Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
Reviewed-by: Chasel Chiu > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: > Remove unused PCD 'PcdUseHpetTimer' > > For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of > them are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is > not being used. > > This commit will remove the above PCD within KabylakeSiliconPkg. > > Cc: Chasel Chiu > Cc: Michael A Kubacki > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 3 +-- > Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > index 92b6d492ee..cca1a2e60d 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > @@ -1,7 +1,7 @@ > ## @file > # Component description file for the Silicon Reference Code. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved. > # > # This program and the accompanying materials are licensed and made available > under # the terms and conditions of the BSD License which accompanies this > distribution. > @@ -592,7 +592,6 @@ [PcdsFeatureFlag] > gSiPkgTokenSpaceGuid.PcdSerialGpioEnable > |FALSE|BOOLEAN|0xF003 > gSiPkgTokenSpaceGuid.PcdAtaEnable > |FALSE|BOOLEAN|0xF004 > gSiPkgTokenSpaceGuid.PcdSiCsmEnable > |FALSE|BOOLEAN|0xF005 > -gSiPkgTokenSpaceGuid.PcdUseHpetTimer > |FALSE|BOOLEAN|0xF006 > gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE > |BOOLEAN|0xF008 > gSiPkgTokenSpaceGuid.PcdAcpiEnable |TRUE > |BOOLEAN|0xF009 > gSiPkgTokenSpaceGuid.PcdSourceDebugEnable > |FALSE|BOOLEAN|0xF00B > diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > index 7189ce6396..cbb2a8bec4 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > @@ -1,7 +1,7 @@ > ## @file > # Component description file for the SkyLake SiPkg DSC file. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved. > # > # This program and the accompanying materials are licensed and made available > under # the terms and conditions of the BSD License which accompanies this > distribution. > @@ -19,7 +19,6 @@ [PcdsFeatureFlag] > gSiPkgTokenSpaceGuid.PcdSerialGpioEnable |FALSE > gSiPkgTokenSpaceGuid.PcdAtaEnable|FALSE > gSiPkgTokenSpaceGuid.PcdSiCsmEnable |FALSE > -gSiPkgTokenSpaceGuid.PcdUseHpetTimer |FALSE > gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE > gSiPkgTokenSpaceGuid.PcdAcpiEnable |FALSE > gSiPkgTokenSpaceGuid.PcdSourceDebugEnable|FALSE > -- > 2.12.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38643): https://edk2.groups.io/g/devel/message/38643 Mute This Topic: https://groups.io/mt/30893898/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38649): https://edk2.groups.io/g/devel/message/38649 Mute This Topic: https://groups.io/mt/30893898/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of them are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not being used. This commit will remove the above PCD within KabylakeSiliconPkg. Cc: Chasel Chiu Cc: Michael A Kubacki Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 3 +-- Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec index 92b6d492ee..cca1a2e60d 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec @@ -1,7 +1,7 @@ ## @file # Component description file for the Silicon Reference Code. # -# Copyright (c) 2017, Intel Corporation. All rights reserved. +# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # # This program and the accompanying materials are licensed and made available under # the terms and conditions of the BSD License which accompanies this distribution. @@ -592,7 +592,6 @@ [PcdsFeatureFlag] gSiPkgTokenSpaceGuid.PcdSerialGpioEnable |FALSE|BOOLEAN|0xF003 gSiPkgTokenSpaceGuid.PcdAtaEnable|FALSE|BOOLEAN|0xF004 gSiPkgTokenSpaceGuid.PcdSiCsmEnable |FALSE|BOOLEAN|0xF005 -gSiPkgTokenSpaceGuid.PcdUseHpetTimer |FALSE|BOOLEAN|0xF006 gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE |BOOLEAN|0xF008 gSiPkgTokenSpaceGuid.PcdAcpiEnable |TRUE |BOOLEAN|0xF009 gSiPkgTokenSpaceGuid.PcdSourceDebugEnable|FALSE|BOOLEAN|0xF00B diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc index 7189ce6396..cbb2a8bec4 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc +++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc @@ -1,7 +1,7 @@ ## @file # Component description file for the SkyLake SiPkg DSC file. # -# Copyright (c) 2017, Intel Corporation. All rights reserved. +# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # # This program and the accompanying materials are licensed and made available under # the terms and conditions of the BSD License which accompanies this distribution. @@ -19,7 +19,6 @@ [PcdsFeatureFlag] gSiPkgTokenSpaceGuid.PcdSerialGpioEnable |FALSE gSiPkgTokenSpaceGuid.PcdAtaEnable|FALSE gSiPkgTokenSpaceGuid.PcdSiCsmEnable |FALSE -gSiPkgTokenSpaceGuid.PcdUseHpetTimer |FALSE gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE gSiPkgTokenSpaceGuid.PcdAcpiEnable |FALSE gSiPkgTokenSpaceGuid.PcdSourceDebugEnable|FALSE -- 2.12.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#34): https://edk2.groups.io/g/devel/message/34 Mute This Topic: https://groups.io/mt/30893898/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
