Re: [edk2-devel] [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.

2019-10-31 Thread Chiu, Chasel 


Agreed. Will rename in V3.

Thanks!
Chasel


> -Original Message-
> From: Kubacki, Michael A 
> Sent: Thursday, October 31, 2019 1:50 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Gao, Liming
> ; Jeremy Soller ; Lu, Shifei A
> ; Zhou, Bowen ; Oram, Isaac
> W ; Wei, David Y ;
> Agyeman, Prince 
> Subject: RE: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.
> 
> Hi Chasel,
> 
> I don't think SetCacheLib is quite precise enough. Can you please consider
> an alternative such as SetMtrrLib?
> 
> Thanks,
> Michael
> 
> > -Original Message-
> > From: Chiu, Chasel 
> > Sent: Wednesday, October 30, 2019 5:30 PM
> > To: devel@edk2.groups.io
> > Cc: Kubacki, Michael A ; Desimone,
> > Nathaniel L ; Gao, Liming
> > ; Jeremy Soller ; Lu,
> > Shifei A ; Zhou, Bowen ;
> > Oram, Isaac W ; Wei, David Y
> > ; Agyeman, Prince 
> > Subject: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
> >
> > The MTRRs may be redundantly or incorrectly configured.
> > It is recommended to move this functionality to a library class that
> > with a NULL library by default. The board package may provide its own
> > library implementation.
> > MinPlatformPkg should contain the library class header (API) and the
> > NULL library class instance.
> >
> > Cc: Michael Kubacki 
> > Cc: Nate DeSimone 
> > Cc: Liming Gao 
> > Cc: Jeremy Soller 
> > Cc: Shifei A Lu 
> > Cc: Xiaohu Zhou 
> > Cc: Isaac W Oram 
> > Cc: Wei David Y 
> > Cc: Agyeman Prince 
> > Signed-off-by: Chasel Chiu 
> >
> > Chasel Chiu (6):
> >   MinPlatformPkg: Add SetCacheLib library class.
> >   MinPlatformPkg: Add SetCacheLib library class.
> >   KabylakeOpenBoardPkg: Add SetCacheLib library class.
> >   WhiskeylakeOpenBoardPkg: Add SetCacheLib library class.
> >   PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class.
> >   SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class.
> >
> >
> > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c   |
> 640
> > --
> > 
> > --
> > 
> > --
> > 
> > --
> > 
> > --
> > 
> > --
> > 
> > --
> > --
> > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c
> > | 325
> > ++
> > ++
> > ++
> > ++
> > ++
> > +++
> >  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c
> > |  37 +
> >
> >
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos
> > tMem.c
> | 149 +-
> > --
> > 
> > -
> >
> >
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> > Mem.c
> | 164 ++
> > --
> > 
> > 
> >  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> > |   3 ++-
> >  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf
> > |   2 +-
> >
> > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf |
> > 67
> > ---
> >  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> > |   1 +
> >  Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h
> > |  34 ++
> >  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf
> > |  44 
> >  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf
> > |  30 ++
> >
> >
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos
> > tMem.inf
> |  11 +--
> >
> >
>

Re: [edk2-devel] [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.

2019-10-30 Thread Kubacki, Michael A 
Hi Chasel,

I don't think SetCacheLib is quite precise enough. Can you please
consider an alternative such as SetMtrrLib?

Thanks,
Michael

> -Original Message-
> From: Chiu, Chasel 
> Sent: Wednesday, October 30, 2019 5:30 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Desimone, Nathaniel
> L ; Gao, Liming ;
> Jeremy Soller ; Lu, Shifei A
> ; Zhou, Bowen ; Oram,
> Isaac W ; Wei, David Y ;
> Agyeman, Prince 
> Subject: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
> 
> The MTRRs may be redundantly or incorrectly configured.
> It is recommended to move this functionality to a library class that with a
> NULL library by default. The board package may provide its own library
> implementation.
> MinPlatformPkg should contain the library class header (API) and the NULL
> library class instance.
> 
> Cc: Michael Kubacki 
> Cc: Nate DeSimone 
> Cc: Liming Gao 
> Cc: Jeremy Soller 
> Cc: Shifei A Lu 
> Cc: Xiaohu Zhou 
> Cc: Isaac W Oram 
> Cc: Wei David Y 
> Cc: Agyeman Prince 
> Signed-off-by: Chasel Chiu 
> 
> Chasel Chiu (6):
>   MinPlatformPkg: Add SetCacheLib library class.
>   MinPlatformPkg: Add SetCacheLib library class.
>   KabylakeOpenBoardPkg: Add SetCacheLib library class.
>   WhiskeylakeOpenBoardPkg: Add SetCacheLib library class.
>   PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class.
>   SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class.
> 
> 
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c   | 640
> --
> --
> --
> --
> --
> --
> 
>  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c
> | 325
> ++
> ++
> ++
> ++
> ++
> +++
>  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c
> |  37 +
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos
> tMem.c  | 149 
> +-
> --
> -
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c   | 164 
> ++
> --
> 
>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> |   3 ++-
>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf
> |   2 +-
> 
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel
> /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf |  67
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> |   1 +
>  Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h
> |  34 ++
>  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf
> |  44 
>  Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf
> |  30 ++
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPos
> tMem.inf|  11 
> +--
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf |   7 ++-
>  Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
> |   3 ++-
>  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> |   1 +
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> g.dsc   |   1 
> +
>  17 files changed, 484 insertions(+), 1035 deletions(-)  delete mode 100644

[edk2-devel] [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class.

2019-10-30 Thread Chiu, Chasel 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314

The MTRRs may be redundantly or incorrectly configured.
It is recommended to move this functionality to a library
class that with a NULL library by default. The board
package may provide its own library implementation.
MinPlatformPkg should contain the library class header (API)
and the NULL library class instance.

Cc: Michael Kubacki 
Cc: Nate DeSimone 
Cc: Liming Gao 
Cc: Jeremy Soller 
Cc: Shifei A Lu 
Cc: Xiaohu Zhou 
Cc: Isaac W Oram 
Cc: Wei David Y 
Cc: Agyeman Prince 
Signed-off-by: Chasel Chiu 

Chasel Chiu (6):
  MinPlatformPkg: Add SetCacheLib library class.
  MinPlatformPkg: Add SetCacheLib library class.
  KabylakeOpenBoardPkg: Add SetCacheLib library class.
  WhiskeylakeOpenBoardPkg: Add SetCacheLib library class.
  PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class.
  SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class.

 
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
   | 640 

 Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c
   | 325 
+
 Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c
   |  37 
+
 
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPostMem.c
  | 149 
+
 
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c 
  | 164 
++--
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
   |   3 ++-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf
   |   2 +-
 
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
 |  67 ---
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc  
   |   1 +
 Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h
   |  34 
++
 Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf  
   |  44 

 Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf  
   |  30 
++
 
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPostMem.inf
|  11 +--
 
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
 |   7 ++-
 Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc   
   |   3 ++-
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc   
   |   1 +
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
   |   1 +
 17 files changed, 484