Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Thank Liming! > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > Sent: Monday, January 15, 2024 1:02 PM > To: Luo, Heng ; devel@edk2.groups.io; Kasbekar, Saloni > ; Clark-williams, Zachary willi...@intel.com>; Kinney, Michael D > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if not connect to AP > > Heng: > This one has been merged. > > Thanks > Liming > > -邮件原件- > > 发件人: Luo, Heng > > 发送时间: 2024年1月15日 11:08 > > 收件人: devel@edk2.groups.io; Luo, Heng ; Gao, > Liming > > ; Kasbekar, Saloni > > ; Clark-williams, Zachary > > ; Kinney, Michael D > > > > 主题: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > > if not connect to AP > > > > Hi Liming & Mike, > > Could you please help to merge PR > > https://github.com/tianocore/edk2/pull/5075 ? > > > > Thanks, > > Heng > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of Heng > > Luo > > > Sent: Tuesday, January 9, 2024 11:17 AM > > > To: Gao, Liming ; devel@edk2.groups.io; > > > Kasbekar, Saloni ; Clark-williams, > > > Zachary ; Kinney, Michael D > > > > > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > scan only > > if > > > not connect to AP > > > > > > HI Liming, > > > All checks have passed in https://github.com/tianocore/edk2/pull/5075. > > What > > > do I need to do? > > > > > > Thanks, > > > Heng > > > > > > > -Original Message- > > > > From: Luo, Heng > > > > Sent: Wednesday, January 3, 2024 1:55 PM > > > > To: gaoliming ; devel@edk2.groups.io; > > > > Kasbekar, Saloni ; Clark-williams, > > > > Zachary ; Kinney, Michael D > > > > > > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > scan only if not connect to AP > > > > > > > > Thank Liming, here is the PR: > > > > https://github.com/tianocore/edk2/pull/5075 > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -Original Message- > > > > > From: gaoliming > > > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > > > To: devel@edk2.groups.io; Luo, Heng ; > > > > > Kasbekar, Saloni ; Clark-williams, > > > > > Zachary > > > > > ; Kinney, Michael D > > > > > > > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger > > > > > regularly scan only if not connect to AP > > > > > > > > > > Heng: > > > > > Can you help create pull request for this patch? Once it pass > > > > > CI, I will merge it. > > > > > > > > > > Thanks > > > > > Liming > > > > > > -邮件原件- > > > > > > 发件人: devel@edk2.groups.io 代表 Heng > > Luo > > > > > > 发送时间: 2024年1月2日 16:55 > > > > > > 收件人: Kasbekar, Saloni ; > > Clark-williams, > > > > > > Zachary ; > > > > > > devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > > > scan only > > > > > if > > > > > > not connect to AP > > > > > > > > > > > > Hi Mike, > > > > > > Would you like to help us merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -Original Message- > > > > > > > From: Kasbekar, Saloni > > > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > > > To: Luo, Heng ; Clark-williams, Zachary > > > > > > > > > > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not > > > > > > connect > > > > > > > to AP > > > > > > > > > > > > > > Mike, > > > > > > > > > > > > > > Would you be a
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Hi Liming & Mike, Could you please help to merge PR https://github.com/tianocore/edk2/pull/5075 ? Thanks, Heng > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Tuesday, January 9, 2024 11:17 AM > To: Gao, Liming ; devel@edk2.groups.io; > Kasbekar, Saloni ; Clark-williams, Zachary > ; Kinney, Michael D > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > HI Liming, > All checks have passed in https://github.com/tianocore/edk2/pull/5075. What > do I need to do? > > Thanks, > Heng > > > -Original Message- > > From: Luo, Heng > > Sent: Wednesday, January 3, 2024 1:55 PM > > To: gaoliming ; devel@edk2.groups.io; > > Kasbekar, Saloni ; Clark-williams, Zachary > > ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > only if not connect to AP > > > > Thank Liming, here is the PR: > > https://github.com/tianocore/edk2/pull/5075 > > > > Thanks, > > Heng > > > > > -Original Message- > > > From: gaoliming > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > To: devel@edk2.groups.io; Luo, Heng ; Kasbekar, > > > Saloni ; Clark-williams, Zachary > > > ; Kinney, Michael D > > > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > scan only if not connect to AP > > > > > > Heng: > > > Can you help create pull request for this patch? Once it pass CI, > > > I will merge it. > > > > > > Thanks > > > Liming > > > > -邮件原件- > > > > 发件人: devel@edk2.groups.io 代表 Heng Luo > > > > 发送时间: 2024年1月2日 16:55 > > > > 收件人: Kasbekar, Saloni ; Clark-williams, > > > > Zachary ; devel@edk2.groups.io; > > > > Kinney, Michael D > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > > only > > > if > > > > not connect to AP > > > > > > > > Hi Mike, > > > > Would you like to help us merge the patch? > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -Original Message- > > > > > From: Kasbekar, Saloni > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > To: Luo, Heng ; Clark-williams, Zachary > > > > > > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not > > > > connect > > > > > to AP > > > > > > > > > > Mike, > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > Thanks, > > > > > Saloni > > > > > > > > > > -Original Message- > > > > > From: Luo, Heng > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > To: Clark-williams, Zachary ; > > > Kasbekar, > > > > > Saloni ; devel@edk2.groups.io > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not > > > > connect > > > > > to AP > > > > > > > > > > Hi Saloni, > > > > > Could you help to merge the patch? > > > > > > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -Original Message- > > > > > > From: Luo, Heng > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > To: Clark-williams, Zachary > > > > > > ; > > > > > > Kasbekar, Saloni ; > > > > > > devel@edk2.groups.io > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not connect to AP > > > > > > > > > > > > Hi Zack, > > > > > > Could you please review the change? > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -Original Message- > > > > > > > From: Kasbekar, Saloni > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > To: Luo, Heng ; devel@edk2.g
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
HI Liming, All checks have passed in https://github.com/tianocore/edk2/pull/5075. What do I need to do? Thanks, Heng > -Original Message- > From: Luo, Heng > Sent: Wednesday, January 3, 2024 1:55 PM > To: gaoliming ; devel@edk2.groups.io; > Kasbekar, Saloni ; Clark-williams, Zachary > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > Thank Liming, here is the PR: > https://github.com/tianocore/edk2/pull/5075 > > Thanks, > Heng > > > -Original Message- > > From: gaoliming > > Sent: Wednesday, January 3, 2024 8:55 AM > > To: devel@edk2.groups.io; Luo, Heng ; Kasbekar, > > Saloni ; Clark-williams, Zachary > > ; Kinney, Michael D > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > only if not connect to AP > > > > Heng: > > Can you help create pull request for this patch? Once it pass CI, I > > will merge it. > > > > Thanks > > Liming > > > -邮件原件- > > > 发件人: devel@edk2.groups.io 代表 Heng Luo > > > 发送时间: 2024年1月2日 16:55 > > > 收件人: Kasbekar, Saloni ; Clark-williams, > > > Zachary ; devel@edk2.groups.io; > > > Kinney, Michael D > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > only > > if > > > not connect to AP > > > > > > Hi Mike, > > > Would you like to help us merge the patch? > > > > > > Thanks, > > > Heng > > > > > > > -Original Message- > > > > From: Kasbekar, Saloni > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > To: Luo, Heng ; Clark-williams, Zachary > > > > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > not > > > connect > > > > to AP > > > > > > > > Mike, > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > Thanks, > > > > Saloni > > > > > > > > -Original Message- > > > > From: Luo, Heng > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > To: Clark-williams, Zachary ; > > Kasbekar, > > > > Saloni ; devel@edk2.groups.io > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > not > > > connect > > > > to AP > > > > > > > > Hi Saloni, > > > > Could you help to merge the patch? > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -Original Message- > > > > > From: Luo, Heng > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > To: Clark-williams, Zachary ; > > > > > Kasbekar, Saloni ; > > > > > devel@edk2.groups.io > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not connect to AP > > > > > > > > > > Hi Zack, > > > > > Could you please review the change? > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -Original Message- > > > > > > From: Kasbekar, Saloni > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > To: Luo, Heng ; devel@edk2.groups.io > > > > > > Cc: Clark-williams, Zachary > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not connect to AP > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni > > > > > > > > > > > > Thanks, > > > > > > Saloni > > > > > > > > > > > > -Original Message- > > > > > > From: Luo, Heng > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Kasbekar, Saloni ; > > > > > > Clark-williams, Zachary > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > > > not connect to AP > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > &
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Thank Liming, here is the PR:
https://github.com/tianocore/edk2/pull/5075
Thanks,
Heng
> -Original Message-
> From: gaoliming
> Sent: Wednesday, January 3, 2024 8:55 AM
> To: devel@edk2.groups.io; Luo, Heng ; Kasbekar, Saloni
> ; Clark-williams, Zachary willi...@intel.com>; Kinney, Michael D
> Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only
> if not connect to AP
>
> Heng:
> Can you help create pull request for this patch? Once it pass CI, I will
> merge
> it.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Heng Luo
> > 发送时间: 2024年1月2日 16:55
> > 收件人: Kasbekar, Saloni ; Clark-williams,
> > Zachary ; devel@edk2.groups.io;
> > Kinney, Michael D
> > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only
> if
> > not connect to AP
> >
> > Hi Mike,
> > Would you like to help us merge the patch?
> >
> > Thanks,
> > Heng
> >
> > > -Original Message-
> > > From: Kasbekar, Saloni
> > > Sent: Friday, December 15, 2023 4:36 AM
> > > To: Luo, Heng ; Clark-williams, Zachary
> > > > willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> > >
> > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > not
> > connect
> > > to AP
> > >
> > > Mike,
> > >
> > > Would you be able to help us merge the patch?
> > >
> > > Thanks,
> > > Saloni
> > >
> > > -Original Message-
> > > From: Luo, Heng
> > > Sent: Thursday, December 14, 2023 3:20 AM
> > > To: Clark-williams, Zachary ;
> Kasbekar,
> > > Saloni ; devel@edk2.groups.io
> > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > not
> > connect
> > > to AP
> > >
> > > Hi Saloni,
> > > Could you help to merge the patch?
> > >
> > > Thanks,
> > > Heng
> > >
> > > > -Original Message-
> > > > From: Luo, Heng
> > > > Sent: Monday, December 11, 2023 4:13 PM
> > > > To: Clark-williams, Zachary ;
> > > > Kasbekar, Saloni ; devel@edk2.groups.io
> > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > > not connect to AP
> > > >
> > > > Hi Zack,
> > > > Could you please review the change?
> > > > Thanks,
> > > > Heng
> > > >
> > > > > -Original Message-
> > > > > From: Kasbekar, Saloni
> > > > > Sent: Saturday, December 2, 2023 5:25 AM
> > > > > To: Luo, Heng ; devel@edk2.groups.io
> > > > > Cc: Clark-williams, Zachary
> > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > if not connect to AP
> > > > >
> > > > > Reviewed-by: Kasbekar, Saloni
> > > > >
> > > > > Thanks,
> > > > > Saloni
> > > > >
> > > > > -Original Message-
> > > > > From: Luo, Heng
> > > > > Sent: Monday, November 27, 2023 7:07 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Kasbekar, Saloni ;
> > > > > Clark-williams, Zachary
> > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > > > not connect to AP
> > > > >
> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> > > > >
> > > > > When UEFI Wi-Fi is in BSS connected state, the platform is
> > > > > considered as a static and Wi-Fi roaming support is not needed.
> > > > > Wifi connection manager should not initiate Scan requests in
> > > > > this state affect BSS client connectivity and must be avoided.
> > > > > Triger regularly scan only if not connect to AP.
> > > > >
> > > > > Signed-off-by: Heng Luo
> > > > > Cc: Saloni Kasbekar
> > > > > Cc: Zachary Clark-williams
> > > > > ---
> > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c |
> > 4
> > > ++-
> > > > -
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > index d1182e52bd..4c5460b65c 100644
> > > > > ---
> > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > +++
> > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> > > > >}Nic->ScanTickTime++;- if (((Nic->ScanTickTime >
> > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&-
> > (Nic-
> > > > > >ScanState == WifiMgrScanFinished))+ if Nic->ScanTickTime >
> > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> > > > WifiMgrConnectedToAp))
> > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE;
> > Nic-
> > > > > >ScanTickTime = 0;--
> > > > > 2.31.1.windows.1
> >
> >
> >
> >
> >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113058): https://edk2.groups.io/g/devel/message/113058
Mute This Topic: https://groups.io/mt/103497585/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Hi Mike,
Would you like to help us merge the patch?
Thanks,
Heng
> -Original Message-
> From: Kasbekar, Saloni
> Sent: Friday, December 15, 2023 4:36 AM
> To: Luo, Heng ; Clark-williams, Zachary willi...@intel.com>; devel@edk2.groups.io; Kinney, Michael D
>
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect
> to AP
>
> Mike,
>
> Would you be able to help us merge the patch?
>
> Thanks,
> Saloni
>
> -Original Message-
> From: Luo, Heng
> Sent: Thursday, December 14, 2023 3:20 AM
> To: Clark-williams, Zachary ; Kasbekar,
> Saloni ; devel@edk2.groups.io
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect
> to AP
>
> Hi Saloni,
> Could you help to merge the patch?
>
> Thanks,
> Heng
>
> > -Original Message-
> > From: Luo, Heng
> > Sent: Monday, December 11, 2023 4:13 PM
> > To: Clark-williams, Zachary ;
> > Kasbekar, Saloni ; devel@edk2.groups.io
> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not
> > connect to AP
> >
> > Hi Zack,
> > Could you please review the change?
> > Thanks,
> > Heng
> >
> > > -Original Message-
> > > From: Kasbekar, Saloni
> > > Sent: Saturday, December 2, 2023 5:25 AM
> > > To: Luo, Heng ; devel@edk2.groups.io
> > > Cc: Clark-williams, Zachary
> > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > not connect to AP
> > >
> > > Reviewed-by: Kasbekar, Saloni
> > >
> > > Thanks,
> > > Saloni
> > >
> > > -Original Message-
> > > From: Luo, Heng
> > > Sent: Monday, November 27, 2023 7:07 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kasbekar, Saloni ; Clark-williams,
> > > Zachary
> > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not
> > > connect to AP
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> > >
> > > When UEFI Wi-Fi is in BSS connected state, the platform is
> > > considered as a static and Wi-Fi roaming support is not needed.
> > > Wifi connection manager should not initiate Scan requests in this
> > > state affect BSS client connectivity and must be avoided.
> > > Triger regularly scan only if not connect to AP.
> > >
> > > Signed-off-by: Heng Luo
> > > Cc: Saloni Kasbekar
> > > Cc: Zachary Clark-williams
> > > ---
> > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4
> ++-
> > -
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > index d1182e52bd..4c5460b65c 100644
> > > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > +++
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> > >}Nic->ScanTickTime++;- if (((Nic->ScanTickTime >
> > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic-
> > > >ScanState == WifiMgrScanFinished))+ if Nic->ScanTickTime >
> > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> > WifiMgrConnectedToAp))
> > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic-
> > > >ScanTickTime = 0;--
> > > 2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113031): https://edk2.groups.io/g/devel/message/113031
Mute This Topic: https://groups.io/mt/102844565/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Mike,
Would you be able to help us merge the patch?
Thanks,
Saloni
-Original Message-
From: Luo, Heng
Sent: Thursday, December 14, 2023 3:20 AM
To: Clark-williams, Zachary ; Kasbekar,
Saloni ; devel@edk2.groups.io
Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect
to AP
Hi Saloni,
Could you help to merge the patch?
Thanks,
Heng
> -Original Message-
> From: Luo, Heng
> Sent: Monday, December 11, 2023 4:13 PM
> To: Clark-williams, Zachary ;
> Kasbekar, Saloni ; devel@edk2.groups.io
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not
> connect to AP
>
> Hi Zack,
> Could you please review the change?
> Thanks,
> Heng
>
> > -Original Message-
> > From: Kasbekar, Saloni
> > Sent: Saturday, December 2, 2023 5:25 AM
> > To: Luo, Heng ; devel@edk2.groups.io
> > Cc: Clark-williams, Zachary
> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > not connect to AP
> >
> > Reviewed-by: Kasbekar, Saloni
> >
> > Thanks,
> > Saloni
> >
> > -Original Message-
> > From: Luo, Heng
> > Sent: Monday, November 27, 2023 7:07 PM
> > To: devel@edk2.groups.io
> > Cc: Kasbekar, Saloni ; Clark-williams,
> > Zachary
> > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not
> > connect to AP
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> >
> > When UEFI Wi-Fi is in BSS connected state, the platform is
> > considered as a static and Wi-Fi roaming support is not needed.
> > Wifi connection manager should not initiate Scan requests in this
> > state affect BSS client connectivity and must be avoided.
> > Triger regularly scan only if not connect to AP.
> >
> > Signed-off-by: Heng Luo
> > Cc: Saloni Kasbekar
> > Cc: Zachary Clark-williams
> > ---
> > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-
> -
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > index d1182e52bd..4c5460b65c 100644
> > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> >}Nic->ScanTickTime++;- if (((Nic->ScanTickTime >
> > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic-
> > >ScanState == WifiMgrScanFinished))+ if Nic->ScanTickTime >
> > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> WifiMgrConnectedToAp))
> > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic-
> > >ScanTickTime = 0;--
> > 2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112548): https://edk2.groups.io/g/devel/message/112548
Mute This Topic: https://groups.io/mt/102844565/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Hi Saloni,
Could you help to merge the patch?
Thanks,
Heng
> -Original Message-
> From: Luo, Heng
> Sent: Monday, December 11, 2023 4:13 PM
> To: Clark-williams, Zachary ; Kasbekar,
> Saloni ; devel@edk2.groups.io
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect
> to AP
>
> Hi Zack,
> Could you please review the change?
> Thanks,
> Heng
>
> > -Original Message-
> > From: Kasbekar, Saloni
> > Sent: Saturday, December 2, 2023 5:25 AM
> > To: Luo, Heng ; devel@edk2.groups.io
> > Cc: Clark-williams, Zachary
> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not
> > connect to AP
> >
> > Reviewed-by: Kasbekar, Saloni
> >
> > Thanks,
> > Saloni
> >
> > -Original Message-
> > From: Luo, Heng
> > Sent: Monday, November 27, 2023 7:07 PM
> > To: devel@edk2.groups.io
> > Cc: Kasbekar, Saloni ; Clark-williams,
> > Zachary
> > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not
> > connect to AP
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> >
> > When UEFI Wi-Fi is in BSS connected state, the platform is considered
> > as a static and Wi-Fi roaming support is not needed.
> > Wifi connection manager should not initiate Scan requests in this
> > state affect BSS client connectivity and must be avoided.
> > Triger regularly scan only if not connect to AP.
> >
> > Signed-off-by: Heng Luo
> > Cc: Saloni Kasbekar
> > Cc: Zachary Clark-williams
> > ---
> > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-
> -
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > index d1182e52bd..4c5460b65c 100644
> > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> >}Nic->ScanTickTime++;- if (((Nic->ScanTickTime >
> > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic-
> > >ScanState == WifiMgrScanFinished))+ if Nic->ScanTickTime >
> > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> WifiMgrConnectedToAp))
> > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic-
> > >ScanTickTime = 0;--
> > 2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112521): https://edk2.groups.io/g/devel/message/112521
Mute This Topic: https://groups.io/mt/102844565/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Hi Zack,
Could you please review the change?
Thanks,
Heng
> -Original Message-
> From: Kasbekar, Saloni
> Sent: Saturday, December 2, 2023 5:25 AM
> To: Luo, Heng ; devel@edk2.groups.io
> Cc: Clark-williams, Zachary
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect
> to AP
>
> Reviewed-by: Kasbekar, Saloni
>
> Thanks,
> Saloni
>
> -Original Message-
> From: Luo, Heng
> Sent: Monday, November 27, 2023 7:07 PM
> To: devel@edk2.groups.io
> Cc: Kasbekar, Saloni ; Clark-williams, Zachary
>
> Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to
> AP
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
>
> When UEFI Wi-Fi is in BSS connected state, the platform is considered as a
> static and Wi-Fi roaming support is not needed.
> Wifi connection manager should not initiate Scan requests in this state affect
> BSS client connectivity and must be avoided.
> Triger regularly scan only if not connect to AP.
>
> Signed-off-by: Heng Luo
> Cc: Saloni Kasbekar
> Cc: Zachary Clark-williams
> ---
> NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> index d1182e52bd..4c5460b65c 100644
> --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
>}Nic->ScanTickTime++;- if (((Nic->ScanTickTime >
> WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic-
> >ScanState == WifiMgrScanFinished))+ if Nic->ScanTickTime >
> WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != WifiMgrConnectedToAp))
> ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
> WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic-
> >ScanTickTime = 0;--
> 2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112272): https://edk2.groups.io/g/devel/message/112272
Mute This Topic: https://groups.io/mt/102844565/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Reviewed-by: Kasbekar, Saloni
Thanks,
Saloni
-Original Message-
From: Luo, Heng
Sent: Monday, November 27, 2023 7:07 PM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Clark-williams, Zachary
Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
When UEFI Wi-Fi is in BSS connected state, the platform is considered as a
static and Wi-Fi roaming support is not needed.
Wifi connection manager should not initiate Scan requests in this state affect
BSS client connectivity and must be avoided.
Triger regularly scan only if not connect to AP.
Signed-off-by: Heng Luo
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
---
NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
index d1182e52bd..4c5460b65c 100644
--- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
+++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
@@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
}Nic->ScanTickTime++;- if (((Nic->ScanTickTime > WIFI_SCAN_FREQUENCY)
|| Nic->OneTimeScanRequest) &&- (Nic->ScanState == WifiMgrScanFinished))+
if Nic->ScanTickTime > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
WifiMgrConnectedToAp)) ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE;
Nic->ScanTickTime = 0;--
2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111987): https://edk2.groups.io/g/devel/message/111987
Mute This Topic: https://groups.io/mt/102844565/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
