Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
On 3/8/24 10:13, Laszlo Ersek wrote: > On 3/5/24 12:38, Laszlo Ersek wrote: >> Bugzillas: >> - https://bugzilla.tianocore.org/show_bug.cgi?id=990 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=991 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 >> >> CI: >> - https://github.com/tianocore/edk2/pull/5442 >> >> Branch: >> - >> https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2 >> >> This patch series puts the recent BaseTools feature to use in which >> AutoGen generates the ProcessLibraryConstructorList() declaration in >> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at >> least 1.30. The BaseTools feature is present in both edk2 [1] and >> edk2-basetools [2], and has been documented in the Build spec [3] and >> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools >> release [5] [6] with the new feature. >> >> [1] edk2 commit bac9c74080cf >> [2] edk2-basetools commit 5b7161de22ee >> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199 >> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe >> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51 >> [6] https://pypi.org/project/edk2-basetools/0.1.51/ >> >> The edk2-basetools part is adopted in the first patch (for >> "pip-requirements.txt"). >> >> The rest of the patches clean up -- superfluous, or even incorrect -- >> ProcessLibraryConstructorList() declarations (and, in some cases, >> incorrect calls), together with raising the INF_VERSIONs in the related >> SEC module INF files to 1.30. >> >> Comparing this version to v1 is not useful, as the compatibility >> approach is different, and so this version is structured differently. >> Please review any patches for your subsystem from scratch (they are not >> difficult or large). >> >> Cc: Andrei Warkentin >> Cc: Andrew Fish >> Cc: Ard Biesheuvel >> Cc: Ashraf Ali S >> Cc: Bob Feng >> Cc: Catharine West >> Cc: Chasel Chiu >> Cc: Duggapu Chinni B >> Cc: Erdem Aktas >> Cc: Gerd Hoffmann >> Cc: Gua Guo >> Cc: Guo Dong >> Cc: James Lu >> Cc: Jiewen Yao >> Cc: Joey Vagedes >> Cc: Leif Lindholm >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Michael Roth >> Cc: Min Xu >> Cc: Nate DeSimone >> Cc: Rahul Kumar >> Cc: Ray Ni >> Cc: Rebecca Cran >> Cc: Sami Mujawar >> Cc: Sean Brogan >> Cc: Sean Rhodes >> Cc: Star Zeng >> Cc: Sunil V L >> Cc: Susovan Mohapatra >> Cc: Ted Kuo >> Cc: Tom Lendacky >> Cc: Yuwei Chen >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (10): >> pip-requirements.txt: require edk2-basetools version 0.1.51 >> OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() >> decl >> OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() >> decl >> OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl >> ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl >> UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> >> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 -- >> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- >> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- >> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- >> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- >> ArmPlatformPkg/PrePi/PrePi.h | 6 -- >> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- >> ArmVirtPkg/PrePi/PrePi.c | 6 -- >> EmulatorPkg/Sec/Sec.h| 9 - >> EmulatorPkg/Sec/Sec.inf | 2 +- >> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf| 2 +- >> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +- >> IntelFsp2Pkg/FspSecCore/SecMain.h| 12 >> >> OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +-- >> OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +- >> OvmfPkg/RiscVVirt/Sec/Memory.c | 1 - >> OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 >> >> OvmfPkg/RiscVVirt/Sec/SecMain.inf| 2 +- >> OvmfPkg/Sec/SecMain.c| 3 +-- >> OvmfPkg/Sec/SecMain.inf | 2 +- >> UefiCpuPkg/SecCore/SecCore.inf | 2 +- >> UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- >> UefiCpuPkg/SecCore/SecMain.h
Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
On 3/5/24 12:38, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 > > Branch: > - > https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at > least 1.30. The BaseTools feature is present in both edk2 [1] and > edk2-basetools [2], and has been documented in the Build spec [3] and > the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools > release [5] [6] with the new feature. > > [1] edk2 commit bac9c74080cf > [2] edk2-basetools commit 5b7161de22ee > [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199 > [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe > [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51 > [6] https://pypi.org/project/edk2-basetools/0.1.51/ > > The edk2-basetools part is adopted in the first patch (for > "pip-requirements.txt"). > > The rest of the patches clean up -- superfluous, or even incorrect -- > ProcessLibraryConstructorList() declarations (and, in some cases, > incorrect calls), together with raising the INF_VERSIONs in the related > SEC module INF files to 1.30. > > Comparing this version to v1 is not useful, as the compatibility > approach is different, and so this version is structured differently. > Please review any patches for your subsystem from scratch (they are not > difficult or large). > > Cc: Andrei Warkentin > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Ashraf Ali S > Cc: Bob Feng > Cc: Catharine West > Cc: Chasel Chiu > Cc: Duggapu Chinni B > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: Gua Guo > Cc: Guo Dong > Cc: James Lu > Cc: Jiewen Yao > Cc: Joey Vagedes > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Michael Roth > Cc: Min Xu > Cc: Nate DeSimone > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Rebecca Cran > Cc: Sami Mujawar > Cc: Sean Brogan > Cc: Sean Rhodes > Cc: Star Zeng > Cc: Sunil V L > Cc: Susovan Mohapatra > Cc: Ted Kuo > Cc: Tom Lendacky > Cc: Yuwei Chen > > Thanks, > Laszlo > > Laszlo Ersek (10): > pip-requirements.txt: require edk2-basetools version 0.1.51 > OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() > decl > OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() > decl > OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl > ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl > ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl > EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl > IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl > UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl > UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl > > ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 -- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PrePi.h | 6 -- > ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- > ArmVirtPkg/PrePi/PrePi.c | 6 -- > EmulatorPkg/Sec/Sec.h| 9 - > EmulatorPkg/Sec/Sec.inf | 2 +- > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf| 2 +- > IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +- > IntelFsp2Pkg/FspSecCore/SecMain.h| 12 > > OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +-- > OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +- > OvmfPkg/RiscVVirt/Sec/Memory.c | 1 - > OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 > > OvmfPkg/RiscVVirt/Sec/SecMain.inf| 2 +- > OvmfPkg/Sec/SecMain.c| 3 +-- > OvmfPkg/Sec/SecMain.inf | 2 +- > UefiCpuPkg/SecCore/SecCore.inf | 2 +- > UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- > UefiCpuPkg/SecCore/SecMain.h | 12 > > UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- >
Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
On Tue, Mar 05, 2024 at 12:38:33PM +0100, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 > > Branch: > - > https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at > least 1.30. The BaseTools feature is present in both edk2 [1] and > edk2-basetools [2], and has been documented in the Build spec [3] and > the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools > release [5] [6] with the new feature. Series: Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116477): https://edk2.groups.io/g/devel/message/116477 Mute This Topic: https://groups.io/mt/104742520/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
For OvmfPkg, reviewed-by: Jiewen Yao > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, March 5, 2024 7:39 PM > To: edk2-devel-groups-io > Cc: Warkentin, Andrei ; Andrew Fish > ; Ard Biesheuvel ; S, Ashraf Ali > ; Feng, Bob C ; West, Catharine > ; Chiu, Chasel ; Duggapu, > Chinni B ; Aktas, Erdem > ; Gerd Hoffmann ; Guo, Gua > ; Dong, Guo ; Lu, James > ; Yao, Jiewen ; Joey Vagedes > ; Leif Lindholm ; Liming > Gao ; Kinney, Michael D > ; Michael Roth ; Xu, Min > M ; Desimone, Nathaniel L > ; Kumar, Rahul R ; > Ni, Ray ; Rebecca Cran ; Sami Mujawar > ; Sean Brogan ; > Rhodes, Sean ; Zeng, Star ; Sunil > V L ; Mohapatra, Susovan > ; Kuo, Ted ; Tom Lendacky > ; Chen, Christine > Subject: [PATCH v2 00/10] clean up ProcessLibraryConstructorList() > declarations > in SEC modules > > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 > > Branch: > - https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990- > 991-v2 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at > least 1.30. The BaseTools feature is present in both edk2 [1] and > edk2-basetools [2], and has been documented in the Build spec [3] and > the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools > release [5] [6] with the new feature. > > [1] edk2 commit bac9c74080cf > [2] edk2-basetools commit 5b7161de22ee > [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199 > [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe > [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51 > [6] https://pypi.org/project/edk2-basetools/0.1.51/ > > The edk2-basetools part is adopted in the first patch (for > "pip-requirements.txt"). > > The rest of the patches clean up -- superfluous, or even incorrect -- > ProcessLibraryConstructorList() declarations (and, in some cases, > incorrect calls), together with raising the INF_VERSIONs in the related > SEC module INF files to 1.30. > > Comparing this version to v1 is not useful, as the compatibility > approach is different, and so this version is structured differently. > Please review any patches for your subsystem from scratch (they are not > difficult or large). > > Cc: Andrei Warkentin > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Ashraf Ali S > Cc: Bob Feng > Cc: Catharine West > Cc: Chasel Chiu > Cc: Duggapu Chinni B > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: Gua Guo > Cc: Guo Dong > Cc: James Lu > Cc: Jiewen Yao > Cc: Joey Vagedes > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Michael Roth > Cc: Min Xu > Cc: Nate DeSimone > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Rebecca Cran > Cc: Sami Mujawar > Cc: Sean Brogan > Cc: Sean Rhodes > Cc: Star Zeng > Cc: Sunil V L > Cc: Susovan Mohapatra > Cc: Ted Kuo > Cc: Tom Lendacky > Cc: Yuwei Chen > > Thanks, > Laszlo > > Laszlo Ersek (10): > pip-requirements.txt: require edk2-basetools version 0.1.51 > OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() > decl > OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() > decl > OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl > ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl > ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl > EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl > IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl > UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl > UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl > > ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 -- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PrePi.h | 6 -- > ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- > ArmVirtPkg/PrePi/PrePi.c | 6 -- > EmulatorPkg/Sec/Sec.h| 9 - > EmulatorPkg/Sec/Sec.inf | 2 +- > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf| 2 +- > IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +- > IntelFsp2Pkg/FspSecCore/SecMain.h| 12 > > OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +--
