Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
On 2019.10.21 15:39, Leif Lindholm wrote: On Mon, Oct 21, 2019 at 03:28:37PM +0100, Pete Batard wrote: Hi Leif, On 2019.10.21 14:46, Leif Lindholm wrote: On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote: On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: If anything, I guess we could consider that the non-osi patch should come first. Still, whatever we do here, as long as only one of non-osi and platform is applied, builds are going to be broken, and there is no way to fix that unless you do consider the set of platforms + non-osi as a single patch. Agreed, this is a egg/chicken problem. I dealt with this in the past by just making sure the non-osi and platform changes are applied at the same time. So it is good to make note of this in the cover letter, but other than that, there is no way we can apply interdependent changes to two separate repositories at the same time without either breaking bisect for one of them, or making a huge effort to add temporary code, defines etc that will be removed again right after the changes have landed. Agreed. My preference would be to treat edk2-non-osi as the chicken, and edk2-platforms the egg. I could put the requisite edk2-non-osi hash into the edk2-platforms commit message before pushing, adding a line like: "This commit requires the edk2-non-osi in use to contain commit in order to build." If I'm feeling nitpicky, that could replace the comment "No other changes are being applied at this stage." Pete: would you be OK with those two changes? Sounds good. Feel free to go ahead with these changes, thanks. In that case: Reviewed-by: Leif Lindholm Pushed as 03f36b8fcfb7. Thanks! Great, thanks! Do you know when the Pi4 upstreaming is likely to start? Well, as opposed to what was the case for the Pi 3 when we started upstreaming, we don't have a fully working Pi 4 platform yet (or at least, there's a fair amount of work left before we can put a checkmark against all the major elements we would like to see checked). So what we'll probably be aiming at is figure out some kind of minimum viable platform that can be officially submitted, that may not do much, but that we can then build upon in a more public and official manner. Now, since there are quite a few people involved on this one, and we need to discuss this internally, I doubt we're going to start publicly submitting anything Pi 4 related before one week at least. Figuring out what we want to submit, or even if we're truly at a stage where we have something proper to submit, is the current next step for us, as we wanted to make sure mainline was okay with the structure we are planning to go with before moving further (which makes the quick turnover on this patchset much appreciated!). For the record, we have a couple of staging repos at: https://github.com/samerhaj/edk2-platforms/tree/pi4_staging https://github.com/samerhaj/edk2-non-osi/tree/pi4_staging as well as Andrei Warkentin's main development tree (over which the repos above are based) at: https://github.com/andreiw/lampone-edk2-platforms/commits/pi4-hack https://github.com/andreiw/lampone-edk2-platforms/commits/master Of course, these are very much WIP still, and not something we can use to generate a patchset from. At this stage, I would say that our biggest issue, apart from various drivers not being finalized, is that mainline ARM Trusted Firmware has recently integrated support for the Pi 4 in a way that is completely different from what we went for (because there was no Trusted Firmware to start with, Andrei had to figure out his own, which was based on extending the Pi 3's). For starters they went for a BL31 only approach: https://github.com/ARM-software/arm-trusted-firmware/commit/f5cb15b0c886afaa41c5d3dad8e859b6a41f76ab. This means that, depending on how complex it might be to retrofit official ATF, we may submit an initial patchset that relies on our own binaries, and leave the switching to official ATF done at a later date... As you may have seen from my autoresponder, I'm traveling this week and next. Yes. We'll take that into account. I believe you might also meet with Samer (El-Haj-Mahmoud), who is participating in the Pi 4 porting effort (the first repos above are his). So feel free to ask for his views as well. I guess I'll wish you some pleasant and safe travels then. Regards, /Pete -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49317): https://edk2.groups.io/g/devel/message/49317 Mute This Topic: https://groups.io/mt/36312720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
On Mon, Oct 21, 2019 at 03:28:37PM +0100, Pete Batard wrote: > Hi Leif, > > On 2019.10.21 14:46, Leif Lindholm wrote: > > On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote: > > > On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé > > > wrote: > > > > > If anything, I guess we could consider that the non-osi patch should > > > > > come first. Still, whatever we do here, as long as only one of non-osi > > > > > and platform is applied, builds are going to be broken, and there is > > > > > no > > > > > way to fix that unless you do consider the set of platforms + non-osi > > > > > as > > > > > a single patch. > > > > > > > > Agreed, this is a egg/chicken problem. > > > > > > I dealt with this in the past by just making sure the non-osi and > > > platform changes are applied at the same time. So it is good to make > > > note of this in the cover letter, but other than that, there is no way > > > we can apply interdependent changes to two separate repositories at > > > the same time without either breaking bisect for one of them, or > > > making a huge effort to add temporary code, defines etc that will be > > > removed again right after the changes have landed. > > > > Agreed. My preference would be to treat edk2-non-osi as the chicken, > > and edk2-platforms the egg. I could put the requisite edk2-non-osi > > hash into the edk2-platforms commit message before pushing, adding a > > line like: > > > > "This commit requires the edk2-non-osi in use to contain commit > > in order to build." > > > > If I'm feeling nitpicky, that could replace the comment > > "No other changes are being applied at this stage." > > > > Pete: would you be OK with those two changes? > > Sounds good. Feel free to go ahead with these changes, thanks. In that case: Reviewed-by: Leif Lindholm Pushed as 03f36b8fcfb7. Thanks! Do you know when the Pi4 upstreaming is likely to start? As you may have seen from my autoresponder, I'm traveling this week and next. Best Regards, Leif (from the backseat of a car going down the M25) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49307): https://edk2.groups.io/g/devel/message/49307 Mute This Topic: https://groups.io/mt/36312720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
Hi Leif, On 2019.10.21 14:46, Leif Lindholm wrote: On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote: On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: On 10/21/19 2:52 PM, Pete Batard wrote: Hi Philippe, On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote: Hi Pete, On 10/21/19 1:25 PM, Pete Batard wrote: In preparation for adding Raspberry Pi 4 support, the Pi 3 platform is restructured by factorizing all the drivers and libraries that are going to be commonly used by the two platforms. Because much of the Pi 4 SoC is an extension of the Pi 3 one this means that almost everything, except the ACPI tables, is moved up into a new common RaspberryPi/ subdirectory that will serve both platforms. The .dec is also moved to this directory, under a new RaspberryPi.dec name, and existing references to it are updated. ... This change seems not related to the rest of your refactor. It is. See https://edk2.groups.io/g/devel/message/49288 The problem is we have no choice but to break the patch in two sections, one that applies to edk2-platforms and the other to edk2-non-osi, since these are separate repos, and the LogoDxe changes belong to non-osi. We need to have part of the non-osi patch that is applied to edk2-platforms, and it would make little sense to break it down into the non-osi related and platforms related, since it still relies on the non-osi changes having been applied. I see. If anything, I guess we could consider that the non-osi patch should come first. Still, whatever we do here, as long as only one of non-osi and platform is applied, builds are going to be broken, and there is no way to fix that unless you do consider the set of platforms + non-osi as a single patch. Agreed, this is a egg/chicken problem. I dealt with this in the past by just making sure the non-osi and platform changes are applied at the same time. So it is good to make note of this in the cover letter, but other than that, there is no way we can apply interdependent changes to two separate repositories at the same time without either breaking bisect for one of them, or making a huge effort to add temporary code, defines etc that will be removed again right after the changes have landed. Agreed. My preference would be to treat edk2-non-osi as the chicken, and edk2-platforms the egg. I could put the requisite edk2-non-osi hash into the edk2-platforms commit message before pushing, adding a line like: "This commit requires the edk2-non-osi in use to contain commit in order to build." If I'm feeling nitpicky, that could replace the comment "No other changes are being applied at this stage." Pete: would you be OK with those two changes? Sounds good. Feel free to go ahead with these changes, thanks. /Pete Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49305): https://edk2.groups.io/g/devel/message/49305 Mute This Topic: https://groups.io/mt/36312720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote: > On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé > wrote: > > > > On 10/21/19 2:52 PM, Pete Batard wrote: > > > Hi Philippe, > > > > > > On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote: > > >> Hi Pete, > > >> > > >> On 10/21/19 1:25 PM, Pete Batard wrote: > > >>> In preparation for adding Raspberry Pi 4 support, the Pi 3 platform > > >>> is restructured by factorizing all the drivers and libraries that are > > >>> going to be commonly used by the two platforms. > > >>> > > >>> Because much of the Pi 4 SoC is an extension of the Pi 3 one this > > >>> means that almost everything, except the ACPI tables, is moved up > > >>> into a new common RaspberryPi/ subdirectory that will serve both > > >>> platforms. The .dec is also moved to this directory, under a new > > >>> RaspberryPi.dec name, and existing references to it are updated. > > >>> > ... > > >> > > >> This change seems not related to the rest of your refactor. > > > > > > It is. See https://edk2.groups.io/g/devel/message/49288 > > > > > > The problem is we have no choice but to break the patch in two sections, > > > one that applies to edk2-platforms and the other to edk2-non-osi, since > > > these are separate repos, and the LogoDxe changes belong to non-osi. > > > > > > We need to have part of the non-osi patch that is applied to > > > edk2-platforms, and it would make little sense to break it down into the > > > non-osi related and platforms related, since it still relies on the > > > non-osi changes having been applied. > > > > I see. > > > > > > > > If anything, I guess we could consider that the non-osi patch should > > > come first. Still, whatever we do here, as long as only one of non-osi > > > and platform is applied, builds are going to be broken, and there is no > > > way to fix that unless you do consider the set of platforms + non-osi as > > > a single patch. > > > > Agreed, this is a egg/chicken problem. > > > > I dealt with this in the past by just making sure the non-osi and > platform changes are applied at the same time. So it is good to make > note of this in the cover letter, but other than that, there is no way > we can apply interdependent changes to two separate repositories at > the same time without either breaking bisect for one of them, or > making a huge effort to add temporary code, defines etc that will be > removed again right after the changes have landed. Agreed. My preference would be to treat edk2-non-osi as the chicken, and edk2-platforms the egg. I could put the requisite edk2-non-osi hash into the edk2-platforms commit message before pushing, adding a line like: "This commit requires the edk2-non-osi in use to contain commit in order to build." If I'm feeling nitpicky, that could replace the comment "No other changes are being applied at this stage." Pete: would you be OK with those two changes? Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49301): https://edk2.groups.io/g/devel/message/49301 Mute This Topic: https://groups.io/mt/36312720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
Hi Ard, On 2019.10.21 14:24, Ard Biesheuvel wrote: On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: On 10/21/19 2:52 PM, Pete Batard wrote: Hi Philippe, On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote: Hi Pete, On 10/21/19 1:25 PM, Pete Batard wrote: In preparation for adding Raspberry Pi 4 support, the Pi 3 platform is restructured by factorizing all the drivers and libraries that are going to be commonly used by the two platforms. Because much of the Pi 4 SoC is an extension of the Pi 3 one this means that almost everything, except the ACPI tables, is moved up into a new common RaspberryPi/ subdirectory that will serve both platforms. The .dec is also moved to this directory, under a new RaspberryPi.dec name, and existing references to it are updated. ... This change seems not related to the rest of your refactor. It is. See https://edk2.groups.io/g/devel/message/49288 The problem is we have no choice but to break the patch in two sections, one that applies to edk2-platforms and the other to edk2-non-osi, since these are separate repos, and the LogoDxe changes belong to non-osi. We need to have part of the non-osi patch that is applied to edk2-platforms, and it would make little sense to break it down into the non-osi related and platforms related, since it still relies on the non-osi changes having been applied. I see. If anything, I guess we could consider that the non-osi patch should come first. Still, whatever we do here, as long as only one of non-osi and platform is applied, builds are going to be broken, and there is no way to fix that unless you do consider the set of platforms + non-osi as a single patch. Agreed, this is a egg/chicken problem. I dealt with this in the past by just making sure the non-osi and platform changes are applied at the same time. So it is good to make note of this in the cover letter, That is good advice. I'll make sure to follow that next time I have a non-osi + platforms dual patchset to submit, as it should indeed ease the review process. Regards, /Pete but other than that, there is no way we can apply interdependent changes to two separate repositories at the same time without either breaking bisect for one of them, or making a huge effort to add temporary code, defines etc that will be removed again right after the changes have landed. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49299): https://edk2.groups.io/g/devel/message/49299 Mute This Topic: https://groups.io/mt/36312720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: > > On 10/21/19 2:52 PM, Pete Batard wrote: > > Hi Philippe, > > > > On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote: > >> Hi Pete, > >> > >> On 10/21/19 1:25 PM, Pete Batard wrote: > >>> In preparation for adding Raspberry Pi 4 support, the Pi 3 platform > >>> is restructured by factorizing all the drivers and libraries that are > >>> going to be commonly used by the two platforms. > >>> > >>> Because much of the Pi 4 SoC is an extension of the Pi 3 one this > >>> means that almost everything, except the ACPI tables, is moved up > >>> into a new common RaspberryPi/ subdirectory that will serve both > >>> platforms. The .dec is also moved to this directory, under a new > >>> RaspberryPi.dec name, and existing references to it are updated. > >>> ... > >> > >> This change seems not related to the rest of your refactor. > > > > It is. See https://edk2.groups.io/g/devel/message/49288 > > > > The problem is we have no choice but to break the patch in two sections, > > one that applies to edk2-platforms and the other to edk2-non-osi, since > > these are separate repos, and the LogoDxe changes belong to non-osi. > > > > We need to have part of the non-osi patch that is applied to > > edk2-platforms, and it would make little sense to break it down into the > > non-osi related and platforms related, since it still relies on the > > non-osi changes having been applied. > > I see. > > > > > If anything, I guess we could consider that the non-osi patch should > > come first. Still, whatever we do here, as long as only one of non-osi > > and platform is applied, builds are going to be broken, and there is no > > way to fix that unless you do consider the set of platforms + non-osi as > > a single patch. > > Agreed, this is a egg/chicken problem. > I dealt with this in the past by just making sure the non-osi and platform changes are applied at the same time. So it is good to make note of this in the cover letter, but other than that, there is no way we can apply interdependent changes to two separate repositories at the same time without either breaking bisect for one of them, or making a huge effort to add temporary code, defines etc that will be removed again right after the changes have landed. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49298): https://edk2.groups.io/g/devel/message/49298 Mute This Topic: https://groups.io/mt/36312720/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
On 10/21/19 2:52 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/21/19 1:25 PM, Pete Batard wrote:
In preparation for adding Raspberry Pi 4 support, the Pi 3 platform
is restructured by factorizing all the drivers and libraries that are
going to be commonly used by the two platforms.
Because much of the Pi 4 SoC is an extension of the Pi 3 one this
means that almost everything, except the ACPI tables, is moved up
into a new common RaspberryPi/ subdirectory that will serve both
platforms. The .dec is also moved to this directory, under a new
RaspberryPi.dec name, and existing references to it are updated.
No other changes are being applied at this stage.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxeFormSetGuid.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxeHii.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxeHii.vfr | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/DisplayDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/DisplayDxe.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/DisplayDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/Screenshot.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DriverBinding.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwUsbHostDxe.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwcHw.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/FdtDxe/FdtDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/FdtDxe/FdtDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsole.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsole.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/NewFont.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/Diagnostics.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/Mmc.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/Mmc.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcBlockIo.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcDebug.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcIdentification.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/SdHostDxe/SdHostDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/SdHostDxe/SdHostDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/VarBlockServiceDxe/FileIo.c |
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
Hi Philippe,
On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/21/19 1:25 PM, Pete Batard wrote:
In preparation for adding Raspberry Pi 4 support, the Pi 3 platform
is restructured by factorizing all the drivers and libraries that are
going to be commonly used by the two platforms.
Because much of the Pi 4 SoC is an extension of the Pi 3 one this
means that almost everything, except the ACPI tables, is moved up
into a new common RaspberryPi/ subdirectory that will serve both
platforms. The .dec is also moved to this directory, under a new
RaspberryPi.dec name, and existing references to it are updated.
No other changes are being applied at this stage.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxeFormSetGuid.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxeHii.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/ConfigDxe/ConfigDxeHii.vfr | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/DisplayDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/DisplayDxe.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/DisplayDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DisplayDxe/Screenshot.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DriverBinding.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwUsbHostDxe.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/DwUsbHostDxe/DwcHw.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/FdtDxe/FdtDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/FdtDxe/FdtDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsole.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsole.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/NewFont.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/ComponentName.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/Diagnostics.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/Mmc.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/Mmc.h | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcBlockIo.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcDebug.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/MmcDxe/MmcIdentification.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/SdHostDxe/SdHostDxe.c | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/SdHostDxe/SdHostDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/VarBlockServiceDxe/FileIo.c | 0
Platform/RaspberryPi/{RPi3 =>
Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4
Hi Pete,
On 10/21/19 1:25 PM, Pete Batard wrote:
In preparation for adding Raspberry Pi 4 support, the Pi 3 platform
is restructured by factorizing all the drivers and libraries that are
going to be commonly used by the two platforms.
Because much of the Pi 4 SoC is an extension of the Pi 3 one this
means that almost everything, except the ACPI tables, is moved up
into a new common RaspberryPi/ subdirectory that will serve both
platforms. The .dec is also moved to this directory, under a new
RaspberryPi.dec name, and existing references to it are updated.
No other changes are being applied at this stage.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/{RPi3 => }/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/ConfigDxe/ConfigDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/ConfigDxe/ConfigDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/ConfigDxe/ConfigDxeFormSetGuid.h
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/ConfigDxe/ConfigDxeHii.uni
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/ConfigDxe/ConfigDxeHii.vfr
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DisplayDxe/ComponentName.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DisplayDxe/DisplayDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DisplayDxe/DisplayDxe.h
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DisplayDxe/DisplayDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/DisplayDxe/Screenshot.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DwUsbHostDxe/ComponentName.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DwUsbHostDxe/DriverBinding.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DwUsbHostDxe/DwUsbHostDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DwUsbHostDxe/DwUsbHostDxe.h
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/DwUsbHostDxe/DwcHw.h
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/FdtDxe/FdtDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/FdtDxe/FdtDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/GraphicsConsoleDxe/ComponentName.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/GraphicsConsoleDxe/GraphicsConsole.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/GraphicsConsoleDxe/GraphicsConsole.h
| 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni | 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/GraphicsConsoleDxe/NewFont.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/ComponentName.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/Diagnostics.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/Mmc.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/Mmc.h
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/MmcBlockIo.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/MmcDebug.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/MmcDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/MmcDxe/MmcIdentification.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
| 0
Platform/RaspberryPi/{RPi3 =>
}/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/SdHostDxe/SdHostDxe.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/SdHostDxe/SdHostDxe.inf
| 2 +-
Platform/RaspberryPi/{RPi3 => }/Drivers/VarBlockServiceDxe/FileIo.c
| 0
Platform/RaspberryPi/{RPi3 => }/Drivers/VarBlockServiceDxe/FvbInfo.c
| 0
