Re: Proposal: Migrating More Git Projects to Pagure

[Martin Krizek]

- Original Message -
> From: "Tim Flink" 
> To: qa-devel@lists.fedoraproject.org
> Sent: Monday, January 9, 2017 5:21:16 PM
> Subject: Proposal: Migrating More Git Projects to Pagure
> 
> This came up in the qadevel meeting today and I wanted to put a bit
> more detail out.
> 
> Bitbucket was never intended to be the long-term home for our git
> projects - I think we're about the only folks in Fedora using it and
> it's not free software. As fedorahosted is closed down, we need to find
> a new home for blockerbugs but I figure that now is as good of a time
> as any to get all of our git projects in the same place.
> 
> I'm proposing the following moves:
> 
> * Move all Taskotron projects to pagure.io using the taskotron group:
>- pagure.io/taskotron/libtaskotron
>- pagure.io/taskotron/resultsdb
>- etc.
> 
> * Move blockerbugs under the existing fedora-qa namespace in pagure:
>- pagure.io/fedora-qa/blockerbugs
> 
> I'm not sure if there are any plans for the openqa stuff that currently
> lives on bitbucket but it'd be nice to see that moved as well.
> 
> Any objections, comments, concerns?
> 

Sounds good to me.

Martin
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Enabling running Taskotron tasks on Koji scratch builds

[Martin Krizek]

Hi team,

we have received a few requests to run tasks on koji scratch builds. 
Unfortunately, it is not as straightforward as it would seem since "real" koji 
builds and scratch builds are not treated the same. That's why "real" builds 
are downloaded with "koji download-build" and scratch builds are downloaded 
with its own tool called "koji-download-scratch" which is part of the 
fedora-review package.

The way the "real" koji builds work is that they are referenced by NVRs since 
NVRs are unique (I think there can be multiple builds with the same NVR, many 
with "failed" status and just one with the "completed" status and only the 
completed ones are searched, but that's just my guess). In taskotron's koji 
tasks, we feed NVR's to libtaskotron's koji directive which downloads build's 
RPMs.

In the case of scratch builds, they are not referenced by NVR's but rather just 
with task ID's.

With that being said, we just can't write a trigger for listening for the 
scratch builds fedmsgs [1] and trigger a libtaskotron job because there's no 
NVR in the fedmsg and even if it was, we wouldn't be able to download the rpms.

During a discussion with Kamil, a few solutions were mentioned (none of them is 
pretty):

1. We can ask koji developers if there is a way to add a method that would 
return all koji scratch builds for a given NVR - we would then take the latest 
one and work with it.

2. We can use "koji download-task" which works for both. That would mean 
koji_build item type would eat koji task IDs instead of NVRs. This would lead 
to having koji task IDs in resultsdb instead of NVR's which kills readability. 
Unless libtaskotron finds the NVR from the koji task ID in the case of "real" 
build" and stores it in a field in resultsdb...Also, we need NVRs for fedmsgs. 
So add code to the fedmsg layer that would take care of somehow adding a NVR to 
fedmsg of completed scratch builds tasks...

3. We can add a new action to the koji directive "download_task". And then have 
for each koji task two formulas, one for scratch build (using "download_task") 
and one for "real" build" (using "download_build). This would require writing 
code for supporting multiple formulas for one task and would result in having 
two almost identical formulas...

Before proceeding with 1. and asking koji folks if they are able to help with 
that I wanted to check here if anyone has any thoughts on this.

Thanks!
Martin

[1] 
https://apps.fedoraproject.org/datagrepper/id?id=2017-738c5d32-b2b9-40a3-bd1f-3f749d2f8d84_raw=true=extra-large
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Re: Enabling "new koji build" Taskotron checks on scratch builds

[Martin Krizek]

- Original Message -
> From: "Jeremy Cline" 
> To: qa-devel@lists.fedoraproject.org
> Sent: Tuesday, December 20, 2016 8:07:55 PM
> Subject: Enabling "new koji build" Taskotron checks on scratch builds
> 
> Hi everyone,
> 
> I recently started maintaining the-new-hotness[0]. In case anyone isn't
> familiar with it, it's responsible for filing bugs[1] when a new
> release  is made upstream. One of its components, rebase-helper,
> currently tries to run a set of tests on packages when upstream
> releases a new version.
> 
> There are a lot of problems with this process and for the most part it
> does not work. I started a discussion on the issue tracker about
> removing rebase-helper[2] as a dependency. Kamil Páral mentioned that
> there has been discussion about running the "new koji build" Taskotron
> checks for scratch builds. This would be great for the-new-hotness since
> it would do everything and more that rebase-helper currently does with
> respect to testing.
> 
> How do people feel about this? Are there any obstacles?
> 
> Thanks!
> 


Hi Jeremy,

I am not aware of any obstacles. To enable this we only need to push a
change into Taskotron Trigger that would listen on the koji scratch
fedmsgs and then wire your task to it. We can start in our dev instance
and see how it goes from there. Let us know if you need any help
with the "the-new-hotness" task.

Any objections/ideas/obstacles, folks?

Thanks,
Martin


> 
> [0] https://github.com/fedora-infra/the-new-hotness/
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1404680
> [2] https://github.com/fedora-infra/the-new-hotness/issues/145
> 
> --
> Jeremy Cline
> XMPP: jer...@jcline.org
> IRC:  jcline
> 
> 
> ___
> qa-devel mailing list -- qa-devel@lists.fedoraproject.org
> To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org
> 
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Re: Getting error "Try #1 for call None (multiCall) failed: syntax error: line 1" while running locally abicheck task

[Martin Krizek]

- Original Message -
> From: "Sinny Kumari" 
> To: "Fedora QA Development" 
> Sent: Tuesday, December 20, 2016 1:15:43 PM
> Subject: Getting error "Try #1 for call None (multiCall) failed: syntax 
> error: line 1" while running locally abicheck
> task
> 
> Hi,
> 
> Form few days, I am am not able to run task-abicheck [1] taskotron
> task locally because of following error message:
> 
> [koji] 11:58:43 INFOTry #1 for call None (multiCall) failed:
> syntax error: line 1, column 0
> 
> Detail log is available at [2]
> 
> I am not sure if there is something to do with Flag day 2016 changes.
> Although, I have made all related changes in my system. Also, I see
> that task-abicheck on taskotron production instance [3] is running
> fine.
> 
> koji and libtaskotron version my system have are:
> $ rpm -qa libtaskotron-* koji*
>   libtaskotron-0.4.17-1.fc24.noarch
>   koji-1.11.0-1.fc24.noarch
> 
> Any help will be appreciated :)
> 

Hi Sinny,

I reproduced it on my machine as well. I managed to make it work with:

1. Use "https" when accessing koji, change these in 
/etc/taskotron/taskotron.yml:

## URL of Koji instance used for querying about new builds
koji_url: https://koji.fedoraproject.org/kojihub
## URL of repository of all the RPM packages built in Koji
pkg_url: https://kojipkgs.fedoraproject.org/packages

2. Set up fedora kerberos [1] and do "kinit fasusern...@fedoraproject.org"

This fixed it for me. I am not sure if all the steps are necessary so
treat it as a workaround, I'll file a bug in phabricator and I'll
look at it closer. I am not sure why it works in production,
haven't checked that yet.

Ping me on irc if you have more questions. :)


Thanks for letting us know!
Martin

[1] https://fedoraproject.org/wiki/ReleaseEngineering/FlagDay2016

> Thanks,
> Sinny
> 
> [1] https://pagure.io/task-abicheck/
> [2]https://paste.fedoraproject.org/510030/
> [3]
> https://taskotron.fedoraproject.org/resultsdb/results?testcase_name=dist.abicheck
> ___
> qa-devel mailing list -- qa-devel@lists.fedoraproject.org
> To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org
> 
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Re: Please Test Staging Phabricator

[Martin Krizek]

- Original Message -
> From: "Tim Flink" 
> To: qa-devel@lists.fedoraproject.org
> Sent: Wednesday, December 14, 2016 4:56:11 PM
> Subject: Re: Please Test Staging Phabricator
> 
> On Wed, 14 Dec 2016 04:09:24 -0500 (EST)
> Kamil Paral  wrote:
> 
> > > After a bunch more fiddling, I think that auth is working correctly
> > > now. I've also removed the monikra.me stuff for now and auth will
> > > work directly against Fedora's auth systems.
> > 
> > I can now log in :-)
> > 
> > The only slight problem I encountered is that I didn't know how to
> > reach my profile, and then I realized there's a missing button in the
> > top right corner, caused by my profile picture not being found. After
> > I click on the invisible rectangle in the top right and then on
> > another invisible rectangle near my name [1], it's then obvious that
> > my current picture is missing and I can change it [2]. Martin was
> > affected by that issue as well. I don't know if all users will hit
> > that, or just those who uploaded their own picture in production
> > Phab. Or maybe it's staging-only issue, because the picture folder is
> > not copied over from production.
> 
> I know that I didn't sync the files over from production so that's very
> possible if you uploaded your picture to phabricator.
> 
> I've synced the local file store over from production, does your
> picture show up now?
> 

It does for me.

Thanks,
Martin
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Re: ResultsDB 2.0 - DB migration on DEV

[Martin Krizek]

- Original Message -
> From: "Kamil Paral" 
> To: "Fedora QA Development" 
> Sent: Friday, November 25, 2016 2:58:03 PM
> Subject: Re: ResultsDB 2.0 - DB migration on DEV
> 
> 
> 
> 
> So, I have performed the migration on DEV - there were some problems with it
> going out of memory, so I had to tweak it a bit (please have a look at
> D1059, that is what I ended up using by hot-fixing on DEV).
> 
> There still is a slight problem, though - the migration of DEV took about 12
> hours total, which is a bit unreasonable. Most of the time was spent in
> `alembic/versions/dbfab576c81_change_schema_to_v2_0_step_2.py` lines 84-93
> in D1059. The code takes about 5 seconds to change 1k results. That would
> mean at least 15 hours of downtime on PROD, and that, I think is unreal...
> 
> And since I don't know how to make it faster (tips are most welcomed), I
> suggest that we archive most of the data in STG/PROD before we go forward
> with the migration. I'd make a complete backup, and deleted all but the data
> from the last 3 months (or any other reasonable time span).
> 
> If we can't make it faster, I think this is reasonable.
> 

+1
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Re: 2016-09-14 @ 14:00 UTC - QA Tools Video "Standup" Meeting

[Martin Krizek]

- Original Message -
> From: "Tim Flink" 
> To: qa-devel@lists.fedoraproject.org
> Sent: Wednesday, September 14, 2016 4:59:49 PM
> Subject: Re: 2016-09-14 @ 14:00 UTC -  QA Tools Video "Standup" Meeting
> 
> 
> 
> One of the topics that came up was how often to do these video
> meetings. Having additional weekly meetings via video seems like
> overkill but if there's an appropriate in-depth topic, meeting via
> video to talk instead of type would be useful.
> 
> The two options we came up with are:
> 
> 1. Switch the first qadevel meeting of every month to be via video,
>making sure that an agenda is sent out early enough for folks to be
>prepared.
> 
> 2. Pencil in a video meeting once or twice a month on the Wednesday
>after qadevel meetings. Ask for video topics during the qadevel
>meeting and on email. If there are enough topics suggested which
>would benefit from talking instead of typing, meet on the following
>Wednesday to discuss via video. If there is no need to meet via
>video, skip it.
> 
> I realize that I'm changing things up a little bit from what we were
> talking about at the end of the meeting but I have a small concern
> about option 1 - one of the issues that we had today is that folks
> weren't prepared because we didn't set an agenda.
> 
> If we switch one qadevel meeting per month  to video, how do we want to
> handle setting the agenda early enough so that participants have enough
> time to prepare?
> 
> Any thoughts or preferences?
> 

My vote would be for the option 2., mostly because the video meeting can
be easily skipped if we don't have any topics to discuss and that
setting an agenda would be done on a set time (Monday meeting). It seems
to me that this could work well.


Thanks,
Martin
___
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org

Task Result Namespaces

[Martin Krizek]

Hi,

we have deployed task result namespaces support a while ago and put
our checks (depcheck, upgradepath, rpmlint) into the 'qa' namespace.
With newly added tasks like task-abicheck and task-dockerautotest,
we weren't sure where to put them and so we used the scratch
namespace which is supposed to be used for testing purposes. Now
with those "3rd party" tasks deployed to production, we need to
decide what namespaces should they and other future tasks belong in.

The starting namespaces, and maintainers of tasks belonging to that
namespace, follows:
qa.* - Fedora QA
pkgs..* -  maintainers
fas..* - 
fasgroup..* - fas members belonging to 
scratch.* - anyone

Now, since we maintain task-dockerautotest, it should go into qa.*,
I am not sure though where does task-abicheck belong. I see three
options here:
1. we can create fas group and put it there,
2. create additional dist.* namespace where tasks like abicheck
   and/or rpmgrill would be, or
3. change semantics of qa.* to 'anything Fedora QA maintains or
   important, not package-specific, tasks".

I don't really have strong feelings about either to be honest.

Thoughts? Other proposals?

Thanks,
Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org

Re: Renamed task-libabigail to task-abicheck and wiki page available

[Martin Krizek]

- Original Message -
> From: "Sinny Kumari" 
> To: "Fedora QA Development" 
> Sent: Friday, May 20, 2016 11:18:42 AM
> Subject: Renamed task-libabigail to task-abicheck and wiki page available
> 
> Hi,
> 
> We felt that task-abicheck name sounds better and signifies exactly
> what it does which is performing ABI checks between shared libraries
> and telling ABI differences if exists.
> 
> I discussed about renaming of task with Kamil on IRC and it seems fine
> to do. So, I went ahead and renamed task-libabigail to task-abicheck.
> Also, we have hosted our new repository at pagure[1] . github [2]
> repository will not receive any further updates and have been
> obsoleted.
> 
> From now on, please refer to new repository available at pagure[1] for
> updates, pull request and reporting a new issue.
> 

Sorry for late reply, this has been done.

Thanks,
Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org

Re: Packaging for Fedora

[Martin Krizek]

- Original Message -
> From: "Tim Flink" 
> To: qa-devel@lists.fedoraproject.org
> Sent: Tuesday, May 3, 2016 1:53:56 AM
> Subject: Packaging for Fedora
> 
> After a bit of miscommunication, I think we're finally on the same page
> as Infra in terms of getting QA tools packaged.
> 
> I've made a commitment to have everything packaged in Fedora before
> F25. In return, they've agreed to let us continue to update the infra
> repo with non-koji-built RPMs until that time.
> 

Sounds good. Thanks for communicating that with the infra folks.

> Even though it's not as immediate of an issue anymore, I still want to
> start making progress on this instead of waiting until the last minute;
> there are plenty of things to package and it's still going to take
> time to get done.
> 
> The biggest problem I see is the 777 dirs in the libtaskotron package.
> I've proposed two solutions in that ticket [1] but more input (and/or
> solutions) would be more than welcome.
> 

Replied in the ticket.

> I've requested a qadevel-sig (the '-sig' part is required) group in
> pkgdb [2] to manage ACLs for the packages and be the default assignee in
> bugzilla so we don't have to worry about who's the primary POC.
> 
> This isn't a "drop whatever you're doing and fix this now" but let's
> get it done so we can get rid of the copr and start working on other
> things :)
> 
> Tim
> 
> 
> [1] https://phab.qadevel.cloud.fedoraproject.org/T779
> [2] https://fedorahosted.org/fedora-infrastructure/ticket/5269
> 
> ___
> qa-devel mailing list
> qa-devel@lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org
> 
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org

Re: Cannot open logs of Taskotron jobs

[Martin Krizek]

- Original Message -
> From: "Juan Orti Alcaine" 
> To: "Development discussions related to Fedora" 
> 
> Sent: Thursday, December 3, 2015 8:54:21 AM
> Subject: Cannot open logs of Taskotron jobs
> 
> Hi,
> 
> I'm trying to open the logs of a couple of failed Taskotron jobs, but
> I get a forbidden error.
> 
> These are the jobs:
> 
> https://taskotron.fedoraproject.org/resultsdb/results/5025942
> https://taskotron.fedoraproject.org/resultsdb/results/5025972
> https://bodhi.fedoraproject.org/updates/FEDORA-2015-245d764be1
> 
> Is there any known problem?

It should be fixed now, thanks for the report.

Martin
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: 2015-07-27 @ 14:00 UTC - Fedora QA Devel Meeting

[Martin Krizek]

Finally gave up fixing mysterious network issues which prevents me
to stay at the channel for more than minute, posting my status 
report here, sorry about that:

#topic mkrizek status report
#info preparing for Flock
#info wrote a draft blogpost about upcoming artifacts changes
#info trivial description fix in resultsdb frontend
#link https://phab.qadevel.cloud.fedoraproject.org/D465
#info finished dev/stg taskotron machines deployment
#link https://phab.qadevel.cloud.fedoraproject.org/T505
#info reported checks failing on long updates names
#link https://phab.qadevel.cloud.fedoraproject.org/T530
#info code reviews
#info I'd like to update taskotron.prod early this week - 
concerns/questions/objections?


- Original Message -
 From: Tim Flink tfl...@redhat.com
 To: qa-devel@lists.fedoraproject.org
 Sent: Monday, July 27, 2015 4:57:11 AM
 Subject: 2015-07-27 @ 14:00 UTC -  Fedora QA Devel Meeting
 
 # Fedora QA Devel Meeting
 # Date: 2015-07-27
 # Time: 14:00 UTC
 (https://fedoraproject.org/wiki/Infrastructure/UTCHowto)
 # Location: #fedora-meeting-1 on irc.freenode.net
 
 Last week's meeting was longer so this should be a shorter one.
 
 If you have any topics to add, respond to this email or bring them up
 during open floor.
 
 Tim
 
 
 Proposed agenda
 ===
 
 Status Updates
 --
   - Please have #info statements ready so we can get through this as
 quickly as possible
 
 Possible Topics To Cover
 
   - feedback on qadevel migration
   - Flock preparations
 
 These are optional and may be covered - group discretion after status
 updates.
 
 
 Open Floor
 --
   - TBD
 
 ___
 qa-devel mailing list
 qa-devel@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/qa-devel
 
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: An update about: Checking the ABI of packages submitted to the updates-testing Fedora repository

[Martin Krizek]

- Original Message -
 From: Dodji Seketeli do...@seketeli.org
 To: Fedora Devel devel@lists.fedoraproject.org
 Cc: kpa...@fedoraproject.org, mkri...@fedoraproject.org, 
 skum...@fedoraproject.org, sgall...@fedoraproject.org,
 tfl...@fedoraproject.org
 Sent: Thursday, June 25, 2015 10:52:47 AM
 Subject: An update about: Checking the ABI of packages submitted to the 
 updates-testing Fedora repository
 
 Hello,
 
 A little update about this project we have been tinkering about.
 
 First thing first, a tracking ticket has been opened against the
 Taskotron project to follow the progress of this effort:
 https://phab.qadevel.cloud.fedoraproject.org/T490.
 
 Just so you remember the big picture, for each stable package named
 N-stable-V-R, whenever a new update N-update-V-R is submitted, we want
 to compare the binaries (mostly C and C++ libraries) to see if there
 has been any harmful ABI change.  If there has been any, then the
 update will not be pushed *automatically* to the stable repository
 when it reaches the karma threshold; rather, it will require a
 conscious decision by the maintainer.
 
 A number of things need to fall into place before we can actually
 have a working system.
 
 After discussing this in the audit trail of the tracking issue and on
 IRC, we are now heading toward triggering the ABI checks each time
 someone submits a build N-update-V-R to Koji.  Whenever the
 information of a new build is broadcasted on the fedmsg bus, a
 dedicated Taskotron task kicks off and performs the following steps:
 
 1/ retrieve the relevant N-stable-V-R package
 2/ retrieve the debug info packages for N-stable-V-R and N-update-V-R
 3/ perform an ABI comparison between N-stable-V-R and N-update-V-R,
using their debug info as necessary input.
 4/ store the result of the comparison in the ResultDB database.
 
 Then, when the package N-udpate-V-R is later submitted to Bodhi, the
 update creation process would query ResultDB for the result of the
 relevant ABI check that happened at build time.  The decision to allow
 an automatic push of the update to stable will depend on the result of
 that query.
 
 For this system to start working, we need a set of things to fall into
 place.  As noted in the tracking issue that I linked to above, we
 need to:
 
   * Extend koji directive to allow the download of debug info
   package. https://phab.qadevel.cloud.fedoraproject.org/T494.
   This is done now.
 
   * Support latest stable build with koji
   directive. https://phab.qadevel.cloud.fedoraproject.org/T491.
 
 * Have an abipkdiff tool, from the libabigail project that
   would compare binaries embedded in two RPMs and produce a
   report.  This is tracked by
   https://sourceware.org/bugzilla/show_bug.cgi?id=18426.
 The tool recently started to work in the branch
   ksinny/abipkgtool.  We are still working on it, but it can
   be used for prototyping already.
 
 * Have a Taskotron task that will use all of the above to
   perform the ABI comparison and store the result in ResultDB.
   
   Note that in the beginning, we'll perform only a basic kind of
   comparison: checking that no public symbols of functions and
   variables present in the stable version disappeared in the
   update.
 
   Obviously, the Libabigail tools can perform more sophisticated
   comparison involving the full signature of the functions and
   variables, including their sub-types.  But we think that
   should be left for later when the whole system works for the
   basic kind of ABI checks first.
   
   I still need to file a tracking issue for this.  I guess I
   can file it to Phabricator instance of Taskotron and assign
   it to myself?
 
 * Write a system wide change proposal for this project.
 
 So this is where we stand at the moment.
 

From what I understood, the current status of the ABI comparison is that it only
works with C/C++ programs. Have you given a thought on how do we know that the 
build
under test includes a C program and so we should run the comparison on it? 
Currently
we just listen on fedmsgs that koji sends about completed builds. So we need
something that would tell us this rpm includes a program in X language - run Y 
check
on it. This is essentially a general concern for the future checks that would
run on builds that include programs in a specific language.

Thanks!
Martin

 So if you have any comment, please do not hesitate.  And more
 importantly, if you feel like you can land us a helping hand, that would
 be greatly appreciated because obviously, this is far far far from being
 a one person project.  I'd like to thank those who stepped up so far:
 Tim Flink, Kamil Páral, Martin Krizek, Sinny Kumari and Stephen
 Gallagher.
 
 Thank you for reading so far

Re: Coding Style

[Martin Krizek]

- Original Message -
 From: Tim Flink tfl...@redhat.com
 To: qa-devel@lists.fedoraproject.org
 Sent: Friday, June 12, 2015 8:49:53 AM
 Subject: Coding Style
 
 Back to everyone's favorite topic - coding style and enforcement of
 that style.
 
 I'm not picking on Josef here - I'm sure I've submitted code recently
 with lint errors, this was just the review I was looking at which
 triggered the idea:
 
 https://phab.qadevel.cloud.fedoraproject.org/D389
 
 Since the last discussion about coding style ended in a long discussion
 about PEP8, the bits we may not like about the standard and the
 exceptions that we'd want, I'm proposing that we use strict PEP8 with
 almost no exceptions. I'm not saying that that PEP8 is perfect or
 that there aren't parts of it I would like to tweak but
  - it's a well known standard, easy for non-regular contributors to
understand and use
  - style checking tools tend to use PEP8 out of the box
  - if we don't allow exceptions, there will be less time spent on
discussing details instead of being productive :)

 To be more specific, I am proposing the following:
  - all QA devel projects be have flake8 as the linter in arc config
  - no code be accepted with lint errors unless there is absolutely no
other way to get around it
  - until we get our entire codebase PEP8 compliant, if you touch a
file, fix the lint errors even if those errors are not part of what
you're changing
 
 Any strong objections to starting this? Any strong objections should
 have an alternative proposal and a justification why that proposal is
 worth deviating from a well known and established standard.
 

By saying we should use strict PEP8, does that mean you want to get
rid of the linter settings we have in .arclint or leave it there?

Other than that, I have no objections. I am all for being strict and
consistent and avoiding discussing details at the expense of productivity.

Thanks,
Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Fedmsg Emitting

[Martin Krizek]

- Original Message -
 From: Tim Flink tfl...@redhat.com
 To: qa-devel@lists.fedoraproject.org
 Sent: Friday, May 15, 2015 1:14:56 AM
 Subject: Re: Fedmsg Emitting
 
 On Thu, 14 May 2015 20:02:29 +0200
 Martin Krizek mkri...@redhat.com wrote:
 
  Before we start sending fedmsgs we need to discuss a few things. We
  don't have to find solutions to all these problems, just keep them in
  mind when designing the solution we're going to start with:
  
  1. How often do we send fedmsg
  a) per-task
  b) per-update
  c) per-build
  
  a) and b): we can list affected packages in a fedmsg.
  
  I am not sure if there are any limits when it comes to fedmsg size.
  Whether the infra folks would be more happy with less larger or more
  smaller fedmsgs (or it doesn't matter).
 
 a) doesn't make a lot of sense to me - yeah, it fits better into our
 execution model but I don't think that anyone outside of taskotron
 cares much about what was done in a task. That being said, once we have
 more diverse tasks, this could change but I'm not really looking to
 design for something that hasn't even started happening yet.
 

Looking at it now, I have no idea why I wrote per-task. What I meant is
that we could send a fedmsg per-build(update) that would contain results
of all tasks executed on that build(update). Just a thought. Sorry for
confusion. :/

 b) hits a similar issue - outside of bodhi, there isn't much that works
 on updates and my suspicion is that most of the folks consuming
 the output will fall into 1 of 2 categories
  - people who have small updates that only contain packages that
they're responsible for
  - people who have packages in one of the megaupdates
 
 There are plenty of exceptions to either of those but I suspect that
 _most_ people will fall into one of those categories.
 
 That leaves us with c)
 
  I guess c) allows to easier filtering in FMN.
 
 c) not only allows for easier filtering in FMN but it's also more
 compatible with how I think that releng would like to see build gating
 done. Assuming that we eventually get into the rawhide space, we'll
 have to start emitting stuff per-build anyways :)
 
 I'm of the opinion that c) is going to be best here. In the past, we've
 done a lot of results on a per-update basis but unless I'm forgetting
 something, we could transition to more of a per-build system.
 
 For example - depcheck processes updates - if one build in that update
 fails, the whole update fails. While I think that this the best choice,
 I also think that logic should be handled in bodhi instead of us trying
 to emulate what bodhi is doing. As far as I know, this is happening
 with bodhi2 - they're assuming that we'll be emitting per-build fedmsgs
 and the logic for failing/passing an update will lie in bodhi and not
 rely on our emulation of bodhi's processes.


That does make sense to me.

  2. Who do we target: users, systems or both
  
  The issue here is with tasks that repeatedly test one update.
  Currently we check if there's a bodhi update comment with the same
  result already and if so, we don't post the comment again. To do
  something like that with fedmsgs we'd have to have a code running
  somewhere that would check against its database whether an incoming
  result is a duplicate or not. The question is where the code would
  run. Bodhi comes to mind since it already has information about
  updates and so is good for tasks that work with bodhi updates.
  However, there might be tasks that work with something else, like
  composes. In this case we'd probably have the code on taskotron
  systems.
 
 I think that how we handle scheduling of some of our current checks
 (depcheck and upgradepath) is a byproduct of trying to make a
 repo-level check look like a build/update-level check. I can't think of
 many more tasks that would run into the same problem of repeated runs.
 
 For the majority of tasks, I see the process as being similar to:
 
   1. trigger task $x for $y
   2. run task $x with $y as input
   3. report result for $x($y)
 
 With this, we'd be running $x for each $y and the reporting would only
 happen for each unique ($x, $y) assuming that something wasn't
 rescheduled or forced to re-run.
 
 I think it would be best to have consistent behavior for our fedmsg
 emitting. If most tasks will only emit fedmsgs once, we should take our
 minority tasks that emit more than one fedmsg per item and deduplicate
 before the messages are emitted.
 
  So if we target systems we'd just send all results in fedmsgs and let
  the systems consume them and do whatever they want to do with them
  (e.g. bodhi can squash all the tasks relevant to specific update and
  notify the maintainer of the package via fedmsg about the result). If
  we target users, we'd have to have some logic to limit rate of fedmsgs
  ourselves but that would mean hiding some of the results (although
  duplicates) from the world.
 
 I'd like to see us do the deduplication in resultsdb (assuming

Re: To RHEL or Not to RHEL?

[Martin Krizek]

- Original Message -
 From: Tim Flink tfl...@redhat.com
 To: qa-devel@lists.fedoraproject.org
 Sent: Saturday, May 9, 2015 8:05:04 PM
 Subject: To RHEL or Not to RHEL?

...snip...
 While virt-in-virt is possible, I'd prefer to avoid the extra
 complexity and performance penalty and figure that running on bare
 metal makes more sense. If we disable local task execution, there
 should be little risk of one task disrupting other stuff on that
 virthost that can't be easily reverted.
 

Does it make sense not to disable local execution on one or more
buildslave? I wonder if some tasks could benefit from not running in
vm. Or it might be waste of resources to run tasks like rpmlint
on a disposable client?


Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: CI for Taskotron and Related Projects

[Martin Krizek]

- Original Message -
 From: Kamil Paral kpa...@redhat.com
 To: Fedora QA Development qa-devel@lists.fedoraproject.org
 Sent: Wednesday, May 13, 2015 3:38:41 PM
 Subject: Re: CI for Taskotron and Related Projects
 
  I've just re-started the CI on qadevel (the future one, not cloud) that
  mkrizek set up a while back. It was destroyed when I started working on
  replacing qadevel.cloud but never finished it.
  
  The link is:
  
  https://qadevel.fedoraproject.org/buildmaster/waterfall
 
 Great. Just to refresh my memory, will we receive some kind of a notification
 when some project fails to build?

IIRC it doesn't send notifications. We might enable sending e-mail to the
author of a commit that breaks tests (if possible). Thoughts?

Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

disposable-develop branch

[Martin Krizek]

There is a new branch disposable-develop [1]. The branch will serve as develop
branch for disposable clients work. Having separate develop branch for
disposable clients work will allow us doing releases in the meantime.

When sending patches for review, do not forget to pass branch name to
'arc diff' as 'develop' branch is default. Another thing to remember is that
we should merge 'develop' into 'disposable-develop' quite often.


Thanks,
Martin


[1] https://bitbucket.org/fedoraqa/libtaskotron/branch/disposable-develop
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Taskotron Fedmsgs Format

[Martin Krizek]

Please find proposed format for taskotron fedmsgs below.

{ 'i': 1,
   'msg': {'check': {'name': 'upgradepath',
                     'type': 'bodhi_update', 
                     'item': 'wireshark-1.10.12-1.fc20',
                     'arch': 'x86_64'},
   'packages': [{'nvr': 'wireshark-1.10.12-1.fc20', 'name': 
'wireshark'}],
           'result': {'id': 123456,
                      'submit_time': '2015-01-27 14:22:53.584210',
                      'outcome': 'failed',
                      'summary': '...',
                      'job_url': 'http://resultsdb.fedoraproject.org/...',
                      'log_url': 'http://taskotron.fedoraproject.org/...'}
   },
   'msg_id': '2014-0bc98222-a864-4aea-bc6b-e3b090d2cc3d',
   'timestamp': 1395760459,
   'topic': 'org.fedoraproject.{prod, stg, dev}.taskotron.result.new',
   'username': 'taskotron'
}

The 'packages' field would be used for all the packages that are relevant
to the check which result is being sent in the fedmsg, so they can be
returned by fedmsg.meta.msg2packages and searched on using datagrepper.


Thoughts?

Thanks,
Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: [Test-Announce] Taskotron Has Replaced AutoQA

[Martin Krizek]

- Original Message -
 From: Vít Ondruch vondr...@redhat.com
 To: devel@lists.fedoraproject.org
 Sent: Tuesday, October 14, 2014 8:57:26 AM
 Subject: Re: [Test-Announce] Taskotron Has Replaced AutoQA
 
 You have not mentioned URL of Taskotron here nor the Wiki is updated to
 contain the link to the production version of Taskotron.
 
 Vít

https://taskotron.fedoraproject.org/

I put that on wiki as well.

Thanks,
Martin
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: [Fedocal] Reminder meeting : Fedora QA Devel Meeting (Cancelled)

[Martin Krizek]

- Original Message -
 From: Tim Flink tfl...@redhat.com
 To: qa-devel@lists.fedoraproject.org
 Sent: Monday, September 8, 2014 4:05:49 PM
 Subject: Re: [Fedocal] Reminder meeting : Fedora QA Devel Meeting (Cancelled)
 
 On Mon, 8 Sep 2014 07:26:39 -0600
 Tim Flink tfl...@redhat.com wrote:
 
  On Sun,  7 Sep 2014 10:00:02 + (UTC)
  kpa...@fedoraproject.org wrote:
  
   Dear all,
   
   You are kindly invited to the meeting:
  Fedora QA Devel Meeting on 2014-09-08 from 10:00:00 to 11:00:00
   America/New_York At fedora-meetin...@irc.freenode.net
  
  I think we either need to rethink the reminder on this or shift the
  time.
  
  A majority of the interested parties that I know of won't be able to
  make this meeting today, so I'm canceling it.
  
  Tim
 
 Bah, I had my dates mixed up and the conflict isn't actually there.
 
 Are we still of the mind that these bi-weekly meetings are of use or
 are there few enough people that we'd be better served by more ad-hoc
 meetings?
 
 Thoughts?

I guess bi-weekly meetings are useful if we still plan to do bi-weekly
releases which I recall we agreed on doing, right? We can always cancel
the meeting if there's nothing to discuss...

Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Default invocation of pytest for qadevel projects

[Martin Krizek]

- Original Message -
 From: Tim Flink tfl...@redhat.com
 To: qa-devel@lists.fedoraproject.org
 Sent: Thursday, March 6, 2014 3:29:32 PM
 Subject: Re: Default invocation of pytest for qadevel projects
 
 On Thu, 6 Mar 2014 05:44:15 -0500 (EST)
 Kamil Paral kpa...@redhat.com wrote:
 
   For the qadevel projects I'm aware of, we've been using pytest for
   our unit/functional test runner.
   
   As part of the shared configuration, tests are split up into two
   categories, unit and functional. Unit tests are fast, do not touch
   the network, database or filesystem (there are some exceptions to
   that last part, though). Functional tests tend to be more
   integration tests that can set up a database or do other actions
   which fall outside of the previous definition of unit test.
   
   When you run pytest without any extra args, only the unit tests are
   run. The '--functional' arg is needed to enable collection and
   execution of the functional tests.
   
   Kamil recently made a request [1] to do one of two things:
   
   [1] https://phab.qadevel.cloud.fedoraproject.org/T89
   
   1. Change the default such that functional tests are collected and
   exclude them from collection using a '--unit' arg
   
   2. Change the functional arg from '--functional' to something
   shorter, like '--func'
   
 * note that there are restrictions on which args we can use. For
   example, '-f' is not allowed as single letter args are reserved
   for pytest itself
   
   As stated in T89, I don't have a strong opinion on this as long as
   it's possible to exclude the functional tests from collection and
   we make the same change across all of our active projects. However,
   I wanted to put this up for a wider discussion before changing
   things.
   
   Any other thoughts on this proposed change?
  
  I should remember to read the mailing list before the Phab comments.
  I already closed the task as wontfix with my comment included:
  https://phab.qadevel.cloud.fedoraproject.org/T89#9
  
  I agree that you have a point in running just the unit tests by
  default.
 
 For my workflow, sure. On the other hand, I'm not sure what other
 peoples' workflow looks like and if it reduces confusion, we may be
 better off changing the defaults to run functional tests. As I stated
 in the ticket, as long as I can turn off the functional tests with a
 command line arg, my workflow won't be affected.
 
 Other thoughts on which is a better default?
 

I don't have a strong feeling about either but I'd run all the tests by default 
if I had to choose (given that functional ones don't run forever, which is 
not the case at this point).

  Changing --functional to --func would be nice, though. It
  even matches the file prefix for func tests, 'functest_'.
 
 Sure, I'm game for changing that. The two args that come to mind are:
 
  * --long (more generic than functional)
  * --func (short for functional)
 
 Any thoughts on which of those (if either) would be better?
 

--func sounds better to me.

Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 61: Rename line.png to line-bottom.png

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/61/
---

(Updated Feb. 21, 2014, 12:11 p.m.)


Status
--

This change has been discarded.


Review request for blockerbugs.


Repository: blockerbugs


Description
---

It appears that we've been getting GET /static/img/line-bottom.png HTTP/1.1 
404 for quite some time now...

commit fb18e118d108a8965a2ea8a2087bf1baa88cc193
Author: Martin Krizek mkri...@redhat.com
Date:   Tue Dec 17 10:47:34 2013 +0100

Rename line.png to line-bottom.png to reflect the actual state of css.


Diffs
-

  blockerbugs/static/img/line.png 6c111c3c3ed2118dfe803e02a6b0c8245010082a 
  blockerbugs/static/img/line-bottom.png PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/61/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 62: Fix needinfo field length

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/62/
---

(Updated Feb. 21, 2014, 12:12 p.m.)


Status
--

This change has been discarded.


Review request for blockerbugs.


Repository: blockerbugs


Description
---

Now that we support multiple needinfo flags, we also need to increase length of 
the needinfo field.


Diffs
-

  blockerbugs/models/bug.py 695d0ce3ca800ad8cd8d8324bc01726a84eade1b 
  alembic/versions/1dfd879c7637_fix_needinfo_field_l.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/62/diff/


Testing
---

Testing done on my dev machine.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 64: Do not display obsolete and deleted updates

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/64/
---

(Updated Feb. 21, 2014, 12:12 p.m.)


Status
--

This change has been discarded.


Review request for blockerbugs.


Repository: blockerbugs


Description
---

This will not display updates that are obsolete or irrelevant. After fetching 
updates from bodhi, the clean_updates method will set status of updates that 
are in database and not in the fetched updates (are not relevant anymore) to 
'deleted'. There seems to be no way to know whether an update in db is still 
present in bodhi or not. So we mark every update in db as 'deleted' that is not 
currently an update that fixes a blocker bug. The question is whether we want 
to mark these updates as 'deleted' and create status that does not exist in 
bodhi or mark them in other way. If a situation where a 'deleted' update is 
used again as a fix of a blocker bug occurs, its status is set back to 
'testing' or 'stable' on the next update sync. Any suggestions about improving 
or changing the approach?


Diffs
-

  testing/testfunc_update_sync.py 48dfb500469b8f237020b5d0845ae60a4e1fb776 
  blockerbugs/util/update_sync.py 47dbc9fa17ed3b751417b4ab822c257fa5423f4b 
  blockerbugs/controllers/main.py 5455e1aa2bbf6edc551223ee6fccb9c6236f0eb8 
  blockerbugs/__init__.py 3525501c382f21339dab0e18e973141ad29073e3 

Diff: http://reviewboard-tflink.rhcloud.com/r/64/diff/


Testing
---

Unit test attached in the patch. Some testing done on my dev machine as well.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 37: Fix sequences in alembic

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/37/
---

(Updated Feb. 21, 2014, 12:13 p.m.)


Status
--

This change has been discarded.


Review request for blockerbugs.


Repository: blockerbugs


Description
---

commit abf5fe2abbcfbce45d103864f5ba40fc89f233fa
Author: Martin Krizek mkri...@redhat.com
Date:   Tue Jul 16 13:57:28 2013 +0200

Fix sequences in alembic

Sequences need to be created separately. The patch also fixes a few
typos.

https://bitbucket.org/zzzeek/alembic/issue/73/more-pg-nextval-it-needs-the-text-wrapper


Diffs
-

  alembic/versions/487cb8ccce92_dropping_flask_login.py 
e64dacb2e3b1a3d14bf38e1116df183ded9793d9 
  alembic/versions/1d12b74d12bd_add_userinfo_table.py 
86dc390ed5e49b0a3ca058e163bc02b070d3d294 

Diff: http://reviewboard-tflink.rhcloud.com/r/37/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: gitflow and branch naming conventions

[Martin Krizek]

- Original Message -
 From: Kamil Paral kpa...@redhat.com
 To: Fedora QA Development qa-de...@lists.fedoraproject.org
 Sent: Friday, January 24, 2014 4:03:40 PM
 Subject: gitflow and branch naming conventions
 
 So, we're going the gitflow way [1][2]. However, when I looked at our
 bitbucket repositories today, only the libtaskotron branch uses 'develop'
 branch, all other projects use only 'master' branch - even taskotron-trigger
 or task-rpmlint. Does it mean we use gitflow only for libtaskotron? Or is it
 a repo author's choice? I'm a bit afraid it's going to be chaos - you'll
 need to inspect available branches every time to decide against which branch
 to base a patch or into which branch to commit.
 
 I wonder, could we use gitflow but drop the idea of misusing 'master' branch
 name for something else than usual?
 
 Because that's the main grievance I have against gitflow, otherwise it's a
 neat workflow. I believe gitflow should have never used master for something
 else, it should have used 'stable' branch instead for stable releases (i.e.
 'gitflow/master' should have been 'traditional/stable' and 'gitflow/develop'
 should have been 'traditional/master'). All the tools (and most of the
 users) expect 'master' to be the main development branch. Git init creates
 master by default. Git clone checks out master by default. Github/Bitbucket
 displays master by default. Arcanist merges to master by default. Users
 clone and send patches against master by default. Usually you can adjust the
 tools, but what's the benefit? Why all the mess? I simply don't get it.
 (Also notice people criticizing it under one of the most famous blogposts
 [3] and offering the same suggestions as I do).
 

I am not against the idea but just a note, we'd need to change this for 
projects that have been using gitflow/develop style branch (blockerbugs) as 
well.

Thanks,
Martin

 So, if we use gitflow with traditional master meaning, and stable branch for
 stable releases, I see it as a win-win. Regardless whether that particular
 repo uses gitflow or not, you known what branch to work with automatically.
 You don't need to change configuration in your tools. Everything works, and
 you get the benefits.
 
 If you have installed the gitflow RPM package (it adds the git flow
 subcommand), it asks you initially what naming conventions you like to use.
 So if you like that tool, there's no problem using it with the traditional
 'master' meaning.
 
 [1] https://fedoraproject.org/wiki/User:Tflink/taskotron_contribution_guide
 [2] http://nvie.com/posts/a-successful-git-branching-model/
 [3] http://jeffkreeftmeijer.com/2010/why-arent-you-using-git-flow/
 ___
 qa-devel mailing list
 qa-de...@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/qa-devel
 
___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

phab: auth providers

[Martin Krizek]

I wonder if we should enable authentication through providers like GitHub 
instead of just username/password (and FAS in the future). This would make it 
easier for non-fas users to report bugs or contribute to the project. I also 
noticed that anonymous access to view tickets is possible but one need to know 
the link, is there a way to fix this?

Any thoughts?

Thanks,
Martin
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: phab: auth providers

[Martin Krizek]

Link might be helpful: 
http://www.phabricator.com/docs/phabricator/article/Configuring_Accounts_and_Registration.html

- Original Message -
 From: Martin Krizek mkri...@redhat.com
 To: Fedora QA Development qa-devel@lists.fedoraproject.org
 Sent: Wednesday, January 22, 2014 3:01:21 PM
 Subject: phab: auth providers
 
 I wonder if we should enable authentication through providers like GitHub
 instead of just username/password (and FAS in the future). This would make
 it easier for non-fas users to report bugs or contribute to the project. I
 also noticed that anonymous access to view tickets is possible but one need
 to know the link, is there a way to fix this?
 
 Any thoughts?
 
 Thanks,
 Martin
 ___
 qa-devel mailing list
 qa-devel@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/qa-devel
 
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Taskotron wiki page

[Martin Krizek]

- Original Message -
 From: Kamil Paral kpa...@redhat.com
 To: Fedora QA Development qa-de...@lists.fedoraproject.org, Josef 
 Skladanka jskla...@redhat.com
 Sent: Tuesday, January 21, 2014 4:00:33 PM
 Subject: Re: Taskotron wiki page
 
  I also updated
  
  https://fedoraproject.org/wiki/QA/Tools
  
  with the list of our current projects. If you see something missing, please
  add it. Thanks.
  
 
 Josef, I find this quite confusing:
 
 https://bitbucket.org/rajcze/resultsdb
 https://bitbucket.org/rajcze/resultsdb_api
 https://bitbucket.org/rajcze/resultsdb_frontend
 https://fedorahosted.org/ResultsDB/
 https://git.fedorahosted.org/git/ResultsDB.git
 
 What is the canonical source? Where should people report issues? Please, pick
 one location to keep the project in (it seems we're going bitbucket, or
 bitbucket+phab way) and kill the other site. Also make sure issues can't be
 reported on two different places, and forward people to the single one. And
 make sure your wiki page points to a correct location:
 https://fedoraproject.org/wiki/ResultsDB
 (I updated it before learning there are other sources of ResultsDB. You might
 have some more under your sleeve.)
 
 Thanks.
 
 As a general note, I'm not fully happy when the source code lives somewhere
 else than the issues do. It confuses people. But if we want to keep
 easy-to-browse-and-fork functionality (bitbucket) and full-featured-review
 functionality (phab), it seems we don't have much choice. At least we should
 always disable the issue support on bitbucket for every project.

Weren't we going to move repos to phab as well?

M.
___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

[Maniphest] [Claimed] T52: investigate logging mechanisms for taskotron runner

[mkrizek (Martin Krizek)]

mkrizek claimed this task.

TASK DETAIL
  https://phab.qadevel.cloud.fedoraproject.org/T52

To: mkrizek
Cc: kparal, qa-devel, tflink
___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

[Maniphest] [Created] T29: show also closed bugs

[mkrizek (Martin Krizek)]

mkrizek created this task.
mkrizek added a subscriber: mkrizek.
mkrizek added a project: blockerbugs

TASK DESCRIPTION
  Moved from trac [[ https://fedorahosted.org/fedora-qa/ticket/440 | 
https://fedorahosted.org/fedora-qa/ticket/440 ]]:
  
  I would like to be able to see also closed blocker bugs, not only the 
pending ones. The current setup can be the default and have a check box for 
showing the closed ones.

TASK DETAIL
  https://phab.qadevel.cloud.fedoraproject.org/T29

To: mkrizek
Cc: qa-devel, mkrizek
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

[Maniphest] [Created] T30: Improve documentation

[mkrizek (Martin Krizek)]

mkrizek created this task.
mkrizek added a subscriber: mkrizek.
mkrizek added a project: blockerbugs

TASK DESCRIPTION
  Moved from trac [[ https://fedorahosted.org/fedora-qa/ticket/384 | 
https://fedorahosted.org/fedora-qa/ticket/384 ]]:
  Problem
  At the moment, our documentation is out of date and somewhat incomplete.
  
  Analysis
  Update the docs and find an appropriate place for them to live.

TASK DETAIL
  https://phab.qadevel.cloud.fedoraproject.org/T30

To: mkrizek
Cc: qa-devel, mkrizek
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 64: Do not display obsolete and deleted updates

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/64/
---

Review request for blockerbugs.


Repository: blockerbugs


Description
---

This will not display updates that are obsolete or irrelevant. After fetching 
updates from bodhi, the clean_updates method will set status of updates that 
are in database and not in the fetched updates (are not relevant anymore) to 
'deleted'. There seems to be no way to know whether an update in db is still 
present in bodhi or not. So we mark every update in db as 'deleted' that is not 
currently an update that fixes a blocker bug. The question is whether we want 
to mark these updates as 'deleted' and create status that does not exist in 
bodhi or mark them in other way. If a situation where a 'deleted' update is 
used again as a fix of a blocker bug occurs, its status is set back to 
'testing' or 'stable' on the next update sync. Any suggestions about improving 
or changing the approach?


Diffs
-

  testing/testfunc_update_sync.py 48dfb500469b8f237020b5d0845ae60a4e1fb776 
  blockerbugs/util/update_sync.py 47dbc9fa17ed3b751417b4ab822c257fa5423f4b 
  blockerbugs/controllers/main.py 5455e1aa2bbf6edc551223ee6fccb9c6236f0eb8 
  blockerbugs/__init__.py 3525501c382f21339dab0e18e973141ad29073e3 

Diff: http://reviewboard-tflink.rhcloud.com/r/64/diff/


Testing
---

Unit test attached in the patch. Some testing done on my dev machine as well.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 62: Fix needinfo field length

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/62/
---

Review request for blockerbugs.


Repository: blockerbugs


Description
---

Now that we support multiple needinfo flags, we also need to increase length of 
the needinfo field.


Diffs
-

  blockerbugs/models/bug.py 695d0ce3ca800ad8cd8d8324bc01726a84eade1b 
  alembic/versions/1dfd879c7637_fix_needinfo_field_l.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/62/diff/


Testing
---

Testing done on my dev machine.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

[Maniphest] [Claimed] T25: Allow users to see which bugs have changed blocker status in the last X hours/days

[mkrizek (Martin Krizek)]

mkrizek claimed this task.
mkrizek added a comment.

I have come up with a proposal implementation here: 
[[https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=feature/T25-blocker-statusid=7b6bed052566341626745dea5b3601b43442c48a
 | 7b6bed052566341626745dea5b3601b43442c48a]] (feature/T25-blocker-status 
branch).

The UI change is just temporary to see if it works.

Before doing review, any thoughts on the backend change and/or on how to fit it 
into the current UI?

TASK DETAIL
  https://phab.qadevel.cloud.fedoraproject.org/T25

To: mkrizek
Cc: qa-devel, tflink
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

[Maniphest] [Closed] T26: Display all users that are listed in needinfo flag

[mkrizek (Martin Krizek)]

mkrizek closed this task as Resolved.
mkrizek added a comment.

Fixed in develop [[ 
https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=developid=0618ae3bc89431f9d00a3cc103b19fc0376697ed
 | 0618ae3bc89431f9d00a3cc103b19fc0376697ed ]]

TASK DETAIL
  https://phab.qadevel.cloud.fedoraproject.org/T26

To: mkrizek
Cc: qa-devel, mkrizek
___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 57: Multiple builds fixing a bug show confusing status label

[Martin Krizek]

 On Dec. 10, 2013, 5:58 p.m., Tim Flink wrote:
  blockerbugs/__init__.py, line 162
  http://reviewboard-tflink.rhcloud.com/r/57/diff/1/?file=1605#file1605line162
 
  Bah, have we really been running this whole time with unclosed span 
  tags on the update status labels?

Yes :)


 On Dec. 10, 2013, 5:58 p.m., Tim Flink wrote:
  blockerbugs/models/update.py, line 55
  http://reviewboard-tflink.rhcloud.com/r/57/diff/1/?file=1607#file1607line55
 
  Why is this sort order change an improvement? If an older update is 
  pending while a newer update is stable, we'd want to show the newer update

But wouldn't the older update be marked as obsolete?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/57/#review118
---


On Dec. 10, 2013, 3:54 p.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/57/
 ---
 
 (Updated Dec. 10, 2013, 3:54 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 438
 https://fedorahosted.org/fedora-qa/ticket/438
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit 911781af9cc06e27c0a8580f07f7673c90e7329d
 Author: Martin Krizek mkri...@redhat.com
 Date:   Tue Dec 10 16:28:52 2013 +0100
 
 Sort updates by (status.desc(), pending.desc())
 
 This way an update label is correctly set when multiple updates fix a
 bug. The label is chosen by the following order (the lowest one):
 
 pending testing  testing  pending stable  stable
 
 Fixes: #438
 
 Note: the rest of the issues with displaying label is handled outside this 
 ticket in https://phab.qadevel.cloud.fedoraproject.org/T21
 
 
 Diffs
 -
 
   blockerbugs/models/update.py 89c083da5c91558d4dead118c67e4a1138b8cae1 
   blockerbugs/controllers/main.py 1795ed1d717bb85e0f3d9e7e7008d68c2aae36d8 
   blockerbugs/__init__.py dcf6c5aadb24e6d86e95d5bb3d608b81721de47f 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/57/diff/
 
 
 Testing
 ---
 
 Sorting seems to be working as expected.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 57: Multiple builds fixing a bug show confusing status label

[Martin Krizek]

 On Dec. 10, 2013, 5:58 p.m., Tim Flink wrote:
  blockerbugs/models/update.py, line 55
  http://reviewboard-tflink.rhcloud.com/r/57/diff/1/?file=1607#file1607line55
 
  Why is this sort order change an improvement? If an older update is 
  pending while a newer update is stable, we'd want to show the newer update
 
 Martin Krizek wrote:
 But wouldn't the older update be marked as obsolete?
 
 Tim Flink wrote:
 It should be but for example, if you look at the tracking app right now, 
 there are 2 anaconda/blivet updates - one of which has been deleted in bodhi 
 but still shows up.
 
 This issue was supposed to be fixed but obviously, it's not. Filed as 
 https://phab.qadevel.cloud.fedoraproject.org/T27
 
 I think that the problem of phantom updates are the root cause of the 
 problem as reported, but I'll ask in bug to be sure.
 
 Tim Flink wrote:
 After re-reading the bug, I stand corrected. That was a completely 
 different issue than I was thinking about in my head.
 
 I don't like sorting on string fields by default but I also don't see 
 much of a way around it unless we changed the schema to use status enums 
 instead of strings.
 
 Go ahead and push to develop. We might want to look into changing the 
 update status field to an enum but that's well outside the scope of this fix.

I know. This is just a part of the fix, the rest will be in 
https://phab.qadevel.cloud.fedoraproject.org/T21 as I mentioned in the fix 
description. Should have probably done it in one review, sorry for confusion.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/57/#review118
---


On Dec. 10, 2013, 3:54 p.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/57/
 ---
 
 (Updated Dec. 10, 2013, 3:54 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 438
 https://fedorahosted.org/fedora-qa/ticket/438
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit 911781af9cc06e27c0a8580f07f7673c90e7329d
 Author: Martin Krizek mkri...@redhat.com
 Date:   Tue Dec 10 16:28:52 2013 +0100
 
 Sort updates by (status.desc(), pending.desc())
 
 This way an update label is correctly set when multiple updates fix a
 bug. The label is chosen by the following order (the lowest one):
 
 pending testing  testing  pending stable  stable
 
 Fixes: #438
 
 Note: the rest of the issues with displaying label is handled outside this 
 ticket in https://phab.qadevel.cloud.fedoraproject.org/T21
 
 
 Diffs
 -
 
   blockerbugs/models/update.py 89c083da5c91558d4dead118c67e4a1138b8cae1 
   blockerbugs/controllers/main.py 1795ed1d717bb85e0f3d9e7e7008d68c2aae36d8 
   blockerbugs/__init__.py dcf6c5aadb24e6d86e95d5bb3d608b81721de47f 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/57/diff/
 
 
 Testing
 ---
 
 Sorting seems to be working as expected.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 57: Multiple builds fixing a bug show confusing status label

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/57/
---

Review request for blockerbugs.


Bugs: 438
https://fedorahosted.org/fedora-qa/ticket/438


Repository: blockerbugs


Description
---

commit 911781af9cc06e27c0a8580f07f7673c90e7329d
Author: Martin Krizek mkri...@redhat.com
Date:   Tue Dec 10 16:28:52 2013 +0100

Sort updates by (status.desc(), pending.desc())

This way an update label is correctly set when multiple updates fix a
bug. The label is chosen by the following order (the lowest one):

pending testing  testing  pending stable  stable

Fixes: #438

Note: the rest of the issues with displaying label is handled outside this 
ticket in https://phab.qadevel.cloud.fedoraproject.org/T26


Diffs
-

  blockerbugs/models/update.py 89c083da5c91558d4dead118c67e4a1138b8cae1 
  blockerbugs/controllers/main.py 1795ed1d717bb85e0f3d9e7e7008d68c2aae36d8 
  blockerbugs/__init__.py dcf6c5aadb24e6d86e95d5bb3d608b81721de47f 

Diff: http://reviewboard-tflink.rhcloud.com/r/57/diff/


Testing
---

Sorting seems to be working as expected.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 57: Multiple builds fixing a bug show confusing status label

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/57/
---

(Updated Dec. 10, 2013, 3:54 p.m.)


Review request for blockerbugs.


Bugs: 438
https://fedorahosted.org/fedora-qa/ticket/438


Repository: blockerbugs


Description (updated)
---

commit 911781af9cc06e27c0a8580f07f7673c90e7329d
Author: Martin Krizek mkri...@redhat.com
Date:   Tue Dec 10 16:28:52 2013 +0100

Sort updates by (status.desc(), pending.desc())

This way an update label is correctly set when multiple updates fix a
bug. The label is chosen by the following order (the lowest one):

pending testing  testing  pending stable  stable

Fixes: #438

Note: the rest of the issues with displaying label is handled outside this 
ticket in https://phab.qadevel.cloud.fedoraproject.org/T21


Diffs
-

  blockerbugs/models/update.py 89c083da5c91558d4dead118c67e4a1138b8cae1 
  blockerbugs/controllers/main.py 1795ed1d717bb85e0f3d9e7e7008d68c2aae36d8 
  blockerbugs/__init__.py dcf6c5aadb24e6d86e95d5bb3d608b81721de47f 

Diff: http://reviewboard-tflink.rhcloud.com/r/57/diff/


Testing
---

Sorting seems to be working as expected.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

[Maniphest] [Commented On] T19: Some users seeing HTTP 503 errors from the blockerbugs production instance

[mkrizek (Martin Krizek)]

mkrizek added a comment.

I am pretty sure that the tb is caused by old version of python-fedora-flask on 
stg and prod that is missing this: 
https://github.com/fedora-infra/python-fedora/commit/dba632f599358ebf6399435b660167c0eed34377

As a workaround, we'd need to call fas.login(return_url=*insert_value_here*) 
instead of fas.login() (which is only at one place: 
check_admin_rights():blockerbugs/util/login.py).

This should only happen in admin interface though, so I am not sure if the tb 
is related to those 503 errors the user was seeing.

TASK DETAIL
  https://phab.qadevel.cloud.fedoraproject.org/T19

To: mkrizek
Cc: qa-devel, tflink
___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 45: Improve asset management

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/
---

(Updated Nov. 14, 2013, 3:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 357
https://fedorahosted.org/fedora-qa/ticket/357


Repository: blockerbugs


Description
---

commit d86f88d7f9da899ffef44ad617a8a831327b7d80
Author: Martin Krizek mkri...@redhat.com
Date:   Mon Aug 12 16:40:16 2013 +0200

Improve asset management

Fixes: #357


I have not minified two js files in milestone_stats.html template as I am not 
sure it's worth it, any objections?


Diffs
-

  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 

Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/


Testing
---

Loaded pages, seems like css and js work as expected after being minified.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 56: Serve IRC Format page as text/plain

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/56/
---

(Updated Oct. 21, 2013, 9:22 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 428
https://fedorahosted.org/fedora-qa/ticket/428


Repository: blockerbugs


Description
---

commit ea3d4374710be7ee6762072746bddbdb7aa85716
Author: Martin Krizek mkri...@redhat.com
Date:   Thu Oct 17 11:10:57 2013 +0200

Serve IRC Format page as text/plain

Fixes: #428


Diffs
-

  blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 

Diff: http://reviewboard-tflink.rhcloud.com/r/56/diff/


Testing
---

Tested on my local dev machine. Works in both browser and wget.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 56: Serve IRC Format page as text/plain

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/56/
---

Review request for blockerbugs.


Bugs: 428
https://fedorahosted.org/fedora-qa/ticket/428


Repository: blockerbugs


Description
---

commit ea3d4374710be7ee6762072746bddbdb7aa85716
Author: Martin Krizek mkri...@redhat.com
Date:   Thu Oct 17 11:10:57 2013 +0200

Serve IRC Format page as text/plain

Fixes: #428


Diffs
-

  blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 

Diff: http://reviewboard-tflink.rhcloud.com/r/56/diff/


Testing
---

Tested on my local dev machine. Works in both browser and wget.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 55: milestone_info uses hardcoded bugzilla url instead of using config value

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/55/
---

(Updated Oct. 17, 2013, 9:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: t423
https://fedorahosted.org/fedora-qa/ticket/t423


Repository: blockerbugs


Description
---

commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28
Author: Martin Krizek mkri...@redhat.com
Date:   Fri Oct 11 12:49:54 2013 +0200

Don't use hardcoded bz url in the milestone_info template


Diffs
-

  blockerbugs/templates/milestone_info.html 
bac8fa075ef4fd40c95fb35885951845d483b521 
  blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 
  blockerbugs/config.py 2693e16b287745bf95dbc9b258c6b8a9afe226c5 

Diff: http://reviewboard-tflink.rhcloud.com/r/55/diff/


Testing
---

I tested it on my local machine.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 55: milestone_info uses hardcoded bugzilla url instead of using config value

[Martin Krizek]

On Oct. 14, 2013, 5:08 p.m., Martin Krizek wrote:
  Overall, looks good other than my question about url munging vs. changing 
  how the settings are done. Thoughts?

I updated the diff according to conversation on IRC.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/55/#review114
---


On Oct. 11, 2013, 11:01 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/55/
 ---
 
 (Updated Oct. 11, 2013, 11:01 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: t423
 https://fedorahosted.org/fedora-qa/ticket/t423
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28
 Author: Martin Krizek mkri...@redhat.com
 Date:   Fri Oct 11 12:49:54 2013 +0200
 
 Don't use hardcoded bz url in the milestone_info template
 
 
 Diffs
 -
 
   blockerbugs/templates/milestone_info.html 
 bac8fa075ef4fd40c95fb35885951845d483b521 
   blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/55/diff/
 
 
 Testing
 ---
 
 I tested it on my local machine.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 55: milestone_info uses hardcoded bugzilla url instead of using config value

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/55/
---

(Updated Oct. 16, 2013, 1:16 p.m.)


Review request for blockerbugs.


Bugs: t423
https://fedorahosted.org/fedora-qa/ticket/t423


Repository: blockerbugs


Description
---

commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28
Author: Martin Krizek mkri...@redhat.com
Date:   Fri Oct 11 12:49:54 2013 +0200

Don't use hardcoded bz url in the milestone_info template


Diffs (updated)
-

  blockerbugs/templates/milestone_info.html 
bac8fa075ef4fd40c95fb35885951845d483b521 
  blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 
  blockerbugs/config.py 2693e16b287745bf95dbc9b258c6b8a9afe226c5 

Diff: http://reviewboard-tflink.rhcloud.com/r/55/diff/


Testing
---

I tested it on my local machine.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 55: milestone_info uses hardcoded bugzilla url instead of using config value

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/55/
---

(Updated Oct. 16, 2013, 1:17 p.m.)


Review request for blockerbugs.


Bugs: t423
https://fedorahosted.org/fedora-qa/ticket/t423


Repository: blockerbugs


Description
---

commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28
Author: Martin Krizek mkri...@redhat.com
Date:   Fri Oct 11 12:49:54 2013 +0200

Don't use hardcoded bz url in the milestone_info template


Diffs
-

  blockerbugs/templates/milestone_info.html 
bac8fa075ef4fd40c95fb35885951845d483b521 
  blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 
  blockerbugs/config.py 2693e16b287745bf95dbc9b258c6b8a9afe226c5 

Diff: http://reviewboard-tflink.rhcloud.com/r/55/diff/


Testing
---

I tested it on my local machine.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 53: fix sync so that closed bugs don't remain on the buglist

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/53/#review111
---

Ship it!


The diff doesn't seem right :) However, looking at 
https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=hotfix/t421-closedsyncfailureid=e37129e7a5c119d43ac296a09d0f7ff9e8d42795,
 it looks good to me.

- Martin Krizek


On Oct. 10, 2013, 4:10 p.m., Tim Flink wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/53/
 ---
 
 (Updated Oct. 10, 2013, 4:10 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 421
 https://fedorahosted.org/fedora-qa/ticket/421
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 This is a simple fix that removes the status restriction from the bugzilla 
 query used during bug sync
 
 
 Diffs
 -
 
   testing/testfunc_update_sync.py 0b92588739c338a0706f083c2306f9b6a2f14e10 
   testing/testfunc_bugsync.py 093115135e6df12be044a14409967c4fa0235d11 
   testing/testfunc_bugmodel.py b02abd4da0082cd5f9749af4cbbfe0958f3a8cbd 
   testing/test_validators.py PRE-CREATION 
   testing/test_updatesync_extract_information.py 
 c5d3f665f475b2a16c4a948a236fc3dc807be453 
   testing/test_spinmodel.py PRE-CREATION 
   testing/test_controllers.py PRE-CREATION 
   testing/test_bugsync_extract_information.py 
 d30c817097778b704e04283de9a96b812dd922ea 
   testing/test_bugchange.py 596e922283bfd20fc0ac6811aa1eef3ef45378ea 
   testing/test_api.py PRE-CREATION 
   testing/conftest.py c30e69ac70a4753a8ef311993b0437ffb0ae0bce 
   setup.py 7b1f26d3d52d5102672f2efc2aad7a8bbd2dbcc7 
   sass/admin_layout.scss PRE-CREATION 
   requirements.txt 29abdbeb36991a6565d403889c5ed5d8d994f423 
   init_db.sh 855df9b0a9776672d60e5546a04c1e05a4957cb4 
   conf/blockerbugs.conf 53f717c6a5e6b39337e074da8b05d64c0cc45c5a 
   blockerbugs/util/update_sync.py 9c46ffc7b3c2f07a73c899165044059447858a48 
   blockerbugs/util/login.py PRE-CREATION 
   blockerbugs/util/koji_interface.py PRE-CREATION 
   blockerbugs/util/bz_interface.py 0676493ab3b8c0789087fcb75f71417c5d9c42d5 
   blockerbugs/util/bug_sync.py dec53ce1d5d998186cea4d63f18a835ee326542e 
   blockerbugs/templates/update_list.html 
 a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f 
   blockerbugs/templates/spin_list.html 
 c455ff4edec0991a453a94cd0e38d959e1757672 
   blockerbugs/templates/login.html 6023c25e3436257c1c6a1027a9b37ec21f62cee9 
   blockerbugs/templates/layout.html 28c22872b716d7125880710db53881a73bc8cdc8 
   blockerbugs/templates/base_nav.html 
 021ddb3126b4c0f30a231d8d9b32df09c669280e 
   blockerbugs/templates/admin_layout.html PRE-CREATION 
   blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
   blockerbugs/templates/admin/spin_create.html PRE-CREATION 
   blockerbugs/templates/admin/modify_release.html 
 a3bb0d95c49414ff977e82f828ffdd111e105cc6 
   blockerbugs/templates/admin/main.html 
 251b1df1647e307e89bcda365422f1cee59b9a35 
   blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
   blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
   blockerbugs/templates/admin/admin_nav.html 
 34a0c2a966c265ab66166b3170f5f6d507014149 
   blockerbugs/templates/admin/add_spin.html 
 be44830da436e4e87700fe940a7c5197b32d1e82 
   blockerbugs/templates/admin/add_release.html 
 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
   blockerbugs/static/js/admin.js PRE-CREATION 
   blockerbugs/static/css/admin_layout.css PRE-CREATION 
   blockerbugs/models/userinfo.py 019fab2a18af3edd9a0e11e6bdd23f5bf71f94ba 
   blockerbugs/models/user.py a3c613621d1a0ff0d2f5a9e817e1616871c80935 
   blockerbugs/models/update.py cdf8739622af9871d5b1e56eef27faf9fc58768c 
   blockerbugs/models/spin.py b339229e25750df96984d76e15fb61992d14b2e4 
   blockerbugs/models/settings.py 8f268f38aec6c7a4c8fbc76b1d5ce34b6dc706ca 
   blockerbugs/models/release.py ed2b835112e627e91c041ad07da3ba30a3dec5e0 
   blockerbugs/models/milestone.py bd9135b27e12c68cb4c919602f6e90f488abbb83 
   blockerbugs/models/criterion.py 44f986796406d507978743aa211088d28c2829e8 
   blockerbugs/models/build.py PRE-CREATION 
   blockerbugs/models/bug.py c61cf22598431594f7887eb578168fe0b6f4e95c 
   blockerbugs/models/__init__.py 9cb19b13e4691c1d0016e2c82760415f936e9f3f 
   blockerbugs/controllers/users.py 0257c431c61fe9c1f1c502645fa3e58f54970efd 
   blockerbugs/controllers/main.py b72636477dd1a0a50357b262e874204f2129fe9a 
   blockerbugs/controllers/forms.py a16a6d26692a3a0a8c2c6ef16e4d3c886ed8b2ea 
   blockerbugs/controllers/api/validators.py PRE-CREATION 
   blockerbugs/controllers/api/utils.py PRE-CREATION 
   blockerbugs/controllers/api/errors.py PRE-CREATION 
   blockerbugs/controllers/api/api.py PRE-CREATION 
   blockerbugs/controllers/api/__init__.py PRE-CREATION 
   blockerbugs/controllers

Re: Review Request 53: fix sync so that closed bugs don't remain on the buglist

[Martin Krizek]

 On Oct. 11, 2013, 7:54 a.m., Martin Krizek wrote:
  The diff doesn't seem right :) However, looking at 
  https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=hotfix/t421-closedsyncfailureid=e37129e7a5c119d43ac296a09d0f7ff9e8d42795,
   it looks good to me.

https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=hotfix/t421-closedsyncfailureid=e37129e7a5c119d43ac296a09d0f7ff9e8d42795
 (the comma got in the link...)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/53/#review111
---


On Oct. 10, 2013, 4:10 p.m., Tim Flink wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/53/
 ---
 
 (Updated Oct. 10, 2013, 4:10 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 421
 https://fedorahosted.org/fedora-qa/ticket/421
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 This is a simple fix that removes the status restriction from the bugzilla 
 query used during bug sync
 
 
 Diffs
 -
 
   testing/testfunc_update_sync.py 0b92588739c338a0706f083c2306f9b6a2f14e10 
   testing/testfunc_bugsync.py 093115135e6df12be044a14409967c4fa0235d11 
   testing/testfunc_bugmodel.py b02abd4da0082cd5f9749af4cbbfe0958f3a8cbd 
   testing/test_validators.py PRE-CREATION 
   testing/test_updatesync_extract_information.py 
 c5d3f665f475b2a16c4a948a236fc3dc807be453 
   testing/test_spinmodel.py PRE-CREATION 
   testing/test_controllers.py PRE-CREATION 
   testing/test_bugsync_extract_information.py 
 d30c817097778b704e04283de9a96b812dd922ea 
   testing/test_bugchange.py 596e922283bfd20fc0ac6811aa1eef3ef45378ea 
   testing/test_api.py PRE-CREATION 
   testing/conftest.py c30e69ac70a4753a8ef311993b0437ffb0ae0bce 
   setup.py 7b1f26d3d52d5102672f2efc2aad7a8bbd2dbcc7 
   sass/admin_layout.scss PRE-CREATION 
   requirements.txt 29abdbeb36991a6565d403889c5ed5d8d994f423 
   init_db.sh 855df9b0a9776672d60e5546a04c1e05a4957cb4 
   conf/blockerbugs.conf 53f717c6a5e6b39337e074da8b05d64c0cc45c5a 
   blockerbugs/util/update_sync.py 9c46ffc7b3c2f07a73c899165044059447858a48 
   blockerbugs/util/login.py PRE-CREATION 
   blockerbugs/util/koji_interface.py PRE-CREATION 
   blockerbugs/util/bz_interface.py 0676493ab3b8c0789087fcb75f71417c5d9c42d5 
   blockerbugs/util/bug_sync.py dec53ce1d5d998186cea4d63f18a835ee326542e 
   blockerbugs/templates/update_list.html 
 a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f 
   blockerbugs/templates/spin_list.html 
 c455ff4edec0991a453a94cd0e38d959e1757672 
   blockerbugs/templates/login.html 6023c25e3436257c1c6a1027a9b37ec21f62cee9 
   blockerbugs/templates/layout.html 28c22872b716d7125880710db53881a73bc8cdc8 
   blockerbugs/templates/base_nav.html 
 021ddb3126b4c0f30a231d8d9b32df09c669280e 
   blockerbugs/templates/admin_layout.html PRE-CREATION 
   blockerbugs/templates/admin/spin_edit.html PRE-CREATION 
   blockerbugs/templates/admin/spin_create.html PRE-CREATION 
   blockerbugs/templates/admin/modify_release.html 
 a3bb0d95c49414ff977e82f828ffdd111e105cc6 
   blockerbugs/templates/admin/main.html 
 251b1df1647e307e89bcda365422f1cee59b9a35 
   blockerbugs/templates/admin/generate_api_key.html PRE-CREATION 
   blockerbugs/templates/admin/edit_userinfo.html PRE-CREATION 
   blockerbugs/templates/admin/admin_nav.html 
 34a0c2a966c265ab66166b3170f5f6d507014149 
   blockerbugs/templates/admin/add_spin.html 
 be44830da436e4e87700fe940a7c5197b32d1e82 
   blockerbugs/templates/admin/add_release.html 
 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
   blockerbugs/static/js/admin.js PRE-CREATION 
   blockerbugs/static/css/admin_layout.css PRE-CREATION 
   blockerbugs/models/userinfo.py 019fab2a18af3edd9a0e11e6bdd23f5bf71f94ba 
   blockerbugs/models/user.py a3c613621d1a0ff0d2f5a9e817e1616871c80935 
   blockerbugs/models/update.py cdf8739622af9871d5b1e56eef27faf9fc58768c 
   blockerbugs/models/spin.py b339229e25750df96984d76e15fb61992d14b2e4 
   blockerbugs/models/settings.py 8f268f38aec6c7a4c8fbc76b1d5ce34b6dc706ca 
   blockerbugs/models/release.py ed2b835112e627e91c041ad07da3ba30a3dec5e0 
   blockerbugs/models/milestone.py bd9135b27e12c68cb4c919602f6e90f488abbb83 
   blockerbugs/models/criterion.py 44f986796406d507978743aa211088d28c2829e8 
   blockerbugs/models/build.py PRE-CREATION 
   blockerbugs/models/bug.py c61cf22598431594f7887eb578168fe0b6f4e95c 
   blockerbugs/models/__init__.py 9cb19b13e4691c1d0016e2c82760415f936e9f3f 
   blockerbugs/controllers/users.py 0257c431c61fe9c1f1c502645fa3e58f54970efd 
   blockerbugs/controllers/main.py b72636477dd1a0a50357b262e874204f2129fe9a 
   blockerbugs/controllers/forms.py a16a6d26692a3a0a8c2c6ef16e4d3c886ed8b2ea 
   blockerbugs/controllers/api/validators.py PRE-CREATION 
   blockerbugs/controllers/api/utils.py

Review Request 55: milestone_info uses hardcoded bugzilla url instead of using config value

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/55/
---

Review request for blockerbugs.


Bugs: t423
https://fedorahosted.org/fedora-qa/ticket/t423


Repository: blockerbugs


Description
---

commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28
Author: Martin Krizek mkri...@redhat.com
Date:   Fri Oct 11 12:49:54 2013 +0200

Don't use hardcoded bz url in the milestone_info template


Diffs
-

  blockerbugs/templates/milestone_info.html 
bac8fa075ef4fd40c95fb35885951845d483b521 
  blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 

Diff: http://reviewboard-tflink.rhcloud.com/r/55/diff/


Testing
---

I tested it on my local machine.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review swap: python-jsmin, python-cssmin

[Martin Krizek]

Hi,

anyone willing to review or swap reviews?

https://bugzilla.redhat.com/show_bug.cgi?id=1014607
https://bugzilla.redhat.com/show_bug.cgi?id=1014601

Thanks!
Martin
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swap: python-jsmin, python-cssmin

[Martin Krizek]

- Original Message -
 From: Stephen Gallagher sgall...@redhat.com
 To: Development discussions related to Fedora 
 devel@lists.fedoraproject.org
 Cc: Martin Krizek mkri...@redhat.com
 Sent: Friday, October 4, 2013 2:33:50 PM
 Subject: Re: Review swap: python-jsmin, python-cssmin
 
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 On 10/04/2013 07:57 AM, Martin Krizek wrote:
  Hi,
  
  anyone willing to review or swap reviews?
  
  https://bugzilla.redhat.com/show_bug.cgi?id=1014607
  https://bugzilla.redhat.com/show_bug.cgi?id=1014601
  
  Thanks! Martin
  
 
 Has JSMin finally changed to an acceptable license? It's got a long
 history of including a line The Software shall be used for Good, not
 Evil. which makes the license unenforceable and unsuitable for
 inclusion in Fedora.
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.4.14 (GNU/Linux)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iEYEARECAAYFAlJOta4ACgkQeiVVYja6o6MNlgCgg9HhrfMX9xuMjU6pnV3ptA0+
 wKkAn247tK9UiqmLyX5xUAfPq4o9ZeCa
 =Y1cL
 -END PGP SIGNATURE-
 

It's MIT.

Martin
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review Request 45: Improve asset management

[Martin Krizek]

 On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
  I attempted to test this on an el6 machine, got a traceback when doing 
  sync. tb added to trac ticket
 
 Martin Krizek wrote:
 Yeah, python-webassets needs to be installed, it's missing in Requires 
 (and in epel repo, it's present in Fedora though), I filed a bug -- 
 https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and 
 created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as 
 they were easy enough to package.
 
 Martin Krizek wrote:
 I can probably fix issues in python-flask-assets and python-webassets so 
 we can have this working until it is officially fixed...
 
 Tim Flink wrote:
 Not sure I understand what's required with python-webassets, that bzid 
 shows up as invalid and I can't find anything filed against python-webassets 
 that talks about epel. Any of the required packages would need to be in epel 
 or at least epel-testing before we deploy to production, though. That's why 
 builds for develop have been slow - I keep hoping that the last build will 
 get done.

https://bugzilla.redhat.com/show_bug.cgi?id=1014147 -- there was a dot in the 
link above.

It's reported against python-flask-assets. So what needs to be done is to push 
python-webassets to epel and put it as Requires in the python-flask-assets spec 
file. Another thing is to send python-jsmin and python-cssmin for a package 
review.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/#review100
---


On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/45/
 ---
 
 (Updated Aug. 29, 2013, 10:23 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 357
 https://fedorahosted.org/fedora-qa/ticket/357
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit d86f88d7f9da899ffef44ad617a8a831327b7d80
 Author: Martin Krizek mkri...@redhat.com
 Date:   Mon Aug 12 16:40:16 2013 +0200
 
 Improve asset management
 
 Fixes: #357
 
 
 I have not minified two js files in milestone_stats.html template as I am not 
 sure it's worth it, any objections?
 
 
 Diffs
 -
 
   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
   blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
 
 
 Testing
 ---
 
 Loaded pages, seems like css and js work as expected after being minified.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 45: Improve asset management

[Martin Krizek]

 On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
  I attempted to test this on an el6 machine, got a traceback when doing 
  sync. tb added to trac ticket
 
 Martin Krizek wrote:
 Yeah, python-webassets needs to be installed, it's missing in Requires 
 (and in epel repo, it's present in Fedora though), I filed a bug -- 
 https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and 
 created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as 
 they were easy enough to package.
 
 Martin Krizek wrote:
 I can probably fix issues in python-flask-assets and python-webassets so 
 we can have this working until it is officially fixed...
 
 Tim Flink wrote:
 Not sure I understand what's required with python-webassets, that bzid 
 shows up as invalid and I can't find anything filed against python-webassets 
 that talks about epel. Any of the required packages would need to be in epel 
 or at least epel-testing before we deploy to production, though. That's why 
 builds for develop have been slow - I keep hoping that the last build will 
 get done.
 
 Martin Krizek wrote:
 https://bugzilla.redhat.com/show_bug.cgi?id=1014147 -- there was a dot in 
 the link above.
 
 It's reported against python-flask-assets. So what needs to be done is to 
 push python-webassets to epel and put it as Requires in the 
 python-flask-assets spec file. Another thing is to send python-jsmin and 
 python-cssmin for a package review.

I sent python-cssmin and python-jsmin for package review:
https://bugzilla.redhat.com/show_bug.cgi?id=1014601
https://bugzilla.redhat.com/show_bug.cgi?id=1014607


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/#review100
---


On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/45/
 ---
 
 (Updated Aug. 29, 2013, 10:23 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 357
 https://fedorahosted.org/fedora-qa/ticket/357
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit d86f88d7f9da899ffef44ad617a8a831327b7d80
 Author: Martin Krizek mkri...@redhat.com
 Date:   Mon Aug 12 16:40:16 2013 +0200
 
 Improve asset management
 
 Fixes: #357
 
 
 I have not minified two js files in milestone_stats.html template as I am not 
 sure it's worth it, any objections?
 
 
 Diffs
 -
 
   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
   blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
 
 
 Testing
 ---
 
 Loaded pages, seems like css and js work as expected after being minified.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 45: Improve asset management

[Martin Krizek]

 On Sept. 24, 2013, 3:44 p.m., Tim Flink wrote:
  I attempted to test this on an el6 machine, got a traceback when doing 
  sync. tb added to trac ticket

Yeah, python-webassets needs to be installed, it's missing in Requires (and in 
epel repo, it's present in Fedora though), I filed a bug -- 
https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and 
created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as 
they were easy enough to package.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/#review100
---


On Aug. 29, 2013, 10:23 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/45/
 ---
 
 (Updated Aug. 29, 2013, 10:23 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 357
 https://fedorahosted.org/fedora-qa/ticket/357
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit d86f88d7f9da899ffef44ad617a8a831327b7d80
 Author: Martin Krizek mkri...@redhat.com
 Date:   Mon Aug 12 16:40:16 2013 +0200
 
 Improve asset management
 
 Fixes: #357
 
 
 I have not minified two js files in milestone_stats.html template as I am not 
 sure it's worth it, any objections?
 
 
 Diffs
 -
 
   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
   blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
 
 
 Testing
 ---
 
 Loaded pages, seems like css and js work as expected after being minified.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 44: Update URLs should contain the update ID when possible

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/44/
---

(Updated Sept. 27, 2013, 7:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 386
https://fedorahosted.org/fedora-qa/ticket/386


Repository: blockerbugs


Description
---

commit be73d7514172ad122ec969b74a1bac37f14f28f4
Author: Martin Krizek mkri...@redhat.com
Date:   Mon Aug 12 14:52:39 2013 +0200

Update URLs should comtain the update ID when possible

Fixes: #386


Diffs
-

  blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11 

Diff: http://reviewboard-tflink.rhcloud.com/r/44/diff/


Testing
---

Run sync without the fix to fetch urls with title in them. Then I run sync with 
the fix, the sync process updated the urls to contain updateid instead of title.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 42: Indicate bugs that are needinfo

[Martin Krizek]

 On Sept. 20, 2013, 11:51 p.m., Tim Flink wrote:
  When doing some functional testing on this, I found that if a bug is 
  needinfo and recently modified, the two icons end up above and below 
  eachother in a taller row instead of next to eachother on a normal height 
  row as they should be. I was able to reproduce this in both firefox and 
  chromium.
  
  After futzing with the css and html for a while, I haven't found an awesome 
  solution to this yet. The best I've come up with is to change the th/th 
  on the first column to something that's effectively:
  
  th style=width=50px/th
  
  I don't like it but I haven't come up with a better solution. Either way, 
  it needs to be fixed before this code is done.

I found out that this happens only when status is longer than 'NEW' (or 'POST' 
possibly), just a note. Other solution to this would be to delete space 
character between spans, it is not as hackish as the width one but might not 
look very good without the space between the two icons. Anyway, I am probably 
fine with both.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/#review99
---


On Aug. 29, 2013, 10:25 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/42/
 ---
 
 (Updated Aug. 29, 2013, 10:25 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 316
 https://fedorahosted.org/fedora-qa/ticket/316
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 This patch adds a needinfo field into the Bug table. The field is filed with 
 the name of a user that the info is needed from, or empty string if needinfo 
 is not set. If needinfo is set, an icon is displayed in bug list in the same 
 way as the 'recently modified' icon -- any ideas on how to display the 
 information better?
 
 
 Diffs
 -
 
   sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c 
   sass/_settings.scss 0365d08d950f4fa3c72223ee9bc32be82cf5d270 
   blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 
   blockerbugs/templates/blocker_list.html 
 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 
   blockerbugs/static/css/general_foundicons.css 
 d46e3b5b5e9452aadedfbb1bc275934a0cea43ec 
   blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
   blockerbugs/static/css/app-foundation.css 
 852272bf1bd1c629b30933b451daceec31812de7 
   blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c 
   alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
 
 
 Testing
 ---
 
 Run db sync, one of the bugs had needinfo flag set, everything worked as 
 expected.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 52: Clean leftovers missed in reviews

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/
---

(Updated Sept. 25, 2013, 11:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Repository: blockerbugs


Description
---

While going through documentation and commits since last release I found some 
leftovers missed in reviews.


Diffs
-

  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 

Diff: http://reviewboard-tflink.rhcloud.com/r/52/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 52: Clean leftovers missed in reviews

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/#review98
---



blockerbugs/controllers/main.py
http://reviewboard-tflink.rhcloud.com/r/52/#comment135

This really should be merged in develop as well as it would result in a 
traceback when one tries to associate his fas and bugzilla accounts. I don't 
see it fixed anywhere.



blockerbugs/controllers/main.py
http://reviewboard-tflink.rhcloud.com/r/52/#comment134

This is just unused variable.


- Martin Krizek


On Sept. 13, 2013, 11:08 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/52/
 ---
 
 (Updated Sept. 13, 2013, 11:08 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 While going through documentation and commits since last release I found some 
 leftovers missed in reviews.
 
 
 Diffs
 -
 
   blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
   blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/52/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 52: Clean leftovers missed in reviews

[Martin Krizek]

 On Sept. 19, 2013, 7:47 p.m., Tim Flink wrote:
  I'm OK with removing the --logfile option from the CLI parser but let's 
  hold off on the user changes since ilgiz has already addressed those 
  issues. I'd rather not be fixing that in multiple places at the same time - 
  it's a great recipe for confusion and merge issues

I remove the --logfile option and unused import, it's in develop. I commented 
on the rest in the diff...


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/#review96
---


On Sept. 13, 2013, 11:08 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/52/
 ---
 
 (Updated Sept. 13, 2013, 11:08 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 While going through documentation and commits since last release I found some 
 leftovers missed in reviews.
 
 
 Diffs
 -
 
   blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
   blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/52/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 52: Clean leftovers missed in reviews

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/
---

Review request for blockerbugs.


Repository: blockerbugs


Description
---

While going through documentation and commits since last release I found some 
leftovers missed in reviews.


Diffs
-

  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
  blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 

Diff: http://reviewboard-tflink.rhcloud.com/r/52/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 51: irc list sort order doesn't match html buglist

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/51/
---

Review request for blockerbugs.


Bugs: 416
https://fedorahosted.org/fedora-qa/ticket/416


Repository: blockerbugs


Description
---

commit 7462ba2ac917381e0f1430fdf4421293fe26ddeb
Author: Martin Krizek mkri...@redhat.com
Date:   Wed Sep 11 14:34:56 2013 +0200

Sort irc and bug lists in the same order

Fixes: #416


Diffs
-

  blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 

Diff: http://reviewboard-tflink.rhcloud.com/r/51/diff/


Testing
---

Tested on my local dev instance. Works for me.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 46: New admin interface and builds support

[Martin Krizek]

 On Aug. 23, 2013, 12:59 p.m., Martin Krizek wrote:
  blockerbugs/models/build.py, line 19
  http://reviewboard-tflink.rhcloud.com/r/46/diff/3/?file=936#file936line19
 
  I wonder if these strings should be limited in length.
 
 Ilgiz Islamgulov wrote:
 you're right

Could you include that in the patch, please?

Otherwise, it looks good to me.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review77
---


On Aug. 28, 2013, 10:20 a.m., Ilgiz Islamgulov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/46/
 ---
 
 (Updated Aug. 28, 2013, 10:20 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 Implement new admin interface with flask-admin
 Add build support
 
 
 Diffs
 -
 
   testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
   testing/test_spinmodel.py PRE-CREATION 
   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
   sass/admin_layout.scss PRE-CREATION 
   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
   blockerbugs/util/koji_interface.py PRE-CREATION 
   blockerbugs/templates/spin_list.html 
 c455ff4edec0991a453a94cd0e38d959e1757672 
   blockerbugs/templates/admin_layout.html PRE-CREATION 
   blockerbugs/templates/admin/modify_release.html 
 a3bb0d95c49414ff977e82f828ffdd111e105cc6 
   blockerbugs/templates/admin/main.html 
 251b1df1647e307e89bcda365422f1cee59b9a35 
   blockerbugs/templates/admin/admin_nav.html 
 34a0c2a966c265ab66166b3170f5f6d507014149 
   blockerbugs/templates/admin/add_spin.html 
 be44830da436e4e87700fe940a7c5197b32d1e82 
   blockerbugs/templates/admin/add_release.html 
 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
   blockerbugs/static/js/admin.js PRE-CREATION 
   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
   blockerbugs/models/build.py PRE-CREATION 
   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
   blockerbugs/controllers/api/utils.py 
 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
   blockerbugs/controllers/admin/spin.py PRE-CREATION 
   blockerbugs/controllers/admin/build.py PRE-CREATION 
   blockerbugs/controllers/admin/auth.py PRE-CREATION 
   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
 
 
 Testing
 ---
 
 I've tested on my develop instance.
 
 
 Thanks,
 
 Ilgiz Islamgulov
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 45: Improve asset management

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/
---

(Updated Aug. 29, 2013, 10:23 a.m.)


Review request for blockerbugs.


Changes
---

Added python-flask-assets as dependency in the spec file.

Also, updates of the new version of python-flask-assets were send to bodhi -- 
https://admin.fedoraproject.org/updates/python-flask-assets


Bugs: 357
https://fedorahosted.org/fedora-qa/ticket/357


Repository: blockerbugs


Description
---

commit d86f88d7f9da899ffef44ad617a8a831327b7d80
Author: Martin Krizek mkri...@redhat.com
Date:   Mon Aug 12 16:40:16 2013 +0200

Improve asset management

Fixes: #357


I have not minified two js files in milestone_stats.html template as I am not 
sure it's worth it, any objections?


Diffs (updated)
-

  requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
  blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
  blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
  blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 

Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/


Testing
---

Loaded pages, seems like css and js work as expected after being minified.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 42: Indicate bugs that are needinfo

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/
---

(Updated Aug. 29, 2013, 10:25 a.m.)


Review request for blockerbugs.


Bugs: 316
https://fedorahosted.org/fedora-qa/ticket/316


Repository: blockerbugs


Description
---

This patch adds a needinfo field into the Bug table. The field is filed with 
the name of a user that the info is needed from, or empty string if needinfo is 
not set. If needinfo is set, an icon is displayed in bug list in the same way 
as the 'recently modified' icon -- any ideas on how to display the information 
better?


Diffs (updated)
-

  sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c 
  sass/_settings.scss 0365d08d950f4fa3c72223ee9bc32be82cf5d270 
  blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 
  blockerbugs/templates/blocker_list.html 
17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 
  blockerbugs/static/css/general_foundicons.css 
d46e3b5b5e9452aadedfbb1bc275934a0cea43ec 
  blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
  blockerbugs/static/css/app-foundation.css 
852272bf1bd1c629b30933b451daceec31812de7 
  blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c 
  alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/


Testing
---

Run db sync, one of the bugs had needinfo flag set, everything worked as 
expected.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 46: New admin interface and builds support

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review81
---


When trying to create new release I get:

[view.py:757] 2013-08-26 14:34:04 ERROR   Failed to create model
Traceback (most recent call last):
  File 
/home/mkrizek/devel/blockerbugs/env_blockerbugs/lib/python2.7/site-packages/flask_admin/contrib/sqlamodel/view.py,
 line 750, in create_model
model = self.model()
TypeError: __init__() takes at least 2 arguments (1 given)

- Martin Krizek


On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/46/
 ---
 
 (Updated Aug. 22, 2013, 7:01 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 Implement new admin interface with flask-admin
 Add build support
 
 
 Diffs
 -
 
   testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
   testing/test_spinmodel.py PRE-CREATION 
   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
   sass/admin_layout.scss PRE-CREATION 
   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
   blockerbugs/util/koji_interface.py PRE-CREATION 
   blockerbugs/templates/spin_list.html 
 c455ff4edec0991a453a94cd0e38d959e1757672 
   blockerbugs/templates/admin_layout.html PRE-CREATION 
   blockerbugs/templates/admin/modify_release.html 
 a3bb0d95c49414ff977e82f828ffdd111e105cc6 
   blockerbugs/templates/admin/main.html 
 251b1df1647e307e89bcda365422f1cee59b9a35 
   blockerbugs/templates/admin/admin_nav.html 
 34a0c2a966c265ab66166b3170f5f6d507014149 
   blockerbugs/templates/admin/add_spin.html 
 be44830da436e4e87700fe940a7c5197b32d1e82 
   blockerbugs/templates/admin/add_release.html 
 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
   blockerbugs/static/js/admin.js PRE-CREATION 
   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
   blockerbugs/models/build.py PRE-CREATION 
   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
   blockerbugs/controllers/api/utils.py 
 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
   blockerbugs/controllers/admin/spin.py PRE-CREATION 
   blockerbugs/controllers/admin/build.py PRE-CREATION 
   blockerbugs/controllers/admin/auth.py PRE-CREATION 
   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
 
 
 Testing
 ---
 
 I've tested on my develop instance.
 
 
 Thanks,
 
 Ilgiz Islamgulov
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 46: New admin interface and builds support

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/46/#review77
---



alembic/versions/1162fb4d4358_added_build_table.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment122

Just curious, why is this needed?



blockerbugs/__init__.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment123

Is this import useful for anything after removing the line below?



blockerbugs/models/build.py
http://reviewboard-tflink.rhcloud.com/r/46/#comment124

I wonder if these strings should be limited in length.


- Martin Krizek


On Aug. 22, 2013, 7:01 p.m., Ilgiz Islamgulov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/46/
 ---
 
 (Updated Aug. 22, 2013, 7:01 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 Implement new admin interface with flask-admin
 Add build support
 
 
 Diffs
 -
 
   testing/testfunc_update_sync.py 70c600515ccc5e97ed17b4cadd40d76277794b67 
   testing/testfunc_bugsync.py 496f2994dda81bc82f2e270944a3fb2b391d9d91 
   testing/testfunc_bugmodel.py a50f3458b2154f13736ab1f93cb3d1a86a48fcb1 
   testing/test_spinmodel.py PRE-CREATION 
   testing/test_controllers.py 702d2a5390e42910176d327461ef628e6bf8b849 
   testing/test_api.py e92dda539117f94f3283f6ce262d65295a5e32c1 
   setup.py 89621b0debb5d368a027a4801de7da62fa961eab 
   sass/admin_layout.scss PRE-CREATION 
   requirements.txt 98eab5da9306a101a41dd13708df1900e9fd1018 
   blockerbugs/util/koji_interface.py PRE-CREATION 
   blockerbugs/templates/spin_list.html 
 c455ff4edec0991a453a94cd0e38d959e1757672 
   blockerbugs/templates/admin_layout.html PRE-CREATION 
   blockerbugs/templates/admin/modify_release.html 
 a3bb0d95c49414ff977e82f828ffdd111e105cc6 
   blockerbugs/templates/admin/main.html 
 251b1df1647e307e89bcda365422f1cee59b9a35 
   blockerbugs/templates/admin/admin_nav.html 
 34a0c2a966c265ab66166b3170f5f6d507014149 
   blockerbugs/templates/admin/add_spin.html 
 be44830da436e4e87700fe940a7c5197b32d1e82 
   blockerbugs/templates/admin/add_release.html 
 931001b23f52dd1b75fe0feb8d0311b76fcc907e 
   blockerbugs/static/js/admin.js PRE-CREATION 
   blockerbugs/models/update.py 9660d038720bcecae8e4f7401e09e26bd6589189 
   blockerbugs/models/spin.py fa8e0e9a887f269cf31e850baa90678ff7055b78 
   blockerbugs/models/release.py cca27cff41875528c1ee13d95194de5f237f31d4 
   blockerbugs/models/milestone.py 31667f6467ed111c3594cdd86d1c933f73b7dfc2 
   blockerbugs/models/build.py PRE-CREATION 
   blockerbugs/models/__init__.py 0223fff2996290005bd50412c844979304ce38a2 
   blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd 
   blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 
   blockerbugs/controllers/api/utils.py 
 38144dd48f3190f709a9bafa3a5a425dfdfffbdf 
   blockerbugs/controllers/api/api.py d6df7d34170da05bd817b12545596f34b43b9da6 
   blockerbugs/controllers/admin/spin.py PRE-CREATION 
   blockerbugs/controllers/admin/build.py PRE-CREATION 
   blockerbugs/controllers/admin/auth.py PRE-CREATION 
   blockerbugs/controllers/admin/__init__.py PRE-CREATION 
   blockerbugs/controllers/admin.py 4ce6c9f58b5513c280312c8d1dd92c341d259d0a 
   blockerbugs/config.py 03e8b2a92aaaf7328b68c3fa4eb585a189f52186 
   blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f 
   blockerbugs.spec cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce 
   alembic/versions/f9e369bf00d_added_spin_type_cons.py PRE-CREATION 
   alembic/versions/1162fb4d4358_added_build_table.py PRE-CREATION 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/46/diff/
 
 
 Testing
 ---
 
 I've tested on my develop instance.
 
 
 Thanks,
 
 Ilgiz Islamgulov
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 42: Indicate bugs that are needinfo

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/
---

(Updated Aug. 21, 2013, 8:29 a.m.)


Review request for blockerbugs.


Bugs: 316
https://fedorahosted.org/fedora-qa/ticket/316


Repository: blockerbugs


Description
---

This patch adds a needinfo field into the Bug table. The field is filed with 
the name of a user that the info is needed from, or empty string if needinfo is 
not set. If needinfo is set, an icon is displayed in bug list in the same way 
as the 'recently modified' icon -- any ideas on how to display the information 
better?


Diffs (updated)
-

  sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c 
  blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 
  blockerbugs/templates/blocker_list.html 
17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 
  blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
  blockerbugs/static/css/app-foundation.css 
852272bf1bd1c629b30933b451daceec31812de7 
  blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c 
  alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/


Testing
---

Run db sync, one of the bugs had needinfo flag set, everything worked as 
expected.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 42: Indicate bugs that are needinfo

[Martin Krizek]

 On Aug. 15, 2013, 4:29 p.m., Tim Flink wrote:
  the sync crashed for me when I tried to run it, will put the tb in trac 
  since I don't know how to do preformatted text in a review.
  
  On a side note, those css diffs make me want to migrate to foundation 4 
  even more than before - that's a crazy diff for such a small change :-/

Could you please put the tb in trac? Thanks!


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/#review67
---


On Aug. 8, 2013, 11:33 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/42/
 ---
 
 (Updated Aug. 8, 2013, 11:33 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 316
 https://fedorahosted.org/fedora-qa/ticket/316
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 This patch adds a needinfo field into the Bug table. The field is filed with 
 the name of a user that the info is needed from, or empty string if needinfo 
 is not set. If needinfo is set, an icon is displayed in bug list in the same 
 way as the 'recently modified' icon -- any ideas on how to display the 
 information better?
 
 
 Diffs
 -
 
   sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c 
   blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 
   blockerbugs/templates/blocker_list.html 
 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 
   blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
   blockerbugs/static/css/app-foundation.css 
 852272bf1bd1c629b30933b451daceec31812de7 
   blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c 
   alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
 
 
 Testing
 ---
 
 Run db sync, one of the bugs had needinfo flag set, everything worked as 
 expected.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 44: Update URLs should contain the update ID when possible

[Martin Krizek]

 On Aug. 15, 2013, 4:10 p.m., Tim Flink wrote:
  Does this work with ilgiz's update_sync code? Is anything other than the 
  display code relying on having the URL? ie, what else could break by 
  suddenly changing the update url during sync?

It does work, according to my testing, with ilgiz's update_sync code. I don't 
see anything other than the display code relying on the URL.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/44/#review66
---


On Aug. 12, 2013, 12:57 p.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/44/
 ---
 
 (Updated Aug. 12, 2013, 12:57 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 386
 https://fedorahosted.org/fedora-qa/ticket/386
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit be73d7514172ad122ec969b74a1bac37f14f28f4
 Author: Martin Krizek mkri...@redhat.com
 Date:   Mon Aug 12 14:52:39 2013 +0200
 
 Update URLs should comtain the update ID when possible
 
 Fixes: #386
 
 
 Diffs
 -
 
   blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/44/diff/
 
 
 Testing
 ---
 
 Run sync without the fix to fetch urls with title in them. Then I run sync 
 with the fix, the sync process updated the urls to contain updateid instead 
 of title.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 45: Improve asset management

[Martin Krizek]

 On Aug. 15, 2013, 4:06 p.m., Tim Flink wrote:
  The problem here is how to deploy this in production - there is a 
  python-flask-assets package but it is at 0.7 instead of upstream's 0.8 and 
  there does not appear to be an el6 build either way (branch exists but it's 
  empty).
  
  Once the dep is figured out and the spec updated, we can talk about getting 
  this code in but right now it can't be deployed to production

I sent an e-mail to the author of the package asking about the state of the 
package. We'll see...


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/#review65
---


On Aug. 12, 2013, 2:46 p.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/45/
 ---
 
 (Updated Aug. 12, 2013, 2:46 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 357
 https://fedorahosted.org/fedora-qa/ticket/357
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit d86f88d7f9da899ffef44ad617a8a831327b7d80
 Author: Martin Krizek mkri...@redhat.com
 Date:   Mon Aug 12 16:40:16 2013 +0200
 
 Improve asset management
 
 Fixes: #357
 
 
 I have not minified two js files in milestone_stats.html template as I am not 
 sure it's worth it, any objections?
 
 
 Diffs
 -
 
   requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95 
   blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
   blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
 
 
 Testing
 ---
 
 Loaded pages, seems like css and js work as expected after being minified.
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 44: Update URLs should contain the update ID when possible

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/44/
---

Review request for blockerbugs.


Bugs: 386
https://fedorahosted.org/fedora-qa/ticket/386


Repository: blockerbugs


Description
---

commit be73d7514172ad122ec969b74a1bac37f14f28f4
Author: Martin Krizek mkri...@redhat.com
Date:   Mon Aug 12 14:52:39 2013 +0200

Update URLs should comtain the update ID when possible

Fixes: #386


Diffs
-

  blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11 

Diff: http://reviewboard-tflink.rhcloud.com/r/44/diff/


Testing
---

Run sync without the fix to fetch urls with title in them. Then I run sync with 
the fix, the sync process updated the urls to contain updateid instead of title.


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 39: Migrate from FAS to FAS-OpenID

[Martin Krizek]

 On July 17, 2013, 5:19 a.m., Tim Flink wrote:
  Don't python-openid-cla and python-openid-teams need to be added to the 
  requirements.txt file? Does the python-fedora stuff really need to be added 
  to site-packages by hand with the bump in required python fedora version?
  
  What all of that list is going to be required above and beyond the changes 
  shown here? I'm not crazy about the idea of releasing like that but I'm 
  suspecting that most of it would go away once a new python-fedora release 
  is done
 
 Martin Krizek wrote:
 Exactly, this is only temporary since python-fedora containing 
 flask_fas_openid.py hasn't been released yet (to my knowledge, at least). 
 Sorry for not pointing that out.
 
 Tim Flink wrote:
 since the fas-openid stuff has been hotfixed into the infra hosts and it 
 might be a bit before we see a new python-fedora release, let's get this into 
 develop. I'd like to get testing on our dev host soon and am planning to 
 hotfix the flask-fas-openid stuff into our dev host

I merged this into develop. Let's keep the review open until we test it on the 
dev host?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/39/#review43
---


On July 16, 2013, 12:43 p.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/39/
 ---
 
 (Updated July 16, 2013, 12:43 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 383
 https://fedorahosted.org/fedora-qa/ticket/383
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 commit 211eafe3e90012dce2e99e0fb2f89fbb900062b7
 Author: Patrick Uiterwijk puiterw...@gmail.com
 Date:   Thu May 2 10:33:05 2013 +0200
 
 Port blockerbugs to OpenID
 
 
 Diffs
 -
 
   requirements.txt e5aeb0dfeeadb5637ddd7f6aafd9fe07ef576c23 
   blockerbugs/templates/login.html 6023c25e3436257c1c6a1027a9b37ec21f62cee9 
   blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 
   blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/39/diff/
 
 
 Testing
 ---
 
 To make this work, following things need to be done:
 
 wget 
 https://raw.github.com/fedora-infra/python-fedora/develop/flask_fas_openid.py
 # apply 
 http://mkrizek.fedorapeople.org/0001-flask_fas_openid.py-fix-imports.patch 
 (sent to Patrick Uiterwijk)
 cp flask_fas_openid.py site-packages
 pip install python-openid-cla
 pip install python-openid-teams
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 31: Display flash messages in appropriate place

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/31/
---

(Updated July 3, 2013, 9:01 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 367
https://fedorahosted.org/fedora-qa/ticket/367


Repository: blockerbugs


Description
---

This patch adds ability to display all flash messages in one common place, 
under the main menu bar.


Diffs
-

  blockerbugs/templates/layout.html 28c22872b716d7125880710db53881a73bc8cdc8 

Diff: http://reviewboard-tflink.rhcloud.com/r/31/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 23: Bugzilla Faults During Proposal are not logged, lead to http 500 errors

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/23/
---

(Updated June 25, 2013, 2:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 372
https://fedorahosted.org/fedora-qa/ticket/372


Repository: blockerbugs


Description
---

This patch wraps bugzilla faults in a BugzillaError and prevents them from not 
being logged and generating http 500 server error.


Diffs
-

  testing/test_bugchange.py 596e922283bfd20fc0ac6811aa1eef3ef45378ea 
  blockerbugs/util/bz_interface.py 0579b2455b57a03e3bee570b8cd97aac0eeaf1a4 
  blockerbugs/controllers/main.py 6d32e5de91900cda33f5e0342c7854adb24fc8b6 

Diff: http://reviewboard-tflink.rhcloud.com/r/23/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 24: Logo in Upper Left Corner Should be a Link to Main Index

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/24/
---

(Updated April 30, 2013, 7:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 369
https://fedorahosted.org/fedora-qa/ticket/369


Repository: blockerbugs


Description
---

commit 06b3fc725ad3e219b1ef09aa56abe0152932ce05
Author: Martin Krizek mkri...@redhat.com
Date:   Wed Apr 24 13:01:58 2013 +0200

Make logo in upper left corner link to main page

Fixes: #369


Diffs
-

  blockerbugs/templates/layout.html 271b09054e9689fbf60a0dc8285022fd988824be 

Diff: http://reviewboard-tflink.rhcloud.com/r/24/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 21: Milestone Update List Generates HTTP 500 Error

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/21/
---

Review request for blockerbugs.


Bugs: 382
https://fedorahosted.org/fedora-qa/ticket/382


Repository: blockerbugs


Description
---

commit 9df9a31b61b4e952a0bb5f5c1c56dc62ac9923a6
Author: Martin Krizek mkri...@redhat.com
Date:   Mon Apr 22 09:50:32 2013 +0200

Replace NTH with FE in the rest of places.

commit 39cef0d8cfe416ed401174c8c4a5a51b3ca0af2d
Author: Martin Krizek mkri...@redhat.com
Date:   Mon Apr 22 09:37:20 2013 +0200

Fix out of date field names for bug objects


Diffs
-

  docs/source/index.rst f07f013268aaa01cec780efec6e320c6cb267339 
  docs/source/development.rst 35b1b34a6b81d8d35e91fb11d32b35dc5d8269a9 
  blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 
  blockerbugs/templates/propose_bug.html 
7c1ac3d1f7202ad96214d064145f026b251754d1 
  blockerbugs/__init__.py aebfe96cc9268f6bbeab3d0bb0c9ae3a4218986b 

Diff: http://reviewboard-tflink.rhcloud.com/r/21/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 20: Rework Logging Mechanisms

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/20/#review23
---

Ship it!


Ship It!

- Martin Krizek


On April 18, 2013, 3:03 p.m., Tim Flink wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/20/
 ---
 
 (Updated April 18, 2013, 3:03 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 374
 https://fedorahosted.org/fedora-qa/ticket/374
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 This is code to rework logging mechanisms for fedora-infra standards. It 
 changed a bit from martin's original code, so I'm creating a new review 
 request.
 
 
 Diffs
 -
 
   sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7 
   conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce 
   conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae 
   blockerbugs/util/update_sync.py 9c46ffc7b3c2f07a73c899165044059447858a48 
   blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887 
   blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1 
   blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a 
   blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2 
   blockerbugs/static/img/repeater-stg.png 
 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4 
   blockerbugs/static/img/blockerbugs-logo-light-stg.png 
 b94f3891dd4726eac435c8a03c2ac0a2daafef39 
   blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505 
   blockerbugs/static/css/app-foundation.css 
 852272bf1bd1c629b30933b451daceec31812de7 
   blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f 
   blockerbugs/cli.py 5cfc306a9051555ad972fd05c627f906d3b2 
   blockerbugs/__init__.py aebfe96cc9268f6bbeab3d0bb0c9ae3a4218986b 
   blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
 
 
 Testing
 ---
 
 local and dev VM testing, currently running on 
 qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
 
 
 Thanks,
 
 Tim Flink
 


___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Review Request 19: Rework Logging Mechanisms

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/19/
---

Review request for blockerbugs.


Bugs: 374
https://fedorahosted.org/fedora-qa/ticket/374


Repository: blockerbugs


Description
---

This patch reworks logging to both, the application and syncs. Both log to 
stdout and to separate files, only if they are configured in config.py though.


Diffs
-

  blockerbugs/util/update_sync.py 7a6af995df3c6aa9d34a6e0ebad9b0fab2d28760 
  blockerbugs/util/bz_interface.py 2a7a9d128ee87bfb332426a8ada373a9a478a97a 
  blockerbugs/util/bug_sync.py 2e76680e1701fc3de521a2c3c9f995ae379b944f 
  blockerbugs/controllers/main.py 6d32e5de91900cda33f5e0342c7854adb24fc8b6 
  blockerbugs/config.py 2806ca0abb2fefd29505677e76fcf240149dc380 
  blockerbugs/cli.py 833e27585e427d4ee24f01fc5355469ce07d92ce 
  blockerbugs/__init__.py 7809b1fc216c764512403acb45e9e0dd836d07de 
  blockerbugs.spec 3f3e9567b60e2f2482cdbfbab267a2aa47f3feb5 

Diff: http://reviewboard-tflink.rhcloud.com/r/19/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 17: Implement Bugzilla Account Association

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/17/
---

(Updated March 15, 2013, 9:19 a.m.)


Status
--

This change has been marked as submitted.


Review request for blockerbugs.


Bugs: 347
https://fedorahosted.org/fedora-qa/ticket/347


Repository: blockerbugs


Description
---

This is a patch for tickets 347, 348, 349 and 350.


Diffs
-

  testing/test_bugchange.py 65f291122b4ae687872170517d196a621d548152 
  blockerbugs/util/bz_interface.py a8958be674e839d6c99694e33440a26331a8b041 
  blockerbugs/templates/propose_bug.html 
c97d72303dff2f49e4bb8bc5ff5fc2f4c764ce8b 
  blockerbugs/templates/login.html 20674fe93eb96c6e1e9b12b5988cad67dc1a5181 
  blockerbugs/templates/layout.html 6d0ae9a7bc913aa408985028db4494d51379da9c 
  blockerbugs/templates/fas_bugzilla.html PRE-CREATION 
  blockerbugs/templates/base_nav.html ce7a7bb478ad57a65d646fa7326a210c6a4eb131 
  blockerbugs/models/userinfo.py PRE-CREATION 
  blockerbugs/controllers/users.py 30b5fb5c8ef2196979a2d22c4380f302a5ce951a 
  blockerbugs/controllers/main.py ce26c641b9db05f11510f16177b017a56cf757c2 
  blockerbugs/controllers/forms.py b213c055d9297b59c6cf5d83358dcd14e265e345 
  alembic/versions/1d12b74d12bd_add_userinfo_table.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/17/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 17: Implement Bugzilla Account Association

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/17/
---

(Updated March 14, 2013, 11:24 a.m.)


Review request for blockerbugs.


Bugs: 347
https://fedorahosted.org/fedora-qa/ticket/347


Repository: blockerbugs


Description
---

This is a patch for tickets 347, 348, 349 and 350.


Diffs (updated)
-

  testing/test_bugchange.py 65f291122b4ae687872170517d196a621d548152 
  blockerbugs/util/bz_interface.py a8958be674e839d6c99694e33440a26331a8b041 
  blockerbugs/templates/propose_bug.html 
c97d72303dff2f49e4bb8bc5ff5fc2f4c764ce8b 
  blockerbugs/templates/login.html 20674fe93eb96c6e1e9b12b5988cad67dc1a5181 
  blockerbugs/templates/layout.html 6d0ae9a7bc913aa408985028db4494d51379da9c 
  blockerbugs/templates/fas_bugzilla.html PRE-CREATION 
  blockerbugs/templates/base_nav.html ce7a7bb478ad57a65d646fa7326a210c6a4eb131 
  blockerbugs/models/userinfo.py PRE-CREATION 
  blockerbugs/controllers/users.py 30b5fb5c8ef2196979a2d22c4380f302a5ce951a 
  blockerbugs/controllers/main.py ce26c641b9db05f11510f16177b017a56cf757c2 
  blockerbugs/controllers/forms.py b213c055d9297b59c6cf5d83358dcd14e265e345 
  alembic/versions/1d12b74d12bd_add_userinfo_table.py PRE-CREATION 

Diff: http://reviewboard-tflink.rhcloud.com/r/17/diff/


Testing
---


Thanks,

Martin Krizek

___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 17: Implement Bugzilla Account Association

[Martin Krizek]

 On March 13, 2013, 9:32 p.m., Tim Flink wrote:
  blockerbugs/controllers/main.py, line 293
  http://reviewboard-tflink.rhcloud.com/r/17/diff/1/?file=232#file232line293
 
  How come you broke this up as a separate function? It seems a bit 
  stylistically different from the rest of the code

Initially, there were some checks that were not necessary in the end. I moved 
the code out of the function. Good point.


 On March 13, 2013, 9:32 p.m., Tim Flink wrote:
  blockerbugs/models/userinfo.py, line 28
  http://reviewboard-tflink.rhcloud.com/r/17/diff/1/?file=234#file234line28
 
  do we know if there are limits on the possible length of these 
  usernames? I assume that there are but then again, I made the same 
  assumption about other fields as well

First I thought that usernames are of an e-mail form (which is not true) so 
that's why I put '255'. However I think it's safe to assume no one will have 
username longer than 255 characters, right?


 On March 13, 2013, 9:32 p.m., Tim Flink wrote:
  blockerbugs/templates/fas_bugzilla.html, line 30
  http://reviewboard-tflink.rhcloud.com/r/17/diff/1/?file=236#file236line30
 
  Stylistically, this doesn't match the existing login page that we have 
  for FAS - it would be better if they matched

Fair enough, fixed.


 On March 13, 2013, 9:32 p.m., Tim Flink wrote:
  blockerbugs/util/bz_interface.py, line 190
  http://reviewboard-tflink.rhcloud.com/r/17/diff/1/?file=240#file240line190
 
  If we get here, the app will blow up with an unhandled exception which 
  originates from my code but as I'm looking at it again, I'm wondering about 
  having a try/catch in the controller which sets an error in the proposal 
  form and lets the user re-submit

So I put try/catch block in the controller, let me know what you think.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/17/#review17
---


On March 14, 2013, 11:24 a.m., Martin Krizek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/17/
 ---
 
 (Updated March 14, 2013, 11:24 a.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 347
 https://fedorahosted.org/fedora-qa/ticket/347
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 This is a patch for tickets 347, 348, 349 and 350.
 
 
 Diffs
 -
 
   testing/test_bugchange.py 65f291122b4ae687872170517d196a621d548152 
   blockerbugs/util/bz_interface.py a8958be674e839d6c99694e33440a26331a8b041 
   blockerbugs/templates/propose_bug.html 
 c97d72303dff2f49e4bb8bc5ff5fc2f4c764ce8b 
   blockerbugs/templates/login.html 20674fe93eb96c6e1e9b12b5988cad67dc1a5181 
   blockerbugs/templates/layout.html 6d0ae9a7bc913aa408985028db4494d51379da9c 
   blockerbugs/templates/fas_bugzilla.html PRE-CREATION 
   blockerbugs/templates/base_nav.html 
 ce7a7bb478ad57a65d646fa7326a210c6a4eb131 
   blockerbugs/models/userinfo.py PRE-CREATION 
   blockerbugs/controllers/users.py 30b5fb5c8ef2196979a2d22c4380f302a5ce951a 
   blockerbugs/controllers/main.py ce26c641b9db05f11510f16177b017a56cf757c2 
   blockerbugs/controllers/forms.py b213c055d9297b59c6cf5d83358dcd14e265e345 
   alembic/versions/1d12b74d12bd_add_userinfo_table.py PRE-CREATION 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/17/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Martin Krizek
 


___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Review Request 16: Initial Packaging Work

[Martin Krizek]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/16/#review16
---


This looks good to me.

- Martin Krizek


On March 7, 2013, 11:38 p.m., Tim Flink wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard-tflink.rhcloud.com/r/16/
 ---
 
 (Updated March 7, 2013, 11:38 p.m.)
 
 
 Review request for blockerbugs.
 
 
 Bugs: 337
 https://fedorahosted.org/fedora-qa/ticket/337
 
 
 Repository: blockerbugs
 
 
 Description
 ---
 
 Initial packaging work and reworking all the various cli scripts into a 
 single module to make it more packaging friendly
 
 
 Diffs
 -
 
   update_blockers.sh d5229ea9b54119608e73cabcabbaaf4d99248876 
   sync_db.py 3489434c9cd6dc4f67ad82f61b171f94c4d65793 
   setup.py b4a51dc9c4bb9dadbd5ada286b8ddd5448811886 
   run_cli.py PRE-CREATION 
   initialize.py eb3c3e160e66f5f044e20f53ff79994820fd4a7e 
   init_db.sh 540dcb1f4baff9d7d0cad0dc75d67a4d6f3c3a98 
   docs/source/installation.rst PRE-CREATION 
   docs/source/index.rst PRE-CREATION 
   docs/source/development.rst PRE-CREATION 
   docs/source/conf.py PRE-CREATION 
   docs/Makefile PRE-CREATION 
   doc/source/installation.rst 41319a6c345987bf50663ae4ff88068aed81334c 
   doc/source/index.rst f07f013268aaa01cec780efec6e320c6cb267339 
   doc/source/development.rst 35b1b34a6b81d8d35e91fb11d32b35dc5d8269a9 
   doc/source/conf.py fc14e55effbd22e0c2b4fef5c7a395d16f0a5f70 
   doc/Makefile 8c16a97606680359188461c22ef48777b5ee9ee0 
   blockerbugs/cli.py PRE-CREATION 
   blockerbugs/__init__.py 9030c04ee244ce21439075be9c446a83c05ed9ae 
   blockerbugs.spec PRE-CREATION 
   alembic.ini 848a3873008f231b03c12c4bcfe6d7367527f8fc 
 
 Diff: http://reviewboard-tflink.rhcloud.com/r/16/diff/
 
 
 Testing
 ---
 
 I've done a bunch of local testing and have a staging instance set up in the 
 cloud: https://209.132.184.164/blockerbugs/
 
 
 Thanks,
 
 Tim Flink
 


___
qa-devel mailing list
qa-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/qa-devel

Re: Package review request - yourls

[Martin Krizek]

- Original Message -
 From: Martin Krizek mkri...@redhat.com
 To: t...@lists.fedoraproject.org, devel@lists.fedoraproject.org
 Sent: Wednesday, August 3, 2011 2:19:20 PM
 Subject: Package review request - yourls
 Hello all,
 
 I packaged yourls (http://yourls.org/), a url shortening service that
 can be run at one's own server,
 https://bugzilla.redhat.com/show_bug.cgi?id=726131. We, in AutoQA
 (http://fedoraproject.org/wiki/AutoQA), would really appreciate if
 someone could review this package. We are going to use this for
 shortening test result urls. And since this is my first package I need
 a sponsor as well.
 

Still no one interested?

Thanks,
Martin
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Package review request - yourls

[Martin Krizek]

Hello all,

I packaged yourls (http://yourls.org/), a url shortening service that can be 
run at one's own server, https://bugzilla.redhat.com/show_bug.cgi?id=726131. 
We, in AutoQA (http://fedoraproject.org/wiki/AutoQA), would really appreciate 
if someone could review this package. We are going to use this for shortening 
test result urls. And since this is my first package I need a sponsor as well.

Thank you very much!
Martin
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel