Re: Packages with compiled python files outside of /usr/lib*/python8
On Saturday, June 16, 2018 1:38:43 AM CEST Jason L Tibbitts III wrote: > cgit kevin praiskup tmz > ... > praiskup cgit There are two *.py files mistakenly byte-compiled (scripts used as filters), but it's OK to wait till %_python_bytecompile_extra becomes '0' system-wide. Pavel ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/E5NOSZ3GX3PII5JS77NUBAVHJTTMN6P2/
Re: Packages with compiled python files outside of /usr/lib*/python8
On 27.7.2018 10:51, Pavel Raiskup wrote: On Friday, July 27, 2018 10:01:42 AM CEST Miro Hrončok wrote: On 27.7.2018 07:55, Pavel Raiskup wrote: On Thursday, July 26, 2018 2:29:17 PM CEST Miro Hrončok wrote: Please, either make sure that %py_byte_compile doesn't collide with the default byte compilation machinery, or change the default right now (and define the '%_python_bytecompile_extra 0' in batch). The former is preferred of course. How does it collide exactly? I'm not sure. Can I simply use %py_byte_compile without '%_python_bytecompile_extra 0'? You CAN use %py_byte_compile anywhere. With or without '%_python_bytecompile_extra 0'. You MUST use '%_python_bytecompile_extra 0' if you have /usr/bin/python in buildroot and you DON'T want it to be used to bytecompile Python files outside of Python dirs. So from your note it looks like the /usr/bin/python can cause troubles? Consider: - I have /usr/bin/python in buildroot mistakenly - I do some explicit %py_byte_compile some files in %buildroot in "extra" dirs, by either python3 only or both python{2,3} - I don't explicitly set '%_python_bytecompile_extra 0' Then, brp-python-bytecompile goes and recompiles (by /bin/python) those files, right? But where's the problem? Python2 and Python3 store the byte compiled files to different directories... (yes, brp-python-bytecompile could avoid recompiling files which are alrady compiled, but that's detail). Yes, I see a very low-prio issue -> if the package is Python 3 only, it can get inadvertently installed python2 '*.pyc' files. But that's only small issue (size of RPM) and it's temporary issue (we plan to turn %_python_bytecompile_extra to 0 system wide soon). I can confirm everything you've said. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/IVNOTXSLF2A7UJQ3J6AZK3AZDB2P4L2M/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Friday, July 27, 2018 10:01:42 AM CEST Miro Hrončok wrote: > On 27.7.2018 07:55, Pavel Raiskup wrote: > > On Thursday, July 26, 2018 2:29:17 PM CEST Miro Hrončok wrote: > >>> Please, either make sure that %py_byte_compile doesn't collide with the > >>> default byte compilation machinery, or change the default right now (and > >>> define the '%_python_bytecompile_extra 0' in batch). The former is > >>> preferred of course. > >> > >> How does it collide exactly? > > > > I'm not sure. Can I simply use %py_byte_compile without > > '%_python_bytecompile_extra 0'? > > You CAN use %py_byte_compile anywhere. With or without > '%_python_bytecompile_extra 0'. > > You MUST use '%_python_bytecompile_extra 0' if you have /usr/bin/python > in buildroot and you DON'T want it to be used to bytecompile Python > files outside of Python dirs. So from your note it looks like the /usr/bin/python can cause troubles? Consider: - I have /usr/bin/python in buildroot mistakenly - I do some explicit %py_byte_compile some files in %buildroot in "extra" dirs, by either python3 only or both python{2,3} - I don't explicitly set '%_python_bytecompile_extra 0' Then, brp-python-bytecompile goes and recompiles (by /bin/python) those files, right? But where's the problem? Python2 and Python3 store the byte compiled files to different directories... (yes, brp-python-bytecompile could avoid recompiling files which are alrady compiled, but that's detail). Yes, I see a very low-prio issue -> if the package is Python 3 only, it can get inadvertently installed python2 '*.pyc' files. But that's only small issue (size of RPM) and it's temporary issue (we plan to turn %_python_bytecompile_extra to 0 system wide soon). Pavel ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/JODS5TTYVKMY2VLEHHIJ6DM5EA7TPAXL/
Re: Packages with compiled python files outside of /usr/lib*/python8
On 27.7.2018 07:55, Pavel Raiskup wrote: On Thursday, July 26, 2018 2:29:17 PM CEST Miro Hrončok wrote: Please, either make sure that %py_byte_compile doesn't collide with the default byte compilation machinery, or change the default right now (and define the '%_python_bytecompile_extra 0' in batch). The former is preferred of course. How does it collide exactly? I'm not sure. Can I simply use %py_byte_compile without '%_python_bytecompile_extra 0'? You CAN use %py_byte_compile anywhere. With or without '%_python_bytecompile_extra 0'. You MUST use '%_python_bytecompile_extra 0' if you have /usr/bin/python in buildroot and you DON'T want it to be used to bytecompile Python files outside of Python dirs. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/UUBO45JN27A2K6V5E4LKUVIKFIFRNKNU/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Thursday, July 26, 2018 2:29:17 PM CEST Miro Hrončok wrote: > > Please, either make sure that %py_byte_compile doesn't collide with the > > default byte compilation machinery, or change the default right now (and > > define the '%_python_bytecompile_extra 0' in batch). The former is > > preferred of course. > > How does it collide exactly? I'm not sure. Can I simply use %py_byte_compile without '%_python_bytecompile_extra 0'? If yes, it's perfect because maintianers can fix their packages and wait till we flip '%_python_bytecompile_extra 0' systemwide. Pavel ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/DG5PABDA4TIFUH4K74IZPEE6WHRBXZSU/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Fri, Jun 15, 2018 at 06:38:43PM -0500, Jason L Tibbitts III wrote: > zbyszekcalibre python-music21 I fixed those two. Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/NYBXIOWCWMSYDBU5NLAYS2JN2ZAJHTXV/
Re: Packages with compiled python files outside of /usr/lib*/python8
On 26.7.2018 14:23, Pavel Raiskup wrote: On Saturday, June 16, 2018 1:38:43 AM CEST Jason L Tibbitts III wrote: In order to prepare for the default to change in a future release, the packaging guidelines have changed to require packages which install .py files outside of the regular python library locations to do the following: * Set %_python_bytecompile_extra to 0 to disable the automatic compilation of the extra python files. * Manually byte-compile those files which do actually need to be compiled. This is done with the %py_byte_compile macro, which as a bonus requires that you specify which python version will be used for the compilation. Wouldn't it be better if users simply started "manual" byte compilation for certain paths with %py_byte_compile, so maintainers could forgot about semantically pretty hard-to-understand %_python_bytecompile_extra macro? Even if we plan to have the automatic byte compilation machinery enabled for some time -- how does the machinery collide with explicit %py_byte_compile? Why do we have to turn it off? I really dislike putting some temporarily macros into spec files... Or please read mi like that: There are two kinds of packages, - first type has maintainers who plan to fix such issues promptly, and they would certainly appreciate if we turned '%_python_bytecompile_extra 0' system-wide sooner - the second type of package has slower maintainers, and they will wait till they have to do the change ..., and in many cases, provenpackagers will have to step in with '%_python_bytecompile_extra 1' sooner or later, no matter when we change the default behavior Please, either make sure that %py_byte_compile doesn't collide with the default byte compilation machinery, or change the default right now (and define the '%_python_bytecompile_extra 0' in batch). The former is preferred of course. How does it collide exactly? Note that there was a proposal on the FPC meeting (from tibbs IIRC) that we make `%_python_bytecompile_extra 0` the default and we push mass update with `%_python_bytecompile_extra 1` to packages that ship pyc/pyo files outside of Python directories. However that was not part of the approved change and it was to late to change it. We can propose it as a Fedora 30 change. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/G2VVJTXZ2ZAVRYNAKED3V5R3JWPTLTTV/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Saturday, June 16, 2018 1:38:43 AM CEST Jason L Tibbitts III wrote: > In order to prepare for the default to change in a future release, the > packaging guidelines have changed to require packages which install .py > files outside of the regular python library locations to do the > following: > > * Set %_python_bytecompile_extra to 0 to disable the automatic > compilation of the extra python files. > * Manually byte-compile those files which do actually need to be > compiled. This is done with the %py_byte_compile macro, which as a > bonus requires that you specify which python version will be used for > the compilation. Wouldn't it be better if users simply started "manual" byte compilation for certain paths with %py_byte_compile, so maintainers could forgot about semantically pretty hard-to-understand %_python_bytecompile_extra macro? Even if we plan to have the automatic byte compilation machinery enabled for some time -- how does the machinery collide with explicit %py_byte_compile? Why do we have to turn it off? I really dislike putting some temporarily macros into spec files... Or please read mi like that: There are two kinds of packages, - first type has maintainers who plan to fix such issues promptly, and they would certainly appreciate if we turned '%_python_bytecompile_extra 0' system-wide sooner - the second type of package has slower maintainers, and they will wait till they have to do the change ..., and in many cases, provenpackagers will have to step in with '%_python_bytecompile_extra 1' sooner or later, no matter when we change the default behavior Please, either make sure that %py_byte_compile doesn't collide with the default byte compilation machinery, or change the default right now (and define the '%_python_bytecompile_extra 0' in batch). The former is preferred of course. Pavel > An example of the changes required for a package: > https://src.fedoraproject.org/rpms/python-uranium/pull-request/1#request_diff > > I looked for .pyc files existing outside of /usr/lib(64)?/python\d\.\d > in order to find packages which _may_ need changes in order to follow > this guideline (and if not fixed may break in the future when the > default for %_python_bytecompile_extra changes to 0). Two lists follow. > One lists packages and their maintainers; the other lists maintainers > and their packages. Both lists include comaintainers. > > > Maintainers by package: > 389-ds-base mreynolds nhosoi nkinder rmeggins > CGAL rineau > FlightCrew jwrdegoede sharkcz > InsightToolkit ignatenkobrain mrceresa sebp > Macaulay2rdieter tremble > PySolFC orphan > PyXB lef marcusk mmahut > R-reticulate qulogic > Singular pcpa rdieter > accerciser kalev > adonthellnobrakal orphan > ambari coolsvap moceap orphan > anaconda-realmd stefw vpodzime > anjuta kalev limb moezroy rakesh > anki chkr thomasfedb > apitrace smani > aqsiskwizart pmachata > arm-none-eabi-gdborphan > asterisk itamarjp jsmith russellb > asymptotespot > atomic adimania baude dwalsh fkluknav lsm5 runcom walters > audio-convert-modfirewing > audit-viewer mitr > autocloudkushal rtnpro sayanchowdhury > avogadro sagitter > backintime cicku hannes raphgro > bakefile filiperosset swt2c > bibusalexlan ankursinha > bkchem limb > bleachbitcicku nonamedotc > blueberrybesser82 leigh123linux > bluefish pghmcfc > bodhibowlofeggs jcline lmacken > boo elsupergomez tpokorra > boostdenisarnaud jwakely > boothjpokorny > bro fab mildew > bugyou sayanchowdhury > bugzilla eseyman itamarjp > bup tadej > calamareskkofler mattia > calibre chkr heliocastro kevin nushio zbyszek > cas astokes > catkin rmattes thofmann > ceph branto dachary dmick jdieter ke4qqq kkeithle ktdreyer > steve stingray > ceph-ansible fcami ktdreyer > cgit kevin praiskup tmz > chameleonjortel > check-mk averi > cherokee pali > chromium spot tpopela > cinnamon-screensaver besser82 leigh123linux > clangairlied daveisfera sbergmann siddharths tstellar > clufter jpokorny > cobbler jimi kwizart orion shenson > comixmtasaka > community-mysql hhorak jdornak jstanek mschorm > copr-backend clime dturecek frostyx msuchy > copr-frontendclime dturecek frostyx msuchy > coq amdunn jjames > cura churchyard > cura-lulzbot churchyard spot >
Re: Packages with compiled python files outside of /usr/lib*/python8
On 18.6.2018 11:45, Milan Crha wrote: On Mon, 2018-06-18 at 11:19 +0200, Miro Hrončok wrote: What Python are those files for actually? Are they imported or executed? Hi, I do not speak pythonish, I'm sorry, but from what I recall they had been added as some sort of unit tests. I think they are meant to be executed only, but I do not know how they are used by 3rd-parties, if at all. The corresponding .test files execute them using `behave`: [Test] Type=session-exclusive Exec=behave /usr/libexec/evolution/installed-tests -t view_shortcuts -k -f html -o view_shortcuts.html -f plain Hope it helps. 1. behave is Python 2 (you might want to check if it works with behave-3 and switch to Python 3 if it works) 2. behave does not create pyc files, so IMHO you do not need to bytecompile those with any Python -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/COXWVDZMY3IOUWI5ALCXAI26HUGIM7EW/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Mon, 2018-06-18 at 11:19 +0200, Miro Hrončok wrote: > What Python are those files for actually? Are they imported or > executed? Hi, I do not speak pythonish, I'm sorry, but from what I recall they had been added as some sort of unit tests. I think they are meant to be executed only, but I do not know how they are used by 3rd-parties, if at all. The corresponding .test files execute them using `behave`: [Test] Type=session-exclusive Exec=behave /usr/libexec/evolution/installed-tests -t view_shortcuts -k -f html -o view_shortcuts.html -f plain Hope it helps. Bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/UBXUJG6IO2ESSAYAL55MYP66ESVWE2PM/
Re: Packages with compiled python files outside of /usr/lib*/python8
On 18.6.2018 11:04, Milan Crha wrote: Hi, On Mon, 2018-06-18 at 10:46 +0200, Miro Hrončok wrote: evolution-tests: oh, I see, I do not build/install them locally, thus I didn't notice them in my $PREFIX. I'll update the evolution package spec file. What Python are those files for actually? Are they imported or executed? -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/I2GZTRGLXMBFEKKN42XHBPTBHPNXRG5O/
Re: Packages with compiled python files outside of /usr/lib*/python8
Hi, On Mon, 2018-06-18 at 10:46 +0200, Miro Hrončok wrote: > evolution-tests: oh, I see, I do not build/install them locally, thus I didn't notice them in my $PREFIX. I'll update the evolution package spec file. Thanks and bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/GC6YNVRVTGMMXV5NGSMCYTBZZ2JFZHN4/
Re: Packages with compiled python files outside of /usr/lib*/python8
On 18.6.2018 10:28, Milan Crha wrote: On Fri, 2018-06-15 at 18:38 -0500, Jason L Tibbitts III wrote: evolutionalexl caillon caolanm mbarnes mcrha rhughes rstrode ssp tpopela Hi, could I ask how evolution had got into the list, please? Having installed evolution-3.29.2-1.fc29.x86_64 and running: $ rpm -ql evolution | grep py returns only folder-copy.png and mail-copy.png, both at /usr/share/evolution/icons/hicolor/16x16/actions/ directory. Trying with $ rpm -ql evolution | grep -c "\.py" returns 0, while $ rpm -ql evolution | grep -c ".py" returns 2, but those are the .png files named above. The evolution package doesn't even require python for anything, neither for build. Thanks and bye, Milan evolution-tests: /usr/libexec/evolution/installed-tests/common_steps.py /usr/libexec/evolution/installed-tests/common_steps.pyc /usr/libexec/evolution/installed-tests/common_steps.pyo /usr/libexec/evolution/installed-tests/environment.py /usr/libexec/evolution/installed-tests/environment.pyc /usr/libexec/evolution/installed-tests/environment.pyo /usr/libexec/evolution/installed-tests/steps/addressbook_steps.py /usr/libexec/evolution/installed-tests/steps/addressbook_steps.pyc /usr/libexec/evolution/installed-tests/steps/addressbook_steps.pyo /usr/libexec/evolution/installed-tests/steps/initial_setup_steps.py /usr/libexec/evolution/installed-tests/steps/initial_setup_steps.pyc /usr/libexec/evolution/installed-tests/steps/initial_setup_steps.pyo /usr/libexec/evolution/installed-tests/steps/steps.py /usr/libexec/evolution/installed-tests/steps/steps.pyc /usr/libexec/evolution/installed-tests/steps/steps.pyo -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/RKBYNNVOIC6B7LDCWNI6J7MS3UAFQAFD/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Fri, 2018-06-15 at 18:38 -0500, Jason L Tibbitts III wrote: > evolutionalexl caillon caolanm mbarnes mcrha rhughes > rstrode ssp tpopela Hi, could I ask how evolution had got into the list, please? Having installed evolution-3.29.2-1.fc29.x86_64 and running: $ rpm -ql evolution | grep py returns only folder-copy.png and mail-copy.png, both at /usr/share/evolution/icons/hicolor/16x16/actions/ directory. Trying with $ rpm -ql evolution | grep -c "\.py" returns 0, while $ rpm -ql evolution | grep -c ".py" returns 2, but those are the .png files named above. The evolution package doesn't even require python for anything, neither for build. Thanks and bye, Milan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/AUFUR4JQU2BYHHJ7CTCDZMB6SJLC4QS7/
Re: Packages with compiled python files outside of /usr/lib*/python8
On 16.6.2018 02:27, Scott Talbert wrote: * Set %_python_bytecompile_extra to 0 to disable the automatic compilation of the extra python files. * Manually byte-compile those files which do actually need to be compiled. This is done with the %py_byte_compile macro, which as a bonus requires that you specify which python version will be used for the compilation. In a couple of my packages, the python files you are detecting are documentation or sample code. Do we care in that case? In fact, maybe it's best those aren't byte-compiled? Yes, it's best not to bytecompile those at all: * Set %_python_bytecompile_extra to 0 to disable the automatic compilation of the extra python files. * Do not manually byte-compile those files because they don't actually need to be byte-compiled. Allowing this is the main point of the change. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/4HCZMZSGOR6QEOGYFETPSY6OKZIOTCHY/
Re: Packages with compiled python files outside of /usr/lib*/python8
On Fri, 15 Jun 2018, Jason L Tibbitts III wrote: As part of a recent guideline change (https://pagure.io/packaging-committee/issue/772) which ties in with an accepted F29 change (https://fedoraproject.org/wiki/Changes/No_more_automagic_Python_bytecompilation), this section of the guidelines was overhauled for F29+: https://fedoraproject.org/wiki/Packaging:Python_Appendix#Manual_byte_compilation The quick summary is that Fedora will be changing to not automatically byte-compile python files which are installed outside of the usual python library locations. Currently implemented is the %_python_bytecompile_extra macro which allows packages to disable this byte-compilation of "extra" python files. The default is still to compile these files, so technically nothing changes. In order to prepare for the default to change in a future release, the packaging guidelines have changed to require packages which install .py files outside of the regular python library locations to do the following: * Set %_python_bytecompile_extra to 0 to disable the automatic compilation of the extra python files. * Manually byte-compile those files which do actually need to be compiled. This is done with the %py_byte_compile macro, which as a bonus requires that you specify which python version will be used for the compilation. In a couple of my packages, the python files you are detecting are documentation or sample code. Do we care in that case? In fact, maybe it's best those aren't byte-compiled? Scott ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/I5MOFJGBUUR67CLWTONEOJUK7FJPACD6/
Packages with compiled python files outside of /usr/lib*/python8
As part of a recent guideline change (https://pagure.io/packaging-committee/issue/772) which ties in with an accepted F29 change (https://fedoraproject.org/wiki/Changes/No_more_automagic_Python_bytecompilation), this section of the guidelines was overhauled for F29+: https://fedoraproject.org/wiki/Packaging:Python_Appendix#Manual_byte_compilation The quick summary is that Fedora will be changing to not automatically byte-compile python files which are installed outside of the usual python library locations. Currently implemented is the %_python_bytecompile_extra macro which allows packages to disable this byte-compilation of "extra" python files. The default is still to compile these files, so technically nothing changes. In order to prepare for the default to change in a future release, the packaging guidelines have changed to require packages which install .py files outside of the regular python library locations to do the following: * Set %_python_bytecompile_extra to 0 to disable the automatic compilation of the extra python files. * Manually byte-compile those files which do actually need to be compiled. This is done with the %py_byte_compile macro, which as a bonus requires that you specify which python version will be used for the compilation. An example of the changes required for a package: https://src.fedoraproject.org/rpms/python-uranium/pull-request/1#request_diff I looked for .pyc files existing outside of /usr/lib(64)?/python\d\.\d in order to find packages which _may_ need changes in order to follow this guideline (and if not fixed may break in the future when the default for %_python_bytecompile_extra changes to 0). Two lists follow. One lists packages and their maintainers; the other lists maintainers and their packages. Both lists include comaintainers. Maintainers by package: 389-ds-base mreynolds nhosoi nkinder rmeggins CGAL rineau FlightCrew jwrdegoede sharkcz InsightToolkit ignatenkobrain mrceresa sebp Macaulay2rdieter tremble PySolFC orphan PyXB lef marcusk mmahut R-reticulate qulogic Singular pcpa rdieter accerciser kalev adonthellnobrakal orphan ambari coolsvap moceap orphan anaconda-realmd stefw vpodzime anjuta kalev limb moezroy rakesh anki chkr thomasfedb apitrace smani aqsiskwizart pmachata arm-none-eabi-gdborphan asterisk itamarjp jsmith russellb asymptotespot atomic adimania baude dwalsh fkluknav lsm5 runcom walters audio-convert-modfirewing audit-viewer mitr autocloudkushal rtnpro sayanchowdhury avogadro sagitter backintime cicku hannes raphgro bakefile filiperosset swt2c bibusalexlan ankursinha bkchem limb bleachbitcicku nonamedotc blueberrybesser82 leigh123linux bluefish pghmcfc bodhibowlofeggs jcline lmacken boo elsupergomez tpokorra boostdenisarnaud jwakely boothjpokorny bro fab mildew bugyou sayanchowdhury bugzilla eseyman itamarjp bup tadej calamareskkofler mattia calibre chkr heliocastro kevin nushio zbyszek cas astokes catkin rmattes thofmann ceph branto dachary dmick jdieter ke4qqq kkeithle ktdreyer steve stingray ceph-ansible fcami ktdreyer cgit kevin praiskup tmz chameleonjortel check-mk averi cherokee pali chromium spot tpopela cinnamon-screensaver besser82 leigh123linux clangairlied daveisfera sbergmann siddharths tstellar clufter jpokorny cobbler jimi kwizart orion shenson comixmtasaka community-mysql hhorak jdornak jstanek mschorm copr-backend clime dturecek frostyx msuchy copr-frontendclime dturecek frostyx msuchy coq amdunn jjames cura churchyard cura-lulzbot churchyard spot cyclelimb mcepl cyphesis bruno mpreisle darkserver kushal salimma ddupdate leamas devhelp alexl caillon caolanm johnp kalev mbarnes rhughes rishi rstrode ssp stransky diskimage-builderapevec bnemec mburns72h pabelanger slagle dlrn jpena domoticz mooninite dracut-modules-olpc cjb dsd pbrobinson yaderv dreampie cicku williamjmorenor dstatdkaspar dynafed andreamanzi okeeble eclipse-pydevakurtakov jjohnstn edk2 bonzini crobinso kraxel encuentroalvesadrian enemies-of-carlotta ertzing orphan entangle berrange eog alexl caillon