Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-11 Thread Tom Hughes via devel 

On 11/05/2020 13:02, Stephen Gallagher wrote:

On Fri, May 8, 2020 at 6:03 PM Tom Hughes  wrote:


On 08/05/2020 21:18, Stephen Gallagher wrote:

On Sat, May 2, 2020 at 6:26 PM Miro Hrončok  wrote:


On 01. 05. 20 22:21, Ben Cotton wrote:

* Proposal owners:
The packages are already built for Fedora 33 in a non-default module
stream. On June 14th, 2020, the nodejs-14.x packages will become the
default in Fedora 33 (either by making the 14.x module stream be the
default stream or by rebuilding the packages as non-modular, depending
on other factors).


Will there be an attempted mass rebuild of the dependent packages?


We're going to request a side-tag and rebuild all of the `nodejs-*`
packages. Anything that fails will need to have an FTBFS bug filed.


Why? We're never done that for Node.js upgrades before, and it's
only the binary modules which actually need to be rebuilt...



Well, we don't have a way of detecting which are binary modules and
which aren't, so far as I know.


I have a list in the script I normally use to rebuild them.


Also, assuming packages are following the guidelines, they should all
at least have the %{__nodejs} -e 'require("./")' test enabled, so we
can at least find out if there are any Node.js modules that cannot
even load.


Excuse me while I try and stop laughing.

I guess it will get of a few hundred more node modules anyway
which is something.

Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-11 Thread Igor Raits 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On Mon, 2020-05-11 at 08:02 -0400, Stephen Gallagher wrote:
> On Fri, May 8, 2020 at 6:03 PM Tom Hughes  wrote:
> > On 08/05/2020 21:18, Stephen Gallagher wrote:
> > > On Sat, May 2, 2020 at 6:26 PM Miro Hrončok 
> > > wrote:
> > > > On 01. 05. 20 22:21, Ben Cotton wrote:
> > > > > * Proposal owners:
> > > > > The packages are already built for Fedora 33 in a non-default 
> > > > > module
> > > > > stream. On June 14th, 2020, the nodejs-14.x packages will
> > > > > become the
> > > > > default in Fedora 33 (either by making the 14.x module stream
> > > > > be the
> > > > > default stream or by rebuilding the packages as non-modular,
> > > > > depending
> > > > > on other factors).
> > > > 
> > > > Will there be an attempted mass rebuild of the dependent
> > > > packages?
> > > 
> > > We're going to request a side-tag and rebuild all of the `nodejs-
> > > *`
> > > packages. Anything that fails will need to have an FTBFS bug
> > > filed.
> > 
> > Why? We're never done that for Node.js upgrades before, and it's
> > only the binary modules which actually need to be rebuilt...
> > 
> 
> Well, we don't have a way of detecting which are binary modules and
> which aren't, so far as I know.
> 
> Also, assuming packages are following the guidelines, they should all
> at least have the %{__nodejs} -e 'require("./")' test enabled, so we
> can at least find out if there are any Node.js modules that cannot
> even load.

Note that double-underscores inside macro names is considered a bad
idea. For user-facing macros, there should not be any underscores.

> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: 
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
- -- 
Igor Raits 
-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEcwgJ58gsbV5f5dMcEV1auJxcHh4FAl65QkEACgkQEV1auJxc
Hh4zJw//W3hBhheAD3MOJSQE8F+11FvhSWoawUEjzPrehlUcmyAZcYyk+3eCx1X/
t0HIVDSVF4XcBzVsWRqey+1lC5/r23xzPTV2it/Tx5IoXE8r79HxuPYbvEmOevDm
WnmhaiR55OF4BjobLGqoGbHa+kQc1935eTKWXNgedgKW/5tCLs8G+pQ1qzxSqfvn
8MsMuhOGUHAZnGCKDeZozlt4bEeU9P6H8OqDz3alDon0fXhuoUL3viuQRl5wNQ3g
JZcVzAXm3gE6sNjcxoIE+yWUi9uFg5tsjjwNE+1c1txAXxETHSpWa9El++ugnncn
Y4XA/IHwAh7nMmBssENJ0T9VUpheQVqkVPg3jK2RqOxW+7BU8RQNCQ5TTorfE/Fd
ixmQlOZV6zuYU+K9on9huKZyeosOLTznDPr8TC7+Y+mr4hkhAfod6P5v7YKU9N4W
2MLdd7eqDENI3UGgBvcWopPHTOTOC4gUrZl+5BktMKWQDS6A4G9rzYwKd2EMINiD
oJ6qiq8XgAFO46G5hswJoEPc388MqpHuzfJp0Y74ye/LbbubVRLpb3XP9DStyhil
GNs/43pvStLQFiNMBB6XYJCz2LG6McMCId42/0+RYpvINDkJ9Ze1qnOba2EQnF/P
TlM53VkTVgkAEDPGwEXNk0t/B/MXJmfCaxIJHCm1dlf718Zxubg=
=DF5+
-END PGP SIGNATURE-
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-11 Thread Stephen Gallagher 
On Fri, May 8, 2020 at 6:03 PM Tom Hughes  wrote:
>
> On 08/05/2020 21:18, Stephen Gallagher wrote:
> > On Sat, May 2, 2020 at 6:26 PM Miro Hrončok  wrote:
> >>
> >> On 01. 05. 20 22:21, Ben Cotton wrote:
> >>> * Proposal owners:
> >>> The packages are already built for Fedora 33 in a non-default module
> >>> stream. On June 14th, 2020, the nodejs-14.x packages will become the
> >>> default in Fedora 33 (either by making the 14.x module stream be the
> >>> default stream or by rebuilding the packages as non-modular, depending
> >>> on other factors).
> >>
> >> Will there be an attempted mass rebuild of the dependent packages?
> >
> > We're going to request a side-tag and rebuild all of the `nodejs-*`
> > packages. Anything that fails will need to have an FTBFS bug filed.
>
> Why? We're never done that for Node.js upgrades before, and it's
> only the binary modules which actually need to be rebuilt...
>

Well, we don't have a way of detecting which are binary modules and
which aren't, so far as I know.

Also, assuming packages are following the guidelines, they should all
at least have the %{__nodejs} -e 'require("./")' test enabled, so we
can at least find out if there are any Node.js modules that cannot
even load.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-09 Thread Miro Hrončok 

On 08. 05. 20 22:17, Stephen Gallagher wrote:

When we wrote that, there was still ambiguity regarding whether DNF
would have implemented the necessary upgrade capabilities we've been
discussing for the last six months.


Just to clarify: DNF upgrade capabilities are not the thing that is holding back 
default modules. It is somebody writing a policy wrt what we ship in modules and 
what we don't.


From the ticket:

https://pagure.io/fesco/issue/2341#comment-627466

"""For Fedora 32 and onward, all default modular streams are banned. Existing 
defaults are removed. Once a comprehensive modular policy for Fedora is created 
and approved by FESCo, this ban can be lifted. The future policy should allow 
modularizing, but the primary objective is to make sure that the user experience 
and nonmodular packaging experience is not significantly worse than before 
modularity."""


--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-08 Thread Tom Hughes via devel 

On 08/05/2020 21:18, Stephen Gallagher wrote:

On Sat, May 2, 2020 at 6:26 PM Miro Hrončok  wrote:


On 01. 05. 20 22:21, Ben Cotton wrote:

* Proposal owners:
The packages are already built for Fedora 33 in a non-default module
stream. On June 14th, 2020, the nodejs-14.x packages will become the
default in Fedora 33 (either by making the 14.x module stream be the
default stream or by rebuilding the packages as non-modular, depending
on other factors).


Will there be an attempted mass rebuild of the dependent packages?


We're going to request a side-tag and rebuild all of the `nodejs-*`
packages. Anything that fails will need to have an FTBFS bug filed.


Why? We're never done that for Node.js upgrades before, and it's
only the binary modules which actually need to be rebuilt...

Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-08 Thread Stephen Gallagher 
On Sat, May 2, 2020 at 6:26 PM Miro Hrončok  wrote:
>
> On 01. 05. 20 22:21, Ben Cotton wrote:
> > * Proposal owners:
> > The packages are already built for Fedora 33 in a non-default module
> > stream. On June 14th, 2020, the nodejs-14.x packages will become the
> > default in Fedora 33 (either by making the 14.x module stream be the
> > default stream or by rebuilding the packages as non-modular, depending
> > on other factors).
>
> Will there be an attempted mass rebuild of the dependent packages?

We're going to request a side-tag and rebuild all of the `nodejs-*`
packages. Anything that fails will need to have an FTBFS bug filed.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-08 Thread Stephen Gallagher 
On Fri, May 1, 2020 at 8:03 PM Miro Hrončok  wrote:
>
> On 01. 05. 20 22:21, Ben Cotton wrote:
> > == Detailed Description ==
> > Fedora 33 will ship with the latest LTS version of Node.js by default.
> > This will either be the `nodejs:14` module stream or else replicated
> > to the non-modular repository, depending on the status of other
> > release engineering work around supporting modular content in the
> > non-modular buildroots.
>
> Since default modular streams are banned, this doesn't depend on release
> engineering work. Can we please just outright say the nonmodular Nodejs will 
> be
> updated?

When we wrote that, there was still ambiguity regarding whether DNF
would have implemented the necessary upgrade capabilities we've been
discussing for the last six months. If it landed, I planned to ask
FESCo for permission to re-enable that and get us out of the position
of needing to build both the modular and non-modular versions. It
doesn't look like that's going to make it for F33, so sure; we can
change the wording here.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-04 Thread James Cassell 

On Mon, May 4, 2020, at 5:39 AM, Miro Hrončok wrote:
> On 04. 05. 20 10:51, Petr Pisar wrote:
> > On Sat, May 02, 2020 at 02:01:43AM +0200, Miro Hrončok wrote:
> >> On 01. 05. 20 22:21, Ben Cotton wrote:
> >>> == Detailed Description ==
> >>> Fedora 33 will ship with the latest LTS version of Node.js by default.
> >>> This will either be the `nodejs:14` module stream or else replicated
> >>> to the non-modular repository, depending on the status of other
> >>> release engineering work around supporting modular content in the
> >>> non-modular buildroots.
> >> Since default modular streams are banned,
> > Indeed? I thought that they are not banned, they only need a FESCo approval.
> 
> Indeed:
> 
> https://pagure.io/fesco/issue/2341#comment-628267
> 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/5DIMII3GR6YT7JJ4XII6AF2JSI24ZTLV/
> 
> Should we be more loud about his?
> 

It's a welcome change, and I hadn't heard about it. An announcement seems 
appropriate.

V/r,
James Cassell
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-04 Thread Miro Hrončok 

On 04. 05. 20 10:51, Petr Pisar wrote:

On Sat, May 02, 2020 at 02:01:43AM +0200, Miro Hrončok wrote:

On 01. 05. 20 22:21, Ben Cotton wrote:

== Detailed Description ==
Fedora 33 will ship with the latest LTS version of Node.js by default.
This will either be the `nodejs:14` module stream or else replicated
to the non-modular repository, depending on the status of other
release engineering work around supporting modular content in the
non-modular buildroots.

Since default modular streams are banned,

Indeed? I thought that they are not banned, they only need a FESCo approval.


Indeed:

https://pagure.io/fesco/issue/2341#comment-628267

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/5DIMII3GR6YT7JJ4XII6AF2JSI24ZTLV/

Should we be more loud about his?

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-04 Thread Petr Pisar 
On Sat, May 02, 2020 at 02:01:43AM +0200, Miro Hrončok wrote:
> On 01. 05. 20 22:21, Ben Cotton wrote:
> > == Detailed Description ==
> > Fedora 33 will ship with the latest LTS version of Node.js by default.
> > This will either be the `nodejs:14` module stream or else replicated
> > to the non-modular repository, depending on the status of other
> > release engineering work around supporting modular content in the
> > non-modular buildroots.
> 
> Since default modular streams are banned,

Indeed? I thought that they are not banned, they only need a FESCo approval.

Maybe a related issue: Where did Module packaging guidelines disappear?
I remember they were reachable from
.
(Home → Packaging Guidelines navigation at
 does not work.)

-- Petr


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Fedora 33 System-Wide Change proposal: Node.js 14.x by default

2020-05-02 Thread Miro Hrončok 

On 01. 05. 20 22:21, Ben Cotton wrote:

* Proposal owners:
The packages are already built for Fedora 33 in a non-default module
stream. On June 14th, 2020, the nodejs-14.x packages will become the
default in Fedora 33 (either by making the 14.x module stream be the
default stream or by rebuilding the packages as non-modular, depending
on other factors).


Will there be an attempted mass rebuild of the dependent packages?

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org