Re: Fw: fedmsg notification

2018-04-11 Thread Todd Zullinger
Hi Pierre,

Pierre-Yves Chibon wrote:
> On Mon, Apr 09, 2018 at 01:28:02PM +0200, Dominik 'Rathann' Mierzejewski 
> wrote:
>> On Monday, 09 April 2018 at 13:20, Pierre-Yves Chibon wrote:
>> [...]
>>> Finally the reason this has not been correctly announced is that we are 
>>> still
>>> investigating the capacity of the system and the pipeline to check if it can
>>> handle the load of all the package in Fedora, but as said, the pipeline is
>>> already sending messages to the production bus, thus this behavior :(
>> 
>> The obvious thing to do is to stop sending these messages to the
>> production bus until fedmsg_meta is updated and the update pushed to
>> production. Why hasn't this been done already?
> 
> The basic answer is that I didn't have the hand to do it.
> So instead I released a new fedmsg-meta-fedora-infrastructure with support for
> these messages and deployed it in production.
> Messages about the allpackages pipeline should now make some sense :)

Is this deployed in production?  I just pushed some changes
to a fork on src.fedoraproject.org and recieved an email for
each commit that looked like this:

Subject: fedmsg notification

   

Notification time stamped 2018-04-12 04:23:01 UTC



https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/upstream-fedora-pipeline-trigger/detail/upstream-fedora-pipeline-trigger/11044/pipeline/

If there's a change from what Michael reported, I can't see
what it is. :)

I suspect this shouldn't be triggering at all for forks,
which I believe two open infrastructure tickets cover:

https://pagure.io/fedora-infrastructure/issue/6575
https://pagure.io/fedora-infrastructure/issue/6791

For non-forks, I think it would also be ideal to not fire
this off for each commit but rather once per push.

Thanks,

-- 
Todd
~~
I have never let my schooling interfere with my education.
-- Mark Twain (1835-1910)



signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Fw: fedmsg notification

2018-04-11 Thread Pierre-Yves Chibon
On Mon, Apr 09, 2018 at 01:28:02PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Monday, 09 April 2018 at 13:20, Pierre-Yves Chibon wrote:
> [...]
> > Finally the reason this has not been correctly announced is that we are 
> > still
> > investigating the capacity of the system and the pipeline to check if it can
> > handle the load of all the package in Fedora, but as said, the pipeline is
> > already sending messages to the production bus, thus this behavior :(
> 
> The obvious thing to do is to stop sending these messages to the
> production bus until fedmsg_meta is updated and the update pushed to
> production. Why hasn't this been done already?

The basic answer is that I didn't have the hand to do it.
So instead I released a new fedmsg-meta-fedora-infrastructure with support for
these messages and deployed it in production.
Messages about the allpackages pipeline should now make some sense :)


Pierre
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Fw: fedmsg notification

2018-04-09 Thread Dominik 'Rathann' Mierzejewski
On Monday, 09 April 2018 at 13:20, Pierre-Yves Chibon wrote:
[...]
> Finally the reason this has not been correctly announced is that we are still
> investigating the capacity of the system and the pipeline to check if it can
> handle the load of all the package in Fedora, but as said, the pipeline is
> already sending messages to the production bus, thus this behavior :(

The obvious thing to do is to stop sending these messages to the
production bus until fedmsg_meta is updated and the update pushed to
production. Why hasn't this been done already?

Regards,
Dominik
-- 
Fedora   https://getfedora.org  |  RPMFusion   http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Fw: fedmsg notification

2018-04-09 Thread Pierre-Yves Chibon
On Mon, Apr 09, 2018 at 11:13:11AM +0100, Tom Hughes wrote:
> The body is not exactly meaningful either, and if you follow the
> link you just get a mostly blank page.
> 
> As best I can tell they are triggered by doing builds, but I seemed
> to get three from two builds yesterday so it's not exactly one-to-one
> but I still have no idea what they're about.
> 
> > >   
> > > https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/upstream-fedora-pipeline-trigger/detail/upstream-fedora-pipeline-trigger/8682/pipeline/


This is what we call the 'allpackage' CI pipeline, it triggers on every commit
made to any branch for all packages in Fedora (as opposed to the Atomic CI
pipeline that triggers only for a restricted set of packages).
The issue is that they have started publishing messages on the production bus
before we got the chance to update fedmsg_meta to support them.
And they changed the topic format to something that is close but not exactly
what is produced by the Atomic CI pipeline.
So the new messages from the allpackages pipeline are being picked up by the
part of fedmsg_meta that handles the messages from the Atomic CI pipeline but it
doesn't quite know how to process them which is why the subject and body of
these notifications are so useless.

There is a PR in fedmsg_meta adding support for the new topic of the messages
coming from the allpackages pipeline:
https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/472

Once it's reviewed and merged we'll be able to cut a release of fedmsg_meta and
push it to the FMN servers which will make these notifications somewhat more
meaning full.


Finally the reason this has not been correctly announced is that we are still
investigating the capacity of the system and the pipeline to check if it can
handle the load of all the package in Fedora, but as said, the pipeline is
already sending messages to the production bus, thus this behavior :(


Sorry for the inconvenience,
Pierre
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Fw: fedmsg notification

2018-04-09 Thread Tom Hughes

The body is not exactly meaningful either, and if you follow the
link you just get a mostly blank page.

As best I can tell they are triggered by doing builds, but I seemed
to get three from two builds yesterday so it's not exactly one-to-one
but I still have no idea what they're about.

Tom

On 09/04/18 11:02, Vít Ondruch wrote:

I don't mind to receive such notification, but I would welcome if the
subject was meaningful.

V.


Dne 8.4.2018 v 13:47 Michael Schwendt napsal(a):

Please make such a message flood opt-in by default instead of opt-out.
The communication about such new services and their purpose is extremely
poor IMO.

[...]

Begin forwarded message:

Date: Sat,  7 Apr 2018 23:42:01 + (UTC)
From: notifications fedoraproject org
Subject: fedmsg notification



https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/upstream-fedora-pipeline-trigger/detail/upstream-fedora-pipeline-trigger/8682/pipeline/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org




--
Tom Hughes (t...@compton.nu)
http://compton.nu/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Fw: fedmsg notification

2018-04-09 Thread Vít Ondruch
I don't mind to receive such notification, but I would welcome if the
subject was meaningful.

V.


Dne 8.4.2018 v 13:47 Michael Schwendt napsal(a):
> Please make such a message flood opt-in by default instead of opt-out.
> The communication about such new services and their purpose is extremely
> poor IMO.
>
> [...]
>
> Begin forwarded message:
>
> Date: Sat,  7 Apr 2018 23:42:01 + (UTC)
> From: notifications fedoraproject org
> Subject: fedmsg notification
>
>
>   
> https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/upstream-fedora-pipeline-trigger/detail/upstream-fedora-pipeline-trigger/8682/pipeline/
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org