Re: GitPython update blocked by rpkg - how can this be resolved?

[Chenxiong Qi]

On 11/12/2016 01:01 AM, Barry wrote:




Barry


On 10 Nov 2016, at 15:21, Chenxiong Qi  wrote:




On 11/10/2016 09:42 PM, Barry Scott wrote:
In this bug

   https://bugzilla.redhat.com/show_bug.cgi?id=1360797

It is implied that rpkg has an unspecified problem with GitPython 2.0.

This is preventing the maintainer from updating to the any GitPython 2
release.

I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.



Import error here.

 File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in 
   import git
 File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line 38, in 

   from git.config import GitConfigParser  # @NoMove @IgnorePep8
 File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25, in 

   from git.util import LockFile
 File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in 

   from unittest.case import SkipTest
ImportError: No module named case

GitPython >= 2 cannot work with Python 2.6 at all.


So on a system where you want to use rpkg with python 2.6 use GitPython 1.

But that is no reason to stop updating GitPython 2 for Fedora 24 where python 
2.7
Is used for rpkg right?



I've tested GitPython >= 2 with rpkg by running all existent tests, that 
covers most of the calls to GitPython API. All tests passed, and I don't 
see an issue. I'm glad to see the upgrade too. I think the upgrade 
should not be a big issue to rpkg, as there is still GitPython 1.x in EPEL6.



Barry





If there is a problem it would be nice if the rpkg people could comment on the
difficult of supporting GitPython 2. The python2.6 support question I suspect
can be handled by version checking in any conflicting code.

It seems wrong that rpkg is blocking updating to the latest GitPython,
preventing user of GitPython getting the bugs fixes and (as far as I am aware)
backwards compatible improvements.

Barry
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org



--
Regards,
Chenxiong Qi
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org



--
Regards,
Chenxiong Qi
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Mathieu Bridon]

On Tue, 2016-11-15 at 16:05 +, Barry wrote:
> I was hoping to find out if there is in fact a patch to rpkg is
> required.

Try, and you'll see?


-- 
Mathieu
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Barry]

> On 14 Nov 2016, at 13:25, Peter Robinson  wrote:
> 
> On Mon, Nov 14, 2016 at 1:23 PM, Peter Robinson  wrote:
> On 11/10/2016 09:42 PM, Barry Scott wrote:
> In this bug
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1360797
> 
> It is implied that rpkg has an unspecified problem with GitPython 2.0.
> 
> This is preventing the maintainer from updating to the any GitPython 2
> release.
> 
> I'd like to know if there is in fact a problem with rpkg with GitPython 
> 2.0.
> 
 
 Import error here.
 
 File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in 
   import git
 File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line 
 38, in 
   from git.config import GitConfigParser  # @NoMove @IgnorePep8
 File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25, 
 in 
   from git.util import LockFile
 File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in 
 
   from unittest.case import SkipTest
 ImportError: No module named case
 
 GitPython >= 2 cannot work with Python 2.6 at all.
>>> 
>>> So on a system where you want to use rpkg with python 2.6 use GitPython 1.
>>> 
>>> But that is no reason to stop updating GitPython 2 for Fedora 24 where 
>>> python 2.7
>>> Is used for rpkg right?
> 
> Take 2.
> 
> If the API is the same between the releases I don't see why it
> wouldn't be OK, presumably the reason why is has been held at that
> older version is that the API isn't compatible and would need someone
> to do a patch for rpkg to support both versions/APIs and I suspect
> that is that people haven't had the resource (time or otherwise) to do
> that.

My exprience with contribting to GitPython is tha backward compatibility was 
very important for any improvement.

I was hoping to find out if there is in fact a patch to rpkg is required.

Barry

> 
> Peter
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Peter Robinson]

On Mon, Nov 14, 2016 at 1:23 PM, Peter Robinson  wrote:
 On 11/10/2016 09:42 PM, Barry Scott wrote:
 In this bug

https://bugzilla.redhat.com/show_bug.cgi?id=1360797

 It is implied that rpkg has an unspecified problem with GitPython 2.0.

 This is preventing the maintainer from updating to the any GitPython 2
 release.

 I'd like to know if there is in fact a problem with rpkg with GitPython 
 2.0.

>>>
>>> Import error here.
>>>
>>>  File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in 
>>>import git
>>>  File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line 
>>> 38, in 
>>>from git.config import GitConfigParser  # @NoMove @IgnorePep8
>>>  File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25, 
>>> in 
>>>from git.util import LockFile
>>>  File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in 
>>> 
>>>from unittest.case import SkipTest
>>> ImportError: No module named case
>>>
>>> GitPython >= 2 cannot work with Python 2.6 at all.
>>
>> So on a system where you want to use rpkg with python 2.6 use GitPython 1.
>>
>> But that is no reason to stop updating GitPython 2 for Fedora 24 where 
>> python 2.7
>> Is used for rpkg right?

Take 2.

If the API is the same between the releases I don't see why it
wouldn't be OK, presumably the reason why is has been held at that
older version is that the API isn't compatible and would need someone
to do a patch for rpkg to support both versions/APIs and I suspect
that is that people haven't had the resource (time or otherwise) to do
that.

Peter
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Peter Robinson]

>>> On 11/10/2016 09:42 PM, Barry Scott wrote:
>>> In this bug
>>>
>>>https://bugzilla.redhat.com/show_bug.cgi?id=1360797
>>>
>>> It is implied that rpkg has an unspecified problem with GitPython 2.0.
>>>
>>> This is preventing the maintainer from updating to the any GitPython 2
>>> release.
>>>
>>> I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.
>>>
>>
>> Import error here.
>>
>>  File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in 
>>import git
>>  File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line 38, 
>> in 
>>from git.config import GitConfigParser  # @NoMove @IgnorePep8
>>  File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25, 
>> in 
>>from git.util import LockFile
>>  File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in 
>> 
>>from unittest.case import SkipTest
>> ImportError: No module named case
>>
>> GitPython >= 2 cannot work with Python 2.6 at all.
>
> So on a system where you want to use rpkg with python 2.6 use GitPython 1.
>
> But that is no reason to stop updating GitPython 2 for Fedora 24 where python 
> 2.7
> Is used for rpkg right?

If the API is the same between the releases I don't see why it
wouldn't be OK, presumably the reason why is tha

>>> If there is a problem it would be nice if the rpkg people could comment on 
>>> the
>>> difficult of supporting GitPython 2. The python2.6 support question I 
>>> suspect
>>> can be handled by version checking in any conflicting code.
>>>
>>> It seems wrong that rpkg is blocking updating to the latest GitPython,
>>> preventing user of GitPython getting the bugs fixes and (as far as I am 
>>> aware)
>>> backwards compatible improvements.
>>>
>>> Barry
>>> ___
>>> devel mailing list -- devel@lists.fedoraproject.org
>>> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
>>>
>>
>> --
>> Regards,
>> Chenxiong Qi
>> ___
>> devel mailing list -- devel@lists.fedoraproject.org
>> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Barry]

> On 10 Nov 2016, at 14:07, Josh Boyer  wrote:
> 
>> On Thu, Nov 10, 2016 at 8:42 AM, Barry Scott  wrote:
>> In this bug
>> 
>>https://bugzilla.redhat.com/show_bug.cgi?id=1360797
>> 
>> It is implied that rpkg has an unspecified problem with GitPython 2.0.
>> 
>> This is preventing the maintainer from updating to the any GitPython 2
>> release.
>> 
>> I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.
>> 
>> If there is a problem it would be nice if the rpkg people could comment on 
>> the
>> difficult of supporting GitPython 2. The python2.6 support question I suspect
>> can be handled by version checking in any conflicting code.
>> 
>> It seems wrong that rpkg is blocking updating to the latest GitPython,
>> preventing user of GitPython getting the bugs fixes and (as far as I am 
>> aware)
>> backwards compatible improvements.
> 
> Why does it seem wrong?

May be surprising is a better description.

> 
> josh
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Barry]

Barry

> On 10 Nov 2016, at 15:21, Chenxiong Qi  wrote:
> 
> 
> 
>> On 11/10/2016 09:42 PM, Barry Scott wrote:
>> In this bug
>> 
>>https://bugzilla.redhat.com/show_bug.cgi?id=1360797
>> 
>> It is implied that rpkg has an unspecified problem with GitPython 2.0.
>> 
>> This is preventing the maintainer from updating to the any GitPython 2
>> release.
>> 
>> I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.
>> 
> 
> Import error here.
> 
>  File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in 
>import git
>  File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", line 38, 
> in 
>from git.config import GitConfigParser  # @NoMove @IgnorePep8
>  File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 25, in 
> 
>from git.util import LockFile
>  File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 18, in 
> 
>from unittest.case import SkipTest
> ImportError: No module named case
> 
> GitPython >= 2 cannot work with Python 2.6 at all.

So on a system where you want to use rpkg with python 2.6 use GitPython 1.

But that is no reason to stop updating GitPython 2 for Fedora 24 where python 
2.7
Is used for rpkg right?

Barry


> 
>> If there is a problem it would be nice if the rpkg people could comment on 
>> the
>> difficult of supporting GitPython 2. The python2.6 support question I suspect
>> can be handled by version checking in any conflicting code.
>> 
>> It seems wrong that rpkg is blocking updating to the latest GitPython,
>> preventing user of GitPython getting the bugs fixes and (as far as I am 
>> aware)
>> backwards compatible improvements.
>> 
>> Barry
>> ___
>> devel mailing list -- devel@lists.fedoraproject.org
>> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
>> 
> 
> -- 
> Regards,
> Chenxiong Qi
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Chenxiong Qi]

On 11/10/2016 09:42 PM, Barry Scott wrote:

In this bug

https://bugzilla.redhat.com/show_bug.cgi?id=1360797

It is implied that rpkg has an unspecified problem with GitPython 2.0.

This is preventing the maintainer from updating to the any GitPython 2
release.

I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.



Import error here.

  File "/root/code/rpkg/pyrpkg/__init__.py", line 14, in 
import git
  File "/root/rpkg-env/lib/python2.6/site-packages/git/__init__.py", 
line 38, in 

from git.config import GitConfigParser  # @NoMove @IgnorePep8
  File "/root/rpkg-env/lib/python2.6/site-packages/git/config.py", line 
25, in 

from git.util import LockFile
  File "/root/rpkg-env/lib/python2.6/site-packages/git/util.py", line 
18, in 

from unittest.case import SkipTest
ImportError: No module named case

GitPython >= 2 cannot work with Python 2.6 at all.


If there is a problem it would be nice if the rpkg people could comment on the
difficult of supporting GitPython 2. The python2.6 support question I suspect
can be handled by version checking in any conflicting code.

It seems wrong that rpkg is blocking updating to the latest GitPython,
preventing user of GitPython getting the bugs fixes and (as far as I am aware)
backwards compatible improvements.

Barry
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org



--
Regards,
Chenxiong Qi
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Dan Horák]

On Thu, 10 Nov 2016 09:07:54 -0500
Josh Boyer  wrote:

> On Thu, Nov 10, 2016 at 8:42 AM, Barry Scott 
> wrote:
> > In this bug
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1360797
> >
> > It is implied that rpkg has an unspecified problem with GitPython
> > 2.0.
> >
> > This is preventing the maintainer from updating to the any
> > GitPython 2 release.
> >
> > I'd like to know if there is in fact a problem with rpkg with
> > GitPython 2.0.
> >
> > If there is a problem it would be nice if the rpkg people could
> > comment on the difficult of supporting GitPython 2. The python2.6
> > support question I suspect can be handled by version checking in
> > any conflicting code.
> >
> > It seems wrong that rpkg is blocking updating to the latest
> > GitPython, preventing user of GitPython getting the bugs fixes and
> > (as far as I am aware) backwards compatible improvements.
> 
> Why does it seem wrong?

yep, a distribution is about compromises, but couldn't a compat
GitPython-1 package solve the problem, if both GitPython 1 and 2 can be
installed in parallel?


Dan
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: GitPython update blocked by rpkg - how can this be resolved?

[Josh Boyer]

On Thu, Nov 10, 2016 at 8:42 AM, Barry Scott  wrote:
> In this bug
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1360797
>
> It is implied that rpkg has an unspecified problem with GitPython 2.0.
>
> This is preventing the maintainer from updating to the any GitPython 2
> release.
>
> I'd like to know if there is in fact a problem with rpkg with GitPython 2.0.
>
> If there is a problem it would be nice if the rpkg people could comment on the
> difficult of supporting GitPython 2. The python2.6 support question I suspect
> can be handled by version checking in any conflicting code.
>
> It seems wrong that rpkg is blocking updating to the latest GitPython,
> preventing user of GitPython getting the bugs fixes and (as far as I am aware)
> backwards compatible improvements.

Why does it seem wrong?

josh
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org