Re: changing the name of a package
On 06-05-2023 19:26, Globe Trotter via devel wrote: The reason stapler was published as pdf-stapler was that there was then a package called stapler on Fedora, so it was suggested to me that I use pdf-stapler, which is any case better because it emphasizes that the software is for pdfs. However, the name stapler itself is quite meaningless but upstream did not buy my argument:-( Perhaps we call it python-pdf-stapler? I see. Whatever provided /usr/bin/stapler has gone. However, I jumped to conclusions a bit too soon. It seems the package could do with some clean up in general. But that's not for you, but for upstream. E.g. the test stuff is not separate from the sources and thus installed along with the module. I will look into making use of the Python macros. Hopefully it is not problematic, because I am still not all that familliar with the process. Thanks! I put in a PR changing the spec file to use the new Python macros as well as fixing some (minor) issues. See it as a starting point. Feel free to ask in the PR if anything is unclear. I'm coming back on the renaming discussion. As Ben stated: You could make a case for renaming the python3-staplelib subpackage to python3-staple, adding the appropriate Obsoletes[2], and adding %py_provides python3-staplelib I saw that the installed module is in fact called 'staplelib', while the package on PyPI is called 'stapler'. In that regard I don't see a need to rename at all and there are reasons why the package is named 'pdf-stapler'. If at all, you could add '%py_provides python3-stapler' to align it with PyPI. -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On Sat May 6, 2023 at 16:38 +0200, Sandro wrote: > On 06-05-2023 16:29, Globe Trotter via devel wrote: > > sudo fedrq whatrequires python-PyPDF2 > > > > does not list pdf-stapler as a reverse dependency, however it does > > include python3-staplelib which is part of the pdf-stapler > > packaging. > > It lists python3-staplelib for me: > > fedrq wr python3-PyPDF2 > pdfposter-0.7.post1-16.fc38.noarch > python-mapnik-3.0.23-23.20200224git7da019c.fc39.src > python3-krop-0.5.1-16.fc38.noarch > python3-staplelib-1.0.0-0.13.20191215git8753251.fc38.noarch You can use `fedrq whatrequires` with the `-F source` option to get the names of the source packages. ``` $ fedrq wr -F source python3-PyPDF2 pdfposter python-mapnik krop pdf-stapler ``` The maintainer emails are , so you'd need to email ``` $ fedrq wr -F source python3-PyPDF2 | sed 's|$|-maintain...@fedoraproject.org|' pdfposter-maintain...@fedoraproject.org python-mapnik-maintain...@fedoraproject.org krop-maintain...@fedoraproject.org pdf-stapler-maintain...@fedoraproject.org ``` to get in contact with them. -- Best, Maxwell G (@gotmax23) Pronouns: He/They ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
Thanks, Sandro! The reason stapler was published as pdf-stapler was that there was then a package called stapler on Fedora, so it was suggested to me that I use pdf-stapler, which is any case better because it emphasizes that the software is for pdfs. However, the name stapler itself is quite meaningless but upstream did not buy my argument:-( Perhaps we call it python-pdf-stapler? I will look into making use of the Python macros. Hopefully it is not problematic, because I am still not all that familliar with the process. Thanks! On Saturday, May 6, 2023 at 09:58:48 AM CDT, Sandro wrote: On 06-05-2023 16:44, Globe Trotter via devel wrote: > Right, but not pdf-stapler. I would have thought that that might be > included too. Anyway, I am the maintainer for pdf-stapler so I can > make myself aware, but I hope I will not be missing others. Well, looking at the spec file of pdf-stapler you can see why that is: %package -n python3-staplelib Summary: Module staplelib of pdf-stapler Requires: python3-PyPDF2 By the way, since you are the maintainer of pdf-stapler, I'd highly recommend transforming the spec file so it makes use of the Python macros. That will autogenerate dependencies and provides. See [1]. Moreover, pdf-stapler package itself should probably be renamed to python-stapler to comply with the PyPI parity requirements [2] of the packaging guidelines. The package is published on PyPI as 'stapler'. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On 06-05-2023 18:48, Ben Beasley wrote: I don’t think the PyPI parity rule needs to apply to the base package name, since this is primarily an application package and thus falls under the general naming guidelines[1]. You could make a case for renaming the python3-staplelib subpackage to python3-staple, adding the appropriate Obsoletes[2], and adding %py_provides python3-staplelib[3]. [1]https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming [2]https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages [3]https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules Thanks for the clarification. It makes sense. Although, I'm still having a hard time determining what the primary purpose of a package is when it provides both, an application and a library/module, which can be used by other Python packages. -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On Sat, May 6, 2023, at 10:58 AM, Sandro wrote: > Moreover, pdf-stapler package itself should probably be renamed to > python-stapler to comply with the PyPI parity requirements [2] of the > packaging guidelines. The package is published on PyPI as 'stapler'. > > [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > [2] > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity I don’t think the PyPI parity rule needs to apply to the base package name, since this is primarily an application package and thus falls under the general naming guidelines[1]. You could make a case for renaming the python3-staplelib subpackage to python3-staple, adding the appropriate Obsoletes[2], and adding %py_provides python3-staplelib[3]. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On 06-05-2023 16:44, Globe Trotter via devel wrote: Right, but not pdf-stapler. I would have thought that that might be included too. Anyway, I am the maintainer for pdf-stapler so I can make myself aware, but I hope I will not be missing others. Well, looking at the spec file of pdf-stapler you can see why that is: %package -n python3-staplelib Summary:Module staplelib of pdf-stapler Requires: python3-PyPDF2 By the way, since you are the maintainer of pdf-stapler, I'd highly recommend transforming the spec file so it makes use of the Python macros. That will autogenerate dependencies and provides. See [1]. Moreover, pdf-stapler package itself should probably be renamed to python-stapler to comply with the PyPI parity requirements [2] of the packaging guidelines. The package is published on PyPI as 'stapler'. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
Right, but not pdf-stapler. I would have thought that that might be included too. Anyway, I am the maintainer for pdf-stapler so I can make myself aware, but I hope I will not be missing others. On Saturday, May 6, 2023 at 09:38:32 AM CDT, Sandro wrote: On 06-05-2023 16:29, Globe Trotter via devel wrote: > sudo fedrq whatrequires python-PyPDF2 > > does not list pdf-stapler as a reverse dependency, however it does > include python3-staplelib which is part of the pdf-stapler > packaging. It lists python3-staplelib for me: fedrq wr python3-PyPDF2 pdfposter-0.7.post1-16.fc38.noarch python-mapnik-3.0.23-23.20200224git7da019c.fc39.src python3-krop-0.5.1-16.fc38.noarch python3-staplelib-1.0.0-0.13.20191215git8753251.fc38.noarch > But how do I inform all the other maintainers about this change in a > package name? I guess my concern is that some of them may not > respond. The renamed package will provide proper obsoletes, making the change transparent. In addition you can sent an announcements to devel list and cc the maintainers using the -maintainers@fp.o generic addresses. -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On 06-05-2023 16:41, Sandro wrote: On 06-05-2023 16:38, Sandro wrote: sudo fedrq whatrequires python-PyPDF2 does not list pdf-stapler as a reverse dependency, however it does include python3-staplelib which is part of the pdf-stapler packaging. It lists python3-staplelib for me: fedrq wr python3-PyPDF2 pdfposter-0.7.post1-16.fc38.noarch python-mapnik-3.0.23-23.20200224git7da019c.fc39.src python3-krop-0.5.1-16.fc38.noarch python3-staplelib-1.0.0-0.13.20191215git8753251.fc38.noarch To clarify, python-PyPDF2 is the src package. The python3 sub package, containing the modules, is what other packages depend on. s/python-PyPDF2/pdf-stapler python3-staplelib is a sub package of pdf-stapler. --Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On 06-05-2023 16:38, Sandro wrote: sudo fedrq whatrequires python-PyPDF2 does not list pdf-stapler as a reverse dependency, however it does include python3-staplelib which is part of the pdf-stapler packaging. It lists python3-staplelib for me: fedrq wr python3-PyPDF2 pdfposter-0.7.post1-16.fc38.noarch python-mapnik-3.0.23-23.20200224git7da019c.fc39.src python3-krop-0.5.1-16.fc38.noarch python3-staplelib-1.0.0-0.13.20191215git8753251.fc38.noarch To clarify, python-PyPDF2 is the src package. The python3 sub package, containing the modules, is what other packages depend on. -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On 06-05-2023 16:29, Globe Trotter via devel wrote: sudo fedrq whatrequires python-PyPDF2 does not list pdf-stapler as a reverse dependency, however it does include python3-staplelib which is part of the pdf-stapler packaging. It lists python3-staplelib for me: fedrq wr python3-PyPDF2 pdfposter-0.7.post1-16.fc38.noarch python-mapnik-3.0.23-23.20200224git7da019c.fc39.src python3-krop-0.5.1-16.fc38.noarch python3-staplelib-1.0.0-0.13.20191215git8753251.fc38.noarch But how do I inform all the other maintainers about this change in a package name? I guess my concern is that some of them may not respond. The renamed package will provide proper obsoletes, making the change transparent. In addition you can sent an announcements to devel list and cc the maintainers using the -maintainers@fp.o generic addresses. -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
Strange that sudo fedrq whatrequires python-PyPDF2 does not list pdf-stapler as a reverse dependency, however it does include python3-staplelib which is part of the pdf-stapler packaging. But how do I inform all the other maintainers about this change in a package name? I guess my concern is that some of them may not respond. On Saturday, May 6, 2023 at 09:01:28 AM CDT, Sandro wrote: On 06-05-2023 15:36, Globe Trotter via devel wrote: > Is there an easy way to find out the reverse dependencies of a > package (PyPDF2)? Should I contact the maintainers of these reverse > dependencies to inform them? PyPDF2 has been renamed back to pypdf. > It is unclear to me why renames in either direction happened, but we > are where we are. I find fedrq quite helpful. https://packages.fedoraproject.org/pkgs/fedrq/fedrq/ https://fedrq.gtmx.me/ -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On 06-05-2023 15:36, Globe Trotter via devel wrote: Is there an easy way to find out the reverse dependencies of a package (PyPDF2)? Should I contact the maintainers of these reverse dependencies to inform them? PyPDF2 has been renamed back to pypdf. It is unclear to me why renames in either direction happened, but we are where we are. I find fedrq quite helpful. https://packages.fedoraproject.org/pkgs/fedrq/fedrq/ https://fedrq.gtmx.me/ -- Sandro ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
On Saturday, May 6, 2023 at 01:13:18 AM CDT, Paweł Marciniak wrote: https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages Thanks! Is there an easy way to find out the reverse dependencies of a package (PyPDF2)? Should I contact the maintainers of these reverse dependencies to inform them? PyPDF2 has been renamed back to pypdf. It is unclear to me why renames in either direction happened, but we are where we are. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: changing the name of a package
https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
