Re: Unannounced soname bump: libreport
On Wed, 2020-08-26 at 20:09 +, Michal Fabik wrote: > Hey guys, > I wish to apologize for the mess. It's only my second or third > release and the first one that involved a soname bump, which, as I've > learned, was the first-ever soname bump for libreport. Reportedly, it > hadn't really been necessary ever before (even though there had been > ABI changes in the past) because nobody else is using our code. I > realize now that I should have studied the whole issue more > thoroughly before even touching anything. Thank you for all the other > complaints and remarks in this thread. I'll try to learn from them > and do my best to not let the situation repeat itself, though I'm > afraid I'll volunteer to do the next release as well, in an attempt > to overcome this rather traumatic experience. Get back on the horse, > they say. > > > As for the situation right now, there's a fresh bodhi update for f33: > https://bodhi.fedoraproject.org/updates/FEDORA-2020-59e144acee > We decided to revoke the updates for f31 and f32. Thanks Michal. Everything looks in line with the F33 update now, to me. The two failed openQA tests are known issues not caused by the update. A Rawhide compose is currently running, which will let us know if there are still any non-obvious issues lurking. You're not the first or last person to get this a bit wrong, don't worry :) But it's important to get it right for libreport because it and abrt are part of release-blocking images, so if it gets out of line, composes start failing, and we really don't want that. We also needed to actually get the update into F33 because of the Beta blocker bug. Thanks again. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
Hey guys, I wish to apologize for the mess. It's only my second or third release and the first one that involved a soname bump, which, as I've learned, was the first-ever soname bump for libreport. Reportedly, it hadn't really been necessary ever before (even though there had been ABI changes in the past) because nobody else is using our code. I realize now that I should have studied the whole issue more thoroughly before even touching anything. Thank you for all the other complaints and remarks in this thread. I'll try to learn from them and do my best to not let the situation repeat itself, though I'm afraid I'll volunteer to do the next release as well, in an attempt to overcome this rather traumatic experience. Get back on the horse, they say. As for the situation right now, there's a fresh bodhi update for f33: https://bodhi.fedoraproject.org/updates/FEDORA-2020-59e144acee We decided to revoke the updates for f31 and f32. Sorry again. -- Michal ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On Fri, Aug 14, 2020 at 11:14:59AM -0400, Neal Gompa wrote:
> On Fri, Aug 14, 2020 at 11:12 AM Fabio Valentini wrote:
> >
> > On Fri, Aug 14, 2020 at 5:01 PM Michael Schwendt
> > wrote:
> > >
> > > On Fri, 14 Aug 2020 16:37:28 +0200, Fabio Valentini wrote:
> > >
> > > > > As a side note, the update now has arch specific BuildRequires, so
> > > > > the SRPM
> > > > > cannot be rebuilt on anything but .
> > > > >
> > > > > https://koschei.fedoraproject.org/package/libreport?collection=f33
> > > >
> > > > Aaaw ... stuff like this makes me sad :(
> > >
> > > What makes me sad is the poorly maintained package %changelog. Instead of
> > > summing up changes to the RPM package, it sums up changes internal to
> > > libreport. It does not list any of the spec file changes.
> > >
> > > A massive commit to the package without any %changelog entry:
> > > https://src.fedoraproject.org/rpms/libreport/c/246d3174118e03cbb345f1d434f3fbe11864b015?branch=master
> >
> > True. This is bad :( This is also the commit that added %{?_isa} to
> > BuildRequires. WHYYY
> >
> > > And later the addition of a %changelog entry that doesn't cover any of the
> > > package changes.
> >
> > It's also for the wrong version (2.13-2 instead of 2.14-2) ... which
> > was fixed in the next commit, with another Release bump. :(
>
> As far as I know, libreport is directly synced from the
> libreport.spec.in in the libreport git repo on GitHub:
> https://github.com/abrt/libreport/blob/master/libreport.spec.in
So %{_isa} changes would be from this:
https://github.com/abrt/libreport/commit/729214f13b1c036e4f9299ddcd12e9219a6ab60a
> I am unsure if ABRT folks are even reviewing stuff going on in Dist-Git...
What do you mean by that?
--
Tomasz TorczTo co nierealne – tutaj jest normalne.
to...@pipebreaker.pl Ziomale na życie mają tu patenty specjalne.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On Fri, Aug 14, 2020 at 11:12 AM Fabio Valentini wrote:
>
> On Fri, Aug 14, 2020 at 5:01 PM Michael Schwendt wrote:
> >
> > On Fri, 14 Aug 2020 16:37:28 +0200, Fabio Valentini wrote:
> >
> > > > As a side note, the update now has arch specific BuildRequires, so the
> > > > SRPM
> > > > cannot be rebuilt on anything but .
> > > >
> > > > https://koschei.fedoraproject.org/package/libreport?collection=f33
> > >
> > > Aaaw ... stuff like this makes me sad :(
> >
> > What makes me sad is the poorly maintained package %changelog. Instead of
> > summing up changes to the RPM package, it sums up changes internal to
> > libreport. It does not list any of the spec file changes.
> >
> > A massive commit to the package without any %changelog entry:
> > https://src.fedoraproject.org/rpms/libreport/c/246d3174118e03cbb345f1d434f3fbe11864b015?branch=master
>
> True. This is bad :( This is also the commit that added %{?_isa} to
> BuildRequires. WHYYY
>
> > And later the addition of a %changelog entry that doesn't cover any of the
> > package changes.
>
> It's also for the wrong version (2.13-2 instead of 2.14-2) ... which
> was fixed in the next commit, with another Release bump. :(
As far as I know, libreport is directly synced from the
libreport.spec.in in the libreport git repo on GitHub:
https://github.com/abrt/libreport/blob/master/libreport.spec.in
I am unsure if ABRT folks are even reviewing stuff going on in Dist-Git...
--
真実はいつも一つ！/ Always, there's only one truth!
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On Fri, Aug 14, 2020 at 5:01 PM Michael Schwendt wrote:
>
> On Fri, 14 Aug 2020 16:37:28 +0200, Fabio Valentini wrote:
>
> > > As a side note, the update now has arch specific BuildRequires, so the
> > > SRPM
> > > cannot be rebuilt on anything but .
> > >
> > > https://koschei.fedoraproject.org/package/libreport?collection=f33
> >
> > Aaaw ... stuff like this makes me sad :(
>
> What makes me sad is the poorly maintained package %changelog. Instead of
> summing up changes to the RPM package, it sums up changes internal to
> libreport. It does not list any of the spec file changes.
>
> A massive commit to the package without any %changelog entry:
> https://src.fedoraproject.org/rpms/libreport/c/246d3174118e03cbb345f1d434f3fbe11864b015?branch=master
True. This is bad :( This is also the commit that added %{?_isa} to
BuildRequires. WHYYY
> And later the addition of a %changelog entry that doesn't cover any of the
> package changes.
It's also for the wrong version (2.13-2 instead of 2.14-2) ... which
was fixed in the next commit, with another Release bump. :(
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On Fri, 14 Aug 2020 16:37:28 +0200, Fabio Valentini wrote: > > As a side note, the update now has arch specific BuildRequires, so the SRPM > > cannot be rebuilt on anything but . > > > > https://koschei.fedoraproject.org/package/libreport?collection=f33 > > Aaaw ... stuff like this makes me sad :( What makes me sad is the poorly maintained package %changelog. Instead of summing up changes to the RPM package, it sums up changes internal to libreport. It does not list any of the spec file changes. A massive commit to the package without any %changelog entry: https://src.fedoraproject.org/rpms/libreport/c/246d3174118e03cbb345f1d434f3fbe11864b015?branch=master And later the addition of a %changelog entry that doesn't cover any of the package changes. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On Fri, Aug 14, 2020 at 4:32 PM Miro Hrončok wrote: > > On 14. 08. 20 2:10, Adam Williamson wrote: > > A new build of libreport was done for all releases today by mfabik: > > > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592551 > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592550 > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592524 > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592531 > > ... > > As a side note, the update now has arch specific BuildRequires, so the SRPM > cannot be rebuilt on anything but . > > https://koschei.fedoraproject.org/package/libreport?collection=f33 Aaaw ... stuff like this makes me sad :( ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On 14. 08. 20 2:10, Adam Williamson wrote: A new build of libreport was done for all releases today by mfabik: https://koji.fedoraproject.org/koji/buildinfo?buildID=1592551 https://koji.fedoraproject.org/koji/buildinfo?buildID=1592550 https://koji.fedoraproject.org/koji/buildinfo?buildID=1592524 https://koji.fedoraproject.org/koji/buildinfo?buildID=1592531 > ... As a side note, the update now has arch specific BuildRequires, so the SRPM cannot be rebuilt on anything but . https://koschei.fedoraproject.org/package/libreport?collection=f33 -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Unannounced soname bump: libreport
On Thu, 2020-08-13 at 17:10 -0700, Adam Williamson wrote: > A new build of libreport was done for all releases today by mfabik: > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592551 > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592550 > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592524 > https://koji.fedoraproject.org/koji/buildinfo?buildID=1592531 > > This build changes the soname of libreport from libreport.so.0 to > libreport.so.1 (and indeed does introduce several API and ABI changes). > > It was sent out as a 'stable' update for F31 and F32 (despite the > soname bump). None of libreport's dependencies - notably including abrt > - have been rebuilt for any release, AFAIK. > > This means abrt is uninstallable in F33 and Rawhide build roots at > present and probably will break subsequent F33 and Rawhide composes > because there are probably release-blocking images with abrt in them. I > have filed negative karma on the F31 and F32 updates, which failed > openQA testing due to this issue. > > It seems a new release of abrt has been made upstream, but at least one > commit *after* that release looks necessary for the latest libreport. > Additionally my first attempt to build the new release failed because > the tarball was missing a file: > https://github.com/abrt/abrt/issues/1519 > I am continuing to try and get a successful abrt build, but if we can't > manage at least that, we will need to untag this build for F33 and > Rawhide. Follow up: couldn't get an abrt build to fly. It appears that the spec file is lying about the source tarball locations. It points to the github archive, but the tarball that's in dist-git for 2.14.2 is clearly *not* the one you get from the github archive: [adamw@adam abrt (master %)]$ spectool -g abrt.spec Downloading: https://github.com/abrt/abrt/archive/2.14.2/abrt-2.14.2.tar.gz [adamw@adam abrt (master %)]$ sha256sum abrt-2.14.2.tar.gz df9ae2e649319ceffa64a301d946c6cfc6e8c7156566ec783fb6bf3c7c8c8249 abrt-2.14.2.tar.gz [adamw@adam abrt (master %)]$ rm -f abrt-2.14.2.tar.gz [adamw@adam abrt (master %)]$ fedpkg srpm Downloading abrt-2.14.2.tar.gz [adamw@adam abrt (master %)]$ sha256sum abrt-2.14.2.tar.gz 735b97f6e6ae5af431aa68abd39c185f6de6afcbfe29453d26d696eeab24c0e4 abrt-2.14.2.tar.gz 'spectool -g' downloads the tarball from wherever the spec file claims it is from, 'fedpkg srpm' command downloads the tarball from dist-git; as you can see, the two are not the same. The one from github is just a github auto-generated source tree dump, without the autogen.sh script run on it; the one from dist-git is a "real" release tarball, which clearly did have autogen.sh run on it, but I can find no indication anywhere of where such "real" release tarballs can actually be downloaded, hence nowhere to get one for 2.14.3. It seems they used to be published on fedorahosted.org, but that is shut down now, and I can't find any other location mentioned anywhere. If I use the github tarball and try to run `autoreconf -i -f` on it I get a weirdly broken configure which has just a '.' command in the middle of the comments at the top, and doesn't work. No idea why that happens. Anyway, since I can't get abrt to build, mboddu has untagged libreport 2.14.0 from F33 and Rawhide for now. They can be retagged once someone sorts this mess out. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Unannounced soname bump: libreport
A new build of libreport was done for all releases today by mfabik: https://koji.fedoraproject.org/koji/buildinfo?buildID=1592551 https://koji.fedoraproject.org/koji/buildinfo?buildID=1592550 https://koji.fedoraproject.org/koji/buildinfo?buildID=1592524 https://koji.fedoraproject.org/koji/buildinfo?buildID=1592531 This build changes the soname of libreport from libreport.so.0 to libreport.so.1 (and indeed does introduce several API and ABI changes). It was sent out as a 'stable' update for F31 and F32 (despite the soname bump). None of libreport's dependencies - notably including abrt - have been rebuilt for any release, AFAIK. This means abrt is uninstallable in F33 and Rawhide build roots at present and probably will break subsequent F33 and Rawhide composes because there are probably release-blocking images with abrt in them. I have filed negative karma on the F31 and F32 updates, which failed openQA testing due to this issue. It seems a new release of abrt has been made upstream, but at least one commit *after* that release looks necessary for the latest libreport. Additionally my first attempt to build the new release failed because the tarball was missing a file: https://github.com/abrt/abrt/issues/1519 I am continuing to try and get a successful abrt build, but if we can't manage at least that, we will need to untag this build for F33 and Rawhide. Other dependencies are abrt-java-connector and reportd, which I haven't looked into it detail yet. Please remember to announce soname bumps ahead of time so this kind of problem can be avoided. Thanks. Please also try and generally do a better job of release engineering and co-ordination...:) -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
