Re: qt (4) no longer injects $RPM_OPT_FLAGS by default (on f24+)

2016-02-02 Thread Rex Dieter
Michael J Gruber wrote:

> Rex Dieter venit, vidit, dixit 18.01.2016 15:00:
>> In response to recent additions to default $RPM_OPT_FLAGS that depend on
>> redhat-rpm-config to be present, and in response to bug
>> http://bugzilla.redhat.com/1279265
>> 
>> Qt4's qmake will no longer inject $RPM_OPT_FLAGS any more, starting with
>> qt-4.8.7-6.f24
>> 
>> Packages that use qmake will have to find some other mechanism, options
>> include:
>> 1.  use %qmake_qt4 macro instead of calling qmake manually
>> 2.  set appropriate envrionment/qmake variables by hand
>> 3.  patch your buildsystem as needed
>> 4.  some better idea
>> 
>> 
>> Please let me know if you have any questions about this.  If any packages
>> need fixing, I'd encourage bugs to be filed, and block bug #1279265 , and
>> I'll make every effort to help fix things.
> 
> Well, in the first place it would be nice not to push FTBFS commits to
> packages you don't own without contacting maintainers before:
> 
> http://koji.fedoraproject.org/koji/buildinfo?buildID=715340

I'm *pretty* sure my commit was not the cause of that failure.

Regardless, sorry.

-- Rex
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: qt (4) no longer injects $RPM_OPT_FLAGS by default (on f24+)

2016-02-02 Thread Tom Hughes

On 02/02/16 07:09, Tom Hughes wrote:


Yes, they've done the same thing to one of my packages as well.

What's more they had already been in contact with me over the weekend
and knew there was an issue that I was looking at but still went ahead
and broke it anyway.


I take that back - turns out I had already pushed the breaking change at 
the weekend when they originally contacted me. I thought I had only done 
a scratch build but apparently not.


Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: qt (4) no longer injects $RPM_OPT_FLAGS by default (on f24+)

2016-02-02 Thread Pierre-Yves Chibon
On Tue, Feb 02, 2016 at 08:00:43AM +0100, Michael J Gruber wrote:
> Well, in the first place it would be nice not to push FTBFS commits to
> packages you don't own without contacting maintainers before:

Well, one thing about this is that no-one owns packages anymore. We are a
community and there are package maintainers in that community.
Each package has one or more maintainers, but nobody owns it. The only reason we
even have a point of contact is because of bugzilla that requires a single
account to assign the bug reports to.

So sorry but you do not own your packages, you maintain them and where you are
the point of contact, you are merely the primary recipient of the bug reports :)


Pierre
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: qt (4) no longer injects $RPM_OPT_FLAGS by default (on f24+)

2016-02-01 Thread Michael J Gruber
Rex Dieter venit, vidit, dixit 18.01.2016 15:00:
> In response to recent additions to default $RPM_OPT_FLAGS that depend on 
> redhat-rpm-config to be present, and in response to bug
> http://bugzilla.redhat.com/1279265
> 
> Qt4's qmake will no longer inject $RPM_OPT_FLAGS any more, starting with 
> qt-4.8.7-6.f24
> 
> Packages that use qmake will have to find some other mechanism, options 
> include:
> 1.  use %qmake_qt4 macro instead of calling qmake manually
> 2.  set appropriate envrionment/qmake variables by hand
> 3.  patch your buildsystem as needed
> 4.  some better idea
> 
> 
> Please let me know if you have any questions about this.  If any packages 
> need fixing, I'd encourage bugs to be filed, and block bug #1279265 , and 
> I'll make every effort to help fix things.

Well, in the first place it would be nice not to push FTBFS commits to
packages you don't own without contacting maintainers before:

http://koji.fedoraproject.org/koji/buildinfo?buildID=715340

And no, I don't consider a post titled "qt (4) does not inject..."
(obviously a bug report about qt4...) to be contacting maintainers, let
alone a call for action.

We do have tools for that, such as bugzilla, that contact package owners
automatically.

Michael
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: qt (4) no longer injects $RPM_OPT_FLAGS by default (on f24+)

2016-02-01 Thread Tom Hughes

On 02/02/16 07:00, Michael J Gruber wrote:

Rex Dieter venit, vidit, dixit 18.01.2016 15:00:

In response to recent additions to default $RPM_OPT_FLAGS that depend on
redhat-rpm-config to be present, and in response to bug
http://bugzilla.redhat.com/1279265

Qt4's qmake will no longer inject $RPM_OPT_FLAGS any more, starting with
qt-4.8.7-6.f24

Packages that use qmake will have to find some other mechanism, options
include:
1.  use %qmake_qt4 macro instead of calling qmake manually
2.  set appropriate envrionment/qmake variables by hand
3.  patch your buildsystem as needed
4.  some better idea


Please let me know if you have any questions about this.  If any packages
need fixing, I'd encourage bugs to be filed, and block bug #1279265 , and
I'll make every effort to help fix things.


Well, in the first place it would be nice not to push FTBFS commits to
packages you don't own without contacting maintainers before:

http://koji.fedoraproject.org/koji/buildinfo?buildID=715340


Yes, they've done the same thing to one of my packages as well.

What's more they had already been in contact with me over the weekend 
and knew there was an issue that I was looking at but still went ahead 
and broke it anyway.


Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

qt (4) no longer injects $RPM_OPT_FLAGS by default (on f24+)

2016-01-18 Thread Rex Dieter
In response to recent additions to default $RPM_OPT_FLAGS that depend on 
redhat-rpm-config to be present, and in response to bug
http://bugzilla.redhat.com/1279265

Qt4's qmake will no longer inject $RPM_OPT_FLAGS any more, starting with 
qt-4.8.7-6.f24

Packages that use qmake will have to find some other mechanism, options 
include:
1.  use %qmake_qt4 macro instead of calling qmake manually
2.  set appropriate envrionment/qmake variables by hand
3.  patch your buildsystem as needed
4.  some better idea


Please let me know if you have any questions about this.  If any packages 
need fixing, I'd encourage bugs to be filed, and block bug #1279265 , and 
I'll make every effort to help fix things.


Qt5 will likely follow suit soon.

-- Rex
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org