Re: state of fedora-review?
On Sun, Mar 3, 2019 at 7:48 PM Robert-André Mauchin wrote: > > I've got a COPR based on the devel branch: > > https://copr.fedorainfracloud.org/coprs/eclipseo/fedora-review/ > fedora-review 0.7.0 has been released and updates have been proposed for Fedora: Fedora 30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c663c80f8c Fedora 29: https://bodhi.fedoraproject.org/updates/FEDORA-2019-aa89309322 Fedora 28: https://bodhi.fedoraproject.org/updates/FEDORA-2019-66722dfef0 Hopefully now it'll be easier to respond and release fixes going forward... -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: state of fedora-review?
On lundi 4 mars 2019 00:16:02 CET Neal Gompa wrote: > On Sun, Mar 3, 2019 at 6:14 PM Felix Schwarz > wrote: > > > > > > Hi, > > > > > > > > I am wondering about the state of the "fedora-review" package. It seems to > > be a pretty important package to ensure new stuff adhers to the latest > > Fedora packaging policy. > > > > > > > > When I ran "fedora-review" I noticed that it was clearly not updated for > > some time: There where outdated points about bundled libraries (nowadays > > without special FPC exception), a warning about an unnecessary "gcc" > > build requirement and many outdated links. > > > > > > > > Well, it turns out fedora-review fails to build from source since July > > 2018 [3] (last successful koji build was in March 2018). I think at > > least some things are fixed upstream [4] but the RPM package was never > > updated.> > > > > > > > > Is fedora-review still the preferred tool to do package reviews? > > > > > > > > > > Background: > > In the last weeks I spent a bit of time checking the review requests for > > hcc [1] and hip [2] which form an important part of AMD's "rocm" stack. > > These packages are "special snowflakes" in a sense that they are > > compilers/compiler wrappers with all the shenanigans this involves > > (bundled llvm, explicit lib dependencies, even dependencies on static > > libraries). > > > > > > > > Approving these libraries would require ignoring quite a few rpmlint > > errors/warnings and I don't feel confident in doing so if the > > fedora-review tool is obviously outdated. > > (Btw: I'd highly appreciate if someone could look at the hcc/hip review > > requests. These packages would enable "open source machine learning" in > > Fedora and IMHO that area fits Fedora's mission pretty well.) > > > > > > > It is still preferred. I was hoping that the in-progress Python 3 > porting PR[1] would land first, but I guess I'll have to push a Git > snapshot release in... > > I don't want to make a new release without Python 3 support. > > [1]: https://pagure.io/FedoraReview/pull-request/312 > I've got a COPR based on the devel branch: https://copr.fedorainfracloud.org/coprs/eclipseo/fedora-review/ ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: state of fedora-review?
On Sun, Mar 3, 2019 at 6:14 PM Felix Schwarz wrote: > > Hi, > > I am wondering about the state of the "fedora-review" package. It seems to be > a pretty important package to ensure new stuff adhers to the latest Fedora > packaging policy. > > When I ran "fedora-review" I noticed that it was clearly not updated for some > time: There where outdated points about bundled libraries (nowadays without > special FPC exception), a warning about an unnecessary "gcc" build requirement > and many outdated links. > > Well, it turns out fedora-review fails to build from source since July 2018 > [3] (last successful koji build was in March 2018). I think at least some > things are fixed upstream [4] but the RPM package was never updated. > > > Is fedora-review still the preferred tool to do package reviews? > > > Background: > In the last weeks I spent a bit of time checking the review requests for hcc > [1] and hip [2] which form an important part of AMD's "rocm" stack. These > packages are "special snowflakes" in a sense that they are compilers/compiler > wrappers with all the shenanigans this involves (bundled llvm, explicit lib > dependencies, even dependencies on static libraries). > > Approving these libraries would require ignoring quite a few rpmlint > errors/warnings and I don't feel confident in doing so if the fedora-review > tool is obviously outdated. > (Btw: I'd highly appreciate if someone could look at the hcc/hip review > requests. These packages would enable "open source machine learning" in Fedora > and IMHO that area fits Fedora's mission pretty well.) > It is still preferred. I was hoping that the in-progress Python 3 porting PR[1] would land first, but I guess I'll have to push a Git snapshot release in... I don't want to make a new release without Python 3 support. [1]: https://pagure.io/FedoraReview/pull-request/312 -- 真実はいつも一つ！/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
state of fedora-review?
Hi, I am wondering about the state of the "fedora-review" package. It seems to be a pretty important package to ensure new stuff adhers to the latest Fedora packaging policy. When I ran "fedora-review" I noticed that it was clearly not updated for some time: There where outdated points about bundled libraries (nowadays without special FPC exception), a warning about an unnecessary "gcc" build requirement and many outdated links. Well, it turns out fedora-review fails to build from source since July 2018 [3] (last successful koji build was in March 2018). I think at least some things are fixed upstream [4] but the RPM package was never updated. Is fedora-review still the preferred tool to do package reviews? Background: In the last weeks I spent a bit of time checking the review requests for hcc [1] and hip [2] which form an important part of AMD's "rocm" stack. These packages are "special snowflakes" in a sense that they are compilers/compiler wrappers with all the shenanigans this involves (bundled llvm, explicit lib dependencies, even dependencies on static libraries). Approving these libraries would require ignoring quite a few rpmlint errors/warnings and I don't feel confident in doing so if the fedora-review tool is obviously outdated. (Btw: I'd highly appreciate if someone could look at the hcc/hip review requests. These packages would enable "open source machine learning" in Fedora and IMHO that area fits Fedora's mission pretty well.) Thank you very much, Felix [1] https://bugzilla.redhat.com/show_bug.cgi?id=1545479 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1668010 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1603956 [4] https://pagure.io/FedoraReview ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
