date:20130219

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

2013-02-19 Thread Saúl Ibarra Corretgé

 
 When comes to SF versus GITHUB - the main problem from my perspective is that 
 SF overs a unified (one account) for tracker, forums, downloads, code 
 repo.If we move code repo to GITHUB, we will force the developer to use 2 
 accounts (on SF for tracker, forum , etc, and one on GITHUB for GIT only)..
 

I guess my original suggestion was not clear then :-) I was suggesting to 
completely move from SF. Just add a pointer to GH.

 For manageability reasons I would prefer to have a place hosting everything.
 

Agreed.

 What options I see:
 
 1) move everything (tracker + GIT and the rest ?) on GITHUB
 

What would the rest be?

 2) keep SF as primary GIT repo and GITHUB can be a secondary. Developers can 
 use the SF accounts for everything and use GITHUB as an interface to the 
 community (changes, pull requests, etc)..
 

The problem I see here is that there would be a split so it could potentially 
be confusing. When a user sends a pull request, and issue is automatically 
created, so there would be two places for issues :-S

Having GitHub not as the primary repo is not so nice because pull requests 
can't be disabled, so people could think that that is the place to contribute 
code :-S

So, I think the two choices become:

- Move everything to GH and have a read-only mirror somewhere (SF, BitBucket, 
self hosted, ...)
- Stick to SF

Personally I'd go for GitHub. In case there is anything I can do to help, 
whatever the choice is, don't hesitate to ask :-)


Regards,

--
Saúl Ibarra Corretgé
AG Projects




___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

2013-02-19 Thread Bogdan-Andrei Iancu



On 02/19/2013 02:36 PM, Saúl Ibarra Corretgé wrote:

When comes to SF versus GITHUB - the main problem from my perspective is that 
SF overs a unified (one account) for tracker, forums, downloads, code 
repo.If we move code repo to GITHUB, we will force the developer to use 2 
accounts (on SF for tracker, forum , etc, and one on GITHUB for GIT only)..


I guess my original suggestion was not clear then :-) I was suggesting to 
completely move from SF. Just add a pointer to GH.


For manageability reasons I would prefer to have a place hosting everything.


Agreed.


What options I see:

1) move everything (tracker + GIT and the rest ?) on GITHUB


What would the rest be?


2) keep SF as primary GIT repo and GITHUB can be a secondary. Developers can 
use the SF accounts for everything and use GITHUB as an interface to the 
community (changes, pull requests, etc)..


The problem I see here is that there would be a split so it could potentially 
be confusing. When a user sends a pull request, and issue is automatically 
created, so there would be two places for issues :-S

Having GitHub not as the primary repo is not so nice because pull requests 
can't be disabled, so people could think that that is the place to contribute 
code :-S

So, I think the two choices become:

- Move everything to GH and have a read-only mirror somewhere (SF, BitBucket, 
self hosted, ...)
- Stick to SF

Personally I'd go for GitHub. In case there is anything I can do to help, 
whatever the choice is, don't hesitate to ask :-)


Currently, what we use from SF :
 - code repository
 - file download system
 - trackers (bugs, patches, features)
 - news system
 - donation system
 - forums

could all these be replaced kept while moving to GH ? I mean is GH a 
platform for complete hosting of projects ?


Regards,
Bogdan

___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] SF.net SVN: opensips:[9804] trunk/modules/ratelimit/ratelimit_helper.c

2013-02-19 Thread Razvan Crainea

Revision: 9804
  http://opensips.svn.sourceforge.net/opensips/?rev=9804view=rev
Author:   razvancrainea
Date: 2013-02-19 16:05:25 + (Tue, 19 Feb 2013)
Log Message:
---
Fixed ratelimit bug where the counter reaches -1
Reported by Matt Williams
Closes bug #3603732

Modified Paths:
--
trunk/modules/ratelimit/ratelimit_helper.c

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] SF.net SVN: opensips:[9806] branches/1.8/modules/ratelimit/ratelimit_helper .c

2013-02-19 Thread Razvan Crainea

Revision: 9806
  http://opensips.svn.sourceforge.net/opensips/?rev=9806view=rev
Author:   razvancrainea
Date: 2013-02-19 16:05:51 + (Tue, 19 Feb 2013)
Log Message:
---
Backported from trunk (rev #9804):
Fixed ratelimit bug where the counter reaches -1
Reported by Matt Williams
Closes bug #3603732

Revision Links:
--
http://opensips.svn.sourceforge.net/opensips/?rev=9804view=rev

Modified Paths:
--
branches/1.8/modules/ratelimit/ratelimit_helper.c

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] SF.net SVN: opensips:[9805] branches/1.9/modules/ratelimit/ratelimit_helper .c

2013-02-19 Thread Razvan Crainea

Revision: 9805
  http://opensips.svn.sourceforge.net/opensips/?rev=9805view=rev
Author:   razvancrainea
Date: 2013-02-19 16:05:45 + (Tue, 19 Feb 2013)
Log Message:
---
Backported from trunk (rev #9804):
Fixed ratelimit bug where the counter reaches -1
Reported by Matt Williams
Closes bug #3603732

Revision Links:
--
http://opensips.svn.sourceforge.net/opensips/?rev=9804view=rev

Modified Paths:
--
branches/1.9/modules/ratelimit/ratelimit_helper.c

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [ opensips-Bugs-3603732 ] rl_dec_count increases counter

2013-02-19 Thread SourceForge . net

Bugs item #3603732, was opened at 2013-02-07 10:15
Message generated for change (Comment added) made by razvancrainea
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3603732group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matt Williams (hmmhesays)
Assigned to: Razvan Crainea (razvancrainea)
Summary: rl_dec_count increases counter

Initial Comment:
Calling rl_dec_count_increases the counter. Test calls rl_check 3 times to 
increment the counter. 

 #We're only checking our gateway rate limits here;
if(!rl_check($avp(778)_$avp(271), $(avp(780){s.int}), TAILDROP)) {
rl_check($avp(778)_$avp(271), $(avp(780){s.int}), 
TAILDROP);
rl_check($avp(778)_$avp(271), $(avp(780){s.int}), 
TAILDROP);
rl_dec_count($avp(778)_$avp(271));
rl_dec_count($avp(778)_$avp(271));
rl_dec_count($avp(778)_$avp(271));
#make sure counter doesn't go negative;
rl_dec_count($avp(778)_$avp(271));
route(route_failover);
exit;
}


Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test doens't exist, 
but was created 0x2b4307eb2428
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test counter:1 load:0 
limit:0 should be blocked (0x2b4307eb2428)
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test found: 
0x2b4307eb2428 - last used 1360260142
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test counter:2 load:0 
limit:0 should be blocked (0x2b4307eb2428)
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test found: 
0x2b4307eb2428 - last used 1360260142
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test counter:3 load:0 
limit:0 should be blocked (0x2b4307eb2428)
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 4
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 5
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 6
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 7


attached patch fixes my issues. Needs review to see if it breaks anything else. 

--

Comment By: Razvan Crainea (razvancrainea)
Date: 2013-02-19 08:12

Message:
Hi, Matt!

I've committed the fix on all branches. Thanks for reporting and for the
tests. I will close this ticket.

Best regards,
Răzvan

--

Comment By: Matt Williams (hmmhesays)
Date: 2013-02-18 13:53

Message:
Looks like this patch works well. Thank you!

--

Comment By: Matt Williams (hmmhesays)
Date: 2013-02-15 12:27

Message:
My apologies I haven't had a chance to test. I will do so later today. 

--

Comment By: Razvan Crainea (razvancrainea)
Date: 2013-02-15 09:05

Message:
Hi, Matt!

Any updates? Please let me know if everything is ok before I commit the
fix.

Best regards,
Răzvan

--

Comment By: Razvan Crainea (razvancrainea)
Date: 2013-02-09 23:18

Message:
Hi, Matt!

I have attached a new patch. Can you please give me a try and let me know
how it works?

Best regards,
Răzvan

--

Comment By: Matt Williams (hmmhesays)
Date: 2013-02-08 09:46

Message:
Looks like this allows it to go negative for one count. 

Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test doens't
exist, but was created 0x2b0d5fa7eee8
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test counter:1
load:0 limit:0 should be blocked (0x2b0d5fa7eee8)
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test found:
0x2b0d5fa7eee8 - last used 1360345517
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test counter:2
load:0 limit:0 should be blocked (0x2b0d5fa7eee8)
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test found:
0x2b0d5fa7eee8 - last used 1360345517
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test counter:3
load:0 limit:0 should be blocked (0x2b0d5fa7eee8)
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 2
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 1
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 0
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is -1
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 0

[OpenSIPS-Devel] [ opensips-Bugs-3603732 ] rl_dec_count increases counter

2013-02-19 Thread SourceForge . net

Bugs item #3603732, was opened at 2013-02-07 10:15
Message generated for change (Settings changed) made by razvancrainea
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3603732group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Matt Williams (hmmhesays)
Assigned to: Razvan Crainea (razvancrainea)
Summary: rl_dec_count increases counter

Initial Comment:
Calling rl_dec_count_increases the counter. Test calls rl_check 3 times to 
increment the counter. 

 #We're only checking our gateway rate limits here;
if(!rl_check($avp(778)_$avp(271), $(avp(780){s.int}), TAILDROP)) {
rl_check($avp(778)_$avp(271), $(avp(780){s.int}), 
TAILDROP);
rl_check($avp(778)_$avp(271), $(avp(780){s.int}), 
TAILDROP);
rl_dec_count($avp(778)_$avp(271));
rl_dec_count($avp(778)_$avp(271));
rl_dec_count($avp(778)_$avp(271));
#make sure counter doesn't go negative;
rl_dec_count($avp(778)_$avp(271));
route(route_failover);
exit;
}


Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test doens't exist, 
but was created 0x2b4307eb2428
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test counter:1 load:0 
limit:0 should be blocked (0x2b4307eb2428)
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test found: 
0x2b4307eb2428 - last used 1360260142
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test counter:2 load:0 
limit:0 should be blocked (0x2b4307eb2428)
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test found: 
0x2b4307eb2428 - last used 1360260142
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_check_3: Pipe test counter:3 load:0 
limit:0 should be blocked (0x2b4307eb2428)
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 4
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 5
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 6
Feb  7 13:02:22 [15173] DBG:ratelimit:w_rl_set_count: new counter for key test 
is 7


attached patch fixes my issues. Needs review to see if it breaks anything else. 

--

Comment By: Razvan Crainea (razvancrainea)
Date: 2013-02-19 08:12

Message:
Hi, Matt!

I've committed the fix on all branches. Thanks for reporting and for the
tests. I will close this ticket.

Best regards,
Răzvan

--

Comment By: Matt Williams (hmmhesays)
Date: 2013-02-18 13:53

Message:
Looks like this patch works well. Thank you!

--

Comment By: Matt Williams (hmmhesays)
Date: 2013-02-15 12:27

Message:
My apologies I haven't had a chance to test. I will do so later today. 

--

Comment By: Razvan Crainea (razvancrainea)
Date: 2013-02-15 09:05

Message:
Hi, Matt!

Any updates? Please let me know if everything is ok before I commit the
fix.

Best regards,
Răzvan

--

Comment By: Razvan Crainea (razvancrainea)
Date: 2013-02-09 23:18

Message:
Hi, Matt!

I have attached a new patch. Can you please give me a try and let me know
how it works?

Best regards,
Răzvan

--

Comment By: Matt Williams (hmmhesays)
Date: 2013-02-08 09:46

Message:
Looks like this allows it to go negative for one count. 

Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test doens't
exist, but was created 0x2b0d5fa7eee8
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test counter:1
load:0 limit:0 should be blocked (0x2b0d5fa7eee8)
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test found:
0x2b0d5fa7eee8 - last used 1360345517
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test counter:2
load:0 limit:0 should be blocked (0x2b0d5fa7eee8)
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test found:
0x2b0d5fa7eee8 - last used 1360345517
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_check_3: Pipe test counter:3
load:0 limit:0 should be blocked (0x2b0d5fa7eee8)
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 2
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 1
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 0
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is -1
Feb  8 12:45:17 [12405] DBG:ratelimit:w_rl_set_count: new counter for key
test is 0

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

Re: [OpenSIPS-Devel] [OpenSIPS-Users] [RFC] migration to GIT

[OpenSIPS-Devel] SF.net SVN: opensips:[9804] trunk/modules/ratelimit/ratelimit_helper.c

[OpenSIPS-Devel] SF.net SVN: opensips:[9806] branches/1.8/modules/ratelimit/ratelimit_helper .c

[OpenSIPS-Devel] SF.net SVN: opensips:[9805] branches/1.9/modules/ratelimit/ratelimit_helper .c

[OpenSIPS-Devel] [ opensips-Bugs-3603732 ] rl_dec_count increases counter

[OpenSIPS-Devel] [ opensips-Bugs-3603732 ] rl_dec_count increases counter

7 matches

Site Navigation

Mail list logo

Footer information