[ovirt-devel] Re: [ovirt-users] Using ovirt imageio

2020-07-07 Thread Nir Soffer 
On Tue, Jul 7, 2020 at 5:05 PM Łukasz Kołaciński 
wrote:

> Dear ovirt community,
>

Hi Łukasz,

Adding de...@ovit.org since this topic is more appropriate for the devel
list.


> I am trying to use ovirt imageio api to receive changed blocks (dirty
> bitmap) on ovirt 4.4. Could anyone tell me how to get them step by step? On
> the documentation I saw endpoint "GET /images/ticket-uuid/map". I don't
> know what ticket-uuid is and how to generate it. I also need to know how to
> use this api because I can't reach it via /ovirt-engine/api/
>
> I am asking about this endpoint:
>
> https://www.ovirt.org/documentation/incremental-backup-guide/incremental-backup-guide.html#imageio-backup-api
>

This guide is outdated and should not be used now.

The most up to date information is here:
https://www.ovirt.org/develop/release-management/features/storage/incremental-backup.html

However the extents API is also outdated in the feature page. We are
working on updating it.

So here is example:

First you must start backup with from_checkpoint_id argument:

backup = backups_service.add(
types.Backup(
disks=disks,
from_checkpoint_id="checkpoint-id",
)
)

>
"checkpoint-id" is the checkpoint created in the last backup.

This starts a backup in in incremental mode. Dirty extents are available
only
in this mode.

Then you start a transfer for download, using the backup id:

transfer = imagetransfer.create_transfer(
connection,
disk,
types.ImageTransferDirection.DOWNLOAD,
backup=types.Backup(id=backup_uuid))

The transfer.transfer_url is the URL to download from, for example:

https://host:54322/images/53787351-3f72-44a1-8a26-1323524fac4a

Connect to host:54322 and send this request:

GET /images/53787351-3f72-44a1-8a26-1323524fac4a/extents?context=dirty

And parse the return json list, containing objects like:

[
{"start": 0, "length": 65536, "dirty": true},
{"start": 65536, "length": 1048576, "dirty": false},
...
]

For example code of using the imageio API, see imageio http backend:
https://github.com/oVirt/ovirt-imageio/blob/d5aa0e1fe659f1bf1247516f83c71e072803fa05/daemon/ovirt_imageio/_internal/backends/http.py#L288
https://github.com/oVirt/ovirt-imageio/blob/d5aa0e1fe659f1bf1247516f83c71e072803fa05/daemon/ovirt_imageio/_internal/backends/http.py#L498

We are adding a ImageioClient API that makes it easier to consume without
writing any HTTP code:
https://gerrit.ovirt.org/c/110068

With this you can use:

with ImageioClient(transfer.transfer_url, cafile=args.cafile) as client:
for extent in client.extent("dirty"):
if extent.dirty:
print("##dirty start={} length={}".format(extent.start,
extent.length))
client.write_to(sys.stdout.buffer, extent.start,
extent.length)
print()

This will stream the dirty extents to stdout. Not very useful as is, but
illustrates how
you can consume the data.

Here is an example writing extents to a sparse stream format:
https://gerrit.ovirt.org/c/110069

For complete backup example code see:
https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/backup_vm.py

Note the new imagetransfer helper module:
https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/helpers/imagetransfer.py

Nir

e-mail: l.kolacin...@storware.eu
> 
>
>
>
>
> *[image: STORWARE]* 
>
>
>
> *ul. Leszno 8/44 01-192 Warszawa www.storware.eu
> *
>
> *[image: facebook]* 
>
> *[image: twitter]* 
>
> *[image: linkedin]* 
>
> *[image: Storware_Stopka_09]*
> 
>
>
>
> *Storware Spółka z o.o. nr wpisu do ewidencji KRS dla M.St. Warszawa
> 000510131* *, NIP 5213672602.** Wiadomość ta jest przeznaczona jedynie
> dla osoby lub podmiotu, który jest jej adresatem i może zawierać poufne
> i/lub uprzywilejowane informacje. Zakazane jest jakiekolwiek przeglądanie,
> przesyłanie, rozpowszechnianie lub inne wykorzystanie tych informacji lub
> podjęcie jakichkolwiek działań odnośnie tych informacji przez osoby lub
> podmioty inne niż zamierzony adresat. Jeżeli Państwo otrzymali przez
> pomyłkę tę informację prosimy o poinformowanie o tym nadawcy i usunięcie
> tej wiadomości z wszelkich komputerów. **This message is intended only
> for the person or entity to which it is addressed and may contain
> confidential and/or privileged material. Any review, retransmission,
> dissemination or other use of, or taking of any action in reliance upon,
> this information by persons or entities other than the intended recipient
> is prohibited. If you have received this message in error, please contact
> the sender and remove the material from all of your computer systems.*
>
> ___
> Users mailing list --

[ovirt-devel] Re: execution failed: javax.net.ssl.SSLPeerUnverifiedException (was: vdsm.storage.exception.UnknownTask: Task id unknown (was: [oVirt Jenkins] ovirt-system-tests_he-basic-suite-master -

2020-07-07 Thread Martin Perina 
Hi,

I'm not aware of change regarding certificates recently. So is this error
reproducible outside Jenkins? Or even better is it reproducible on some
easier flow other than HE installation so we can debug what certificate is
loaded in VDSM?

Thanks,
Martin

On Tue, Jul 7, 2020 at 2:07 PM Yedidyah Bar David  wrote:

> On Tue, Jul 7, 2020 at 12:50 PM Yedidyah Bar David 
> wrote:
> >
> > On Wed, Jun 24, 2020 at 2:14 PM Evgeny Slutsky 
> wrote:
> > >
> > > Hi,
> > > changing the hostname to include also the domain name fixed the  cert
> deployment issue:
> > > https://gerrit.ovirt.org/#/c/109842/
> > >
> > > not sure how it affects the engine certificate content.
> > > from my offline discussion with @Martin Perina  this was that change
> that could cause it:
> > > https://gerrit.ovirt.org/#/c/109636/
> > >
> > > any thoughts?
> >
> > Above two patches are merged, but we still fail the same way:
> >
> >
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1664/
> >
> >
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1664/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-he_deploy/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/engine-logs-2020-07-07T03%3A15%3A01Z/ovirt-engine/engine.log
> >
> > 2020-07-06 23:04:25,555-04 ERROR
> > [org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand]
> > (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-38)
> > [fb28ce9] Command 'UploadStreamVDSCommand(HostName =
> > lago-he-basic-suite-master-host-0.lago.local,
> >
> UploadStreamVDSCommandParameters:{hostId='e096650f-a7d6-4383-b1bb-f2e61327aac0'})'
> > execution failed: javax.net.ssl.SSLPeerUnverifiedException:
> > Certificate for  doesn't
> > match any of the subject alternative names:
> > [lago-he-basic-suite-master-host-0.lago.local]
> >
> > Any idea?
>
> And I now see this is indeed what's failing hosted-engine deploy at:
>
> 2020-07-07 05:51:58,573-0400 INFO ansible task start {'status': 'OK',
> 'ansible_type': 'task', 'ansible_playbook':
> '/usr/share/ovirt-hosted-engine-setup/ansible/trigger_role.yml',
> 'ansible_task': 'ovirt.hosted_engine_setup : Check OVF_STORE volume
> status'}
>
> (See other thread: [oVirt Jenkins]
> ovirt-system-tests_he-basic-suite-master - Build # 1655 - Still
> Failing! )
>
> On a successful run, engine.log has:
>
> 2020-07-02 18:01:55,527+03 INFO
>
> [org.ovirt.engine.core.bll.storage.ovfstore.ProcessOvfUpdateForStorageDomainCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
>  [2b0721d8] Running command: ProcessOvfUpdateForStorageDomainCommand
> internal: true. Entities affected :  ID:
> e102d7b5-1a37-490f-a3e7-20e56c37791f Type: StorageAction group
> MANIPULATE_STORAG
> E_DOMAIN with role type ADMIN
> 2020-07-02 18:01:55,607+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] START, SetVolumeDescriptionVDSCommand(
>
> SetVolumeDescriptionVDSCommandParameters:{storagePoolId='b9dccefe-bc61-11ea-8ebe-001a4a231728',
> ignoreFailoverLimit='false', storageDomainId='e102d7b
> 5-1a37-490f-a3e7-20e56c37791f',
> imageGroupId='db934a98-4111-4faf-8cb9-6b36928cd61c',
> imageId='f898c40e-1f88-48db-b59b-f2c73162ddb7'}), log id: e203e51
> 2020-07-02 18:01:55,609+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] -- executeIrsBrokerCommand: calling 'setVolumeDescription', parameters:
> 2020-07-02 18:01:55,609+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] ++ spUUID=b9dccefe-bc61-11ea-8ebe-001a4a231728
> 2020-07-02 18:01:55,609+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] ++ sdUUID=e102d7b5-1a37-490f-a3e7-20e56c37791f
> 2020-07-02 18:01:55,609+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] ++ imageGroupGUID=db934a98-4111-4faf-8cb9-6b36928cd61c
> 2020-07-02 18:01:55,610+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] ++ volUUID=f898c40e-1f88-48db-b59b-f2c73162ddb7
> 2020-07-02 18:01:55,610+03 INFO
> [org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
> [2b0721d8
> ] ++ description={"Updated":false,"Last Updated":"Thu Jul 02 17:35:07
> IDT 2020","Storage
>

[ovirt-devel] execution failed: javax.net.ssl.SSLPeerUnverifiedException (was: vdsm.storage.exception.UnknownTask: Task id unknown (was: [oVirt Jenkins] ovirt-system-tests_he-basic-suite-master - Buil

2020-07-07 Thread Yedidyah Bar David 
On Tue, Jul 7, 2020 at 12:50 PM Yedidyah Bar David  wrote:
>
> On Wed, Jun 24, 2020 at 2:14 PM Evgeny Slutsky  wrote:
> >
> > Hi,
> > changing the hostname to include also the domain name fixed the  cert 
> > deployment issue:
> > https://gerrit.ovirt.org/#/c/109842/
> >
> > not sure how it affects the engine certificate content.
> > from my offline discussion with @Martin Perina  this was that change that 
> > could cause it:
> > https://gerrit.ovirt.org/#/c/109636/
> >
> > any thoughts?
>
> Above two patches are merged, but we still fail the same way:
>
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1664/
>
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1664/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-he_deploy/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/engine-logs-2020-07-07T03%3A15%3A01Z/ovirt-engine/engine.log
>
> 2020-07-06 23:04:25,555-04 ERROR
> [org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand]
> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-38)
> [fb28ce9] Command 'UploadStreamVDSCommand(HostName =
> lago-he-basic-suite-master-host-0.lago.local,
> UploadStreamVDSCommandParameters:{hostId='e096650f-a7d6-4383-b1bb-f2e61327aac0'})'
> execution failed: javax.net.ssl.SSLPeerUnverifiedException:
> Certificate for  doesn't
> match any of the subject alternative names:
> [lago-he-basic-suite-master-host-0.lago.local]
>
> Any idea?

And I now see this is indeed what's failing hosted-engine deploy at:

2020-07-07 05:51:58,573-0400 INFO ansible task start {'status': 'OK',
'ansible_type': 'task', 'ansible_playbook':
'/usr/share/ovirt-hosted-engine-setup/ansible/trigger_role.yml',
'ansible_task': 'ovirt.hosted_engine_setup : Check OVF_STORE volume
status'}

(See other thread: [oVirt Jenkins]
ovirt-system-tests_he-basic-suite-master - Build # 1655 - Still
Failing! )

On a successful run, engine.log has:

2020-07-02 18:01:55,527+03 INFO
[org.ovirt.engine.core.bll.storage.ovfstore.ProcessOvfUpdateForStorageDomainCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
 [2b0721d8] Running command: ProcessOvfUpdateForStorageDomainCommand
internal: true. Entities affected :  ID:
e102d7b5-1a37-490f-a3e7-20e56c37791f Type: StorageAction group
MANIPULATE_STORAG
E_DOMAIN with role type ADMIN
2020-07-02 18:01:55,607+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] START, SetVolumeDescriptionVDSCommand(
SetVolumeDescriptionVDSCommandParameters:{storagePoolId='b9dccefe-bc61-11ea-8ebe-001a4a231728',
ignoreFailoverLimit='false', storageDomainId='e102d7b
5-1a37-490f-a3e7-20e56c37791f',
imageGroupId='db934a98-4111-4faf-8cb9-6b36928cd61c',
imageId='f898c40e-1f88-48db-b59b-f2c73162ddb7'}), log id: e203e51
2020-07-02 18:01:55,609+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] -- executeIrsBrokerCommand: calling 'setVolumeDescription', parameters:
2020-07-02 18:01:55,609+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] ++ spUUID=b9dccefe-bc61-11ea-8ebe-001a4a231728
2020-07-02 18:01:55,609+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] ++ sdUUID=e102d7b5-1a37-490f-a3e7-20e56c37791f
2020-07-02 18:01:55,609+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] ++ imageGroupGUID=db934a98-4111-4faf-8cb9-6b36928cd61c
2020-07-02 18:01:55,610+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] ++ volUUID=f898c40e-1f88-48db-b59b-f2c73162ddb7
2020-07-02 18:01:55,610+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] ++ description={"Updated":false,"Last Updated":"Thu Jul 02 17:35:07
IDT 2020","Storage
Domains":[{"uuid":"e102d7b5-1a37-490f-a3e7-20e56c37791f"}],"Disk
Description":"OVF_STORE"}
2020-07-02 18:01:55,717+03 INFO
[org.ovirt.engine.core.vdsbroker.irsbroker.SetVolumeDescriptionVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8
] FINISH, SetVolumeDescriptionVDSCommand, return: , log id: e203e51
2020-07-02 18:01:55,829+03 INFO
[org.ovirt.engine.core.bll.storage.ovfstore.UploadStreamCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-84)
[2b0721d8] Lock Acq
uired to object

[ovirt-devel] ovirt-engine has been tagged (ovirt-engine-4.4.1.6)

2020-07-07 Thread Tal Nisan 

___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/AQ5CVA474DDLRWNSEEKMB6HPXI3CW5U6/

[ovirt-devel] Re: [oVirt Jenkins] ovirt-system-tests_he-basic-suite-master - Build # 1655 - Still Failing!

2020-07-07 Thread Artem Hrechanychenko 
hit into the same issue
https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/10162/console

On Sun, Jun 28, 2020 at 3:01 PM Yedidyah Bar David  wrote:

> On Sun, Jun 28, 2020 at 2:51 PM Nir Soffer  wrote:
> >
> > On Sun, Jun 28, 2020 at 2:35 PM Yedidyah Bar David 
> wrote:
> > >
> > > On Sun, Jun 28, 2020 at 1:37 PM Nir Soffer  wrote:
> > > >
> > > > On Sun, Jun 28, 2020 at 1:23 PM Yedidyah Bar David 
> wrote:
> > > > >
> > > > > On Sun, Jun 28, 2020 at 6:23 AM 
> wrote:
> > > > > >
> > > > > > Project:
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/
> > > > > > Build:
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1655/
> > > > >
> > > > > This fails for some time now. Checked last one ^^, and it failed
> in:
> > > > >
> > > > >
> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1655/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-he_deploy/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-ansible-create_target_vm-20200627230157-7lqrnp.log
> > > > >
> > > > > 2020-06-27 23:05:02,253-0400 INFO ansible task start {'status':
> 'OK',
> > > > > 'ansible_type': 'task', 'ansible_playbook':
> > > > > '/usr/share/ovirt-hosted-engine-setup/ansible/trigger_role.yml',
> > > > > 'ansible_task': 'ovirt.hosted_engine_setup : Check OVF_STORE volume
> > > > > status'}
> > > > > 2020-06-27 23:05:02,253-0400 DEBUG ansible on_any args TASK:
> > > > > ovirt.hosted_engine_setup : Check OVF_STORE volume status kwargs
> > > > > is_conditional:False
> > > > > 2020-06-27 23:05:02,254-0400 DEBUG ansible on_any args
> localhostTASK:
> > > > > ovirt.hosted_engine_setup : Check OVF_STORE volume status kwargs
> > > > > 2020-06-27 23:05:03,816-0400 DEBUG ansible on_any args
> > > > > 
> > > > > kwargs
> > > > > ...
> > > > >
> > > > > 2020-06-27 23:09:39,166-0400 DEBUG var changed: host "localhost"
> var
> > > > > "ovf_store_status" type "" value: "{
> > > > > "changed": true,
> > > > > "failed": true,
> > > > > "msg": "All items completed",
> > > > > "results": [
> > > > > {
> > > > > "ansible_loop_var": "item",
> > > > > "attempts": 12,
> > > > >
> > > > > Meaning, it ran 12 times the command:
> > > > >
> > > > > vdsm-client Volume getInfo
> > > > > storagepoolID=41c9fdea-b8e9-11ea-ae2a-5452c0a8c863
> > > > > storagedomainID=10a69775-8fb6-437d-9e78-2ecfd77c0a45
> > > > > imageID=c2ad2065-1c8b-4ec1-afdd-f7cefc708cf9
> > > > > volumeID=6b835f55-a512-4f83-9d25-f6837d8b5cb1
> > > > >
> > > > > and never got a result with output including "Updated". Any idea?
> > > >
> > > > I don't know what is the meaning of "Updated".
> > >
> > > Sorry, meant Updated:true. This is a snippet from above
> > > ansible-create_target_vm log:
> > >
> > > "cmd": [
> > > "vdsm-client",
> > > "Volume",
> > > "getInfo",
> > > "storagepoolID=41c9fdea-b8e9-11ea-ae2a-5452c0a8c863",
> > > "storagedomainID=10a69775-8fb6-437d-9e78-2ecfd77c0a45",
> > > "imageID=c2ad2065-1c8b-4ec1-afdd-f7cefc708cf9",
> > > "volumeID=6b835f55-a512-4f83-9d25-f6837d8b5cb1"
> > > ],
> > > ...
> > >
> > > "stdout_lines": [
> > > "{",
> > > "\"apparentsize\": \"134217728\",",
> > > "\"capacity\": \"134217728\",",
> > > "\"children\": [],",
> > > "\"ctime\": \"1593313323\",",
> > > "\"description\":
> > > \"{\\\"Updated\\\":false,\\\"Last Updated\\\":null,\\\"Storage
> > >
> Domains\\\":[{\\\"uuid\\\":\\\"10a69775-8fb6-437d-9e78-2ecfd77c0a45\\\"}],\\\"Disk
> > > Description\\\":\\\"OVF_STORE\\\"}\",",
> > > "\"disktype\": \"OVFS\",",
> > > "\"domain\":
> \"10a69775-8fb6-437d-9e78-2ecfd77c0a45\",",
> > > "\"format\": \"RAW\",",
> > > "\"generation\": 0,",
> > > "\"image\":
> \"c2ad2065-1c8b-4ec1-afdd-f7cefc708cf9\",",
> > > "\"lease\": {",
> > > "\"offset\": 0,",
> > > "\"owners\": [],",
> > > "\"path\":
> > >
> \"/rhev/data-center/mnt/lago-he-basic-suite-master-storage:_exports_nfs__he/10a69775-8fb6-437d-9e78-2ecfd77c0a45/images/c2ad2065-1c8b-4ec1-afdd-f7cefc708cf9/6b835f55-a512-4f83-9d25-f6837d8b5cb1.lease\",",
> > > "\"version\": null",
> > > "},",
> > > "\"legality\": \"LEGAL\",",
> > > "\"mtime\": \"0\",",
> > > "\"parent\":
> \"----\",",
> > > "\"pool\": \"\",",
> > > "\"status\": \"OK\",",
> > > "\"truesize\": \"134217728\",",
> > > "

[ovirt-devel] VM export: task stucked

2020-07-07 Thread francesco--- via Devel 
Hi all,

everyday at 01:00 AM we perform a daily backup on many VMs hosted in multiple 
hosts (all with oVirt 4.3) using a custom sciprt written in python3 (using SDK) 
and everything works "almost" fine.

There is one single VM (Windows Server 2016) with a disk of 600 GB (the real 
disk usage is about 150 GB) hosted on a single node that has a strange 
behaviour. 

1) The export start after a few seconds of the execution of the script, we use 
"vm_service.export_to_path_on_host" class for exporting the VM as ova file;
2) After few minutes i see in the engine the command "START, 
DumpXmlsVDSCommand" that is completely istantly both on the host side ad the 
engine side, and it's fine:

2020-07-02 01:05:45,428+0200 INFO  (jsonrpc/7) [api.host] START 
dumpxmls(vmList=[u'10e88cab-ec4f-4491-b51f-94e3d2e81a0a']) 
from=:::$ENGINE_IP,39308 (api:48)
2020-07-02 01:05:45,428+0200 INFO  (jsonrpc/7) [api.host] FINISH dumpxmls 
return={... LONG XML ...}


3) after 3 hours i see the following logs about the export task:


2020-07-02 04:11:39,201+02 INFO  
[org.ovirt.engine.core.vdsbroker.vdsbroker.GetVolumeInfoVDSCommand] 
(EE-ManagedThreadFactory-engineScheduled-Thread-91) 
[895d6936-f45c-4766-afd4-408a4e4e9a41] START, GetVolumeInfoVDSCommand(HostName 
= $OVIRT_HOST, 
GetVolumeInfoVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5',
 storagePoolId='79d774b7-ca5b-49c2-baf8-9275ba3f1a84', 
storageDomainId='6775c41c-7d67-451b-8beb-4fd086eade2e', 
imageGroupId='a084fa36-0f93-45c2-a323-ea9ca2d16677', 
imageId='55b3eac5-05b2-4bae-be50-37cde7050697'}), log id: 3cbf2c7c
2020-07-02 04:11:39,299+02 INFO  
[org.ovirt.engine.core.vdsbroker.vdsbroker.GetQemuImageInfoVDSCommand] 
(EE-ManagedThreadFactory-engineScheduled-Thread-91) 
[895d6936-f45c-4766-afd4-408a4e4e9a41] START, 
GetQemuImageInfoVDSCommand(HostName = $OVIRT_HOST, 
GetVolumeInfoVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5',
 storagePoolId='79d774b7-ca5b-49c2-baf8-9275ba3f1a84', 
storageDomainId='6775c41c-7d67-451b-8beb-4fd086eade2e', 
imageGroupId='a084fa36-0f93-45c2-a323-ea9ca2d16677', 
imageId='55b3eac5-05b2-4bae-be50-37cde7050697'}), log id: 47d5122e
2020-07-02 04:43:21,339+02 INFO  
[org.ovirt.engine.core.vdsbroker.vdsbroker.PrepareImageVDSCommand] 
(EE-ManagedThreadFactory-engineScheduled-Thread-19) [312261bb] START, 
PrepareImageVDSCommand(HostName = $OVIRT_HOST, 
PrepareImageVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5'}),
 log id: 28c880d12020-07-02 04:43:21,650+02 INFO  
[org.ovirt.engine.core.common.utils.ansible.AnsibleExecutor] 
(EE-ManagedThreadFactory-engineScheduled-Thread-19) [312261bb] Executing 
Ansible command: ANSIBLE_STDOUT_CALLBACK=imagemeasureplugin 
/usr/bin/ansible-playbook --ssh-common-args=-F 
/var/lib/ovirt-engine/.ssh/config 
--private-key=/etc/pki/ovirt-engine/keys/engine_id_rsa 
--inventory=/tmp/ansible-inventory1121551177697847734 
--extra-vars=image_path="/rhev/data-center/mnt/_data/6775c41c-7d67-451b-8beb-4fd086eade2e/images/a084fa36-0f93-45c2-a323-ea9ca2d16677/5b76cc6c-1a6b-4e02-8ce4-dc80faf9ed04"
 /usr/share/ovirt-engine/playbooks/ovirt-image-measure.yml [Logfile: 
/var/log/ovirt-engine/ova
 /ovirt-image-measure-ansible-20200702044321-$OVIRT_HOST-312261bb.log]
2020-07-02 05:05:20,428+02 INFO  
[org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand] 
(EE-ManagedThreadFactory-engineScheduled-Thread-8) [64c95c4d] START, 
UploadStreamVDSCommand(HostName = $OVIRT_HOST, 
UploadStreamVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5'}),
 log id: 666809cb
2020-07-02 05:05:22,104+02 INFO  
[org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand] 
(EE-ManagedThreadFactory-engineScheduled-Thread-8) [64c95c4d] START, 
UploadStreamVDSCommand(HostName = $OVIRT_HOST, 
UploadStreamVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5'}),
 log id: 33ff46bf
2020-07-02 05:05:29,602+02 INFO  
[org.ovirt.engine.core.vdsbroker.vdsbroker.HSMClearTaskVDSCommand] 
(EE-ManagedThreadFactory-engine-Thread-287) [64c95c4d] START, 
HSMClearTaskVDSCommand(HostName = $OVIRT_HOST, 
HSMTaskGuidBaseVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5',
 taskId='e40a2740-37f6-455d-bed7-554efef761ff'}), log id: f01ff26
2020-07-02 05:05:29,619+02 INFO  
[org.ovirt.engine.core.vdsbroker.vdsbroker.HSMClearTaskVDSCommand] 
(EE-ManagedThreadFactory-engine-Thread-269) [64c95c4d] START, 
HSMClearTaskVDSCommand(HostName = $OVIRT_HOST, 
HSMTaskGuidBaseVDSCommandParameters:{hostId='e8c07142-fcd8-4f78-9158-ffb2caa06dc5',
 taskId='1c94df38-88c1-4bf8-89a2-8c322513b21b'}), log id: 6150e13b  

4) And then, after several hours, the export fail with the following logs:

engine logs.

2020-07-02 12:43:21,653+02 ERROR [org.ovirt.engine.core.bll.CreateOvaCommand] 
(EE-ManagedThreadFactory-engineScheduled-Thread-19) [312261bb] Failed to 
measure image: null. Please check logs for more details:

[ovirt-devel] Re: Backup: how to download only used extents from imageio backend

2020-07-07 Thread Eyal Shenitzky 
Thanks for the feedback Michael.

Great to hear that things work well also from users!

Please let us know if you encounter some issues or you have some
suggestions for improvements.



On Thu, 2 Jul 2020 at 17:42, Michael Ablassmeier  wrote:

> hi again!
>
> On Thu, Jul 02, 2020 at 03:28:45PM +0300, Nir Soffer wrote:
> > If you want to test this code, you can use git:
> > $ git clone https://gerrit.ovirt.org/ovirt-imageio
> > $ git fetch https://gerrit.ovirt.org/ovirt-imageio
> > refs/changes/69/110069/1 && git checkout FETCH_HEAD
>
> i just adopted my POC for using the new functions and it worked
> flawlessly, backing a virtual machine full/inc and restoring it. Im
> going have more thoughts the coming days, but for now that seems a good
> and usuable interface for us!
>
> Just as a side note if anyone whos trying with full/inc chains: the
> backup stream of the full chain includes the stop frame, so you cant
> just do "upload < full inc", as it will always exit the loop if the
> first stop marker is hit, not attempting to upload the changes from the
> inc file ;)
>
> thanks for all your input!
>
> bye,
> - michael
>
>

-- 
Regards,
Eyal Shenitzky
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QUWN3G33ECCKJWMFN3CWTJ3MNC772IVF/

[ovirt-devel] Re: Backup: how to download only used extents from imageio backend

2020-07-07 Thread Michael Ablassmeier 
hi again!

On Thu, Jul 02, 2020 at 03:28:45PM +0300, Nir Soffer wrote:
> If you want to test this code, you can use git:
> $ git clone https://gerrit.ovirt.org/ovirt-imageio
> $ git fetch https://gerrit.ovirt.org/ovirt-imageio
> refs/changes/69/110069/1 && git checkout FETCH_HEAD

i just adopted my POC for using the new functions and it worked
flawlessly, backing a virtual machine full/inc and restoring it. Im
going have more thoughts the coming days, but for now that seems a good
and usuable interface for us!

Just as a side note if anyone whos trying with full/inc chains: the
backup stream of the full chain includes the stop frame, so you cant
just do "upload < full inc", as it will always exit the loop if the
first stop marker is hit, not attempting to upload the changes from the
inc file ;)

thanks for all your input!

bye,
- michael
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/5FM6QLPNY67KEWMZN37SMUPBW6VAIZX2/

[ovirt-devel] Re: Backup: how to download only used extents from imageio backend

2020-07-07 Thread Nir Soffer 
Michael,

Continuing the discussion, I posted RFC patch adding a public
ImageioClient class:
https://gerrit.ovirt.org/c/110068

This is an early version for discussion, the API may change based on
the feedback
we get from users.

I posted an example showing how the client can used:
https://gerrit.ovirt.org/c/110069

Because the streaming use case seems to be what you want, I used
the stream format mentioned in the previous mail for this example.

You can review the patches here on in https://gerrit.ovirt.org/ (I
think you need to create a user).

If you want to test this code, you can use git:
$ git clone https://gerrit.ovirt.org/ovirt-imageio
$ git fetch https://gerrit.ovirt.org/ovirt-imageio
refs/changes/69/110069/1 && git checkout FETCH_HEAD

Then build and install imageio:
$ make rpm
$ dnf upgrade daemon/dist/*.rpm

Or you can install this build:
https://jenkins.ovirt.org/job/ovirt-imageio_standard-check-patch/3228/artifact/build-artifacts.py3.el8.x86_64/

By adding this repo file:

$ cat /etc/yum.repos.d/imageio-testing.repo
[ovirt-imageio-testing]
name=ovirt-imageio testing repo
baseurl=https://jenkins.ovirt.org/job/ovirt-imageio_standard-check-patch/3228/artifact/build-artifacts.py3.el8.x86_64/
enabled=1
gpgcheck=0

If you want to test latest commits before they are released, you can
enable ovirt-imageio-prevew repo:

$ dnf copr enable nsoffer/ovirt-imageio-preview

Looking forward to your feedback.

Nir

On Wed, Jul 1, 2020 at 8:43 PM Nir Soffer  wrote:
>
> On Tue, Jun 30, 2020 at 10:22 PM Michael Ablassmeier  wrote:
> >
> > hi,
> >
> > On Tue, Jun 30, 2020 at 04:49:01PM +0300, Nir Soffer wrote:
> > > On Tue, Jun 30, 2020 at 10:32 AM Michael Ablassmeier  
> > > wrote:
> > > >  
> > > > https://tranfer_node:54322/images/d471c659-889f-4e7f-b55a-a475649c48a6/extents
> > > >
> > > > As i failed to find them, are there any existing functions/api calls
> > > > that could be used to download only the used extents to a file/fifo
> > > > pipe?
> > >
> > > To use _internal.io.copy to copy the image to tape, we need to solve
> > > several issues:
> > >
> > > 1. how do you write the extents to tape so that you can extract them 
> > > later?
> > > 2. provide a backend that knows how to stream data to tape in the right 
> > > format
> > > 3. fix client.download() to consider the number of writers allowed by
> > > the backend,
> > >since streaming to tape using multiple writers will not be possible.
> >
> > so, speaking as someone who works for a backup vendor, issue  1 and 2 are
> > already solved by our software, the backend is there, we just need an
> > way to extract the data from the api without storing it into a file
> > first. Something like:
> >
> >  backup_vm.py full  pipe
> >
> > is already sufficient, as our backup client software would simply read
> > the data from the pipe, sending it to our backend which does all the
> > stuff regarding tape communication and format.
>
> Great, but piping the data is not so simple, see below.
>
> > The old implementation used the snapshot/attach feature, where our
> > backup client is reading directly from the attached storage device,
> > sending the data to the backend, which cares about multiplexing to tape,
> > possible dedpulication, etc..
>
> In this case you read a complete disk, including the unallocated areas which
> read as zeroes. This is not efficient, creating lots of I/O and
> network bandwidth
> on the way to the backup software, where you do deduplication etc.
>
> > Tape is not the only use case here, most of the times our customers want
> > to write data to storage devices which do not expose an regular file
> > system (such as dedup services, StoreOnce, Virtual Tape solutions etc).
> >
> > > To restore this backup, you need to:
> > > 1. find the tar in the tape (I have no idea how you would do this)
> > > 2. extract backup info from the tar
> > > 3. extract extents from the tar
> >
> > 1-3 are not an issue here and handled by our backend
> >
> > > 4. start an upload transfer
> > > 5. for each data extent:
> > > read data from the tar member, and send to imageio using the right
> > > offset and size
> >
> > that is some good information, so it is possible to create an empty disk
> > with the same size using the API and then directly send the extents with
> > their propper offset. How does it look with an incremental backup on top
> > of an just restored full backup. Does the imageio backend automatically
> > rebase and commit the data from the incremental backup during upload?
>
> No, during upload you get the similar interface - you can write to any offset
> or zero a byte range.
>
> imageio API is mostly like a remote file descriptor. Instead of integer  
> (fd=42)
> you get a random URL
> (https://host:port/images/efb761c6-2b06-4b46-bf50-2c40677ea419).
> Using URL you can read, write or zero a byte range.
>
> During restore, you need to write back the data that should be on the disk
> at a specific point in time.
>
> Ideally your

[ovirt-devel] Re: vdsm.storage.exception.UnknownTask: Task id unknown (was: [oVirt Jenkins] ovirt-system-tests_he-basic-suite-master - Build # 1641 - Still Failing!)

2020-07-07 Thread Yedidyah Bar David 
On Wed, Jun 24, 2020 at 2:14 PM Evgeny Slutsky  wrote:
>
> Hi,
> changing the hostname to include also the domain name fixed the  cert 
> deployment issue:
> https://gerrit.ovirt.org/#/c/109842/
>
> not sure how it affects the engine certificate content.
> from my offline discussion with @Martin Perina  this was that change that 
> could cause it:
> https://gerrit.ovirt.org/#/c/109636/
>
> any thoughts?

Above two patches are merged, but we still fail the same way:

https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1664/

https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1664/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-he_deploy/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/engine-logs-2020-07-07T03%3A15%3A01Z/ovirt-engine/engine.log

2020-07-06 23:04:25,555-04 ERROR
[org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand]
(EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-38)
[fb28ce9] Command 'UploadStreamVDSCommand(HostName =
lago-he-basic-suite-master-host-0.lago.local,
UploadStreamVDSCommandParameters:{hostId='e096650f-a7d6-4383-b1bb-f2e61327aac0'})'
execution failed: javax.net.ssl.SSLPeerUnverifiedException:
Certificate for  doesn't
match any of the subject alternative names:
[lago-he-basic-suite-master-host-0.lago.local]

Any idea?

>
>
>
>
> On Wed, Jun 17, 2020 at 9:32 AM Yedidyah Bar David  wrote:
>>
>> On Wed, Jun 17, 2020 at 6:28 AM  wrote:
>> >
>> > Project: 
>> > https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/
>> > Build: 
>> > https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1641/
>>
>> This one failed while trying to create the disk image for the hosted-egnine 
>> VM:
>>
>> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1641/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-he_deploy/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-ansible-create_target_vm-20200616230220-yfumoc.log
>> :
>>
>> 2020-06-16 23:03:20,527-0400 INFO ansible task start {'status': 'OK',
>> 'ansible_type': 'task', 'ansible_playbook':
>> '/usr/share/ovirt-hosted-engine-setup/ansible/trigger_role.yml',
>> 'ansible_task': 'ovirt.hosted_engine_setup : Add HE disks'}
>> ...
>> 2020-06-16 23:14:12,702-0400 DEBUG var changed: host "localhost" var
>> "add_disks" type "" value: "{
>> ...
>> "msg": "Timeout exceed while waiting on result state of the 
>> entity."
>>
>> https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/1641/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-he_deploy/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/engine-logs-2020-06-17T03%3A14%3A18Z/ovirt-engine/engine.log
>> :
>>
>> 2020-06-16 23:03:22,612-04 INFO
>> [org.ovirt.engine.core.bll.CommandMultiAsyncTasks] (default task-1)
>> [16c24599-0048-44eb-a410-d39b7ce98712]
>> CommandMultiAsyncTasks::attachTask: Attaching task
>> '6b2a7648-748c-430b-94b6-5e3f719df2ac' to command
>> 'fa81759d-c57a-4237-81e0-beb210faa64d'.
>> 2020-06-16 23:03:22,659-04 INFO
>> [org.ovirt.engine.core.bll.tasks.AsyncTaskManager] (default task-1)
>> [16c24599-0048-44eb-a410-d39b7ce98712] Adding task
>> '6b2a7648-748c-430b-94b6-5e3f719df2ac' (Parent Command
>> 'AddImageFromScratch', Parameters Type
>> 'org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters'),
>> polling hasn't started yet..
>> 2020-06-16 23:03:22,699-04 INFO
>> [org.ovirt.engine.core.bll.tasks.SPMAsyncTask] (default task-1)
>> [16c24599-0048-44eb-a410-d39b7ce98712]
>> BaseAsyncTask::startPollingTask: Starting to poll task
>> '6b2a7648-748c-430b-94b6-5e3f719df2ac'.
>> ...
>> 2020-06-16 23:03:25,835-04 INFO
>> [org.ovirt.engine.core.bll.tasks.SPMAsyncTask]
>> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-25)
>> [] SPMAsyncTask::PollTask: Polling task
>> '6b2a7648-748c-430b-94b6-5e3f719df2ac' (Parent Command
>> 'AddImageFromScratch', Parameters Type
>> 'org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters')
>> returned status 'finished', result 'success'.
>> 2020-06-16 23:03:25,863-04 INFO
>> [org.ovirt.engine.core.bll.tasks.SPMAsyncTask]
>> (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-25)
>> [] BaseAsyncTask::onTaskEndSuccess: Task
>> '6b2a7648-748c-430b-94b6-5e3f719df2ac' (Parent Command
>> 'AddImageFromScratch', Parameters Type
>> 'org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters') ended
>> successfully.
>>
>> But then:
>>
>> 2020-06-16 23:03:25,897-04 INFO
>> [org.ovirt.engine.core.bll.tasks.CommandAsyncTask]
>> (EE-ManagedThreadFactory-engine-Thread-29)
>> [16c24599-0048-44eb-a410-d39b7ce98712]
>> CommandAsyncTask::HandleEndActionResult [within thread]: endAction for
>> action type 'AddImageFromScratch' succeeded, clearing tasks.
>> 2020-06-16 23:03:25,897-04 INFO
>> [org.ovirt.engine.core.bll.tasks.SPMAsyncTask]
>>

[ovirt-devel] Re: Backup: how to download only used extents from imageio backend

2020-07-07 Thread Nir Soffer 
On Thu, Jul 2, 2020 at 5:36 PM Michael Ablassmeier  wrote:
>
> hi again!
>
> On Thu, Jul 02, 2020 at 03:28:45PM +0300, Nir Soffer wrote:
> > If you want to test this code, you can use git:
> > $ git clone https://gerrit.ovirt.org/ovirt-imageio
> > $ git fetch https://gerrit.ovirt.org/ovirt-imageio
> > refs/changes/69/110069/1 && git checkout FETCH_HEAD
>
> i just adopted my POC for using the new functions and it worked
> flawlessly, backing a virtual machine full/inc and restoring it. Im
> going have more thoughts the coming days, but for now that seems a good
> and usuable interface for us!
>
> Just as a side note if anyone whos trying with full/inc chains: the
> backup stream of the full chain includes the stop frame, so you cant
> just do "upload < full inc", as it will always exit the loop if the
> first stop marker is hit, not attempting to upload the changes from the
> inc file ;)

Well this is just an example how to use the API. Real code will probably
have some "start" frame with metadata, and will continue after the stop frame
if needed.

But it will probably be more useful if the backup software can
generate a restore
stream on the fly, instead of playing back the recorded data, so you don't write
the same area multiple times.

> thanks for all your input!
>
> bye,
> - michael
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/TIRCMEERRHTFNHFGKPOWBMLFKTIOU6EJ/

[ovirt-devel] Re: sic transit gloria mundi

2020-07-07 Thread Edward Haas 
Great milestone!

On Sun, Jul 5, 2020 at 9:25 PM Dan Kenigsberg  wrote:

> Seven years ago, in June 2013, Giuseppe Valarelli introduced
> tests/functional/networkTests.py in
> https://gerrit.ovirt.org/#/c/14840/. It held high aspirations: to
> provide a comprehensive functional test for Vdsm's network API, in
> order to ease development of new code and reduce chances of
> reintroducing old bugs.
>
> 390 commits later, Andrej Cernak removed the last lines of code from
> that file in https://gerrit.ovirt.org/#/c/109182/.
>
> In between, many many other developers contributed to the set of
> tests, and later dissipated its content to multiple pytest-driven test
> modules. tests/functional/networkTests.py was never an emblem of great
> software design; it makes me happy to see it gone. But it was very
> useful and its spirit lives on: API tests are now the rule of Vdsm
> development, not an exception.
>
> I'd like to thank all the people who made this possible.
>
> $ git log 1c5f15c9b~ -- tests/functional/networkTests.py|grep
> Author|sort|uniq -c|sort -nr
>  72 Author: Edward Haas 
>  58 Author: Ido Barkan 
>  46 Author: Ondřej Svoboda 
>  40 Author: Petr Horáček 
>  35 Author: Dan Kenigsberg 
>  34 Author: Antoni S. Puimedon 
>  24 Author: Bell Levin 
>  23 Author: Leon Goldberg 
>  18 Author: Giuseppe Vallarelli 
>   8 Author: Assaf Muller 
>   5 Author: Sveta Haas 
>   4 Author: Mark Wu 
>   3 Author: Nir Soffer 
>   2 Author: Yaniv Bronhaim 
>   2 Author: Sagi Shnaidman 
>   2 Author: Petr Sebek 
>   2 Author: Miguel Angel Ajo 
>   2 Author: Andrej Cernek 
>   1 Author: Viliam Serecun 
>   1 Author: Vered Volansky 
>   1 Author: Timothy Asir Jeyasingh 
>   1 Author: shlad 
>   1 Author: pkliczewski 
>   1 Author: Petr Benas 
>   1 Author: Marcin Sobczyk 
>   1 Author: Marcin Mirecki 
>   1 Author: Ilia Meerovich 
>   1 Author: Genadi Chereshnya 
>   1 Author: Dominik Holler 
>
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/XL4M5WR44PKMKXYH32XIL5GEHIUFQARJ/

[ovirt-devel] ovirt-engine has been tagged (ovirt-engine-4.4.1.7)

2020-07-07 Thread Sandro Bonazzola 

___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZZX7J6VBNVZHWJWWSWYLIWXVQOQ56YSJ/

[ovirt-devel] sic transit gloria mundi

2020-07-07 Thread Dan Kenigsberg 
Seven years ago, in June 2013, Giuseppe Valarelli introduced
tests/functional/networkTests.py in
https://gerrit.ovirt.org/#/c/14840/. It held high aspirations: to
provide a comprehensive functional test for Vdsm's network API, in
order to ease development of new code and reduce chances of
reintroducing old bugs.

390 commits later, Andrej Cernak removed the last lines of code from
that file in https://gerrit.ovirt.org/#/c/109182/.

In between, many many other developers contributed to the set of
tests, and later dissipated its content to multiple pytest-driven test
modules. tests/functional/networkTests.py was never an emblem of great
software design; it makes me happy to see it gone. But it was very
useful and its spirit lives on: API tests are now the rule of Vdsm
development, not an exception.

I'd like to thank all the people who made this possible.

$ git log 1c5f15c9b~ -- tests/functional/networkTests.py|grep
Author|sort|uniq -c|sort -nr
 72 Author: Edward Haas 
 58 Author: Ido Barkan 
 46 Author: Ondřej Svoboda 
 40 Author: Petr Horáček 
 35 Author: Dan Kenigsberg 
 34 Author: Antoni S. Puimedon 
 24 Author: Bell Levin 
 23 Author: Leon Goldberg 
 18 Author: Giuseppe Vallarelli 
  8 Author: Assaf Muller 
  5 Author: Sveta Haas 
  4 Author: Mark Wu 
  3 Author: Nir Soffer 
  2 Author: Yaniv Bronhaim 
  2 Author: Sagi Shnaidman 
  2 Author: Petr Sebek 
  2 Author: Miguel Angel Ajo 
  2 Author: Andrej Cernek 
  1 Author: Viliam Serecun 
  1 Author: Vered Volansky 
  1 Author: Timothy Asir Jeyasingh 
  1 Author: shlad 
  1 Author: pkliczewski 
  1 Author: Petr Benas 
  1 Author: Marcin Sobczyk 
  1 Author: Marcin Mirecki 
  1 Author: Ilia Meerovich 
  1 Author: Genadi Chereshnya 
  1 Author: Dominik Holler 
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/WWBTUKYHAB376PXPNERSEFSPLTWV4H2L/

[ovirt-devel] Re: Issue while installing ovirt-imageio-daemon

2020-07-07 Thread Vojtech Juranek 
On čtvrtek 2. července 2020 8:15:59 CEST Sandro Bonazzola wrote:
> Il giorno mer 1 lug 2020 alle ore 19:03 Nir Soffer  ha
> 
> scritto:
> > On Wed, Jul 1, 2020 at 7:46 PM Sandro Bonazzola 
> > 
> > wrote:
> >> Hi, just noticed in appliance build at
> >> https://jenkins.ovirt.org/job/ovirt-appliance_standard-check-patch/286/co
> >> nsoleFull>> 
> >>  15:18:22,373 INFO anaconda:program: Installing :
> >>  ovirt-imageio-daemon-2.0.9-1.el8.x86_64 90/223
> >>  
> >>   >>  consoleFull#L8,513> 15:18:22,373 INFO anaconda:program: warning: group
> >>  Development/Debug does not exist - using root> 
> > We remove "Group:" from the spec here:
> > 
> > https://github.com/oVirt/ovirt-imageio/commit/dd570082896cc410ad28b420ca37
> > dd065ec68831
> > 
> > Is this an upgrade from an older version that included Group?
> 
> No it's a build from scratch of an ovirt engine appliance.
> I see you have %dir %attr(755, %{user}, %{group}) %{logdir}
> 
> Looking at /usr/lib/rpm/macros.d content I see:
> ./macros.perl:
>   136 : Group: Development/Debug\
> ./macros.scl:
>19 : Group: Development/Debug
> 
> which looks pretty suspicious.
> 
> I think it would be safer using a different macro name for your spec file
> changing:
> %global user ovirtimg
> %global group ovirtimg
> 
> to:
> 
> %global ovirtimg_user ovirtimg
> %global ovirtimg_group ovirtimg
> 
> and use them, avoiding to use generic names like "user" and "group" that
> may conflict with existing macros

thanks for the hint, should be fixed in 
https://gerrit.ovirt.org/110066

> 
> >>   >>  consoleFull#L8,514> 15:18:22,373 INFO anaconda:program:
> >>  
> >>   >>  consoleFull#L8,515> 15:18:22,374 INFO anaconda:program: Running
> >>  scriptlet: ovirt-imageio-daemon-2.0.9-1.el8.x86_64 90/223>> 
> >> Sounds like a bug in the spec file.
> >> 
> >> --
> >> 
> >> Sandro Bonazzola
> >> 
> >> MANAGER, SOFTWARE ENGINEERING, EMEA R RHV
> >> 
> >> Red Hat EMEA 
> >> 
> >> sbona...@redhat.com
> >> 
> >> 
> >> *Red Hat respects your work life balance. Therefore there is no need to
> >> answer this email out of your office hours.
> >> *



signature.asc
Description: This is a digitally signed message part.
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/EMV7XBANC3CA5ZH2PV2H5ITPO3ENXIPB/