[ovirt-devel] changes in dbscripts/common_sp.sql functions validation

[Eli Mesika]

Hi All

Patch [1] is about to be merged soon and it changes the behaviour of
dbscripts/common_sp.sql functions validation.

In dbscripts/common_sp.sql we have several helper functions that execute
dynamic SQL using the EXECUTE command
In order to validate parameters as table name , column name etc, we used to
check those parameters
with the information stored in the information_schema data

Due to that we had some side effects:

1. fn_db_change_column_type did not accept valid types as DECIMAL since in
the information_schema data in is named NUMERIC
2. fn_db_change_column_type did not accept precision in the origin column
type as NUMERIC(24,4) for example
3. fn_db_change_column_type swallowed any error causing scripts not to
perform the action but to consider as successful

Patch [1] fixes all those issues and now the comon_sp.sql functions will
trust errors thrown by using the EXECUTE command without
validating the SQL syntax before. This will resolve issues 1 and 2 listed
above

In addition, the patch fixes issue 3 by adding the needed upgrade scripts
to enforce the changes that were not performed in former upgrade scripts
updates.

Please feel free to contact me on any issues/questions regarding those
changes

Regards
Eli Mesika

[1] https://gerrit.ovirt.org/#/c/ovirt-engine/+/117448/
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QT533FHOOFYZFXKTEKYWULYCGTV7C2JT/

[ovirt-devel] Re: Is "Copy Role" functionality possible through the SDK?

[Eli Mesika]

On Mon, Feb 10, 2020 at 12:27 PM  wrote:

> Hi,
>
> Is there ability to copy an existing system role via the SDK similar to
> what's available in the oVirt Admin Portal?
>
> I can see add(), update() and remove() but nothing so far that looks like
> it maps to copy().
>

AFAIK SDK handles only those general operations
Adding Ori Liel who is in charge of the SDK

>
> Thanks a lot,
> Conor
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/PI3GTYP6EWDYQNO74SKBIKYYZ7TCDUKP/
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GVG3YSHRI4TWTGGFZ2UZ6LK4O5Y44MTH/

[ovirt-devel] Re: Misc configuration': Failed to start service 'rh-postgresql95-postgresql

[Eli Mesika]

Galit

Did you find what went wrong?

On Sun, Feb 17, 2019 at 12:55 PM Galit Rosenthal 
wrote:

> Thanks Greg
>
> I will check this
>
>
> On Sun, Feb 17, 2019 at 12:51 PM Greg Sheremeta 
> wrote:
>
>> Is there any way you can run
>> "systemctl status rh-postgresql95-postgresql.service" and "journalctl -xe"
>> like it suggests?
>> The logs below don't give any indication why it failed to start, afaict.
>>
>> On Sun, Feb 17, 2019 at 4:59 AM Galit Rosenthal 
>> wrote:
>>
>>> Hi
>>>
>>> I receive this error message both in CQ and check_patch:
>>>
>>> 2019-02-16 16:28:06,874-0500 DEBUG otopi.plugins.otopi.services.systemd 
>>> systemd.state:130 starting service rh-postgresql95-postgresql
>>> 2019-02-16 16:28:06,874-0500 DEBUG otopi.plugins.otopi.services.systemd 
>>> plugin.executeRaw:813 execute: ('/usr/bin/systemctl', 'start', 
>>> 'rh-postgresql95-postgresql.service'), executable='None', cwd='None', 
>>> env=None
>>> 2019-02-16 16:28:07,913-0500 DEBUG otopi.plugins.otopi.services.systemd 
>>> plugin.executeRaw:863 execute-result: ('/usr/bin/systemctl', 'start', 
>>> 'rh-postgresql95-postgresql.service'), rc=1
>>> 2019-02-16 16:28:07,914-0500 DEBUG otopi.plugins.otopi.services.systemd 
>>> plugin.execute:921 execute-output: ('/usr/bin/systemctl', 'start', 
>>> 'rh-postgresql95-postgresql.service') stdout:
>>>
>>>
>>> 2019-02-16 16:28:07,914-0500 DEBUG otopi.plugins.otopi.services.systemd 
>>> plugin.execute:926 execute-output: ('/usr/bin/systemctl', 'start', 
>>> 'rh-postgresql95-postgresql.service') stderr:
>>> Job for rh-postgresql95-postgresql.service failed because the control 
>>> process exited with error code. See "systemctl status 
>>> rh-postgresql95-postgresql.service" and "journalctl -xe" for details.
>>>
>>> 2019-02-16 16:28:07,915-0500 DEBUG otopi.transaction transaction.abort:119 
>>> aborting 'File transaction for 
>>> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_hba.conf''
>>> 2019-02-16 16:28:07,916-0500 DEBUG otopi.context context._executeMethod:143 
>>> method exception
>>> Traceback (most recent call last):
>>>   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 133, in 
>>> _executeMethod
>>> method['method']()
>>>   File 
>>> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py",
>>>  line 201, in _misc
>>> self._provisioning.provision()
>>>   File 
>>> "/usr/share/ovirt-engine/setup/ovirt_engine_setup/engine_common/postgres.py",
>>>  line 498, in provision
>>> self.restartPG()
>>>   File 
>>> "/usr/share/ovirt-engine/setup/ovirt_engine_setup/engine_common/postgres.py",
>>>  line 399, in restartPG
>>> state=state,
>>>   File "/usr/share/otopi/plugins/otopi/services/systemd.py", line 141, in 
>>> state
>>> service=name,
>>> RuntimeError: Failed to start service 'rh-postgresql95-postgresql'
>>> 2019-02-16 16:28:07,918-0500 ERROR otopi.context context._executeMethod:152 
>>> Failed to execute stage 'Misc configuration': Failed to start service 
>>> 'rh-postgresql95-postgresql'
>>> 2019-02-16 16:28:07,958-0500 DEBUG 
>>> otopi.plugins.otopi.debug.debug_failure.debug_failure 
>>> debug_failure._notification:100 tcp connections:
>>> id uid local foreign state pid exe
>>>
>>>
>>> What can cause it?
>>>
>>>
>>> Thanks
>>>
>>> Galit
>>>
>>> https://jenkins.ovirt.org/view/Change%20queue%20jobs/job/ovirt-master_change-queue-tester/12916/testReport/junit/(root)/001_initialize_engine/running_tests___upgrade_from_release_suite_el7_x86_64___test_initialize_engine/
>>>
>>>
>>> https://jenkins.ovirt.org/blue/organizations/jenkins/ovirt-system-tests_standard-check-patch/detail/ovirt-system-tests_standard-check-patch/3207/pipeline/101
>>>
>>>
>>>
>>> Regards,
>>>
>>> Galit
>>>
>>>
>>> --
>>>
>>> GALIT ROSENTHAL
>>>
>>> SOFTWARE ENGINEER
>>>
>>> Red Hat
>>>
>>> 
>>>
>>> ga...@gmail.comT: 972-9-7692230
>>> 
>>> ___
>>> Devel mailing list -- devel@ovirt.org
>>> To unsubscribe send an email to devel-le...@ovirt.org
>>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>>> oVirt Code of Conduct:
>>> https://www.ovirt.org/community/about/community-guidelines/
>>> List Archives:
>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QNDG65M6UPEXTCT3HXORRTZ67RVXH653/
>>>
>>
>>
>> --
>>
>> GREG SHEREMETA
>>
>> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
>>
>> Red Hat NA
>>
>> 
>>
>> gsher...@redhat.comIRC: gshereme
>> 
>>
>
>
> --
>
> GALIT ROSENTHAL
>
> SOFTWARE ENGINEER
>
> Red Hat
>
> 
>
> ga...@gmail.comT: 972-9-7692230
> 
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/

[ovirt-devel] preventing modifications of exiting upgrade scripts

[Eli Mesika]

Hi

Please note that patch[1] was merged.
This patch will prevent(with a detailed ERROR[2]) any attempt to modify an
existing DB upgrade script since this may lead to upgrade problems.
The correct way to change something in the database is a new upgrade script.
In a case that the upgrade script must be changed, this can be forced by
adding a special keyword[3] to your commit header.

Please see [1] description for details.

If you have any questions, please let me know.


[1] https://gerrit.ovirt.org/#/c/96421/
[2] [ERROR] : Changing an existing upgrade script is dangerous and can
cause upgrade problems,
if you are doing that in purpose and sure that there is no
other way to fix the issue you
are working on, please add the key
'Allow-db-upgrade-script-changes:Yes' to your patch commit message."
[3] "Allow-db-upgrade-script-changes:Yes"


Thanks

Eli Mesika
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/4V4TLI5IOI57WG32N2F27GGGP45TUPKE/

[ovirt-devel] [IMPORTANT] Upgrading to PG 10.x in version 4.3 on f28/CentOS7.5 , instructions for developers,, please read before you re-base on master

[Eli Mesika]

Hi

We will merge a patch[1] today that will require the upcoming 4.3 version
to use Postgres 10 on f28 and Postgres SCL 10 (Software Collections) on
CentOS 7.5

* If you are using f28 and creating new DB schema for development (having
no 9.x PG data), then you done and this change should be transparent to you.

* If you are using f27, have some old 9.x PG data and upgrade to f28, then
you will have to upgrade your old PG data after moving to f28 according to
the instructions in [2]

* If you are using CentOS then you are running PG SCL 9.5 and should
upgrade to PG SCL 10

1.  Upgrade to CentOS 7.5 (insure that you have the SCL repo [3] after
upgrade)
2.  #yum update -y # insure that your OS has latest patches
3.  #service rh-postgresql95-postgresql stop
4.  #yum install rh-postgresql10 rh-postgresql10-postgresql-contrib -y
5.  #/opt/rh/rh-postgresql10/root/bin/postgresql-setup --upgrade
--upgrade-from="rh-postgresql95-postgresql" # If you have junk sachems,
drop them first, the upgrade of each takes time.
6.  #service rh-postgresql10-postgresql start # check status to see that it
is active
7.  #service rh-postgresql10-postgresql enable
8.  Insure that your patches are re-based on master latest
9.  Remove all  binaries created with "#make clean install-dev
PREFIX=."
10. Compile(make install-dev..)/Setup(engine-setup) and run again your
patches (git branches you are working on)
11. Insure that basic operations (add new dc/cluster for example) are
working
12. Track engine.log / server.log and PG logs for database errors
13. # yum remove rh-postgresql95 rh-postgresql95-postgresql-contrib -y
(only if all above is succeed)


[1] https://gerrit.ovirt.org/#/c/95100/
[2]
https://docs.bmc.com/docs/btco113/migrating-the-data-from-postgresql-9-x-to-10-x-800581922.html
[3] https://wiki.centos.org/AdditionalResources/Repositories/SCL

If you are developing from a VM then it is always recommended to create a
"before upgrade" snapshot of the VM.
(I know it is not supported from the user portal but you can ask for access
rights only for doing this from your admin on the admin portal.

If you have any questions/problems , please contact me

Eli Mesika (emesika on IRC)

Best Regards

Eli
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/VS6M75UXJR76D3JVSGZWKOUHXM2GBJY6/

[ovirt-devel] Re: [ OST Failure Report ] [ oVirt 4.2 (ovirt-engine) ] [ 07-08-2018 ] [ 004_basic_sanity.update_template_version ]

[Eli Mesika]

Looking 

On Tue, Aug 7, 2018 at 2:42 PM, Dafna Ron  wrote:

> Hi,
>
> We are failing ovirt 4.2 on project ovirt-engine on test
> 004_basic_sanity.update_template_version.
>
> I believe the reported patch from CQ may have indeed caused the issue.
>
> Eli, can you please check this issue?
>
> *Link and headline of suspected patches:
> https://gerrit.ovirt.org/#/c/93501/  -
> *
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> *core:make search string fields not null and emptyLink to
> Job:https://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/2800
> Link to
> all
> logs:https://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/2800/artifact/basic-suite.el7.x86_64/test_logs/basic-suite-4.2/post-004_basic_sanity.py/
> (Relevant)
> error snippet from the log:  "0aec9ef2-5e1f-4cb6-bf75-f5826d2ae135", method: Volume.getInfo, params:
> {storagepoolID=fe6f6819-4791-4624-aa56-c82e49b0eaf3,
> storagedomainID=2a3af2d0-c00e-4ac7-a162-fa08d33c173f,
> imageID=2d2f61d4-2347-4200-9c1f-0ee376104ef0,
> volumeID=21ea717f-e3a1-4c36-8101-ba746bd78c40}>2018-08-07 06:12:46,522-04
> INFO  [org.ovirt.engine.core.bll.AddVmTemplateCommand] (default task-4)
> [6db41b0d-0d11-4b75-94f9-4a478e6fb3dc] Running command:
> AddVmTemplateCommand internal: false. Entities affected :  ID:
> fe6f6819-4791-4624-aa56-c82e49b0eaf3 Type: StoragePoolAction group
> CREATE_TEMPLATE with role type USER2018-08-07 06:12:46,525-04 INFO
> [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand] (default task-4)
> [6db41b0d-0d11-4b75-94f9-4a478e6fb3dc] START, SetVmStatusVDSCommand(
> SetVmStatusVDSCommandParameters:{vmId='64293490-e128-48b7-9e23-0491b48d9a1f',
> status='ImageLocked', exitStatus='Normal'}), log id: eca02a92018-08-07
> 06:12:46,527-04 INFO
> [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand] (default task-4)
> [6db41b0d-0d11-4b75-94f9-4a478e6fb3dc] FINISH, SetVmStatusVDSCommand, log
> id: eca02a92018-08-07 06:12:46,527-04 DEBUG
> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
> (default task-4) [6db41b0d-0d11-4b75-94f9-4a478e6fb3dc] method:
> runVdsCommand, params: [SetVmStatus,
> SetVmStatusVDSCommandParameters:{vmId='64293490-e128-48b7-9e23-0491b48d9a1f',
> status='ImageLocked', exitStatus='Normal'}], timeElapsed: 3ms2018-08-07
> 06:12:46,537-04 DEBUG
> [org.ovirt.engine.core.dal.dbbroker.CustomSQLErrorCodeSQLExceptionTranslator]
> (default task-4) [6db41b0d-0d11-4b75-94f9-4a478e6fb3dc] Translating
> SQLException with SQL state '23502', error code '0', message [ERROR: null
> value in column "description" violates not-null constraint  Detail: Failing
> row contains (ce532690-2131-49a8-b2a0-183936727092,
> CirrOS_0.4.0_for_x86_64_glance_template, 512,
> 5b1f874d-dc92-43ed-86ef-a9c2d6bfc9a3, 0, null,
> fe7292a4-c998-4f6c-897c-fa7525911a16, 2018-08-07 06:12:46.529-04, 1, null,
> f, 1, 1, 1, Etc/GMT, t, f, 2018-08-07 06:12:46.530974-04, null, null, f, 1,
> 0, 0, 1, 0, , 3, null, null, null, 0, , , 256, TEMPLATE, 0, 1,
> 31a8e1fa-1fad-456c-8b8a-aa11551cae9d, f, null, f, f, 1, f, f, f,
> d0d66980-9a26-11e8-b2f3-5452c0a8c802, null, , f, 0, null, null, null,
> guest_agent, null, null, null, 2, null, 2, 12345678, f, interleave, t, t,
> deb3f53e-13c5-4aea-bf90-0339eba39fed, null, null, null, null,
> 22716173-2816-a109-1d2f-c44d945e92dd, 3b3f239c-d8bb-423f-a39c-e2b905473b83,
> null, 1, LOCK_SCREEN, 2, null, null, 2048, null, AUTO_RESUME, t).  Where:
> SQL statement "INSERTINTO vm_static(child_count,
> creation_date,description,free_text_comment,
> mem_size_mb,max_memory_size_mb,num_of_io_threads,
> vm_name,num_of_sockets,cpu_per_socket,
> threads_per_cpu,os,vm_guid,cluster_id,
> num_of_monitors,single_qxl_pci,
> allow_console_reconnect,template_status,usb_policy,
> time_zone,fail_back,vm_type,nice_level,
> cpu_shares,default_boot_sequence,default_display_type,*
>
>
> **
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/EVAWWDN43EXXQBWHXTUWPA5R3G6M7HF4/

[ovirt-devel] Re: [ OST Failure Report ] [ oVirt Master (ovirt-engine) ] [ 05-06-2018 ] [ 002_bootstrap.update_default_cluster ]

[Eli Mesika]

Patch on master merged , patch on 4.2 is waiting for CI and then will be
merged

On Tue, Jun 12, 2018 at 1:00 PM, Dafna Ron  wrote:

> Hi Martin, Eli and Arik.
>
> can you please give an update on this?
>
> Is there a bug reported for this?
>
> Thanks,
> Danfa
>
>
> On Fri, Jun 8, 2018 at 1:26 PM, Martin Perina  wrote:
>
>>
>>
>> On Fri, Jun 8, 2018 at 12:56 PM, Dafna Ron  wrote:
>>
>>> Hi Martin, Eli,
>>>
>>> It seems the fix has failed on the same test:
>>> https://jenkins.ovirt.org/view/Change%20queue%20jobs/job/ovi
>>> rt-master_change-queue-tester/8068/
>>>
>>> can you please have a look?
>>>
>>
>> ​It's strange, because Eli manually verified upgrade OST for master and
>> it worked.
>>
>> But yeah, we know that provided fix didn't solve all cpu_name related
>> issues and Eli is working on complete fix with Arik:
>> https://gerrit.ovirt.org/#/c/92049/
>> Eli, please try to put maximum priority on it during Sunday and merge the
>> fix if acked by Arik.
>> ​
>> Thanks
>>
>> Martin
>>
>>
>>> Thanks,
>>> Dafna
>>>
>>>
>>> On Wed, Jun 6, 2018 at 11:03 AM, Dafna Ron  wrote:
>>>
>>>> Thanks Eli.
>>>>
>>>> On Wed, Jun 6, 2018 at 10:49 AM, Eli Mesika  wrote:
>>>>
>>>>> Hi Dafna
>>>>>
>>>>> We are aware of that, the patch will be merged upstream ASAP and I
>>>>> sent a 4.2 patch as well , hope to have both merge soon
>>>>>
>>>>> On Wed, Jun 6, 2018 at 11:45 AM, Dafna Ron  wrote:
>>>>>
>>>>>> any idea when the fix will be merged? for now, ovirt-engine is
>>>>>> broken.
>>>>>>
>>>>>> On Tue, Jun 5, 2018 at 9:37 PM, Eli Mesika 
>>>>>> wrote:
>>>>>>
>>>>>>> Yes I do
>>>>>>>
>>>>>>> On Tue, Jun 5, 2018 at 7:20 PM, Martin Perina 
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, Jun 5, 2018 at 5:08 PM, Dafna Ron  wrote:
>>>>>>>>
>>>>>>>>> Eli, Martin,
>>>>>>>>> Any updates?
>>>>>>>>>
>>>>>>>>
>>>>>>>> ​Eli, do you think that https://gerrit.ovirt.org/91968​ fixes also
>>>>>>>> this OST failure?
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Tue, Jun 5, 2018 at 12:15 PM, Dafna Ron 
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> *Hi, We have a failure in ovirt-engine on master on update
>>>>>>>>>> cluster because of "cpu not found" CQ reported the below as the most
>>>>>>>>>> possible cause for the failure. I looked at the other changes that 
>>>>>>>>>> ran and
>>>>>>>>>> I don't think any of them would be the cause of failure. *
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> *Can you please have a look at this issue? *
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> *Link and headline of suspected patches: *
>>>>>>>>>>
>>>>>>>>>> https://gerrit.ovirt.org/#/c/91888/ - db:fix upgrade issue on
>>>>>>>>>> NULL values
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>

[ovirt-devel] Re: [ OST Failure Report ] [ oVirt Master (ovirt-engine) ] [ 05-06-2018 ] [ 002_bootstrap.update_default_cluster ]

[Eli Mesika]

Hi Dafna

We are aware of that, the patch will be merged upstream ASAP and I sent a
4.2 patch as well , hope to have both merge soon

On Wed, Jun 6, 2018 at 11:45 AM, Dafna Ron  wrote:

> any idea when the fix will be merged? for now, ovirt-engine is broken.
>
> On Tue, Jun 5, 2018 at 9:37 PM, Eli Mesika  wrote:
>
>> Yes I do
>>
>> On Tue, Jun 5, 2018 at 7:20 PM, Martin Perina  wrote:
>>
>>>
>>>
>>> On Tue, Jun 5, 2018 at 5:08 PM, Dafna Ron  wrote:
>>>
>>>> Eli, Martin,
>>>> Any updates?
>>>>
>>>
>>> ​Eli, do you think that https://gerrit.ovirt.org/91968​ fixes also this
>>> OST failure?
>>>
>>>
>>>>
>>>> On Tue, Jun 5, 2018 at 12:15 PM, Dafna Ron  wrote:
>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> *Hi, We have a failure in ovirt-engine on master on update cluster
>>>>> because of "cpu not found" CQ reported the below as the most possible 
>>>>> cause
>>>>> for the failure. I looked at the other changes that ran and I don't think
>>>>> any of them would be the cause of failure. *
>>>>>
>>>>>
>>>>>
>>>>> *Can you please have a look at this issue? *
>>>>>
>>>>>
>>>>> *Link and headline of suspected patches: *
>>>>>
>>>>> https://gerrit.ovirt.org/#/c/91888/ - db:fix upgrade issue on NULL
>>>>> values
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> *Link to
>>>>> Job:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/
>>>>> <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/>Link
>>>>> to all
>>>>> logs:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/
>>>>> <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/>(Relevant)
>>>>> error snippet from the log: 2018-06-04 11:56:31,958-04 INFO
>>>>> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
>>>>> (default task-13) [] EVENT_ID: USER_ADDED_CPU_PROFILE(10,130), CPU Profile
>>>>> test-cluster was successfully added (User: 
>>>>> admin@internal-authz).2018-06-04
>>>>> 11:56:31,959-04 DEBUG
>>>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>>>> (default task-13) [] method: runAction, params: [AddCpuProfile,
>>>>> CpuProfileParameters:{commandId='c76f8e59-c9a2-4601-964e-a92e9cb668ce', 
>>>>> user='admin',
>>>>> commandType='Unknown'}], timeElapsed: 168ms2018-06-04 11:56:31,974-04 INFO
>>>>> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
>>>>> (default task-13) [] EVENT_ID: USER_ADD_CLUSTER(809), Cluster test-cluster
>>>>> was added by admin@internal-authz2018-06-04 11:56:31,975-04 DEBUG
>>>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>>>> (default task-13) [] method: runAction, params: [AddCluster,
>>>>> ManagementNetworkOnClusterOperationParameters:{commandId='3e0bf24c-4c49-4094-928d-7c15ef50ff62',
>>>>> user='null', commandType='Unknown'}], timeElapsed: 272ms2018-06-04
>>>>> 11:56:31,980-04 DEBUG
>>>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>>>> (default task-13) [8ef59a69-020e-407c-9766-fbd3a6cc9381] method: runQuery,
>>>>> params: [GetClusterById,
>>>>> IdQueryParameters:{refresh='false', filtered='false'}], timeElapsed: 5ms*
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> *2018-06-04 11:57:19,857-04 DEBUG
>>>>> [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall]

[ovirt-devel] Re: [ OST Failure Report ] [ oVirt Master (ovirt-engine) ] [ 05-06-2018 ] [ 002_bootstrap.update_default_cluster ]

[Eli Mesika]

Yes I do

On Tue, Jun 5, 2018 at 7:20 PM, Martin Perina  wrote:

>
>
> On Tue, Jun 5, 2018 at 5:08 PM, Dafna Ron  wrote:
>
>> Eli, Martin,
>> Any updates?
>>
>
> ​Eli, do you think that https://gerrit.ovirt.org/91968​ fixes also this
> OST failure?
>
>
>>
>> On Tue, Jun 5, 2018 at 12:15 PM, Dafna Ron  wrote:
>>
>>>
>>>
>>>
>>>
>>> *Hi, We have a failure in ovirt-engine on master on update cluster
>>> because of "cpu not found" CQ reported the below as the most possible cause
>>> for the failure. I looked at the other changes that ran and I don't think
>>> any of them would be the cause of failure. *
>>>
>>>
>>>
>>> *Can you please have a look at this issue? *
>>>
>>>
>>> *Link and headline of suspected patches: *
>>>
>>> https://gerrit.ovirt.org/#/c/91888/ - db:fix upgrade issue on NULL
>>> values
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> *Link to
>>> Job:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/
>>> Link
>>> to all
>>> logs:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8033/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/
>>> (Relevant)
>>> error snippet from the log: 2018-06-04 11:56:31,958-04 INFO
>>> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
>>> (default task-13) [] EVENT_ID: USER_ADDED_CPU_PROFILE(10,130), CPU Profile
>>> test-cluster was successfully added (User: admin@internal-authz).2018-06-04
>>> 11:56:31,959-04 DEBUG
>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>> (default task-13) [] method: runAction, params: [AddCpuProfile,
>>> CpuProfileParameters:{commandId='c76f8e59-c9a2-4601-964e-a92e9cb668ce', 
>>> user='admin',
>>> commandType='Unknown'}], timeElapsed: 168ms2018-06-04 11:56:31,974-04 INFO
>>> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
>>> (default task-13) [] EVENT_ID: USER_ADD_CLUSTER(809), Cluster test-cluster
>>> was added by admin@internal-authz2018-06-04 11:56:31,975-04 DEBUG
>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>> (default task-13) [] method: runAction, params: [AddCluster,
>>> ManagementNetworkOnClusterOperationParameters:{commandId='3e0bf24c-4c49-4094-928d-7c15ef50ff62',
>>> user='null', commandType='Unknown'}], timeElapsed: 272ms2018-06-04
>>> 11:56:31,980-04 DEBUG
>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>> (default task-13) [8ef59a69-020e-407c-9766-fbd3a6cc9381] method: runQuery,
>>> params: [GetClusterById,
>>> IdQueryParameters:{refresh='false', filtered='false'}], timeElapsed: 5ms*
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> *2018-06-04 11:57:19,857-04 DEBUG
>>> [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall]
>>> (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] Compiled stored
>>> procedure. Call string is [{call getvdsbyclusterid(?, ?, ?)}]2018-06-04
>>> 11:57:19,857-04 DEBUG
>>> [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall]
>>> (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] SqlCall for
>>> procedure [GetVdsByClusterId] compiled2018-06-04 11:57:19,878-04 DEBUG
>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>> (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] method:
>>> getAllForCluster, params: [9cbb05e6-680f-11e8-b07e-5452c0a8c904],
>>> timeElapsed: 25ms2018-06-04 11:57:19,879-04 WARN
>>> [org.ovirt.engine.core.bll.UpdateClusterCommand] (default task-6)
>>> [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] Validation of action 'UpdateCluster'
>>> failed for user admin@internal-authz. Reasons:
>>> VAR__TYPE__CLUSTER,VAR__ACTION__UPDATE,VAR__TYPE__CLUSTER,ACTION_TYPE_FAILED_CPU_NOT_FOUND2018-06-04
>>> 11:57:19,881-04 INFO [org.ovirt.engine.core.bll.UpdateClusterCommand]
>>> (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] Lock freed to
>>> object 'EngineLock:{exclusiveLocks='[]', sharedLocks='[]'}'2018-06-04
>>> 11:57:19,881-04 DEBUG
>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
>>> (default task-6) [72cc0877-c16d-4539-a3d0-90cd3c4a7a84] method: runAction,
>>> params: [UpdateCluster,
>>> ManagementNetworkOnClusterOperationParameters:{commandId='36bf82e7-eec8-4b36-99af-db5ade902593',
>>> user='null', commandType='Unknown'}], timeElapsed: 58ms2018-06-04
>>> 11:57:19,886-04 ERROR
>>> [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default
>>> task-6) [] Operation Failed: [Cannot edit Cluster. The chosen CPU is not
>>> supported.]*
>>> Thanks,
>>> Dafna
>>>
>>>
>>
>
>
> --
> Martin Perina
> Associate Manager, Software Engineering
> Red Hat Czech s.r.o.
>

[ovirt-devel] Re: Recent upgrade issues caused by mess in database scripts

[Eli Mesika]

On Sat, Jun 2, 2018 at 12:20 PM, Martin Perina  wrote:

> Hi,
>
> recently [1], [2] were raised, but the main reason for those bugs was the
> we are no paying enough attention to consequences when doing backports.
> Below are two examples which we need to pay more attention to:
>
> 1. Database upgrade scripts naming and numbering
> - there's no problem if the same script has different name or number
> between y-streams (for example 4.3 and 4.2), but names and number need to
> match between z-streams
> - if we are going to do async release (for example 4.2.3.z) and we
> need to backport to async branch patch which includes db upgrade script, we
> need to make sure to align db scripts in branch from which next z-stream
> will be built (for example 4.2, patch [3] can be used as an example how to
> fix this issue)
>
> 2. Use the same name of database upgrade script when doing backports
>   - when backporting some patches to z-stream branch please use the same
> db script name and change only db script number as needed, otherwise
> backports are quite confusing (for example [4] and [5])
>
>
> Patch [3] fixes the situation, so when included into 4.2.4 build it should
> allow smooth upgrade from 4.2.3.z to 4.2.4, but users which already
> performed upgrade are in trouble. @Eli is there any way how we can force
> execution of db scripts, which were skipped due to the mess in names
> between 4.2.3.z and 4.2.4 to help users which have already broken database?
>

​unfortunately, those should be run manually or merge all to one re-entrant
script and add it as an additional upgrade script.
​

>
>
> @Tal/@Piotr, could you please pay even more attention when merging patches
> containing db scripts to z-stream async branches (normal branch, for
> example ovirt-engine-4.2, should be fine, but ovirt-engine-4.2.3.z requires
> more attention)? I agree that developer who backports the patch should
> handle the situation (feel free to ask infra team if unsure about
> consequences), but you are the last safety check we have.
>
> Thanks a lot
>
> Martin
>
> [1] https://bugzilla.redhat.com/1583562
> [2] https://bugzilla.redhat.com/1583664
> [3] https://gerrit.ovirt.org/91874
> [4] https://gerrit.ovirt.org/90695
> [5] https://gerrit.ovirt.org/90698
>
>
> --
> Martin Perina
> Associate Manager, Software Engineering
> Red Hat Czech s.r.o.
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/56CTWFLRP3VXSXYZOZ4PWORHTW5O4XWU/

[ovirt-devel] Re: [ OST Failure Report ] [ oVirt Master (ovirt-engine) ] [22-05-2018 ] [ 004_basic_sanity.update_template_version]

[Eli Mesika]

Seems as [1] solves the issue

[1] https://gerrit.ovirt.org/#/c/91586/


On Wed, May 23, 2018 at 6:19 PM, Dafna Ron  wrote:

> ok. thank you for the update Martin.
>
> On Wed, May 23, 2018 at 4:16 PM, Martin Perina  wrote:
>
>>
>>
>> On Wed, May 23, 2018 at 5:11 PM, Dafna Ron  wrote:
>>
>>> Arik - any update?
>>>
>>> Thanks,
>>> Dafna
>>>
>>
>> ​We have confirmed that the fix doesn't work. If we haven't found a fix
>> till tomorrow noon, we will revert the patch.
>> ​
>>
>>>
>>>
>>> On Wed, May 23, 2018 at 1:23 PM, Martin Perina 
>>> wrote:
>>>


 On Wed, May 23, 2018 at 2:08 PM, Martin Perina 
 wrote:

>
>
> On Wed, May 23, 2018 at 12:23 PM, Martin Perina 
> wrote:
>
>>
>>
>> On Wed, May 23, 2018 at 11:55 AM, Dafna Ron  wrote:
>>
>>> Eli, Martin - can you please take a look?
>>>
>>
>> ​We have discussed a few minutes ago, Eli is looking at it.
>>
>
> ​Here's possible fix: https://gerrit.ovirt.org/91534​
> We want to verify it by OST run, but looks like manual engine RPM
> builds are either not working or it takes REALLY long time to start ...
>

 ​Adding Arik to the thread, it looks like the above fix doesn't help,
 we are continuing with investigations ...
 ​

>
>
>> Thanks
>>
>> Martin
>>
>> ​
>>
>>>
>>> Thanks,
>>> Dafna
>>>
>>>
>>> On Tue, May 22, 2018 at 7:09 PM, Dafna Ron  wrote:
>>>
 Hi,

 This failure seems to be related to the regression we found earlier
 today which was causing failure in initialize engine:
 https://gerrit.ovirt.org/#/c/89293/ - core:make search string
 fields not null and empty

 The fix for the above change was reported as failed on the update
 template test with an error which I think is related to the same
 regression.

 https://gerrit.ovirt.org/#/c/91476/ - db: resolve duplicate db
 scripts

 Can you please have a look?













































































































































































 *Link to
 Job:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/7675/
 Link
 to all
 logs:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/7675/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-004_basic_sanity.py/
 (Relevant)
 error snippet from the log: 2018-05-22 12:40:21,015-04 DEBUG
 [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
 (default task-10) [aa79ad89-02ea-4474-ad41-78cf52243b41] method: 
 runQuery,
 params: [GetSoundDevices, IdQueryParameters:{refresh='false',
 filtered='false'}], timeElapsed: 3ms2018-05-22 12:40:21,021-04 DEBUG
 [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor]
 (default task-10) [aa79ad89-02ea-4474-ad41-78cf52243b41] method: get,
 params: [5cf93146-a5f1-4330-affe-672eaf39cc0d], timeElapsed: 
 

[ovirt-devel] Re: [FC28] PostgreSQL 10

[Eli Mesika]

On Sun, May 13, 2018 at 12:09 PM, Benny Zlotnik <bzlot...@redhat.com> wrote:

> 9.2-1002-jdbc4
>
> It does not look like the same issue
>

​Can you please send to me the details ​of the machine in order to
investigate?




>
> On Sun, May 13, 2018 at 11:46 AM, Eli Mesika <emes...@redhat.com> wrote:
>
>>
>>
>> On Wed, May 9, 2018 at 11:12 AM, Sandro Bonazzola <sbona...@redhat.com>
>> wrote:
>>
>>>
>>>
>>> 2018-05-09 10:04 GMT+02:00 Benny Zlotnik <bzlot...@redhat.com>:
>>>
>>>> I've had an issue[1] running engine, it looks like it's related to
>>>> Fedora 28 coming with postgresql 10.
>>>> I managed to workaround it by upgrading locally the jdbc driver to the
>>>> latest 42.2.2
>>>>
>>>
>> ​Which JDBC version was used in original installation ?
>> Can you check if this BZ [1] is the cause ?
>>
>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1459499
>> ​
>>
>>
>>>
>>> Dropping infra, adding Martin and Eli.
>>> Also changing subject
>>>
>>>
>>>>
>>>>
>>>>
>>>> [1]
>>>> 2018-05-09 10:59:26,303+03 ERROR 
>>>> [org.jboss.as.controller.management-operation]
>>>> (Controller Boot Thread) WFLYCTL0013: Operation ("deploy") failed -
>>>>  address: ([("deployment" => "engine.ear")]) - failure description:
>>>> {"WFLYCTL0080: Failed services" => {"jboss.deployment.subunit.\"e
>>>> ngine.ear\".\"
>>>> bll.jar\".component.Backend.START" => "java.lang.IllegalStateException:
>>>> WFLYEE0042: Failed to construct component instance
>>>> Caused by: java.lang.IllegalStateException: WFLYEE0042: Failed to
>>>> construct component instance
>>>> Caused by: javax.ejb.EJBException: 
>>>> org.jboss.weld.exceptions.WeldException:
>>>> WELD-49: Unable to invoke protected void org.ovirt.engine.core.
>>>> bll.TagsDirector.init() on org.ovirt.engine.core.bll.Tags
>>>> Director@891dc3a
>>>> Caused by: org.jboss.weld.exceptions.WeldException: WELD-49:
>>>> Unable to invoke protected void org.ovirt.engine.core.bll.Tags
>>>> Director.init()
>>>> on org.ovirt.engine.core.bll.TagsDirector@891dc3a
>>>> Caused by: java.lang.reflect.InvocationTargetException
>>>> Caused by: org.springframework.jdbc.BadSqlGrammarException:
>>>> PreparedStatementCallback; bad SQL grammar [select * from
>>>> gettagsbyparent_id()]; n
>>>> ested exception is org.postgresql.util.PSQLException: ERROR: function
>>>> gettagsbyparent_id() does not exist
>>>>   Hint: No function matches the given name and argument types. You
>>>> might need to add explicit type casts.
>>>>   Position: 16
>>>> Caused by: org.postgresql.util.PSQLException: ERROR: function
>>>> gettagsbyparent_id() does not exist
>>>>   Hint: No function matches the given name and argument types. You
>>>> might need to add explicit type casts.
>>>>   Position: 16"}}
>>>>
>>>>
>>>> On Wed, May 9, 2018 at 10:38 AM, Sandro Bonazzola <sbona...@redhat.com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>> if you're not yet on Fedora 28, please consider updating to it.
>>>>> On master we are aiming to support Fedora 28 and we are dismissing any
>>>>> older Fedora jobs in Jenkins soon.
>>>>>
>>>>> As a reminder Fedora 26 support is going to be EOL on Tuesday, May
>>>>> 29th, 2018.
>>>>>
>>>>> Thanks,
>>>>> --
>>>>>
>>>>> SANDRO BONAZZOLA
>>>>>
>>>>> ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R
>>>>>
>>>>> Red Hat EMEA <https://www.redhat.com/>
>>>>>
>>>>> sbona...@redhat.com
>>>>> <https://red.ht/sig>
>>>>> <https://redhat.com/summit>
>>>>>
>>>>> ___
>>>>> Infra mailing list -- in...@ovirt.org
>>>>> To unsubscribe send an email to infra-le...@ovirt.org
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> SANDRO BONAZZOLA
>>>
>>> ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R
>>>
>>> Red Hat EMEA <https://www.redhat.com/>
>>>
>>> sbona...@redhat.com
>>> <https://red.ht/sig>
>>> <https://redhat.com/summit>
>>>
>>> ___
>>> Devel mailing list -- devel@ovirt.org
>>> To unsubscribe send an email to devel-le...@ovirt.org
>>> %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
>>>
>>
>>
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[ovirt-devel] Re: [FC28] PostgreSQL 10

[Eli Mesika]

On Wed, May 9, 2018 at 11:12 AM, Sandro Bonazzola 
wrote:

>
>
> 2018-05-09 10:04 GMT+02:00 Benny Zlotnik :
>
>> I've had an issue[1] running engine, it looks like it's related to Fedora
>> 28 coming with postgresql 10.
>> I managed to workaround it by upgrading locally the jdbc driver to the
>> latest 42.2.2
>>
>
​Which JDBC version was used in original installation ?
Can you check if this BZ [1] is the cause ?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1459499
​


>
> Dropping infra, adding Martin and Eli.
> Also changing subject
>
>
>>
>>
>>
>> [1]
>> 2018-05-09 10:59:26,303+03 ERROR 
>> [org.jboss.as.controller.management-operation]
>> (Controller Boot Thread) WFLYCTL0013: Operation ("deploy") failed -
>>  address: ([("deployment" => "engine.ear")]) - failure description:
>> {"WFLYCTL0080: Failed services" => {"jboss.deployment.subunit.\"e
>> ngine.ear\".\"
>> bll.jar\".component.Backend.START" => "java.lang.IllegalStateException:
>> WFLYEE0042: Failed to construct component instance
>> Caused by: java.lang.IllegalStateException: WFLYEE0042: Failed to
>> construct component instance
>> Caused by: javax.ejb.EJBException: 
>> org.jboss.weld.exceptions.WeldException:
>> WELD-49: Unable to invoke protected void org.ovirt.engine.core.
>> bll.TagsDirector.init() on org.ovirt.engine.core.bll.TagsDirector@891dc3a
>> Caused by: org.jboss.weld.exceptions.WeldException: WELD-49:
>> Unable to invoke protected void org.ovirt.engine.core.bll.Tags
>> Director.init()
>> on org.ovirt.engine.core.bll.TagsDirector@891dc3a
>> Caused by: java.lang.reflect.InvocationTargetException
>> Caused by: org.springframework.jdbc.BadSqlGrammarException:
>> PreparedStatementCallback; bad SQL grammar [select * from
>> gettagsbyparent_id()]; n
>> ested exception is org.postgresql.util.PSQLException: ERROR: function
>> gettagsbyparent_id() does not exist
>>   Hint: No function matches the given name and argument types. You might
>> need to add explicit type casts.
>>   Position: 16
>> Caused by: org.postgresql.util.PSQLException: ERROR: function
>> gettagsbyparent_id() does not exist
>>   Hint: No function matches the given name and argument types. You might
>> need to add explicit type casts.
>>   Position: 16"}}
>>
>>
>> On Wed, May 9, 2018 at 10:38 AM, Sandro Bonazzola 
>> wrote:
>>
>>> Hi,
>>> if you're not yet on Fedora 28, please consider updating to it.
>>> On master we are aiming to support Fedora 28 and we are dismissing any
>>> older Fedora jobs in Jenkins soon.
>>>
>>> As a reminder Fedora 26 support is going to be EOL on Tuesday, May
>>> 29th, 2018.
>>>
>>> Thanks,
>>> --
>>>
>>> SANDRO BONAZZOLA
>>>
>>> ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R
>>>
>>> Red Hat EMEA 
>>>
>>> sbona...@redhat.com
>>> 
>>> 
>>>
>>> ___
>>> Infra mailing list -- in...@ovirt.org
>>> To unsubscribe send an email to infra-le...@ovirt.org
>>>
>>>
>>
>
>
> --
>
> SANDRO BONAZZOLA
>
> ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R
>
> Red Hat EMEA 
>
> sbona...@redhat.com
> 
> 
>
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[ovirt-devel] Re: oVirt messages from engine to vdsm

[Eli Mesika]

On Tue, May 8, 2018 at 7:11 AM, Anastasiya Ruzhanskaya <
anastasiya.ruzhansk...@frtk.ru> wrote:

> scl enable rh-postgresql95 'psql -U postgres'
>

​This should be :

scl enable rh-postgresql95 bash

​



> psql: FATAL:  Peer authentication failed for user "postgres"
>
> I am not sure why it is trying to execute the command while enabling.
>
> 2018-05-07 12:22 GMT-04:00 Martin Sivak <msi...@redhat.com>:
>
>> Hi,
>>
>> that sure looks like postgresql SCL packages. Software collections are
>> installed into /opt and need to be enabled using the `scl enable
>> ` command to allow their usage.
>>
>> Best regards
>>
>> Martin Sivak
>>
>> On Mon, May 7, 2018 at 2:21 PM, Anastasiya Ruzhanskaya
>> <anastasiya.ruzhansk...@frtk.ru> wrote:
>> > rpm -qa |grep postgres
>> > rh-postgresql95-postgresql-libs-9.5.9-1.el7.x86_64
>> > postgresql-libs-9.2.23-3.el7_4.x86_64
>> > rh-postgresql95-runtime-2.2-2.el7.x86_64
>> > rh-postgresql95-postgresql-9.5.9-1.el7.x86_64
>> > postgresql-jdbc-9.2.1002-5.el7.noarch
>> > postgresql-contrib-9.2.23-3.el7_4.x86_64
>> > rh-postgresql95-postgresql-server-9.5.9-1.el7.x86_64
>> > postgresql-9.2.23-3.el7_4.x86_64
>> > rh-postgresql95-postgresql-contrib-9.5.9-1.el7.x86_64
>> > collectd-postgresql-5.8.0-2.el7.x86_64
>> > postgresql-server-9.2.23-3.el7_4.x86_64
>> > [skotti@localhost ~]$ psql -U postgres
>> > psql: FATAL:  Peer authentication failed for user "postgres"
>> >
>> > But I actually installed it manually, still no succeed. But ovirt
>> engine is
>> > working.
>> >
>> > 2018-05-07 5:22 GMT-04:00 Eli Mesika <emes...@redhat.com>:
>> >>
>> >>
>> >>
>> >> On Mon, May 7, 2018 at 11:40 AM, Anastasiya Ruzhanskaya
>> >> <anastasiya.ruzhansk...@frtk.ru> wrote:
>> >>>
>> >>> If the engine user is not accessible directly, why then in this
>> command
>> >>> you use it?:
>> >>>
>> >>>  psql -U engine engine -c "UPDATE vdc_options set option_value =
>> 'false'
>> >>>  WHERE option_name =
>> >>> 'SSLEnabled';"
>> >>>
>> >>> I am not really good in managing databases, I also didn't have
>> postgresql
>> >>> installed after finishing oVirt engine installation and even managing
>> to
>> >>> deploy everything. Does it mean that no database was created at all?
>> I have
>> >>> chosen automatic and local creation in all fields related to database
>> while
>> >>> installing oVirt engine.
>> >>
>> >>
>> >> Can you paste the output of the following command
>> >>
>> >> rpm -qa |grep postgres
>> >>
>> >>
>> >>
>> >>>
>> >>>
>> >>>
>> >>> 2018-05-07 11:00 GMT+03:00 Martin Sivak <msi...@redhat.com>:
>> >>>>
>> >>>> Hi,
>> >>>>
>> >>>> I think what you are looking for is mostly this:
>> >>>> https://github.com/oVirt/vdsm/blob/master/lib/vdsm/api/vdsm-api.yml
>> >>>>
>> >>>> The best way to see what the traffic is is to disable SSL. The
>> >>>> postgres database is installed and accessible using the postgres user
>> >>>> (the engine user is not allowed to access it directly).
>> >>>>
>> >>>> You might also be interested in the vdsm fake project we use as node
>> >>>> simulator. Its readme will tell you exactly how to do this:
>> >>>> https://github.com/oVirt/ovirt-vdsmfake
>> >>>>
>> >>>> I wrote an article some time ago that explained how to setup a
>> >>>> development environment without real hosts:
>> >>>>
>> >>>> https://www.ovirt.org/blog/2016/11/testing-ovirt-changes-wit
>> hout-cluster/
>> >>>>
>> >>>> Might I ask what you goal is?
>> >>>>
>> >>>> Best regards
>> >>>>
>> >>>> --
>> >>>> Martin Sivak
>> >>>> SLA / oVirt
>> >>>>
>> >>>> On Sun, May 6, 2018 at 6:26 AM, Anastasiya Ruzhanskaya
>> >>>> <anastasiya.ruzhansk...@frtk.ru> wrote:
>> >>

Re: [ovirt-devel] oVirt messages from engine to vdsm

[Eli Mesika]

On Mon, May 7, 2018 at 11:40 AM, Anastasiya Ruzhanskaya <
anastasiya.ruzhansk...@frtk.ru> wrote:

> If the engine user is not accessible directly, why then in this command
> you use it?:
>
>  psql -U engine engine -c "UPDATE vdc_options set option_value = 'false'
>  WHERE option_name = 
> 'SSLEnabled';"
>
> I am not really good in managing databases, I also didn't have postgresql
> installed after finishing oVirt engine installation and even managing to
> deploy everything. Does it mean that no database was created at all? I have
> chosen automatic and local creation in all fields related to database while
> installing oVirt engine.
>

​Can you paste the output of the following command

rpm -qa |grep postgres ​




>
>
> 2018-05-07 11:00 GMT+03:00 Martin Sivak :
>
>> Hi,
>>
>> I think what you are looking for is mostly this:
>> https://github.com/oVirt/vdsm/blob/master/lib/vdsm/api/vdsm-api.yml
>>
>> The best way to see what the traffic is is to disable SSL. The
>> postgres database is installed and accessible using the postgres user
>> (the engine user is not allowed to access it directly).
>>
>> You might also be interested in the vdsm fake project we use as node
>> simulator. Its readme will tell you exactly how to do this:
>> https://github.com/oVirt/ovirt-vdsmfake
>>
>> I wrote an article some time ago that explained how to setup a
>> development environment without real hosts:
>> https://www.ovirt.org/blog/2016/11/testing-ovirt-changes-without-cluster/
>>
>> Might I ask what you goal is?
>>
>> Best regards
>>
>> --
>> Martin Sivak
>> SLA / oVirt
>>
>> On Sun, May 6, 2018 at 6:26 AM, Anastasiya Ruzhanskaya
>>  wrote:
>> > Hello everyone!
>> > Currently I want to determine what information is included in messages
>> > passing from oVirt engine to VDSM on ovirt-node.
>> >
>> > I made up a really simple configuration with one VM representing engine,
>> > another - node, a managed to successfully  launch a single VM on this
>> node.
>> > However, I have chosen to configure everything automatically. Currently
>> > traffic is encrypted with default certificates.
>> > So, there are three options for me and no one of them really works.
>> >
>> > 1) Find the format of messages ( what the fields are, session id for
>> > example) in docs, but I didn't  manage to find it;
>> > 2) Use wireshark to decrypt the traffic and the apply maybe a json
>> > -dissector to the decrypted data. I have tried many solutions ( thanks
>> god I
>> > have rsa private and public keys but there is another session key which
>> is
>> > generated every time engine starts to communicate with vdsm, which I
>> cannot
>> > get with the help of sslkeylog file or ld_preload technology.
>> > Maybe someone knows the exact methodology how to do this correctly?
>> >
>> > 3) Turn off ssl in oVirt. It is simple to do that for vdsm, but for
>> engine,
>> > according to answers on oVirt site, I should do 2 requests to the
>> database.
>> > I was really surprised that psql was not installed by oVirt on my
>> system.
>> > How did it then created a default database? ( I have chosen to create
>> all
>> > locally and with default configurations).
>> > I mean these two commands :
>> > https://www.ovirt.org/develop/developer-guide/vdsm/connectin
>> g-development-vdsm-to-engine/
>> > . I have a following error there :
>> > psql: FATAL: Peer authentication failed for user "engine"
>> >
>> > Could you please guide my what method is the best and how should I
>> correct
>> > my faults there?
>> >
>> >
>> > ___
>> > Devel mailing list
>> > Devel@ovirt.org
>> > http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt messages from engine to vdsm

[Eli Mesika]

On Mon, May 7, 2018 at 11:00 AM, Martin Sivak  wrote:

> Hi,
>
> I think what you are looking for is mostly this:
> https://github.com/oVirt/vdsm/blob/master/lib/vdsm/api/vdsm-api.yml
>
> The best way to see what the traffic is is to disable SSL. The
> postgres database is installed and accessible using the postgres user
> (the engine user is not allowed to access it directly).
>
> You might also be interested in the vdsm fake project we use as node
> simulator. Its readme will tell you exactly how to do this:
> https://github.com/oVirt/ovirt-vdsmfake


​I don't think that vdsm fake is aligned to latest master , I have tried to
use it before few months ​and it had lot of problems.
I am afraid that vsm fake is a dead project since AFAIK no maintainer is
updating it or testing it in a regular basis
The last person I know that touched its code an tried to fix it was Roy
Golan, but work is not completed yet





>
>
> I wrote an article some time ago that explained how to setup a
> development environment without real hosts:
> https://www.ovirt.org/blog/2016/11/testing-ovirt-changes-without-cluster/
>
> Might I ask what you goal is?
>
> Best regards
>
> --
> Martin Sivak
> SLA / oVirt
>
> On Sun, May 6, 2018 at 6:26 AM, Anastasiya Ruzhanskaya
>  wrote:
> > Hello everyone!
> > Currently I want to determine what information is included in messages
> > passing from oVirt engine to VDSM on ovirt-node.
> >
> > I made up a really simple configuration with one VM representing engine,
> > another - node, a managed to successfully  launch a single VM on this
> node.
> > However, I have chosen to configure everything automatically. Currently
> > traffic is encrypted with default certificates.
> > So, there are three options for me and no one of them really works.
> >
> > 1) Find the format of messages ( what the fields are, session id for
> > example) in docs, but I didn't  manage to find it;
> > 2) Use wireshark to decrypt the traffic and the apply maybe a json
> > -dissector to the decrypted data. I have tried many solutions ( thanks
> god I
> > have rsa private and public keys but there is another session key which
> is
> > generated every time engine starts to communicate with vdsm, which I
> cannot
> > get with the help of sslkeylog file or ld_preload technology.
> > Maybe someone knows the exact methodology how to do this correctly?
> >
> > 3) Turn off ssl in oVirt. It is simple to do that for vdsm, but for
> engine,
> > according to answers on oVirt site, I should do 2 requests to the
> database.
> > I was really surprised that psql was not installed by oVirt on my system.
> > How did it then created a default database? ( I have chosen to create all
> > locally and with default configurations).
> > I mean these two commands :
> > https://www.ovirt.org/develop/developer-guide/vdsm/
> connecting-development-vdsm-to-engine/
> > . I have a following error there :
> > psql: FATAL: Peer authentication failed for user "engine"
> >
> > Could you please guide my what method is the best and how should I
> correct
> > my faults there?
> >
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Propose Dominik Holler as a Network-Backend Maintainer

[Eli Mesika]

+1

On Tue, May 1, 2018 at 10:54 AM, Alona Kaplan  wrote:

> Hi all,
>
> Dominik Holler has been working on the oVirt project for more than 1.5
> years.
>
> To share some of Dominik's great stats -
> ~ 120 patches related to the network backend/ui
> ~ 95 patches for ovirt-provider-ovn
> ~ 44 vdsm patches
> ~ 80 bug fixes
>
> He was the feature owner of 'auto sync network provider', 'lldp-reporting'
> and 'network-filter-parameters'.
>
> For the last few months Dominik is helping review network-backend related
> patches and is doing a great and thorough work.
> Dominik showed a deep understanding of all the parts of code that he
> touched or reviewed.
> He learns fast, thorough and uncompromising.
>
> I've reviewed most of Dominik's engine related work (code and reviews).
> I trust his opinion and think he will be a good addition to the
> maintainers team.
>
> I would like to propose Dominik as a Network backend maintainer.
>
>
> Thanks,
> Alona.
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [ACTION REQUIRED] upgrade to Fedora 27 for otopi on master

[Eli Mesika]

I have upgraded to fc27
I am not able to add a host to a PPC cluster : "no otopi module ..."

otopi is installed

rpm -qa |grep otopi
otopi-java-1.8.0-0.0.master.20180228112959.git6eccc31.fc27.noarch
otopi-common-1.8.0-0.0.master.20180228112959.git6eccc31.fc27.noarch
python2-otopi-devtools-1.8.0-0.0.master.20180228112959.git6eccc31.fc27.noarch
python2-otopi-1.8.0-0.0.master.20180228112959.git6eccc31.fc27.noarch

Any ideas ?


On Wed, Feb 28, 2018 at 7:01 PM, Greg Sheremeta <gsher...@redhat.com> wrote:

> [changing subject]
>
> Looks like we all have to upgrade Fedora devel machines to Fedora 27.
>
> Greg
>
> On Wed, Feb 28, 2018 at 11:05 AM, Yedidyah Bar David <d...@redhat.com>
> wrote:
>
>> (Adding devel, was asked twice already)
>>
>> On Wed, Feb 28, 2018 at 4:52 PM, Eli Mesika <emes...@redhat.com> wrote:
>> > Hi Didi
>> >
>> > I am getting :
>> >
>> >
>> > ***L:ERROR Internal error: type object 'Stages' has no attribute
>> > 'ANSWER_FILE_GENERATED'
>> > Traceback (most recent call last):
>> >   File "/usr/lib/python2.7/site-packages/otopi/__main__.py", line 88,
>> in
>> > main
>> > installer.execute()
>> >   File "/usr/lib/python2.7/site-packages/otopi/main.py", line 153, in
>> > execute
>> > sys.exc_info()[2],
>> >   File "/usr/lib/python2.7/site-packages/otopi/util.py", line 81, in
>> > raiseExceptionInformation
>> > exec('raise info[1], None, info[2]')
>> >   File "/usr/lib/python2.7/site-packages/otopi/main.py", line 147, in
>> > execute
>> > self.context.loadPlugins()
>> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 859,
>> in
>> > loadPlugins
>> > self._loadPluginGroups(plugindir, needgroups, loadedgroups)
>> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 113,
>> in
>> > _loadPluginGroups
>> > self._loadPlugins(path, path, groupname)
>> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 70, in
>> > _loadPlugins
>> > self._loadPlugins(base, d, groupname)
>> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 70, in
>> > _loadPlugins
>> > self._loadPlugins(base, d, groupname)
>> >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 101,
>> in
>> > _loadPlugins
>> > os.path.basename(path),
>> >   File "/usr/lib/python2.7/site-packages/otopi/util.py", line 105, in
>> > loadModule
>> > mod_desc
>> >   File
>> > "/home/emesika/ovirt-engine-1481197/share/ovirt-engine/setup
>> /bin/../plugins/ovirt-engine-common/base/core/__init__.py",
>> > line 24, in 
>> > from . import answerfile
>> >   File
>> > "/home/emesika/ovirt-engine-1481197/share/ovirt-engine/setup
>> /bin/../plugins/ovirt-engine-common/base/core/answerfile.py",
>> > line 38, in 
>> > class Plugin(plugin.PluginBase):
>> >   File
>> > "/home/emesika/ovirt-engine-1481197/share/ovirt-engine/setup
>> /bin/../plugins/ovirt-engine-common/base/core/answerfile.py",
>> > line 60, in Plugin
>> > otopicons.Stages.ANSWER_FILE_GENERATED,
>> > PluginLoadException: type object 'Stages' has no attribute
>> > 'ANSWER_FILE_GENERATED'
>> >
>>
>> Please update otopi.
>>
>> If you are on fedora, you'll need to upgrade to fc27 first.
>>
>> Good luck,
>> --
>> Didi
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] engine master failing build on fcraw

[Eli Mesika]

May this be related to the PG JDBC driver issue [1]


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1459499 ???

On Fri, Feb 9, 2018 at 2:47 PM, Sandro Bonazzola 
wrote:

> Hi,
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-
> patch-fcraw-x86_64/114/consoleFull
>
> failed on fcraw with:
>
> *10:59:21* Failed tests:   
> org.ovirt.engine.core.dal.dbbroker.DbConnectionUtilTest: Unable to init tests
>
>
> Test output was:
>
> *10:59:11* Running 
> org.ovirt.engine.core.dal.dbbroker.DbConnectionUtilTest*10:59:13* Tests run: 
> 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.296 sec <<< 
> FAILURE!*10:59:13* org.ovirt.engine.core.dal.dbbroker.DbConnectionUtilTest  
> Time elapsed: 2287 sec  <<< FAILURE!*10:59:13* java.lang.AssertionError: 
> Unable to init tests*10:59:13*at 
> org.ovirt.engine.core.dao.BaseDaoTestCase.initTestCase(BaseDaoTestCase.java:84)*10:59:13*
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)*10:59:13*  
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)*10:59:13*
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)*10:59:13*
>   at java.lang.reflect.Method.invoke(Method.java:498)*10:59:13*   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)*10:59:13*
>at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)*10:59:13*
> at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)*10:59:13*
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)*10:59:13*
>   at 
> org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)*10:59:13*
>at 
> org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)*10:59:13*
>  at 
> org.junit.runners.ParentRunner.run(ParentRunner.java:363)*10:59:13*  at 
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)*10:59:13*
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)*10:59:13*
>at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)*10:59:13*
> at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)*10:59:13*
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)*10:59:13*  
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)*10:59:13*
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)*10:59:13*
>   at java.lang.reflect.Method.invoke(Method.java:498)*10:59:13*   at 
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)*10:59:13*
>  at 
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)*10:59:13*
> at 
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)*10:59:13*
>at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)*10:59:13*
> at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)*10:59:13*
>  Caused by: java.lang.NullPointerException*10:59:13*   at 
> org.postgresql.jdbc2.AbstractJdbc2DatabaseMetaData.getColumns(AbstractJdbc2DatabaseMetaData.java:2501)*10:59:13*
>  at 
> org.postgresql.jdbc4.AbstractJdbc4DatabaseMetaData.getColumns(AbstractJdbc4DatabaseMetaData.java:98)*10:59:13*
>at 
> org.dbunit.database.DefaultMetadataHandler.getColumns(DefaultMetadataHandler.java:52)*10:59:13*
>   at 
> org.dbunit.database.DatabaseTableMetaData.getColumns(DatabaseTableMetaData.java:317)*10:59:13*
>at 
> org.dbunit.dataset.AbstractTableMetaData.getColumnIndex(AbstractTableMetaData.java:106)*10:59:13*
> at 
> org.dbunit.operation.AbstractOperation.getOperationMetaData(AbstractOperation.java:89)*10:59:13*
>  at 
> org.dbunit.operation.AbstractBatchOperation.execute(AbstractBatchOperation.java:150)*10:59:13*
>at 
> org.dbunit.operation.CompositeOperation.execute(CompositeOperation.java:79)*10:59:13*
> at 
> org.ovirt.engine.core.dao.BaseDaoTestCase.initTestCase(BaseDaoTestCase.java:66)*10:59:13*
> ... 24 more*10:59:13*
>
>
> I'm disabling again fcraw tests for ovirt-engine, please let me know when
> this issue has been addressed.
>
>
> --
>
> SANDRO BONAZZOLA
>
> ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R
>
> Red Hat EMEA 
> 
> TRIED. TESTED. TRUSTED. 
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [IMPORTANT] getting rid of our implementation of UUID generation in 4.2.1

[Eli Mesika]

Hi Guys

Please note that this patch was merged .
You should follow all steps described in the original email

If you have any questions or problems, please contact me

Eli

On Tue, Dec 12, 2017 at 12:11 PM, Eli Mesika <emes...@redhat.com> wrote:

> Hi
>
> We had decided to drop our UUID generation function from DB in 4.2.1 and
> use the one provided by PG (using an extension)
> Please note that once this patch [1] is merged , you will have to do the
> following steps in your env in order that it will continue working.
>
> 1) make sure that the postgresql-contrib is installed on your machine
> (yum/dnf install postgresql-contrib -y)
> 2) run the following command from psql prompt while logging in with a DB
> admin (postgres) user
>  a) DROP FUNCTION IF EXISTS uuid_generate_v1();
>  b) CREATE EXTENSION "uuid-ossp";'
> 3) validate from psql prompt by :
>
> # select *  from pg_available_extensions where name = 'uuid-ossp' and
> installed_version IS NOT NULL;
>
> You should get the following result
>
> -[ RECORD 1 ]-+
> name  | uuid-ossp
> default_version   | 1.0
> installed_version | 1.0
> comment   | generate universally unique identifiers (UUIDs)
>
> Please contact me for any questions or problems you encounter after this
> patch is merged to master.
>
> [1] https://gerrit.ovirt.org/#/c/84832/
>
>
> Thanks
>
> Eli Mesika
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Fwd: [IMPORTANT] Implementing materialized views

[Eli Mesika]

On Tue, Jul 18, 2017 at 8:56 AM, Yedidyah Bar David <d...@redhat.com> wrote:

> On Tue, Jul 18, 2017 at 1:29 AM, Martin Perina <mper...@redhat.com> wrote:
> > Hello,
> >
> > to make things completely clear: any developer which will perform any
> > changes around permissions tables need to use only predefined stored
> > procedures for permissions handling. If for some reason direct SQL
> update is
> > performed, then materialized view will not be refreshed until some
> > permission stored procedure is called, which could cause strange results.
>
> Isn't it possible to prevent such accidents somehow?
>
> E.g., is it possible that:
> 1. We rename current table ("permissions") to some "private"
> name (e.g. "permissions_tab")
>
​This is possible ​



> 2. We create the materialized view having the name of the
> original table ("permissions")
>

​The MV replaces the views that uses the permissions table.
The plan is to rename the original view to something else and have the
created MV with the original view name



> 3. We do what's needed (?) so that direct inserts/updates/deletes
> on the view either fail or do the right thing.
>

​See my answer in 1)
​


>
> >
> > Eli has already removed all such code within patch [3], so this is just a
> > warning for future.
> >
> > Thanks
> >
> > Martin
> >
> >
> > On Mon, Jul 17, 2017 at 9:47 PM, Eli Mesika <emes...@redhat.com> wrote:
> >>
> >>
> >> Materialized Views [1] can be used to reduce query time on complex
> queries
> >> with low data update
> >>
> >> The first candidates to use this feature are all the *permission* views
> >>
> >> There is already a RFE [2] opened for that.
> >>
> >> Please make sure that each call that handles the permissions table data
> is
> >> using the corresponding SP in dbscripts/multi_level_administration.sql
> >> No direct access to the permissions table is allowed !
> >>
> >> In case that a direct access to the permissions table is used, you
> should
> >> replace the code in a call to the corresponding SP as you can see in [3]
> >>
> >> A direct use that will not be replaced with a call to the corresponding
> SP
> >> may cause that direct changes to the permissions table will not be
> reflected
> >> in the
> >> *permission* Materialized Views and the views will remain dirty until a
> >> change that is calling one of the SPs that handle the data of the
> >> permissions table is issued and cause the Materialized Views to be
> refreshed
> >>
> >> Please check your code for direct use of the permissions table and
> consult
> >> with me if you have any questions or issues.
> >>
> >> Thanks
> >>
> >> Eli Mesika
> >>
> >> [1] https://wiki.postgresql.org/wiki/Materialized_Views
> >> [2] https://bugzilla.redhat.com/show_bug.cgi?id=1470991
> >> [3] https://gerrit.ovirt.org/#/c/79287/
> >>
> >>
> >> ___
> >> Devel mailing list
> >> Devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/devel
> >
> >
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
> --
> Didi
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Fwd: [IMPORTANT] Implementing materialized views

[Eli Mesika]

Materialized Views [1] can be used to reduce query time on complex queries
with low data update

The first candidates to use this feature are all the *permission* views

There is already a RFE [2] opened for that.

Please make sure that each call that handles the permissions table data is
using the corresponding SP in dbscripts/multi_level_administration.sql
No direct access to the permissions table is allowed !

In case that a direct access to the permissions table is used, you should
replace the code in a call to the corresponding SP as you can see in [3]

A direct use that will not be replaced with a call to the corresponding SP
may cause that direct changes to the permissions table will not be
reflected in the
*permission* Materialized Views and the views will remain dirty until a
change that is calling one of the SPs that handle the data of the
permissions table is issued and cause the Materialized Views to be
refreshed

Please check your code for direct use of the permissions table and consult
with me if you have any questions or issues.

Thanks

Eli Mesika

[1] https://wiki.postgresql.org/wiki/Materialized_Views
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1470991
[3] https://gerrit.ovirt.org/#/c/79287/
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Subject: [ OST Failure Report ] [ oVirt master ] [ 24-04-2017 ] [import_template_from_glance]

[Eli Mesika]

The fix for that regression was merged to master, please sync and check
again

On Tue, Apr 25, 2017 at 5:14 PM, Eli Mesika <emes...@redhat.com> wrote:

> Hi
>
> Please review the fixing patch
> https://gerrit.ovirt.org/#/c/76013/2
>
> On Tue, Apr 25, 2017 at 3:00 PM, Fred Rolland <froll...@redhat.com> wrote:
>
>> Eli hi,
>>
>> It seems there is some issue in the squash patch [1].
>>
>> Regarding the issue found by the OST, if you start from a fresh DB, wrong
>> values will be inserted in the "spec_params" column in the vm_device table.
>> [2]
>> We will get '58ca7b19-0071-00c0-01d6-0212' instead of a map like
>> { "vram" : "65536" }
>>
>> It will fail the creation of the AddVmTemplateCommand that we see in the
>> log.
>>
>> Regards,
>>
>> Freddy
>>
>> [1] https://gerrit.ovirt.org/#/c/74382/
>> [2] https://gerrit.ovirt.org/#/c/74382/8/packaging/dbscripts/dat
>> a/01200_insert_vm_device.sql
>>
>> On Tue, Apr 25, 2017 at 12:13 PM, Fred Rolland <froll...@redhat.com>
>> wrote:
>>
>>> Looking at it
>>>
>>> On Tue, Apr 25, 2017 at 12:11 AM, Nadav Goldin <ngol...@redhat.com>
>>> wrote:
>>>
>>>> Test failed: add_secondary_storage_domains/import_template_from_glance
>>>>
>>>> Link to suspected patches: https://gerrit.ovirt.org/#/c/74382/
>>>>
>>>> Link to Job: http://jenkins.ovirt.org/job/t
>>>> est-repo_ovirt_experimental_master/6456/
>>>> (started in 6451)
>>>>
>>>> Link to all logs:
>>>> http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_ma
>>>> ster/6456/artifact/exported-artifacts/basic-suit-master-el7/
>>>> test_logs/basic-suite-master/post-002_bootstrap.py/
>>>>
>>>> Engine log: http://jenkins.ovirt.org/job/t
>>>> est-repo_ovirt_experimental_master/6456/artifact/exported-ar
>>>> tifacts/basic-suit-master-el7/test_logs/basic-suite-master/p
>>>> ost-002_bootstrap.py/lago-basic-suite-master-engine/_var_log
>>>> /ovirt-engine/engine.log
>>>>
>>>> Error snippet from the test log:
>>>>
>>>> 
>>>>
>>>> lago.utils: ERROR: Error while running thread
>>>> Traceback (most recent call last):
>>>>   File "/usr/lib/python2.7/site-packages/lago/utils.py", line 58, in
>>>> _ret_via_queue
>>>> queue.put({'return': func()})
>>>>   File "/home/jenkins/workspace/test-repo_ovirt_experimental_master
>>>> /ovirt-system-tests/basic-suite-master/test-scenarios/002_bo
>>>> otstrap.py",
>>>> line 803, in import_template_from_glance
>>>> generic_import_from_glance(api, image_name=CIRROS_IMAGE_NAME,
>>>> image_ext='_glance_template', as_template=True)
>>>>   File "/home/jenkins/workspace/test-repo_ovirt_experimental_master
>>>> /ovirt-system-tests/basic-suite-master/test-scenarios/002_bo
>>>> otstrap.py",
>>>> line 641, in generic_import_from_glance
>>>> lambda: api.disks.get(disk_name).status.state == 'ok',
>>>>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>>> 264, in assert_true_within_long
>>>> assert_equals_within_long(func, True, allowed_exceptions)
>>>>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>>> 251, in assert_equals_within_long
>>>> func, value, LONG_TIMEOUT, allowed_exceptions=allowed_exceptions
>>>>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>>> 230, in assert_equals_within
>>>> '%s != %s after %s seconds' % (res, value, timeout)
>>>> AssertionError: False != True after 600 seconds
>>>>
>>>>
>>>> 
>>>>
>>>>
>>>> the engine.log has this sequence repeating(apparently at the end of
>>>> the task - 199ed356):
>>>>
>>>> 2017-04-24 13:34:50,079-04 INFO
>>>> [org.ovirt.engine.core.bll.storage.repoimage.ImportRepoImageCommand]
>>>> (DefaultQuartzScheduler10) [199ed356-0960-4ef4-9637-09c76a07c932]
>>>> Ending command 'org.ovirt.engine.core.bll.sto
>>>> rage.repoimage.ImportRepoImageCommand'
>>>> successfully.
>>>> 2017-04-24 13:34:50,090-04 ERROR
>>>> [org.ovirt.engine.core.bll.CommandsFactory] (DefaultQ

Re: [ovirt-devel] Subject: [ OST Failure Report ] [ oVirt master ] [ 24-04-2017 ] [import_template_from_glance]

[Eli Mesika]

Hi

Please review the fixing patch
https://gerrit.ovirt.org/#/c/76013/2

On Tue, Apr 25, 2017 at 3:00 PM, Fred Rolland  wrote:

> Eli hi,
>
> It seems there is some issue in the squash patch [1].
>
> Regarding the issue found by the OST, if you start from a fresh DB, wrong
> values will be inserted in the "spec_params" column in the vm_device table.
> [2]
> We will get '58ca7b19-0071-00c0-01d6-0212' instead of a map like
> { "vram" : "65536" }
>
> It will fail the creation of the AddVmTemplateCommand that we see in the
> log.
>
> Regards,
>
> Freddy
>
> [1] https://gerrit.ovirt.org/#/c/74382/
> [2] https://gerrit.ovirt.org/#/c/74382/8/packaging/dbscripts/
> data/01200_insert_vm_device.sql
>
> On Tue, Apr 25, 2017 at 12:13 PM, Fred Rolland 
> wrote:
>
>> Looking at it
>>
>> On Tue, Apr 25, 2017 at 12:11 AM, Nadav Goldin 
>> wrote:
>>
>>> Test failed: add_secondary_storage_domains/import_template_from_glance
>>>
>>> Link to suspected patches: https://gerrit.ovirt.org/#/c/74382/
>>>
>>> Link to Job: http://jenkins.ovirt.org/job/t
>>> est-repo_ovirt_experimental_master/6456/
>>> (started in 6451)
>>>
>>> Link to all logs:
>>> http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_ma
>>> ster/6456/artifact/exported-artifacts/basic-suit-master-el7/
>>> test_logs/basic-suite-master/post-002_bootstrap.py/
>>>
>>> Engine log: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_ma
>>> ster/6456/artifact/exported-artifacts/basic-suit-master-el7/
>>> test_logs/basic-suite-master/post-002_bootstrap.py/lago-basi
>>> c-suite-master-engine/_var_log/ovirt-engine/engine.log
>>>
>>> Error snippet from the test log:
>>>
>>> 
>>>
>>> lago.utils: ERROR: Error while running thread
>>> Traceback (most recent call last):
>>>   File "/usr/lib/python2.7/site-packages/lago/utils.py", line 58, in
>>> _ret_via_queue
>>> queue.put({'return': func()})
>>>   File "/home/jenkins/workspace/test-repo_ovirt_experimental_master
>>> /ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py",
>>> line 803, in import_template_from_glance
>>> generic_import_from_glance(api, image_name=CIRROS_IMAGE_NAME,
>>> image_ext='_glance_template', as_template=True)
>>>   File "/home/jenkins/workspace/test-repo_ovirt_experimental_master
>>> /ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py",
>>> line 641, in generic_import_from_glance
>>> lambda: api.disks.get(disk_name).status.state == 'ok',
>>>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>> 264, in assert_true_within_long
>>> assert_equals_within_long(func, True, allowed_exceptions)
>>>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>> 251, in assert_equals_within_long
>>> func, value, LONG_TIMEOUT, allowed_exceptions=allowed_exceptions
>>>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
>>> 230, in assert_equals_within
>>> '%s != %s after %s seconds' % (res, value, timeout)
>>> AssertionError: False != True after 600 seconds
>>>
>>>
>>> 
>>>
>>>
>>> the engine.log has this sequence repeating(apparently at the end of
>>> the task - 199ed356):
>>>
>>> 2017-04-24 13:34:50,079-04 INFO
>>> [org.ovirt.engine.core.bll.storage.repoimage.ImportRepoImageCommand]
>>> (DefaultQuartzScheduler10) [199ed356-0960-4ef4-9637-09c76a07c932]
>>> Ending command 'org.ovirt.engine.core.bll.sto
>>> rage.repoimage.ImportRepoImageCommand'
>>> successfully.
>>> 2017-04-24 13:34:50,090-04 ERROR
>>> [org.ovirt.engine.core.bll.CommandsFactory] (DefaultQuartzScheduler10)
>>> [] An exception has occurred while trying to create a command object
>>> for command 'AddVmTemplate' with parameters
>>> 'AddVmTemplateParameters:{commandId='a6d45092-dfe0-4a65-bdc4
>>> -4c23a68fe7d5',
>>> user='admin', commandType='Unknown'}': WELD-49: Unable to invoke
>>> protected final void
>>> org.ovirt.engine.core.bll.CommandBase.postConstruct() on
>>> org.ovirt.engine.core.bll.AddVmTemplateCommand@35c1cbd5
>>> 2017-04-24 13:34:50,095-04 INFO
>>> [org.ovirt.engine.core.utils.transaction.TransactionSupport]
>>> (DefaultQuartzScheduler10) [] transaction rolled back
>>> 2017-04-24 13:34:50,123-04 INFO
>>> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
>>> (DefaultQuartzScheduler10) [] EVENT_ID:
>>> USER_IMPORT_IMAGE_AS_TEMPLATE_FINISHED_SUCCESS(3,018), Correlation ID:
>>> 199ed356-0960-4ef4-9637-09c76a07c932, Job ID:
>>> 0b91fec3-97be-493f-9dfb-af1230e4d3ee, Call Stack: null, Custom Event
>>> ID: -1, Message: User admin@internal-authz successfully imported image
>>> CirrOS_0.3.4_for_x86_64_glance_template as template
>>> CirrOS_0.3.4_for_x86_64_glance_template to domain iscsi.
>>> 2017-04-24 13:34:50,123-04 ERROR
>>> [org.ovirt.engine.core.bll.tasks.CommandCallbacksPoller]
>>> (DefaultQuartzScheduler10) [] Failed invoking callback end method
>>> 'onSucceeded' for command '25028c51-d877-44e3-b1ef-40b315b469d3' with
>>> exception 

Re: [ovirt-devel] Writing SQL queries in DAO code

[Eli Mesika]

On Wed, Mar 29, 2017 at 4:23 PM, Martin Mucha <mmu...@redhat.com> wrote:

> Hi,
>
> I didn't want to step into this, but I was asked by dan to express my
> opinion about this. I'm not pushing for change (since I believe it will be
> blocked), I'm just trying to help us focus. We should have some questions
> answered prior to saying what we want to do...
>
> Current state of accessing db is that there's fired lots of unnecessary db
> calls, just because there isn't easy way to do them correctly, someone is
> lazy, whatever, that isn't important. The blame was laid on invalid code
> review. Now let me remember maintainer Kolesnik, who during CR *insisted*
> on creating N+1 problem[1] when accessing db, to save ±10 lines of code in
> dal layer. So Eli is right, our code suck because of improper code revision
> process, but sometimes it is maintainers who wants invalid code to be
> pushed to simplify db access code. Therefore we cannot rely on review
> process, this is real issue we have. I'm fine with it, this is how we do
> things. But we also have (sometimes (a lot)) degraded performance because
> of it.
>
> We should have answered following questions:
>
> 1) is performance even important at all? Should we optimize db access? I'm
> assuming "yes" should be the answer. If it's not the answer, we can skip
> next questions.
>
> 2) can someone responsible for whole project provide timings and count of
> queries? This should easily bring crosshair on commands requiring attention.
>   2.1) customer is issuing synchronous command. What is maximum number of
> queries this command (plus all transitive internal commands) should fire?
> What's the number for asynchronous command?
>   2.2) same for time; what is the maximum time for synchronous and
> asynchronous command?
>
> 3) lets say that we found command which requires optimization (and that
> should not be hard). If we go back to mentioned N+1 problem, it's rather
> easy to avoid it for one association(yet we did not do it even there), but
> it's not that easy for multiple joins [1]. But it's superbly easy to
> achieve it using ORM tool, even with still using only named queries, even
> native ones defined outside of java. Supposing we want to optimize found
> command, what would dal maintainers consider as a acceptable optimization?
> Is there even possibility to not use stored procedures? I believe saying
> simple "no", if that's the case, is valid response, which can save time. If
> there is theoretical possibility, what criteria must be met so that we can
> consider replacing most trivial stored procedures with some tool in our
> project? There are lots of tools/frameworks, based on your criteria we
> might find some, which would work best...
>
> —
>
> My generic opinion would be to stick with sp and allowing to use something
> less heavy for simplest queries/stuff. It could beJPA using ORM and
> entities. Or named queries (still using entities) or nativequeries (which
> does not use entities, but plain sql) and both ends up creating prepared
> statements on server startup. Or we could use some lighter orm. But I'd
> definitely avoid writing any new homebrewed approach, this isn't a sane
> option.
>

​In that case , if we will not use SP , we still will have to secure the
data (for example , hidden columns for some users like in the VDS view)​


>
> [1] example: Lets discuss query association A—>B—>C, 5xA, each A has 5B
> etc. In our typical dao this will mean 1+5+5*5=31 queries. Same with
> properly annotated ORM sums up to 1 or 3 queries.
>
>
> M.
>
> On Mon, Mar 27, 2017 at 5:38 PM, Yevgeny Zaspitsky <yzasp...@redhat.com>
> wrote:
>
>>
>>
>> On Mon, Mar 27, 2017 at 5:30 PM, Yevgeny Zaspitsky <yzasp...@redhat.com>
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 27, 2017 at 12:45 PM, Eli Mesika <emes...@redhat.com> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Mar 27, 2017 at 12:26 PM, Yevgeny Zaspitsky <
>>>> yzasp...@redhat.com> wrote:
>>>>
>>>>> > I don't think that looking in SQL in Java code is ​clear than
>>>>> looking in a SP code
>>>>>
>>>>> Looking in SQL isn't the problem I'm trying to solve, but finding that.
>>>>>
>>>>> > 1) You will pass more data on the wire instead of calling a SP with
>>>>> parameters
>>>>>
>>>>> Passing the SQL string shouldn't be a problem unless that is very long
>>>>> one (several K) and then we probably do something wrong.
>>>>>
>>>>> > 2) Your data that is passed on the

Re: [ovirt-devel] Writing SQL queries in DAO code

[Eli Mesika]

On Mon, Mar 27, 2017 at 12:26 PM, Yevgeny Zaspitsky <yzasp...@redhat.com>
wrote:

> > I don't think that looking in SQL in Java code is ​clear than looking in
> a SP code
>
> Looking in SQL isn't the problem I'm trying to solve, but finding that.
>
> > 1) You will pass more data on the wire instead of calling a SP with
> parameters
>
> Passing the SQL string shouldn't be a problem unless that is very long one
> (several K) and then we probably do something wrong.
>
> > 2) Your data that is passed on the wire is exposed to attacks since you
> will have to implement DB security in the engine level (for example hidden
> columns).
>
> IIUC currently querying tables/views with hidden columns is implemented in
> a SP that consist of at least 2 SQL's, so those aren't good candidates for
> my proposal and will stay as is.
> BTW how other projects resolve the security problem? AFAIK usually hidden
> columns are hidden by defining a proper view that do not include those.
>

​That's a bad solution as long as your data is passed unmasked on the wire ​
Database security should be done in the database level and you will not be
able to do that without using SPs



>
> > 3) Changes in the SQL code done in patches may be more complicated to
> track
>
> Most of SQL code changes involve changes in a DAO too, so this shouldn't
> be an issue.
>
​It is !!! , changes in DAO are easy to track since it is a Java code , you
are suggesting to write the SQL itself ​


>
> > 4) SQL Injection
>
> Again, how other projects resolve the security problem? Internet is full
> of articles/blogs of why stored procedures should be avoided ("avoid
> ​​
> stored procedures" Google query returned ~6.6M results), so I guess there
> are some other approaches for the security issue if that exists.
>

​"use stored procedures" Google query returned About 4,840,000 results ​



>
> > 5) I think that SP performs better than SQL inside Java
>
> Do we have a measurement of how much better?
> One of my intentions for this proposal is that people evidently avoid
> creating neat SQL queries and re-use the existing ones, which has much
> bigger performance impact. I guess that the biggest limit here is how
> complicated that procedure is in the engine code.
>

​That's why we have code review process and we should nack such ​patches ,
so you think that if people are not familiar with Java8 syntax for example
we should move this code to be performed by a "easier" mechanism ?
If people are not doing the right thing , we have gerrit for that, we can
comment , nack , whatever to make the code good



>
>
> On Mon, Mar 27, 2017 at 11:09 AM, Eli Mesika <emes...@redhat.com> wrote:
>
>>
>>
>> On Mon, Mar 27, 2017 at 1:56 AM, Moti Asayag <masa...@redhat.com> wrote:
>>
>>>
>>>
>>> On Sun, Mar 26, 2017 at 5:12 PM, Yevgeny Zaspitsky <yzasp...@redhat.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Recently I had a task of performance improvement in one of our network
>>>> related flows and had some hard time following our DAL code and one of the
>>>> outcomes of the task was defining a couple of new quite simple, but neat
>>>> queries.
>>>> When I came to coding those new queries I remembered how hard was
>>>> following the existing DAL code, I decided to make my own new methods
>>>> clearer. So I created [1] and [2] patches.
>>>>
>>>> Everything is quite standard there beside the fact that they do not use
>>>> any stored procedure, but use SQL directly, IMHO by that they save time
>>>> that I spent in trying to follow what a DAO method does. Looking into the
>>>> method code you get the understanding of what this method is all about:
>>>>
>>>>- no looking for a stored procedure name that is buried in the DAO
>>>>class hierarchy
>>>>- no looking for the SP definition
>>>>
>>>>
>>> There are additional pros and cons for the suggestion to consider:
>>>
>>> Pros:
>>>
>>>1. No need to run engine-setup after changing DB related code (in
>>>case of SQL inside Java).
>>>
>>> Cons:
>>>
>>>1. DAO files might become very long.
>>>2. If you decide to return the business entity associated with the
>>>DAO as a returned object, you won't know as a caller which fields to 
>>> expect
>>>to be populated, which lead to 3:
>>>3. An inflation of business entities to represent partial populate

Re: [ovirt-devel] Writing SQL queries in DAO code

[Eli Mesika]

On Mon, Mar 27, 2017 at 1:56 AM, Moti Asayag  wrote:

>
>
> On Sun, Mar 26, 2017 at 5:12 PM, Yevgeny Zaspitsky 
> wrote:
>
>> Hi All,
>>
>> Recently I had a task of performance improvement in one of our network
>> related flows and had some hard time following our DAL code and one of the
>> outcomes of the task was defining a couple of new quite simple, but neat
>> queries.
>> When I came to coding those new queries I remembered how hard was
>> following the existing DAL code, I decided to make my own new methods
>> clearer. So I created [1] and [2] patches.
>>
>> Everything is quite standard there beside the fact that they do not use
>> any stored procedure, but use SQL directly, IMHO by that they save time
>> that I spent in trying to follow what a DAO method does. Looking into the
>> method code you get the understanding of what this method is all about:
>>
>>- no looking for a stored procedure name that is buried in the DAO
>>class hierarchy
>>- no looking for the SP definition
>>
>>
> There are additional pros and cons for the suggestion to consider:
>
> Pros:
>
>1. No need to run engine-setup after changing DB related code (in case
>of SQL inside Java).
>
> Cons:
>
>1. DAO files might become very long.
>2. If you decide to return the business entity associated with the DAO
>as a returned object, you won't know as a caller which fields to expect to
>be populated, which lead to 3:
>3. An inflation of business entities to represent partial populated
>business entity or inflation of mappers inflation (this will be required
>for SP as well).
>4. SQL code inside of Java:
>1. Beside of the fact that a multi-line concatenated string that
>   cannot be easily copied and run with psql, it means that we should 
> compile
>   the code in order to test the change (vs building with DEV_REBUILD=0 
> which
>   only package the SQL file).
>   2. No syntax highlighting when performing code review. i.e. I don't
>   think reviewing a patch such as https://gerrit.ovirt.org/#/c/
>   66729/10/packaging/dbscripts/network_sp.sql
>   
> 
>   would be more clear inside a java file.
>   3. The user permissions management is implemented on DB level. That
>   means that SQL will be more complex (more concatenated java lines).
>5. Stored procedure are cached by project's code. See
>SimpleJdbcCallsHandler.getCall(), while the NamedParameterJdbcTemplate
>are cached by spring's code which seems less optimal (sync all calls using
>synchronized vs using ConcurrentHashMap as in SP cache).
>6. With the NamedParametersJdbcTemplate there is no use of the
>DbEngineDialect. What's the impact of it ?
>
> So besides 5 and 6, the rest is a matter of style. I'd like to hear more
> opinions from other members.
>

​I agree with all you wrote Moti
I don't think that looking in SQL in Java code is ​clear than looking in a
SP code
Additionally
1) You will pass more data on the wire instead of calling a SP with
parameters
2) Your data that is passed on the wire is exposed to attacks since you
will have to implement DB security in the engine level (for example hidden
columns)
3) Changes in the SQL code done in patches may be more complicated to track
4) SQL Injection
5) I think that SP performs better than SQL inside Java

I see no real reason to replace the SPs with SQL code , SP is just a
container for SQL code



>
> Regards,
> Moti
>
> So I'd like to propose moving towards this approach in general in all
>> cases when nothing beyond a simple SQL is needed (no stored procedure
>> programming language is needed).
>> From my experience with the performance improvement task it looks like
>> people avoid adding new queries for a specific need of a flow, instead they
>> use the existing general ones (e.g. dao.getAllForX()) and do the actual
>> join in the bll code.
>> IMHO the proposed approach would simplify adding new specific queries and
>> by that would prevent a decent part of performance issues in the future.
>>
>> I do not propose changing all existing SP's to inline queries in a once,
>> but to allow adding new queries this way. Also we might consider converting
>> relatively simple SP's to inline SQL statements later in a graduate way.
>>
>> [1] - https://gerrit.ovirt.org/#/c/74456
>> [2] - https://gerrit.ovirt.org/#/c/74458
>>
>> Regards,
>> Yevgeny
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
> --
> Regards,
> Moti
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Alternatives to automatically move bugs to MODIFIED

[Eli Mesika]

I also got this, especially when bugs should be back-ported
+1 for option #1

On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David 
wrote:

> Hi all,
>
> We currently have a bot that automatically moves bugs from POST to MODIFIED
> if all linked patches on gerrit are merged.
>
> It happened to me personally several times that this was a wrong thing to
> do,
> either because a new patch was still needed but not pushed yet, or because
> an existing patch should have been back-ported to another branch and wasn't
> yet. Since I usually pay more attention to my bug in POST, I sometimes
> missed
> this and handled the missing patches (backports, usually) later than I
> could
> if left on POST.
>
> I have a feeling I am not the only one. So I suggest to stop doing this.
>
> I can think of several alternatives:
>
> 1. Do nothing. I think that's reasonable - I think most people pay more
> attention to POST bugs anyway.
>
> 2. Set needinfo on bug owner.
>
> 3. Send some alert email to relevant people (bug owner, existing patches
> owners,
> perhaps others - e.g. reviewers of existing patches, perhaps those
> that actually reviewed, etc.). Need to think how to make it not too
> annoying for others but
> still effective also if owner is on long PTO or something like that. New
> flag
> doesn't have to be very specific - can be called something like 'attention
> needed' or something like that.
>
> 4. Add a new flag for that and set it. This will allow easier
> filtering/reporting.
>
> What do you think?
> --
> Didi
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] uuid_generate_v1 not random enough (was: Change in ovirt-engine[ovirt-engine-4.0.2]: build: ovirt-engine-4.0.2.3)

[Eli Mesika]

Generating the UUIDs outside the database is not possible always , for
example it is not possible when you install the DBV with initial data 
so , in any case we need this support inside the database engine

On Mon, Aug 1, 2016 at 4:16 PM, Juan Hernández  wrote:

> On 08/01/2016 11:02 AM, Yedidyah Bar David wrote:
> > On Sun, Jul 31, 2016 at 6:35 PM, Jenkins CI 
> wrote:
> >> Jenkins CI has posted comments on this change.
> >>
> >> Change subject: build: ovirt-engine-4.0.2.3
> >> ..
> >>
> >>
> >> Patch Set 2:
> >>
> >> Build Failed
> >>
> >>
> http://jenkins.ovirt.org/job/ovirt-engine_4.0.2_check-merged-el7-x86_64/64/
> : FAILURE
> >
> > 15:07:43 Running upgrade sql script
> >
> './packaging/dbscripts/upgrade/03_05_0580_add_default_instance_types.sql'...
> > 15:07:43
> psql:./packaging/dbscripts/upgrade/03_05_0580_add_default_instance_types.sql:131:
> > ERROR:  duplicate key value violates unique constraint
> > "pk_permissions_id"
> > 15:07:43 DETAIL:  Key (id)=() already exists.
> >
> > Didn't try reproducing, but my best guess is that above uuid
> > was generated by a call to uuid_generate_v1() in above file after it
> > was already inserted to the table in
> > dbscripts/data/00600_insert_permissions.sql.
> >
> > Perhaps we should be using something more random.
> >
> > [1] https://www.postgresql.org/docs/9.5/static/uuid-ossp.html
> >
>
> Note that we did use that long time ago, and we decided to stop using it
> because enabling that extension required an additional RPM package
> (postgrersql-contrib) and different mechanisms to enable it in
> PostgreSQL 8 and PostgreSQL 9, which was cumbersome. As we should now
> support only PostgreSQL 9.2 or newer, this may be no longer a problem.
> In that case you can just remove our "uuid_generate_v1" function and
> enable the extension, the name of the function is the same.
>
> However, it would be better, in general, to generate the identifiers
> outside of the database, and pass them as parameters to the stored
> procedures or SQL statements, that way we have less dependencies.
>
> See bug 870056 for additional information.
>
> >>
> >>
> http://jenkins.ovirt.org/job/ovirt-engine_4.0.2_check-merged-fc23-x86_64/64/
> : SUCCESS
> >>
> >> --
> >> To view, visit https://gerrit.ovirt.org/61733
> >> To unsubscribe, visit https://gerrit.ovirt.org/settings
> >>
> >> Gerrit-MessageType: comment
> >> Gerrit-Change-Id: Ice9518eea22dfa19126e04e49f3a76ee86f3e3c0
> >> Gerrit-PatchSet: 2
> >> Gerrit-Project: ovirt-engine
> >> Gerrit-Branch: ovirt-engine-4.0.2
> >> Gerrit-Owner: Yedidyah Bar David 
> >> Gerrit-Reviewer: Eyal Edri 
> >> Gerrit-Reviewer: Jenkins CI
> >> Gerrit-Reviewer: Oved Ourfali 
> >> Gerrit-Reviewer: Yedidyah Bar David 
> >> Gerrit-Reviewer: gerrit-hooks 
> >> Gerrit-HasComments: No
> >
> >
> >
>
>
> --
> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
> 3ºD, 28016 Madrid, Spain
> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] column c.mac_pool_id does not exist (was: Change in ovirt-engine[master]: packaging: setup: Always update ovirt-engine-dashboard)

[Eli Mesika]

Hi
Once this [1] is merged , I will send email to all to start using 04_01
prefix on master

[1] https://gerrit.ovirt.org/#/c/59231/

On Sun, Jun 19, 2016 at 4:19 PM, Yedidyah Bar David  wrote:

> On Thu, Jun 9, 2016 at 10:42 PM, Martin Perina  wrote:
> > Hi,
> >
> > here's patch that should fix 4.0 -> master upgrade issue for now:
> >
> > https://gerrit.ovirt.org/58936
>
> Still broken with same issue - cluster table has no col mac_pool_id.
>
> Current status is:
>
> master branch has: 04_00_0750_add_mac_pool_id_to_vds_group.sql
> 4.0 branch does not have this file, nor another with same content.
> However, it does have: 04_00_0750_change_cluster_default_policy.sql
>
> So on 4.0 setup, this file is ran, and this fact is saved in the db.
>
> On upgrade to master, the function _dbfunc_common_schema_upgrade
> loops over all upgrade scripts, but ignores those with lower version
> than "current" (last script processed, supposedly in a previous run).
> Pushed a patch [1] to show them. In the logs of current failure [2],
> "current" was probably 0750 - guessing this from the setup log, which
> has:
>
> Dropping materialized views...
> Running upgrade sql script
>
> '/usr/share/ovirt-engine/dbscripts/upgrade/04_00_0760_empty_current_cd_to_null.sql'...
>
> So 0750 was never ran.
>
> Not sure what's the best fix:
> 1. Stop pushing to master scripts with 04_00, start using 04_01
> 2. In master, rename 04_00_0810_change_cluster_default_policy.sql
> to 04_00_0750_change_cluster_default_policy.sql , which is the
> last one in 4.0 (all till 0750 seem ok, following Martin's previous
> rename patches).
> 3. In master, rename these to have 04_01 prefix:
> 04_00_0750_add_mac_pool_id_to_vds_group.sql
> 04_00_0760_empty_current_cd_to_null.sql
> 04_00_0770_remove_mac_pool_id_from_storage_pool.sql
> 04_00_0780_move_guest_mem_fields_to_statistics.sql
> 04_00_0790_remove_el7_upgrade_policy_units.sql
> 04_00_0800_add_switch_type_to_vds_interface_and_cluster.sql
> 4. Do something that will prevent such things in the future, not sure what.
>
> [1] https://gerrit.ovirt.org/59441
> [2]
> http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-4.0_el7_merged/243/
>
> >
> >
> > Martin
> >
> >
> > On Thu, Jun 9, 2016 at 5:04 PM, Martin Perina 
> wrote:
> >>
> >> It seems to me, that our 4.0 upgrade scripts in master and
> >> ovirt-engine-4.0 are not in sync again. I will investigate and post a
> new
> >> fix for that.
> >>
> >> This issue will be definitely fixed next week, when Eli posts a patch
> >> bumping database version to 4.1 on master branch.
> >>
> >> Martin
> >>
> >>
> >> On Thu, Jun 9, 2016 at 4:59 PM, Yedidyah Bar David 
> >> wrote:
> >>>
> >>> On Thu, Jun 9, 2016 at 5:38 PM, Jenkins CI 
> >>> wrote:
> >>> > Jenkins CI has posted comments on this change.
> >>> >
> >>> > Change subject: packaging: setup: Always update
> ovirt-engine-dashboard
> >>> >
> ..
> >>> >
> >>> >
> >>> > Patch Set 3:
> >>> >
> >>> > Build Failed
> >>> >
> >>> >
> >>> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-4.0_el7_merged/150/
> >>> > : FAILURE
> >>>
> >>> In server.log:
> >>>
> >>> Caused by: org.postgresql.util.PSQLException: ERROR: column
> >>> c.mac_pool_id does not exist
> >>>
> >>> It seems like it was supposed to be fixed by:
> >>>
> >>> https://gerrit.ovirt.org/58604
> >>>
> >>> In ovirt-engine-setup-20160609142049-s4dyhe.log I see:
> >>>
> >>> Skipping upgrade script
> >>>
> >>>
> /usr/share/ovirt-engine/dbscripts/upgrade/04_00_0770_remove_filter_from_passthrough_vnics.sql,
> >>> already installed by 04000730
> >>>
> >>> And I see no mention of 0720 anywhere there.
> >>>
> >>> Adding also Eli.
> >>>
> >>> >
> >>> >
> >>> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/600/
> >>> > : SUCCESS
> >>> >
> >>> >
> >>> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-fc23-x86_64/600/
> >>> > : SUCCESS
> >>> >
> >>> >
> >>> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/615/
> >>> > : SUCCESS
> >>> >
> >>> > --
> >>> > To view, visit https://gerrit.ovirt.org/58629
> >>> > To unsubscribe, visit https://gerrit.ovirt.org/settings
> >>> >
> >>> > Gerrit-MessageType: comment
> >>> > Gerrit-Change-Id: I21d9bc56278c720ddfc26b00f8bb64932fbab465
> >>> > Gerrit-PatchSet: 3
> >>> > Gerrit-Project: ovirt-engine
> >>> > Gerrit-Branch: master
> >>> > Gerrit-Owner: Yedidyah Bar David 
> >>> > Gerrit-Reviewer: Jenkins CI
> >>> > Gerrit-Reviewer: Martin Peřina 
> >>> > Gerrit-Reviewer: Simone Tiraboschi 
> >>> > Gerrit-Reviewer: Yedidyah Bar David 
> >>> > Gerrit-Reviewer: gerrit-hooks 
> >>> > Gerrit-HasComments: No
> >>>
> >>>
> >>>
> >>> --
> >>> Didi
> >>
> >>
> >
>
>
>
> --
> Didi
>

Re: [ovirt-devel] Master ovirt-engine build broken

[Eli Mesika]

Got it also, different error :

Failed tests:
  doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
unreachableGlusterHosts does not match the number of parameters in
UIMessages_pt_BR.properties


On Wed, May 4, 2016 at 1:31 PM, Marek Libra  wrote:

> There are issues on other keys as well.
> I'm rebuilding for all locales locally now.
>
>
> --
>
> *From: *"Marek Libra" 
> *To: *"devel" 
> *Sent: *Wednesday, May 4, 2016 11:29:55 AM
>
> *Subject: *Re: [ovirt-devel] Master ovirt-engine build broken
>
> The fix is here: https://gerrit.ovirt.org/#/c/57007/
>
> --
>
> *From: *"Roman Mohr" 
> *To: *"Oved Ourfali" 
> *Cc: *"devel" 
> *Sent: *Wednesday, May 4, 2016 10:27:51 AM
> *Subject: *Re: [ovirt-devel] Master ovirt-engine build broken
>
>
>
> On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali  wrote:
>
>> Roman - did you build the langs in order to find the issue?
>>
>
> I just ran 'mvn clean  verify', so I saw it on my machine. On gerrit not
> all of my builds showed that error.
>
> Looking at
>
>
> https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
>
> two patches passed and two failed after  a topic rebase.
>
>
>> Eyal - can we monitor a list of files that i changed will result in also
>> building all the languages?
>>
>>
>>
>> On Wed, May 4, 2016 at 11:22 AM, Eyal Edri  wrote:
>>
>>> right, and we can't enable lang permutation since it takes a very long
>>> time to run.
>>>
>>> On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek 
>>> wrote:
>>>


 - Original Message -
 > From: "Oved Ourfali" 
 > To: "Tomas Jelinek" 
 > Cc: "Roman Mohr" , "devel" ,
 "Scott Dickerson" 
 > Sent: Wednesday, May 4, 2016 9:55:40 AM
 > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
 >
 > I wonder, how come the CI didn't catch that?

 because this happens only when you compile with language permutations

 >
 > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek 
 wrote:
 >
 > > hmmm,
 > > regression introduced yesterday by
 https://gerrit.ovirt.org/#/c/56720/
 > > fix on the way
 > >
 > > - Original Message -
 > > > From: "Roman Mohr" 
 > > > To: "devel" 
 > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
 > > > Subject: [ovirt-devel] Master ovirt-engine build broken
 > > >
 > > > Hi,
 > > >
 > > > I see failing tests regarding to missing translations (e.g. [1]).
 > > >
 > > > [...]
 > > >
 > > > Failed tests:
  doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
 > > > cpuInfoLabel does not match the number of parameters in
 > > > UIMessages_zh_CN.properties(..)
 > > >
 > > > [...]
 > > >
 > > > Best Regards,
 > > >
 > > > Roman
 > > >
 > > > [1]
 > > >
 > >
 http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
 > > >
 > > > ___
 > > > Devel mailing list
 > > > Devel@ovirt.org
 > > > http://lists.ovirt.org/mailman/listinfo/devel
 > > ___
 > > Devel mailing list
 > > Devel@ovirt.org
 > > http://lists.ovirt.org/mailman/listinfo/devel
 > >
 > >
 > >
 >
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel



>>>
>>>
>>> --
>>> Eyal Edri
>>> Associate Manager
>>> RHEV DevOps
>>> EMEA ENG Virtualization R
>>> Red Hat Israel
>>>
>>> phone: +972-9-7692018
>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>
>>
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] New host deploy package is not compatible with current engine

[Eli Mesika]

Hi

Please note that if you updated the ovirt-host-deploy package , it includes
changes related to NGN RHEVH [1]
Those changes will work only when the engine side of this change is merged
I was forced to issue the host deploy patch in order to put the right
host-deploy dependency in engine's pom.xml
I will try to merge the engine part ASAP and send an email to devel when
done
Meanwhile, please work with older host-deploy package

host-deploy version before NGN changes is :

 df57fe1 - (tag: ovirt-host-deploy-1.5.0_alpha1) core: Fix priorities to
comply with before/after (2 settimane fa) 
 http://resources.ovirt.org/pub/ovirt-4.0_alpha1/

Thanks
Eli

[1] https://gerrit.ovirt.org/#/q/topic:NGN
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] NGN - Network error when adding a new NGN node

[Eli Mesika]

- Original Message -

> From: "Fabian Deutsch" <fdeut...@redhat.com>
> To: "Yaniv Bronheim" <ybron...@redhat.com>, "Eli Mesika" <emes...@redhat.com>
> Cc: "Dan Kenigsberg" <dan...@redhat.com>, "devel" <devel@ovirt.org>
> Sent: Wednesday, February 24, 2016 4:16:55 PM
> Subject: Re: [ovirt-devel] NGN - Network error when adding a new NGN node

> On Wed, Feb 24, 2016 at 3:10 PM, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > I suspect that it relates to the desire to remove the dependency in
> > vdsm-cli
> > - https://gerrit.ovirt.org/#/c/53831/ which is not merged yet. and Fabian
> > created the iso without vdsm-cli so the deploy failed in the middle. after
> > it failed it couldn't recover even when vdsm-cli was installed. sounds
> > reasonable?

> Sounds reasonable - if host deploy can mess up networking that much.

> Eli, can you restart with a clean installation and install vdsm-cli
> before trying to add the host?
Do you mean clean installation of NGN ? 

> (This is actually what I do in my testing: Install, add vdsm-cli, then add
> host)

> - fabian

> > On Wed, Feb 24, 2016 at 4:01 PM, Dan Kenigsberg <dan...@redhat.com> wrote:
> >>
> >> On Wed, Feb 24, 2016 at 08:16:45AM -0500, Eli Mesika wrote:
> >> > Hi Guys
> >> >
> >> > I am working on NGN
> >> > I had installed a ovirt-node from ISO, it (by mistake) did not include
> >> > the vdsm-cli package, so host-deploy failed on that
> >> > Fabian asked me to install vdsm-cli manually using :
> >> >
> >> > yum --enablerepo=ovirt* install vdsm-cli
> >> >
> >> > In that time the host was installed but did not came up having
> >> > networking issues (see attached logs)
> >> >
> >> > Fabian thinks that this is regression in VDSM, he said that same method
> >> > was tested 2 weeks ago with no problems
> >>
> >> Let's see {super,vdsm}.log, then and the exact vdsm version involved.
> >> ___
> >> Devel mailing list
> >> Devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/devel
> >
> >
> >
> >
> > --
> > Yaniv Bronhaim.

> --
> Fabian Deutsch <fdeut...@redhat.com>
> RHEV Hypervisor
> Red Hat
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] NGN - Network error when adding a new NGN node

[Eli Mesika]

Attached 

- Original Message -

> From: "Dan Kenigsberg" < dan...@redhat.com >
> To: "Eli Mesika" < emes...@redhat.com >
> Cc: "devel" < devel@ovirt.org >, "Fabian Deutsch" < fdeut...@redhat.com >
> Sent: Wednesday, February 24, 2016 4:01:12 PM
> Subject: Re: [ovirt-devel] NGN - Network error when adding a new NGN node

> On Wed, Feb 24, 2016 at 08:16:45AM -0500, Eli Mesika wrote:
> > Hi Guys
> >
> > I am working on NGN
> > I had installed a ovirt-node from ISO, it (by mistake) did not include the
> > vdsm-cli package, so host-deploy failed on that
> > Fabian asked me to install vdsm-cli manually using :
> >
> > yum --enablerepo=ovirt* install vdsm-cli
> >
> > In that time the host was installed but did not came up having networking
> > issues (see attached logs)
> >
> > Fabian thinks that this is regression in VDSM, he said that same method was
> > tested 2 weeks ago with no problems

> Let's see {super,vdsm}.log, then and the exact vdsm version involved.


vdsm-logs.tar.gz
Description: application/compressed-tar
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] IPv6 support in oVirt

[Eli Mesika]

This will require a change also in the fencing arguments 
We will have to add inet4_only  inet6_only support from the UI/API as a common 
field (like port/slot/secure)

See 
https://fedorahosted.org/cluster/wiki/FenceArguments

Please add that as well to your doc.


- Original Message -
> From: "Yevgeny Zaspitsky" 
> To: "devel" 
> Cc: "Michael Burman" 
> Sent: Tuesday, February 16, 2016 6:02:03 PM
> Subject: [ovirt-devel] IPv6 support in oVirt
> 
> Hi All,
> 
> IPv6 support is a long waited feature in oVirt and that was decided to
> include it in v4.0.
> I have updated the feature page [1] with the recent projected changes.
> 
> Please take a look on the page and please send me your comments so those
> would be reflected in the feature implementation.
> 
> Regards,
> Yevgeny
> 
> [1] http://www.ovirt.org/Features/IPv6_support
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Proposing Martin Betak as oVirt UI maintainer

[Eli Mesika]

+1

- Original Message -
> From: "Vojtech Szocs" 
> To: "devel" 
> Cc: "Michal Skrivanek" 
> Sent: Wednesday, February 3, 2016 4:00:57 PM
> Subject: [ovirt-devel] Proposing Martin Betak as oVirt UI maintainer
> 
> Hello, UI folks!
> 
> I'd like to propose Martin Betak as oVirt UI maintainer.
> 
> Over time, Martin made some significant UI contributions:
> 
> - improving UiCommon by utilizing Java generics [1]
> 
> - adding GinUiBinder [2] to allow @Inject'ing GIN-managed
>   objects into GWT widgets created in ui.xml templates
> 
> - upgrade GWT version to 2.6.1 [3] for both oVirt webapps
> 
> - providing excellent feedback and ideas on oVirtJS project
>   [4] while demonstrating outstanding JavaScript knowledge
> 
> [1] https://gerrit.ovirt.org/#/c/32907/
> [2] https://gerrit.ovirt.org/#/c/34954/
> [3] https://gerrit.ovirt.org/#/c/32135/
> [4] https://gerrit.ovirt.org/#/c/49466/
> 
> Personal note: Martin is familiar with oVirt GWT UI infra
> as a whole (GWT-P component model, advanced GWT features,
> UiCommon integration etc). His grasp on JS and its current
> eco-system is very solid.
> 
> Regards,
> Vojtech
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] oVirt UI now supports GWT Super Dev Mode

[Eli Mesika]

- Original Message -
> From: "Vojtech Szocs" 
> To: "devel" 
> Sent: Monday, February 1, 2016 8:46:51 PM
> Subject: [ovirt-devel] oVirt UI now supports GWT Super Dev Mode
> 
> Hi everyone,
> 
> in ovirt-engine master branch, it's now possible [1] to use GWT Super
> Dev Mode [2] to debug oVirt web applications (WebAdmin, UserPortal):
> 
> [1] https://gerrit.ovirt.org/#/c/50742/
> [2] http://www.gwtproject.org/articles/superdevmode.html
> 
> Please refer to commit msg [1] for details on GWT Super Dev Mode.

First of all Kudos 
I think that the steps explaining how to use that should appear also in 
README.developer file 

> 
> In general, SDM is good for "iterative" development when one changes
> UI code and wants to see the change reflected in browser very quickly
> (compared to existing GWT debug mechanism, aka Classic Dev Mode).
> 
> On the other hand, SDM does *not* allow using Java IDE to debug UI
> code, so one has to rely on browser's JavaScript developer tools.
> 
> Existing (Java IDE based) debug mechanism still works as expected,
> the Super Dev Mode is just an alternative.
> 
> Note on SDM usage by Scott: it's almost easier to run in Chrome's
> incognito mode so cached JS and mapped sources aren't an issue.
> 
> Regards,
> Vojtech
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Changing the name of VDSM in oVirt 4.0.

[Eli Mesika]

- Original Message -
> From: "Michal Skrivanek" 
> To: "Oved Ourfali" 
> Cc: "devel" 
> Sent: Thursday, January 28, 2016 4:57:33 PM
> Subject: Re: [ovirt-devel] Changing the name of VDSM in oVirt 4.0.
> 
> 
> 
> 
> 
> On 26 Jan 2016, at 19:13, Oved Ourfali < oourf...@redhat.com > wrote:
> 
> 
> 
> I must agree with Martin here.
> In addition, I think the benefit here is low, and the efforts it will require
> and the risks are high. Upgrade issues? Compatibility ones? Effect on engine
> features such as host upgrade manager, different provisioning products that
> might rely on that such as puppet recipes, ansible modules, or others..
> (can't say all mentioned stuff are relevant, and I guess there might be more
> implications than I've described).
> 
> IMHO, we should spend our time improving our project rather than spend a lot
> of developers, testers and integration people on these kind of tasks.
> 
> +1

+1 as well, don't think it worth the effort 

> I like vdsm.
> any variant with “agent” brings confusion with guest agent (let alone the
> fact we have three of them)
> 
> 
> 
> 
> 
> 
> In addition, bootstrapping of hosts doesn't require manual installation of
> VDSM, and as of 3.6 neither does upgrade, so most users shouldn't know and
> care what VDSM is.
> 
> Regards,
> Oved
> 
> 
> On Jan 26, 2016 7:00 PM, "Martin Sivak" < msi...@redhat.com > wrote:
> > 
> > Hi,
> > 
> > name change might be considered, but I do not think it will make a big
> > difference. People do not see vdsm too often (installed by host
> > deploy, managed by engine..).
> > 
> > 
> > But trying to make sure that (all?) component versions in a project
> > are the same is not a good idea if you ask me. You are not going to
> > rebuild everything when a hot fix is needed, but granted, you might
> > use minor numbers so the versions will at least start with the same
> > numbers. Or will we force a version bump and rebuild to unchanged
> > component, when others were updated for a given release? (we have
> > components like that - ovirt-scheduler-proxy for example)
> > 
> > Engine does not depend on an exact vdsm version, we have gradual
> > feature degradation built in in form of capabilities, machine type and
> > cluster levels so it should be totally up to the user what version of
> > vdsm is used. The same we do not control libvirt or kernel. Some of
> > the components (at least on my side) are completely usable without
> > oVirt and when oVirt is released it just gets the latest stable bits
> > available.
> > 
> > Why don't we treat oVirt as a package distribution it is? The long
> > term plan still is to break the monoliths (like vdsm or engine) and
> > the possibly new teams (or community) might have different needs.. we
> > might even want to promote reuse of some of the components (like [2])
> > in oVirt unrelated way and I would really love to see that kind of
> > adoption. We are trying to keep so much control that we are an open
> > project, but not a community one (where the community can influence
> > future plans, release schedules, workflows or processes).
> > 
> > Neither Fedora, nor RHEL (Debian, ..) try to control the version of
> > components. They depend purely on package dependencies and separate
> > component development from distribution compose processes (something
> > we lack..). Even OpenStack abandoned the unified versioning last year
> > (at least partially) [1]. We decided to use similar age based
> > versioning like described in [1] when I was still part of the Anaconda
> > team and it worked perfectly fine.
> > 
> > I really wish we would loosen the project coupling (and processes)
> > instead of tightening it. Sadly everything we have done lately is
> > going in the tightening direction...
> > 
> > 
> > 
> > TL;DR: Please let us use whatever versions of packages we want,
> > release as often as we want and just take the latest bits to compose
> > the oVirt distribution. Most of the components we have handle that
> > just fine.
> > 
> > [1] OpenStack versioning plans: http://ttx.re/new-versioning.html (and
> > please pay particular attention to the last section and especially the
> > last two paragraphs in it)
> > [2] There was a thread about vdsm RPMs being too granular:
> > http://lists.ovirt.org/pipermail/devel/2016-January/012185.html
> > 
> > --
> > Martin Sivak
> > oVirt / SLA
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> > 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Eli Mesika]

- Original Message -
> From: "Eli Mesika" <emes...@redhat.com>
> To: "devel" <devel@ovirt.org>
> Sent: Tuesday, January 19, 2016 6:29:09 PM
> Subject: Re: [ovirt-devel] No more "vds group" in master code , instead 
> please use "cluster"
> 
> Hi all
> 
> Please note that there is still a problem on engine-setup I have already a
> fixing draft [1]
> Meanwhile, until this is verified and merged please do before engine-setup
> from dbscripts/upgrade dir
> 
> psql -U engine -f 04_00_0210_add_vds_group_view.sql 
> 
> Thanks and sorry for that, this will be fixed ASAP and reported in this
> thread.
> 
> Eli
> 
> [1] https://gerrit.ovirt.org/#/c/52454/

Fix is now merged, thanks for your cooperation 


> - Original Message -
> > From: "Idan Shaby" <ish...@redhat.com>
> > To: "Eli Mesika" <emes...@redhat.com>
> > Sent: Tuesday, January 19, 2016 10:10:17 AM
> > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
> > please use "cluster"
> > 
> > Hi Eli,
> > 
> > I've fetched and rebased master, and got this error while running
> > engine-setup:
> > 
> > [ INFO  ] Stage: Setup validation
> > [WARNING] Cannot validate host name settings, reason: resolved host does
> > not match any of the local addresses
> > [ ERROR ] Failed to execute stage 'Setup validation': relation "vds_groups"
> > does not exist LINE 2: SELECT compatibility_version FROM
> > vds_groups...   ^
> > [ INFO  ] Stage: Clean up
> >   Log file is located at
> > /home/ishaby/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20160119100829-tebscp.log
> > [ INFO  ] Generating answer file
> > '/home/ishaby/ovirt-engine/var/lib/ovirt-engine/setup/answers/20160119100830-setup.conf'
> > [ INFO  ] Stage: Pre-termination
> > [ INFO  ] Stage: Termination
> > [ ERROR ] Execution of setup failed
> > 
> > Any idea?
> > 
> > 
> > Regards,
> > Idan
> > 
> > On Sun, Jan 17, 2016 at 4:50 PM, Eli Mesika <emes...@redhat.com> wrote:
> > 
> > >
> > >
> > > - Original Message -
> > > > From: "Eli Mesika" <emes...@redhat.com>
> > > > To: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Sunday, January 17, 2016 1:32:27 PM
> > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
> > > please use "cluster"
> > > >
> > > >
> > > >
> > > > - Original Message -
> > > > > From: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > > To: "Eli Mesika" <emes...@redhat.com>
> > > > > Cc: "devel" <devel@ovirt.org>
> > > > > Sent: Thursday, January 14, 2016 7:48:12 PM
> > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,
> > >  instead
> > > > > please use "cluster"
> > > > >
> > > > > Hi Eli,
> > > > >
> > > > > thank you, it helped. Now `engine-setup` works fine. However engine
> > > itself
> > > > > reports following in a few seconds after start:
> > > > >
> > > > > ERROR: relation "clusters_storage_domain" does not exist
> > > > >
> > > > > Relevant part of engine log: http://pastebin.test.redhat.com/340672
> > > > > Tested on current master (commit 8561bb69560686d0) and clean db.
> > > >
> > > > You are right, sorry for that ...
> > > > This patch fixes that issue
> > > > https://gerrit.ovirt.org/#/c/51929
> > >
> > > Patch merged please re-base on master and try again
> > >
> > >
> > > >
> > > > >
> > > > > - Original Message -
> > > > > > From: "Eli Mesika" <emes...@redhat.com>
> > > > > > To: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > > > Cc: "devel" <devel@ovirt.org>
> > > > > > Sent: Thursday, January 14, 2016 1:10:42 AM
> > > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,
> > >  instead
> > > > > 

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Eli Mesika]

Hi all 

Please note that there is still a problem on engine-setup I have already a 
fixing draft [1]
Meanwhile, until this is verified and merged please do before engine-setup from 
dbscripts/upgrade dir

psql -U engine -f 04_00_0210_add_vds_group_view.sql 

Thanks and sorry for that, this will be fixed ASAP and reported in this thread.

Eli

[1] https://gerrit.ovirt.org/#/c/52454/
- Original Message -
> From: "Idan Shaby" <ish...@redhat.com>
> To: "Eli Mesika" <emes...@redhat.com>
> Sent: Tuesday, January 19, 2016 10:10:17 AM
> Subject: Re: [ovirt-devel] No more "vds group" in master code , instead 
> please use "cluster"
> 
> Hi Eli,
> 
> I've fetched and rebased master, and got this error while running
> engine-setup:
> 
> [ INFO  ] Stage: Setup validation
> [WARNING] Cannot validate host name settings, reason: resolved host does
> not match any of the local addresses
> [ ERROR ] Failed to execute stage 'Setup validation': relation "vds_groups"
> does not exist LINE 2: SELECT compatibility_version FROM
> vds_groups...   ^
> [ INFO  ] Stage: Clean up
>   Log file is located at
> /home/ishaby/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20160119100829-tebscp.log
> [ INFO  ] Generating answer file
> '/home/ishaby/ovirt-engine/var/lib/ovirt-engine/setup/answers/20160119100830-setup.conf'
> [ INFO  ] Stage: Pre-termination
> [ INFO  ] Stage: Termination
> [ ERROR ] Execution of setup failed
> 
> Any idea?
> 
> 
> Regards,
> Idan
> 
> On Sun, Jan 17, 2016 at 4:50 PM, Eli Mesika <emes...@redhat.com> wrote:
> 
> >
> >
> > - Original Message -
> > > From: "Eli Mesika" <emes...@redhat.com>
> > > To: "Jakub Niedermertl" <jnied...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Sunday, January 17, 2016 1:32:27 PM
> > > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
> > please use "cluster"
> > >
> > >
> > >
> > > - Original Message -
> > > > From: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > To: "Eli Mesika" <emes...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Thursday, January 14, 2016 7:48:12 PM
> > > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,
> >  instead
> > > > please use "cluster"
> > > >
> > > > Hi Eli,
> > > >
> > > > thank you, it helped. Now `engine-setup` works fine. However engine
> > itself
> > > > reports following in a few seconds after start:
> > > >
> > > > ERROR: relation "clusters_storage_domain" does not exist
> > > >
> > > > Relevant part of engine log: http://pastebin.test.redhat.com/340672
> > > > Tested on current master (commit 8561bb69560686d0) and clean db.
> > >
> > > You are right, sorry for that ...
> > > This patch fixes that issue
> > > https://gerrit.ovirt.org/#/c/51929
> >
> > Patch merged please re-base on master and try again
> >
> >
> > >
> > > >
> > > > - Original Message -
> > > > > From: "Eli Mesika" <emes...@redhat.com>
> > > > > To: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > > Cc: "devel" <devel@ovirt.org>
> > > > > Sent: Thursday, January 14, 2016 1:10:42 AM
> > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,
> >  instead
> > > > > please use "cluster"
> > > > >
> > > > >
> > > > >
> > > > > - Original Message -
> > > > > > From: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > > > To: "Eli Mesika" <emes...@redhat.com>
> > > > > > Cc: "devel" <devel@ovirt.org>
> > > > > > Sent: Wednesday, January 13, 2016 9:18:57 PM
> > > > > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,
> > instead
> > > > > > please use "cluster"
> > > > > >
> > > > > > Hi Eli,
> > > > > >
> > > > > > are db migration scripts supposed to handle this change? My

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Eli Mesika]

- Original Message -
> From: "Jakub Niedermertl" <jnied...@redhat.com>
> To: "Eli Mesika" <emes...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Thursday, January 14, 2016 7:48:12 PM
> Subject: Re: [ovirt-devel] No more "vds group" in master code ,   instead 
> please use "cluster"
> 
> Hi Eli,
> 
> thank you, it helped. Now `engine-setup` works fine. However engine itself
> reports following in a few seconds after start:
> 
> ERROR: relation "clusters_storage_domain" does not exist
> 
> Relevant part of engine log: http://pastebin.test.redhat.com/340672
> Tested on current master (commit 8561bb69560686d0) and clean db.

You are right, so for that ...
This patch fixes that issue 
https://gerrit.ovirt.org/#/c/51929

> 
> - Original Message -
> > From: "Eli Mesika" <emes...@redhat.com>
> > To: "Jakub Niedermertl" <jnied...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>
> > Sent: Thursday, January 14, 2016 1:10:42 AM
> > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
> > please use "cluster"
> > 
> > 
> > 
> > - Original Message -
> > > From: "Jakub Niedermertl" <jnied...@redhat.com>
> > > To: "Eli Mesika" <emes...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, January 13, 2016 9:18:57 PM
> > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,   instead
> > > please use "cluster"
> > > 
> > > Hi Eli,
> > > 
> > > are db migration scripts supposed to handle this change? My
> > > `engine-setup`
> > > failed with following message in log:
> > 
> > Hi Jakub
> > 
> > Please re-base on latest master, there was an issue with that and it was
> > solved in https://gerrit.ovirt.org/#/c/51784/
> > 
> > 
> > > 
> > > """
> > > 2016-01-13 20:02:57 DEBUG
> > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
> > > database.execute:172 Database: 'None', Statement: '
> > > SELECT compatibility_version FROM cluster;;
> > > ', args: {}
> > > 2016-01-13 20:02:57 DEBUG
> > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
> > > database.execute:177 Creating own connection
> > > 2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156 method
> > > exception
> > > Traceback (most recent call last):
> > >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in
> > >   _executeMethod
> > > method['method']()
> > >   File
> > >   
> > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
> > >   line 218, in _validation
> > > self._checkSupportedVersionsPresent()
> > >   File
> > >   
> > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
> > >   line 180, in _checkSupportedVersionsPresent
> > > transaction=False,
> > >   File
> > >   
> > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py",
> > >   line 196, in execute
> > > args,
> > > ProgrammingError: relation "cluster" does not exist
> > > LINE 2: SELECT compatibility_version FROM cluster;;
> > >   ^
> > > 
> > > 2016-01-13 20:02:57 ERROR otopi.context context._executeMethod:165 Failed
> > > to
> > > execute stage 'Setup validation': relation "cluster" does not exist
> > > LINE 2: SELECT compatibility_version FROM cluster;;
> > >   ^
> > > """
> > > 
> > > Thank you for answer.
> > > 
> > > Best regards
> > > Jakub
> > > 
> > > 
> > > - Original Message -
> > > > From: "Eli Mesika" <emes...@redhat.com>
> > > > To: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, January 13, 2016 12:00:50 AM
> > > > Subject: [ovirt-devel] No more "vds group" in mas

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Eli Mesika]

- Original Message -
> From: "Eli Mesika" <emes...@redhat.com>
> To: "Jakub Niedermertl" <jnied...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Sunday, January 17, 2016 1:32:27 PM
> Subject: Re: [ovirt-devel] No more "vds group" in master code , instead 
> please use "cluster"
> 
> 
> 
> ----- Original Message -
> > From: "Jakub Niedermertl" <jnied...@redhat.com>
> > To: "Eli Mesika" <emes...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>
> > Sent: Thursday, January 14, 2016 7:48:12 PM
> > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
> > please use "cluster"
> > 
> > Hi Eli,
> > 
> > thank you, it helped. Now `engine-setup` works fine. However engine itself
> > reports following in a few seconds after start:
> > 
> > ERROR: relation "clusters_storage_domain" does not exist
> > 
> > Relevant part of engine log: http://pastebin.test.redhat.com/340672
> > Tested on current master (commit 8561bb69560686d0) and clean db.
> 
> You are right, sorry for that ...
> This patch fixes that issue
> https://gerrit.ovirt.org/#/c/51929

Patch merged please re-base on master and try again


> 
> > 
> > - Original Message -
> > > From: "Eli Mesika" <emes...@redhat.com>
> > > To: "Jakub Niedermertl" <jnied...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Thursday, January 14, 2016 1:10:42 AM
> > > Subject: Re: [ovirt-devel] No more "vds group" in master code ,   instead
> > > please use "cluster"
> > > 
> > > 
> > > 
> > > - Original Message -
> > > > From: "Jakub Niedermertl" <jnied...@redhat.com>
> > > > To: "Eli Mesika" <emes...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, January 13, 2016 9:18:57 PM
> > > > Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
> > > > please use "cluster"
> > > > 
> > > > Hi Eli,
> > > > 
> > > > are db migration scripts supposed to handle this change? My
> > > > `engine-setup`
> > > > failed with following message in log:
> > > 
> > > Hi Jakub
> > > 
> > > Please re-base on latest master, there was an issue with that and it was
> > > solved in https://gerrit.ovirt.org/#/c/51784/
> > > 
> > > 
> > > > 
> > > > """
> > > > 2016-01-13 20:02:57 DEBUG
> > > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
> > > > database.execute:172 Database: 'None', Statement: '
> > > > SELECT compatibility_version FROM cluster;;
> > > > ', args: {}
> > > > 2016-01-13 20:02:57 DEBUG
> > > > otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
> > > > database.execute:177 Creating own connection
> > > > 2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156
> > > > method
> > > > exception
> > > > Traceback (most recent call last):
> > > >   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146,
> > > >   in
> > > >   _executeMethod
> > > > method['method']()
> > > >   File
> > > >   
> > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
> > > >   line 218, in _validation
> > > > self._checkSupportedVersionsPresent()
> > > >   File
> > > >   
> > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
> > > >   line 180, in _checkSupportedVersionsPresent
> > > > transaction=False,
> > > >   File
> > > >   
> > > > "/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py",
> > > >   line 196, in execute
> > > > args,
> > > > ProgrammingError: relation "cluster" does not exist
> > > > LINE 2: SELECT compatibility_version FROM cluster;;
> > > >

Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Eli Mesika]

- Original Message -
> From: "Jakub Niedermertl" <jnied...@redhat.com>
> To: "Eli Mesika" <emes...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Wednesday, January 13, 2016 9:18:57 PM
> Subject: Re: [ovirt-devel] No more "vds group" in master code ,   instead 
> please use "cluster"
> 
> Hi Eli,
> 
> are db migration scripts supposed to handle this change? My `engine-setup`
> failed with following message in log:

Hi Jakub

Please re-base on latest master, there was an issue with that and it was solved 
in https://gerrit.ovirt.org/#/c/51784/


> 
> """
> 2016-01-13 20:02:57 DEBUG
> otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
> database.execute:172 Database: 'None', Statement: '
> SELECT compatibility_version FROM cluster;;
> ', args: {}
> 2016-01-13 20:02:57 DEBUG
> otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
> database.execute:177 Creating own connection
> 2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156 method
> exception
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/otopi/context.py", line 146, in
>   _executeMethod
> method['method']()
>   File
>   
> "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
>   line 218, in _validation
> self._checkSupportedVersionsPresent()
>   File
>   
> "/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
>   line 180, in _checkSupportedVersionsPresent
> transaction=False,
>   File
>   
> "/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py",
>   line 196, in execute
> args,
> ProgrammingError: relation "cluster" does not exist
> LINE 2: SELECT compatibility_version FROM cluster;;
>   ^
> 
> 2016-01-13 20:02:57 ERROR otopi.context context._executeMethod:165 Failed to
> execute stage 'Setup validation': relation "cluster" does not exist
> LINE 2: SELECT compatibility_version FROM cluster;;
>   ^
> """
> 
> Thank you for answer.
> 
> Best regards
> Jakub
> 
> 
> - Original Message -
> > From: "Eli Mesika" <emes...@redhat.com>
> > To: "devel" <devel@ovirt.org>
> > Sent: Wednesday, January 13, 2016 12:00:50 AM
> > Subject: [ovirt-devel] No more "vds group" in master code , instead please
> > use "cluster"
> > 
> > Hi
> > 
> > I have merged today this patch[1] to master.
> > 
> > The code from historical reasons uses both "vds group" and "cluster" for a
> > cluster entity.
> > This makes the code not-clear, non-readable and hard for beginners (to find
> > for example SPs that handle clusters , or all code related to a cluster
> > operation)
> > This also makes our logging and error messages using sometimes "vds group"
> > and sometimes "cluster" to relate to the same entity.
> > Worse than that, new code written sometimes introduce a mix of both terms.
> > 
> > Patch[1] renames "vds group" to cluster all over the code.
> > This renaming covers all engine code including
> >   Class names
> >   Variables
> >   Comments
> >   Logging
> >   Error messages
> >   Database tables,views, columns and SPs including all kinds of keys and
> >   constrains
> > 
> > Please do not use from now on the term "vds group" (all its variants
> > (VdsGroup, vdsGroup, vds_group etc.)
> > Instead , cluster and all its variants should be used
> > 
> > If you have some written code that is not merged yet, you will probably
> > have
> > a little work on rebase on top this patch, as far as I know those  should
> > be
> > trivial patches and if you have any question, please ask.
> > 
> > Possible affects on other products are minor and were communicated to the
> > relevant product people.
> > 
> > [1] https://gerrit.ovirt.org/#/c/51109/
> > 
> > Thanks
> > Eli Mesika
> > 
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> > 
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] No more "vds group" in master code , instead please use "cluster"

[Eli Mesika]

Hi

I have merged today this patch[1] to master.

The code from historical reasons uses both "vds group" and "cluster" for a 
cluster entity.
This makes the code not-clear, non-readable and hard for beginners (to find for 
example SPs that handle clusters , or all code related to a cluster operation)
This also makes our logging and error messages using sometimes "vds group" and 
sometimes "cluster" to relate to the same entity.
Worse than that, new code written sometimes introduce a mix of both terms.   

Patch[1] renames "vds group" to cluster all over the code.
This renaming covers all engine code including 
  Class names 
  Variables 
  Comments 
  Logging 
  Error messages 
  Database tables,views, columns and SPs including all kinds of keys and 
constrains 

Please do not use from now on the term "vds group" (all its variants (VdsGroup, 
vdsGroup, vds_group etc.) 
Instead , cluster and all its variants should be used 

If you have some written code that is not merged yet, you will probably have a 
little work on rebase on top this patch, as far as I know those  should be 
trivial patches and if you have any question, please ask.

Possible affects on other products are minor and were communicated to the 
relevant product people.

[1] https://gerrit.ovirt.org/#/c/51109/

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] canDoAction is dead, long live validate ...

[Eli Mesika]

Hi

I had merged today a patch [1]  that renames canDoAction to validate in 
CommandBase and all references
Please note that canDo boolean flags where replaced with valid and canDoAction 
was replaced all over with validate/validation all over the code including 
javadoc, comments and logging messages.

For example getCanDoActionMessages became getValidationMessages 
failCanDoAction became failValidation 

And so on 
 
[1] https://gerrit.ovirt.org/#/c/50632/


Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] New VM status functions - your comments?

[Eli Mesika]

- Original Message -
> From: "Shmuel Melamud" 
> To: "devel" 
> Sent: Tuesday, December 15, 2015 3:41:21 PM
> Subject: [ovirt-devel] New VM status functions - your comments?
> 
> Hi!
> 
> https://docs.google.com/a/redhat.com/spreadsheets/d/1yb-JdTAGh_4bOC6tL7KLz1Q2VR-UkF3eMSo1o_kU3MM/edit?usp=sharing
> 
> In the document above I've summarized the changes I plan to make to
> reorganize VM status checks in the Engine.
> 
> The second page of the documents contains the list of the new functions and
> the statuses they will check.
> 
> On the first page I've collected all the places I'm planning to change -
> class name, method name and line number.

I am not sure line number is suitable here, code is changing and line numbers 
become not relevant, maybe a link to a gerrit draft with the change is better 
or a code fragment 


> "New method" column is the new
> check that will be put in this place.
> 
> Changing to new functions will often add/remove a state or two, that's why
> I'll be VERY pleased to see your comments. I've sorted the classes by topic,
> so it will be easy to look on those you're familiar with.
> 
> Ask yourself questions:
> 
> 1. If Up state is required, what about PoweringUp, PoweringDown,
> RebootInProgress?
> 2. If Up state is required, what about WaitingForLaunch? Paused?
> 3. What about migration?
> 4. What about hibernation?
> 5. If Down state is required, should it allow also ImageLocked and
> ImageIllegal?
> 6. If Down state is required, what about Suspended?
> 
> Thank you in advance.
> 
> Shmuel
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Default DC & Cluster are created now with version 4.0

[Eli Mesika]

Hi

Please note that https://gerrit.ovirt.org/#/c/48802/ was merged.

>From now, Default DC and Cluster are created with version 4.0 

A patch adding support for 4.0 from the vdsm side was merged to vdsm today 

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Controlling UI table column visibility and position

[Eli Mesika]

- Original Message -
> From: "Oved Ourfali" 
> To: "Vojtech Szocs" 
> Cc: "users" , "devel" 
> Sent: Wednesday, November 25, 2015 7:32:33 PM
> Subject: Re: [ovirt-devel] Controlling UI table column visibility and position
> 
> 
> 
> That's awesome!
> Looking forward to playing around with it!
> 
> Thanks,
> Oved
> On Nov 25, 2015 6:42 PM, "Vojtech Szocs" < vsz...@redhat.com > wrote:
> 
> 
> Dear developers and users,
> 
> it's now possible to tweak table column visibility and position
> through header context menu in WebAdmin's main & sub tabs [1,2].
> 
> [1] https://gerrit.ovirt.org/#/c/43401/
> [2] https://gerrit.ovirt.org/#/c/47542/
> 
> This allows you to turn "unwanted" columns off and re-arrange
> those which are visible to match your personal preference.
> 
> Screenshot of customizing VM main tab:
> 
> https://imgur.com/5dfh8QA

Really useful 
However, I would filter out status columns since this column does not have a 
title and also  I can not see a use-case of removing this column from the view 

> 
> There's also RFE [3] to persist (remember) such column settings
> in the browser, similar to persisting other client-side options.
> 
> [3] https://bugzilla.redhat.com/1285456
> 
> Regards,
> Vojtech
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Push notifications in 4.0 backend

[Eli Mesika]

- Original Message -
> From: "Vojtech Szocs" 
> To: "Martin Betak" 
> Cc: "engine-de...@ovirt.org" , "Piotr Kliczewski" 
> , "Michal Skrivanek"
> 
> Sent: Monday, November 23, 2015 6:22:45 PM
> Subject: Re: [ovirt-devel] Push notifications in 4.0 backend
> 
> 
> 
> - Original Message -
> > From: "Martin Betak" 
> > To: "Vojtech Szocs" 
> > Cc: "Einav Cohen" , "engine-de...@ovirt.org"
> > , "Roy Golan" ,
> > "Roman Mohr" , "Michal Skrivanek" ,
> > "Piotr Kliczewski" ,
> > "Tomas Jelinek" , "Alexander Wels" ,
> > "Greg Sheremeta" ,
> > "Scott Dickerson" , "Arik Hadas" ,
> > "Allon Mureinik" ,
> > "Shmuel Melamud" , "Jakub Niedermertl"
> > , "Marek Libra"
> > , "Martin Perina" , "Alona Kaplan"
> > , "Martin Mucha"
> > 
> > Sent: Thursday, November 19, 2015 1:53:07 PM
> > Subject: Re: Push notifications in 4.0 backend
> > 
> > Hi All,
> > 
> > I have created a PoC patch [1] demonstrating the idea of annotating
> > basic CRUD commands to publish CDI events. It is not meant as 100%
> > solution, but as a simplification of the common use cases when
> > one would inject CDI event with given qualifier and fire it after
> > successful completion of transaction.
> 
> The patches (mentioned below) look interesting.
> 
> At this point, it would be great if backend core maintainers
> voiced their opinions on the general idea of firing CDI events
> in response to important actions happening on Engine, such as
> backend commands being executed. So, what do you think guys?

+1

I am for it, I think it may reduce load from our DB 

> 
> > 
> > The usage of this annotations is demonstrated on several basic CRUD
> > commands in [2] on StoragePool, VDS, VDSGroup, .etc
> > 
> > As always, comments and suggestions are very welcome!
> > 
> > Thank you and best regards,
> > 
> > Martin
> > 
> > [1] infra: https://gerrit.ovirt.org/#/c/48696/
> > [2] usage: https://gerrit.ovirt.org/#/c/48697/
> > 
> > 
> > 
> > - Original Message -
> > > From: "Vojtech Szocs" 
> > > To: "Martin Betak" , "Einav Cohen" 
> > > Cc: "engine-de...@ovirt.org" , "Roy Golan"
> > > , "Roman Mohr" ,
> > > "Michal Skrivanek" , "Piotr Kliczewski"
> > > , "Tomas Jelinek"
> > > , "Alexander Wels" , "Greg
> > > Sheremeta" , "Scott
> > > Dickerson" 
> > > Sent: Friday, November 13, 2015 9:31:45 PM
> > > Subject: Re: Push notifications in 4.0 backend
> > > 
> > > Hi everyone,
> > > 
> > > assuming that 4.0 UI will be based on the existing GWT technology,
> > > I'd like to improve two things which I believe are very important:
> > > 
> > > #1 goal: improve GWT compilation times
> > >- don't use standard GWT i18n mechanism which yields separate
> > >  permutation vector, but use our own i18n mechanism instead
> > >- in practice, compiling for X browsers and Y languages should
> > >  result in GWT compiler processing X permutations (not X * Y)
> > >- this will also directly impact GWT debug performance, making
> > >  GWT debugging experience less painful for developers
> > > 
> > > #2 goal: improve UX related to backend operations
> > >- replace periodic polling with push notifications that inform
> > >  UI of changes in oVirt "system" as they happen
> > >- in practice, UI becomes reactive instead of proactive, which
> > >  has several benefits (reduced HTTP load on Engine being the
> > >  most obvious one)
> > > 
> > > So what Martin wrote in email below directly relates to #2 goal.
> > > 
> > > Push notifications improve user experience regardless of specific
> > > UI technology, regardless of whether we improve existing REST API
> > > (e.g. introduce data aggregations) or not.
> > > 
> > > For me, it's a big +1.
> > > 
> > > Having BLL commands firing CDI events upon execution makes sense.
> > > That said, I'd suggest to start with a simple implementation and
> > > proceed from there.
> > > 
> > > What Martin suggested:
> > > 
> > >   void onVmChanged(@Observes @Updated VM vm)
> > > 
> > > could be even simplified into:
> > > 
> > >   void onCommandExecuted(@Observes @CommandExecuted UpdateVmCommand cmd)
> > > 
> > > and still it would bring value to the general idea, which is the
> > > ability to detect changes in oVirt "system" as they happen along
> > > with the ability to react 

[ovirt-devel] Db scripts formatting

[Eli Mesika]

Hi

Please note that SQL files under dbscripts directory were formatted to allow 
easy review of changes in future
You can find the basic formatting rules in [1]

Next step is to find a way to auto-verify auto-format on he patch level.

Meanwhile, please insure that your future patches follows the new formatting 
rules 

Thanks for your cooperation 

Eli Mesika 


[1] http://www.ovirt.org/index.php?title=OVirt-DB-Issues/formatting

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reported-By - giving credit to our testers

[Eli Mesika]

+1

- Original Message -
> From: "Nir Soffer" 
> To: "devel" 
> Cc: "Piotr Kliczewski" 
> Sent: Thursday, November 12, 2015 4:45:13 PM
> Subject: [ovirt-devel] Reported-By - giving credit to our testers
> 
> Hi all,
> 
> Our QE (and sometimes our users) are working hard testing and
> reporting bugs, but
> their effort is never mentioned in our code.
> 
> Looking at kernel git history, I found that they are using the
> Reported-By header for
> giving credit to the person reporting a bug. I suggest we adapt this header.
> 
> Here are some examples how we can use it:
> 
> - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG
> -
> https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd
> -
> https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598
> 
> Thanks,
> Nir
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [Postgres] RETURNS TABLE is problematic on fc22

[Eli Mesika]

Guys 
Please look at https://bugzilla.redhat.com/show_bug.cgi?id=1249671
problem was usage of PG RETURNS TABLE instead of a TYPE

Please see the fixing patch in https://gerrit.ovirt.org/#/c/44337

Please avoid usage of RETURNS TABLE and use only a define TYPE 

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] upgrade script failing in latest master

[Eli Mesika]

- Original Message -
 From: Greg Padgett gpadg...@redhat.com
 To: aw...@redhat.com
 Cc: devel@ovirt.org
 Sent: Monday, July 27, 2015 11:22:56 PM
 Subject: Re: [ovirt-devel] upgrade script failing in latest master
 
 On 07/27/2015 03:24 PM, Alexander Wels wrote:
  On Monday, July 27, 2015 03:07:19 PM Greg Padgett wrote:
 
On 07/27/2015 02:48 PM, Alexander Wels wrote:
 
 Hi,
 

 
 When I run engine-setup in the latest master I get the following error
 in
 
 my setup log:
 
Hi Alexander,
 
   
 
It looks like a bug. The upgrade script casts the
 
vm_static.dedicated_vm_for_vds value to a UUID, but in VmBaseDaoDbFacade
 
we see that this field may consist of a comma-delimited list of UUIDs.
 
   
 
To work around it for now you can update the offending
 
vm_static.dedicated_vm_for_vds values to have only a single UUID.
 
   
 
Unfortunately I don't know the proper fix (guessing
vm_host_pinning_map
 
needs one value per UUID in dedicated_vm_for_vds?), but this should at
 
least get you up and running.
 
   
 
  Aha, that tells me what the problem is, I have been working on a UI change
  to allow one to select multiple hosts to run a VM on. And I believe the
  result is a comma separated list of host ids. I had one of my VMs still
  marked for 2 hosts, and as soon as I changed that to one host, this
  problem went away.
 
 Glad it worked.
 
  Of course immediately a new one showed up...
 
  2015-07-27 15:11:47 DEBUG otopi.context context._executeMethod:141 Stage
  misc METHOD
  otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.config.public_glance_repository.Plugin._misc
 
  2015-07-27 15:11:47 DEBUG
  otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database
  database.execute:171 Database: 'None', Statement: '
  select inst_add_glance_provider(
  %(provider_id)s,
  %(provider_name)s,
  %(provider_description)s,
  %(provider_url)s,
  %(storage_domain_id)s
  )
  ', args: {'provider_url': 'http://glance.ovirt.org:9292',
  'provider_name': 'ovirt-image-repository', 'storage_domain_id':
  '072fbaa1-08f3-4a40-9f34-a5ca22dd1d74', 'provider_description': 'Publ
  ic Glance repository for oVirt', 'provider_id':
  'ceab03af-7220-4d42-8f5c-9b557f5d29af'}
  2015-07-27 15:11:47 DEBUG otopi.context context._executeMethod:155 method
  exception
  Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
  _executeMethod
  method['method']()
File
  /home/awels/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/config/public_glance_repository.py,
  line 77, in _misc
  storage_domain_id=072fbaa1-08f3-4a40-9f34-a5ca22dd1d74
File
  /home/awels/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py,
  line 195, in execute
  args,
  ProgrammingError: function inst_add_glance_provider(unknown, unknown,
  unknown, unknown, unknown) does not exist
  LINE 2: select inst_add_glance_provider(
 ^
  HINT:  No function matches the given name and argument types. You might
  need to add explicit type casts.
 
  2015-07-27 15:11:47 ERRORotopi.context context._executeMethod:164 Failed
  to execute stage 'Misc configuration': function
  inst_add_glance_provider(unknown, unknown, unknown, unknown, unknown) does
  not ex
  ist
  LINE 2: select inst_add_glance_provider(
 ^
  HINT:  No function matches the given name and argument types. You might
  need to add explicit type casts.
 
  Again, this is strange as I do have that function in my database, and it
  looks like the appropriate fields are there.
 
 I saw this before too, and I suspect it's a symptom of the db update
 failing--but I never nailed down the root cause, thinking it was something
 unique I did to myself.  It went away on its own just as unexpectedly as
 it had arrived.  While it plagued me, I worked around it by modifying
 public_glance_repository.py to return early.

Seems to me as a result of a broken upgrade 

 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Screen casting and video editing on fc21 with Blender

[Eli Mesika]

Hi guys

As you already know, some of us need to do some video/screen cast for their 3.6 
new features 
I spent my day today in recording and editing a video for one of my new 3.6 
features and I want to share my experience to save you time (and hair..)

Well, I started with recordmydesktop (yum) to capture the video files , this 
worked smooth and enables you also to have a cup of coffee until the file is 
written to the disk.
Then, after having few videos, I wanted to edit them and make a whole smooth 
video, cutting some stuff out ... 
I had started with installing pitivi (yum), from its feature list it seems 
promising but after dozens of crashes on almost every mouse move, I really gave 
up...

Oved, sent me this post [1]: 
So, I installed Blender and tried to work with it but it seems to refuse adding 
my video files to the project time-line ...
Digging around [2], I found that the Blender package on fc21 does not work well 
and in order to get it working you have to download Blender latest version 
(2.75a) manually from [3],
extract it to a directory and run blender 

Blender has many usages, but you can adjust it to do video editing, just follow 
[4] [5] and [6] tutorials (less than 15 min for all)
(all are important, especially the first one that includes proper configuration)

One major issue is to configure well the frames per second rate (fps) (can be 
shown on the file properties) of your videos if you don't want to get a gap 
between your video and the sound track  

I was able after that to edit my videos and export (render) video as MP4 and 
audio as MP3 (embedded in the video file) (other formats may have codec 
issues...)

Overall, I worked with Blender few hours, splitting videos, removing video 
strips , grabbing and dragging without a single error or crash 

Although that Blender learning curve seems to be longer than other 
applications, I recommend to use this application for video editing and screen 
casting 

If you have any question or need any assistance/advice , I will be happy to 
help.


[1] http://opensource.com/life/15/1/current-state-linux-video-editing
[2] http://www.spinics.net/linux/fedora/fedora-users/msg459024.html
[3] https://www.blender.org/
[4] https://www.youtube.com/watch?v=xSGIPmQdV6Mhtml5=1
[5] https://www.youtube.com/watch?v=20VqQLpvctY
[6] https://www.youtube.com/watch?v=zxFGm_LQeZQ


Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Running oVirt 3.5 on fc21 with open jdk 1.8 (dev)

[Eli Mesika]

Hi

I upgraded my workstation from fc20 to fc21 and had troubles running 
engine-setup on a 3.5 application.
The following instructions did the trick to me (Thanks to Alon Bar Lev)

1) Download jboss-eap-x.y from http://www.jboss.org/products/eap/overview/ (zip)
2) Extract it to /opt (insure that it has the right permissions)
3) set the following environment variables :
   a) export OVIRT_ENGINE_JAVA_HOME=/usr/lib/jvm/jre
   b) export OVIRT_ENGINE_JAVA_HOME_FORCE=1
4) run engine-setup as follows :
   engine-setup --jboss-home=/opt/jboss-eap-x.y


Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] New warning when running dev env , JDK 1.8 , fc 21

[Eli Mesika]

Hi

I got those warnings when I run the application 

OpenJDK 64-Bit Server VM warning: ignoring option PermSize=256m; support was 
removed in 8.0
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was 
removed in 8.0

Please advice  

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Checkstyle changes in oVirt

[Eli Mesika]

Well done 
However, InteliJ instructions in http://www.ovirt.org/Building_oVirt_Engine/IDE 
are very old and should be aligned with current InteliJ version 
Tal , can you update this as well?

- Original Message -
 From: Ramesh Nachimuthu rnach...@redhat.com
 To: Tal Nisan tni...@redhat.com, rhev-devel rhev-de...@redhat.com, 
 devel@ovirt.org
 Sent: Wednesday, July 15, 2015 9:07:21 AM
 Subject: Re: [ovirt-devel] Checkstyle changes in oVirt
 
 very much needed one. Thanks. :)
 
 Regards,
 Ramesh
 
 On 07/14/2015 10:41 PM, Tal Nisan wrote:
  Hey everyone,
 
  We've all reviewed patches that contained imports sorting noise
  caused by misconfigured IDEs, I decided to enforce the project's
  standards concerning imports order with the checkstyle plugin.
  Achieving this required upgrading checkstyle to version 6.5 and fixing
  the existing violations so we can have a clean baseline to build from.
  While I was at it, I fixed the left curly braces position suppression
  in the uicommon project to align with the proper standards defined
  in the rest of the project.
 
  Please note that these standards are now enforced at build time and
  patches that violate them will break the build.
  A big thank you goes out to everyone who reviewed and commented on the
  patches!
 
  * For those interested, the relevant patches can be found at
  https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:checkstyle
  * The project formatter settings can be found at
  http://www.ovirt.org/Building_oVirt_Engine/IDE
 
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Renamed classes

[Eli Mesika]

Hi

Please note that the following classes were renamed :


*DAODbFacadeImpl.java  = *DaoImpl.java

VdsIdParametersBase = IdQueryableParameter

VdcBllErrors = EngineBllError

VdcBllMessages =  EngineBllMessage

VdcFault = EngineFault


Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Reaming VdcFault to EngineFault

[Eli Mesika]

- Original Message -
 From: Eli Mesika emes...@redhat.com
 To: devel devel@ovirt.org
 Sent: Wednesday, July 8, 2015 3:22:23 PM
 Subject: Reaming VdcFault to EngineFault
 
 You may get the following error after rebase with master :
 
 http://pastebin.test.redhat.com/295552

If you can not see this , the error is :

2015-07-08 12:59:21,322 ERROR [org.ovirt.engine.core.vdsbroker.HostMonitoring] 
(DefaultQuartzScheduler_Worker-5) [5766d7b4] Exception: javax.ejb.EJBException: 
org.apache.commons.lang.SerializationException: 
org.codehaus.jackson.map.JsonMappingException: Invalid type id 
'org.ovirt.engine.core.common.errors.VdcFault' (for id type 'Id.class'): no 
such class found (through reference chain: 
org.ovirt.engine.core.common.action.VdcReturnValueBase[fault])

 
 The reason is that the CommandEntity has a memeber of type VdcReturnValueBase
 which contains
 the VdcFault. It is serialized by jackson into the db, and when there is
 an attempt to deserialize it - you got the error.
 
 This can be addressed by a simple update command followed by engine restart:
 
 psql -U user -c update command_entities set return_value =
 replace(return_value,'VdcFault','EngineFault'), return_value_class =
 replace(return_value_class,'VdcFault','EngineFault'); db
 
 
 Please let me know if you have any issues.
 
 Thanks
 Eli Mesika
 
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] engine-setup broken in master?

[Eli Mesika]

- Original Message -
 From: Omer Frenkel ofren...@redhat.com
 To: Roy Golan rgo...@redhat.com
 Cc: devel@ovirt.org
 Sent: Thursday, June 25, 2015 11:16:23 AM
 Subject: Re: [ovirt-devel] engine-setup broken in master?
 
 
 
 - Original Message -
  From: Roy Golan rgo...@redhat.com
  To: Omer Frenkel ofren...@redhat.com, devel@ovirt.org
  Sent: Thursday, June 25, 2015 11:07:40 AM
  Subject: Re: [ovirt-devel] engine-setup broken in master?
  
  Dudi hit the same issue.
  
  On 06/25/2015 10:37 AM, Omer Frenkel wrote:
   Hi,
   on latest master, engine-setup fails for me with:
   [ ERROR ] Failed to execute stage 'Setup validation': Failed checking
   Engine database: [u'']
  
   from the setup log:
  
   2015-06-25 10:27:51 DEBUG
   otopi.plugins.ovirt_**FILTERED**_setup.ovirt_**FILTERED**.upgrade.dbvalidations
   plugin.execute:940 execute-output:
   ['/home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/dbu
   tils/validatedb.sh', '--user=**FILTERED**', '--host=localhost',
   '--port=5432', '--database=**FILTERED**',
   '--log=/home/ofrenkel/ovirt-**FILTERED**/var/log/ovirt-**FILTERED**/setup/ovirt-**FILTERED**-setup-201506
   25102702-nwwazb.log'] stderr:
   ERROR:  function fn_db_validate_fks(boolean, boolean) does not exist
   LINE 3: from fn_db_validate_fks(false, 0 != 0)
 ^
   HINT:  No function matches the given name and argument types. You might
   need to add explicit type casts.

Didi, we concluded that engine-setup is responding for installing the SPs, can 
you please check on upgrade scenario if the call for fkvalidaor script is done 
before SPs are installed 

  
   2015-06-25 10:27:51 DEBUG otopi.context context._executeMethod:155 method
   exception
   Traceback (most recent call last):
  File /usr/lib/python2.7/site-packages/otopi/context.py, line 145, in
  _executeMethod
method['method']()
  File
  
   /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
  line 128, in _validation
violations, issues_found = self._checkDb()
  File
  
   /home/ofrenkel/ovirt-**FILTERED**/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/upgrade/dbvalidations.py,
  line 91, in _checkDb
output=stdout,
   RuntimeError: Failed checking Engine database:
   [u'']
  
   2015-06-25 10:27:51 ERROR otopi.context context._executeMethod:164 Failed
   to execute stage 'Setup validation': Failed checking Engine database:
   [u'']
  
   
  
   looks like lately this function (fn_db_validate_fks) was moved, might be
   related?
   ( https://gerrit.ovirt.org/#/c/42655/ )
  
   i even tried to completely remove my ~/ovirt-engine/ folder and create
   from
   scratch
  
   anyone else experienced this?
  
   Thanks,
   Omer.
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
  
  
 
 
 manually running the script [1] fixed it, but upgrade is broken
 
 [1] psql -f packaging/dbscripts/fkvalidator_sp.sql
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [ovirt-users] spm changes hourly due to unexpected error of getAllTasksStatuses

[Eli Mesika]

- Original Message -
 From: like ma like...@cs2c.com.cn
 To: devel@ovirt.org, us...@ovirt.org
 Sent: Tuesday, June 23, 2015 11:26:17 AM
 Subject: [ovirt-users] spm changes hourly due to unexpected error of  
 getAllTasksStatuses
 
 Hello all,
 
 In our ovirt environment(oVirt 3.4.4), we have 2 hosts, and the spm changes
 hourly between the 2 hosts. In the events of DataCenters there is following
 message each hour:
 'Data Center is being initialized, please wait for initialization to
 complete'
 
 In the vdsm.log i found following error message:
 Thread-13::ERROR::2015-06-23
 13:38:36,667::task::866::TaskManager.Task::(_setError)
 Task=`e450d7d6-771d-4c51-90b7-c6b10da37897`::Unexpected error
 Traceback (most recent call last):
 File /usr/share/vdsm/storage/task.py, line 873, in _run
 return fn(*args, **kargs)
 File /usr/share/vdsm/logUtils.py, line 45, in wrapper
 res = f(*args, **kwargs)
 File /usr/share/vdsm/storage/hsm.py, line 2125, in getAllTasksStatuses
 allTasksStatus = sp.getAllTasksStatuses()
 File /usr/share/vdsm/storage/securable.py, line 73, in wrapper
 raise SecureError(Secured object is not in safe state)
 SecureError: Secured object is not in safe state
 
 The attachment is vdsm.log and engine.log. The error occured at 2015-06-23
 13:38 and 2015-06-23 15:38 in vdsm.log.
 (by the way, in the other host the error occured at 2015-06-23 12:38 and
 2015-06-23 14:38 )
 
 And in the engine.log i found following error message:
 2015-06-23 13:38:37,933 ERROR
 [org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand]
 (DefaultQuartzScheduler_Worker-34) [781beaea] IrsBroker::Failed::UpdateVMVDS
 due to: XmlRpcException: type 'exceptions.UnicodeDecodeError':'utf8' codec
 can't decode byte 0xeb in position 749: invalid continuation byte
 
 2015-06-23 13:38:37,971 ERROR [org.ovirt.engine.core.bll.OvfDataUpdater]
 (DefaultQuartzScheduler_Worker-34) [781beaea] Exception while trying to
 update or remove VMs/Templates ovf in Data Center Default.:
 org.ovirt.engine.core.common.errors.VdcBLLException: VdcBLLException:
 java.lang.reflect.UndeclaredThrowableException (Failed with error
 VDS_NETWORK_ERROR and code 5022)
 at org.ovirt.engine.core.bll.VdsHandler.handleVdsResult(VdsHandler.java:116)
 [bll.jar:]
 at
 org.ovirt.engine.core.bll.VDSBrokerFrontendImpl.RunVdsCommand(VDSBrokerFrontendImpl.java:33)
 [bll.jar:]
 at
 org.ovirt.engine.core.bll.OvfDataUpdater.executeUpdateVmInSpmCommand(OvfDataUpdater.java:383)
 [bll.jar:]
 at
 org.ovirt.engine.core.bll.OvfDataUpdater.performOvfUpdate(OvfDataUpdater.java:163)
 [bll.jar:]
 at
 org.ovirt.engine.core.bll.OvfDataUpdater.updateOvfForVmsOfStoragePool(OvfDataUpdater.java:135)
 [bll.jar:]
 at
 org.ovirt.engine.core.bll.OvfDataUpdater.ovfUpdate_timer(OvfDataUpdater.java:93)
 [bll.jar:]
 at sun.reflect.GeneratedMethodAccessor250.invoke(Unknown Source) [:1.7.0_65]
 at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 [rt.jar:1.7.0_65]
 at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
 at org.ovirt.engine.core.utils.timer.JobWrapper.execute(JobWrapper.java:60)
 [scheduler.jar:]
 at org.quartz.core.JobRunShell.run(JobRunShell.java:213) [quartz.jar:]
 at
 org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:557)
 [quartz.jar:]
 
 Can anyone help?

Can you please share the result of the following on both hosts ?

 echo $LANG

thanks 


 Thanks
 
 like...@cs2c.com.cn
 
 ___
 Users mailing list
 us...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/users
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.6 Localization Question #19] The selected proxy Host must be in the destination Storage Pool

[Eli Mesika]

- Original Message -
 From: Yuko Katabami ykata...@redhat.com
 To: devel@ovirt.org
 Sent: Monday, June 22, 2015 4:47:13 PM
 Subject: [ovirt-devel] [oVirt 3.6 Localization Question #19] The selected 
 proxy Host must be in the destination
 Storage Pool
 
 Hello again,
 
 Here is another question,
 
 File: AppErrors
 Resource ID: ACTION_TYPE_FAILED_VDS_NOT_IN_DEST_STORAGE_POOL
 String: Cannot ${action} ${type}. The selected proxy Host must be in the
 destination Storage Pool.
 Question: In my language, translation for the word destination may have to
 be changed depending on the action (i.e. migrate, move, import/export, copy,
 clone etc).
 What action is applicable in this case?

This error is raised when trying to import a VM from an external provider, so , 
the action is : import 

 
 Thank you,
 
 Yuko
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [UI] New/Edit host dialog is broken

[Eli Mesika]

- Original Message -
 From: Eli Mesika emes...@redhat.com
 To: Oved Ourfali oourf...@redhat.com
 Cc: devel devel@ovirt.org
 Sent: Wednesday, June 10, 2015 11:20:51 AM
 Subject: Re: [ovirt-devel] [UI] New/Edit host dialog is broken
 
 
 
 - Original Message -
  From: Oved Ourfali oourf...@redhat.com
  To: Alexander Wels aw...@redhat.com
  Cc: devel devel@ovirt.org
  Sent: Tuesday, June 9, 2015 9:22:58 PM
  Subject: Re: [ovirt-devel] [UI] New/Edit host dialog is broken
  
  
  On Jun 9, 2015 21:00, Alexander Wels aw...@redhat.com wrote:
  
   On Monday, June 08, 2015 07:38:05 AM Einav Cohen wrote:
Thanks, Eli; @Alexander - can you please investigate this?


Regards,
Einav

  
   Yes, found the problem, fixed here [1].
  
  
  Looks good to me. Thanks for the quick fix.
  Who can merge that on a short loop?
 
 I will verify it and if it is OK +2 and merge , OK ???

Now host is created in the correct cluster 
But when I create a new DC I got 
Error while executing action: A Request to the Server failed with the 
following Status Code: 500

Can you please check if related ???

 
  
  
   [1] https://gerrit.ovirt.org/#/c/42104/
  
- Original Message -

 From: Eli Mesika emes...@redhat.com
 To: engine-de...@ovirt.org devel@ovirt.org
 Cc: Einav Cohen eco...@redhat.com, Oved Ourfali
 oourf...@redhat.com, Alexander Wels aw...@redhat.com Sent:
 Monday,
 June 8, 2015 7:17:46 AM
 Subject: [UI] New/Edit host dialog is broken
 
 Hi guys
 
 I have found that new/edit host dialog is not working as expected
 
 1) Create a new DC 'mydc'
 2) Create a new cluster 'myCluster'
 3) Create a new Host on 'myCluster'
 
 Result: Host is created in Dc 'Default' and cluster 'Default'
 
 1) Edit the host you have created
 2) Change the cluster to 'myCluster'
 3) press OK
 
 Result: Host is still in Dc 'Default' and cluster 'Default'
 
 
 Thanks
 Eli Mesika
  
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
  
  
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [UI] New/Edit host dialog is broken

[Eli Mesika]

Hi guys 

I have found that new/edit host dialog is not working as expected

1) Create a new DC 'mydc'
2) Create a new cluster 'myCluster'
3) Create a new Host on 'myCluster' 

Result: Host is created in Dc 'Default' and cluster 'Default' 

1) Edit the host you have created 
2) Change the cluster to 'myCluster'
3) press OK

Result: Host is still in Dc 'Default' and cluster 'Default' 


Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] gerrit+ci improvement proposal

[Eli Mesika]

- Original Message -
 From: Oved Ourfali ov...@redhat.com
 To: Eyal Edri ee...@redhat.com
 Cc: devel@ovirt.org, in...@ovirt.org
 Sent: Thursday, June 4, 2015 10:03:02 AM
 Subject: Re: [ovirt-devel] gerrit+ci improvement proposal
 
 
 
 - Original Message -
  From: Eyal Edri ee...@redhat.com
  To: Sandro Bonazzola sbona...@redhat.com
  Cc: in...@ovirt.org, devel@ovirt.org
  Sent: Thursday, June 4, 2015 9:46:40 AM
  Subject: Re: [ovirt-devel] gerrit+ci improvement proposal
  
  
  
  - Original Message -
   From: Sandro Bonazzola sbona...@redhat.com
   To: Eyal Edri ee...@redhat.com, Max Kovgan mkov...@redhat.com
   Cc: devel@ovirt.org, in...@ovirt.org
   Sent: Thursday, June 4, 2015 9:11:10 AM
   Subject: Re: [ovirt-devel] gerrit+ci improvement proposal
   
   Il 03/06/2015 21:46, Eyal Edri ha scritto:


- Original Message -
From: Max Kovgan mkov...@redhat.com
To: devel@ovirt.org
Cc: in...@ovirt.org
Sent: Wednesday, June 3, 2015 8:22:54 PM
Subject: [ovirt-devel] gerrit+ci improvement proposal
   
Hi everyone!
We really want to have reliable and snappy CI: to allow short cycles
and
encourage developers to write tests.
   
# Problem
   
Many patches are neither ready for review nor for CI upon submission,
which
is OK.
But running all the jobs on those patches with limited resources
results
in:
overloaded resources, slow response time, unhappy developers.
   
# Proposed Solution
   
To run less jobs we know we don’t need to, thus making more resources
for
the
jobs we need to run.
We have been experimenting to make our CI stabler and quicker to
respond
by
using gerrit flags. This has improved in both directions very well
internally.
Now it seems a good time to let all the oVirt projects to use this.
This solution indirectly promotes reviews and quick tests - “to fail
early”,
yet full blown static code analysis and long tests to run “when
ready”.
   
# How it works
   
2 new gerrit independent flags are added to gerrit.
   
## CI flag
   
Will express patch CI status. Values:
 * +1 CI passed
 *  0 CI did not run yet
 * -1 CI failed
Permissions for setting: project maintainers (for special cases)
should
be
able to set/override (except Jenkins).
   
## Workflow flag
   
Will express patch “workflow” state. Values:
 *  0 Work In Progress
 * +1 Ready For Review
 * +2 Ready For Merge
Permissions for setting: Owner can set +1, Project Maintainers can set
+2
   
## Review + CI Integration:
   
Merging [“Submit” button to appear] will require: Review+1, CI+1,
Workflow+2
Patch lifecycle now is:
---
patch state   |owner |reviewer |maintainer |CI tests |pass
---
added/updated |- |-|-  |quick|CI+1
review|Workflow+1|Review+1 |-  |heavy   |CI+1
merge ready   |- |-|Workflow+2 |gating   |CI+1
merge |- |-|merge  |merge|CI+1
   
Changes from current workflow:
Owner only adds reviewers, now owner needs to set Workflow+1 for the
patch
to be reviewed, and heavily auto-tested.
Maintainer now needs to set Workflow+2 and wait for Submit button
to
appear after CI has completed running gating tests.
   
   
Next step will be to automate merge the change after Workflow+2 has
been
set
by the Maintainer and gating tests passed.
   
   
## Why now?
   
It is elimination of waste. The sooner - the better.
The solution has been used for a while and it works.
Resolving the problem without gerrit involved will lead to adding
unreliable
code into jobs, and will still be prone to problems:
  Just recently, 3d ago we’ve tried detecting what to run from jenkins
  relying only on gerrit comments so that upon Verified+1, we’d run
  the
  job.
  We could not use “Review+1”, because it makes no sense at all, so we
  left
  the job to set Verified+1.
  Meaning - re-trigger itself immediately more than 1 times.
  
  Jenkins and its visitors very unhappy, and we had to stop those
  jobs,
  clean
  up the queue, and spam developers.
   
## OK OK OK. Now what?
   
Now we want your comments and opinions before pushing this further:
Please participate in this thread, so we can start trying it out.
Ask, Suggest better ideas, all this is welcome.
   
   
Best Regards!
   
   
N.B.
Of course, this is not written in stone, in case we find a better
approach
on
solving those issues, we will change to it.
And we will keep improving so don't be afraid that it will be
enforced:
if
this does not work 

[ovirt-devel] [HELP] UI error after last rebase

[Eli Mesika]

Hi

I am getting this error on login:

Operation Canceled 
Error while executing action: A Request to the Server failed: This application 
is out of date, please click the refresh button on your browser. ( The client 
cannot accept IoThreadsSupported )

I cleaned my browser cache 

Any ideas

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] searching by tags

[Eli Mesika]

- Original Message -
 From: Yaniv Dary yd...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: Einav Cohen eco...@redhat.com, devel@ovirt.org
 Sent: Monday, March 23, 2015 4:44:28 PM
 Subject: Re: [ovirt-devel] searching by tags
 
 Eli, could this be related to the search you committed a few weeks ago?

Which one, we had many search changes lately 

 
 
 
 Yaniv
 
 On 03/11/2015 09:53 PM, Einav Cohen wrote:
  Hi,
 
  AFAIR, we used to support a hierarchical search by tag.
  i.e. if I had a parent tag Europe, and it had child-tags
  Italy and UK, a search such as: VMs: tag=Europe would
  have returned VMs that are tagged with Europe as well as
  VMs tagged with any child-tags of Europe (i.e. VMs that
  are tagged with UK or Italy); however, this doesn't seem
  to be the case anymore [see http://i.imgur.com/85rZbZj.png].
 
  [I am running master from ~3 weeks ago]
 
  Any idea why?
 
  Thanks.
 
  
  Regards,
  Einav
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 --
 Yaniv Dary
 Red Hat Israel Ltd.
 34 Jerusalem Road
 Building A, 4th floor
 Ra'anana, Israel 4350109
 
 Tel : +972 (9) 7692306
 8272306
 Email: yd...@redhat.com
 IRC : ydary
 
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] Important changes in the Search Engine code

[Eli Mesika]

Hi All

We had in the past many cases in which the search engine returned duplicate 
records.
Most of those cases are not simple to resolve in the DB layer by changing the 
query due to schema limitations.
We had decided to handle that by adding DISTINCT to the queries that the search 
engine generates  [1]
However, we might have cases in which both DISTINCT and ORDER BY f({args}) 
(where f is a function call) is used 
In that case, we will get SQL exception since the ORDER BY is applied on the 
DISTINCT result that does not include f as a field.
I had prevented using DISTINCT in such cases [2]
That means that you still may got duplicates in such cases and then you should 
handle it in the same method as in [3]
(basically returning the function result in the select as a computed field)


[1] https://gerrit.ovirt.org/#/c/31896
[2] https://gerrit.ovirt.org/#/c/38459
[3] https://gerrit.ovirt.org/#/c/36946


Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Important changes in the Search Engine code

[Eli Mesika]

- Original Message -
 From: Moti Asayag masa...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: engine-de...@ovirt.org devel@ovirt.org
 Sent: Wednesday, March 11, 2015 11:53:50 AM
 Subject: Re: [ovirt-devel] Important changes in the Search Engine code
 
 
 
 - Original Message -
  From: Eli Mesika emes...@redhat.com
  To: engine-de...@ovirt.org devel@ovirt.org
  Sent: Wednesday, March 11, 2015 10:48:44 AM
  Subject: [ovirt-devel] Important changes in the Search Engine code
  
  Hi All
  
  We had in the past many cases in which the search engine returned duplicate
  records.
  Most of those cases are not simple to resolve in the DB layer by changing
  the
  query due to schema limitations.
  We had decided to handle that by adding DISTINCT to the queries that the
  search engine generates  [1]
 
 Wouldn't that cause some penalty for each query ? Each navigation between
 tabs in
 the UI will become slower now that the returned values need to be sorted,
 even when
 not required ?

We had tested that for a while and  the penalty is relatively small.
We surely can come with a better solution but it requires heavy schema changes 
I think we can live with that 

 
  However, we might have cases in which both DISTINCT and ORDER BY f({args})
  (where f is a function call) is used
  In that case, we will get SQL exception since the ORDER BY is applied on
  the
  DISTINCT result that does not include f as a field.
  I had prevented using DISTINCT in such cases [2]
  That means that you still may got duplicates in such cases and then you
  should handle it in the same method as in [3]
  (basically returning the function result in the select as a computed field)
  
  
  [1] https://gerrit.ovirt.org/#/c/31896
  [2] https://gerrit.ovirt.org/#/c/38459
  [3] https://gerrit.ovirt.org/#/c/36946
  
  
  Thanks
  Eli Mesika
  
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Proposing Sahina Bose as oVirt core maintainer

[Eli Mesika]

- Original Message -
 From: Oved Ourfali ov...@redhat.com
 To: engine-de...@ovirt.org devel@ovirt.org
 Sent: Sunday, March 1, 2015 1:56:55 PM
 Subject: [ovirt-devel] Proposing Sahina Bose as oVirt core maintainer
 
 Hi all!
 
 I would like to propose Sahina Bose as an engine-core maintainer, with
 regards to Gluster related code.
 Sahina joined the oVirt project two years ago, and has since contributed over
 150 patches, and has been instrumental in reviews of all Gluster patches.
 
 Will appreciate your response!


+1 

 
 Thanks,
 Oved
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Gerrit update

[Eli Mesika]

Another nice feature added is full keyboard support so you can do anything with 
your keyboard.
Most used by me is the ']' and '[' to got to Next/Prev file in the patch 

- Original Message -
 From: David Caro dcaro...@redhat.com
 To: Infra in...@ovirt.org, devel@ovirt.org
 Sent: Monday, February 23, 2015 8:29:03 PM
 Subject: Re: Gerrit update
 
 
 
 Some relevant new features that might be missed:
 
 == UI
 * Add My  Groups menu entry that shows the list of own groups.
 * Added option to quickly add current user as reviewer of a change.
  An Add Me button is displayed next to the Add button when searching for
  reviewers to add to a change. This allows users to quickly add
  themselves
  as a reviewer on the change without having to type their name in the
  search box.
 
 == Side-by-Side Diff Screen
 * Allow the user to select the syntax highlighter.
 * Add Shift-a keybinding to show/hide left side.
 * Add syntax highlighting of the commit message.
 
 == Change List / Dashboards
 * Add option to show Change-ID in the change table.
 
 
 == Project Screens
 * Add branch actions to Projects  Branches view.
 
 == User Preferences
 * Users can customize the contents of the My menu from the preferences
 screen.
 * Replace Display name in review category preference with a list of options.
 Including new options Show Abbreviated Name to display Abbreviated
 reviewer names and Show Username to show usernames in the change list.
 
 
 For a full list you can check the release notes:
 
   
 https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.10.html
 
 
 Enjoy!
 
 On 02/23, David Caro wrote:
  
  Gerrit has been upgraded successfully, I'll be monitoring it through the
  day to
  make sure nothing pops up, but if you see anything strange please ping me.
  
  
  
  Thanks!
  
  
  
  
  On 02/23, David Caro wrote:
   
   Hi everyone!
   
   As of right now, gerrit is being updated to 2.10 [1] I will notice when
   it's
   ready, in the meantime you (or jenkins) will not be able to use it.
   
   
  
  I forgot the link:
  
  [1]
  https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.10.html
  
   
   Cheers!
   
   
   --
   David Caro
   
   Red Hat S.L.
   Continuous Integration Engineer - EMEA ENG Virtualization RD
   
   Tel.: +420 532 294 605
   Email: dc...@redhat.com
   Web: www.redhat.com
   RHT Global #: 82-62605
  
  
  
   ___
   Infra mailing list
   in...@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/infra
  
  
  --
  David Caro
  
  Red Hat S.L.
  Continuous Integration Engineer - EMEA ENG Virtualization RD
  
  Tel.: +420 532 294 605
  Email: dc...@redhat.com
  Web: www.redhat.com
  RHT Global #: 82-62605
 
 
 
 --
 David Caro
 
 Red Hat S.L.
 Continuous Integration Engineer - EMEA ENG Virtualization RD
 
 Tel.: +420 532 294 605
 Email: dc...@redhat.com
 Web: www.redhat.com
 RHT Global #: 82-62605
 
 ___
 Infra mailing list
 in...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/infra
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [DB] Diffrent UUIDs for inserted data per installation

[Eli Mesika]

- Original Message -
 From: Lior Vernia lver...@redhat.com
 To: Moti Asayag masa...@redhat.com
 Cc: Martin Mucha mmu...@redhat.com, engine-de...@ovirt.org 
 devel@ovirt.org, Eli Mesika emes...@redhat.com
 Sent: Thursday, January 29, 2015 2:46:40 PM
 Subject: Re: [ovirt-devel] [DB] Diffrent UUIDs for inserted data per 
 installation
 
 Apologies for the late response...
 
 On 25/01/15 13:44, Moti Asayag wrote:
  
  
  - Original Message -
  From: Eli Mesika emes...@redhat.com
  To: Sahina Bose sab...@redhat.com, Allon Mureinik
  amure...@redhat.com, Arik Hadas aha...@redhat.com,
  Mike Kolesnik mkole...@redhat.com, Gilad Chaplik
  gchap...@redhat.com
  Cc: engine-de...@ovirt.org devel@ovirt.org
  Sent: Wednesday, January 21, 2015 6:05:51 PM
  Subject: [ovirt-devel] [DB] Diffrent UUIDs for inserted data per
  installation
 
  Hi
 
  I am trying to cleanup all the data insertion to the engine DB and make it
  more general
  The main drive to that is DB version squashing that was done manually and
  therefor was error prone ...
 
  I know that both storage_pool_id (a.k.a DC) and vds_group_id (a.k.a
  Cluster)
  needs to get a different UUID per installation.
  But I had found that UUIDs are generated per installation for also :
 
  table  |   column/s
  
 
  [cpu_profiles] : id
 
  [gluster_services] : id
 
  [mac_pools] : id
 
  
  Added Martin to comment on this one. AFAIK the id can be static for
  all installations.
  
 
 Looks okay to have a static ID for the default MAC pool.
 
  [permissions] : id, object_id
 
  [vm_device]: device_id, vm_id
 
  [vm_static] : vm_guid
 
  [vnic_profiles] : id
 
  
  Added Lior to comment. In any case, we can evaluate the id by querying
  by name, hence the specific value id value shouldn't be important.
  
 
 We don't need to have distinct IDs by installation, however the current
 upgrade script creating the IDs (03_03_0710) creates one for each
 existing network, and every deployment will have its own networks... If
 your change might affect upgrades from versions  3.3, then I don't see
 how you could achieve this using static IDs.

That's not a problem
Keep in mind that we are squashing always (latest-version - 3)
So, when we squash this 03_03_0710 script 

1) upgrade for current installations will be supported only from 3.4 and up, 
that means that DB already run the 03_03_0710 script.
2) new installation , and then we have no problem either 

The main point is that we squash only when we DON'T SUPPORT and upgrade from 
the squashed version, so he problem you had mentioned never occurs 

 
 
  Please let me know if any of the above should be generated using the
  uuid_generate_v1() function on each installation or we can have static IDs
  for those.
 
   
 
  Thanks
  Eli Mesika
 
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Upgrade job is failing while upgrading from 3.4.4 to 3.5.2-snapshot:

[Eli Mesika]

I had succeeded to do the upgrade manually without any problem
This seems to be related to the engine-setup when it calls the task cleaner SPs

Didi, can you have a look ?

- Original Message -
 From: Sandro Bonazzola sbona...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: devel@ovirt.org, Yair Zaslavsky yzasl...@redhat.com, infra 
 in...@ovirt.org
 Sent: Wednesday, January 28, 2015 2:09:31 PM
 Subject: Re: [ovirt-devel] Upgrade job is failing while upgrading from 3.4.4 
 to   3.5.2-snapshot:
 
 Il 28/01/2015 14:05, Eli Mesika ha scritto:
  
  
  - Original Message -
  From: Sandro Bonazzola sbona...@redhat.com
  To: devel@ovirt.org, Yair Zaslavsky yzasl...@redhat.com, infra
  in...@ovirt.org
  Sent: Tuesday, January 27, 2015 5:54:24 PM
  Subject: [ovirt-devel] Upgrade job is failing while upgrading from 3.4.4
  to 3.5.2-snapshot:
 
  Upgrade job is failing while upgrading from 3.4.4 to 3.5.2-snapshot:
  
  Sandro , please specify which git tags/commit hash matches the above so I
  can reproduce
 
 3.4.4 is from ovirt-3.4 repository, corresponding to the 3.4.4 tag.
 3.5.2-snapshot was at 652a8ef4c1a09ab98a6ca2783eaa74bf01be2cf1.
 
 
  
  Thanks
  
 
  2015-01-27 15:02:46 DEBUG
  otopi.plugins.ovirt_engine_setup.ovirt_engine.upgrade.asynctasks
  plugin.execute:866 execute-output:
  ('/usr/share/ovirt-engine/setup/dbutils/taskcleaner.sh', '-l',
  '/var/log/ovirt-engine/setup/ovirt-engine-setup-20150127150216-p4ixpj.log',
  '-u',
  'engine', '-s', 'localhost', '-p', '5432', '-d', 'engine', '-R', '-A',
  '-J',
  '-q') stderr:
  psql:/usr/share/ovirt-engine/setup/dbutils/taskcleaner_sp.sql:145: ERROR:
  type command_entities does not exist
  FATAL: Cannot execute sql command:
  --file=/usr/share/ovirt-engine/setup/dbutils/taskcleaner_sp.sql
 
  2015-01-27 15:02:46 DEBUG otopi.context context._executeMethod:152 method
  exception
  Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/otopi/context.py, line 142, in
_executeMethod
  method['method']()
File

  /usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py,
line 422, in _validateZombies
  self._clearZombieTasks()
File

  /usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py,
line 156, in _clearZombieTasks
  'Failed to clear zombie tasks. Please access support '
  RuntimeError: Failed to clear zombie tasks. Please access support in
  attempt
  to resolve the problem
  2015-01-27 15:02:46 ERROR otopi.context context._executeMethod:161 Failed
  to
  execute stage 'Setup validation': Failed to clear zombie tasks. Please
  access support in attempt to resolve the problem
 
  Please fix ASAP.
 
  Reference:
  http://jenkins.ovirt.org/job/ovirt-engine_3.5_upgrade-from-3.4_merged/label=el6/1360/
 
 
  --
  Sandro Bonazzola
  Better technology. Faster innovation. Powered by community collaboration.
  See how it works at redhat.com
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
 
 
 
 --
 Sandro Bonazzola
 Better technology. Faster innovation. Powered by community collaboration.
 See how it works at redhat.com
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [DB] Diffrent UUIDs for inserted data per installation

[Eli Mesika]

Hi

I am trying to cleanup all the data insertion to the engine DB and make it more 
general 
The main drive to that is DB version squashing that was done manually and 
therefor was error prone ...

I know that both storage_pool_id (a.k.a DC) and vds_group_id (a.k.a Cluster) 
needs to get a different UUID per installation.
But I had found that UUIDs are generated per installation for also :

table  |   column/s


[cpu_profiles] : id

[gluster_services] : id

[mac_pools] : id

[permissions] : id, object_id

[vm_device]: device_id, vm_id

[vm_static] : vm_guid

[vnic_profiles] : id 


Please let me know if any of the above should be generated using the 
uuid_generate_v1() function on each installation or we can have static IDs for 
those.

 

Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Adding support for 3.6 in engine database

[Eli Mesika]

- Original Message -
 From: Lior Vernia lver...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: engine-de...@ovirt.org devel@ovirt.org, Dan Kenigsberg 
 dan...@redhat.com, Yaniv Bronheim
 ybron...@redhat.com
 Sent: Thursday, January 8, 2015 3:08:24 PM
 Subject: Re: [ovirt-devel] Adding support for 3.6 in engine database
 
 Tried to work with it, and noticed that:
 1. The engine doesn't list 4.17 as a supported vdsm version.
 2. 4.17 vdsm doesn't report 3.6 as a supported engine version.
 
 This basically means that no host could be operational in a 3.6 cluster,
 as to my understanding 4.17 is exactly the version supporting 3.6
 functionality.
 
 May I send a fix for (1), or is there any argument against? And who
 could take care of (2)?

I had understood deom Oved that this is 4.16 see patch 
http://gerrit.ovirt.org/#/c/36511/
Oved ???


 
 Yours, Lior.
 
 On 07/01/15 14:53, Eli Mesika wrote:
  Hi
  
  Please note that 3.6 version support was added to master, default
  DC/Cluster are created now with 3.6 and all config changes we applied.
  For more information : http://gerrit.ovirt.org/#/c/36518/
  
  Thanks
  Eli Mesika
  
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Adding support for 3.6 in engine database

[Eli Mesika]

- Original Message -
 From: Eli Mesika emes...@redhat.com
 To: Lior Vernia lver...@redhat.com
 Cc: Oved Ourfali ov...@redhat.com, Dan Kenigsberg dan...@redhat.com, 
 engine-de...@ovirt.org
 devel@ovirt.org, Yaniv Bronheim ybron...@redhat.com
 Sent: Thursday, January 8, 2015 4:06:58 PM
 Subject: Re: [ovirt-devel] Adding support for 3.6 in engine database
 
 
 
 - Original Message -
  From: Lior Vernia lver...@redhat.com
  To: Oved Ourfali ov...@redhat.com
  Cc: Dan Kenigsberg dan...@redhat.com, engine-de...@ovirt.org
  devel@ovirt.org, Yaniv Bronheim
  ybron...@redhat.com, Eli Mesika emes...@redhat.com
  Sent: Thursday, January 8, 2015 3:48:53 PM
  Subject: Re: [ovirt-devel] Adding support for 3.6 in engine database
  
  
  
  On 08/01/15 15:46, Oved Ourfali wrote:
   
   
   - Original Message -
   From: Eli Mesika emes...@redhat.com
   To: Lior Vernia lver...@redhat.com, Oved Ourfali
   oourf...@redhat.com
   Cc: engine-de...@ovirt.org devel@ovirt.org, Dan Kenigsberg
   dan...@redhat.com, Yaniv Bronheim
   ybron...@redhat.com
   Sent: Thursday, January 8, 2015 3:41:31 PM
   Subject: Re: [ovirt-devel] Adding support for 3.6 in engine database
  
  
  
   - Original Message -
   From: Lior Vernia lver...@redhat.com
   To: Eli Mesika emes...@redhat.com
   Cc: engine-de...@ovirt.org devel@ovirt.org, Dan Kenigsberg
   dan...@redhat.com, Yaniv Bronheim
   ybron...@redhat.com
   Sent: Thursday, January 8, 2015 3:08:24 PM
   Subject: Re: [ovirt-devel] Adding support for 3.6 in engine database
  
   Tried to work with it, and noticed that:
   1. The engine doesn't list 4.17 as a supported vdsm version.
   2. 4.17 vdsm doesn't report 3.6 as a supported engine version.
  
   This basically means that no host could be operational in a 3.6
   cluster,
   as to my understanding 4.17 is exactly the version supporting 3.6
   functionality.
  
   May I send a fix for (1), or is there any argument against? And who
   could take care of (2)?
  
   I had understood deom Oved that this is 4.16 see patch
   http://gerrit.ovirt.org/#/c/36511/
   Oved ???
  
   
   I don't know when we should add 4.17. I remember there is some policy
   for
   that.
   Dan?
   
  
  And as for Eli's question, if I'm not mistaken 4.16 corresponded to 3.5.
 
 I don't think so, it was merged upstream in Jan 1 2015 and does not have a
 downstream backport ... , 3.5 is already on the air

Sorry, my bad , it was merged to 3.5 as well ... so we will have to get clear 
answer to 3.6 

 
  
  
  
   Yours, Lior.
  
   On 07/01/15 14:53, Eli Mesika wrote:
   Hi
  
   Please note that 3.6 version support was added to master, default
   DC/Cluster are created now with 3.6 and all config changes we applied.
   For more information : http://gerrit.ovirt.org/#/c/36518/
  
   Thanks
   Eli Mesika
  
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
  
  
  
  
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Bump to 3.6 default cluster version

[Eli Mesika]

- Original Message -
 From: Lior Vernia lver...@redhat.com
 To: devel@ovirt.org
 Cc: Eli Mesika emes...@redhat.com
 Sent: Thursday, January 1, 2015 3:42:18 PM
 Subject: Bump to 3.6 default cluster version
 
 Hello,
 
 Could we add the 3.6 version on master and change that to the default
 DC/cluster version? Some features are already merged, so they could be
 used and bugs could be found earlier by people working on master (mostly
 us developers I guess) once the version is bumped.
 
 I saw 6199b29506253eeae9712afea71a3641727de71b for 3.5 - however, I'm
 not sure I understand the logic behind what config values need to be
 added for old features to work, so I'd prefer not to be the one sending
 the patch.

I already sent a draft on that 
http://gerrit.ovirt.org/#/c/36518/
I need reviews from network, storage , gluster  virt

 
 Yours, Lior.
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Fwd: Got an error after buuilding VDSM on latest upstream commit

[Eli Mesika]

- Original Message -
 From: Dan Kenigsberg dan...@redhat.com
 To: ybronhei ybron...@redhat.com, ibar...@redhat.com
 Cc: devel@ovirt.org
 Sent: Monday, December 1, 2014 3:12:39 AM
 Subject: Re: [ovirt-devel] Fwd: Got an error after buuilding VDSM on latest 
 upstream commit
 
 On Sun, Nov 30, 2014 at 01:00:28PM +0200, ybronhei wrote:
  forwarding to devels
  
  anyone familiar with the issue already ? any ready patch?
  
  
   Forwarded Message 
  Subject: Got an error after buuilding VDSM on latest upstream commit
  Date: Sun, 30 Nov 2014 05:54:45 -0500 (EST)
  From: Eli Mesika emes...@redhat.com
  To: Dan Kenigsberg dan...@redhat.com, Saggi Mizrahi
  smizr...@redhat.com,
  ybronhei ybron...@redhat.com, Dima Kuznetsov dkuzn...@redhat.com
  CC: Oved Ourfali oourf...@redhat.com, Barak Azulay bazu...@redhat.com
  
  vdsm: Running restore_nets
  libvirt: Network Driver error : Network not found: no network with matching
  name 'vdsm-ovirtmgmt'
  ^X^CTraceback (most recent call last):
File /usr/share/vdsm/vdsm-restore-net-config, line 139, in module
  restore()
File /usr/share/vdsm/vdsm-restore-net-config, line 125, in restore
  unified_restoration()
File /usr/share/vdsm/vdsm-restore-net-config, line 70, in
  unified_restoration
  setupNetworks(nets, bonds, connectivityCheck=False, _inRollback=True)
File /usr/share/vdsm/network/api.py, line 715, in setupNetworks
  implicitBonding=True, _netinfo=_netinfo, **d)
File /usr/share/vdsm/network/api.py, line 221, in wrapped
  ret = func(**attrs)
File /usr/share/vdsm/network/api.py, line 310, in addNetwork
  netEnt.configure(**options)
File /usr/share/vdsm/network/models.py, line 196, in configure
  self.configurator.configureBridge(self, **opts)
File /usr/share/vdsm/network/configurators/ifcfg.py, line 92, in
  configureBridge
  ifup(bridge.name, bridge.ipConfig.async)
File /usr/share/vdsm/network/configurators/ifcfg.py, line 820, in ifup
  rc, out, err = _ifup(iface)
File /usr/share/vdsm/network/configurators/ifcfg.py, line 804, in _ifup
  rc, out, err = utils.execCmd([constants.EXT_IFUP, netIf], raw=False)
File /usr/lib/python2.6/site-packages/vdsm/utils.py, line 622, in
  execCmd
  (out, err) = p.communicate(data)
File /usr/lib64/python2.6/subprocess.py, line 732, in communicate
  stdout, stderr = self._communicate(input, endtime)
File /usr/lib64/python2.6/subprocess.py, line 1316, in _communicate
  stdout, stderr = self._communicate_with_poll(input, endtime)
File /usr/lib64/python2.6/subprocess.py, line 1388, in
  _communicate_with_poll
  ready = poller.poll(self._remaining_time(endtime))
 
 
 The traceback seems snipped. I woder which exception is raised deep
 done.
 
 As it happens with our new unified_restoration() of network definitions,
 please share the content of your /var/lib/vdsm/netconf/*

I already had to move on and redefine my network in order to continue my tasks 
All I can say that I had recently installed tested neutron on that host 

 
 Could it be that a network there referes to a nic that no longer exists?
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

[ovirt-devel] [db] add config key with same value to multiple versions

[Eli Mesika]

Hi

Please note that I have added a common function to ease handling of 
configuration settings: 

signature : fn_db_add_config_value_for_versions_up_to(v_option_name, v_val , 
v_version )

so, for example, if you want to add a new feature F1 flag, which is true only 
for 3.6,  to _config.sql instead of :

select fn_db_add_config_value('F1','false','3.0');
select fn_db_add_config_value('F1','false','3.1');
select fn_db_add_config_value('F1','false','3.2');
select fn_db_add_config_value('F1','false','3.3');
select fn_db_add_config_value('F1','false', '3.4');
select fn_db_add_config_value('F1','true', '3.5');

All you have to do is :

fn_db_add_config_value_for_versions_up_to('F1','true', '3.5');

This is true also for other values, for example if you have a key K1 that has 
values 'a' for {3.0, 3.1} and 'b' for {3.2, 3.3, 3.4, 3.5)

instead of 

select fn_db_add_config_value('K1','a','3.0');
select fn_db_add_config_value('K1','a','3.1');
select fn_db_add_config_value('K1','b','3.2');
select fn_db_add_config_value('K1','b','3.3');
select fn_db_add_config_value('K1','b', '3.4');
select fn_db_add_config_value('K1','b', '3.5');

simply write :

fn_db_add_config_value_for_versions_up_to('K1','a', '3.1');
fn_db_add_config_value_for_versions_up_to('K1','b', '3.5');



Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [db] add config key with same value to multiple versions

[Eli Mesika]

- Original Message -
 From: Eli Mesika emes...@redhat.com
 To: engine-de...@ovirt.org devel@ovirt.org
 Sent: Monday, November 17, 2014 12:40:53 PM
 Subject: [ovirt-devel] [db] add config key with same value to multiple
 versions
 
 Hi
 
 Please note that I have added a common function to ease handling of
 configuration settings:
 
 signature : fn_db_add_config_value_for_versions_up_to(v_option_name, v_val ,
 v_version )
 
 so, for example, if you want to add a new feature F1 flag, which is true only
 for 3.6,  to _config.sql instead of :
 
 select fn_db_add_config_value('F1','false','3.0');
 select fn_db_add_config_value('F1','false','3.1');
 select fn_db_add_config_value('F1','false','3.2');
 select fn_db_add_config_value('F1','false','3.3');
 select fn_db_add_config_value('F1','false', '3.4');
 select fn_db_add_config_value('F1','true', '3.5');
sorry, this one is 
select fn_db_add_config_value('F1','false', '3.5');

 
 All you have to do is :
 
 fn_db_add_config_value_for_versions_up_to('F1','true', '3.5');
 
 This is true also for other values, for example if you have a key K1 that has
 values 'a' for {3.0, 3.1} and 'b' for {3.2, 3.3, 3.4, 3.5)
 
 instead of
 
 select fn_db_add_config_value('K1','a','3.0');
 select fn_db_add_config_value('K1','a','3.1');
 select fn_db_add_config_value('K1','b','3.2');
 select fn_db_add_config_value('K1','b','3.3');
 select fn_db_add_config_value('K1','b', '3.4');
 select fn_db_add_config_value('K1','b', '3.5');
 
 simply write :
 
 fn_db_add_config_value_for_versions_up_to('K1','a', '3.1');
 fn_db_add_config_value_for_versions_up_to('K1','b', '3.5');
 
 
 
 Thanks
 Eli Mesika
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] GWT-Platform MVP tech session - anyone interested?

[Eli Mesika]

+1

- Original Message -
 From: Vojtech Szocs vsz...@redhat.com
 To: devel@ovirt.org
 Sent: Friday, November 7, 2014 9:13:17 PM
 Subject: [ovirt-devel] GWT-Platform MVP tech session - anyone interested?
 
 Hi guys,
 
 few days ago, I gave my ancient (Dec 2011!) GWT-Platform [1]
 Model-View-Presenter tech session to a couple of colleagues
 so that they better understand our frontend infra/structure.
 
 [1] https://github.com/ArcBees/GWTP
 
 This session was meant to explain the core concepts of GWTP
 framework. Would anyone from community be interested in this
 session?
 
 Regards,
 Vojtech
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [Devel] Proposing Roy Golan as VDSM Fake maintainer

[Eli Mesika]

- Original Message -
 From: Tomas Jelinek tjeli...@redhat.com
 To: infra in...@ovirt.org, engine-de...@ovirt.org devel@ovirt.org
 Cc: Liran Zelkha lzel...@redhat.com, users us...@ovirt.org
 Sent: Thursday, November 6, 2014 10:33:07 AM
 Subject: [ovirt-devel] [Devel] Proposing Roy Golan as VDSM Fake maintainer
 
 Hi,
 
 I would like to propose Roy Golan as VDSM Fake
 (http://www.ovirt.org/VDSM_Fake) co-maintainer.
 
 Your response would be appreciated.

+1

 
 Thanks in advance.
 Tomas
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Propose Shirly Radco as DWH Reports Maintainer.

[Eli Mesika]

- Original Message -
 From: Yaniv Dary yd...@redhat.com
 To: devel@ovirt.org, infra in...@ovirt.org
 Sent: Thursday, September 18, 2014 3:02:19 PM
 Subject: [ovirt-devel] Propose Shirly Radco as DWH  Reports Maintainer.
 
 Hi,
 Shirly Radco has contributed many features, bug fixes and documentation
 enhancements for DWH  Reports
 and has taken a major role in the project progress and management in the last
 9 months.
 
 I would like to propose Shirly as a  DWH  Reports projects Maintainer.
 
 I would like to thank Shirly for her great contribution and hope she will
 keep up the good work!

+1

 
 
 
 
 ---
 Yaniv Dary
 BI Software Engineer
 Red Hat Israel Ltd.
 34 Jerusalem Road
 Building A, 4th floor
 Ra'anana, Israel 4350109
 
 Tel : +972 (9) 7692306
 8272306
 Email: yd...@redhat.com
 IRC : Yaniv D
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [ovirt-users] oVirt 3.5.0 release schedule updated

[Eli Mesika]

- Original Message -
 From: Sandro Bonazzola sbona...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: us...@ovirt.org, devel@ovirt.org
 Sent: Thursday, August 21, 2014 8:55:42 AM
 Subject: Re: [ovirt-users] oVirt 3.5.0 release schedule updated
 
 Il 20/08/2014 23:13, Eli Mesika ha scritto:
  
  
  - Original Message -
  From: Sandro Bonazzola sbona...@redhat.com
  To: us...@ovirt.org, devel@ovirt.org
  Sent: Wednesday, August 20, 2014 5:49:53 PM
  Subject: [ovirt-users] oVirt 3.5.0 release schedule updated
 
  Here is the updated schedule for oVirt 3.5.0 after today oVirt sync
  meeting
  discussion.
  These are tentative planning dates and may change:
 
  General availability: 2014-09-17 (Wed)
  oVirt 3.5 Third Test Day: 2014-09-11 (Thu)
  
  Sandro, please note that the TLV office have a summer event in this date
  from 14:00 local time
  (We have to drive about an hour to the event location, what makes our day
  work end around 13:00)
 
 Better to anticipate to 2014-09-10 (Wed)?

Yes

 
 
 
  
  
  RC2 Build:2014-09-03 (Wed)
  Build refresh:2014-08-21 (Thu)
 
  Release management page has been updated accordingly:
  http://www.ovirt.org/OVirt_3.5_release-management
 
  oVirt Google Calendar has been updated accordingly:
  ICAL:
  https://www.google.com/calendar/ical/ppqtk46u9cglj7l987ruo2l0f8%40group.calendar.google.com/public/basic.ics
  XML:
  https://www.google.com/calendar/feeds/ppqtk46u9cglj7l987ruo2l0f8%40group.calendar.google.com/public/basic
  HTML:
  https://www.google.com/calendar/embed?src=ppqtk46u9cglj7l987ruo2l0f8%40group.calendar.google.comctz=UTC
 
 
  Thanks,
 
  --
  Sandro Bonazzola
  Better technology. Faster innovation. Powered by community collaboration.
  See how it works at redhat.com
  ___
  Users mailing list
  us...@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/users
 
 
 
 --
 Sandro Bonazzola
 Better technology. Faster innovation. Powered by community collaboration.
 See how it works at redhat.com
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.5 Localization Question #13] Cannot ${action} ${type}. Cannot change QoS data center.

[Eli Mesika]

- Original Message -
 From: Yuko Katabami ykata...@redhat.com
 To: devel@ovirt.org
 Sent: Wednesday, August 20, 2014 8:22:42 AM
 Subject: [ovirt-devel] [oVirt 3.5 Localization Question #13] Cannot 
 ${action} ${type}. Cannot change QoS data
 center.
 
 Hello again,
 
 Another question has been raised.
 
 File: AppErrors
 Resource ID: ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_CONSISTENT
 String: Cannot ${action} ${type}. Cannot change QoS data center.
 Question: Could anyone explain what this string means? Does it mean Cannot
 change a data center's QoS settings?

Hi Yuko
This message is generated when you attempt to update Qos data and change also 
the DC id which is forbidden.
The validation checks that the same DC id known to the persisted entity before 
the update is used

Eli

 
 Thank you,
 
 Yuko
 
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [ovirt-users] oVirt 3.5.0 release schedule updated

[Eli Mesika]

- Original Message -
 From: Sandro Bonazzola sbona...@redhat.com
 To: us...@ovirt.org, devel@ovirt.org
 Sent: Wednesday, August 20, 2014 5:49:53 PM
 Subject: [ovirt-users] oVirt 3.5.0 release schedule updated
 
 Here is the updated schedule for oVirt 3.5.0 after today oVirt sync meeting
 discussion.
 These are tentative planning dates and may change:
 
 General availability: 2014-09-17 (Wed)
 oVirt 3.5 Third Test Day: 2014-09-11 (Thu)

Sandro, please note that the TLV office have a summer event in this date from 
14:00 local time
(We have to drive about an hour to the event location, what makes our day work 
end around 13:00)


 RC2 Build:2014-09-03 (Wed)
 Build refresh:2014-08-21 (Thu)
 
 Release management page has been updated accordingly:
 http://www.ovirt.org/OVirt_3.5_release-management
 
 oVirt Google Calendar has been updated accordingly:
 ICAL:
 https://www.google.com/calendar/ical/ppqtk46u9cglj7l987ruo2l0f8%40group.calendar.google.com/public/basic.ics
 XML:
 https://www.google.com/calendar/feeds/ppqtk46u9cglj7l987ruo2l0f8%40group.calendar.google.com/public/basic
 HTML:
 https://www.google.com/calendar/embed?src=ppqtk46u9cglj7l987ruo2l0f8%40group.calendar.google.comctz=UTC
 
 
 Thanks,
 
 --
 Sandro Bonazzola
 Better technology. Faster innovation. Powered by community collaboration.
 See how it works at redhat.com
 ___
 Users mailing list
 us...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/users
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.5 Localization Question #12] Error message that are enclosed in double quotation marks

[Eli Mesika]

- Original Message -
 From: Yuko Katabami ykata...@redhat.com
 To: devel@ovirt.org
 Sent: Tuesday, August 19, 2014 12:18:59 PM
 Subject: [ovirt-devel] [oVirt 3.5 Localization Question #12] Error message 
 that are enclosed in double quotation
 marks
 
 Hello again,
 
 Sorry for increasing your mail traffic, this is my last question for today.
 
 There are error messages starting with Cannot ${action} ${type}, and entire
 message is enclosed in a set of double quotation marks:
 
 Cannot ${action} ${type}. The specified disk snapshots don't belong to the
 same Disk.
 Cannot ${action} ${type}. SCSI Generic IO is not supported for image disk.
 Cannot ${action} ${type}. SCSI device pass-throguh is not supported for a
 read-only disk.
 
 (also found typos in pass-throguh = pass-through)
 
 Other similar error messages are not enclosed in double quotation marks.
 Are the quotation marks there for separating the message from other text?
 Should we keep those quotation marks (or equivalent symbols for each
 language) in our translation?

Hi Yuko
Those quotation marks are redundant and should be removed 
Can you please open a BZ describing this plus the typos and send me its BZ ID
I will handle that 

Thanks
Eli

 
 Kind regards,
 
 Yuko
 
 
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [ATTN] GWT Debug mode is now 2x faster!

[Eli Mesika]

- Original Message -
 From: Greg Sheremeta gsher...@redhat.com
 To: devel@ovirt.org
 Sent: Wednesday, August 6, 2014 3:09:03 PM
 Subject: [ovirt-devel] [ATTN] GWT Debug mode is now 2x faster!
 
 [changing the subject to be more noticeable]
 
 All,
 
 Alexander did some great work making GWT debug mode at least 2x faster.
 It is now *very* usable.
 
 I have previously avoided it, but now it's pretty awesome. If you have
 avoided
 it like me, give it a try!
 
 Tip:
 make gwt-debug DEBUG_MODULE=webadmin
 DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS=-Dgwt.cssResourceStyle=pretty
 will un-obfuscate CSS classes for you. Very helpful with debugging UI stuff.
 
 Greg

Hi
Well done 
Can the README.developer file be modified with this information?

Thanks 


 
 - Original Message -
  From: Vojtech Szocs vsz...@redhat.com
  To: devel@ovirt.org
  Cc: aw...@redhat.com, eco...@redhat.com, gsher...@redhat.com
  Sent: Wednesday, July 30, 2014 11:19:46 AM
  Subject: Re: GWT debug slowness.
  
  Hi Alex,
  
  (adding devel list to share it with others)
  
  I really appreciate that you took the time to analyze GWT EventBus
  activity!
  
  As we discussed on IRC, @ProxyEvent in AbstractSubTabPresenter is the most
  likely cause of overall UI slowness after successful user authentication.
  Fix for this should be rather easy and harmless, please add me as reviewer
  once you come up with the relevant patch.
  
  Another thing is refresh on logout for all (both) GWT applications. This
  is mainly due to planned SSO changes (there will be a dedicated interactive
  login page for entire Engine); for us it means that login section of all
  GWT applications will be unnecessary. Before that, however, we can already
  implement refresh on logout. As a nice side effect, we can remove some of
  our infra (UiCommonInitEvent  friends) to make it more simple.
  
  Please find some more comments below (inline).
  
  Thanks,
  Vojtech
  
  
  - Original Message -
   From: Alexander Wels aw...@redhat.com
   To: vsz...@redhat.com
   Cc: eco...@redhat.com, gsher...@redhat.com
   Sent: Friday, July 25, 2014 7:59:56 PM
   Subject: Re: GWT debug slowness.
   
   On Friday, July 25, 2014 09:28:33 AM Alexander Wels wrote:
Vojtech,

I know you suggested that maybe the event bus was getting overloaded
with
events might be the cause of the slowness in the GWT debug mode. So I
modified the event bus implementation to record the number of events,
their
handlers, and the occurrences of those events.

This is right after the login page is loaded.
+---+---+---
+
|Type   |handlers   |fired
||
+---+---+---
+
|event: ApplicationFocusChangeEvent:|0  |2
|| event: LockInteractionEvent:   |2  |2
|  | event: NavigationEvent:|0  |1
|| event: PlaceRequestInternalEvent:  |111
|| |1
|  | event: ResetPresentersEvent:   |1
|  | |1
|| event: RevealRootLayoutContentEvent:   |1
||1  |
+---+---+---
+
  
  Just for clarification:
  
  * ApplicationFocusChangeEvent - fired by our infra whenever browser/window
gains or looses focus (we use this to throttle UiCommon model refresh
timers, i.e. when out of focus, lower the refresh rate)
  
  * LockInteractionEvent - fired by GWTP infra, indicates that UI interaction
should be avoided because the application is currently in transition from
one place to another (in practice, invisible glass div element covers
the entire viewport during transition, see RootPresenter.RootView)
  
Note: we had plans to provide some In progress... label (just like you
see in Gmail) to make this obvious to end users, there's also RFE on this
  
  * NavigationEvent - fired by GWTP infra, it's a hook we don't use
  
  * PlaceRequestInternalEvent - fired by GWTP infra, PlaceManagerImpl fires
this event to ask all proxies: which one of you can reveal a presenter
with name token xxx (i.e. dataCenters-clusters)
  
Note: handler count is high because EACH presenter proxy adds handler
for this event.
  
  * ResetPresentersEvent - fired by GWTP infra, after transition to new place
is complete, trigger onReset lifecycle method on all presenters present
on reveal path (from leaf to root)
  
  * RevealRootLayoutContentEvent - fired by GWTP infra, this makes GWTP root
presenter/view reveal within the browser/window viewport
  

This is right after you login, and the VM main tab is displayed
+---+---+---
+

[ovirt-devel] oVirt 3.5 2 nd test day report(1124458, 1124318, 1124340, 1124346, 1124354, 1124360, 1124363, 1124364)

[Eli Mesika]

Hardware: 

2 x VM 2cpu 4GB ram (Fedora 19, CentOS 6.5)

Network configuration: Single NIC without bonding / vlans

Storage configurations: NFS v3 ISO and data domain

* History DB should sync user's first and last name for user usage tables. (BZ 
1091687)

test result: partly passed 

Tested 

Add a user from AD = passed 

Change user details = passed

Delete a user = Not passed opened BZ 1124458 

Other Bugs Opened :
--
1124318
1124340
1124346
1124354
1124360
1124363
1124364



Thanks
Eli Mesika

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] propose Alona Kaplan as a Backend Maintainer

[Eli Mesika]

- Original Message -
 From: Mike Kolesnik mkole...@redhat.com
 To: Alona Kaplan alkap...@redhat.com
 Cc: devel@ovirt.org
 Sent: Tuesday, July 29, 2014 11:12:04 AM
 Subject: Re: [ovirt-devel] propose Alona Kaplan as a Backend Maintainer
 
 +1

+1 as well ... :-)

 
 Good luck!
 
 Regards,
 Mike
 
 - Original Message -
  Hi All,
  
  Alona Kaplan has been working on the oVirt project for over 2.5 years.
  At the beginning Alona's focus was on the UI aspect of the project, she
  did a great Job contributing many features, bug fixes and documentation
  enhancements across the UI, she became a UI maintainer.
  
  In the last year Alona also contributed a lot of code to the backend
  side of the project, the code was focused on the network side and
  included end to end features.
  
  To share some of Alona's great stats -
  ~ 115 patches related to the network backend
  ~ 300 patches for UI
  
  She coded 'migration-network', 'network-linking' and lately 'support in
  different VLAN names' end to end.
  
  I would like to thank Alona for her great contribution and hope for many
  more patches to come :)
  
  I would also like to propose Alona as a Network backend maintainer.
  
  
  Thanks, Livnat
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Can not run application on last master (again...)

[Eli Mesika]

- Original Message -
 From: Yair Zaslavsky yzasl...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: devel@ovirt.org
 Sent: Wednesday, July 23, 2014 2:01:39 PM
 Subject: Re: [ovirt-devel] Can not run application on last master (again...)
 
 Works for me on master- created a clean deployment directory,
 commit hash -
 e6c1d6e6e097c2051518ea3818fdf37c166b72e0

Solved as well after creating a new branch again, have no idea what went wrong 
before 
Thanks anyway for the support 

 
 - Original Message -
  From: Eli Mesika emes...@redhat.com
  To: Yair Zaslavsky yzasl...@redhat.com
  Cc: devel@ovirt.org
  Sent: Wednesday, July 23, 2014 12:48:57 PM
  Subject: Re: [ovirt-devel] Can not run application on last master
  (again...)
  
  
  
  - Original Message -
   From: Yair Zaslavsky yzasl...@redhat.com
   To: Eli Mesika emes...@redhat.com
   Cc: devel@ovirt.org
   Sent: Wednesday, July 23, 2014 12:33:25 PM
   Subject: Re: [ovirt-devel] Can not run application on last master
   (again...)
   
   Hi Eli,
   Did you make clean ?
   DbUser has moved a package, but it should work...
  
  I had build to a new deployment directory so I do not expect old binaries
  to
  be at all 
  
   
   
   - Original Message -
From: Eli Mesika emes...@redhat.com
To: devel@ovirt.org
Sent: Wednesday, July 23, 2014 12:02:56 PM
Subject: [ovirt-devel] Can not run application on last master
(again...)


Hi Guys

Seems that last master is unstable , please see attached server.log and
let
me know if you have any idea

Thanks
Eli Mesika


___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
   
  
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Project vdsm-jsonrpc-java backup maintainer

[Eli Mesika]

- Original Message -
 From: Sandro Bonazzola sbona...@redhat.com
 To: infra in...@ovirt.org, devel@ovirt.org
 Cc: Piotr Kliczewski pklic...@redhat.com
 Sent: Friday, June 27, 2014 5:30:34 PM
 Subject: [ovirt-devel] Project vdsm-jsonrpc-java backup maintainer
 
 Hi,
 looks like only one person has +2 / merge rights on vdsm-jsonrpc-java.
 I think every project should have a backup maintainer.
 Since it seems pkliczewski is the only committer there, I would like to
 propose him as maintainer too.

+1

 
 
 --
 Sandro Bonazzola
 Better technology. Faster innovation. Powered by community collaboration.
 See how it works at redhat.com
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [oVirt 3.5 Localization Question #2] Update display network on cluster with an active VM (audit log)

[Eli Mesika]

CCing Frantisek who added the virtio support 

- Original Message -
 From: Yuko Katabami ykata...@redhat.com
 To: Yevgeny Zaspitsky yzasp...@redhat.com, devel@ovirt.org
 Sent: Wednesday, June 18, 2014 11:09:23 AM
 Subject: Re: [ovirt-devel] [oVirt 3.5 Localization Question #2] Update 
 display network on cluster with an active VM
 (audit log)
 
 Thank you very much Yevgeny.
 That's all clear now.
 
 Kind regards,
 
 Yuko
 On 06/18/2014 05:54 PM, Yevgeny Zaspitsky wrote:
 
 
 That is the warning to the user that means that an update to the display
 network has been done, which means that he might expect loosing display
 connectivity to the VMs that were active at the time of the update action in
 some cases of the update.
 
 Regards,
 Yevgeny
 
 On 18/06/14 04:02, Yuko Katabami wrote:
 
 
 Hello again.
 
 I would like to ask another question with the following details:
 
 File: LocalizedEnums
 Resource ID: AuditLogType___NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM
 Strings: Update display network on cluster with an active VM
 Question: Is this string an instruction to the user to update the display
 network? Since the resource ID suggests it is audit log, there might be a
 possibility that it is actually meant to be a past event (i.e. Updated).
 
 Kind regards,
 
 Yuko
 
 
 
 
 ___
 Devel mailing list Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
 
 
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Question/thoughts about our engine logging framework

[Eli Mesika]

- Original Message -
 From: Vojtech Szocs vsz...@redhat.com
 To: Martin Perina mper...@redhat.com
 Cc: devel@ovirt.org
 Sent: Friday, June 13, 2014 12:57:49 PM
 Subject: Re: [ovirt-devel] Question/thoughts about our engine logging 
 framework
 
 
 
 - Original Message -
  From: Martin Perina mper...@redhat.com
  To: Yair Zaslavsky yzasl...@redhat.com
  Cc: devel@ovirt.org
  Sent: Friday, June 13, 2014 10:43:59 AM
  Subject: Re: [ovirt-devel] Question/thoughts about our engine logging
  framework
  
  Hi Yair,
  
  I had in my mind to clean up logging framework mess for quite some time :-)
  Currently this is the usage of logging frameworks in engine classes:
  
  java.util.logging.Logger  6.8%
  org.apache.commons.logging.Log7.8%
  org.apache.log4j.Logger  13.6%
  org.ovirt.engine.core.utils.log.Log  68.8%
  org.slf4j.Logger  2.9%
  
  I think we should definitely use only 1 logging framework for the whole
  engine!
  
  So +1 to slf4j from me.
 
 +1 from me as well.

+1 

 
 Note that GWT UI code uses java.util.logging exclusively to do all logging.
 (GWT emulates java.util.logging API and provides log handlers for use on
 client side such as console.log() or stdout/DevMode-during-debug handlers.)
 
  
  And once we agree to 1 logging framework, I can start preparing patches to
  use it.
  
  - Original Message -
   From: Yair Zaslavsky yzasl...@redhat.com
   To: devel@ovirt.org
   Sent: Friday, June 13, 2014 8:15:55 AM
   Subject: [ovirt-devel] Question/thoughts about our engine logging
   framework
   
   Hi all,
   During my recent work on AAA, I was suggested by Juan Hernandez  to use
   slf4j
   logging framework which serves as a facade for other logging frameworks
   (including java utils logging which is now used by jboss), log4j and
   others.
   I have accepted Juan's offer, and then when looking at our LogFactory
   class
   I
   have noticed we use commons logging.
   
   Several thoughts/questions -
   A. Why continue use our own wrapper as slf4j is already a facade.
   b. I think we should move cross java code to slf4j. What do you think on
   this
   point?
   
   Some reading material -
   
   http://javarevisited.blogspot.com.au/2013/08/why-use-sl4j-over-log4j-for-logging-in.html
   http://stackoverflow.com/questions/3222895/what-is-the-issue-with-the-runtime-discovery-algorithm-of-apache-commons-logging
   
   
   
   Yair
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
   
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Entity names in DB scripts

[Eli Mesika]

- Original Message -
 From: Moti Asayag masa...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: Yair Zaslavsky yzasl...@redhat.com, devel@ovirt.org
 Sent: Thursday, May 15, 2014 7:33:06 PM
 Subject: Re: [ovirt-devel] Entity names in DB scripts
 
 
 
 - Original Message -
  From: Eli Mesika emes...@redhat.com
  To: Yair Zaslavsky yzasl...@redhat.com
  Cc: devel@ovirt.org
  Sent: Thursday, May 15, 2014 4:56:50 PM
  Subject: Re: [ovirt-devel] Entity names in DB scripts
  
  
  
  - Original Message -
   From: Yair Zaslavsky yzasl...@redhat.com
   To: devel@ovirt.org
   Sent: Thursday, May 15, 2014 3:20:18 PM
   Subject: [ovirt-devel] Entity names in DB scripts
   
   Hi all,
   I have a feeling there is some inconsistency in using entity names in the
   DB
   scripts.
   For example, should we use Host or VDS?
   I am not talking about existing tables or columns but about new ones (and
   new
   stored procedures).
   
   I am quite sure I saw patches containing both approaches.
 
 I guess that includes any recent patches around the network area.
 
  
  You are right
  I think old should be kept until we have the time to do a global
  find/replace
  of all old names.
 
 Without enabling the new (or more appropriate) naming to new code we:
 1. Increase the amount of 'old' code in the system (gaining more debts)
 2. As a result - more work when and if global change will take affect.
 3. Double the entire work flow: code + review.
 
 That change should start at some point, and having it incrementally is a
 valid approach
 to achieve that goal.

I basically agree, but first someone (that can say that) should say that we are 
going to do that and allocate resources to this tasks , unless , you are left 
in hybrid ugly condition 

 
  The only place in which I encourage new names are application log/audit
  messages
  
   
   Yair
   ___
   Devel mailing list
   Devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/devel
   
  ___
  Devel mailing list
  Devel@ovirt.org
  http://lists.ovirt.org/mailman/listinfo/devel
  
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Entity names in DB scripts

[Eli Mesika]

- Original Message -
 From: Yair Zaslavsky yzasl...@redhat.com
 To: devel@ovirt.org
 Sent: Thursday, May 15, 2014 3:20:18 PM
 Subject: [ovirt-devel] Entity names in DB scripts
 
 Hi all,
 I have a feeling there is some inconsistency in using entity names in the DB
 scripts.
 For example, should we use Host or VDS?
 I am not talking about existing tables or columns but about new ones (and new
 stored procedures).
 
 I am quite sure I saw patches containing both approaches.

You are right 
I think old should be kept until we have the time to do a global find/replace 
of all old names.
The only place in which I encourage new names are application log/audit 
messages 

 
 Yair
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt

[Eli Mesika]

- Original Message -
 From: Omer Frenkel ofren...@redhat.com
 To: Gilad Chaplik gchap...@redhat.com
 Cc: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com, Roy 
 Golan rgo...@redhat.com, Eli Mesika
 emes...@redhat.com, Chuan Liao (Jason Liao, HPservers-Core-OE-PSC) 
 chuan.l...@hp.com, Doron Fediuck
 dfedi...@redhat.com, Chegu Vinod chegu_vi...@hp.com, Shang-Chun Liang 
 (David Liang, HPservers-Core-OE-PSC)
 shangchun.li...@hp.com, Yaniv Dary yd...@redhat.com, 
 engine-devel@ovirt.org
 Sent: Thursday, April 3, 2014 4:45:49 PM
 Subject: Re: Please help us to review our database schema design with NUMA 
 feature on ovirt
 
 
 
 - Original Message -
  From: Gilad Chaplik gchap...@redhat.com
  To: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com, Roy
  Golan rgo...@redhat.com, Omer Frenkel
  ofren...@redhat.com
  Cc: Eli Mesika emes...@redhat.com, Roy Golan rgo...@redhat.com,
  Chuan Liao (Jason Liao,
  HPservers-Core-OE-PSC) chuan.l...@hp.com, Doron Fediuck
  dfedi...@redhat.com, Chegu Vinod
  chegu_vi...@hp.com, Shang-Chun Liang (David Liang,
  HPservers-Core-OE-PSC) shangchun.li...@hp.com, Yaniv Dary
  yd...@redhat.com, engine-devel@ovirt.org
  Sent: Monday, March 31, 2014 4:31:17 PM
  Subject: Re: Please help us to review our database schema design with NUMA
  feature on ovirt
  
  adding Roy  Omer.
  
  why CPU topology is in dynamic?
  
 
 the guideline we (try to) follow today is (i know you can find exceptions to
 this, but this is how it suppose to be):
 vm/vds static - user configurable information (whatever you have in add/edit)
 vm dynamic - information related to a running instance, the is changed in a
 somewhat small frequency
 vds dynamic - host capabilities, information from the host that doesn't
 change while the host is up.
 statistics - all the rest, mostly statistics, and other fast changing
 information.

IMO it is a little more complicated and the terms static/dynamic does not 
reflect today the meaning of those terms rather, if engine knows the values by 
itself , this is considered static and if it has to ask the VDSM for the 
value then this is considered dynamic.
For example cpu_cores is a static information but it is stored in vds_dynamic 
since we get the value from VDSM.
I found those terms very confusing and a good candidate for a serious 
refactoring in future 


 
  Thanks,
  Gilad.
  
  - Original Message -
   From: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com
   To: Eli Mesika emes...@redhat.com
   Cc: Gilad Chaplik gchap...@redhat.com, Roy Golan
   rgo...@redhat.com,
   Chuan Liao (Jason Liao,
   HPservers-Core-OE-PSC) chuan.l...@hp.com, Doron Fediuck
   dfedi...@redhat.com, Chegu Vinod
   chegu_vi...@hp.com, Shang-Chun Liang (David Liang,
   HPservers-Core-OE-PSC) shangchun.li...@hp.com, Yaniv Dary
   yd...@redhat.com, engine-devel@ovirt.org
   Sent: Monday, March 31, 2014 3:20:33 PM
   Subject: RE: Please help us to review our database schema design with
   NUMA
   feature on ovirt
   
   Thanks Eli.
   I will move the vm level NUMA fields to vm_dynamic, and the related
   database
   schema will be updated accordingly.
   
   Thanks  Best Regards
   Shi, Xiao-Lei (Bruce)
   
   Hewlett-Packard Co., Ltd.
   HP Servers Core Platform Software China
   Telephone +86 23 65683093
   Mobile +86 18696583447
   Email xiao-lei@hp.com
   
   -Original Message-
   From: Eli Mesika [mailto:emes...@redhat.com]
   Sent: Monday, March 31, 2014 5:49 PM
   To: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ)
   Cc: Gilad Chaplik; Roy Golan; Liao, Chuan (Jason Liao,
   HPservers-Core-OE-PSC); Doron Fediuck; Vinod, Chegu; Liang, Shang-Chun
   (David Liang, HPservers-Core-OE-PSC); Yaniv Dary; engine-devel@ovirt.org
   Subject: Re: Please help us to review our database schema design with
   NUMA
   feature on ovirt
   
   
   
   - Original Message -
From: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com
To: Gilad Chaplik gchap...@redhat.com, Eli Mesika
emes...@redhat.com, Roy Golan rgo...@redhat.com
Cc: Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)
chuan.l...@hp.com, Doron Fediuck dfedi...@redhat.com, Chegu
Vinod
chegu_vi...@hp.com, Shang-Chun Liang (David Liang,
HPservers-Core-OE-PSC)
shangchun.li...@hp.com, Yaniv Dary yd...@redhat.com,
engine-devel@ovirt.org
Sent: Monday, March 31, 2014 12:38:04 PM
Subject: RE: Please help us to review our database schema design with
NUMA feature on ovirt

We put host level NUMA fields in vds_dynamic because these information
are from host itself, and NUMA topology may be changed if the host's
hardware make a change. NUMA information are similar to the host's cpu
topology information like cpu_cores and cpu_sockets which are in
vds_dynamic, we refer to this.
VM level NUMA fields are configured by user, and actually we
originally think they should be in vm_dynamic. But we found

Re: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt

[Eli Mesika]

- Original Message -
 From: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com
 To: Gilad Chaplik gchap...@redhat.com, Eli Mesika emes...@redhat.com
 Cc: Roy Golan rgo...@redhat.com, Omer Frenkel ofren...@redhat.com, 
 Chegu Vinod chegu_vi...@hp.com, Chuan
 Liao (Jason Liao, HPservers-Core-OE-PSC) chuan.l...@hp.com, Doron 
 Fediuck dfedi...@redhat.com, Shang-Chun
 Liang (David Liang, HPservers-Core-OE-PSC) shangchun.li...@hp.com, Yaniv 
 Dary yd...@redhat.com,
 engine-devel@ovirt.org
 Sent: Thursday, April 3, 2014 7:25:11 AM
 Subject: RE: Please help us to review our database schema design with NUMA 
 feature on ovirt
 
 Hi all,
 Please see my comments in line.
 
 Thanks  Best Regards
 Shi, Xiao-Lei (Bruce)
 
 Hewlett-Packard Co., Ltd.
 HP Servers Core Platform Software China
 Telephone +86 23 65683093
 Mobile +86 18696583447
 Email xiao-lei@hp.com
 
 -Original Message-
 From: Gilad Chaplik [mailto:gchap...@redhat.com]
 Sent: Thursday, April 03, 2014 9:05 AM
 To: Eli Mesika
 Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel; Vinod,
 Chegu; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
 Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
 engine-devel@ovirt.org
 Subject: Re: Please help us to review our database schema design with NUMA
 feature on ovirt
 
 Hi all,
 Sorry for joining-in late.
 
 My comments (according to the db diagram section in
 https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykDr0I6VY):
 1) Join vm_numa_node and vds_numa_node to a single table (almost identical),
 one of the FKs can be null.
 [Bruce] I prefer two tables. Actually host level NUMA node and vm level NUMA
 node are different objects. In my understanding, vm level NUMA node is just
 a simulation of host level NUMA node, and host level NUMA node has more
 features that not in vm NUMA (like several levels of host NUMA topology
 mentioned by Vinod). We need to consider the extensions of host NUMA in the
 future.

I agree with Bruce, we have no problem with more tables and constrains should 
work as expected and remove entries when a Host or VM is removed.
I do not like tables that have 2 UUIDs when one of them is null , this is 
against simple DB normalization 


 2) No templates reference in the design, need to check it out (it might be
 inherently designed already :-) ); vNode can be linked to a template.
 [Bruce] IMO, we can consider template as a special vm, our current design
 supports to create vNodes in a template just like what it does in a vm.

We also store today templates in the VM* tables as special entities defined by 
the entity_type column

 
 3) The reason I want host's NUMA data to be in static is because it updates
 only once (on boot). engineerically speaking, dynamic table has a lot of
 traffic and that's not the case for NUMA info. Its feels to me like 'a
 hybrid' of static and dynamic, 3 suggestions comes to mind:
  - leave it in dynamic (maybe in a separate process).
  - have a separate flow that updates static.
  - come up with a third 'vds_on_boot' table (my favorite ;-P ).
 I will get back to you on that.
 [Bruce] From the onTimer codes in vdsManager (IMO it's the scheduled vds
 refresh action), when vds is in normal running status (up status), only
 statistics data will be refreshed, so I think maybe dynamic table doesn't
 have so much traffic, and the varied data (I mean the data varied through a
 power reload, like cpu topology, numa topology, ...etc) can be refreshed
 meanwhile.
 
 4) vm_vds_numa_node_map is connected to vds_numa_node_statistics, why to
 split the tables (vds_numa_node  vds_numa_node_statistics), going back to
 comment #1, don't we want vNode stats as well, it can be nice to show it :-)
 (have a vNUMA overview of the VM using guest-agent or sth, in a future
 phase).
 [Bruce] Split the tables is referring to vds_interface
 (vds_interface_statistics) and vm_interface (vm_interface_statistics), the
 statistics table will be refreshed with a high frequency.
 I will update the design to add the vNuma statistics for the future phase,
 and according to my feedback in comment #1, vNuma statistics will also in an
 independent table since I think there will be more statistics fields for
 host NUMA than for vNuma.

Agree with Bruce

 
 5) IMO vds_cpu_statistics shouldn't include any reference to NUMA, I gave
 that comment in the BE patch as well (remove vds_numa_node_id FK in
 vds_cpu_statistics), for that you should extract cpu_list to a connection
 table (anyway I don't like lists as a text/strings/etc.)
 [Bruce] Yes, I agree with you to remove the reference between
 vds_cpu_statistics and NUMA. Actually cpu_list is enough for current
 requirements. I think the connection table is needed when we consider to
 collect more cpu related information and do more cpu related actions in the
 future.
 
 6) vm_numatune_nodeset can be removed - the vNode should hold it's pinning
 info; I think

Re: [Engine-devel] Please help us to review our database schema design with NUMA feature on ovirt

[Eli Mesika]

- Original Message -
 From: Gilad Chaplik gchap...@redhat.com
 To: Eli Mesika emes...@redhat.com
 Cc: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com, Roy 
 Golan rgo...@redhat.com, Omer Frenkel
 ofren...@redhat.com, Chegu Vinod chegu_vi...@hp.com, Chuan Liao (Jason 
 Liao, HPservers-Core-OE-PSC)
 chuan.l...@hp.com, Doron Fediuck dfedi...@redhat.com, Shang-Chun Liang 
 (David Liang, HPservers-Core-OE-PSC)
 shangchun.li...@hp.com, Yaniv Dary yd...@redhat.com, 
 engine-devel@ovirt.org
 Sent: Thursday, April 3, 2014 1:46:32 PM
 Subject: Re: Please help us to review our database schema design with NUMA 
 feature on ovirt
 
 - Original Message -
  From: Eli Mesika emes...@redhat.com
  To: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com
  Cc: Gilad Chaplik gchap...@redhat.com, Roy Golan rgo...@redhat.com,
  Omer Frenkel ofren...@redhat.com,
  Chegu Vinod chegu_vi...@hp.com, Chuan Liao (Jason Liao,
  HPservers-Core-OE-PSC) chuan.l...@hp.com, Doron
  Fediuck dfedi...@redhat.com, Shang-Chun Liang (David Liang,
  HPservers-Core-OE-PSC) shangchun.li...@hp.com,
  Yaniv Dary yd...@redhat.com, engine-devel@ovirt.org
  Sent: Thursday, April 3, 2014 10:54:54 AM
  Subject: Re: Please help us to review our database schema design with NUMA
  feature on ovirt
  
  
  
  - Original Message -
   From: Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ) xiao-lei@hp.com
   To: Gilad Chaplik gchap...@redhat.com, Eli Mesika
   emes...@redhat.com
   Cc: Roy Golan rgo...@redhat.com, Omer Frenkel
   ofren...@redhat.com,
   Chegu Vinod chegu_vi...@hp.com, Chuan
   Liao (Jason Liao, HPservers-Core-OE-PSC) chuan.l...@hp.com, Doron
   Fediuck dfedi...@redhat.com, Shang-Chun
   Liang (David Liang, HPservers-Core-OE-PSC) shangchun.li...@hp.com,
   Yaniv Dary yd...@redhat.com,
   engine-devel@ovirt.org
   Sent: Thursday, April 3, 2014 7:25:11 AM
   Subject: RE: Please help us to review our database schema design with
   NUMA
   feature on ovirt
   
   Hi all,
   Please see my comments in line.
   
   Thanks  Best Regards
   Shi, Xiao-Lei (Bruce)
   
   Hewlett-Packard Co., Ltd.
   HP Servers Core Platform Software China
   Telephone +86 23 65683093
   Mobile +86 18696583447
   Email xiao-lei@hp.com
   
   -Original Message-
   From: Gilad Chaplik [mailto:gchap...@redhat.com]
   Sent: Thursday, April 03, 2014 9:05 AM
   To: Eli Mesika
   Cc: Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ); Roy Golan; Omer Frenkel;
   Vinod,
   Chegu; Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Doron Fediuck;
   Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC); Yaniv Dary;
   engine-devel@ovirt.org
   Subject: Re: Please help us to review our database schema design with
   NUMA
   feature on ovirt
   
   Hi all,
   Sorry for joining-in late.
   
   My comments (according to the db diagram section in
   https://docs.google.com/document/d/1-wdDkm6EDbwyoCIRPPcmbGWAcyQo_ISTY8ykDr0I6VY):
   1) Join vm_numa_node and vds_numa_node to a single table (almost
   identical),
   one of the FKs can be null.
   [Bruce] I prefer two tables. Actually host level NUMA node and vm level
   NUMA
   node are different objects. In my understanding, vm level NUMA node is
   just
   a simulation of host level NUMA node, and host level NUMA node has more
   features that not in vm NUMA (like several levels of host NUMA topology
   mentioned by Vinod). We need to consider the extensions of host NUMA in
   the
   future.
 
 Let's open the discussion and consider them right now. vNode and Node are the
 same.
 Vinod?
 
  
  I agree with Bruce, we have no problem with more tables and constrains
  should
  work as expected and remove entries when a Host or VM is removed.
  I do not like tables that have 2 UUIDs when one of them is null , this is
  against simple DB normalization
  
 
 We are going to maintain and develop this feature. there is a huge overhead
 in 6 table design in compare to 4.

Counting how many tables you should manage is out of context.
The only thing I can care of is database design 
From DB design perspective if you have a main table A with PK PK-A if you have 
any other table X that includes PK-A as a column Cx , then there should be a 
foreign key constraint that handles removals from A and clean corresponding X 
table records accordingly. This you can not do when you have 2 UUIDs as you 
suggested (not to mention that this is considered as bad DB design with no 
doubt)
Add to that the fact that when managing both UUIDs in one table, you are 
supposed to get deadlocks from scenarios that wouldn't cause that if each 
entity is managed in its own table.
I don't see any point to open this to discussion, we had worked hard to 
separate tables that used this bad method in the past and caused us a bunch of 
unexpected problems.
Please develop your DB changes according to normal well accepted guidelines I 
will not ack a change that violates simple DB design rules.
Thanks  

 
  
   2) No templates reference

Re: [Engine-devel] vds_dynamic refactor

[Eli Mesika]

- Original Message -
 From: Gilad Chaplik gchap...@redhat.com
 To: Yair Zaslavsky yzasl...@redhat.com
 Cc: engine-devel engine-devel@ovirt.org
 Sent: Thursday, April 3, 2014 4:00:25 PM
 Subject: Re: [Engine-devel] vds_dynamic refactor
 
 - Original Message -
  From: Yair Zaslavsky yzasl...@redhat.com
  To: Liran Zelkha liran.zel...@gmail.com
  Cc: Gilad Chaplik gchap...@redhat.com, engine-devel
  engine-devel@ovirt.org
  Sent: Thursday, April 3, 2014 2:12:59 PM
  Subject: Re: [Engine-devel] vds_dynamic refactor
  
  
  
  - Original Message -
   From: Liran Zelkha liran.zel...@gmail.com
   To: Gilad Chaplik gchap...@redhat.com
   Cc: engine-devel engine-devel@ovirt.org
   Sent: Thursday, April 3, 2014 2:04:29 PM
   Subject: Re: [Engine-devel] vds_dynamic refactor
   
   Why not move it to vds_static?
  
  +1 on Liran's comment.

+1 as well , vds_static is the place for that 

  I would prefer not to add more complexity to the  vds tables family.
  Such complexity may effect performs of queries/views.
  If you wish, you can create a view on top of vds_static named vds_on_boot
  for
  querying of vds on boot info.
  
  Yair
 
 That means moving almost all of vds_dynamic into vds_static except of memory,
 pending resources and status (maybe more but not much);
 and there will not be any db separation between user input and on_boot data.

Why we should have such separation ?

 
 Thanks,
 Gilad.
 
  
   
   
   On Thu, Apr 3, 2014 at 2:00 PM, Gilad Chaplik gchap...@redhat.com
   wrote:
   
Hi list,
   
I propose to split vds_dynamic table into 2 tables:
- vds_dynamic
- vds_on_boot
We need a place to put all non-dynamic data that gets updated once the
host is booted, and I think dynamic isn't the place for it.
In first phase we will put there NUMA host topoplogy, but later on
migrate
all non-dynamic host data (cpu, os, etc.).
   
thoughts?
   
Thanks,
Gilad.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
   
   
   ___
   Engine-devel mailing list
   Engine-devel@ovirt.org
   http://lists.ovirt.org/mailman/listinfo/engine-devel
   
  
 ___
 Engine-devel mailing list
 Engine-devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/engine-devel
 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel