Re: [ovirt-devel] [Devel] Vdsm functional tests

2014-04-10 Thread Michal Skrivanek

On Apr 10, 2014, at 08:34 , Francesco Romani from...@redhat.com wrote:

 - Original Message -
 From: Michal Skrivanek michal.skriva...@redhat.com
 To: Dan Kenigsberg dan...@redhat.com
 Cc: vdsm-de...@ovirt.org, devel@ovirt.org
 Sent: Thursday, April 10, 2014 8:13:55 AM
 Subject: Re: [ovirt-devel] [Devel] Vdsm functional tests
 
 When could we expect to have it running per commit on a Jenkins slaves?
 
 virt tests are running
 There is a common initialization issue with VdsProxy at the moment, once it's
 fixed the virt tests can be un-silenced and they will hopefully come out of
 failing-only mode:)
 I'd say end of this week...
 
 Confirmed.
 This http://gerrit.ovirt.org/#/c/26514/ should fix the current VdsProxy 
 troubles

Plus ideally a better initialization to get rid of that embarrassing sleep 10 
in gerrit config. We should check and wait till vdsm responds in VdsProxy init.
We need to make the test as fast as possible, otherwise people won't run them...

Thanks,
michal

 
 
 Bests,
 
 -- 
 Francesco Romani
 RedHat Engineering Virtualization R  D
 Phone: 8261328
 IRC: fromani

___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [ovirt-devel] [Devel] Vdsm functional tests

2014-04-10 Thread Antoni Segura Puimedon


- Original Message -
 From: Michal Skrivanek michal.skriva...@redhat.com
 To: Francesco Romani from...@redhat.com
 Cc: vdsm-de...@ovirt.org, devel@ovirt.org
 Sent: Thursday, April 10, 2014 8:37:18 AM
 Subject: Re: [ovirt-devel] [Devel] Vdsm functional tests
 
 
 On Apr 10, 2014, at 08:34 , Francesco Romani from...@redhat.com wrote:
 
  - Original Message -
  From: Michal Skrivanek michal.skriva...@redhat.com
  To: Dan Kenigsberg dan...@redhat.com
  Cc: vdsm-de...@ovirt.org, devel@ovirt.org
  Sent: Thursday, April 10, 2014 8:13:55 AM
  Subject: Re: [ovirt-devel] [Devel] Vdsm functional tests
  
  When could we expect to have it running per commit on a Jenkins slaves?
  
  virt tests are running
  There is a common initialization issue with VdsProxy at the moment, once
  it's
  fixed the virt tests can be un-silenced and they will hopefully come out
  of
  failing-only mode:)
  I'd say end of this week...
  
  Confirmed.
  This http://gerrit.ovirt.org/#/c/26514/ should fix the current VdsProxy
  troubles
 
 Plus ideally a better initialization to get rid of that embarrassing sleep
 10 in gerrit config.
Well, that happens to you because you all copied our network functional tests
job xD Where it really doesn't matter 10 seconds since the tests take upwards
of 10 minutes to run.

 We should check and wait till vdsm responds in
 VdsProxy init.
 We need to make the test as fast as possible, otherwise people won't run
 them...
 
 Thanks,
 michal
 
  
  
  Bests,
  
  --
  Francesco Romani
  RedHat Engineering Virtualization R  D
  Phone: 8261328
  IRC: fromani
 
 ___
 Devel mailing list
 Devel@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/devel
 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [Devel] Vdsm functional tests

2014-04-06 Thread Dan Kenigsberg
On Sun, Apr 06, 2014 at 11:18:19AM +0300, ybronhei wrote:
 On 04/03/2014 07:31 PM, Douglas Schilling Landgraf wrote:
 On 04/03/2014 11:08 AM, Dan Kenigsberg wrote:
 Functional tests are intended to verify that a running Vdsm instance
 does what it should, when treated as a black box, over its public API.
 
 They should be comprehensive and representative of a typical field usage
 of Vdsm. It is a sin to break such a test - but we must be able to know
 when such a sin is committed.
 
 We currently have the following functional tests modules:
 
 - sosPluginTests.py
supervdsmFuncTests.py
 
 Sure, count with me.
 
 any news about it ? need my help around it?

Douglas still owes me a time estimate on when this be done.

 supervdsmFuncTests.py doesn't really check much. we need to add much
 more logic there if we actually want to test the communication
 between vdsm and supervdsm (not sure if its really required.. its
 like checking calls to libvirt or sanlock or testing api calls)

At the moment supervdsmFuncTests do test that supervdsm is reponsive and
that supervdsm.getProxy() works. It's not like testing libvirt api calls
since supervdsm is inside our tree. So it's like testing libvirt api
calls - within the libvirt project.

I would embrace more smarter logic into the test - but I'm not sure what
you have in mind.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel


Re: [Devel] Vdsm functional tests

2014-04-06 Thread Douglas Schilling Landgraf

On 04/03/2014 12:24 PM, Dan Kenigsberg wrote:

On Thu, Apr 03, 2014 at 12:31:44PM -0400, Douglas Schilling Landgraf wrote:

On 04/03/2014 11:08 AM, Dan Kenigsberg wrote:

Functional tests are intended to verify that a running Vdsm instance
does what it should, when treated as a black box, over its public API.

They should be comprehensive and representative of a typical field usage
of Vdsm. It is a sin to break such a test - but we must be able to know
when such a sin is committed.

We currently have the following functional tests modules:

- sosPluginTests.py
   supervdsmFuncTests.py


Sure, count with me.


Thanks! When do you think you could write a job similar to
http://jenkins.ovirt.org/view/By%20Project/view/vdsm/job/vdsm_network_functional_tests/configure
running whenever there's a change in the modules relevant to
sosPluginTests and supervdsmFuncTests?



Hi,

Instead of to split by domain like (network, infra, storage), why not 
have a single functional test job? If something fail, it should trigger 
the volunteers.


For while, I started a creation of infra based on the above one.
http://jenkins.ovirt.org/job/vdsm_infra_functional_tests

--
Cheers
Douglas
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel