[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Marcin Sobczyk



On 10/15/19 3:49 PM, Kaustav Majumder wrote:

Thanks a lot. BTW here is the full log : https://pastebin.com/6zDb9tB3


So the only failure I can see is:

JsonRpcNoResponseError: No response for JSON-RPC request: {'method': 'event'}

and this one is on me - stomp-related tests can be unfortunately quite 
unstable...

As soon as I dig myself out of py3-related tasks I will look into this.

On Tue, Oct 15, 2019 at 6:48 PM Marcin Sobczyk > wrote:




On 10/15/19 3:07 PM, Kaustav Majumder wrote:

Yes, I didnot run make after I chnged my dev environment, It
worked but I still see some commands failing namely
```
ERROR:   tests-py27: commands failed
ERROR:   storage-py27: commands failed
  lib-py27: commands succeeded
ERROR:   network-py27: commands failed
  virt-py27: commands succeeded
  gluster-py27: commands succeeded
```
I am working on master.
Full log here: https://pastebin.com/8RbBk97d


AFAICT there are no actual errors regarding storage and network
tests - the reason a failure is reported is because you're missing
minimal required coverage i.e. for storage:

FAIL Required test coverage of 62% not reached. Total coverage: 56.81%


The coverage is lower than expected because some tests work only
in specific envs (like running as 'root').
You can lower the expected coverage by defining these vars:

export NETWORK_COVERAGE=5
export STORAGE_COVERAGE=5

Unfortunately I can't the reason behind failure of 'tests-py27'
it's trimmed.


On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk
mailto:msobc...@redhat.com>> wrote:



On 10/15/19 2:12 PM, Kaustav Majumder wrote:

Hi,
There is no constants.py file but constants.py.in
 -> https://pastebin.com/ATLrmTuh

That would suggest that you didn't run 'make' - this is the
step that generates files from '*.in' ones.



On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk
mailto:msobc...@redhat.com>> wrote:



On 10/15/19 1:44 PM, Kaustav Majumder wrote:

Thanks , solved the tox issue but now pytlint is
throwing errors. Mostly with vdsm.constants.I have
lines of
```
E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP'
member (no-member)
* Module vdsm.gluster.api
E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT'
member (no-member)
* Module vdsm.gluster.gfapi
E:228,35: Module 'vdsm.constants' has no 'P_VDSM'
member (no-member)
E:259,35: Module 'vdsm.constants' has no 'P_VDSM'
member (no-member)
* Module vdsm.supervdsm_api.udev
```
for all places wherever vdsm.constants is required. Any
change I am unaware of.

Can you please pastebin the contents of your
'lib/vdsm/common/constants.py' file?



Full log here : https://pastebin.com/fb77r7Hj


On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal
mailto:mzama...@redhat.com>> wrote:

Marcin Sobczyk mailto:msobc...@redhat.com>> writes:

> Hi,
>
> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>
>> Hi,
>> I am having an issue running make check on vdsm
master.
>>
>> `
>> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>>         mv .coverage .coverage-nose-py27; \
>> fi
>> Traceback (most recent call last):
>>   File "../tests/testrunner.py", line 70, in

>>     from vdsm import constants
>>   File
"/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py",
line
>> 29, in 
>>     from vdsm.common.constants import *  # NOQA:
F401, F403
>> `
>> Am I missing something? Do I need to run tests
differently?
> did you run plane 'make' before 'make check'?

Wouldn't it be worth to fix the missing
dependency?  We hit this issue
often.

Even if we made `check' simply depend on `all', it
would be fine IMO,
since the running time of `all' is negligible to
the running time of
`check'.

>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>> ___
>> Devel mailing list -- devel@ovirt.org

>> 

[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Kaustav Majumder
Thanks a lot. BTW here is the full log : https://pastebin.com/6zDb9tB3

On Tue, Oct 15, 2019 at 6:48 PM Marcin Sobczyk  wrote:

>
>
> On 10/15/19 3:07 PM, Kaustav Majumder wrote:
>
> Yes, I didnot run make after I chnged my dev environment, It worked but I
> still see some commands failing namely
> ```
> ERROR:   tests-py27: commands failed
> ERROR:   storage-py27: commands failed
>   lib-py27: commands succeeded
> ERROR:   network-py27: commands failed
>   virt-py27: commands succeeded
>   gluster-py27: commands succeeded
> ```
> I am working on master.
> Full log here: https://pastebin.com/8RbBk97d
>
> AFAICT there are no actual errors regarding storage and network tests -
> the reason a failure is reported is because you're missing
> minimal required coverage i.e. for storage:
>
> FAIL Required test coverage of 62% not reached. Total coverage: 56.81%
>
>
> The coverage is lower than expected because some tests work only in
> specific envs (like running as 'root').
> You can lower the expected coverage by defining these vars:
>
> export NETWORK_COVERAGE=5
> export STORAGE_COVERAGE=5
>
> Unfortunately I can't the reason behind failure of 'tests-py27' it's
> trimmed.
>
> On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk 
> wrote:
>
>>
>>
>> On 10/15/19 2:12 PM, Kaustav Majumder wrote:
>>
>> Hi,
>> There is no constants.py file but constants.py.in ->
>> https://pastebin.com/ATLrmTuh
>>
>> That would suggest that you didn't run 'make' - this is the step that
>> generates files from '*.in' ones.
>>
>>
>> On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk 
>> wrote:
>>
>>>
>>>
>>> On 10/15/19 1:44 PM, Kaustav Majumder wrote:
>>>
>>> Thanks , solved the tox issue but now pytlint is throwing errors. Mostly
>>> with vdsm.constants.I have lines of
>>> ```
>>> E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member)
>>> * Module vdsm.gluster.api
>>> E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member)
>>> * Module vdsm.gluster.gfapi
>>> E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
>>> E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
>>> * Module vdsm.supervdsm_api.udev
>>> ```
>>> for all places wherever vdsm.constants is required. Any change I am
>>> unaware of.
>>>
>>> Can you please pastebin the contents of your
>>> 'lib/vdsm/common/constants.py' file?
>>>
>>>
>>> Full log here : https://pastebin.com/fb77r7Hj
>>>
>>>
>>> On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal 
>>> wrote:
>>>
 Marcin Sobczyk  writes:

 > Hi,
 >
 > On 10/14/19 3:06 PM, Kaustav Majumder wrote:
 >>
 >> Hi,
 >> I am having an issue running make check on vdsm master.
 >>
 >> `
 >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
 >> mv .coverage .coverage-nose-py27; \
 >> fi
 >> Traceback (most recent call last):
 >>   File "../tests/testrunner.py", line 70, in 
 >> from vdsm import constants
 >>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
 >> 29, in 
 >> from vdsm.common.constants import *  # NOQA: F401, F403
 >> `
 >> Am I missing something? Do I need to run tests differently?
 > did you run plane 'make' before 'make check'?

 Wouldn't it be worth to fix the missing dependency?  We hit this issue
 often.

 Even if we made `check' simply depend on `all', it would be fine IMO,
 since the running time of `all' is negligible to the running time of
 `check'.

 >> Thanks,
 >>
 >> Kaustav Majumder
 >>
 >>
 >> ___
 >> Devel mailing list -- devel@ovirt.org
 >> To unsubscribe send an email to devel-le...@ovirt.org
 >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
 >> oVirt Code of Conduct:
 https://www.ovirt.org/community/about/community-guidelines/
 >> List Archives:
 >>
 https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
 >
 > ___
 > Devel mailing list -- devel@ovirt.org
 > To unsubscribe send an email to devel-le...@ovirt.org
 > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
 > oVirt Code of Conduct:
 https://www.ovirt.org/community/about/community-guidelines/
 > List Archives:
 >
 https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
 ___
 Devel mailing list -- devel@ovirt.org
 To unsubscribe send an email to devel-le...@ovirt.org
 Privacy Statement: https://www.ovirt.org/site/privacy-policy/
 oVirt Code of Conduct:
 https://www.ovirt.org/community/about/community-guidelines/
 List Archives:
 https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/

>>>
>>>
>>> --
>>>
>>> Thanks,

[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Marcin Sobczyk



On 10/15/19 3:07 PM, Kaustav Majumder wrote:
Yes, I didnot run make after I chnged my dev environment, It worked 
but I still see some commands failing namely

```
ERROR:   tests-py27: commands failed
ERROR:   storage-py27: commands failed
  lib-py27: commands succeeded
ERROR:   network-py27: commands failed
  virt-py27: commands succeeded
  gluster-py27: commands succeeded
```
I am working on master.
Full log here: https://pastebin.com/8RbBk97d

AFAICT there are no actual errors regarding storage and network tests - 
the reason a failure is reported is because you're missing

minimal required coverage i.e. for storage:

FAIL Required test coverage of 62% not reached. Total coverage: 56.81%


The coverage is lower than expected because some tests work only in 
specific envs (like running as 'root').

You can lower the expected coverage by defining these vars:

export NETWORK_COVERAGE=5
export STORAGE_COVERAGE=5

Unfortunately I can't the reason behind failure of 'tests-py27' it's 
trimmed.


On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk > wrote:




On 10/15/19 2:12 PM, Kaustav Majumder wrote:

Hi,
There is no constants.py file but constants.py.in
 -> https://pastebin.com/ATLrmTuh

That would suggest that you didn't run 'make' - this is the step
that generates files from '*.in' ones.



On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk
mailto:msobc...@redhat.com>> wrote:



On 10/15/19 1:44 PM, Kaustav Majumder wrote:

Thanks , solved the tox issue but now pytlint is throwing
errors. Mostly with vdsm.constants.I have lines of
```
E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member
(no-member)
* Module vdsm.gluster.api
E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member
(no-member)
* Module vdsm.gluster.gfapi
E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member
(no-member)
E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member
(no-member)
* Module vdsm.supervdsm_api.udev
```
for all places wherever vdsm.constants is required. Any
change I am unaware of.

Can you please pastebin the contents of your
'lib/vdsm/common/constants.py' file?



Full log here : https://pastebin.com/fb77r7Hj


On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal
mailto:mzama...@redhat.com>> wrote:

Marcin Sobczyk mailto:msobc...@redhat.com>> writes:

> Hi,
>
> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>
>> Hi,
>> I am having an issue running make check on vdsm master.
>>
>> `
>> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>>         mv .coverage .coverage-nose-py27; \
>> fi
>> Traceback (most recent call last):
>>   File "../tests/testrunner.py", line 70, in 
>>     from vdsm import constants
>>   File
"/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
>> 29, in 
>>     from vdsm.common.constants import *  # NOQA:
F401, F403
>> `
>> Am I missing something? Do I need to run tests
differently?
> did you run plane 'make' before 'make check'?

Wouldn't it be worth to fix the missing dependency?  We
hit this issue
often.

Even if we made `check' simply depend on `all', it would
be fine IMO,
since the running time of `all' is negligible to the
running time of
`check'.

>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>> ___
>> Devel mailing list -- devel@ovirt.org

>> To unsubscribe send an email to devel-le...@ovirt.org

>> Privacy Statement:
https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>>

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>
> ___
> Devel mailing list -- devel@ovirt.org

> To unsubscribe send an email to devel-le...@ovirt.org

> Privacy Statement:
https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
  

[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Kaustav Majumder
Yes, I didnot run make after I chnged my dev environment, It worked but I
still see some commands failing namely
```
ERROR:   tests-py27: commands failed
ERROR:   storage-py27: commands failed
  lib-py27: commands succeeded
ERROR:   network-py27: commands failed
  virt-py27: commands succeeded
  gluster-py27: commands succeeded
```
I am working on master.
Full log here: https://pastebin.com/8RbBk97d

On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk  wrote:

>
>
> On 10/15/19 2:12 PM, Kaustav Majumder wrote:
>
> Hi,
> There is no constants.py file but constants.py.in ->
> https://pastebin.com/ATLrmTuh
>
> That would suggest that you didn't run 'make' - this is the step that
> generates files from '*.in' ones.
>
>
> On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk 
> wrote:
>
>>
>>
>> On 10/15/19 1:44 PM, Kaustav Majumder wrote:
>>
>> Thanks , solved the tox issue but now pytlint is throwing errors. Mostly
>> with vdsm.constants.I have lines of
>> ```
>> E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member)
>> * Module vdsm.gluster.api
>> E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member)
>> * Module vdsm.gluster.gfapi
>> E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
>> E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
>> * Module vdsm.supervdsm_api.udev
>> ```
>> for all places wherever vdsm.constants is required. Any change I am
>> unaware of.
>>
>> Can you please pastebin the contents of your
>> 'lib/vdsm/common/constants.py' file?
>>
>>
>> Full log here : https://pastebin.com/fb77r7Hj
>>
>>
>> On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal 
>> wrote:
>>
>>> Marcin Sobczyk  writes:
>>>
>>> > Hi,
>>> >
>>> > On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>> >>
>>> >> Hi,
>>> >> I am having an issue running make check on vdsm master.
>>> >>
>>> >> `
>>> >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>>> >> mv .coverage .coverage-nose-py27; \
>>> >> fi
>>> >> Traceback (most recent call last):
>>> >>   File "../tests/testrunner.py", line 70, in 
>>> >> from vdsm import constants
>>> >>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
>>> >> 29, in 
>>> >> from vdsm.common.constants import *  # NOQA: F401, F403
>>> >> `
>>> >> Am I missing something? Do I need to run tests differently?
>>> > did you run plane 'make' before 'make check'?
>>>
>>> Wouldn't it be worth to fix the missing dependency?  We hit this issue
>>> often.
>>>
>>> Even if we made `check' simply depend on `all', it would be fine IMO,
>>> since the running time of `all' is negligible to the running time of
>>> `check'.
>>>
>>> >> Thanks,
>>> >>
>>> >> Kaustav Majumder
>>> >>
>>> >>
>>> >> ___
>>> >> Devel mailing list -- devel@ovirt.org
>>> >> To unsubscribe send an email to devel-le...@ovirt.org
>>> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>>> >> oVirt Code of Conduct:
>>> https://www.ovirt.org/community/about/community-guidelines/
>>> >> List Archives:
>>> >>
>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>>> >
>>> > ___
>>> > Devel mailing list -- devel@ovirt.org
>>> > To unsubscribe send an email to devel-le...@ovirt.org
>>> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>>> > oVirt Code of Conduct:
>>> https://www.ovirt.org/community/about/community-guidelines/
>>> > List Archives:
>>> >
>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
>>> ___
>>> Devel mailing list -- devel@ovirt.org
>>> To unsubscribe send an email to devel-le...@ovirt.org
>>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>>> oVirt Code of Conduct:
>>> https://www.ovirt.org/community/about/community-guidelines/
>>> List Archives:
>>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/
>>>
>>
>>
>> --
>>
>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>>
>
> --
>
> Thanks,
>
> Kaustav Majumder
>
>
>

-- 

Thanks,

Kaustav Majumder
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/CEVETDSH42D5TT6GSFXPNUDP22I76TSE/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Marcin Sobczyk



On 10/15/19 2:12 PM, Kaustav Majumder wrote:

Hi,
There is no constants.py file but constants.py.in 
 -> https://pastebin.com/ATLrmTuh
That would suggest that you didn't run 'make' - this is the step that 
generates files from '*.in' ones.




On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk > wrote:




On 10/15/19 1:44 PM, Kaustav Majumder wrote:

Thanks , solved the tox issue but now pytlint is throwing errors.
Mostly with vdsm.constants.I have lines of
```
E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member
(no-member)
* Module vdsm.gluster.api
E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member
(no-member)
* Module vdsm.gluster.gfapi
E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
* Module vdsm.supervdsm_api.udev
```
for all places wherever vdsm.constants is required. Any change I
am unaware of.

Can you please pastebin the contents of your
'lib/vdsm/common/constants.py' file?



Full log here : https://pastebin.com/fb77r7Hj


On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal
mailto:mzama...@redhat.com>> wrote:

Marcin Sobczyk mailto:msobc...@redhat.com>> writes:

> Hi,
>
> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>
>> Hi,
>> I am having an issue running make check on vdsm master.
>>
>> `
>> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>>         mv .coverage .coverage-nose-py27; \
>> fi
>> Traceback (most recent call last):
>>   File "../tests/testrunner.py", line 70, in 
>>     from vdsm import constants
>>   File
"/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
>> 29, in 
>>     from vdsm.common.constants import *  # NOQA: F401, F403
>> `
>> Am I missing something? Do I need to run tests differently?
> did you run plane 'make' before 'make check'?

Wouldn't it be worth to fix the missing dependency? We hit
this issue
often.

Even if we made `check' simply depend on `all', it would be
fine IMO,
since the running time of `all' is negligible to the running
time of
`check'.

>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>> ___
>> Devel mailing list -- devel@ovirt.org 
>> To unsubscribe send an email to devel-le...@ovirt.org

>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>>

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>
> ___
> Devel mailing list -- devel@ovirt.org 
> To unsubscribe send an email to devel-le...@ovirt.org

> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
>

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
___
Devel mailing list -- devel@ovirt.org 
To unsubscribe send an email to devel-le...@ovirt.org

Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives:

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/



-- 


Thanks,

Kaustav Majumder





--

Thanks,

Kaustav Majumder



___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/EJPU4IWOC3N4ENSRQMATTK6DGCOQCNHI/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Kaustav Majumder
Hi,
There is no constants.py file but constants.py.in ->
https://pastebin.com/ATLrmTuh

On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk  wrote:

>
>
> On 10/15/19 1:44 PM, Kaustav Majumder wrote:
>
> Thanks , solved the tox issue but now pytlint is throwing errors. Mostly
> with vdsm.constants.I have lines of
> ```
> E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member)
> * Module vdsm.gluster.api
> E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member)
> * Module vdsm.gluster.gfapi
> E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
> E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
> * Module vdsm.supervdsm_api.udev
> ```
> for all places wherever vdsm.constants is required. Any change I am
> unaware of.
>
> Can you please pastebin the contents of your
> 'lib/vdsm/common/constants.py' file?
>
>
> Full log here : https://pastebin.com/fb77r7Hj
>
>
> On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal  wrote:
>
>> Marcin Sobczyk  writes:
>>
>> > Hi,
>> >
>> > On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>> >>
>> >> Hi,
>> >> I am having an issue running make check on vdsm master.
>> >>
>> >> `
>> >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>> >> mv .coverage .coverage-nose-py27; \
>> >> fi
>> >> Traceback (most recent call last):
>> >>   File "../tests/testrunner.py", line 70, in 
>> >> from vdsm import constants
>> >>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
>> >> 29, in 
>> >> from vdsm.common.constants import *  # NOQA: F401, F403
>> >> `
>> >> Am I missing something? Do I need to run tests differently?
>> > did you run plane 'make' before 'make check'?
>>
>> Wouldn't it be worth to fix the missing dependency?  We hit this issue
>> often.
>>
>> Even if we made `check' simply depend on `all', it would be fine IMO,
>> since the running time of `all' is negligible to the running time of
>> `check'.
>>
>> >> Thanks,
>> >>
>> >> Kaustav Majumder
>> >>
>> >>
>> >> ___
>> >> Devel mailing list -- devel@ovirt.org
>> >> To unsubscribe send an email to devel-le...@ovirt.org
>> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> >> oVirt Code of Conduct:
>> https://www.ovirt.org/community/about/community-guidelines/
>> >> List Archives:
>> >>
>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>> >
>> > ___
>> > Devel mailing list -- devel@ovirt.org
>> > To unsubscribe send an email to devel-le...@ovirt.org
>> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> > oVirt Code of Conduct:
>> https://www.ovirt.org/community/about/community-guidelines/
>> > List Archives:
>> >
>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
>> ___
>> Devel mailing list -- devel@ovirt.org
>> To unsubscribe send an email to devel-le...@ovirt.org
>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct:
>> https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/
>>
>
>
> --
>
> Thanks,
>
> Kaustav Majumder
>
>
>

-- 

Thanks,

Kaustav Majumder
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/SKXCHJZ4DNO3MLNPXSQIICBITCOM2BGT/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Marcin Sobczyk



On 10/15/19 1:44 PM, Kaustav Majumder wrote:
Thanks , solved the tox issue but now pytlint is throwing errors. 
Mostly with vdsm.constants.I have lines of

```
E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member (no-member)
* Module vdsm.gluster.api
E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member (no-member)
* Module vdsm.gluster.gfapi
E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
* Module vdsm.supervdsm_api.udev
```
for all places wherever vdsm.constants is required. Any change I am 
unaware of.
Can you please pastebin the contents of your 
'lib/vdsm/common/constants.py' file?




Full log here : https://pastebin.com/fb77r7Hj


On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal > wrote:


Marcin Sobczyk mailto:msobc...@redhat.com>>
writes:

> Hi,
>
> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>
>> Hi,
>> I am having an issue running make check on vdsm master.
>>
>> `
>> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>>         mv .coverage .coverage-nose-py27; \
>> fi
>> Traceback (most recent call last):
>>   File "../tests/testrunner.py", line 70, in 
>>     from vdsm import constants
>>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
>> 29, in 
>>     from vdsm.common.constants import *  # NOQA: F401, F403
>> `
>> Am I missing something? Do I need to run tests differently?
> did you run plane 'make' before 'make check'?

Wouldn't it be worth to fix the missing dependency?  We hit this issue
often.

Even if we made `check' simply depend on `all', it would be fine IMO,
since the running time of `all' is negligible to the running time of
`check'.

>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>> ___
>> Devel mailing list -- devel@ovirt.org 
>> To unsubscribe send an email to devel-le...@ovirt.org

>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>>

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>
> ___
> Devel mailing list -- devel@ovirt.org 
> To unsubscribe send an email to devel-le...@ovirt.org

> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
>

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
___
Devel mailing list -- devel@ovirt.org 
To unsubscribe send an email to devel-le...@ovirt.org

Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives:

https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/



--

Thanks,

Kaustav Majumder



___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/I6PNZMSUDUTFPCRCO6SNRC2CYI7BJNEL/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Marcin Sobczyk
From the images you've sent I can see that you have some very old vdsm 
version installed on your dev machine - one of the failing imports is:


/usr/libexec/vdsm/hooks/before_nic_hotplug/50_vmfex:

from vdsm import libvirtconnection

Which was changed in November, 2017 [1].
You definitely need to clean your env.

PS1 Installing vdsm in your dev environment is not the best idea ever, 
since it's kinda intrusive.

PS2 I think it's better to sent plain text than images when possible

Regards, Marcin

[1] 
https://github.com/oVirt/vdsm/commit/f64a138f4cbee96cfaa6ad1799b4364bb80850f2



On 10/15/19 1:13 PM, Prajith Kesava Prasad wrote:

Hi, thanks for that, :)


although i still am facing these issues,

___
ERROR:   tests-py27: commands failed
  storage-py27: commands succeeded
  lib-py27: commands succeeded
ERROR:   network-py27: commands failed
ERROR:   virt-py27: commands failed
  gluster-py27: commands succeeded
make: *** [Makefile:1047: tests-py27] Error 1


Thanks,
Prajith K Prasad


On Tue, Oct 15, 2019 at 3:27 PM Marcin Sobczyk > wrote:


Hi,

On 10/15/19 9:28 AM, Prajith Kesava Prasad wrote:

hey,

even im facing a issue with make check, i have installed all the
libraries,

That doesn't seem to be the case since the screenshots mentions
missing 'netaddr' and 'mock' packages.
Please try running:

sudo dnf install $(cat automation/check-patch.packages.fc29)

from your vdsm dir.


the following occurs on fedora 29, IDE:Pycharm
could some one help me with this?

Thanks,
Prajith Kesava Prasad

___
Devel mailing list --devel@ovirt.org  
To unsubscribe send an email todevel-le...@ovirt.org  

Privacy Statement:https://www.ovirt.org/site/privacy-policy/
oVirt Code of 
Conduct:https://www.ovirt.org/community/about/community-guidelines/
List 
Archives:https://lists.ovirt.org/archives/list/devel@ovirt.org/message/PUSD2FVSLAZEC2EQPLIMI4GJQAED6VCC/




___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MFQ2ZWNWLJSXEBPWPISV54KF3JI6VLY3/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Marcin Sobczyk

Hi,

On 10/15/19 9:28 AM, Prajith Kesava Prasad wrote:

hey,

even im facing a issue with make check, i have installed all the 
libraries,
That doesn't seem to be the case since the screenshots mentions missing 
'netaddr' and 'mock' packages.

Please try running:

sudo dnf install $(cat automation/check-patch.packages.fc29)

from your vdsm dir.


the following occurs on fedora 29, IDE:Pycharm
could some one help me with this?

Thanks,
Prajith Kesava Prasad

___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/PUSD2FVSLAZEC2EQPLIMI4GJQAED6VCC/


___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/JJT2VRAKU3VUAOFFUMM2QQX2GNAWL2XB/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Milan Zamazal
Marcin Sobczyk  writes:

> Hi,
>
> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>
>> Hi,
>> I am having an issue running make check on vdsm master.
>>
>> `
>> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>>         mv .coverage .coverage-nose-py27; \
>> fi
>> Traceback (most recent call last):
>>   File "../tests/testrunner.py", line 70, in 
>>     from vdsm import constants
>>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
>> 29, in 
>>     from vdsm.common.constants import *  # NOQA: F401, F403
>> `
>> Am I missing something? Do I need to run tests differently?
> did you run plane 'make' before 'make check'?

Wouldn't it be worth to fix the missing dependency?  We hit this issue
often.

Even if we made `check' simply depend on `all', it would be fine IMO,
since the running time of `all' is negligible to the running time of
`check'.

>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>> ___
>> Devel mailing list -- devel@ovirt.org
>> To unsubscribe send an email to devel-le...@ovirt.org
>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct: 
>> https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct: 
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-15 Thread Vojtech Juranek
> Thanks for pointing that out. Right now the only isssue is upgrading tox
> I guess.

yes. Fedora provides only 3.5, so you need to upgrade it via pip (and make 
sure you use one installed via pip and not from package if you previously 
installed it)

> ```
> [kmajumde:~/work/git/vdsm] master+* 2 ± make check
> Makefile:1029: warning: overriding recipe for target 'check-recursive'
> Makefile:548: warning: ignoring old recipe for target 'check-recursive'
> Checking that .in files are ignored...
> ! git --no-pager grep execCmd `git ls-files | grep -v -F -f
> execcmd-blacklist.txt`
> out=`tox --version`; \
> if [ $? -ne 0 ]; then \
> echo "Error: cannot run tox, please install tox \
> 3.14 or later"; \
> exit 1; \
> fi; \
> version=`echo $out | cut -d' ' -f1`; \
> if python2.7 build-aux/vercmp $version 3.14; then \
> echo "Error: tox is too old, please install tox \
> 3.14 or later"; \
> exit 1; \
> fi
> Error: tox is too old, please install tox   3.14 or later
> make: *** [Makefile:1012: tox] Error 1
> ```
> 
> On Mon, Oct 14, 2019 at 10:42 PM Benny Zlotnik  wrote:
> > did you run autogen.sh?
> > 
> > On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder 
> > 
> > wrote:
> > > Yes i did but same issue.
> > > 
> > > On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk 
> > 
> > wrote:
> > >> Hi,
> > >> 
> > >> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
> > >> 
> > >> 
> > >> Hi,
> > >> I am having an issue running make check on vdsm master.
> > >> 
> > >> `
> > >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
> > >> 
> > >> mv .coverage .coverage-nose-py27; \
> > >> 
> > >> fi
> > >> 
> > >> Traceback (most recent call last):
> > >>   File "../tests/testrunner.py", line 70, in 
> > >>   
> > >> from vdsm import constants
> > >>   
> > >>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29,
> > 
> > in 
> > 
> > >> from vdsm.common.constants import *  # NOQA: F401, F403
> > >> 
> > >> `
> > >> Am I missing something? Do I need to run tests differently?
> > >> 
> > >> did you run plane 'make' before 'make check'?
> > >> 
> > >> --
> > >> 
> > >> Thanks,
> > >> 
> > >> Kaustav Majumder
> > >> 
> > >> 
> > >> ___
> > >> Devel mailing list -- devel@ovirt.org
> > >> To unsubscribe send an email to devel-le...@ovirt.org
> > >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> > 
> > >> oVirt Code of Conduct:
> > https://www.ovirt.org/community/about/community-guidelines/
> > 
> > >> List Archives:
> > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLD
> > VOWHW6RZWBLMETZ3NYCM/> 
> > > --
> > > 
> > > Thanks,
> > > 
> > > Kaustav Majumder
> > > 
> > > ___
> > > Devel mailing list -- devel@ovirt.org
> > > To unsubscribe send an email to devel-le...@ovirt.org
> > > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> > 
> > > oVirt Code of Conduct:
> > https://www.ovirt.org/community/about/community-guidelines/
> > 
> > > List Archives:
> > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WE
> > LAQT5EHG6U72LWQFUGSK/



signature.asc
Description: This is a digitally signed message part.
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/433TI2GA37QFFA4G4NB53JXENH2OZOEF/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-14 Thread Kaustav Majumder
Thanks for pointing that out. Right now the only isssue is upgrading tox
I guess.
```
[kmajumde:~/work/git/vdsm] master+* 2 ± make check
Makefile:1029: warning: overriding recipe for target 'check-recursive'
Makefile:548: warning: ignoring old recipe for target 'check-recursive'
Checking that .in files are ignored...
! git --no-pager grep execCmd `git ls-files | grep -v -F -f
execcmd-blacklist.txt`
out=`tox --version`; \
if [ $? -ne 0 ]; then \
echo "Error: cannot run tox, please install tox \
3.14 or later"; \
exit 1; \
fi; \
version=`echo $out | cut -d' ' -f1`; \
if python2.7 build-aux/vercmp $version 3.14; then \
echo "Error: tox is too old, please install tox \
3.14 or later"; \
exit 1; \
fi
Error: tox is too old, please install tox   3.14 or later
make: *** [Makefile:1012: tox] Error 1
```

On Mon, Oct 14, 2019 at 10:42 PM Benny Zlotnik  wrote:

> did you run autogen.sh?
>
> On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder 
> wrote:
> >
> > Yes i did but same issue.
> >
> > On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk 
> wrote:
> >>
> >> Hi,
> >>
> >> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
> >>
> >>
> >> Hi,
> >> I am having an issue running make check on vdsm master.
> >>
> >> `
> >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
> >> mv .coverage .coverage-nose-py27; \
> >> fi
> >> Traceback (most recent call last):
> >>   File "../tests/testrunner.py", line 70, in 
> >> from vdsm import constants
> >>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29,
> in 
> >> from vdsm.common.constants import *  # NOQA: F401, F403
> >> `
> >> Am I missing something? Do I need to run tests differently?
> >>
> >> did you run plane 'make' before 'make check'?
> >>
> >> --
> >>
> >> Thanks,
> >>
> >> Kaustav Majumder
> >>
> >>
> >> ___
> >> Devel mailing list -- devel@ovirt.org
> >> To unsubscribe send an email to devel-le...@ovirt.org
> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> >> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> >> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
> >>
> >>
> >
> >
> > --
> >
> > Thanks,
> >
> > Kaustav Majumder
> >
> > ___
> > Devel mailing list -- devel@ovirt.org
> > To unsubscribe send an email to devel-le...@ovirt.org
> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> > oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> > List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WELAQT5EHG6U72LWQFUGSK/
>


-- 

Thanks,

Kaustav Majumder
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/Z6MROU33OYRH5G2KAWVGPTF6AU45AASC/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-14 Thread Benny Zlotnik
did you run autogen.sh?

On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder  wrote:
>
> Yes i did but same issue.
>
> On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk  wrote:
>>
>> Hi,
>>
>> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>>
>>
>> Hi,
>> I am having an issue running make check on vdsm master.
>>
>> `
>> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
>> mv .coverage .coverage-nose-py27; \
>> fi
>> Traceback (most recent call last):
>>   File "../tests/testrunner.py", line 70, in 
>> from vdsm import constants
>>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in 
>> 
>> from vdsm.common.constants import *  # NOQA: F401, F403
>> `
>> Am I missing something? Do I need to run tests differently?
>>
>> did you run plane 'make' before 'make check'?
>>
>> --
>>
>> Thanks,
>>
>> Kaustav Majumder
>>
>>
>> ___
>> Devel mailing list -- devel@ovirt.org
>> To unsubscribe send an email to devel-le...@ovirt.org
>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct: 
>> https://www.ovirt.org/community/about/community-guidelines/
>> List Archives: 
>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>>
>>
>
>
> --
>
> Thanks,
>
> Kaustav Majumder
>
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct: 
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives: 
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WELAQT5EHG6U72LWQFUGSK/
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/J7DKXPJXLL5NF6MKTIEDA4LYIHO2NMVI/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-14 Thread Kaustav Majumder
Yes i did but same issue.

On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk  wrote:

> Hi,
>
> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
>
>
> Hi,
> I am having an issue running make check on vdsm master.
>
> `
> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
> mv .coverage .coverage-nose-py27; \
> fi
> Traceback (most recent call last):
>   File "../tests/testrunner.py", line 70, in 
> from vdsm import constants
>   File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, in
> 
> from vdsm.common.constants import *  # NOQA: F401, F403
> `
> Am I missing something? Do I need to run tests differently?
>
> did you run plane 'make' before 'make check'?
>
> --
>
> Thanks,
>
> Kaustav Majumder
>
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct: 
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives: 
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
>
>
>

-- 

Thanks,

Kaustav Majumder
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WELAQT5EHG6U72LWQFUGSK/


[ovirt-devel] Re: Problem with vdsm 'make check'

2019-10-14 Thread Marcin Sobczyk

Hi,

On 10/14/19 3:06 PM, Kaustav Majumder wrote:


Hi,
I am having an issue running make check on vdsm master.

`
if [ -n "$NOSE_WITH_COVERAGE" ]; then \
        mv .coverage .coverage-nose-py27; \
fi
Traceback (most recent call last):
  File "../tests/testrunner.py", line 70, in 
    from vdsm import constants
  File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line 29, 
in 

    from vdsm.common.constants import *  # NOQA: F401, F403
`
Am I missing something? Do I need to run tests differently?

did you run plane 'make' before 'make check'?


--

Thanks,

Kaustav Majumder


___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/


___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/