Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Vojtech Szocs 


- Original Message -
> From: "Eyal Edri" <ee...@redhat.com>
> To: "Vojtech Szocs" <vsz...@redhat.com>
> Cc: "Oved Ourfali" <oourf...@redhat.com>, "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 2:38:40 PM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> Vojtech,
> Any ideas on a test we can add to check-patch.sh (other than building all
> permutations) that can help catch these ?

We already have Java unit tests for these issues:

  org.ovirt.engine.ui.uicompat.UIMessagesTest
  org.ovirt.engine.ui.common.CommonApplicationMessagesTest
  org.ovirt.engine.ui.userportal.ApplicationMessagesTest
  org.ovirt.engine.ui.webadmin.ApplicationMessagesTest

they were added like 1 year ago by Alexander [1].

[1] https://gerrit.ovirt.org/#/c/32995/

I'm not sure why `check-patch` didn't report errors,
because above mentioned unit tests should be executed
just like any other Engine unit tests.

> 
> The original patch didn't fail on unit tests (though I can't see info since
> the build got deleted, we now increased the history for builds so we will
> be able to see it).

I don't know why above mentioned unit tests didn't
fail when `check-patch` was executed. If this happens
again, we can investigate test logs for that build.

> Please let me know once the translations patch is re-submitted,I'd like to
> monitor it and see if CI catch any issues there.

OK, we'll let you know.

> 
> e.
> 
> On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> 
> >
> >
> > - Original Message -
> > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 2:24:21 PM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > >
> > >
> > > ----- Original Message -
> > > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro"
> > > > <dcaro...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > >
> > > >
> > > > - Original Message -
> > > > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > > Okay.
> > > > > Makes sense.
> > > > > Thanks Vojtech - please also revert this one.
> > > >
> > > > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > > > gives me "500 Internal server error" -- am I missing something?
> > > >
> > > > Perhaps oVirt gerrit maintainers can advise here? (adding David)
> > >
> > > Sorry for the noise, I did it manually with git revert:
> > >
> > >   https://gerrit.ovirt.org/#/c/57031/
> > >
> > > Can someone please ack?
> >
> > Merged, this should fix the master build.
> >
> > >
> > > >
> > > > >
> > > > > Oved
> > > > >
> > > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com>
> > wrote:
> > > > >
> > > > > > (top-posting)
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > root cause is wrong number of message parameters (placeholders)
> > > > > > in translated properties files, compared to message definitions
> > > > > > in Java code.
> > > > > >
> > > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > > > > but the corresponding message in `UIMessages_de_DE.properties`
> > > > > > only contains 3 placeholders.
> > > > > >
> > > > > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > > > > definitions in Java code.
> > > > > >
> > > >

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Alexander Wels 
On Wednesday, May 04, 2016 03:48:27 PM Eyal Edri wrote:
> On Wed, May 4, 2016 at 3:41 PM, Alexander Wels <aw...@redhat.com> wrote:
> > On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:
> > > Vojtech,
> > > Any ideas on a test we can add to check-patch.sh (other than building
> > > all
> > > permutations) that can help catch these ?
> > > 
> > > The original patch didn't fail on unit tests (though I can't see info
> > 
> > since
> > 
> > > the build got deleted, we now increased the history for builds so we
> > > will
> > > be able to see it).
> > > Please let me know once the translations patch is re-submitted,I'd like
> > 
> > to
> > 
> > > monitor it and see if CI catch any issues there.
> > > 
> > > e.
> > 
> > Eyal,
> > 
> > I wrote a unit test specifically to catch this particular issue without
> > having
> > to compile all the permutations. This is what failed the build, I don't
> > understand why it wasn't run during CI.
> 
> Does it run on specific code change/path/file?
> I can't check why unfortunately since the history is gone, but if you can
> reproduce the patch we can check.
> 

Its a standard unit test that is run during the test suite.

> > > On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> > > > ----- Original Message -
> > > > 
> > > > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > > > Cc: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 2:24:21 PM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > > 
> > > > > 
> > > > > 
> > > > > - Original Message -
> > > > > 
> > > > > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro"
> > > > > > <dcaro...@redhat.com>
> > > > > > Cc: "devel" <devel@ovirt.org>
> > > > > > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > - Original Message -
> > > > > > 
> > > > > > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > > > > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > > > > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > > > > 
> > > > > > > Okay.
> > > > > > > Makes sense.
> > > > > > > Thanks Vojtech - please also revert this one.
> > > > > > 
> > > > > > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > > > > > gives me "500 Internal server error" -- am I missing something?
> > > > > > 
> > > > > > Perhaps oVirt gerrit maintainers can advise here? (adding David)
> > > > > 
> > > > > Sorry for the noise, I did it manually with git revert:
> > > > >   https://gerrit.ovirt.org/#/c/57031/
> > > > > 
> > > > > Can someone please ack?
> > > > 
> > > > Merged, this should fix the master build.
> > > > 
> > > > > > > Oved
> > > > > > > 
> > > > > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com
> > > > 
> > > > wrote:
> > > > > > > > (top-posting)
> > > > > > > > 
> > > > > > > > Hi,
> > > > > > > > 
> > > > > > > > root cause is wrong number of message parameters
> > > > > > > > (placeholders)
> > > > > > > > in translated properties files, compared to message
> > > > > > > > definitions
> > > > > > > > in Java code.
> > > > > > > > 
> > > > &g

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Eyal Edri 
On Wed, May 4, 2016 at 3:41 PM, Alexander Wels <aw...@redhat.com> wrote:

> On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:
> > Vojtech,
> > Any ideas on a test we can add to check-patch.sh (other than building all
> > permutations) that can help catch these ?
> >
> > The original patch didn't fail on unit tests (though I can't see info
> since
> > the build got deleted, we now increased the history for builds so we will
> > be able to see it).
> > Please let me know once the translations patch is re-submitted,I'd like
> to
> > monitor it and see if CI catch any issues there.
> >
> > e.
> >
>
> Eyal,
>
> I wrote a unit test specifically to catch this particular issue without
> having
> to compile all the permutations. This is what failed the build, I don't
> understand why it wasn't run during CI.
>

Does it run on specific code change/path/file?
I can't check why unfortunately since the history is gone, but if you can
reproduce the patch we can check.


>
> > On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> > > - Original Message -
> > >
> > > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 2:24:21 PM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > >
> > > >
> > > > - Original Message -----
> > > >
> > > > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro"
> > > > > <dcaro...@redhat.com>
> > > > > Cc: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > >
> > > > >
> > > > > - Original Message -
> > > > >
> > > > > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > > > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > > > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > > >
> > > > > > Okay.
> > > > > > Makes sense.
> > > > > > Thanks Vojtech - please also revert this one.
> > > > >
> > > > > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > > > > gives me "500 Internal server error" -- am I missing something?
> > > > >
> > > > > Perhaps oVirt gerrit maintainers can advise here? (adding David)
> > > >
> > > > Sorry for the noise, I did it manually with git revert:
> > > >   https://gerrit.ovirt.org/#/c/57031/
> > > >
> > > > Can someone please ack?
> > >
> > > Merged, this should fix the master build.
> > >
> > > > > > Oved
> > > > > >
> > > > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com
> >
> > >
> > > wrote:
> > > > > > > (top-posting)
> > > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > root cause is wrong number of message parameters (placeholders)
> > > > > > > in translated properties files, compared to message definitions
> > > > > > > in Java code.
> > > > > > >
> > > > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > > > > > but the corresponding message in `UIMessages_de_DE.properties`
> > > > > > > only contains 3 placeholders.
> > > > > > >
> > > > > > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > > > > > definitions in Java code.
> > > > > > >
> > > > > > > I suggest to simply revert the offending patch:
> > > > > > >   translations update from zanata ovirt-3.6
> > > > > >

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Alexander Wels 
On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:
> Vojtech,
> Any ideas on a test we can add to check-patch.sh (other than building all
> permutations) that can help catch these ?
> 
> The original patch didn't fail on unit tests (though I can't see info since
> the build got deleted, we now increased the history for builds so we will
> be able to see it).
> Please let me know once the translations patch is re-submitted,I'd like to
> monitor it and see if CI catch any issues there.
> 
> e.
> 

Eyal,

I wrote a unit test specifically to catch this particular issue without having 
to compile all the permutations. This is what failed the build, I don't 
understand why it wasn't run during CI.

> On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> > - Original Message -
> > 
> > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 2:24:21 PM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > 
> > > 
> > > 
> > > - Original Message -
> > > 
> > > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro"
> > > > <dcaro...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > 
> > > > 
> > > > 
> > > > - Original Message -
> > > > 
> > > > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > > 
> > > > > Okay.
> > > > > Makes sense.
> > > > > Thanks Vojtech - please also revert this one.
> > > > 
> > > > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > > > gives me "500 Internal server error" -- am I missing something?
> > > > 
> > > > Perhaps oVirt gerrit maintainers can advise here? (adding David)
> > > 
> > > Sorry for the noise, I did it manually with git revert:
> > >   https://gerrit.ovirt.org/#/c/57031/
> > > 
> > > Can someone please ack?
> > 
> > Merged, this should fix the master build.
> > 
> > > > > Oved
> > > > > 
> > > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com>
> > 
> > wrote:
> > > > > > (top-posting)
> > > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > root cause is wrong number of message parameters (placeholders)
> > > > > > in translated properties files, compared to message definitions
> > > > > > in Java code.
> > > > > > 
> > > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > > > > but the corresponding message in `UIMessages_de_DE.properties`
> > > > > > only contains 3 placeholders.
> > > > > > 
> > > > > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > > > > definitions in Java code.
> > > > > > 
> > > > > > I suggest to simply revert the offending patch:
> > > > > >   translations update from zanata ovirt-3.6
> > > > > >   https://gerrit.ovirt.org/#/c/56720/
> > > > > > 
> > > > > > and create new one which doesn't introduce conflicts.
> > > > > > 
> > > > > > We have unit tests to detect these kinds of errors, this is
> > > > > > to ensure the build fails early on (before GWT compilation).
> > > > > > 
> > > > > > I'm not sure why `check-patch` job for above mentioned patch
> > > > > > didn't report the problem, since UIMessagesTest should fail,
> > > > > > as Roman wrote below.
> > > > > > 
> > > > > > Regards,
>

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Eyal Edri 
Vojtech,
Any ideas on a test we can add to check-patch.sh (other than building all
permutations) that can help catch these ?

The original patch didn't fail on unit tests (though I can't see info since
the build got deleted, we now increased the history for builds so we will
be able to see it).
Please let me know once the translations patch is re-submitted,I'd like to
monitor it and see if CI catch any issues there.

e.

On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <vsz...@redhat.com> wrote:

>
>
> - Original Message -
> > From: "Vojtech Szocs" <vsz...@redhat.com>
> > To: "Oved Ourfali" <oourf...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 2:24:21 PM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> >
> >
> >
> > - Original Message -
> > > From: "Vojtech Szocs" <vsz...@redhat.com>
> > > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro"
> > > <dcaro...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > >
> > >
> > > - Original Message -----
> > > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > > Okay.
> > > > Makes sense.
> > > > Thanks Vojtech - please also revert this one.
> > >
> > > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > > gives me "500 Internal server error" -- am I missing something?
> > >
> > > Perhaps oVirt gerrit maintainers can advise here? (adding David)
> >
> > Sorry for the noise, I did it manually with git revert:
> >
> >   https://gerrit.ovirt.org/#/c/57031/
> >
> > Can someone please ack?
>
> Merged, this should fix the master build.
>
> >
> > >
> > > >
> > > > Oved
> > > >
> > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com>
> wrote:
> > > >
> > > > > (top-posting)
> > > > >
> > > > > Hi,
> > > > >
> > > > > root cause is wrong number of message parameters (placeholders)
> > > > > in translated properties files, compared to message definitions
> > > > > in Java code.
> > > > >
> > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > > > but the corresponding message in `UIMessages_de_DE.properties`
> > > > > only contains 3 placeholders.
> > > > >
> > > > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > > > definitions in Java code.
> > > > >
> > > > > I suggest to simply revert the offending patch:
> > > > >
> > > > >   translations update from zanata ovirt-3.6
> > > > >   https://gerrit.ovirt.org/#/c/56720/
> > > > >
> > > > > and create new one which doesn't introduce conflicts.
> > > > >
> > > > > We have unit tests to detect these kinds of errors, this is
> > > > > to ensure the build fails early on (before GWT compilation).
> > > > >
> > > > > I'm not sure why `check-patch` job for above mentioned patch
> > > > > didn't report the problem, since UIMessagesTest should fail,
> > > > > as Roman wrote below.
> > > > >
> > > > > Regards,
> > > > > Vojtech
> > > > >
> > > > >
> > > > > - Original Message -
> > > > > > From: "Marek Libra" <mli...@redhat.com>
> > > > > > To: "devel" <devel@ovirt.org>
> > > > > > Sent: Wednesday, May 4, 2016 12:31:18 PM
> > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > > >
> > > > > > There are issues on other keys as well.
> > > > > > I'm rebuilding for all locales locally now.
> > > > > >
>

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Vojtech Szocs 


- Original Message -
> From: "Vojtech Szocs" <vsz...@redhat.com>
> To: "Oved Ourfali" <oourf...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 2:24:21 PM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> 
> 
> - Original Message -
> > From: "Vojtech Szocs" <vsz...@redhat.com>
> > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro"
> > <dcaro...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > 
> > 
> > 
> > - Original Message -
> > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > 
> > > Okay.
> > > Makes sense.
> > > Thanks Vojtech - please also revert this one.
> > 
> > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > gives me "500 Internal server error" -- am I missing something?
> > 
> > Perhaps oVirt gerrit maintainers can advise here? (adding David)
> 
> Sorry for the noise, I did it manually with git revert:
> 
>   https://gerrit.ovirt.org/#/c/57031/
> 
> Can someone please ack?

Merged, this should fix the master build.

> 
> > 
> > > 
> > > Oved
> > > 
> > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> > > 
> > > > (top-posting)
> > > >
> > > > Hi,
> > > >
> > > > root cause is wrong number of message parameters (placeholders)
> > > > in translated properties files, compared to message definitions
> > > > in Java code.
> > > >
> > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > > but the corresponding message in `UIMessages_de_DE.properties`
> > > > only contains 3 placeholders.
> > > >
> > > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > > definitions in Java code.
> > > >
> > > > I suggest to simply revert the offending patch:
> > > >
> > > >   translations update from zanata ovirt-3.6
> > > >   https://gerrit.ovirt.org/#/c/56720/
> > > >
> > > > and create new one which doesn't introduce conflicts.
> > > >
> > > > We have unit tests to detect these kinds of errors, this is
> > > > to ensure the build fails early on (before GWT compilation).
> > > >
> > > > I'm not sure why `check-patch` job for above mentioned patch
> > > > didn't report the problem, since UIMessagesTest should fail,
> > > > as Roman wrote below.
> > > >
> > > > Regards,
> > > > Vojtech
> > > >
> > > >
> > > > - Original Message -
> > > > > From: "Marek Libra" <mli...@redhat.com>
> > > > > To: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 12:31:18 PM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > > There are issues on other keys as well.
> > > > > I'm rebuilding for all locales locally now.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > From: "Marek Libra" <mli...@redhat.com>
> > > > > To: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 11:29:55 AM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > > The fix is here: https://gerrit.ovirt.org/#/c/57007/
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > From: "Roman Mohr" <rm...@redhat.com>
> > > > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > > > Cc: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 10:27:51 AM
> > > > > Subject: Re: [ovirt-devel] Master ovir

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Oved Ourfali 
On Wed, May 4, 2016 at 3:24 PM, Vojtech Szocs <vsz...@redhat.com> wrote:

>
>
> - Original Message -
> > From: "Vojtech Szocs" <vsz...@redhat.com>
> > To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro" <
> dcaro...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 2:19:09 PM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> >
> >
> >
> > - Original Message -
> > > From: "Oved Ourfali" <oourf...@redhat.com>
> > > To: "Vojtech Szocs" <vsz...@redhat.com>
> > > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > > Okay.
> > > Makes sense.
> > > Thanks Vojtech - please also revert this one.
> >
> > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> > gives me "500 Internal server error" -- am I missing something?
> >
> > Perhaps oVirt gerrit maintainers can advise here? (adding David)
>
> Sorry for the noise, I did it manually with git revert:
>
>   https://gerrit.ovirt.org/#/c/57031/
>
> Can someone please ack?
>

done.


>
> >
> > >
> > > Oved
> > >
> > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com>
> wrote:
> > >
> > > > (top-posting)
> > > >
> > > > Hi,
> > > >
> > > > root cause is wrong number of message parameters (placeholders)
> > > > in translated properties files, compared to message definitions
> > > > in Java code.
> > > >
> > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > > but the corresponding message in `UIMessages_de_DE.properties`
> > > > only contains 3 placeholders.
> > > >
> > > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > > definitions in Java code.
> > > >
> > > > I suggest to simply revert the offending patch:
> > > >
> > > >   translations update from zanata ovirt-3.6
> > > >   https://gerrit.ovirt.org/#/c/56720/
> > > >
> > > > and create new one which doesn't introduce conflicts.
> > > >
> > > > We have unit tests to detect these kinds of errors, this is
> > > > to ensure the build fails early on (before GWT compilation).
> > > >
> > > > I'm not sure why `check-patch` job for above mentioned patch
> > > > didn't report the problem, since UIMessagesTest should fail,
> > > > as Roman wrote below.
> > > >
> > > > Regards,
> > > > Vojtech
> > > >
> > > >
> > > > - Original Message -
> > > > > From: "Marek Libra" <mli...@redhat.com>
> > > > > To: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 12:31:18 PM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > > There are issues on other keys as well.
> > > > > I'm rebuilding for all locales locally now.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > From: "Marek Libra" <mli...@redhat.com>
> > > > > To: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 11:29:55 AM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > > The fix is here: https://gerrit.ovirt.org/#/c/57007/
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > From: "Roman Mohr" <rm...@redhat.com>
> > > > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > > > Cc: "devel" <devel@ovirt.org>
> > > > > Sent: Wednesday, May 4, 2016 10:27:51 AM
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > >
> > > > >
> > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <
> oourf...@redhat.com >
> > > > wrote:
> > > > >
> > > > >
> > >

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Vojtech Szocs 


- Original Message -
> From: "Vojtech Szocs" <vsz...@redhat.com>
> To: "Oved Ourfali" <oourf...@redhat.com>, "David Caro" <dcaro...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 2:19:09 PM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> 
> 
> - Original Message -
> > From: "Oved Ourfali" <oourf...@redhat.com>
> > To: "Vojtech Szocs" <vsz...@redhat.com>
> > Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 2:07:19 PM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > 
> > Okay.
> > Makes sense.
> > Thanks Vojtech - please also revert this one.
> 
> Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
> gives me "500 Internal server error" -- am I missing something?
> 
> Perhaps oVirt gerrit maintainers can advise here? (adding David)

Sorry for the noise, I did it manually with git revert:

  https://gerrit.ovirt.org/#/c/57031/

Can someone please ack?

> 
> > 
> > Oved
> > 
> > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> > 
> > > (top-posting)
> > >
> > > Hi,
> > >
> > > root cause is wrong number of message parameters (placeholders)
> > > in translated properties files, compared to message definitions
> > > in Java code.
> > >
> > > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > > but the corresponding message in `UIMessages_de_DE.properties`
> > > only contains 3 placeholders.
> > >
> > > 4.0 String Freeze is May 25 so it's still OK to modify message
> > > definitions in Java code.
> > >
> > > I suggest to simply revert the offending patch:
> > >
> > >   translations update from zanata ovirt-3.6
> > >   https://gerrit.ovirt.org/#/c/56720/
> > >
> > > and create new one which doesn't introduce conflicts.
> > >
> > > We have unit tests to detect these kinds of errors, this is
> > > to ensure the build fails early on (before GWT compilation).
> > >
> > > I'm not sure why `check-patch` job for above mentioned patch
> > > didn't report the problem, since UIMessagesTest should fail,
> > > as Roman wrote below.
> > >
> > > Regards,
> > > Vojtech
> > >
> > >
> > > ----- Original Message -
> > > > From: "Marek Libra" <mli...@redhat.com>
> > > > To: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 12:31:18 PM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > > There are issues on other keys as well.
> > > > I'm rebuilding for all locales locally now.
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > From: "Marek Libra" <mli...@redhat.com>
> > > > To: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 11:29:55 AM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > > The fix is here: https://gerrit.ovirt.org/#/c/57007/
> > > >
> > > >
> > > >
> > > >
> > > > From: "Roman Mohr" <rm...@redhat.com>
> > > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > > Cc: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 10:27:51 AM
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > >
> > > >
> > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourf...@redhat.com >
> > > wrote:
> > > >
> > > >
> > > >
> > > > Roman - did you build the langs in order to find the issue?
> > > >
> > > > I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not
> > > all
> > > > of my builds showed that error.
> > > >
> > > > Looking at
> > > >
> > > >
> > > https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
> > > >
> > > > two patches passed and two failed after a topic rebase.
> > > >
> > > >
> > &

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Vojtech Szocs 


- Original Message -
> From: "Oved Ourfali" <oourf...@redhat.com>
> To: "Vojtech Szocs" <vsz...@redhat.com>
> Cc: "Marek Libra" <mli...@redhat.com>, "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 2:07:19 PM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> Okay.
> Makes sense.
> Thanks Vojtech - please also revert this one.

Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/
gives me "500 Internal server error" -- am I missing something?

Perhaps oVirt gerrit maintainers can advise here? (adding David)

> 
> Oved
> 
> On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com> wrote:
> 
> > (top-posting)
> >
> > Hi,
> >
> > root cause is wrong number of message parameters (placeholders)
> > in translated properties files, compared to message definitions
> > in Java code.
> >
> > For example, UIMessages#cpuInfoLabel method has 4 parameters,
> > but the corresponding message in `UIMessages_de_DE.properties`
> > only contains 3 placeholders.
> >
> > 4.0 String Freeze is May 25 so it's still OK to modify message
> > definitions in Java code.
> >
> > I suggest to simply revert the offending patch:
> >
> >   translations update from zanata ovirt-3.6
> >   https://gerrit.ovirt.org/#/c/56720/
> >
> > and create new one which doesn't introduce conflicts.
> >
> > We have unit tests to detect these kinds of errors, this is
> > to ensure the build fails early on (before GWT compilation).
> >
> > I'm not sure why `check-patch` job for above mentioned patch
> > didn't report the problem, since UIMessagesTest should fail,
> > as Roman wrote below.
> >
> > Regards,
> > Vojtech
> >
> >
> > - Original Message -
> > > From: "Marek Libra" <mli...@redhat.com>
> > > To: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 12:31:18 PM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > > There are issues on other keys as well.
> > > I'm rebuilding for all locales locally now.
> > >
> > >
> > >
> > >
> > >
> > > From: "Marek Libra" <mli...@redhat.com>
> > > To: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 11:29:55 AM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > > The fix is here: https://gerrit.ovirt.org/#/c/57007/
> > >
> > >
> > >
> > >
> > > From: "Roman Mohr" <rm...@redhat.com>
> > > To: "Oved Ourfali" <oourf...@redhat.com>
> > > Cc: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 10:27:51 AM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > >
> > >
> > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourf...@redhat.com >
> > wrote:
> > >
> > >
> > >
> > > Roman - did you build the langs in order to find the issue?
> > >
> > > I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not
> > all
> > > of my builds showed that error.
> > >
> > > Looking at
> > >
> > >
> > https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
> > >
> > > two patches passed and two failed after a topic rebase.
> > >
> > >
> > >
> > > Eyal - can we monitor a list of files that i changed will result in also
> > > building all the languages?
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < ee...@redhat.com > wrote:
> > >
> > >
> > >
> > > right, and we can't enable lang permutation since it takes a very long
> > time
> > > to run.
> > >
> > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjeli...@redhat.com >
> > wrote:
> > >
> > >
> > >
> > >
> > > - Original Message -
> > > > From: "Oved Ourfali" < oourf...@redhat.com >
> > > > To: "Tomas Jelinek" < tjeli...@redhat.com >
> > > > Cc: "Roman Mohr" < rm...@redhat.com >, "devel" < devel@ovirt.org >,
> > "Scott
> > > &g

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Oved Ourfali 
Okay.
Makes sense.
Thanks Vojtech - please also revert this one.

Oved

On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <vsz...@redhat.com> wrote:

> (top-posting)
>
> Hi,
>
> root cause is wrong number of message parameters (placeholders)
> in translated properties files, compared to message definitions
> in Java code.
>
> For example, UIMessages#cpuInfoLabel method has 4 parameters,
> but the corresponding message in `UIMessages_de_DE.properties`
> only contains 3 placeholders.
>
> 4.0 String Freeze is May 25 so it's still OK to modify message
> definitions in Java code.
>
> I suggest to simply revert the offending patch:
>
>   translations update from zanata ovirt-3.6
>   https://gerrit.ovirt.org/#/c/56720/
>
> and create new one which doesn't introduce conflicts.
>
> We have unit tests to detect these kinds of errors, this is
> to ensure the build fails early on (before GWT compilation).
>
> I'm not sure why `check-patch` job for above mentioned patch
> didn't report the problem, since UIMessagesTest should fail,
> as Roman wrote below.
>
> Regards,
> Vojtech
>
>
> - Original Message -
> > From: "Marek Libra" <mli...@redhat.com>
> > To: "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 12:31:18 PM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> >
> > There are issues on other keys as well.
> > I'm rebuilding for all locales locally now.
> >
> >
> >
> >
> >
> > From: "Marek Libra" <mli...@redhat.com>
> > To: "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 11:29:55 AM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> >
> > The fix is here: https://gerrit.ovirt.org/#/c/57007/
> >
> >
> >
> >
> > From: "Roman Mohr" <rm...@redhat.com>
> > To: "Oved Ourfali" <oourf...@redhat.com>
> > Cc: "devel" <devel@ovirt.org>
> > Sent: Wednesday, May 4, 2016 10:27:51 AM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> >
> >
> >
> > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourf...@redhat.com >
> wrote:
> >
> >
> >
> > Roman - did you build the langs in order to find the issue?
> >
> > I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not
> all
> > of my builds showed that error.
> >
> > Looking at
> >
> >
> https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
> >
> > two patches passed and two failed after a topic rebase.
> >
> >
> >
> > Eyal - can we monitor a list of files that i changed will result in also
> > building all the languages?
> >
> >
> >
> >
> >
> >
> > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < ee...@redhat.com > wrote:
> >
> >
> >
> > right, and we can't enable lang permutation since it takes a very long
> time
> > to run.
> >
> > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjeli...@redhat.com >
> wrote:
> >
> >
> >
> >
> > - Original Message -
> > > From: "Oved Ourfali" < oourf...@redhat.com >
> > > To: "Tomas Jelinek" < tjeli...@redhat.com >
> > > Cc: "Roman Mohr" < rm...@redhat.com >, "devel" < devel@ovirt.org >,
> "Scott
> > > Dickerson" < sdick...@redhat.com >
> > > Sent: Wednesday, May 4, 2016 9:55:40 AM
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > >
> > > I wonder, how come the CI didn't catch that?
> >
> > because this happens only when you compile with language permutations
> >
> > >
> > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjeli...@redhat.com >
> > > wrote:
> > >
> > > > hmmm,
> > > > regression introduced yesterday by
> https://gerrit.ovirt.org/#/c/56720/
> > > > fix on the way
> > > >
> > > > - Original Message -
> > > > > From: "Roman Mohr" < rm...@redhat.com >
> > > > > To: "devel" < devel@ovirt.org >
> > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > > > > Subject: [ovirt-devel] Master ovirt-engine build broken
> > > > >
> > > > > Hi,
> > > > >
> > > > > I see failing tests regarding to missing translations

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Vojtech Szocs 
(top-posting)

Hi,

root cause is wrong number of message parameters (placeholders)
in translated properties files, compared to message definitions
in Java code.

For example, UIMessages#cpuInfoLabel method has 4 parameters,
but the corresponding message in `UIMessages_de_DE.properties`
only contains 3 placeholders.

4.0 String Freeze is May 25 so it's still OK to modify message
definitions in Java code.

I suggest to simply revert the offending patch:

  translations update from zanata ovirt-3.6
  https://gerrit.ovirt.org/#/c/56720/

and create new one which doesn't introduce conflicts.

We have unit tests to detect these kinds of errors, this is
to ensure the build fails early on (before GWT compilation).

I'm not sure why `check-patch` job for above mentioned patch
didn't report the problem, since UIMessagesTest should fail,
as Roman wrote below.

Regards,
Vojtech


- Original Message -
> From: "Marek Libra" <mli...@redhat.com>
> To: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 12:31:18 PM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> There are issues on other keys as well.
> I'm rebuilding for all locales locally now.
> 
> 
> 
> 
> 
> From: "Marek Libra" <mli...@redhat.com>
> To: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 11:29:55 AM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> The fix is here: https://gerrit.ovirt.org/#/c/57007/
> 
> 
> 
> 
> From: "Roman Mohr" <rm...@redhat.com>
> To: "Oved Ourfali" <oourf...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 10:27:51 AM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> 
> 
> On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourf...@redhat.com > wrote:
> 
> 
> 
> Roman - did you build the langs in order to find the issue?
> 
> I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all
> of my builds showed that error.
> 
> Looking at
> 
> https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
> 
> two patches passed and two failed after a topic rebase.
> 
> 
> 
> Eyal - can we monitor a list of files that i changed will result in also
> building all the languages?
> 
> 
> 
> 
> 
> 
> On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < ee...@redhat.com > wrote:
> 
> 
> 
> right, and we can't enable lang permutation since it takes a very long time
> to run.
> 
> On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjeli...@redhat.com > wrote:
> 
> 
> 
> 
> - Original Message -
> > From: "Oved Ourfali" < oourf...@redhat.com >
> > To: "Tomas Jelinek" < tjeli...@redhat.com >
> > Cc: "Roman Mohr" < rm...@redhat.com >, "devel" < devel@ovirt.org >, "Scott
> > Dickerson" < sdick...@redhat.com >
> > Sent: Wednesday, May 4, 2016 9:55:40 AM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > 
> > I wonder, how come the CI didn't catch that?
> 
> because this happens only when you compile with language permutations
> 
> > 
> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjeli...@redhat.com >
> > wrote:
> > 
> > > hmmm,
> > > regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/
> > > fix on the way
> > > 
> > > - Original Message -
> > > > From: "Roman Mohr" < rm...@redhat.com >
> > > > To: "devel" < devel@ovirt.org >
> > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > > > Subject: [ovirt-devel] Master ovirt-engine build broken
> > > > 
> > > > Hi,
> > > > 
> > > > I see failing tests regarding to missing translations (e.g. [1]).
> > > > 
> > > > [...]
> > > > 
> > > > Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > > > cpuInfoLabel does not match the number of parameters in
> > > > UIMessages_zh_CN.properties(..)
> > > > 
> > > > [...]
> > > > 
> > > > Best Regards,
> > > > 
> > > > Roman
> > > > 
> > > > [1]
> > > > 
> > > http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
> > > > 
> > > > ___
> > > > Devel mailing list
> > > > Devel@ovirt.org
> > &g

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Eli Mesika 
Got it also, different error :

Failed tests:
  doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
unreachableGlusterHosts does not match the number of parameters in
UIMessages_pt_BR.properties


On Wed, May 4, 2016 at 1:31 PM, Marek Libra <mli...@redhat.com> wrote:

> There are issues on other keys as well.
> I'm rebuilding for all locales locally now.
>
>
> --
>
> *From: *"Marek Libra" <mli...@redhat.com>
> *To: *"devel" <devel@ovirt.org>
> *Sent: *Wednesday, May 4, 2016 11:29:55 AM
>
> *Subject: *Re: [ovirt-devel] Master ovirt-engine build broken
>
> The fix is here: https://gerrit.ovirt.org/#/c/57007/
>
> --
>
> *From: *"Roman Mohr" <rm...@redhat.com>
> *To: *"Oved Ourfali" <oourf...@redhat.com>
> *Cc: *"devel" <devel@ovirt.org>
> *Sent: *Wednesday, May 4, 2016 10:27:51 AM
> *Subject: *Re: [ovirt-devel] Master ovirt-engine build broken
>
>
>
> On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <oourf...@redhat.com> wrote:
>
>> Roman - did you build the langs in order to find the issue?
>>
>
> I just ran 'mvn clean  verify', so I saw it on my machine. On gerrit not
> all of my builds showed that error.
>
> Looking at
>
>
> https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
>
> two patches passed and two failed after  a topic rebase.
>
>
>> Eyal - can we monitor a list of files that i changed will result in also
>> building all the languages?
>>
>>
>>
>> On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <ee...@redhat.com> wrote:
>>
>>> right, and we can't enable lang permutation since it takes a very long
>>> time to run.
>>>
>>> On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjeli...@redhat.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> - Original Message -
>>>> > From: "Oved Ourfali" <oourf...@redhat.com>
>>>> > To: "Tomas Jelinek" <tjeli...@redhat.com>
>>>> > Cc: "Roman Mohr" <rm...@redhat.com>, "devel" <devel@ovirt.org>,
>>>> "Scott Dickerson" <sdick...@redhat.com>
>>>> > Sent: Wednesday, May 4, 2016 9:55:40 AM
>>>> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
>>>> >
>>>> > I wonder, how come the CI didn't catch that?
>>>>
>>>> because this happens only when you compile with language permutations
>>>>
>>>> >
>>>> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjeli...@redhat.com>
>>>> wrote:
>>>> >
>>>> > > hmmm,
>>>> > > regression introduced yesterday by
>>>> https://gerrit.ovirt.org/#/c/56720/
>>>> > > fix on the way
>>>> > >
>>>> > > - Original Message -
>>>> > > > From: "Roman Mohr" <rm...@redhat.com>
>>>> > > > To: "devel" <devel@ovirt.org>
>>>> > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
>>>> > > > Subject: [ovirt-devel] Master ovirt-engine build broken
>>>> > > >
>>>> > > > Hi,
>>>> > > >
>>>> > > > I see failing tests regarding to missing translations (e.g. [1]).
>>>> > > >
>>>> > > > [...]
>>>> > > >
>>>> > > > Failed tests:
>>>>  doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
>>>> > > > cpuInfoLabel does not match the number of parameters in
>>>> > > > UIMessages_zh_CN.properties(..)
>>>> > > >
>>>> > > > [...]
>>>> > > >
>>>> > > > Best Regards,
>>>> > > >
>>>> > > > Roman
>>>> > > >
>>>> > > > [1]
>>>> > > >
>>>> > >
>>>> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
>>>> > > >
>>>> > > > ___
>>>> > > > Devel mailing list
>>>> > > > Devel@ovirt.org
>>>> > > > http://lists.ovirt.org/mailman/listinfo/devel
>>>> > > ___
>>>> > > Devel mailing list
>>>> > > Devel@ovirt.org
>>>> > > http://lists.ovirt.org/mailman/listinfo/devel
>>>> > >
>>>> > >
>>>> > >
>>>> >
>>>> ___
>>>> Devel mailing list
>>>> Devel@ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Eyal Edri
>>> Associate Manager
>>> RHEV DevOps
>>> EMEA ENG Virtualization R
>>> Red Hat Israel
>>>
>>> phone: +972-9-7692018
>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>
>>
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Marek Libra 
There are issues on other keys as well. 
I'm rebuilding for all locales locally now. 

- Original Message -

> From: "Marek Libra" <mli...@redhat.com>
> To: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 11:29:55 AM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken

> The fix is here: https://gerrit.ovirt.org/#/c/57007/

> - Original Message -

> > From: "Roman Mohr" <rm...@redhat.com>
> 
> > To: "Oved Ourfali" <oourf...@redhat.com>
> 
> > Cc: "devel" <devel@ovirt.org>
> 
> > Sent: Wednesday, May 4, 2016 10:27:51 AM
> 
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 

> > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourf...@redhat.com >
> > wrote:
> 

> > > Roman - did you build the langs in order to find the issue?
> > 
> 

> > I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all
> > of my builds showed that error.
> 

> > Looking at
> 

> > https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration
> 

> > two patches passed and two failed after a topic rebase.
> 

> > > Eyal - can we monitor a list of files that i changed will result in also
> > > building all the languages?
> > 
> 

> > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < ee...@redhat.com > wrote:
> > 
> 

> > > > right, and we can't enable lang permutation since it takes a very long
> > > > time
> > > > to run.
> > > 
> > 
> 

> > > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjeli...@redhat.com >
> > > > wrote:
> > > 
> > 
> 

> > > > > - Original Message -
> > > > 
> > > 
> > 
> 
> > > > > > From: "Oved Ourfali" < oourf...@redhat.com >
> > > > 
> > > 
> > 
> 
> > > > > > To: "Tomas Jelinek" < tjeli...@redhat.com >
> > > > 
> > > 
> > 
> 
> > > > > > Cc: "Roman Mohr" < rm...@redhat.com >, "devel" < devel@ovirt.org >,
> > > > > > "Scott
> > > > > > Dickerson" < sdick...@redhat.com >
> > > > 
> > > 
> > 
> 
> > > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM
> > > > 
> > > 
> > 
> 
> > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > > 
> > > 
> > 
> 
> > > > > >
> > > > 
> > > 
> > 
> 
> > > > > > I wonder, how come the CI didn't catch that?
> > > > 
> > > 
> > 
> 

> > > > > because this happens only when you compile with language permutations
> > > > 
> > > 
> > 
> 

> > > > > >
> > > > 
> > > 
> > 
> 
> > > > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <
> > > > > > tjeli...@redhat.com
> > > > > > >
> > > > > > wrote:
> > > > 
> > > 
> > 
> 
> > > > > >
> > > > 
> > > 
> > 
> 
> > > > > > > hmmm,
> > > > 
> > > 
> > 
> 
> > > > > > > regression introduced yesterday by
> > > > > > > https://gerrit.ovirt.org/#/c/56720/
> > > > 
> > > 
> > 
> 
> > > > > > > fix on the way
> > > > 
> > > 
> > 
> 
> > > > > > >
> > > > 
> > > 
> > 
> 
> > > > > > > - Original Message -
> > > > 
> > > 
> > 
> 
> > > > > > > > From: "Roman Mohr" < rm...@redhat.com >
> > > > 
> > > 
> > 
> 
> > > > > > > > To: "devel" < devel@ovirt.org >
> > > > 
> > > 
> > 
> 
> > > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > > > 
> > > 
> > 
> 
> > > > > > > > Subject: [ovirt-devel] Master ovirt-engine build broken
> > > > 
> > > 
> > 
> 
> > > > > > > >
> > > > 
> > > 
> > 
> 
> > > >

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Marek Libra 
The fix is here: https://gerrit.ovirt.org/#/c/57007/ 

- Original Message -

> From: "Roman Mohr" <rm...@redhat.com>
> To: "Oved Ourfali" <oourf...@redhat.com>
> Cc: "devel" <devel@ovirt.org>
> Sent: Wednesday, May 4, 2016 10:27:51 AM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken

> On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < oourf...@redhat.com > wrote:

> > Roman - did you build the langs in order to find the issue?
> 

> I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all
> of my builds showed that error.

> Looking at

> https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration

> two patches passed and two failed after a topic rebase.

> > Eyal - can we monitor a list of files that i changed will result in also
> > building all the languages?
> 

> > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < ee...@redhat.com > wrote:
> 

> > > right, and we can't enable lang permutation since it takes a very long
> > > time
> > > to run.
> > 
> 

> > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < tjeli...@redhat.com >
> > > wrote:
> > 
> 

> > > > - Original Message -
> > > 
> > 
> 
> > > > > From: "Oved Ourfali" < oourf...@redhat.com >
> > > 
> > 
> 
> > > > > To: "Tomas Jelinek" < tjeli...@redhat.com >
> > > 
> > 
> 
> > > > > Cc: "Roman Mohr" < rm...@redhat.com >, "devel" < devel@ovirt.org >,
> > > > > "Scott
> > > > > Dickerson" < sdick...@redhat.com >
> > > 
> > 
> 
> > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM
> > > 
> > 
> 
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> > > 
> > 
> 
> > > > >
> > > 
> > 
> 
> > > > > I wonder, how come the CI didn't catch that?
> > > 
> > 
> 

> > > > because this happens only when you compile with language permutations
> > > 
> > 
> 

> > > > >
> > > 
> > 
> 
> > > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < tjeli...@redhat.com
> > > > > >
> > > > > wrote:
> > > 
> > 
> 
> > > > >
> > > 
> > 
> 
> > > > > > hmmm,
> > > 
> > 
> 
> > > > > > regression introduced yesterday by
> > > > > > https://gerrit.ovirt.org/#/c/56720/
> > > 
> > 
> 
> > > > > > fix on the way
> > > 
> > 
> 
> > > > > >
> > > 
> > 
> 
> > > > > > - Original Message -
> > > 
> > 
> 
> > > > > > > From: "Roman Mohr" < rm...@redhat.com >
> > > 
> > 
> 
> > > > > > > To: "devel" < devel@ovirt.org >
> > > 
> > 
> 
> > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > > 
> > 
> 
> > > > > > > Subject: [ovirt-devel] Master ovirt-engine build broken
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > > > > Hi,
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > > > > I see failing tests regarding to missing translations (e.g. [1]).
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > > > > [...]
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > > > > Failed tests:
> > > > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > > 
> > 
> 
> > > > > > > cpuInfoLabel does not match the number of parameters in
> > > 
> > 
> 
> > > > > > > UIMessages_zh_CN.properties(..)
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > > > > [...]
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > > > > Best Regards,
> > > 
> > 
> 
> > > > > > >
> > > 
> > 
> 
> > > > >

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Oved Ourfali 
Roman - did you build the langs in order to find the issue?
Eyal - can we monitor a list of files that i changed will result in also
building all the languages?


On Wed, May 4, 2016 at 11:22 AM, Eyal Edri <ee...@redhat.com> wrote:

> right, and we can't enable lang permutation since it takes a very long
> time to run.
>
> On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjeli...@redhat.com>
> wrote:
>
>>
>>
>> - Original Message -
>> > From: "Oved Ourfali" <oourf...@redhat.com>
>> > To: "Tomas Jelinek" <tjeli...@redhat.com>
>> > Cc: "Roman Mohr" <rm...@redhat.com>, "devel" <devel@ovirt.org>, "Scott
>> Dickerson" <sdick...@redhat.com>
>> > Sent: Wednesday, May 4, 2016 9:55:40 AM
>> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
>> >
>> > I wonder, how come the CI didn't catch that?
>>
>> because this happens only when you compile with language permutations
>>
>> >
>> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjeli...@redhat.com>
>> wrote:
>> >
>> > > hmmm,
>> > > regression introduced yesterday by
>> https://gerrit.ovirt.org/#/c/56720/
>> > > fix on the way
>> > >
>> > > - Original Message -
>> > > > From: "Roman Mohr" <rm...@redhat.com>
>> > > > To: "devel" <devel@ovirt.org>
>> > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
>> > > > Subject: [ovirt-devel] Master ovirt-engine build broken
>> > > >
>> > > > Hi,
>> > > >
>> > > > I see failing tests regarding to missing translations (e.g. [1]).
>> > > >
>> > > > [...]
>> > > >
>> > > > Failed tests:   doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
>> > > > cpuInfoLabel does not match the number of parameters in
>> > > > UIMessages_zh_CN.properties(..)
>> > > >
>> > > > [...]
>> > > >
>> > > > Best Regards,
>> > > >
>> > > > Roman
>> > > >
>> > > > [1]
>> > > >
>> > >
>> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
>> > > >
>> > > > ___
>> > > > Devel mailing list
>> > > > Devel@ovirt.org
>> > > > http://lists.ovirt.org/mailman/listinfo/devel
>> > > ___
>> > > Devel mailing list
>> > > Devel@ovirt.org
>> > > http://lists.ovirt.org/mailman/listinfo/devel
>> > >
>> > >
>> > >
>> >
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHEV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Roman Mohr 
On Wed, May 4, 2016 at 9:44 AM, Tomas Jelinek  wrote:

> hmmm,
> regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/
> fix on the way
>
> Thx


> - Original Message -
> > From: "Roman Mohr" 
> > To: "devel" 
> > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > Subject: [ovirt-devel] Master ovirt-engine build broken
> >
> > Hi,
> >
> > I see failing tests regarding to missing translations (e.g. [1]).
> >
> > [...]
> >
> > Failed tests:   doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > cpuInfoLabel does not match the number of parameters in
> > UIMessages_zh_CN.properties(..)
> >
> > [...]
> >
> > Best Regards,
> >
> > Roman
> >
> > [1]
> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Eyal Edri 
right, and we can't enable lang permutation since it takes a very long time
to run.

On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <tjeli...@redhat.com> wrote:

>
>
> - Original Message -
> > From: "Oved Ourfali" <oourf...@redhat.com>
> > To: "Tomas Jelinek" <tjeli...@redhat.com>
> > Cc: "Roman Mohr" <rm...@redhat.com>, "devel" <devel@ovirt.org>, "Scott
> Dickerson" <sdick...@redhat.com>
> > Sent: Wednesday, May 4, 2016 9:55:40 AM
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> >
> > I wonder, how come the CI didn't catch that?
>
> because this happens only when you compile with language permutations
>
> >
> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjeli...@redhat.com>
> wrote:
> >
> > > hmmm,
> > > regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/
> > > fix on the way
> > >
> > > - Original Message -
> > > > From: "Roman Mohr" <rm...@redhat.com>
> > > > To: "devel" <devel@ovirt.org>
> > > > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > > > Subject: [ovirt-devel] Master ovirt-engine build broken
> > > >
> > > > Hi,
> > > >
> > > > I see failing tests regarding to missing translations (e.g. [1]).
> > > >
> > > > [...]
> > > >
> > > > Failed tests:   doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > > > cpuInfoLabel does not match the number of parameters in
> > > > UIMessages_zh_CN.properties(..)
> > > >
> > > > [...]
> > > >
> > > > Best Regards,
> > > >
> > > > Roman
> > > >
> > > > [1]
> > > >
> > >
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
> > > >
> > > > ___
> > > > Devel mailing list
> > > > Devel@ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/devel
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > >
> > >
> > >
> >
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>


-- 
Eyal Edri
Associate Manager
RHEV DevOps
EMEA ENG Virtualization R
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Tomas Jelinek 


- Original Message -
> From: "Oved Ourfali" <oourf...@redhat.com>
> To: "Tomas Jelinek" <tjeli...@redhat.com>
> Cc: "Roman Mohr" <rm...@redhat.com>, "devel" <devel@ovirt.org>, "Scott 
> Dickerson" <sdick...@redhat.com>
> Sent: Wednesday, May 4, 2016 9:55:40 AM
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken
> 
> I wonder, how come the CI didn't catch that?

because this happens only when you compile with language permutations

> 
> On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <tjeli...@redhat.com> wrote:
> 
> > hmmm,
> > regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/
> > fix on the way
> >
> > - Original Message -
> > > From: "Roman Mohr" <rm...@redhat.com>
> > > To: "devel" <devel@ovirt.org>
> > > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > > Subject: [ovirt-devel] Master ovirt-engine build broken
> > >
> > > Hi,
> > >
> > > I see failing tests regarding to missing translations (e.g. [1]).
> > >
> > > [...]
> > >
> > > Failed tests:   doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > > cpuInfoLabel does not match the number of parameters in
> > > UIMessages_zh_CN.properties(..)
> > >
> > > [...]
> > >
> > > Best Regards,
> > >
> > > Roman
> > >
> > > [1]
> > >
> > http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
> > >
> > > ___
> > > Devel mailing list
> > > Devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/devel
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> >
> >
> >
> 
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Oved Ourfali 
I wonder, how come the CI didn't catch that?

On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek  wrote:

> hmmm,
> regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/
> fix on the way
>
> - Original Message -
> > From: "Roman Mohr" 
> > To: "devel" 
> > Sent: Wednesday, May 4, 2016 9:34:53 AM
> > Subject: [ovirt-devel] Master ovirt-engine build broken
> >
> > Hi,
> >
> > I see failing tests regarding to missing translations (e.g. [1]).
> >
> > [...]
> >
> > Failed tests:   doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> > cpuInfoLabel does not match the number of parameters in
> > UIMessages_zh_CN.properties(..)
> >
> > [...]
> >
> > Best Regards,
> >
> > Roman
> >
> > [1]
> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
> >
> > ___
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] Master ovirt-engine build broken

2016-05-04 Thread Tomas Jelinek 
hmmm, 
regression introduced yesterday by https://gerrit.ovirt.org/#/c/56720/ 
fix on the way

- Original Message -
> From: "Roman Mohr" 
> To: "devel" 
> Sent: Wednesday, May 4, 2016 9:34:53 AM
> Subject: [ovirt-devel] Master ovirt-engine build broken
> 
> Hi,
> 
> I see failing tests regarding to missing translations (e.g. [1]).
> 
> [...]
> 
> Failed tests:   doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):
> cpuInfoLabel does not match the number of parameters in
> UIMessages_zh_CN.properties(..)
> 
> [...]
> 
> Best Regards,
> 
> Roman
> 
> [1]
> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console
> 
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel