Re: [riot-devel] 35C3 CfP

[Martine Lenders]

Hi,

to everyone interested FYI: The presale dates are set:
https://events.ccc.de/2018/10/10/35c3-tickets-presale/

Regards,
Martine

Am Mo., 24. Sep. 2018 um 15:51 Uhr schrieb Simon Brummer <
simon.brum...@posteo.de>:

> Hi Martine,
>
> I would like to be part of a RIOT assembly. ;)
>
> Cheers Simon
>
> Am 2018-09-19 18:04 schrieb Martine Lenders:
> > Hi,
> >
> > FYI, the CfP for 35C3 is out [1] since last week.
> >
> > My current plan is to represent the RIOT community there with an
> > high-level introductory talk on ICN within the Science track there.
> >
> > As every year: If we get enough people together, I would like to start
> > a RIOT assembly.
> >
> > Kind regards,
> > Martine
> >
> > [1]
> >
> https://events.ccc.de/2018/09/11/35c3-call-for-participation-and-submission-guidelines/
> >
> > ___
> > devel mailing list
> > devel@riot-os.org
> > https://lists.riot-os.org/mailman/listinfo/devel
> ___
> devel mailing list
> devel@riot-os.org
> https://lists.riot-os.org/mailman/listinfo/devel
>
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

Re: [riot-devel] Lifting the 50 characters commit first line limit?

[Nikander Pekka]

Hi Martin,

https://github.com/RIOT-OS/RIOT/pull/10142

--Pekka

On 10.10.2018, at 13:24, Martine Lenders  wrote:

Hi Pekka,

feel free to change the check script [1] to whatever is most comfortable to you 
:-) (sorry today I'm very busy so I can't do it myself; but I'm happy to review 
it once ready).

Regards,
Martine

[1] https://github.com/RIOT-OS/RIOT/blob/master/dist/tools/commit-msg/check.sh

Am Mi., 10. Okt. 2018 um 12:14 Uhr schrieb Nikander Pekka 
mailto:pekka.nikan...@aalto.fi>>:
Thanks Martine and all!

My memory is bad.  Now that I saw your answer, Martine, I remembered that I 
have asked about this before, in some other forum, and have got the same 
answer.  But I didn't remember it.

That is, Travis tricked me again.

If possible, it would be very nice if Travis (and make static-test) was changed 
so that I won't get tricked again and won't again start doing work which is not 
needed.

In more precise terms, could the string

  Commit message is longer than 50 characters:

be changed to

 Warning: Commit message is longer than 50 characters (but still < 70 
characters):

Had there been at least that one more word, "Warning:", this whole noise would 
not have taken place.

--Pekka

On 10.10.2018, at 12:50, Ken Bannister 
mailto:kb...@runbox.com>> wrote:


Martine and I discussed this over a PR a few months ago. The outcome was to 
update the Good Pull Request wiki page [1], which basically says what has just 
been discussed on this thread. Good to spread the word and share the link. :-)

Ken

[1] 
https://github.com/RIOT-OS/RIOT/wiki/Guidelines-for-Creating-a-Good-Pull-Request

On 10/10/2018 03:31 AM, Joakim Nohlgård wrote:
+1 what Martine wrote.

(I was composing a similar message when you beat me to it)
/Joakim

Den ons 10 okt. 2018 08:51Martine Lenders 
mailto:m...@martine-lenders.eu>> skrev:
Hi Pekka,

the 50 chars is just the warning bound. You can go up to 70 until the commit 
message check fails on you. Longer will make GitHub break the commit message in 
the webview with the dreaded […] ;-).

My usual approach is to boil down the summary to the bare minimum within these 
constraints (even using just the module name instead of the full path) and go 
into details in the following lines of the commit message.

Regards,
Martine

Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka 
mailto:pekka.nikan...@aalto.fi>>:
[Refactoring the nRF520 mega-PR to follow the standards...]

I guess this has been bashed to death, but I am annoyed.

With long paths, the 50 characters limit on the first line
of the commit message makes it impossible to have any meaningful
explanation of what the commit actually does.  Actually,
the limitation makes the commit messages unintelligible.

_Any_ change of increasing the limit to e.g. 72 characters?

--Pekka

___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel



___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel


___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

Re: [riot-devel] Lifting the 50 characters commit first line limit?

[Martine Lenders]

Hi Pekka,

feel free to change the check script [1] to whatever is most comfortable to
you :-) (sorry today I'm very busy so I can't do it myself; but I'm happy
to review it once ready).

Regards,
Martine

[1]
https://github.com/RIOT-OS/RIOT/blob/master/dist/tools/commit-msg/check.sh

Am Mi., 10. Okt. 2018 um 12:14 Uhr schrieb Nikander Pekka <
pekka.nikan...@aalto.fi>:

> Thanks Martine and all!
>
> My memory is bad.  Now that I saw your answer, Martine, I remembered that
> I have asked about this before, in some other forum, and have got the same
> answer.  But I didn't remember it.
>
> That is, Travis tricked me again.
>
> If possible, it would be very nice if Travis (and make static-test) was
> changed so that I won't get tricked again and won't again start doing work
> which is not needed.
>
> In more precise terms, could the string
>
>   Commit message is longer than 50 characters:
>
> be changed to
>
>  Warning: Commit message is longer than 50 characters (but still < 70
> characters):
>
> Had there been at least that one more word, "Warning:", this whole noise
> would not have taken place.
>
> --Pekka
>
> On 10.10.2018, at 12:50, Ken Bannister  wrote:
>
> Martine and I discussed this over a PR a few months ago. The outcome was
> to update the Good Pull Request wiki page [1], which basically says what
> has just been discussed on this thread. Good to spread the word and share
> the link. :-)
>
> Ken
>
> [1]
> https://github.com/RIOT-OS/RIOT/wiki/Guidelines-for-Creating-a-Good-Pull-Request
>
> On 10/10/2018 03:31 AM, Joakim Nohlgård wrote:
>
> +1 what Martine wrote.
>
> (I was composing a similar message when you beat me to it)
> /Joakim
>
> Den ons 10 okt. 2018 08:51Martine Lenders  skrev:
>
>> Hi Pekka,
>>
>> the 50 chars is just the warning bound. You can go up to 70 until the
>> commit message check fails on you. Longer will make GitHub break the commit
>> message in the webview with the dreaded […] ;-).
>>
>> My usual approach is to boil down the summary to the bare minimum within
>> these constraints (even using just the module name instead of the full
>> path) and go into details in the following lines of the commit message.
>>
>> Regards,
>> Martine
>>
>> Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka <
>> pekka.nikan...@aalto.fi>:
>>
>>> [Refactoring the nRF520 mega-PR to follow the standards...]
>>>
>>> I guess this has been bashed to death, but I am annoyed.
>>>
>>> With long paths, the 50 characters limit on the first line
>>> of the commit message makes it impossible to have any meaningful
>>> explanation of what the commit actually does.  Actually,
>>> the limitation makes the commit messages unintelligible.
>>>
>>> _Any_ change of increasing the limit to e.g. 72 characters?
>>>
>>> --Pekka
>>>
>>> ___
>>> devel mailing list
>>> devel@riot-os.org
>>> https://lists.riot-os.org/mailman/listinfo/devel
>>>
>> ___
>> devel mailing list
>> devel@riot-os.org
>> https://lists.riot-os.org/mailman/listinfo/devel
>>
>
>
> ___
> devel mailing 
> listdevel@riot-os.orghttps://lists.riot-os.org/mailman/listinfo/devel
>
>
> ___
> devel mailing list
> devel@riot-os.org
> https://lists.riot-os.org/mailman/listinfo/devel
>
>
> ___
> devel mailing list
> devel@riot-os.org
> https://lists.riot-os.org/mailman/listinfo/devel
>
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

Re: [riot-devel] Lifting the 50 characters commit first line limit?

[Nikander Pekka]

Thanks Martine and all!

My memory is bad.  Now that I saw your answer, Martine, I remembered that I 
have asked about this before, in some other forum, and have got the same 
answer.  But I didn't remember it.

That is, Travis tricked me again.

If possible, it would be very nice if Travis (and make static-test) was changed 
so that I won't get tricked again and won't again start doing work which is not 
needed.

In more precise terms, could the string

  Commit message is longer than 50 characters:

be changed to

 Warning: Commit message is longer than 50 characters (but still < 70 
characters):

Had there been at least that one more word, "Warning:", this whole noise would 
not have taken place.

--Pekka

On 10.10.2018, at 12:50, Ken Bannister 
mailto:kb...@runbox.com>> wrote:


Martine and I discussed this over a PR a few months ago. The outcome was to 
update the Good Pull Request wiki page [1], which basically says what has just 
been discussed on this thread. Good to spread the word and share the link. :-)

Ken

[1] 
https://github.com/RIOT-OS/RIOT/wiki/Guidelines-for-Creating-a-Good-Pull-Request

On 10/10/2018 03:31 AM, Joakim Nohlgård wrote:
+1 what Martine wrote.

(I was composing a similar message when you beat me to it)
/Joakim

Den ons 10 okt. 2018 08:51Martine Lenders 
mailto:m...@martine-lenders.eu>> skrev:
Hi Pekka,

the 50 chars is just the warning bound. You can go up to 70 until the commit 
message check fails on you. Longer will make GitHub break the commit message in 
the webview with the dreaded […] ;-).

My usual approach is to boil down the summary to the bare minimum within these 
constraints (even using just the module name instead of the full path) and go 
into details in the following lines of the commit message.

Regards,
Martine

Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka 
mailto:pekka.nikan...@aalto.fi>>:
[Refactoring the nRF520 mega-PR to follow the standards...]

I guess this has been bashed to death, but I am annoyed.

With long paths, the 50 characters limit on the first line
of the commit message makes it impossible to have any meaningful
explanation of what the commit actually does.  Actually,
the limitation makes the commit messages unintelligible.

_Any_ change of increasing the limit to e.g. 72 characters?

--Pekka

___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel



___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel


___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

Re: [riot-devel] Lifting the 50 characters commit first line limit?

[Ken Bannister]

Martine and I discussed this over a PR a few months ago. The outcome was 
to update the Good Pull Request wiki page [1], which basically says what 
has just been discussed on this thread. Good to spread the word and 
share the link. :-)


Ken

[1] 
https://github.com/RIOT-OS/RIOT/wiki/Guidelines-for-Creating-a-Good-Pull-Request



On 10/10/2018 03:31 AM, Joakim Nohlgård wrote:

+1 what Martine wrote.

(I was composing a similar message when you beat me to it)
/Joakim

Den ons 10 okt. 2018 08:51Martine Lenders > skrev:


Hi Pekka,

the 50 chars is just the warning bound. You can go up to 70 until
the commit message check fails on you. Longer will make GitHub
break the commit message in the webview with the dreaded […] ;-).

My usual approach is to boil down the summary to the bare minimum
within these constraints (even using just the module name instead
of the full path) and go into details in the following lines of
the commit message.

Regards,
Martine

Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka
mailto:pekka.nikan...@aalto.fi>>:

[Refactoring the nRF520 mega-PR to follow the standards...]

I guess this has been bashed to death, but I am annoyed.

With long paths, the 50 characters limit on the first line
of the commit message makes it impossible to have any meaningful
explanation of what the commit actually does.  Actually,
the limitation makes the commit messages unintelligible.

_Any_ change of increasing the limit to e.g. 72 characters?

--Pekka

___
devel mailing list
devel@riot-os.org 
https://lists.riot-os.org/mailman/listinfo/devel

___
devel mailing list
devel@riot-os.org 
https://lists.riot-os.org/mailman/listinfo/devel



___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel


___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

Re: [riot-devel] Lifting the 50 characters commit first line limit?

[Joakim Nohlgård]

+1 what Martine wrote.

(I was composing a similar message when you beat me to it)
/Joakim

Den ons 10 okt. 2018 08:51Martine Lenders  skrev:

> Hi Pekka,
>
> the 50 chars is just the warning bound. You can go up to 70 until the
> commit message check fails on you. Longer will make GitHub break the commit
> message in the webview with the dreaded […] ;-).
>
> My usual approach is to boil down the summary to the bare minimum within
> these constraints (even using just the module name instead of the full
> path) and go into details in the following lines of the commit message.
>
> Regards,
> Martine
>
> Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka <
> pekka.nikan...@aalto.fi>:
>
>> [Refactoring the nRF520 mega-PR to follow the standards...]
>>
>> I guess this has been bashed to death, but I am annoyed.
>>
>> With long paths, the 50 characters limit on the first line
>> of the commit message makes it impossible to have any meaningful
>> explanation of what the commit actually does.  Actually,
>> the limitation makes the commit messages unintelligible.
>>
>> _Any_ change of increasing the limit to e.g. 72 characters?
>>
>> --Pekka
>>
>> ___
>> devel mailing list
>> devel@riot-os.org
>> https://lists.riot-os.org/mailman/listinfo/devel
>>
> ___
> devel mailing list
> devel@riot-os.org
> https://lists.riot-os.org/mailman/listinfo/devel
>
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

Re: [riot-devel] Lifting the 50 characters commit first line limit?

[Martine Lenders]

Hi Pekka,

the 50 chars is just the warning bound. You can go up to 70 until the
commit message check fails on you. Longer will make GitHub break the commit
message in the webview with the dreaded […] ;-).

My usual approach is to boil down the summary to the bare minimum within
these constraints (even using just the module name instead of the full
path) and go into details in the following lines of the commit message.

Regards,
Martine

Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka <
pekka.nikan...@aalto.fi>:

> [Refactoring the nRF520 mega-PR to follow the standards...]
>
> I guess this has been bashed to death, but I am annoyed.
>
> With long paths, the 50 characters limit on the first line
> of the commit message makes it impossible to have any meaningful
> explanation of what the commit actually does.  Actually,
> the limitation makes the commit messages unintelligible.
>
> _Any_ change of increasing the limit to e.g. 72 characters?
>
> --Pekka
>
> ___
> devel mailing list
> devel@riot-os.org
> https://lists.riot-os.org/mailman/listinfo/devel
>
___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel

[riot-devel] Lifting the 50 characters commit first line limit?

[Nikander Pekka]

[Refactoring the nRF520 mega-PR to follow the standards...]

I guess this has been bashed to death, but I am annoyed.

With long paths, the 50 characters limit on the first line
of the commit message makes it impossible to have any meaningful
explanation of what the commit actually does.  Actually,
the limitation makes the commit messages unintelligible.

_Any_ change of increasing the limit to e.g. 72 characters?

--Pekka

___
devel mailing list
devel@riot-os.org
https://lists.riot-os.org/mailman/listinfo/devel