Re: AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 29/11/21 11:24 pm, Sebastian Huber wrote: > On 24/11/2021 10:57, gabriel.moy...@dlr.de wrote: >>> I am fine with this change being pushed to the 5 branch but I think it >>> needs to built with the tier 1 archs (i386, powerpc, arm). >> I could compile them for the BSPs of those archs. > Thanks. > >> Does it make sense to run some test in qemu? > Test results are always welcome. > I've run the following tests: - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. - sptimecounter01 doesn't print something since everything happens inside of boot_card(). How the result of this test is verified? >>> Re-run the test using rtems-test. >>> - sptimecounter01, 02, 03 and 04 are marked as pass on Xilinx_zynq_a9 and >>> psim >>> - sptimecounter02, 03 and 04 are marked as pass on pc686 >>> - sptimecounter01 is marked as invalid on pc686. This result is with and >>> without the patch set. I guess it is because nothing is printed >>> out. >>> Are there any other tests that can be interested to run? >>> If there isn't any other test to run, I would say that the patch set is >>> ready. >> After running the whole testsuite for pc686, xilinx_zynq_a9 and psim; there >> are no new failures introduced. > > For me this is fine, what do you think Chris? Sorry about the delay and being distracted .. a few deadlines. Yes this looks fine. I think Jan has commit access so if he could push this to the 5 branch it would be appreciated. Thanks Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 24/11/2021 10:57, gabriel.moy...@dlr.de wrote: I am fine with this change being pushed to the 5 branch but I think it needs to built with the tier 1 archs (i386, powerpc, arm). I could compile them for the BSPs of those archs. Thanks. Does it make sense to run some test in qemu? Test results are always welcome. I've run the following tests: - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. - sptimecounter01 doesn't print something since everything happens inside of boot_card(). How the result of this test is verified? Re-run the test using rtems-test. - sptimecounter01, 02, 03 and 04 are marked as pass on Xilinx_zynq_a9 and psim - sptimecounter02, 03 and 04 are marked as pass on pc686 - sptimecounter01 is marked as invalid on pc686. This result is with and without the patch set. I guess it is because nothing is printed out. Are there any other tests that can be interested to run? If there isn't any other test to run, I would say that the patch set is ready. After running the whole testsuite for pc686, xilinx_zynq_a9 and psim; there are no new failures introduced. For me this is fine, what do you think Chris? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
> > > >> I am fine with this change being pushed to the 5 branch but I think it > > > >> needs to built with the tier 1 archs (i386, powerpc, arm). > > > > > > > > I could compile them for the BSPs of those archs. > > > > > > Thanks. > > > > > > > Does it make sense to run some test in qemu? > > > > > > Test results are always welcome. > > > > > I've run the following tests: > > - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. > > - sptimecounter01 doesn't print something since everything happens inside > > of boot_card(). How the result of this test is verified? > > Re-run the test using rtems-test. > - sptimecounter01, 02, 03 and 04 are marked as pass on Xilinx_zynq_a9 and psim > - sptimecounter02, 03 and 04 are marked as pass on pc686 > - sptimecounter01 is marked as invalid on pc686. This result is with and > without the patch set. I guess it is because nothing is printed > out. > > > Are there any other tests that can be interested to run? > > If there isn't any other test to run, I would say that the patch set is ready. After running the whole testsuite for pc686, xilinx_zynq_a9 and psim; there are no new failures introduced. Results for pc686: Passed:561 Failed: 5 User Input: 6 Expected Fail: 0 Indeterminate: 0 Benchmark: 3 Timeout:13 Invalid: 6 Wrong Version: 0 Wrong Build: 0 Wrong Tools: 0 -- Total: 594 Failures: dl06.exe psx12.exe psxfenv01.exe spfatal30.exe tmcontext01.exe User Input: dl10.exe monitor.exe termios.exe top.exe capture.exe fileio.exe Benchmark: dhrystone.exe linpack.exe whetstone.exe Timeouts: dl05.exe psxintrcritical01.exe cdtest.exe cxx_iostream.exe spintrcritical06.exe spintrcritical07.exe spintrcritical11.exe spintrcritical12.exe spintrcritical13.exe spintrcritical14.exe spintrcritical15.exe spintrcritical18.exe spintrcritical24.exe Invalid: spfatal09.exe spfatal12.exe spinternalerror01.exe spstkalloc02.exe spstkalloc03.exe sptimecounter01.exe Results for psim: Passed:567 Failed: 0 User Input: 6 Expected Fail: 16 Indeterminate: 0 Benchmark: 3 Timeout: 1 Invalid: 0 Wrong Version: 0 Wrong Build: 0 Wrong Tools: 0 -- Total: 593 User Input: dl10.exe monitor.exe termios.exe top.exe capture.exe fileio.exe Expected Fail: fsimfsgeneric01.exe block11.exe rbheap01.exe termios01.exe ttest01.exe psx12.exe psxchroot01.exe psxfenv01.exe psximfs02.exe psxpipe01.exe spextensions01.exe spfatal31.exe spfifo02.exe spmountmgr01.exe spprivenv01.exe spstdthreads01.exe Benchmark: linpack.exe dhrystone.exe whetstone.exe Timeouts: fsrfsbitmap01.exe Results for xilinx_zynq_a9: Passed:572 Failed: 1 User Input: 6 Expected Fail: 2 Indeterminate: 0 Benchmark: 3 Timeout:10 Invalid: 0 Wrong Version: 0 Wrong Build: 0 Wrong Tools: 0 -- Total: 594 Failures: psx12.exe User Input: dl10.exe monitor.exe termios.exe top.exe capture.exe fileio.exe Expected Fail: dl06.exe psxfenv01.exe Benchmark: whetstone.exe linpack.exe dhrystone.exe Timeouts: psxintrcritical01.exe spintrcritical06.exe spintrcritical07.exe spintrcritical11.exe spintrcritical12.exe spintrcritical13.exe spintrcritical14.exe spintrcritical15.exe spintrcritical18.exe spintrcritical24.exe ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
> > >> I am fine with this change being pushed to the 5 branch but I think it > > >> needs to built with the tier 1 archs (i386, powerpc, arm). > > > > > > I could compile them for the BSPs of those archs. > > > > Thanks. > > > > > Does it make sense to run some test in qemu? > > > > Test results are always welcome. > > > I've run the following tests: > - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. > - sptimecounter01 doesn't print something since everything happens inside of > boot_card(). How the result of this test is verified? Re-run the test using rtems-test. - sptimecounter01, 02, 03 and 04 are marked as pass on Xilinx_zynq_a9 and psim - sptimecounter02, 03 and 04 are marked as pass on pc686 - sptimecounter01 is marked as invalid on pc686. This result is with and without the patch set. I guess it is because nothing is printed out. > Are there any other tests that can be interested to run? If there isn't any other test to run, I would say that the patch set is ready. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
> >> I am fine with this change being pushed to the 5 branch but I think it > >> needs to built with the tier 1 archs (i386, powerpc, arm). > > > > I could compile them for the BSPs of those archs. > > Thanks. > > > Does it make sense to run some test in qemu? > > Test results are always welcome. > I've run the following tests: - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. - sptimecounter01 doesn't print something since everything happens inside of boot_card(). How the result of this test is verified? Are there any other tests that can be interested to run? For ppc, what bsp and configuration can be used with qemu? (is there some example showing how to run qemu for ppc?) ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 19/11/21 9:32 pm, gabriel.moy...@dlr.de wrote: >> I am fine with this change being pushed to the 5 branch but I think it needs >> to built with the tier 1 archs (i386, powerpc, arm). > > I could compile them for the BSPs of those archs. Thanks. > Does it make sense to run some test in qemu? Test results are always welcome. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
> I am fine with this change being pushed to the 5 branch but I think it needs > to built with the tier 1 archs (i386, powerpc, arm). I could compile them for the BSPs of those archs. Does it make sense to run some test in qemu? > Once pushed I would appreciate an update to: > > https://git.rtems.org/rtems-release/tree/rtems-notes-5.md > > under "## RTEMS 5.2 Release Notes". > > Thanks > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 17/11/21 11:03 pm, Sebastian Huber wrote: > On 17/11/2021 11:42, gabriel.moy...@dlr.de wrote: >>> The patch set should have no API/ABI impact on applications. >> Sorry I didn't verified if the ABI is broken. We are checking this with my >> team. > > I think, the patch set should have no API/ABI impact on applications. The > changes are all in kern_tc.c. I am fine with this change being pushed to the 5 branch but I think it needs to built with the tier 1 archs (i386, powerpc, arm). Once pushed I would appreciate an update to: https://git.rtems.org/rtems-release/tree/rtems-notes-5.md under "## RTEMS 5.2 Release Notes". Thanks Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 17/11/2021 11:42, gabriel.moy...@dlr.de wrote: The patch set should have no API/ABI impact on applications. Sorry I didn't verified if the ABI is broken. We are checking this with my team. I think, the patch set should have no API/ABI impact on applications. The changes are all in kern_tc.c. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
Hi Sebastian, Thx for your quick answer. > > These commits port to rtems 5 the last changes in kern_tc and timecounter > > pushed by Sebastian Huber. > > Additionally the last commit closes the ticket 4549, which is a clone of > > 2348(NTP support) for rtems 5. > > From my point of view this patch set acceptable for RTEMS 5 provided you > tested it with at least one BSP and libbsd. Yes, I tested it using the bsp pc686 and since I'm working in including ptpd into rtems-libbsd, the handler ntp_update_second is set from libbsd. > The patch set should have no API/ABI impact on applications. Sorry I didn't verified if the ABI is broken. We are checking this with my team. Best regards, Gabriel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel