Re: AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 29/11/21 11:24 pm, Sebastian Huber wrote: > On 24/11/2021 10:57, gabriel.moy...@dlr.de wrote: >>> I am fine with this change being pushed to the 5 branch but I think it >>> needs to built with the tier 1 archs (i386, powerpc, arm). >> I could compile them for the BSPs of those archs. > Thanks. > >> Does it make sense to run some test in qemu? > Test results are always welcome. > I've run the following tests: - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. - sptimecounter01 doesn't print something since everything happens inside of boot_card(). How the result of this test is verified? >>> Re-run the test using rtems-test. >>> - sptimecounter01, 02, 03 and 04 are marked as pass on Xilinx_zynq_a9 and >>> psim >>> - sptimecounter02, 03 and 04 are marked as pass on pc686 >>> - sptimecounter01 is marked as invalid on pc686. This result is with and >>> without the patch set. I guess it is because nothing is printed >>> out. >>> Are there any other tests that can be interested to run? >>> If there isn't any other test to run, I would say that the patch set is >>> ready. >> After running the whole testsuite for pc686, xilinx_zynq_a9 and psim; there >> are no new failures introduced. > > For me this is fine, what do you think Chris? Sorry about the delay and being distracted .. a few deadlines. Yes this looks fine. I think Jan has commit access so if he could push this to the 5 branch it would be appreciated. Thanks Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: AW: AW: AW: [PATCH 00/27] Update kern_tc in rtems 5 for ntp support
On 24/11/2021 10:57, gabriel.moy...@dlr.de wrote: I am fine with this change being pushed to the 5 branch but I think it needs to built with the tier 1 archs (i386, powerpc, arm). I could compile them for the BSPs of those archs. Thanks. Does it make sense to run some test in qemu? Test results are always welcome. I've run the following tests: - sptimecounter02, 03 and 04 are pass on pc686 and Xilinx_zynq_a9. - sptimecounter01 doesn't print something since everything happens inside of boot_card(). How the result of this test is verified? Re-run the test using rtems-test. - sptimecounter01, 02, 03 and 04 are marked as pass on Xilinx_zynq_a9 and psim - sptimecounter02, 03 and 04 are marked as pass on pc686 - sptimecounter01 is marked as invalid on pc686. This result is with and without the patch set. I guess it is because nothing is printed out. Are there any other tests that can be interested to run? If there isn't any other test to run, I would say that the patch set is ready. After running the whole testsuite for pc686, xilinx_zynq_a9 and psim; there are no new failures introduced. For me this is fine, what do you think Chris? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
