function definition isn't a prototype

2004-04-02 Thread Terry R. Friedrichsen
From a March 31 CVS update, there are 2714 of the above warnings in a
make World when compiling under FreeBSD 5.2 on an Alpha.

With some guidance from the committers, I'd like to take on the task of
eliminating the vast majority of these.  I'll provide context diffs and
submit them to the bug tracker as time permits, but I'd like to know whe-
ther you feel that the declarations in question should be wrapped in some-
thing like #ifdef __STDC__ / #endif or not first.

(Or if you'd rather I didn't bother, I'll just shut up and go away :-).

Thanks.

Terry R. Friedrichsen

[EMAIL PROTECTED]
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: function definition isn't a prototype

2004-04-02 Thread Marc Aurele La France
On Fri, 2 Apr 2004, Terry R. Friedrichsen wrote:

 From a March 31 CVS update, there are 2714 of the above warnings in a

 make World when compiling under FreeBSD 5.2 on an Alpha.

 With some guidance from the committers, I'd like to take on the task of
 eliminating the vast majority of these.  I'll provide context diffs and
 submit them to the bug tracker as time permits, but I'd like to know whe-
 ther you feel that the declarations in question should be wrapped in some-
 thing like #ifdef __STDC__ / #endif or not first.

No, please don't wrap them.  Support for pre-ANSIC compilers is pretty much
dead now.

 (Or if you'd rather I didn't bother, I'll just shut up and go away :-).

Please wait a bit, as I still have a few such things to integrate.  Also, I'd
prefer you sent them to me directly.

Thanks.

Marc.

+--+---+
|  Marc Aurele La France   |  work:   1-780-492-9310   |
|  Computing and Network Services  |  fax:1-780-492-1729   |
|  352 General Services Building   |  email:  [EMAIL PROTECTED]  |
|  University of Alberta   +---+
|  Edmonton, Alberta   |   |
|  T6G 2H1 | Standard disclaimers apply|
|  CANADA  |   |
+--+---+
XFree86 developer and VP.  ATI driver and X server internals.


___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: function definition isn't a prototype

2004-04-02 Thread Dr Andrew C Aitchison
On Fri, 2 Apr 2004, Terry R. Friedrichsen wrote:

 From a March 31 CVS update, there are 2714 of the above warnings in a
 make World when compiling under FreeBSD 5.2 on an Alpha.
 
 With some guidance from the committers, I'd like to take on the task of
 eliminating the vast majority of these.  I'll provide context diffs and
 submit them to the bug tracker as time permits, but I'd like to know whe-
 ther you feel that the declarations in question should be wrapped in some-
 thing like #ifdef __STDC__ / #endif or not first.

I'm not a committer, just someone who has been around long enough to 
remember the discussions about ansifying the code.

I don't think we need #ifdef __STDC__ or similar.

The ansification work is progressing very slowly because we need to be 
sure that we don't change the types of any arguements when we do this -
remember that the default type promotions rules changed between KR and 
ANSI C.
This means that the could be binary incompatibilities in the interfaces
we we do this with a dummy script, rather than a thinking brain.

Thomas Dickey has done bits in the past, and has email suggestions about 
how to verify that binary compatibility isn't broken.

Thanks for offering to help.

-- 
Dr. Andrew C. Aitchison Computer Officer, DPMMS, Cambridge
[EMAIL PROTECTED]   http://www.dpmms.cam.ac.uk/~werdna

___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: function definition isn't a prototype

2004-04-02 Thread Thomas Dickey
On Fri, 2 Apr 2004, Terry R. Friedrichsen wrote:

 From a March 31 CVS update, there are 2714 of the above warnings in a
 make World when compiling under FreeBSD 5.2 on an Alpha.

 With some guidance from the committers, I'd like to take on the task of
 eliminating the vast majority of these.  I'll provide context diffs and
 submit them to the bug tracker as time permits, but I'd like to know whe-
 ther you feel that the declarations in question should be wrapped in some-
 thing like #ifdef __STDC__ / #endif or not first.

See

http://invisible-island.net/ansification/

for example.

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: function definition isn't a prototype

2004-04-02 Thread Thomas Dickey
On Fri, 2 Apr 2004, Dr Andrew C Aitchison wrote:

 On Fri, 2 Apr 2004, Terry R. Friedrichsen wrote:

  From a March 31 CVS update, there are 2714 of the above warnings in a
  make World when compiling under FreeBSD 5.2 on an Alpha.
 
  With some guidance from the committers, I'd like to take on the task of
  eliminating the vast majority of these.  I'll provide context diffs and
  submit them to the bug tracker as time permits, but I'd like to know whe-
  ther you feel that the declarations in question should be wrapped in some-
  thing like #ifdef __STDC__ / #endif or not first.

 I'm not a committer, just someone who has been around long enough to
 remember the discussions about ansifying the code.

 I don't think we need #ifdef __STDC__ or similar.

right - what we need are changes that preserve the interfaces (don't
change types/sizes) but eliminate the nonstandard syntax.  It's
time-consuming.

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel