[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-13 Thread Prakash Surya 
Merged #539.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/539#event-1472048156
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T603f896faeeb4d25-Mb889d453aaff8417d018691f
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-12 Thread Pavel Zakharov 
pzakha commented on this pull request.



> @@ -461,6 +461,16 @@ kernel_fini(void)
system_taskq_fini();
 }
 
+/* ARGSUSED */
+uint32_t
+zone_get_hostid(void *zonep)

After further investigation I'd propose to keep this in `libzpool` as the 
generic `libfakekernel` implementation should probably just be calling 
`gethostid()`. I'll add a comment in `zone_get_hostid()` to explain this 
special behaviour. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/539#discussion_r167639415
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T603f896faeeb4d25-Mfff1a50084e79626569abdbb
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-12 Thread Pavel Zakharov 
pzakha commented on this pull request.



> @@ -461,6 +461,16 @@ kernel_fini(void)
system_taskq_fini();
 }
 
+/* ARGSUSED */
+uint32_t
+zone_get_hostid(void *zonep)

I'll need to look into it. It seems like `zone_get_hostid()` has a behaviour 
specific to libzpool as the value returned will either be `0` or `gethostid()` 
depending on the mode passed in `kernel_ini()` (see initialization of 
`hw_serial`). This might not be what we want for all users of libfakekernel.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/539#discussion_r167605634
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T603f896faeeb4d25-Me665b69855cad3830e663b8b
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-10 Thread Andrew Stormont 
andy-js commented on this pull request.

Overall looks good.

> +#
+# We want to test the case where a whole created by a log device is filled
+# by a regular device
+#
+function test_remove_log_then_add_vdev
+{
+   log_note "$0."
+   log_must zpool create -o cachefile=$CPATH $TESTPOOL1 \
+   $VDEV0 $VDEV1 $VDEV2 log $VDEV3
+
+   log_must cp $CPATH $CPATHBKP
+
+   log_must zpool remove $TESTPOOL1 $VDEV1
+   log_must wait_for_pool_config $TESTPOOL1 "$VDEV0 $VDEV2 log $VDEV3"
+   log_must zpool remove $TESTPOOL1 $VDEV3
+log_must check_pool_config $TESTPOOL1 "$VDEV0 $VDEV2"

The indentation looks wonky here.

> @@ -461,6 +461,16 @@ kernel_fini(void)
system_taskq_fini();
 }
 
+/* ARGSUSED */
+uint32_t
+zone_get_hostid(void *zonep)

I think this probably belongs in libfakekernel.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/539#pullrequestreview-95153387
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T603f896faeeb4d25-Mf1cc508ea5824637283cc241
Powered by Topicbox: https://topicbox.com