Re: [Development] Q_OBJECT and override
On Thursday, June 04, 2015 16:01:01 Aleix Pol wrote: Is it really that much work? I hear there's tools to do so [1] and it's the compiler telling whether it's correct or not. Aleix I've added Q_DECL_OVERRIDE to some kdepim libraries with clang-modernize and 5 minutes of my time. I also tried it on qtbase but it didn't work though, it failed to find some Qt headers, looks like a bug in clang-modernize or the tool I used to build the compilation database (bear). Maybe someone else wants to give it a shot ? Regards, -- Sérgio Martins | sergio.mart...@kdab.com | Software Engineer Klarälvdalens Datakonsult AB, a KDAB Group company Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - The Qt Experts ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] New Qt5.5.0-RC snapshot available
Hi all, New snapshot for Qt5.5.0 RC available. Windows: http://download.qt.io/snapshots/qt/5.5/5.5.0-rc/2015-06-05_79/ Linux: http://download.qt.io/snapshots/qt/5.5/5.5.0-rc/2015-06-05_101/ Mac: http://download.qt.io/snapshots/qt/5.5/5.5.0-rc/2015-06-05_83/ Content is not the final RC one but should be really near so please inform me immediately if you find something broken which should block the release. We are trying to pur RC out this Thursday final Tue 23.6.2015 so please don't try to get any nice-to-have's in anymore. Maintainers: For the coming releases please make sure - All findings from header diff is fixed today - all known issues are listed in https://wiki.qt.io/Qt_5.5.0_Known_Issues - Change files are created found from https://wiki.qt.io/Change-files-in-Qt-5.5.0#Qt_5.5.0_Change_files * Missing: ** qtandroidextras: http://code.qt.io/cgit/qt/qtandroidextras.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtbase: http://code.qt.io/cgit/qt/qtbase.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtconnectivity: http://code.qt.io/cgit/qt/qtconnectivity.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtdoc: http://code.qt.io/cgit/qt/qtdoc.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtenginio: http://code.qt.io/cgit/qt/qtenginio.git/tree/dist/changes-1.1.2?h=1.1.2 ** qtgraphicaleffects: http://code.qt.io/cgit/qt/qtgraphicaleffects.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtlocation: http://code.qt.io/cgit/qt/qtlocation.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtmacextras: http://code.qt.io/cgit/qt/qtmacextras.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtmultimedia: http://code.qt.io/cgit/qt/qtmultimedia.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtquick1: http://code.qt.io/cgit/qt/qtquick1.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtscript: http://code.qt.io/cgit/qt/qtscript.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtsensors: http://code.qt.io/cgit/qt/qtsensors.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtserialport: http://code.qt.io/cgit/qt/qtserialport.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtsvg: http://code.qt.io/cgit/qt/qtsvg.git/tree/dist/changes-5.5.0?h=5.5.0 ** qttranslations: http://code.qt.io/cgit/qt/qttranslations.git/tree/dist/changes-5.5.0?h=5.5.0 ** qttools: http://code.qt.io/cgit/qt/qttools.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtwayland: http://code.qt.io/cgit/qt/qtwayland.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtwebchannel: http://code.qt.io/cgit/qt/qtwebchannel.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtwebengine: http://code.qt.io/cgit/qt/qtwebengine.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtwebkit-examples: http://code.qt.io/cgit/qt/qtwebkit-examples.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtx11extras: http://code.qt.io/cgit/qt/qtx11extras.git/tree/dist/changes-5.5.0?h=5.5.0 ** qtxmlpatterns: http://code.qt.io/cgit/qt/qtxmlpatterns.git/tree/dist/changes-5.5.0?h=5.5.0 br, Jani ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Some Qt3D feedback
Hello, Congrats to Paul, Sean and others working on getting this module in a releasable state for Qt 5.5! I have not reviewed the code, but I found some items to raise: 1) The include/Qt3DCore/Window file doesn't have a Q prefix. as every other header does. Should probably be Qt3DWindow. 2) A private header is included in a public header: include/Qt3DCore$ grep private/ *.h qaspectjobmanager.h:#include Qt3DCore/private/qt3dcore_global_p.h This is concerning - Don't we have a unit test preventing that? 3) The cmake unit tests don't pass. It is easily fixable, but does this mean that the cmake tests are not run for this module? That is concerning. Are unit tests run for this module in CI at all? 4) Private dependencies git grep -w -e QT --and -e private shows a bunch of content. Shouldn't they be added to QT_PRIVATE instead? 5) Qt3D namespace This is the first time that all classes in a library are in a namespace. Previously only enums (in various modules) and free functions (in QtConcurrent) have been put in namespaces. In QtConcurrent, the module name also appears in the header file, but that is not followed by Qt3D libraries. Given that Qt has never put classes in a namespace like this, is there something to be consistent about here? 6) QParameter is a very generic name I realise it is in a namespace, but still... Qt3DParamter might be better *and* more consistent. Similar applies to other classes. 7) Unneeded Q_DECLARE_METATYPE Using the macro for QObject derived types is not needed. I saw Q_DECLARE_METATYPE(Qt3D::QNode *) and similar for QParameter and then stopped searching. 8) Docs in headers. I saw one method documented in qparameter.h instead of in the cpp and I didn't look for more. Thanks, Steve. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.5.0 header diff: QtQuickWidgets.diff
On 06/06/15 10:04, development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of thiago.macie...@intel.com wrote: On Friday 05 June 2015 10:10:46 Frederik Gladhorn wrote: +#ifndef QT_NO_DRAGANDDROP +virtual void dragEnterEvent(QDragEnterEvent *); +virtual void dragMoveEvent(QDragMoveEvent *); +virtual void dragLeaveEvent(QDragLeaveEvent *); +virtual void dropEvent(QDropEvent *); +#endif + Is this a public libary? Yes. Are the above overrides or not? If they are overrides, add Q_DECL_OVERRIDE. The methods are overrides. The change looks good except for the missing Q_DECL_OVERRIDE. So far the drag events have been catched in the generic ::event() reimplementation, so nobody could have subclassed these methods in any meaningful way anyway. Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.5.0 header diff: QtSvg.diff
On Saturday 6. June 2015 10:04:09 Thiago Macieira wrote: On Friday 05 June 2015 10:10:44 Frederik Gladhorn wrote: No changes, good. We ought to stop revving the version number for libraries that did not update at all... Maybe there was no API, But if you look a git loog, you will see several commits that adds feature, fix bugs, or optimize QtSvg. -- Olivier Woboq - Qt services and support - http://woboq.com - http://code.woboq.org ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff
On 06/06/15 15:26, development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of thiago.macie...@intel.com wrote: On Saturday 06 June 2015 14:22:20 Giuseppe D'Angelo wrote: Il 06/06/2015 13:27, Thiago Macieira ha scritto: Then why do we need them in QSslSocket? Technically they are be needed there, indeed, but I didn't want to cause an API asymmetry with the other functions for ciphers, certificates and so on, that's all. The symmetry only existed because we added them to QSslSocket before QSslCertificate existed. I'd rather new API existed only in QSslConfiguration. That way, we don't need to duplicate in QSslSocket. In that case you should probably also deprecate the methods in QSslSocket. Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
