Re: [Development] CI problems
Awesome. Thanks, Tony (and others who worked to get this resolved quickly)! Yours, Tuukka From: Development on behalf of Tony Sarajärvi Date: Thursday, 18 May 2017 at 22.46 To: "development@qt-project.org" Subject: Re: [Development] CI problems (Apparently it was just my own inbox not being updated 😉) It now looks like we have a running CI again! I started Coin and everything seems to be running as normal. I’ll keep watching it for a while longer and then resume work in the morning. Thanks for your patience. -Tony From: Development [mailto:development-bounces+tony.sarajarvi=qt...@qt-project.org] On Behalf Of Tony Sarajärvi Sent: torstaina 18. toukokuuta 2017 20.17 To: development@qt-project.org Subject: [Development] CI problems Hi Seems my earlier 2 mails haven’t reached you. I hope this one does. We’ve suffered hardware malfunction today. Our CI environment began behaving oddly aprox 20 hours ago and early this morning we noticed that not everything was OK. To prevent data loss and further problems, we shut down the CI. It took a lot of time to narrow the problem down, and we still aren’t 100% sure where the problem is, but we have a good suspect currently. We have 24/7 teams on this issue trying to get everything fixed. Bear with us. We’ll be back as soon as possible. -Tony ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] CI problems
(Apparently it was just my own inbox not being updated 😉) It now looks like we have a running CI again! I started Coin and everything seems to be running as normal. I’ll keep watching it for a while longer and then resume work in the morning. Thanks for your patience. -Tony From: Development [mailto:development-bounces+tony.sarajarvi=qt...@qt-project.org] On Behalf Of Tony Sarajärvi Sent: torstaina 18. toukokuuta 2017 20.17 To: development@qt-project.org Subject: [Development] CI problems Hi Seems my earlier 2 mails haven’t reached you. I hope this one does. We’ve suffered hardware malfunction today. Our CI environment began behaving oddly aprox 20 hours ago and early this morning we noticed that not everything was OK. To prevent data loss and further problems, we shut down the CI. It took a lot of time to narrow the problem down, and we still aren’t 100% sure where the problem is, but we have a good suspect currently. We have 24/7 teams on this issue trying to get everything fixed. Bear with us. We’ll be back as soon as possible. -Tony ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] CI problems
Hi Seems my earlier 2 mails haven't reached you. I hope this one does. We've suffered hardware malfunction today. Our CI environment began behaving oddly aprox 20 hours ago and early this morning we noticed that not everything was OK. To prevent data loss and further problems, we shut down the CI. It took a lot of time to narrow the problem down, and we still aren't 100% sure where the problem is, but we have a good suspect currently. We have 24/7 teams on this issue trying to get everything fixed. Bear with us. We'll be back as soon as possible. -Tony ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] CI is down again
Update: Dell is investigating problems with the Compellent (our backend storage system). We're seeing huge latencies over our fiber optics there and the system can't be used atm. Their 24/7 crew is working on it as their P1. -Tony -- Update: We're unsure why we a going at crawling speed on some parts of our infra. We could be facing hardware issues since we have restarted almost everything we have. Investigations are ongoing, and I can't give an ETA currently as to when we come back online. We need to find the reason first. -Tony --- We seem to have hardware issues which are under investigation. We'll be back online as soon as possible. -Tony ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Introducing discussion about QStringFormatter
On Thursday, 18 May 2017 02:57:43 PDT Mårten Nordheim wrote:
> But to clarify, in your scenario
> "{}{}" % ("a", "b")
> would be "ab", correct?
That's what I would expect, yes.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Introducing discussion about QStringFormatter
On Thursday, 18 May 2017 02:39:36 PDT Mårten Nordheim wrote:
> > Please consider, in terms of Qt API design (ease of use, surprise factor,
> > etc.) just what the following should do:
> >
> > QStringFormatter("%1 is {1}").arg("foo").subs("bar")
>
> Hm, hadn't thought that far ahead, thanks. I guess that would be hard to
> guess without reading the docs. In this case a constructor parameter is
> the better choice for BC.
That's exactly my point: please think of what would be the least surprise.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Stepping down as QtDBus maintainer
On Thursday, 18 May 2017 03:01:08 PDT Sergio Martins wrote: > On 2017-05-17 17:19, Thiago Macieira wrote: > > Since I am unable to fulfill my duties as maintainer, I am stepping > > down and > > opening the way up for someone else. > > Hi Thiago, > > Do you have an overview on what's the current state of the module ? Just > so the next maintainer gets an idea of where to start. Currently, the ONE important thing that QtDBus needs is to solve that crash- on-exit bug. It's been P1 since the new threading model was released in 5.6.0. After that, the module could be declared Done. It doesn't need much update and works almost just fine. There may be a couple of other issues that need to be addressed relating to the threading model, but I haven't received any reports recently. The biggest problem is that QDBusConnectionManager is a thread that runs until application exit and it outlives QCoreApplication (that's why QDaemonThread exists). And this runs into a problem with Windows: whenever ExitProcess is called, before each DLL's static destructors are run, the threads simply disappear. So global destructors may try to lock mutexes that are held by threads that are no longer running and, thus, cause a deadlock. That is the source of the deadlock that we've been seeing on the CI. Aside from that, my (dropped) patches were meant to clean up QtDBus. There are a couple of poor design choices that I made in 2006 that are still present. But mostly, they were meant to first constrain libdbus-1 requirements to a few places, as opposed to how they permeate all of QDBusMessage. This is already done, though there is one regression I know of for a bug that was fixed after I started developing back in 5.4 and 5.5 days. Eventually, the goal was to drop the libdbus-1 requirement and implement the protocol entirely in Qt code. Andreas Hartmetz has a number of patches on top of mine that go in that direction. But I never reviewed his contributions because they depended on getting mine out and mine depended on that P1 being fixed. I also developed a file-descriptor passing functionality for QNativeSocketEngine but haven't upstreamed that yet. QtDBus would then use QNativeSocketEngine directly (not QLocalSocket) and Andreas's marshalling and demarshalling code. So, as you can see, everything goes back to the problems that happen at exit, during global destruction, because QDBusConnectionManager must outlive QCoreApplication. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Stepping down as QtDBus maintainer
On Thursday, 18 May 2017 03:58:19 PDT Frederik Gladhorn wrote: > Isn't that a bit premature? Maybe someone could use these as inspiration. > I'd like to see us (as in The Qt Project) be more flexible when it comes to > ownership of patches - maybe someone feels inspired to take over some of > the work that has been started and expand on it. They can always pick them up. I can un-abandon if they want to use the same reviews, or they can cherry-pick and re-submit. I did that for the qEnvironmentVariable change, for example. It was open for over 6 months because I was asked to let someone reuse the change. (I closed yesterday because no one was working on it) -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] CI is down again
Update: We're unsure why we a going at crawling speed on some parts of our infra. We could be facing hardware issues since we have restarted almost everything we have. Investigations are ongoing, and I can't give an ETA currently as to when we come back online. We need to find the reason first. -Tony --- We seem to have hardware issues which are under investigation. We'll be back online as soon as possible. -Tony ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Stepping down as QtDBus maintainer
Hello Thiago, Thanks a lot for all the great work on QtDBus! Cheers, Frederik On onsdag 17. mai 2017 09.19.13 CEST Thiago Macieira wrote: > With https://codereview.qt-project.org/194893 getting integrated, this > signals my inability to keep QtDBus working for 4 minor releases in a row > (5.6 through 5.9, inclusive). Obviously, the patch that this change > reverted is required and it is the only way I've supported QtDBus in the > last 1½ years, but we don't seem to be able to make it work. > > Since I am unable to fulfill my duties as maintainer, I am stepping down and > opening the way up for someone else. > > Good luck. > > I've just abandoned all my pending changes related to QtDBus. Isn't that a bit premature? Maybe someone could use these as inspiration. I'd like to see us (as in The Qt Project) be more flexible when it comes to ownership of patches - maybe someone feels inspired to take over some of the work that has been started and expand on it. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Stepping down as QtDBus maintainer
Hi Thiago, thanks for all the efforts you’ve been putting into it over the years. > On 17 May 2017, at 18:19, Thiago Macieira wrote: > > With https://codereview.qt-project.org/194893 getting integrated, this > signals > my inability to keep QtDBus working for 4 minor releases in a row (5.6 > through > 5.9, inclusive). Obviously, the patch that this change reverted is required > and it is the only way I've supported QtDBus in the last 1½ years, but we > don't seem to be able to make it work. This is more showing that a situation where we only have one person working on (and knowing) a module is not sustainable. The changes you did were clearly going into the right direction, and will need to be picked up in one way or another. > > Since I am unable to fulfill my duties as maintainer, I am stepping down and > opening the way up for someone else. I’m currently trying to find someone else who can step up and get to know the module. It would be great if you could help that person get up to speed (once I found him/her). Lars > > Good luck. > > I've just abandoned all my pending changes related to QtDBus. > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center > > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Stepping down as QtDBus maintainer
On 2017-05-17 17:19, Thiago Macieira wrote: Since I am unable to fulfill my duties as maintainer, I am stepping down and opening the way up for someone else. Hi Thiago, Do you have an overview on what's the current state of the module ? Just so the next maintainer gets an idea of where to start. Anyway, thanks for the hours you've spent on it. Regards, -- Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer Klarälvdalens Datakonsult AB, a KDAB Group company Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - The Qt, C++ and OpenGL Experts ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Introducing discussion about QStringFormatter
On 16.05.2017 19:14, Thiago Macieira wrote:
On {}{}: I think that's an acceptable shorthand, just like we have "%1 is %1"
today. A bracket without any digits has higher replacement precedence than
{0}:
"The {0} brown {} jumped over the {2} {3}" % ("fox", "quick", "dog", "lazy")
{} gets replaced ahead of {0}, then {0}, then {2} because {1} is missing, then
{3}.
Hm, interesting approach to it, other approaches I've seen is:
- {} gets assigned the first unused number (in your example it'd be
equivalent to {1})
- No mixing between numbered and unnumbered placeholders
But to clarify, in your scenario
"{}{}" % ("a", "b")
would be "ab", correct?
--
Mårten Nordheim
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Introducing discussion about QStringFormatter
On 16.05.2017 19:23, Thiago Macieira wrote:
On segunda-feira, 15 de maio de 2017 05:49:19 PDT Mårten Nordheim wrote:
- Note: To print a curly brace they have to be doubled (same
as in all of the above) ( "{{", "}}" )
Why do we need a double closing curly brace? This is not a valid sequence:
"Closing Brace: }"
Or would the formatter complain if it found that?
This is enforced for consistency, not because it would cause a problem
for the formatter:
"{{ABC}" vs "{{abs}}"
As well as the fact that it is also done this way in other libraries (I
originally had '\\{' for escaping, but changed it.)
- Alternatively: put all BC functionality
behind 'arg' and use another function-name
for the new formatting style/functionality
(e.g. '.format', '.subs')
The choice of whether to use a constructor or a differently-named function
will depend on the design choice for your API. So it's up to you.
Please consider, in terms of Qt API design (ease of use, surprise factor,
etc.) just what the following should do:
QStringFormatter("%1 is {1}").arg("foo").subs("bar")
Hm, hadn't thought that far ahead, thanks. I guess that would be hard to
guess without reading the docs. In this case a constructor parameter is
the better choice for BC.
- i18n could be in a separate class/child-class
- but it should be kept in mind during the design and
implementation of this class to make i18n easier to
implement
No, the MAIN purpose of the formatter is i18n. Therefore, this needs to be in
the base class and designed from the get-go.
Formatted output to files is a secondary goal (we already have QTextStream).
Formatted output to the console is a tertiary goal, or even a non-goal.
I'll have to look into and get back to this
--
Mårten Nordheim
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] QList
On 27 April 2017 at 17:57, Thiago Macieira wrote: > On Thursday, 27 April 2017 01:19:16 -03 Marc Mutz wrote: >> On 2017-04-26 23:38, Konstantin Tokarev wrote: >> > 26.04.2017, 08:04, "Marc Mutz" : >> >> Users >> >> that need a queue can use std::deque. If you don't iterate over it, >> >> it's >> >> a more than acceptable container. >> > >> > std::deque is not a contiguous container, unlike QList or QVector >> >> Here's news for you: QList is not a contiguous container. > > Sometimes it is. Not relevant to this post, but the QUIP is here for review: https://codereview.qt-project.org/#/c/194984/ ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
