Re: [Development] Platform maintainers
And I’ve now updated the wiki with all the new maintainers that got nominated and accepted over the last couple of months. Congratulations to all of them :) Cheers, Lars On 08/12/14 09:22, Paul Olav Tvete paul.tv...@theqtcompany.com wrote: On Friday 5. December 2014 10.56.48 Thiago Macieira wrote: Was there anyone who did not get seconded? No. You approved all of them. :) - Paul ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On Friday 5. December 2014 10.56.48 Thiago Macieira wrote: Was there anyone who did not get seconded? No. You approved all of them. :) - Paul ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
Il 25/09/2014 12:17, Knoll Lars ha scritto: There are currently a few empty spots in our maintainer list, and I’d like to fill them again and make that list more complete before we have 5.4 out. I guess we should make those nominations official now? :) -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Software Engineer KDAB (UK) Ltd., a KDAB Group company Tel. UK +44-1738-450410, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions smime.p7s Description: Firma crittografica S/MIME ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On Friday 05 December 2014 18:49:56 Giuseppe D'Angelo wrote: Il 25/09/2014 12:17, Knoll Lars ha scritto: There are currently a few empty spots in our maintainer list, and I’d like to fill them again and make that list more complete before we have 5.4 out. I guess we should make those nominations official now? :) It's been a while and there were no objections. Was there anyone who did not get seconded? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
In addition to the below, I would suggest adding Rafael Roquetto as a second maintainer for the QNX platform. Rafael was tightly involved in the development of Qt5 for QNX and is working on several customer projects using Qt on QNX. — Vladimir On 26.09.14 14:04, Vladimir Minenko vmine...@blackberry.com wrote: On 25.09.14 12:17, Knoll Lars lars.kn...@digia.com wrote: QNX is open for the moment, I’d love to hear proposals. I propose Bernd Weimer for this role. Bernd has a long-term experience working with Qt in general and was developing many core elements of the current QPA for QNX. I know only very few other persons who know this code at a comparable level and/or worked on it that much. https://codereview.qt-project.org/#/q/owner:bweimer,n,z — Vladimir ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
Hi, On Friday 26 September 2014 18:01:55 Robin Burchell wrote: On Fri, Sep 26, 2014 at 5:17 PM, Nichols Andy andy.nich...@digia.com wrote: My suggestions for replacement would be either Giulio Camuffo who as been main driver for the QtWayland project this year, or Jorgen Lind who was the previous QtWayland maintainer and who still has a deep interest in the project. +1 to either, but I have to say I'd lean towards a +2 for Giulio simply because he is more focused on Wayland, whereas Jørgen has many other things on his plate already (from what I've seen going around in Gerrit). Giulio has an extensive knowledge base in the area, and has proven a real asset in the time he's been working actively on QtWayland QtCompositor. (No offence intended to Jørgen if my understanding of the situation is incorrect!) Non taken :) Giulio has driven much of the QtWayland development for 3/4 of a year now, and I think he is a good fit for as the maintainer. I can be the maintainer if he does not want it, as I intend to pick up QtWayland development again. Jørgen ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On Monday 29 September 2014 18:22:22 Jorgen Lind wrote: Giulio has driven much of the QtWayland development for 3/4 of a year now, and I think he is a good fit for as the maintainer. I can be the maintainer if he does not want it, as I intend to pick up QtWayland development again. Given that, I hereby nominate Giulio Camuffo as the qtwayland maintainer. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On 25.09.14 12:17, Knoll Lars lars.kn...@digia.com wrote: QNX is open for the moment, I’d love to hear proposals. I propose Bernd Weimer for this role. Bernd has a long-term experience working with Qt in general and was developing many core elements of the current QPA for QNX. I know only very few other persons who know this code at a comparable level and/or worked on it that much. https://codereview.qt-project.org/#/q/owner:bweimer,n,z — Vladimir ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
With all the embedded and graphics stuff on my plate QtWayland would be too much at this stage, I think. Jørgen would be an excellent candidate indeed, given that he is the original maintainer anyhow. Cheers, Laszlo From: development-bounces+laszlo.agocs=digia@qt-project.org [development-bounces+laszlo.agocs=digia@qt-project.org] on behalf of Giulio Camuffo [giuliocamu...@gmail.com] Sent: Friday, September 26, 2014 12:33 PM To: Thiago Macieira Cc: development@qt-project.org Subject: Re: [Development] Platform maintainers 2014-09-25 19:26 GMT+03:00 Thiago Macieira thiago.macie...@intel.com: On Thursday 25 September 2014 10:17:25 Knoll Lars wrote: Windows: Friedemann WinRT: Andrew Knight OS X: Morten Linux (X11): Jørgen Lind Linux (Wayland): Already covered by Andy Nichols iOS: Tor Arne Android: Bogdan Windows CE: Björn Breitmeyer QNX is open for the moment, I’d love to hear proposals. Most of the people above have been acting as a platform maintainer in practice, so this is mostly about formalising the responsibility and giving them proper recognition. Agreed, most of them are already acting as Maintainers anyway, which is the usual requirement for them to become Maintainers anyway. At the very least, I can directly confirm Friedemann, Andrew, Tor Arne, Bogdan and Björn have done that work, as I've sent a few patches their way for those platforms and they were readily acted on. Moreover, I know Morten, Jørgen and Andy personally, and a quick git log shows they've been active. (Wayland being the easiest, since it's a separate repo: of the last 200 commits, 140 were reviewed by Andy) Uhm, how did you get that number? A git log -n 200 |grep Andy|wc -l says 5 to me, four Reviewed-by and one Author, the last one being on February 11. I don't want to be dismissive of the work he has done on qtwayland, but he hasn't been working on it for many months, and on and off for even more. Jørgen or Laszlo would be a better fit, imho. -- Giulio ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On Friday 26 September 2014 13:33:55 Giulio Camuffo wrote: Uhm, how did you get that number? A git log -n 200 |grep Andy|wc -l says 5 to me, four Reviewed-by and one Author, the last one being on February 11. I don't want to be dismissive of the work he has done on qtwayland, but he hasn't been working on it for many months, and on and off for even more. Jørgen or Laszlo would be a better fit, imho. I ran this: $ git log origin/5.4~200..origin/5.4 | grep Reviewed-by | sort | uniq -c 32 Reviewed-by: Andrew Knight andrew.kni...@digia.com 140 Reviewed-by: Andy Nichols andy.nich...@digia.com 1 Reviewed-by: Elvis Lee kwangwoong@lge.com 1 Reviewed-by: Frederik Gladhorn frederik.gladh...@digia.com 3 Reviewed-by: Giulio Camuffo giuliocamu...@gmail.com 50 Reviewed-by: Giulio Camuffo giulio.camu...@jollamobile.com 2 Reviewed-by: Gunnar Sletta gunnar.sle...@digia.com 34 Reviewed-by: Gunnar Sletta gunnar.sle...@jollamobile.com 1 Reviewed-by: Gunnar Sletta gun...@sletta.org 36 Reviewed-by: Jan Arne Petersen jan.peter...@kdab.com 1 Reviewed-by: Jędrzej Nowacki jedrzej.nowa...@digia.com 2 Reviewed-by: Joerg Bornemann joerg.bornem...@digia.com 109 Reviewed-by: Jørgen Lind jorgen.l...@digia.com 8 Reviewed-by: Jørgen Lind jorgen.l...@gmail.com 89 Reviewed-by: Laszlo Agocs laszlo.ag...@digia.com 1 Reviewed-by: Laszlo Papp lp...@kde.org 1 Reviewed-by: Lubomir Rintel lkund...@v3.sk 1 Reviewed-by: Michael Brasser michael.bras...@live.com 2 Reviewed-by: Mikko Levonmaa mikko.levon...@lge.com 6 Reviewed-by: Oswald Buddenhagen oswald.buddenha...@digia.com 7 Reviewed-by: Paul Olav Tvete paul.tv...@digia.com 2 Reviewed-by: Philippe Coval r...@gna.org 18 Reviewed-by: Pier Luigi Fiorini pierluigi.fior...@gmail.com 26 Reviewed-by: Robin Burchell robin.burch...@viroteck.net 30 Reviewed-by: Robin Burchell robin...@viroteck.net 17 Reviewed-by: Samuel Rødal samuel.ro...@digia.com 3 Reviewed-by: Sergio Ahumada sahum...@blackberry.com 5 Reviewed-by: Shawn Rutledge shawn.rutle...@digia.com 1 Reviewed-by: Simo Fält simo.f...@digia.com 2 Reviewed-by: Thiago Macieira thiago.macie...@intel.com 1 Reviewed-by: Tor Arne Vestbø tor.arne.ves...@digia.com 1 Reviewed-by: Vesa Halttunen 1 Reviewed-by: Yen-Chin Lee coldnew...@gmail.com Problem: origin/5.4~200..origin/5.4 contains more than 200 commits due to merging. That's actually 491. I didn't notice this problem because the number of reviews per person were all less than 200. Bad coincidence. If I restrict to actually 200 commits, here's the result: $ git log -n200 origin/5.4 | grep Reviewed-by | sort | uniq -c 4 Reviewed-by: Andrew Knight andrew.kni...@digia.com 4 Reviewed-by: Andy Nichols andy.nich...@digia.com 1 Reviewed-by: Frederik Gladhorn frederik.gladh...@digia.com 1 Reviewed-by: Giulio Camuffo giuliocamu...@gmail.com 50 Reviewed-by: Giulio Camuffo giulio.camu...@jollamobile.com 34 Reviewed-by: Gunnar Sletta gunnar.sle...@jollamobile.com 1 Reviewed-by: Gunnar Sletta gun...@sletta.org 2 Reviewed-by: Jan Arne Petersen jan.peter...@kdab.com 22 Reviewed-by: Jørgen Lind jorgen.l...@digia.com 48 Reviewed-by: Laszlo Agocs laszlo.ag...@digia.com 1 Reviewed-by: Michael Brasser michael.bras...@live.com 2 Reviewed-by: Mikko Levonmaa mikko.levon...@lge.com 1 Reviewed-by: Oswald Buddenhagen oswald.buddenha...@digia.com 2 Reviewed-by: Philippe Coval r...@gna.org 6 Reviewed-by: Pier Luigi Fiorini pierluigi.fior...@gmail.com 26 Reviewed-by: Robin Burchell robin.burch...@viroteck.net 25 Reviewed-by: Robin Burchell robin...@viroteck.net 1 Reviewed-by: Sergio Ahumada sahum...@blackberry.com 5 Reviewed-by: Shawn Rutledge shawn.rutle...@digia.com 1 Reviewed-by: Thiago Macieira thiago.macie...@intel.com 1 Reviewed-by: Vesa Halttunen 1 Reviewed-by: Yen-Chin Lee coldnew...@gmail.com And you're right, the last time Andy reviewed anything in qtwayland was February/2014. So, Andy, are you coming back? Or do you want to step down for someone else? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
Hi everyone, And you're right, the last time Andy reviewed anything in qtwayland was February/2014. This sounds much more in line with reality. So, Andy, are you coming back? Or do you want to step down for someone else? It is true that I have not had much time to devote to QtWayland this year, and while I can see the possibility of returning to working with QtWayland, it will not be to the same extent as before. I would be comfortable stepping down to let someone who has shown they do have the time needed to devote to QtWayland. My suggestions for replacement would be either Giulio Camuffo who as been main driver for the QtWayland project this year, or Jorgen Lind who was the previous QtWayland maintainer and who still has a deep interest in the project. Regards, Andy Nichols ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On Fri, Sep 26, 2014 at 5:17 PM, Nichols Andy andy.nich...@digia.com wrote: My suggestions for replacement would be either Giulio Camuffo who as been main driver for the QtWayland project this year, or Jorgen Lind who was the previous QtWayland maintainer and who still has a deep interest in the project. +1 to either, but I have to say I'd lean towards a +2 for Giulio simply because he is more focused on Wayland, whereas Jørgen has many other things on his plate already (from what I've seen going around in Gerrit). Giulio has an extensive knowledge base in the area, and has proven a real asset in the time he's been working actively on QtWayland QtCompositor. (No offence intended to Jørgen if my understanding of the situation is incorrect!) ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Platform maintainers
Hi, There are currently a few empty spots in our maintainer list, and I’d like to fill them again and make that list more complete before we have 5.4 out. To start with, I’d like to pick up a topic that had been discussed in the past without reaching a conclusion. It is about having platform maintainers. We currently have a lot of maintainers for different subsystems in Qt, but nobody with a clear formal responsibility of ensuring that Qt runs well on a certain platform/operating system. I think we should change that as Qt does contain sizeable pieces of platform dependent code in Qt. In the QPA plugins and the platform dependent implementations in qtbase. In styles and backends for things such as sensors. We can also clearly see that not everybody can test on all platforms, and we need to have a point of contact when it comes to helping getting things working on a specific platform. To make it explicit, I’d like to propose the following people as Maintainers for different platforms: Windows: Friedemann WinRT: Andrew Knight OS X: Morten Linux (X11): Jørgen Lind Linux (Wayland): Already covered by Andy Nichols iOS: Tor Arne Android: Bogdan Windows CE: Björn Breitmeyer QNX is open for the moment, I’d love to hear proposals. Most of the people above have been acting as a platform maintainer in practice, so this is mostly about formalising the responsibility and giving them proper recognition. Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
To make it explicit, I’d like to propose the following people as Maintainers for different platforms: Android: Bogdan +1 daniel ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
On Thursday 25 September 2014 10:17:25 Knoll Lars wrote: Windows: Friedemann WinRT: Andrew Knight OS X: Morten Linux (X11): Jørgen Lind Linux (Wayland): Already covered by Andy Nichols iOS: Tor Arne Android: Bogdan Windows CE: Björn Breitmeyer QNX is open for the moment, I’d love to hear proposals. Most of the people above have been acting as a platform maintainer in practice, so this is mostly about formalising the responsibility and giving them proper recognition. Agreed, most of them are already acting as Maintainers anyway, which is the usual requirement for them to become Maintainers anyway. At the very least, I can directly confirm Friedemann, Andrew, Tor Arne, Bogdan and Björn have done that work, as I've sent a few patches their way for those platforms and they were readily acted on. Moreover, I know Morten, Jørgen and Andy personally, and a quick git log shows they've been active. (Wayland being the easiest, since it's a separate repo: of the last 200 commits, 140 were reviewed by Andy) Therefore, I give my Maintainer +1 on all nominations. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
Is it possible also to add sub categories under QtPorts for Windows/XCB/OS X and etc in bug tracker? Regards, Liang On 10 January 2014 23:51, Knoll Lars wrote: Yes, I was about to write a mail about it. We don't currently officially have maintainers for platforms, but they exist in reality, and I'd like to make them explicit. So if nobody disagrees, I'll add them to the list next week. Cheers, Lars On 10/01/14 18:22, David Faure wrote: Could we add a table at the bottom of http://qt-project.org/wiki/Maintainers with the platform maintainers, for each platform? ... unless I'm wrong and the concept doesn't exist within the Qt community, but AFAIK it does? I can't find who's the official maintainer for each platform. -- David Faure | david.fa...@kdab.com | Managing Director KDAB France KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions -- http://www.qiliang.net ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Platform maintainers
Could we add a table at the bottom of http://qt-project.org/wiki/Maintainers with the platform maintainers, for each platform? ... unless I'm wrong and the concept doesn't exist within the Qt community, but AFAIK it does? I can't find who's the official maintainer for each platform. -- David Faure | david.fa...@kdab.com | Managing Director KDAB France KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers
Yes, I was about to write a mail about it. We don't currently officially have maintainers for platforms, but they exist in reality, and I'd like to make them explicit. So if nobody disagrees, I'll add them to the list next week. Cheers, Lars On 10/01/14 18:22, David Faure david.fa...@kdab.com wrote: Could we add a table at the bottom of http://qt-project.org/wiki/Maintainers with the platform maintainers, for each platform? ... unless I'm wrong and the concept doesn't exist within the Qt community, but AFAIK it does? I can't find who's the official maintainer for each platform. -- David Faure | david.fa...@kdab.com | Managing Director KDAB France KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Platform maintainers: changes to OpenGL context creation required
Il 23/02/2013 15:45, Giuseppe D'Angelo ha scritto: Hello, in a few days I would like to stage https://codereview.qt-project.org/48657 which will cause QOpenGLShaderProgram to ignore QT_OPENGL_ES (defined at build time) and rely on renderable type returned from the current context (via QOpenGLContext::format()). Unless someone objects, I'll stage it tomorrow. Thanks, -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Software Engineer KDAB (UK) Ltd., a KDAB Group company Tel. UK +44-1738-450410, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Platform maintainers: changes to OpenGL context creation required
Hello, in a few days I would like to stage https://codereview.qt-project.org/48657 which will cause QOpenGLShaderProgram to ignore QT_OPENGL_ES (defined at build time) and rely on renderable type returned from the current context (via QOpenGLContext::format()). This means that platform plugins must correctly set the renderable type on the surface format when they successfully create an OpenGL context. (A default constructed QSurfaceFormat will have DefaultRenderableType instead; you MUST NOT return that value any more. Return the actual default type.) Failing to do so might result in QOpenGLShaderProgram breaking on your Desktop OpenGL platform, as it won't hide you the precision qualifiers any more. (Note that this also means breaking QQ2 on your platform.) I have already patched the XCB, Windows (Desktop GL) and Cocoa platforms -- EGL (and Windows/ANGLE, which uses it) was already returning the right renderable type: https://codereview.qt-project.org/48653 https://codereview.qt-project.org/48655 https://codereview.qt-project.org/48654 If you're going to patch a platform plugin in order to fix this issue, please add me as a reviewer -- I will not stage my change until yours is in. Thanks, -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Software Engineer KDAB (UK) Ltd., a KDAB Group company Tel. UK +44-1738-450410, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
