Re: [Development] codereview, merge please
On 21.2.2019 9.08, Martin Koller wrote: > On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote: >> Since it has the +2 you can click on the "Merge patch 2 to staging" now, is >> that button showing up for you? > > So now I did merge it to staging, but I got a "Qt CI Bot" mail stating that > "Continuous Integration: Failed" > https://testresults.qt.io/coin/integration/qt/qtbase/tasks/1550613219 > > I have no idea how a DBus test could be influenced by my commit. > Should I just try to merge again or what is the correct procedure ? Yes, if the failure is unrelated to your commit, just merge the patch to staging again. -- Kari ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] codereview, merge please
On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote: > Since it has the +2 you can click on the "Merge patch 2 to staging" now, is > that button showing up for you? So now I did merge it to staging, but I got a "Qt CI Bot" mail stating that "Continuous Integration: Failed" https://testresults.qt.io/coin/integration/qt/qtbase/tasks/1550613219 I have no idea how a DBus test could be influenced by my commit. Should I just try to merge again or what is the correct procedure ? > > Andy > > -Opprinnelig melding- > Fra: Development på vegne av Martin > Koller > Dato: fredag 15. februar 2019 11:04 > Til: "development@qt-project.org" > Emne: [Development] codereview, merge please > > Hi, > > I made a patch here > https://codereview.qt-project.org/#/c/249171/ > > but it's still not merged. > Did I forget something ? > > -- > Best regards/Schöne Grüße > > Martin > A: Because it breaks the logical sequence of discussion > Q: Why is top posting bad? > > () ascii ribbon campaign - against html e-mail > /\- against proprietary attachments > > Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at > > > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development > > > -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] codereview, merge please
On fredag 15. februar 2019 12:21:43 CET Martin Koller wrote: > On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote: > > Since it has the +2 you can click on the "Merge patch 2 to staging" now, > > is that button showing up for you? > ah, great. Was not aware that I needed to trigger that. > My fault. Was thinking the maintainer does that. Thank you for contributing to Qt Martin! This goes of course for all contributors, it's greatly appreciated that you make Qt better! Sometimes Gerrit (especially the old version running on codereview.qt- project.org) is not the most obvious to use. For the people regularly using it, it tends to work nicely, but I can understand how it's just different enough from other Git workflows to be confusing. Cheers, Frederik > Thanks! > > > Andy > > > > -Opprinnelig melding- > > Fra: Development på vegne av Martin > > Koller Dato: fredag 15. februar 2019 11:04 > > Til: "development@qt-project.org" > > Emne: [Development] codereview, merge please > > > > Hi, > > > > I made a patch here > > https://codereview.qt-project.org/#/c/249171/ > > > > but it's still not merged. > > Did I forget something ? ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] codereview, merge please
On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote: > Since it has the +2 you can click on the "Merge patch 2 to staging" now, is > that button showing up for you? ah, great. Was not aware that I needed to trigger that. My fault. Was thinking the maintainer does that. Thanks! > Andy > > -Opprinnelig melding- > Fra: Development på vegne av Martin > Koller > Dato: fredag 15. februar 2019 11:04 > Til: "development@qt-project.org" > Emne: [Development] codereview, merge please > > Hi, > > I made a patch here > https://codereview.qt-project.org/#/c/249171/ > > but it's still not merged. > Did I forget something ? > > -- > Best regards/Schöne Grüße > > Martin > A: Because it breaks the logical sequence of discussion > Q: Why is top posting bad? > > () ascii ribbon campaign - against html e-mail > /\- against proprietary attachments > > Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at > > > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development > > > -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] codereview, merge please
Since it has the +2 you can click on the "Merge patch 2 to staging" now, is that button showing up for you? Andy -Opprinnelig melding- Fra: Development på vegne av Martin Koller Dato: fredag 15. februar 2019 11:04 Til: "development@qt-project.org" Emne: [Development] codereview, merge please Hi, I made a patch here https://codereview.qt-project.org/#/c/249171/ but it's still not merged. Did I forget something ? -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
[Development] codereview, merge please
Hi, I made a patch here https://codereview.qt-project.org/#/c/249171/ but it's still not merged. Did I forget something ? -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
