Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-06 Thread Marc Mutz 
On Tuesday 06 September 2016 11:43:34 Oswald Buddenhagen wrote:
> On Mon, Sep 05, 2016 at 09:17:59PM +, J-P Nurmi wrote:
> > On 05 Sep 2016, at 19:27, Marc Mutz  wrote:
> > > It's not about restricting what a user can do. It's simply missing
> > > implementation, and I believe that if it were easy to implement,
> > > Ossi would have done it long ago instead of playing retarget-monkey
> > > for the rest of us :)
> > 
> > Doing it through the web UI would be a nice bonus, but having access
> > to the same script that is already used by the admins would be good
> > enough for starters.
> 
> yep - because i'm totally going to give everyone full write access to
> the database. ;)
> 
> if you make a secure web frontend that authenticates against qt account
> and verifies change ownership using the gerrit ssh interface, i'm
> totally willing to deploy that. ;)

Maybe just add a combobox "Request Move to Other Branch" that just emails you 
and Frederik?

As it is now, not even all @qt.io people know how to do this/that it's 
possible...

Thanks,
Marc

-- 
Marc Mutz  | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - Qt, C++ and OpenGL Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-06 Thread J-P Nurmi 
On 06 Sep 2016, at 11:46, Konstantin Tokarev  wrote:
> 
> 
> 
> 06.09.2016, 12:44, "Oswald Buddenhagen" :
>>> On Mon, Sep 05, 2016 at 09:17:59PM +, J-P Nurmi wrote:
>>>  On 05 Sep 2016, at 19:27, Marc Mutz  wrote:
>>>  > It's not about restricting what a user can do. It's simply missing
>>>  > implementation, and I believe that if it were easy to implement,
>>>  > Ossi would have done it long ago instead of playing retarget-monkey
>>>  > for the rest of us :)
>>> 
>>>  Doing it through the web UI would be a nice bonus, but having access
>>>  to the same script that is already used by the admins would be good
>>>  enough for starters.
>> 
>> yep - because i'm totally going to give everyone full write access to
>> the database. ;)
>> 
>> if you make a secure web frontend that authenticates against qt account
>> and verifies change ownership using the gerrit ssh interface, i'm
>> totally willing to deploy that. ;)
> 
> Idea: IRC bot accepting retarget requests, with rate limit e.g. one request 
> per minute. Bot runs on host with db access and can do only this one thing.

Another idea: patch Gerrit to change the target branch (and create a new 
patchset version to reset scores) when pushing to a different branch.

--
J-P Nurmi

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-06 Thread Konstantin Tokarev 


06.09.2016, 12:44, "Oswald Buddenhagen" :
> On Mon, Sep 05, 2016 at 09:17:59PM +, J-P Nurmi wrote:
>>  On 05 Sep 2016, at 19:27, Marc Mutz  wrote:
>>  > It's not about restricting what a user can do. It's simply missing
>>  > implementation, and I believe that if it were easy to implement,
>>  > Ossi would have done it long ago instead of playing retarget-monkey
>>  > for the rest of us :)
>>
>>  Doing it through the web UI would be a nice bonus, but having access
>>  to the same script that is already used by the admins would be good
>>  enough for starters.
>
> yep - because i'm totally going to give everyone full write access to
> the database. ;)
>
> if you make a secure web frontend that authenticates against qt account
> and verifies change ownership using the gerrit ssh interface, i'm
> totally willing to deploy that. ;)

Idea: IRC bot accepting retarget requests, with rate limit e.g. one request per 
minute. Bot runs on host with db access and can do only this one thing.

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-06 Thread Oswald Buddenhagen 
On Mon, Sep 05, 2016 at 09:17:59PM +, J-P Nurmi wrote:
> On 05 Sep 2016, at 19:27, Marc Mutz  wrote:
> > It's not about restricting what a user can do. It's simply missing
> > implementation, and I believe that if it were easy to implement,
> > Ossi would have done it long ago instead of playing retarget-monkey
> > for the rest of us :)
> 
> Doing it through the web UI would be a nice bonus, but having access
> to the same script that is already used by the admins would be good
> enough for starters.
> 
yep - because i'm totally going to give everyone full write access to
the database. ;)

if you make a secure web frontend that authenticates against qt account
and verifies change ownership using the gerrit ssh interface, i'm
totally willing to deploy that. ;)
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-05 Thread J-P Nurmi 
> On 05 Sep 2016, at 19:27, Marc Mutz  wrote:
> 
> On Monday 05 September 2016 19:20:29 J-P Nurmi wrote:
 On 05 Sep 2016, at 18:53, Marc Mutz  wrote:
 On Wednesday 31 August 2016 16:12:55 Oswald Buddenhagen wrote:
 with the upcoming qtcon and my subsequent vacation, my availability will
 be rather sporadic, so consider this:
 - i'm not going to do reviews on a regular basis, so it's unwise to just
 
 add me to them and expect a reaction. send me a direct mail.
 - this recommendation actually applies irrespective of current plans -
 
   sometimes i actually want to get some work done instead of just doing
   reviews. ;)
 
 - you can also ask frederik gladhorn (fregl)
 
 generally speaking, send a complete list of change urls, as we can just
 paste that into the script which performs the operation. that's also the
 reason why a single mail (or irc messsage) instead of adding us to n
 reviews is always preferred. please don't give verbal descriptions of
 ranges - somebody has to do the click and paste orgy anyway, and that
 should be you. ;)
>>> 
>>> And please, pretty please, don't _abandon_ changes and resubmit them to a
>>> different branch. _Do_ ask Ossi or Frederik to re-target on the server,
>>> _esp_ if you've already run into half a dozen revisions. Submitting a
>>> new change without the ability to use inter-change diffs is just rude
>>> towards the reviewers.
>> 
>> Let us move our own changes. If you're worried about abuse, downgrade any
>> +2 to +1 on branch change. Problem solved.
> 
> It's not about restricting what a user can do. It's simply missing 
> implementation, and I believe that if it were easy to implement, Ossi would 
> have done it long ago instead of playing retarget-monkey for the rest of us :)

Doing it through the web UI would be a nice bonus, but having access to the 
same script that is already used by the admins would be good enough for 
starters.

--
J-P Nurmi
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-05 Thread Sergio Ahumada 

On 05.09.2016 19:29, Marc Mutz wrote:

On Monday 05 September 2016 19:20:29 J-P Nurmi wrote:

On 05 Sep 2016, at 18:53, Marc Mutz  wrote:

On Wednesday 31 August 2016 16:12:55 Oswald Buddenhagen wrote:
with the upcoming qtcon and my subsequent vacation, my availability will
be rather sporadic, so consider this:
- i'm not going to do reviews on a regular basis, so it's unwise to just

 add me to them and expect a reaction. send me a direct mail.
 - this recommendation actually applies irrespective of current plans -

   sometimes i actually want to get some work done instead of just doing
   reviews. ;)

- you can also ask frederik gladhorn (fregl)

generally speaking, send a complete list of change urls, as we can just
paste that into the script which performs the operation. that's also the
reason why a single mail (or irc messsage) instead of adding us to n
reviews is always preferred. please don't give verbal descriptions of
ranges - somebody has to do the click and paste orgy anyway, and that
should be you. ;)


And please, pretty please, don't _abandon_ changes and resubmit them to a
different branch. _Do_ ask Ossi or Frederik to re-target on the server,
_esp_ if you've already run into half a dozen revisions. Submitting a
new change without the ability to use inter-change diffs is just rude
towards the reviewers.


Let us move our own changes. If you're worried about abuse, downgrade any
+2 to +1 on branch change. Problem solved.


It's not about restricting what a user can do. It's simply missing
implementation, and I believe that if it were easy to implement, Ossi would
have done it long ago instead of playing retarget-monkey for the rest of us :)

Thanks,
Marc



https://bugreports.qt.io/browse/QTQAINFRA-268

https://bugs.chromium.org/p/gerrit/issues/detail?id=117

--
Sergio Ahumada
sahum...@texla.cl

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-05 Thread Marc Mutz 
On Monday 05 September 2016 19:20:29 J-P Nurmi wrote:
> > On 05 Sep 2016, at 18:53, Marc Mutz  wrote:
> >> On Wednesday 31 August 2016 16:12:55 Oswald Buddenhagen wrote:
> >> with the upcoming qtcon and my subsequent vacation, my availability will
> >> be rather sporadic, so consider this:
> >> - i'm not going to do reviews on a regular basis, so it's unwise to just
> >> 
> >>  add me to them and expect a reaction. send me a direct mail.
> >>  - this recommendation actually applies irrespective of current plans -
> >>  
> >>sometimes i actually want to get some work done instead of just doing
> >>reviews. ;)
> >> 
> >> - you can also ask frederik gladhorn (fregl)
> >> 
> >> generally speaking, send a complete list of change urls, as we can just
> >> paste that into the script which performs the operation. that's also the
> >> reason why a single mail (or irc messsage) instead of adding us to n
> >> reviews is always preferred. please don't give verbal descriptions of
> >> ranges - somebody has to do the click and paste orgy anyway, and that
> >> should be you. ;)
> > 
> > And please, pretty please, don't _abandon_ changes and resubmit them to a
> > different branch. _Do_ ask Ossi or Frederik to re-target on the server,
> > _esp_ if you've already run into half a dozen revisions. Submitting a
> > new change without the ability to use inter-change diffs is just rude
> > towards the reviewers.
> 
> Let us move our own changes. If you're worried about abuse, downgrade any
> +2 to +1 on branch change. Problem solved.

It's not about restricting what a user can do. It's simply missing 
implementation, and I believe that if it were easy to implement, Ossi would 
have done it long ago instead of playing retarget-monkey for the rest of us :)

Thanks,
Marc

-- 
Marc Mutz  | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - Qt, C++ and OpenGL Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-05 Thread J-P Nurmi 
> On 05 Sep 2016, at 18:53, Marc Mutz  wrote:
> 
>> On Wednesday 31 August 2016 16:12:55 Oswald Buddenhagen wrote:
>> with the upcoming qtcon and my subsequent vacation, my availability will
>> be rather sporadic, so consider this:
>> - i'm not going to do reviews on a regular basis, so it's unwise to just
>>  add me to them and expect a reaction. send me a direct mail.
>>  - this recommendation actually applies irrespective of current plans -
>>sometimes i actually want to get some work done instead of just doing
>>reviews. ;)
>> - you can also ask frederik gladhorn (fregl)
>> 
>> generally speaking, send a complete list of change urls, as we can just
>> paste that into the script which performs the operation. that's also the
>> reason why a single mail (or irc messsage) instead of adding us to n
>> reviews is always preferred. please don't give verbal descriptions of
>> ranges - somebody has to do the click and paste orgy anyway, and that
>> should be you. ;)
> 
> And please, pretty please, don't _abandon_ changes and resubmit them to a 
> different branch. _Do_ ask Ossi or Frederik to re-target on the server, _esp_ 
> if you've already run into half a dozen revisions. Submitting a new change 
> without the ability to use inter-change diffs is just rude towards the 
> reviewers.

Let us move our own changes. If you're worried about abuse, downgrade any +2 to 
+1 on branch change. Problem solved.

--
J-P Nurmi
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [FYI] on gerrit change retargeting requests

2016-09-05 Thread Marc Mutz 
On Wednesday 31 August 2016 16:12:55 Oswald Buddenhagen wrote:
> with the upcoming qtcon and my subsequent vacation, my availability will
> be rather sporadic, so consider this:
> - i'm not going to do reviews on a regular basis, so it's unwise to just
>   add me to them and expect a reaction. send me a direct mail.
>   - this recommendation actually applies irrespective of current plans -
> sometimes i actually want to get some work done instead of just doing
> reviews. ;)
> - you can also ask frederik gladhorn (fregl)
> 
> generally speaking, send a complete list of change urls, as we can just
> paste that into the script which performs the operation. that's also the
> reason why a single mail (or irc messsage) instead of adding us to n
> reviews is always preferred. please don't give verbal descriptions of
> ranges - somebody has to do the click and paste orgy anyway, and that
> should be you. ;)

And please, pretty please, don't _abandon_ changes and resubmit them to a 
different branch. _Do_ ask Ossi or Frederik to re-target on the server, _esp_ 
if you've already run into half a dozen revisions. Submitting a new change 
without the ability to use inter-change diffs is just rude towards the 
reviewers.

Thanks,
Marc

-- 
Marc Mutz  | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - Qt, C++ and OpenGL Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development