Re: [Development] HEADS-UP: Qt 5.4.2 release coming
Hi Peter, Thanks! Why an incomplete copy/paste? I see it's missing the changes to tools/qtconfig/mainwindow.cpp, did you omit other changes as well? Because the gerrit code is Qt5 not Qt4. So it needs a complete review and test by you if it works on Mac, I don't have a Mac. Peter R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Thursday April 23 2015 16:58:05 Peter Kuemmel wrote: Because the gerrit code is Qt5 not Qt4. Doh ... I wondered about that and should have realised it was the case seeing the dialoghelper file on the list. So it needs a complete review and test by you if it works on Mac, Actually, I am still working on a Qt 5 version. Porting the OS X specific changes of the Qt 4 patch was relatively straightforward, but the Linux code needs some attention as well. That's a bit problematic because I don't currently have a Linux rig powerful enough to build Qt, but also I can't find the x11/xcb/freetype equivalent to qcocoafontdialoghelper.mm ... Anyway, the current patch for Qt 5 (5.4.1) is here: https://github.com/RJVB/mp-port-repository/blob/master/aqua/qt5-mac-devel/files/patch-improve-fontweight-support.diff I looked at the gerrit comments, and one made me wonder: is Qt no longer the product of a European company? I'm pretty sure trolls are a EU species, who if they could write without errors would use an EU language and spelling ;) R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On 23.04.2015 20:31, René J.V. Bertin wrote: On Thursday April 23 2015 16:58:05 Peter Kuemmel wrote: Because the gerrit code is Qt5 not Qt4. Doh ... I wondered about that and should have realised it was the case seeing the dialoghelper file on the list. So it needs a complete review and test by you if it works on Mac, Actually, I am still working on a Qt 5 version. Porting the OS X specific changes of the Qt 4 patch was relatively straightforward, but the Linux code needs some attention as well. That's a bit problematic because I don't currently have a Linux rig powerful enough to build Qt, but also I can't find the x11/xcb/freetype equivalent to qcocoafontdialoghelper.mm ... Anyway, the current patch for Qt 5 (5.4.1) is here: https://github.com/RJVB/mp-port-repository/blob/master/aqua/qt5-mac-devel/files/patch-improve-fontweight-support.diff I would start only with the Mac changes, and if they get accepted, you/one could change the other systems (where the folk is not that sensitive on font stuff ;) ) I looked at the gerrit comments, and one made me wonder: is Qt no longer the product of a European company? I'm pretty sure trolls are a EU species, who if they could write without errors would use an EU language and spelling ;) R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On 23.04.2015 14:30, René J.V. Bertin wrote: On Thursday April 23 2015 11:13:41 Peter Kuemmel wrote: René, maybe this helps you a bit: https://codereview.qt-project.org/#/c/111056/ It's only a incomplete copy and paste of your Qt 4 patch, but it could show you the direction. Hi Peter, Thanks! Why an incomplete copy/paste? I see it's missing the changes to tools/qtconfig/mainwindow.cpp, did you omit other changes as well? Wasn't qtconfig removed from Qt5? R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Thursday April 23 2015 02:26:22 Jan Kundrát wrote: Hi, what did the damn system say, and what command did you use to send your patch to that damn system? I cannot answer that exactly, I was trying to do the push amidst the preparations for a trip which I'm now on and which explains that the we'll see next week bit of my message. The successful tickets I created were done with Atlassian SourceTree, which I tried using again but I also tried the command shown in the online documentation. It's not like I tried once without any RTFM and then made a public announcement of defeat. R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
René, maybe this helps you a bit: https://codereview.qt-project.org/#/c/111056/ It's only a incomplete copy and paste of your Qt 4 patch, but it could show you the direction. Peter ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Thursday April 23 2015 11:13:41 Peter Kuemmel wrote: René, maybe this helps you a bit: https://codereview.qt-project.org/#/c/111056/ It's only a incomplete copy and paste of your Qt 4 patch, but it could show you the direction. Hi Peter, Thanks! Why an incomplete copy/paste? I see it's missing the changes to tools/qtconfig/mainwindow.cpp, did you omit other changes as well? R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Wednesday 22 April 2015 09:55:52 René J.V. Bertin wrote: https://git.reviewboard.kde.org/r/123458/ Sure, but your patch should be rejected there. Opinion, not a fact. The patch is up there for review and reference, not to sneak into Qt via a backdoor. There is no backdoor, only a mirror of the main repository. Which is exactly why it should be rejected: if it's a mirror, it shouldn't contain additional changes. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday, 21 April 2015 21:19:43 CEST, René J.V. Bertin wrote: Damn system refused to let me push anything where before I've been able to do so. Hi René, what did the damn system say, and what command did you use to send your patch to that damn system? Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday April 21 2015 15:02:33 Thiago Macieira ... just whining. No comment. But just for the record, I was indeed annoyed (with myself at least as much as with gerrit) but otherwise just observing a fact. I think I made it clear enough that I wasn't going to have time to spend on the issue for a bit. https://git.reviewboard.kde.org/r/123458/ Sure, but your patch should be rejected there. Opinion, not a fact. The patch is up there for review and reference, not to sneak into Qt via a backdoor. There is no backdoor, only a mirror of the main repository. R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
If you aren't fixing critical bug you should use '5.5' branch for that. '5.4' is for possible 5.4.3 and not for any nice-to-have fixes, sorry. Br, jani -Original Message- From: René J.V. Bertin [mailto:rjvber...@gmail.com] Sent: 20. huhtikuuta 2015 14:06 To: development@qt-project.org Cc: Heikkinen Jani Subject: Re: [Development] HEADS-UP: Qt 5.4.2 release coming On Monday April 20 2015 10:54:36 Heikkinen Jani wrote: Hi, Once again: Please remember that '5.4.2' is release branch and so on no any nice-to-have fixes in anymore! I'm trying to finish up a patch to the logic behind the support for font weights and styles testing against 5.4.1 currently (and 5.4.2 once it's out). Can I at least launch a code review request against the 5.4 branch when I'm done? R ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday April 21 2015 10:07:49 Thiago Macieira wrote: Either they've been putting up with it or they've never noticed. Either way, that makes the bug not critical for a patch release. Possibly. I've just tried to create a code review for the Qt 4.8 version of my patch. Damn system refused to let me push anything where before I've been able to do so. Too bad. The patch will be available through github for anyone who finds this critical enough to (re)build Qt for it. R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
Hi René, * René J.V. Bertin rjvber...@gmail.com [2015-04-21 21:19:43 +0200]: On Tuesday April 21 2015 10:07:49 Thiago Macieira wrote: Either they've been putting up with it or they've never noticed. Either way, that makes the bug not critical for a patch release. Possibly. I've just tried to create a code review for the Qt 4.8 version of my patch. Damn system refused to let me push anything where before I've been able to do so. Too bad. The patch will be available through github for anyone who finds this critical enough to (re)build Qt for it. I'm sure enough people here will be more than happy to help you with that, but it'd be useful to know what exactly went wrong. Florian -- http://www.the-compiler.org | m...@the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc I love long mails! | http://email.is-not-s.ms/ pgpm10wV5MbFJ.pgp Description: PGP signature ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday April 21 2015 14:37:49 Olivier Goffart wrote: If people have been living in the 80s for that long, they can wait until the next minor release. If I decided to pick up on this it's because I had had enough of it that about none of the Medium/Semibold fonts I use in my GUIs were stable (i.e. always evolved into either Bold or Normal). If this is not a regression against Qt4, then it is a new Hmmm, yes and no. Qt4 is affected too, but in a different way. Especially because font rendering is so delicate, and fixes somewhere in this area tends to break applications that relied on the previous behaviour. (When suddenly a line is a pixel larger, the rendering of a whole screen can be disastrous.) This doesn't have anything to do with rendering. I'm not touching that. It's got to do with getting the proper QFont : QFont font = QFontDialog::getFont(ok, QFont(), this, Select Font, options); QFont font2 = QFont(font.family(), font.pointSize(), font.weight(), font.italic()); QFont font3 = QFontDialog::getFont(ok, font2, this, Select Font, options); the second dialog can give a different font than the one selected in the 1st and indeed font3==font2!=font . Good test fonts are the Avenir Next and Helvetica Neue families (system fonts on OS X, the latter then new UI default), or even the Segoe UI family that comes with all MS Windows machines. Anyway, I'm not going to insist it has to go into 5.4, but I'm not going to go out of my way to prepare and test the patches against software I'm not even planning to build without proper incentive. Someone may (will) have to pick up on what I come up with. R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday April 21 2015 06:32:47 Heikkinen Jani wrote: If you aren't fixing critical bug you should use '5.5' branch for that. '5.4' is for possible 5.4.3 and not for any nice-to-have fixes, sorry. This is actually more than just a nice-to-have fix. It affects anyone doing any kind of serious work with fonts, and not just on OS X. So this is more than just a nice-to-have fix, unless of course you think it's fine for Qt to remain stuck in the 80s or so as far as font handling is concerned. There are lots of typefaces (combinations of font family, weight, style) that cannot be reloaded for the standard ways to represent them in settings files, and I'm not even sure that the approach Qt follows allows for 100% reliable function. I'll see how my patch set applies to 5.5 if I get it to a point where I'm satisfied. If it doesn't, and you really want it for 5.5 or later ... I'll be available for hire (for that crucial incentive to meddle with an unreleased major software version). R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
Perhaps worth mentioning that QPushButtons don't render on Android: https://bugreports.qt.io/browse/QTBUG-45714 On 21/04/2015 15:20, Massimo Callegari wrote: Hi all! Downmerge from '5.4' to '5.4.2' is now done all changes targeted to Qt5.4.2 release must be done in '5.4.2' branch. From now on '5.4' is for possible Qt5.4.3 release. If there is some open changes in '5.4' which should be in Qt5.4.2 please sent re-targeting request to Ossi. Once again: Please remember that '5.4.2' is release branch and so on no any nice-to-have fixes in anymore! Maintainers: Please create change files for Qt5.4.2 immediately, we are planning to put Qt5.4.2 out soon! br, Jani Hi, if possible please include this: https://bugreports.qt.io/browse/QTBUG-45037 Pending on Gerrit here: https://codereview.qt-project.org/#/c/110724/ It's a regression from 5.4.0. Thanks Massimo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday 21. April 2015 15:26:36 René J.V. Bertin wrote: On Tuesday April 21 2015 14:37:49 Olivier Goffart wrote: If people have been living in the 80s for that long, they can wait until the next minor release. If I decided to pick up on this it's because I had had enough of it that about none of the Medium/Semibold fonts I use in my GUIs were stable (i.e. always evolved into either Bold or Normal). That's not the point. One can say that for everything: If I decided to work on $FEATURE it is because I really need it. Therefore it should go in the next patch release That's not an argument. Especially because font rendering is so delicate, and fixes somewhere in this area tends to break applications that relied on the previous behaviour. (When suddenly a line is a pixel larger, the rendering of a whole screen can be disastrous.) This doesn't have anything to do with rendering. I'm not touching that. It's got to do with getting the proper QFont : [...] As I said, i don't know the specific details of this patch, but the problem is the same. If you get a different font (because you get the more 'proper' font now), then this can break applications layout. It is a behaviour change that should not be part of a patch release. Anyway, I'm not going to insist it has to go into 5.4, but I'm not going to go out of my way to prepare and test the patches against software I'm not even planning to build without proper incentive. Someone may (will) have to pick up on what I come up with. I understand your point of view. But if you want to maximize your chances that your patch get included in Qt, you have to target the right branch. (And honestly, it is not too hard to switch branches. If you can build 5.4 it is no more work to build 5.5 or dev) -- Olivier Woboq - Qt services and support - http://woboq.com - http://code.woboq.org ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday 21. April 2015 10:33:50 René J.V. Bertin wrote: On Tuesday April 21 2015 06:32:47 Heikkinen Jani wrote: If you aren't fixing critical bug you should use '5.5' branch for that. '5.4' is for possible 5.4.3 and not for any nice-to-have fixes, sorry. This is actually more than just a nice-to-have fix. It affects anyone doing any kind of serious work with fonts, and not just on OS X. So this is more than just a nice-to-have fix, unless of course you think it's fine for Qt to remain stuck in the 80s or so as far as font handling is concerned. There are lots of typefaces (combinations of font family, weight, style) that cannot be reloaded for the standard ways to represent them in settings files, and I'm not even sure that the approach Qt follows allows for 100% reliable function. I don't know anything about that particular patch, but this does not look like a candidate for a stable branch. If people have been living in the 80s for that long, they can wait until the next minor release. If this is not a regression against Qt4, then it is a new feature, and 5.5 or even dev should be a better candidate. Especially because font rendering is so delicate, and fixes somewhere in this area tends to break applications that relied on the previous behaviour. (When suddenly a line is a pixel larger, the rendering of a whole screen can be disastrous.) But this does sound like a nice change you are doing. -- Olivier Woboq - Qt services and support - http://woboq.com - http://code.woboq.org ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday April 21 2015 16:38:57 Olivier Goffart wrote: That's not the point. That *was* not my point. Which was: who knows how many users have been working around it, or putting up with it, as I used to do. As I said, i don't know the specific details of this patch, but the problem is the same. If you get a different font (because you get the more 'proper' font now), then this can break applications layout. It is a behaviour change that should not be part of a patch release. The removal of a crashing bug which people avoid by using undocumented features (that might be affected by a proper fix) is also a behavioural change that line of thought... The issue also isn't that font selection through the font dialog doesn't work. It does. Common font weights and styles also get restored properly. That won't change. The only cases in which layout that will change is when applications rely on getting the wrong font, one way or another. In other words, they exploit undocumented behaviour, and that should be their problem. (And honestly, it is not too hard to switch branches. If you can build 5.4 it is no more work to build 5.5 or dev) Sure, if I really had unlimited time and resources at my disposal I wouldn't mind. That's not the case, so I'm not going to be wasting hours of those I do have to build something I'm not going to use. And certainly not if we're talking about 5.6, because that would mean I'll also have to tackle 5.5 and if so ... well, no thanks. R ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday 21 April 2015 17:51:13 René J.V. Bertin wrote: That's not the point. That *was* not my point. Which was: who knows how many users have been working around it, or putting up with it, as I used to do. Either they've been putting up with it or they've never noticed. Either way, that makes the bug not critical for a patch release. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday April 21 2015 21:23:13 Florian Bruhin wrote: Hi I'm sure enough people here will be more than happy to help you with In the meantime, this site was more than happy to accept my patch - no gitting or committing required :) https://git.reviewboard.kde.org/r/123458/ R. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Tuesday 21 April 2015 22:32:51 René J.V. Bertin wrote: On Tuesday April 21 2015 21:23:13 Florian Bruhin wrote: Hi Florian, I'm sure enough people here will be more than happy to help you with that, but it'd be useful to know what exactly went wrong. It looked as if commits are no longer accepted, and that's after I configured https upload because my SSH key was being refused too. Maybe a transient glitch, but it'll be about a week before I'll have time to look at this again. That would be wrong, since commits are accepted into 4.8, including via SSH. I know because I've just tested. Like I said, if you don't post the error and the steps you took, you're not going to get help. If after twice being asked to post them you still don't but complain publicly again, you're not asking for help -- you're just whining. So don't bother posting them now, I'll not help you. In the meantime, this site was more than happy to accept my patch - no gitting or committing required https://git.reviewboard.kde.org/r/123458/ Sure, but your patch should be rejected there. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Monday April 20 2015 10:54:36 Heikkinen Jani wrote: Hi, Once again: Please remember that '5.4.2' is release branch and so on no any nice-to-have fixes in anymore! I'm trying to finish up a patch to the logic behind the support for font weights and styles testing against 5.4.1 currently (and 5.4.2 once it's out). Can I at least launch a code review request against the 5.4 branch when I'm done? R ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] HEADS-UP: Qt 5.4.2 release coming
Hi all! Downmerge from '5.4' to '5.4.2' is now done all changes targeted to Qt5.4.2 release must be done in '5.4.2' branch. From now on '5.4' is for possible Qt5.4.3 release. If there is some open changes in '5.4' which should be in Qt5.4.2 please sent re-targeting request to Ossi. Once again: Please remember that '5.4.2' is release branch and so on no any nice-to-have fixes in anymore! Maintainers: Please create change files for Qt5.4.2 immediately, we are planning to put Qt5.4.2 out soon! br, Jani Lähettäjä: Heikkinen Jani Lähetetty: 10. huhtikuuta 2015 13:23 Vastaanottaja: development@qt-project.org Kopio: releas...@qt-project.org Aihe: HEADS-UP: Qt 5.4.2 release coming Hi all, Qt5.git integration succeed finally in '5.4' and so on we can start soft branching from '5.4' to '5.4.2' today. '5.4.2' branch is already created and downmerge from '5.4' to '5.4.2' will be done Friday 17th April 2015. That way everyone should have enough time to finalize ongoing changes in '5.4' branch start using '5.4.2' branch for the changes targeted to Qt 5.4.2 release. Target is to release Qt 5.4.2 at the end of April. Please remember: we are doing patch level release now meaning do not put any new features / nice to have fix in it! Please make sure all issues blocking the Qt 5.4.2 release are linked to blocker meta bug: https://bugreports.qt.io/browse/QTBUG-44881 Snapshot creation is ongoing first Qt5.4.2 snapshot should be available here later today: http://download.qt.io/snapshots/qt/5.4/ br, Jani ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
