Re: [xwiki-devs] [XWiki Day] BFD#123

2016-10-21 Thread Alexandru Cotiuga 
Results: http://www.xwiki.org/xwiki/bin/view/Blog/Bug+Fixing+Day+123

Thanks Marius!

On Thu, Oct 20, 2016 at 7:30 AM, Alexandru Cotiuga <
alexandru.coti...@xwiki.com> wrote:

> Hello devs,
>
> This Thursday is BFD#123:
> http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingdays
>
> Our current status for the 1 year period is 62 bugs behind. See:
> http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=100
> 00#Created-vs-Resolved-Chart/10470
>
> Here's the BFD#123 dashboard to follow the progress during the day:
> http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=13699
>
> Happy Bug Fixing Day,
> Alex
>
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [Proposal] Add authclass property to the XWikiPreferences class

2016-10-21 Thread Thomas Mortagne 
Note that you will need to refactor a bit XWiki#getAuthService() if
you want to change the authenticator at runtime because right now it's
initialized once the first time it's called (i.e. need to reset it
when the authClass field is modified).

On Fri, Oct 21, 2016 at 10:04 AM, Thomas Mortagne
 wrote:
> I never liked authclass property but what we should have in it's place
> require major refactoring and your proposal is not worst than the
> current situation so I'm fine with it. +0
>
> On Fri, Oct 21, 2016 at 9:59 AM, Alexandru Cotiuga
>  wrote:
>> Since the xwiki.cfg allows the same for all the wikis, I was thinking for
>> now
>> to keep the same behaviour but with XWikiPreference so this would mean
>> that the main wiki will be the only one taken into account.
>>
>> On Fri, Oct 21, 2016 at 10:39 AM, Thomas Mortagne >> wrote:
>>
>>> Note there there is a big different between XWikiPreferences page and
>>> xwiki.cfg: each wiki has its own.
>>>
>>> So do you plan to refactor the auth system to let each wiki have a
>>> different authenticator ? Or is the main wiki the only one that will
>>> be taken into account ?
>>>
>>> On Fri, Oct 21, 2016 at 8:57 AM, Alexandru Cotiuga
>>>  wrote:
>>> > Hi devs,
>>> >
>>> > I'm proposing to add this new property to the *XWikiPreferences* class
>>> > since there are many authenticators, listed on
>>> > http://platform.xwiki.org/xwiki/bin/view/Features/Authentication and
>>> most
>>> > of them require the overriding of the *xwiki.authentication.authclass*
>>> > property in the *WEB-INF/xwiki.cfg* file and the restart of the wiki. So
>>> > the *authclass* is meant to keep the value of the
>>> > *xwiki.authentication.authclass
>>> > *property*.*
>>> >
>>> > Please keep in mind that *xwiki.cfg* was the historical file containing
>>> the
>>> > configuration options, we're moving away from it and this can be the
>>> moment
>>> > to improve this functionality by removing the *restart wiki* step which
>>> is
>>> > often a pain for the user.
>>> >
>>> > Thanks,
>>> > Alex
>>> > ___
>>> > devs mailing list
>>> > devs@xwiki.org
>>> > http://lists.xwiki.org/mailman/listinfo/devs
>>>
>>>
>>>
>>> --
>>> Thomas Mortagne
>>> ___
>>> devs mailing list
>>> devs@xwiki.org
>>> http://lists.xwiki.org/mailman/listinfo/devs
>>>
>> ___
>> devs mailing list
>> devs@xwiki.org
>> http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne



-- 
Thomas Mortagne
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [Proposal] Add authclass property to the XWikiPreferences class

2016-10-21 Thread Thomas Mortagne 
I never liked authclass property but what we should have in it's place
require major refactoring and your proposal is not worst than the
current situation so I'm fine with it. +0

On Fri, Oct 21, 2016 at 9:59 AM, Alexandru Cotiuga
 wrote:
> Since the xwiki.cfg allows the same for all the wikis, I was thinking for
> now
> to keep the same behaviour but with XWikiPreference so this would mean
> that the main wiki will be the only one taken into account.
>
> On Fri, Oct 21, 2016 at 10:39 AM, Thomas Mortagne > wrote:
>
>> Note there there is a big different between XWikiPreferences page and
>> xwiki.cfg: each wiki has its own.
>>
>> So do you plan to refactor the auth system to let each wiki have a
>> different authenticator ? Or is the main wiki the only one that will
>> be taken into account ?
>>
>> On Fri, Oct 21, 2016 at 8:57 AM, Alexandru Cotiuga
>>  wrote:
>> > Hi devs,
>> >
>> > I'm proposing to add this new property to the *XWikiPreferences* class
>> > since there are many authenticators, listed on
>> > http://platform.xwiki.org/xwiki/bin/view/Features/Authentication and
>> most
>> > of them require the overriding of the *xwiki.authentication.authclass*
>> > property in the *WEB-INF/xwiki.cfg* file and the restart of the wiki. So
>> > the *authclass* is meant to keep the value of the
>> > *xwiki.authentication.authclass
>> > *property*.*
>> >
>> > Please keep in mind that *xwiki.cfg* was the historical file containing
>> the
>> > configuration options, we're moving away from it and this can be the
>> moment
>> > to improve this functionality by removing the *restart wiki* step which
>> is
>> > often a pain for the user.
>> >
>> > Thanks,
>> > Alex
>> > ___
>> > devs mailing list
>> > devs@xwiki.org
>> > http://lists.xwiki.org/mailman/listinfo/devs
>>
>>
>>
>> --
>> Thomas Mortagne
>> ___
>> devs mailing list
>> devs@xwiki.org
>> http://lists.xwiki.org/mailman/listinfo/devs
>>
> ___
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs



-- 
Thomas Mortagne
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [Proposal] Add authclass property to the XWikiPreferences class

2016-10-21 Thread Alexandru Cotiuga 
Since the xwiki.cfg allows the same for all the wikis, I was thinking for
now
to keep the same behaviour but with XWikiPreference so this would mean
that the main wiki will be the only one taken into account.

On Fri, Oct 21, 2016 at 10:39 AM, Thomas Mortagne  wrote:

> Note there there is a big different between XWikiPreferences page and
> xwiki.cfg: each wiki has its own.
>
> So do you plan to refactor the auth system to let each wiki have a
> different authenticator ? Or is the main wiki the only one that will
> be taken into account ?
>
> On Fri, Oct 21, 2016 at 8:57 AM, Alexandru Cotiuga
>  wrote:
> > Hi devs,
> >
> > I'm proposing to add this new property to the *XWikiPreferences* class
> > since there are many authenticators, listed on
> > http://platform.xwiki.org/xwiki/bin/view/Features/Authentication and
> most
> > of them require the overriding of the *xwiki.authentication.authclass*
> > property in the *WEB-INF/xwiki.cfg* file and the restart of the wiki. So
> > the *authclass* is meant to keep the value of the
> > *xwiki.authentication.authclass
> > *property*.*
> >
> > Please keep in mind that *xwiki.cfg* was the historical file containing
> the
> > configuration options, we're moving away from it and this can be the
> moment
> > to improve this functionality by removing the *restart wiki* step which
> is
> > often a pain for the user.
> >
> > Thanks,
> > Alex
> > ___
> > devs mailing list
> > devs@xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne
> ___
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [Proposal] Add authclass property to the XWikiPreferences class

2016-10-21 Thread Thomas Mortagne 
Note there there is a big different between XWikiPreferences page and
xwiki.cfg: each wiki has its own.

So do you plan to refactor the auth system to let each wiki have a
different authenticator ? Or is the main wiki the only one that will
be taken into account ?

On Fri, Oct 21, 2016 at 8:57 AM, Alexandru Cotiuga
 wrote:
> Hi devs,
>
> I'm proposing to add this new property to the *XWikiPreferences* class
> since there are many authenticators, listed on
> http://platform.xwiki.org/xwiki/bin/view/Features/Authentication and most
> of them require the overriding of the *xwiki.authentication.authclass*
> property in the *WEB-INF/xwiki.cfg* file and the restart of the wiki. So
> the *authclass* is meant to keep the value of the
> *xwiki.authentication.authclass
> *property*.*
>
> Please keep in mind that *xwiki.cfg* was the historical file containing the
> configuration options, we're moving away from it and this can be the moment
> to improve this functionality by removing the *restart wiki* step which is
> often a pain for the user.
>
> Thanks,
> Alex
> ___
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs



-- 
Thomas Mortagne
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [Proposal] Add authclass property to the XWikiPreferences class

2016-10-21 Thread Sergiu Dumitriu 
I really don't like that only one authenticator can be enabled at a
time. This forces more specialized authenticators to explicitly inherit
another type of authenticator that should also be supported (see for
example NTLMAuthServiceImpl -> XWikiLDAPAuthServiceImpl ->
XWikiAuthServiceImpl). Ideally, we should have only one root
authenticator, which shouldn't be configurable at all, and which doesn't
authenticate itself but delegates to a dynamic list of pluggable
authenticators.

But this would take a lot longer to design and implement, so I'm just
going to vote +0 for your incremental improvement proposal.

On 10/21/2016 02:57 AM, Alexandru Cotiuga wrote:
> Hi devs,
> 
> I'm proposing to add this new property to the *XWikiPreferences* class
> since there are many authenticators, listed on
> http://platform.xwiki.org/xwiki/bin/view/Features/Authentication and most
> of them require the overriding of the *xwiki.authentication.authclass*
> property in the *WEB-INF/xwiki.cfg* file and the restart of the wiki. So
> the *authclass* is meant to keep the value of the
> *xwiki.authentication.authclass
> *property*.*
> 
> Please keep in mind that *xwiki.cfg* was the historical file containing the
> configuration options, we're moving away from it and this can be the moment
> to improve this functionality by removing the *restart wiki* step which is
> often a pain for the user.
> 
> Thanks,
> Alex


-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

[xwiki-devs] [Proposal] Add authclass property to the XWikiPreferences class

2016-10-21 Thread Alexandru Cotiuga 
Hi devs,

I'm proposing to add this new property to the *XWikiPreferences* class
since there are many authenticators, listed on
http://platform.xwiki.org/xwiki/bin/view/Features/Authentication and most
of them require the overriding of the *xwiki.authentication.authclass*
property in the *WEB-INF/xwiki.cfg* file and the restart of the wiki. So
the *authclass* is meant to keep the value of the
*xwiki.authentication.authclass
*property*.*

Please keep in mind that *xwiki.cfg* was the historical file containing the
configuration options, we're moving away from it and this can be the moment
to improve this functionality by removing the *restart wiki* step which is
often a pain for the user.

Thanks,
Alex
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs