Re: Adding json lines (jsonl) serializer to django
Hi Ali, as I noted on the PR, the ticket isn't in the review queue because "needs tests" is checked. On Thursday, May 21, 2020 at 9:47:53 AM UTC-4, Ali Vakilzade wrote: > > Hi! > > A while back I opened a pull request on this topic and there is no updates > on the my request for a while. I know people might be busy and not having > time to review but I'm sending this mail hoping to bring the pull request > back up and not die on github. I think supporting "JSON lines" is a small > feature which can be very useful for many people. > > pull request: https://github.com/django/django/pull/12267 > ticket: https://code.djangoproject.com/ticket/30190 > previous discussion: > https://groups.google.com/forum/#!topic/django-developers/MMm1AGS2Ibg > > thanks > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/ad34bab0-5b83-45c4-a18a-2bfb9607be4f%40googlegroups.com.
Re: Adding json lines (jsonl) serializer ro django
Hi Ali
Thanks for coming back to this. As I wrote on the ticket I'd be in favour
of adding this.
If you've got some code already it'd be good to see it in a PR
As for your question about overly long lines I think the .replace() style
is fine, or a consrtuction like this:
''.join([
"{"
'"key1": "value1",
"}",
])
Django contributions are not just about core developers giving you the
green light; you'll need to be a bit persistent to follow the coding
guides, fix test errors, respond to feedback, and push the patch through.
But given you've returned after 10 months I'm sure you can!
Thanks,
Adam
On Mon, 16 Dec 2019 at 23:05, Ali Vakilzade wrote:
> Hey!
>
> A few month ago I opened a ticket for adding jsonl support to django
> serializers, I have added a basic patch as the starting point but my ticket
> was closed because it needed more discussion on the mailing list, I'm
> willing to work more on my patch to reach a final state (adding more tests
> and updating docs) but before working more on it just wanted to get the
> green light or some direction from you :-)
>
> Link to ticket: https://code.djangoproject.com/ticket/30190
>
> Thanks
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/17a919f1-559d-4599-85c8-236a9df5cf6e%40googlegroups.com
>
> .
>
--
Adam
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/CAMyDDM2RQ5x65XA%2BtiRmbhCKeasPn8a7wc_Na7LD8zLSEzLJMg%40mail.gmail.com.
Adding json lines (jsonl) serializer ro django
Hey! A few month ago I opened a ticket for adding jsonl support to django serializers, I have added a basic patch as the starting point but my ticket was closed because it needed more discussion on the mailing list, I'm willing to work more on my patch to reach a final state (adding more tests and updating docs) but before working more on it just wanted to get the green light or some direction from you :-) Link to ticket: https://code.djangoproject.com/ticket/30190 Thanks -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/17a919f1-559d-4599-85c8-236a9df5cf6e%40googlegroups.com.
