Re: Multiple template engines for Django - week 12
Thanks for the explanation. It makes sense to remove select_template. Regards, Michael Manfre On Sun, Dec 28, 2014 at 3:53 AM, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hi Michael, > > > On 28 déc. 2014, at 07:12, Michael Manfre wrote: > > > > If I'm understanding your post correctly, any potential performance > improvement that a special cased select_template would have would likely be > negated by caching. > > Sorry, I didn’t explain sufficiently clearly. My reasoning was: > > 1) Is there any situation where I can call a backend's select_template? > Yes, when only one template engine is configured. > 2) Does this have any advantages? Unclear, it may allow some performance > optimizations at the backend level but that's completely theoretical. > 3) Does that make it worth keeping select_template? Probably not. > > > Have you observed, or do you expect to see any significant performance > hits to the test suite, which doesn't cache as intensely as live sites? > > No, I don’t expect to see a measurable impact on the test suite’s run > time, because the current code and the new code will do roughly the same > amont of work and neither optimizes anything. > > -- > Aymeric. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/05BAC9A8-41C3-4FD8-88F2-531E933C517C%40polytechnique.org > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAGdCwBtv7jkA-y-c3OcCs-hUbRfwi9y66v_JpHSbEFxCeY-1Ag%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Multiple template engines for Django - week 12
Hi Michael, > On 28 déc. 2014, at 07:12, Michael Manfre wrote: > > If I'm understanding your post correctly, any potential performance > improvement that a special cased select_template would have would likely be > negated by caching. Sorry, I didn’t explain sufficiently clearly. My reasoning was: 1) Is there any situation where I can call a backend's select_template? Yes, when only one template engine is configured. 2) Does this have any advantages? Unclear, it may allow some performance optimizations at the backend level but that's completely theoretical. 3) Does that make it worth keeping select_template? Probably not. > Have you observed, or do you expect to see any significant performance hits > to the test suite, which doesn't cache as intensely as live sites? No, I don’t expect to see a measurable impact on the test suite’s run time, because the current code and the new code will do roughly the same amont of work and neither optimizes anything. -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/05BAC9A8-41C3-4FD8-88F2-531E933C517C%40polytechnique.org. For more options, visit https://groups.google.com/d/optout.
Re: Multiple template engines for Django - week 12
If I'm understanding your post correctly, any potential performance improvement that a special cased select_template would have would likely be negated by caching. Have you observed, or do you expect to see any significant performance hits to the test suite, which doesn't cache as intensely as live sites? Regards, Michael Manfre On Sat, Dec 27, 2014 at 5:59 PM, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello, > > My twelfth update is online: > https://myks.org/en/multiple-template-engines-for-django/#2014-12-28 > > It comes with a question — should I drop `select_template` from the > backend API? I think I should. Follow the link above for details. > > Looking forward to your feedback, > > -- > Aymeric. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAGdCwBsUd4B%3D7NkKh6oEaaqwFNvCCcupRsOMFcEfRfMoUsH0vg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Multiple template engines for Django - week 12
I agree about the select_template() change as well. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/286ede07-d0e7-447f-9da9-4b3e9e49089e%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Multiple template engines for Django - week 12
I agree with your expected behavior for select_template() and the conclusions you drew. On Saturday, December 27, 2014 5:59:37 PM UTC-5, Aymeric Augustin wrote: > > Hello, > > My twelfth update is online: > https://myks.org/en/multiple-template-engines-for-django/#2014-12-28 > > It comes with a question — should I drop `select_template` from the > backend API? I think I should. Follow the link above for details. > > Looking forward to your feedback, > > -- > Aymeric. > > > > > On 20 déc. 2014, at 23:57, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > > > > Hello, > > > > I haven’t written to this mailing-list for three weeks because nothing > warranted your immediate attention. > > > > Now the code is in reasonably good shape. Feel free to have a look: > > https://github.com/aaugustin/django/commits/multiple-template-engines > > > > I plan to merge this branch within a few days. > > > > Updates for weeks 9 to 11 are available at the usual location: > > https://github.com/aaugustin/django/commits/multiple-template-engines > > > > -- > > Aymeric. > > > > > > > >> On 30 nov. 2014, at 10:37, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > >> > >> Hello, > >> > >> Here’s my eight update — this is getting repetitive :-) > >> https://myks.org/en/multiple-template-engines-for-django/#2014-11-30 > >> > >> -- > >> Aymeric. > >> > >> > >> > >>> On 23 nov. 2014, at 00:02, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > >>> > >>> Hello, > >>> > >>> I published my seventh update: > >>> https://myks.org/en/multiple-template-engines-for-django/#2014-11-23 > >>> > >>> I have another pull request ready for review: > >>> https://github.com/django/django/pull/3605 > >>> > >>> Let me know if you have any questions! > >>> > >>> -- > >>> Aymeric. > >>> > >>> > >>> > On 16 nov. 2014, at 09:19, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > > Hello, > > Here’s my sixth update: > https://myks.org/en/multiple-template-engines-for-django/#2014-11-16 > > I have a first pull request ready for review: > https://github.com/django/django/pull/3555 > > Whenever possible, I’ll merge changes that make sense regardless of > the Multiple Template Engines Project in small batches, in order to > minimize the size of the final pull request. > > -- > Aymeric. > > > > > On 9 nov. 2014, at 22:05, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > > > > Hello, > > > > Here’s my fifth update: > > https://myks.org/en/multiple-template-engines-for-django/#2014-11-09 > > > > The first step of my project, as outlined in my original proposal, > is complete. > > > > -- > > Aymeric. > > > > > > > >> On 1 nov. 2014, at 23:30, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > >> > >> Hello, > >> > >> I’m happy to annonce that the DEP is ready for public review! > >> > >> Direct link, HTML: > >> https://myks.org/en/multiple-template-engines-for-django/dep/ > >> > >> Direct link, ReStructured Text: > >> > https://raw.githubusercontent.com/aaugustin/mtefd/master/multiple-template-engines.rst > > >> > >> (I’m not reproducing it here because I don’t think email is a very > good medium for communicating 50kB of markup.) > >> > >> I’ve written a bit more about what “ready” means: > >> > https://myks.org/en/multiple-template-engines-for-django/#2014-11-01 > >> > >> Of course, your regularly scheduled update will also be available > (in half an hour): > >> > https://myks.org/en/multiple-template-engines-for-django/#2014-11-02 > >> > >> I’m looking forward to your feedback! > >> > >> -- > >> Aymeric. > >> > >> > >> > >>> On 26 oct. 2014, at 22:36, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > >>> > >>> Hello, > >>> > >>> I just published the third update: > >>> > https://myks.org/en/multiple-template-engines-for-django/#2014-10-26 > >>> > >>> -- > >>> Aymeric. > >>> > >>> > >>> > On 19 oct. 2014, at 00:09, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > > Hello, > > Here’s the second update: > > https://myks.org/en/multiple-template-engines-for-django/#2014-10-19 > > Best, > > -- > Aymeric. > > > > On 12 oct. 2014, at 20:31, Aymeric Augustin < > aymeric@polytechnique.org > wrote: > > > Hello, > > > > I just posted the first update on this project: > > > https://myks.org/en/multiple-template-engines-for-django/#2014-10-12 > > >
Multiple template engines for Django - week 12
Hello, My twelfth update is online: https://myks.org/en/multiple-template-engines-for-django/#2014-12-28 It comes with a question — should I drop `select_template` from the backend API? I think I should. Follow the link above for details. Looking forward to your feedback, -- Aymeric. > On 20 déc. 2014, at 23:57, Aymeric Augustin > wrote: > > Hello, > > I haven’t written to this mailing-list for three weeks because nothing > warranted your immediate attention. > > Now the code is in reasonably good shape. Feel free to have a look: > https://github.com/aaugustin/django/commits/multiple-template-engines > > I plan to merge this branch within a few days. > > Updates for weeks 9 to 11 are available at the usual location: > https://github.com/aaugustin/django/commits/multiple-template-engines > > -- > Aymeric. > > > >> On 30 nov. 2014, at 10:37, Aymeric Augustin >> wrote: >> >> Hello, >> >> Here’s my eight update — this is getting repetitive :-) >> https://myks.org/en/multiple-template-engines-for-django/#2014-11-30 >> >> -- >> Aymeric. >> >> >> >>> On 23 nov. 2014, at 00:02, Aymeric Augustin >>> wrote: >>> >>> Hello, >>> >>> I published my seventh update: >>> https://myks.org/en/multiple-template-engines-for-django/#2014-11-23 >>> >>> I have another pull request ready for review: >>> https://github.com/django/django/pull/3605 >>> >>> Let me know if you have any questions! >>> >>> -- >>> Aymeric. >>> >>> >>> On 16 nov. 2014, at 09:19, Aymeric Augustin wrote: Hello, Here’s my sixth update: https://myks.org/en/multiple-template-engines-for-django/#2014-11-16 I have a first pull request ready for review: https://github.com/django/django/pull/3555 Whenever possible, I’ll merge changes that make sense regardless of the Multiple Template Engines Project in small batches, in order to minimize the size of the final pull request. -- Aymeric. > On 9 nov. 2014, at 22:05, Aymeric Augustin > wrote: > > Hello, > > Here’s my fifth update: > https://myks.org/en/multiple-template-engines-for-django/#2014-11-09 > > The first step of my project, as outlined in my original proposal, is > complete. > > -- > Aymeric. > > > >> On 1 nov. 2014, at 23:30, Aymeric Augustin >> wrote: >> >> Hello, >> >> I’m happy to annonce that the DEP is ready for public review! >> >> Direct link, HTML: >> https://myks.org/en/multiple-template-engines-for-django/dep/ >> >> Direct link, ReStructured Text: >> https://raw.githubusercontent.com/aaugustin/mtefd/master/multiple-template-engines.rst >> >> (I’m not reproducing it here because I don’t think email is a very good >> medium for communicating 50kB of markup.) >> >> I’ve written a bit more about what “ready” means: >> https://myks.org/en/multiple-template-engines-for-django/#2014-11-01 >> >> Of course, your regularly scheduled update will also be available (in >> half an hour): >> https://myks.org/en/multiple-template-engines-for-django/#2014-11-02 >> >> I’m looking forward to your feedback! >> >> -- >> Aymeric. >> >> >> >>> On 26 oct. 2014, at 22:36, Aymeric Augustin >>> wrote: >>> >>> Hello, >>> >>> I just published the third update: >>> https://myks.org/en/multiple-template-engines-for-django/#2014-10-26 >>> >>> -- >>> Aymeric. >>> >>> >>> On 19 oct. 2014, at 00:09, Aymeric Augustin wrote: Hello, Here’s the second update: https://myks.org/en/multiple-template-engines-for-django/#2014-10-19 Best, -- Aymeric. On 12 oct. 2014, at 20:31, Aymeric Augustin wrote: > Hello, > > I just posted the first update on this project: > https://myks.org/en/multiple-template-engines-for-django/#2014-10-12 > > My work in progress on the DEP is available here: > https://myks.org/en/multiple-template-engines-for-django/dep/ > > Feedback is welcome, especially on sections I’ve described as “done” > in the update. > > Thanks, > > -- > Aymeric. > >>> >> > >>> >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-deve
