Re: No caching if request.GET not empty
I updated the patch http://code.djangoproject.com/attachment/ticket/4992/cache_by_request_full_path_v2.diff I think it is ready for commit. The patch has docs and tests. Can someone please test it on different plattforms? I used: Python 2.5.1 on linux. Thomas Mikhail Korobov wrote: > Hi Thomas, > > there is a ticket for that: > > http://code.djangoproject.com/ticket/4992 -- Thomas Guettler, http://www.thomas-guettler.de/ E-Mail: guettli (*) thomas-guettler + de -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Re: No caching if request.GET not empty
Hi Thomas, there is a ticket for that: http://code.djangoproject.com/ticket/4992 On 29 сен, 16:36, Thomas Guettlerwrote: > Hi, > > I got not response on django-users, now I ask here: > > requests with a query string (http://example.com?foo=bar) are not cached in > Django: > > http://code.djangoproject.com/browser/django/trunk/django/middleware/... > {{{ > if not request.method in ('GET', 'HEAD') or request.GET: > request._cache_update_cache = False > return None # Don't bother checking the cache. > > }}} > > If the query string would be used in _generate_cache_key() (utils/cache.py), > requests with a not empty request.GET could be cached. > > I see no reason, not to cache requests with a query string. > > Can someone explain this? > > I read the documentation[1], but couldn't find a hint way GET requests > with a query string are not cached. > > Should I open a ticket? > > [1] cache docs:http://docs.djangoproject.com/en/dev/topics/cache/ > > Thomas > > -- > Thomas Guettler,http://www.thomas-guettler.de/ > E-Mail: guettli (*) thomas-guettler + de -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
No caching if request.GET not empty
Hi, I got not response on django-users, now I ask here: requests with a query string (http://example.com?foo=bar) are not cached in Django: http://code.djangoproject.com/browser/django/trunk/django/middleware/cache.py {{{ if not request.method in ('GET', 'HEAD') or request.GET: request._cache_update_cache = False return None # Don't bother checking the cache. }}} If the query string would be used in _generate_cache_key() (utils/cache.py), requests with a not empty request.GET could be cached. I see no reason, not to cache requests with a query string. Can someone explain this? I read the documentation[1], but couldn't find a hint way GET requests with a query string are not cached. Should I open a ticket? [1] cache docs: http://docs.djangoproject.com/en/dev/topics/cache/ Thomas -- Thomas Guettler, http://www.thomas-guettler.de/ E-Mail: guettli (*) thomas-guettler + de -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.