Re: Critical ticket: can cause data loss
2007/1/30, Russell Keith-Magee <[EMAIL PROTECTED]>: > > On 1/30/07, David Larlet <[EMAIL PROTECTED]> wrote: > > I'm +1 on this option. Before making decision what about at least add > > a warning message on the documentation page? > > This is kind of the point. Which documentation page? Generic relations > exist, but they aren't documented - specifically because they're not > really ready for prime time yet (at the very least, they don't have > any representation in the admin view). Here is the documentation page: http://www.djangoproject.com/documentation/models/generic_relations/ Cheers, David --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 30/01/07, James Bennett <[EMAIL PROTECTED]> wrote: > > On 1/29/07, Ned Batchelder <[EMAIL PROTECTED]> wrote: > > I don't know that you need to make a release for this fix, but I think you > > should alert people to it. There is a mailing list for announcing releases > > and security issues, right? You should send a message to that list > > announcing the patch. > > I will once I've backported it. The question in my mind is just > whether we need 0.95.2 from this. > I'm +1 on this too. I believe backports and point releases should be made for the following types of bugs: - security - availability e.g. crashing bugs - data integrity e.g. anything that causes data corruption, deletion etc. They cover off what most software vendors consider critical issues. Maybe the triage team could add keywords to that effect to tickets? regards matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
2007/1/29, James Bennett <[EMAIL PROTECTED]>: > > On 1/29/07, Ned Batchelder <[EMAIL PROTECTED]> wrote: > > I don't know that you need to make a release for this fix, but I think you > > should alert people to it. There is a mailing list for announcing releases > > and security issues, right? You should send a message to that list > > announcing the patch. > > I will once I've backported it. The question in my mind is just > whether we need 0.95.2 from this. I'm +1 on this option. Before making decision what about at least add a warning message on the documentation page? Cheers, David --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 1/29/07, Ned Batchelder <[EMAIL PROTECTED]> wrote: > I don't know that you need to make a release for this fix, but I think you > should alert people to it. There is a mailing list for announcing releases > and security issues, right? You should send a message to that list > announcing the patch. I will once I've backported it. The question in my mind is just whether we need 0.95.2 from this. -- "Bureaucrat Conrad, you are technically correct -- the best kind of correct." --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
I think it is risky to assume that all potentially affected users will see this information in this thread. I found it, but there was an element of luck involved. I don't read this list religiously, and could easily have missed it. I don't know that you need to make a release for this fix, but I think you should alert people to it. There is a mailing list for announcing releases and security issues, right? You should send a message to that list announcing the patch. --Ned. Adrian Holovaty wrote: > On 1/25/07, James Bennett <[EMAIL PROTECTED]> wrote: > >> At the moment I'm leaning toward rolling 0.95.2 immediately after that >> goes in, but I'd like to hear opinions on it; with 0.96 probably >> coming up soon, I can come up with good arguments either way. >> > > Nah, given that generic relations have never been documented and the > small fraction of people using them probably all subscribe to this > mailing list, I don't see any point in having another release. Plus, > 0.96 is coming soon enough. > > Adrian > > -- Ned Batchelder, http://nedbatchelder.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > > > I've just attached a unit test to the ticket. It seems to be the same > > issue described in #2749 and #3081. I think I understand the problem; > > the patch on #3081 is pretty much correct. I should have this sorted > > out by tonight. > > > > Ok - I've attached a patch with a fix to #3215. The fix is pretty much > what is attached to #3081, cleaned up for a couple of edge cases. The > patch fixes #3081, #3215 and #2749. > > I haven't committed the fix - it's late, I'm jetlagged, and I'm not > completely certain I haven't missed an edge case (in particular, the > reverse case - the patch for #3081 contains protection in the > reverse_m2m traversal, but as far as I can make out generic relations > don't have a reverse representation). My jetlag has worn off, so now I can see the obvious problem that I missed on Tuesday. I've checked in the fix as [4428]. Russ Magee %-) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > I've just attached a unit test to the ticket. It seems to be the same > issue described in #2749 and #3081. I think I understand the problem; > the patch on #3081 is pretty much correct. I should have this sorted > out by tonight. > Ok - I've attached a patch with a fix to #3215. The fix is pretty much what is attached to #3081, cleaned up for a couple of edge cases. The patch fixes #3081, #3215 and #2749. I haven't committed the fix - it's late, I'm jetlagged, and I'm not completely certain I haven't missed an edge case (in particular, the reverse case - the patch for #3081 contains protection in the reverse_m2m traversal, but as far as I can make out generic relations don't have a reverse representation). There is also some potential for cleanup - I'd rather see the type specific portion abstracted into a method on the field rather than having the isinstance(GenericField) call. However, in the meantime, the provided patch makes the unit tests pass and removes the data loss problem. If someone else can give this patch a sanity check and commit it, I'd be much obliged. Yours, Russ Magee %-) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 1/23/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > On 1/23/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > > > Could somebody provide some unit tests that isolate the problem? I've > > never mucked with the GenericForeignKey code -- perhaps Jacob or > > Russell could chime in here for the fix? > > I've never really played with GenericRelations, so I don't know their > internals particularly well. I'll have a look tonight and see if I can > make any sense of the problem. I've just attached a unit test to the ticket. It seems to be the same issue described in #2749 and #3081. I think I understand the problem; the patch on #3081 is pretty much correct. I should have this sorted out by tonight. Russ Magee %-) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 1/23/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > Could somebody provide some unit tests that isolate the problem? I've > never mucked with the GenericForeignKey code -- perhaps Jacob or > Russell could chime in here for the fix? I've never really played with GenericRelations, so I don't know their internals particularly well. I'll have a look tonight and see if I can make any sense of the problem. Yours, Russ Magee %-) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Critical ticket: can cause data loss
On 1/22/07, SmileyChris <[EMAIL PROTECTED]> wrote: > Deletion of objects with a GenericRelation(X) deletes unrelated X > objects with the same object_id! > http://code.djangoproject.com/ticket/3215 > > This ticket needs developers focus sooner rather than later. The > implications of this patch mean it's not acceptable for this patch to > sit in the queue - it needs to be fast-tracked. Could somebody provide some unit tests that isolate the problem? I've never mucked with the GenericForeignKey code -- perhaps Jacob or Russell could chime in here for the fix? Adrian -- Adrian Holovaty holovaty.com | djangoproject.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
