Re: Okay to use form field labels in admin history?

2015-08-26 Thread Ramez Ashraf 
Yes it worked well enough for over then it should be.
So yes i would love to give it a try.

So we will be storing json as string in the database? or what would be the 
recommended path to go about this ?!



On Wednesday, August 26, 2015 at 3:34:31 PM UTC+2, Tim Graham wrote:
>
> The current approach has worked "well enough" for 10 years. I think we can 
> wait a little longer for a better solution rather than change the message 
> format twice. Want to give it a try?
>
> On Tuesday, August 25, 2015 at 11:07:45 AM UTC-4, Ramez Ashraf wrote:
>>
>> Dear devs 
>> I'm the PR mentioned contributor. 
>> While I understand your concern about translated content in the database 
>> and the other ticket mentioned (having the info stored as Json or yaml) 
>> I see that these are different ways and are not mutually exclusive. 
>> The issue mentioned regards having multiple supported languages, while 
>> what the PR is solving is the simple "not english " site + the idea of 
>> having a customized label or clear verbose name instead of the current 
>> field name. 
>>
>> IMHO, I think this pull is a step forward. And when the issue mentioned 
>> is solved in an enhancement of the log structure, the old structure will 
>> continue to exist for backword compatibility. 
>>
>> I call -if I may- a reconsideration. :) 
>>
>> Last, I'm making extensive use of the admin in my work.. Hopefully I'll 
>> be around contributing in it. 
>>
>> Kind regards
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/5728679c-4181-48fa-b76f-1008d3c038eb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Okay to use form field labels in admin history?

2015-08-26 Thread Tim Graham 
The current approach has worked "well enough" for 10 years. I think we can 
wait a little longer for a better solution rather than change the message 
format twice. Want to give it a try?

On Tuesday, August 25, 2015 at 11:07:45 AM UTC-4, Ramez Ashraf wrote:
>
> Dear devs 
> I'm the PR mentioned contributor. 
> While I understand your concern about translated content in the database 
> and the other ticket mentioned (having the info stored as Json or yaml) 
> I see that these are different ways and are not mutually exclusive. 
> The issue mentioned regards having multiple supported languages, while 
> what the PR is solving is the simple "not english " site + the idea of 
> having a customized label or clear verbose name instead of the current 
> field name. 
>
> IMHO, I think this pull is a step forward. And when the issue mentioned is 
> solved in an enhancement of the log structure, the old structure will 
> continue to exist for backword compatibility. 
>
> I call -if I may- a reconsideration. :) 
>
> Last, I'm making extensive use of the admin in my work.. Hopefully I'll be 
> around contributing in it. 
>
> Kind regards

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/b42297c7-c3bc-4834-8323-579115535854%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Okay to use form field labels in admin history?

2015-08-25 Thread Ramez Ashraf 
Dear devs
I'm the PR mentioned contributor.
While I understand your concern about translated content in the database and 
the other ticket mentioned (having the info stored as Json or yaml)
I see that these are different ways and are not mutually exclusive.
The issue mentioned regards having multiple supported languages, while what the 
PR is solving is the simple "not english " site + the idea of having a 
customized label or clear verbose name instead of the current field name.

IMHO, I think this pull is a step forward. And when the issue mentioned is 
solved in an enhancement of the log structure, the old structure will continue 
to exist for backword compatibility. 

I call -if I may- a reconsideration. :) 

Last, I'm making extensive use of the admin in my work.. Hopefully I'll be 
around contributing in it.

Kind regards

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/b1f74548-a324-46a1-a126-06b7830b809e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Okay to use form field labels in admin history?

2015-08-25 Thread Claude Paroz 
On Tuesday, August 25, 2015 at 1:48:55 AM UTC+2, Tim Graham wrote:
>
> Do you like the idea to use form field labels in the admin history 
> messages instead of the form field names themselves?
>
> It's been implemented here:
> https://github.com/django/django/pull/5169 
> 
>
> One consideration is that the messages are generated/stored in the current 
> language so this could increase confusion in multilingual environments 
> until this issue is addressed:
> https://code.djangoproject.com/ticket/21113
>
> I'm not sure if we should block the current pull request on that ticket or 
> not.
>

I think that the correct way would be to fix #21113 first. Having transated 
content in the database looks like a bad idea in the first place.

Claude

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/2a6dd4ea-27a5-4fc8-88a2-42f9cccd018a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.