Re: Pertaining the 4.2.6 release's "recreate indexes" footnote

['Adam Johnson' via Django developers (Contributions to Django itself)]

I’ve created a PR with a suggested improvement: 
https://github.com/django/django/pull/17359 .

On Thu, Oct 12, 2023, at 5:09 AM, Mariusz Felisiak wrote:
> > Thoughts on this?
> 
> Documentation improvements are always welcome, you can send your proposition 
> via GitHub PR.
> 
> Best,
> Mariusz
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/5088719c-22e9-40b5-9585-a1a2bfd39ec1n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/8dedd63f-927c-4839-a1b8-6573c04a11df%40app.fastmail.com.

Re: Pertaining the 4.2.6 release's "recreate indexes" footnote

[Mariusz Felisiak]

> Thoughts on this?

Documentation improvements are always welcome, you can send your 
proposition via GitHub PR.

Best,
Mariusz

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/5088719c-22e9-40b5-9585-a1a2bfd39ec1n%40googlegroups.com.

Re: Pertaining the 4.2.6 release's "recreate indexes" footnote

[Michael]

Pardon, @Mariusz, I didn't mean to specify "non-text fields" - I had 
re-worded that sentence before posting.

On Wednesday, October 11, 2023 at 2:29:58 AM UTC-4 Mariusz Felisiak wrote:

> My immediate thought is that any indexes on non-text fields, created with 
> these versions, will be useless in ORM-based queries. If that's the case, 
> this seems like a much bigger deal than the footnote would imply.
>
>
> I'm puzzled. Why you assumed that all non-string based fields are 
> affected? Release note explicitly specifies what kind of indexes are 
> affected:
>
> Indexes *"on string based fields (CharField, EmailField, TextField, 
> CICharField, CIEmailField, and CITextField) used with the __isnull lookup 
> on PostgreSQL".*
>
> Do you it's worth mentioning again after *"You may need to recreate 
> indexes.."?* For example
>
> *"You may need to recreate indexes on string based fields (CharField, 
> EmailField, TextField, CICharField, CIEmailField, and CITextField) used 
> with the __isnull lookup propagated to the PostgreSQL database with Django 
> 4.2 - 4.2.5, as they contain unnecessary ::text casting that is avoided as 
> of this release."*
>
> Best,
> Mariusz
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/726c4a23-6795-4e8e-aa4e-238b9ab2dba1n%40googlegroups.com.

Re: Pertaining the 4.2.6 release's "recreate indexes" footnote

[Mariusz Felisiak]

My immediate thought is that any indexes on non-text fields, created with 
these versions, will be useless in ORM-based queries. If that's the case, 
this seems like a much bigger deal than the footnote would imply.


I'm puzzled. Why you assumed that all non-string based fields are affected? 
Release note explicitly specifies what kind of indexes are affected:

Indexes *"on string based fields (CharField, EmailField, TextField, 
CICharField, CIEmailField, and CITextField) used with the __isnull lookup 
on PostgreSQL".*

Do you it's worth mentioning again after *"You may need to recreate 
indexes.."?* For example

*"You may need to recreate indexes on string based fields (CharField, 
EmailField, TextField, CICharField, CIEmailField, and CITextField) used 
with the __isnull lookup propagated to the PostgreSQL database with Django 
4.2 - 4.2.5, as they contain unnecessary ::text casting that is avoided as 
of this release."*

Best,
Mariusz

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/a6a82877-eb21-45a7-bc1c-6fe055aaa650n%40googlegroups.com.

Re: Pertaining the 4.2.6 release's "recreate indexes" footnote

[אורי]

Hi,

I also think a more specific documentation as to how to fix this issue is
required.

I usually upgrade Django about 6 months after the initial major release,
which is this month. But because of this issue I decided to wait 2 more
months.

Thanks,
Uri.
אורי
u...@speedy.net


On Wed, Oct 11, 2023 at 12:32 AM Michael  wrote:

> The release notes on https://docs.djangoproject.com/en/dev/releases/4.2.6/
> contain:
>
> > You may need to recreate indexes propagated to the database with Django
> 4.2 - 4.2.5 as they contain unnecessary ::text casting that is avoided as
> of this release.
>
> This doesn't give much context or give any guidance on how best to handle
> this, whether Django could help, etc.
>
> It also doesn't clarify why this is a "may need to" situation. Were Django
> versions 4.2-4.2.5 randomly doing this from time to time, or is this
> actually "you definitely do need to" situation; or is only relevant in
> specific scenarios?
>
> My immediate thought is that any indexes on non-text fields, created with
> these versions, will be useless in ORM-based queries. If that's the case,
> this seems like a much bigger deal than the footnote would imply.
>
> Thoughts on this?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/e686415b-0c4b-4643-8d0f-707aa859992bn%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CABD5YeGKoznt-svAZkc8kCXnJLQXT8qdUh5KxNpKrVMChDozwA%40mail.gmail.com.