Re: Should django-admin allow specifying hidden directories for --template?

2021-01-01 Thread laym...@gmail.com
Finally got around to create a ticket for this: 
https://code.djangoproject.com/ticket/32309

I've also created a PoC with a new --directory option: 
https://github.com/django/django/pull/13827

Sage

On Thursday, 1 October 2020 at 21:14:51 UTC+7 re...@fleschenberg.net wrote:

> Hi,
>
> On 01.10.20 15:56, laym...@gmail.com wrote:
> > Thanks for the feedback! From my observations, Django does not ignore 
> > hidden /files/,
> > it only ignores hidden /directories/. So, the files that you listed 
> > should work fine.
>
> Ah, my bad, sorry.
>
> > As for the built-in exclusion list, I'm not sure if we should add that. 
> > I think ignoring .git
> > by default is fine, but we shouldn't assume that people would like to 
> > ignore .coverage.
>
> Hmmm, you mean because other tools besides 
> https://pypi.org/project/coverage/ might use that path? I guess that 
> could happen, yup.
>
> > Regarding exclusion vs inclusion... I'm not sure what the best option 
> > is, though! :)
>
> I think I prefer explicit exclusion by the user (except for obvious 
> cases like .git and __pycache__) because it's less surprising.
>
> René
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/1985ff35-48b6-4fa4-8c5d-d085eb3c7b86n%40googlegroups.com.


Re: Should django-admin allow specifying hidden directories for --template?

2020-10-01 Thread René Fleschenberg

Hi,

On 01.10.20 15:56, laym...@gmail.com wrote:
Thanks for the feedback! From my observations, Django does not ignore 
hidden /files/,
it only ignores hidden /directories/. So, the files that you listed 
should work fine.


Ah, my bad, sorry.

As for the built-in exclusion list, I'm not sure if we should add that. 
I think ignoring .git
by default is fine, but we shouldn't assume that people would like to 
ignore .coverage.


Hmmm, you mean because other tools besides 
https://pypi.org/project/coverage/ might use that path? I guess that 
could happen, yup.


Regarding exclusion vs inclusion... I'm not sure what the best option 
is, though! :)


I think I prefer explicit exclusion by the user (except for obvious 
cases like .git and __pycache__) because it's less surprising.


René

--
You received this message because you are subscribed to the Google Groups "Django 
developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/da363f4b-740d-0300-2c73-31f6ba3b7ac9%40fleschenberg.net.


Re: Should django-admin allow specifying hidden directories for --template?

2020-10-01 Thread laym...@gmail.com
Hi René,

Thanks for the feedback! From my observations, Django does not ignore 
hidden *files*,
it only ignores hidden *directories*. So, the files that you listed should 
work fine.

As for the built-in exclusion list, I'm not sure if we should add that. I 
think ignoring .git
by default is fine, but we shouldn't assume that people would like to 
ignore .coverage.

Regarding exclusion vs inclusion... I'm not sure what the best option is, 
though! :)

Sage


On Thursday, 1 October 2020 at 20:47:48 UTC+7 re...@fleschenberg.net wrote:

> Hi,
>
> I can see several use-cases for hidden files / directories in a project 
> template. Here are some examples from one of my current projects:
>
> .coveragerc
> .editorconfig
> .flake8
> .gitignore
> .gitlab-ci.yml
> .isort.cfg
>
> Instead of introducing a command line option to explicitly include 
> things, can we replace the current behavior with a built-in exclusion 
> list? And maybe an --exclude option to exclude additional things?
>
> Candidates for the exclusion list that come to my mind:
>
> __pycache__
> .git
> .coverage
>
> Regards,
> René
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/3f5fd60d-f830-4353-ae94-ce1649a6889an%40googlegroups.com.


Re: Should django-admin allow specifying hidden directories for --template?

2020-10-01 Thread René Fleschenberg

Hi,

I can see several use-cases for hidden files / directories in a project 
template. Here are some examples from one of my current projects:


.coveragerc
.editorconfig
.flake8
.gitignore
.gitlab-ci.yml
.isort.cfg

Instead of introducing a command line option to explicitly include 
things, can we replace the current behavior with a built-in exclusion 
list? And maybe an --exclude option to exclude additional things?


Candidates for the exclusion list that come to my mind:

__pycache__
.git
.coverage

Regards,
René

--
You received this message because you are subscribed to the Google Groups "Django 
developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/904d1155-edf9-c7f2-23b9-59eaf6f82240%40fleschenberg.net.