Re: django.utils.version.get_version() discrepancy for Python 2 vs. Python 3

2015-11-18 Thread Aymeric Augustin 
Considering the information provided by Donald, it’s pretty clear to me that we 
should switch to rc as proposed by Tim.

-- 
Aymeric.



> On 18 nov. 2015, at 01:26, Tim Graham  wrote:
> 
> Thanks Donald, updating setuptools was the factor I missed, not Python 2 vs. 
> 3.
> 
> On Tuesday, November 17, 2015 at 5:06:59 PM UTC-5, Donald Stufft wrote:
> 
>> On Nov 17, 2015, at 12:00 PM, Tim Graham  
>> wrote:
>> 
>> There was a small hiccup with the 1.9 release candidate yesterday. Unless 
>> there is some other conflating factor that I missed, generating release 
>> packages using Python 2 will yield a name like "Django-1.9c1.tar.gz" while 
>> Python 3 yields "Django-1.9rc1.tar.gz" ('rc' instead of 'c'). Yesterday's 
>> release must have been the first release candidate to be generated using 
>> Python 3, and this broke the download page because 
>> django.utils.version.get_version() (which the website uses) returns "c1" for 
>> the file name instead of "rc1". I put in a (perhaps temporary) fix to 
>> correct this: https://github.com/django/djangoproject.com/pull/547 
>> 
>> 
>> Do you think it's correct to make the change in Django itself? 
>> https://github.com/django/django/pull/5676 
>>  -- I didn't track down the 
>> reason why this changed in Python.
>> While get_version() isn't a public API, it's widely used according to GitHub 
>> search.
>> 
> 
> Whoever generated the tarballs is probably using a version of setuptools 
> older than 8.0 in their Python 2 environment and a version of setuptools 
> newer than 8.0 in their Python 3 environment.
> 
> 
> -
> Donald Stufft
> PGP: 0x6E3CBCE93372DCFA // 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to django-developers+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to django-developers@googlegroups.com 
> .
> Visit this group at http://groups.google.com/group/django-developers 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/e02a697f-36c4-4604-b484-1907919a6a54%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/72652A2A-292E-4303-ACCE-8BB1104196B0%40polytechnique.org.
For more options, visit https://groups.google.com/d/optout.

Re: django.utils.version.get_version() discrepancy for Python 2 vs. Python 3

2015-11-17 Thread Tim Graham 
Thanks Donald, updating setuptools was the factor I missed, not Python 2 
vs. 3.

On Tuesday, November 17, 2015 at 5:06:59 PM UTC-5, Donald Stufft wrote:
>
>
> On Nov 17, 2015, at 12:00 PM, Tim Graham  
> wrote:
>
> There was a small hiccup with the 1.9 release candidate yesterday. Unless 
> there is some other conflating factor that I missed, generating release 
> packages using Python 2 will yield a name like "Django-1.9c1.tar.gz" while 
> Python 3 yields "Django-1.9rc1.tar.gz" ('rc' instead of 'c'). Yesterday's 
> release must have been the first release candidate to be generated using 
> Python 3, and this broke the download page because 
> django.utils.version.get_version() (which the website uses) returns "c1" 
> for the file name instead of "rc1". I put in a (perhaps temporary) fix to 
> correct this: https://github.com/django/djangoproject.com/pull/547
>
> Do you think it's correct to make the change in Django itself? 
> https://github.com/django/django/pull/5676 -- I didn't track down the 
> reason why this changed in Python.
> While get_version() isn't a public API, it's widely used according to 
> GitHub search.
>
>
> Whoever generated the tarballs is probably using a version of setuptools 
> older than 8.0 in their Python 2 environment and a version of setuptools 
> newer than 8.0 in their Python 3 environment.
>
>
> -
> Donald Stufft
> PGP: 0x6E3CBCE93372DCFA // 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 
> DCFA 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/e02a697f-36c4-4604-b484-1907919a6a54%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: django.utils.version.get_version() discrepancy for Python 2 vs. Python 3

2015-11-17 Thread Donald Stufft 

> On Nov 17, 2015, at 12:00 PM, Tim Graham  wrote:
> 
> There was a small hiccup with the 1.9 release candidate yesterday. Unless 
> there is some other conflating factor that I missed, generating release 
> packages using Python 2 will yield a name like "Django-1.9c1.tar.gz" while 
> Python 3 yields "Django-1.9rc1.tar.gz" ('rc' instead of 'c'). Yesterday's 
> release must have been the first release candidate to be generated using 
> Python 3, and this broke the download page because 
> django.utils.version.get_version() (which the website uses) returns "c1" for 
> the file name instead of "rc1". I put in a (perhaps temporary) fix to correct 
> this: https://github.com/django/djangoproject.com/pull/547 
> 
> 
> Do you think it's correct to make the change in Django itself? 
> https://github.com/django/django/pull/5676 
>  -- I didn't track down the 
> reason why this changed in Python.
> While get_version() isn't a public API, it's widely used according to GitHub 
> search.
> 

Whoever generated the tarballs is probably using a version of setuptools older 
than 8.0 in their Python 2 environment and a version of setuptools newer than 
8.0 in their Python 3 environment.


-
Donald Stufft
PGP: 0x6E3CBCE93372DCFA // 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/F8D9E8C5-852C-4BDF-A8E9-C3D91CFA7972%40stufft.io.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: django.utils.version.get_version() discrepancy for Python 2 vs. Python 3

2015-11-17 Thread Donald Stufft 

> On Nov 17, 2015, at 3:03 PM, Aymeric Augustin 
>  wrote:
> 
> On 17 nov. 2015, at 18:00, Tim Graham  > wrote:
> 
>> Do you think it's correct to make the change in Django itself? 
>> https://github.com/django/django/pull/5676 
>>  -- I didn't track down the 
>> reason why this changed in Python.
> 
> 
> 
> Per PEP 386, the standard scheme is ‘c’, although ‘rc’ is acceptable as well.

PEP 386 has been superseded by PEP 440 which recommends “rc” because almost 
everyone was using “rc” and not “c”. It didn’t seem reasonable to have a 
decision which was solely bike shedding (it can handle rc as easily as it can 
handle c) to favor an option that flew in the face of what most projects were 
doing.

-
Donald Stufft
PGP: 0x6E3CBCE93372DCFA // 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/D79091CB-743C-4D96-8CAF-29718BDA61D9%40stufft.io.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: django.utils.version.get_version() discrepancy for Python 2 vs. Python 3

2015-11-17 Thread Aymeric Augustin 
On 17 nov. 2015, at 18:00, Tim Graham  wrote:

> Do you think it's correct to make the change in Django itself? 
> https://github.com/django/django/pull/5676 
>  -- I didn't track down the 
> reason why this changed in Python.



Per PEP 386, the standard scheme is ‘c’, although ‘rc’ is acceptable as well.

> Pre-releases can use a for "alpha", b for "beta" and c for "release 
> candidate". rc is an alternative notation for "release candidate" that is 
> added to make the version scheme compatible with Python's own version scheme. 
> rc sorts after c.

We can take this opportunity to change the naming scheme to what Python 3 
generates by default. We just have to be careful not to generate releases with 
Python 2 from now on. I suggest to add something in the release checklist 
(assuming you still follow it when making releases, perhaps you know it by 
heart by now).

-- 
Aymeric.



-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/34D2A435-48DA-47E2-A86F-FE5BF351%40polytechnique.org.
For more options, visit https://groups.google.com/d/optout.