date:20131009

Re: [Django] #21251: Not all database backends support grouping by a column number

2013-10-09 Thread Django

#21251: Not all database backends support grouping by a column number
-+-
 Reporter:  manfre   |Owner:  manfre
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  mssql|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by russellm):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I'm moderately surprised that Django does this -- firstly because I wasn't
 aware it was valid SQL in the first place, but secondly because I don't
 remember implementing anything like that when I committed the aggregation
 codebase. It's entirely possible something has changed since I last looked
 at the code, but it doesn't strike me as a very "Django" thing to find in
 a codebase.

 Can you give a specific example of a query (ideally one in Django's test
 suite) that does this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.70e8b34b77554a0ec363e556a504a117%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21254: Random memcache error

2013-10-09 Thread Django

#21254: Random memcache error
-+-
 Reporter:  azurit   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  1.5
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  memcache | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timo):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => invalid
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 Please see
 https://code.djangoproject.com/wiki/TicketClosingReasons/UseSupportChannels

 If you believe this is a bug in Django, we'll need more details to
 reproduce this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.421eab8ab40960a15598ea3aaaf9181e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21254: Random memcache error

2013-10-09 Thread Django

#21254: Random memcache error
-+--
 Reporter:  azurit   |  Owner:  nobody
 Type:  Bug  | Status:  new
Component:  Core (Cache system)  |Version:  1.5
 Severity:  Normal   |   Keywords:  memcache
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+--
 Hi,

 i'm getting this error randomly after upgrading to python2.7 (from 2.6):


 {{{
 Traceback (most recent call last):
   File "/usr/local/lib/python2.7/dist-
 packages/Django-1.5.4-py2.7.egg/django/http/response.py", line 236, in
 close
 signals.request_finished.send(sender=self._handler_class)
   File "/usr/local/lib/python2.7/dist-
 packages/Django-1.5.4-py2.7.egg/django/dispatch/dispatcher.py", line 170,
 in send
 response = receiver(signal=self, sender=sender, **named)
   File "/usr/local/lib/python2.7/dist-
 packages/Django-1.5.4-py2.7.egg/django/core/cache/backends/memcached.py",
 line 89, in close
 self._cache.disconnect_all()
   File "/usr/lib/python2.7/dist-packages/memcache.py", line 344, in
 disconnect_all
 for s in self.servers:
 AttributeError: 'Client' object has no attribute 'servers'
 }}}


 Any ideas?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.bbd22c1ff7d7f278c7224f707fc95942%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19740: Make sure only posts not marked as defunct show up in feed

2013-10-09 Thread Django

#19740: Make sure only posts not marked as defunct show up in feed
-+
 Reporter:  aaugustin|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  *.djangoproject.com  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timo):

 From brutasse on [https://github.com/django/djangoproject.com/pull/54 this
 pull request]:

   the code only takes `approval_status` into account. Instead of marking
 feeds as defunct, their approval status should be set to 'denied'.

   The `is_defunct` flag could probably be deleted completely. I believe it
 was used when dp.com was doing the polling.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cec1a14dfa19da23b12a72df7e0faa63%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20928: djangoproject.com is no longer picking up the Django Packages RSS feed

2013-10-09 Thread Django

#20928: djangoproject.com is no longer picking up the Django Packages RSS feed
-+
 Reporter:  pydanny  |Owner:  jezdez
 Type:  Bug  |   Status:  assigned
Component:  *.djangoproject.com  |  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * has_patch:  0 => 1


Comment:

 Bruno says [https://github.com/django/djangoproject.com/pull/54 this PR]
 should fix the issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a613e1d5e42cba9406ba3ac10c49a340%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

2013-10-09 Thread Django

#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  File |  Version:  master
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1
 * easy:  0 => 1


Comment:

 Patch needs to be updated to apply cleanly and the change should be
 mentioned in the release notes (docs/releases/1.7.txt). These changes
 should be suitable for a first-time committer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1b376e53a98782d9ce128a8e5e5fdd07%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 8765ed: [1.6.x] Updated auth translation template

2013-10-09 Thread GitHub

  Branch: refs/heads/stable/1.6.x
  Home:   https://github.com/django/django
  Commit: 8765eddf2e8470b2d359ea8c4c55ee009b89dbcb
  
https://github.com/django/django/commit/8765eddf2e8470b2d359ea8c4c55ee009b89dbcb
  Author: Claude Paroz 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M django/contrib/auth/locale/en/LC_MESSAGES/django.po

  Log Message:
  ---
  [1.6.x] Updated auth translation template



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52559eed39376_7bbed5fd5414685d%40hookshot-fe4-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21021: Default geom_type attribute for GeometryWidget should be "Geometry", not "Unknown"

2013-10-09 Thread Django

#21021: Default geom_type attribute for GeometryWidget should be "Geometry", not
"Unknown"
-+-
 Reporter:  leplatrem|Owner:
 Type:   |  EricBoersma
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:
 Severity:  Normal   |  1.6-beta-1
 Keywords:  minor|   Resolution:
Has patch:  1| Triage Stage:  Ready for
  Needs tests:  0|  checkin
Easy pickings:  0|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timo):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 Eric, don't forget to link to your PR from the ticket and check "Has
 patch" so it's picked up for review.

 Here's [https://github.com/django/django/pull/1568 Eric's PR]. It looks
 good to me but I'll let Claude or something more familiar with GeoDjango
 do a final review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c3fc4f71330725e643f8636e19cf85db%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14226: Bug in dumpdata dependency calculation involving ManyToManyFields

2013-10-09 Thread Django

#14226: Bug in dumpdata dependency calculation involving ManyToManyFields
-+-
 Reporter:  aneil|Owner:  koirikivi
 Type:  Bug  |   Status:  assigned
Component:  Core |  Version:  1.2
  (Serialization)|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  easy-pickings|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.efba098398267964f8e727e27ce97d09%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20477: Allow list of modules for FORMAT_MODULE_PATH

2013-10-09 Thread Django

#20477: Allow list of modules for FORMAT_MODULE_PATH
-+-
 Reporter:  mbrochh  |Owner:  mbrochh
 Type:  New feature  |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  localization,|  Needs documentation:  0
  format files   |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0a210ae417393010a0c51f3f0ce196bb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21253: PBKDF2 with cached HMAC key

2013-10-09 Thread Django

#21253: PBKDF2 with cached HMAC key
+
   Reporter:  timo  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.auth  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 50% faster than our implementation according to the
 [https://github.com/django/django/pull/1638 pull request].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.5a112e568677a85e5bda8f2a2c922f09%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21240: Breaking change regarding select_related+OneToOneField missing from release notes

2013-10-09 Thread Django

#21240: Breaking change regarding select_related+OneToOneField missing from 
release
notes
-+
 Reporter:  marcin@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:  breaking change  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by akaariai):

 * stage:  Unreviewed => Accepted


Comment:

 A quick mention in backwards incompatible changes seems OK to me.
 Miscellaneous is probably the right place.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.9d76a062a34debf9cbe795575e40d5e3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20863: Clarify which session backends require django.contrib.sessions in INSTALLED_APPS (was: Sessions backend changing could be clearer)

2013-10-09 Thread Django

#20863: Clarify which session backends require django.contrib.sessions in
INSTALLED_APPS
-+-
 Reporter:  Keryn Knight |Owner:  nobody
   |   Status:  new
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Documentation| Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by timo):

 As far as I can tell, only `db` and `cached_db` require the
 `INSTALLED_APPS` entry.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.e8f9bf8d272566c8917ef6710163949e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20222: Some functions are wrapped into allow_lazy incorrectly

2013-10-09 Thread Django

#20222: Some functions are wrapped into allow_lazy incorrectly
---+-
 Reporter:  void   |Owner:  bmispelon
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timo):

 * needs_better_patch:  0 => 1
 * easy:  1 => 0


Comment:

 No longer merges cleanly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.f5b21ac68f889c66312c375897f73f58%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19139: OpenLayersWidget's 'Delete all Features' control doesn't respect GeoModelAdmin's modifiable attribute

2013-10-09 Thread Django

#19139: OpenLayersWidget's 'Delete all Features' control doesn't respect
GeoModelAdmin's modifiable attribute
+
 Reporter:  fcurella|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  gis admin template  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  1
+
Changes (by timo):

 * easy:  1 => 0


Comment:

 Patch no longer applies cleanly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.855ad79647eb7019d57581eb559cad9d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18314: request.build_absolute_uri() functions incorrectly when the path starts with //

2013-10-09 Thread Django

#18314: request.build_absolute_uri() functions incorrectly when the path starts
with //
---+
 Reporter:  anonymous  |Owner:  susan
 Type:  Bug|   Status:  assigned
Component:  HTTP handling  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6b0648b6d198d71c117451ba89cb8594%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21222: document that ./runtests.py must use different databases for 'default' and 'other'.

2013-10-09 Thread Django

#21222: document that ./runtests.py must use different databases for 'default' 
and
'other'.
-+-
 Reporter:  vernondcole  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Testing framework|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:  runtests infinite|  Unreviewed
  wait   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9700194195735300f86803b0d023a37a89f4dff0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9700194195735300f86803b0d023a37a89f4dff0"
 Fixed #21222 - Documented that 'default' and 'other' must be different
 databases when running tests.

 Thanks vernondcole for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.690f7c3a53b488ae9798f4376c078840%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21252: Positional column numbers is not always correct for ORDER BY and GROUP BY

2013-10-09 Thread Django

#21252: Positional column numbers is not always correct for ORDER BY and GROUP
BY
--+
Reporter: manfre| Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) |Version: master
Severity: Normal| Keywords:
Triage Stage: Unreviewed| Has patch: 0
Easy pickings: 0 | UI/UX: 0
--+
"SELECT ... GROUP BY 1 ORDER BY 1" is very fragile and may not associate
with the intended column if any columns are front loaded on to the select.
Columns are front loaded by extra() and could be added by 3rd party
database backends.

There are discussions of no longer front loading the extra() select
columns. Assuming this change happens, the problem space would be reduced
to just 3rd party backends, which would need some way to know that there
are positional values in the query or would need an easier way of
injecting columns in to the select without resorting to the simple front
loading.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/049.833bc3d3af1fa134f772eb6a977fac97%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21250: Make Remote User tests more flexible

2013-10-09 Thread Django

#21250: Make Remote User tests more flexible
--+
 Reporter:  elbarto   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I would say that our tests probably shouldn't be considered a stable API
 that you can re-use, but if cleaning things up by making them more DRY has
 the benefit of allowing you to use them and you are willing to submit a
 patch, it seems ok.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b5c98259c16be67bb1dcc1b86080bdce%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21249: Typo in SQLCompiler.get_grouping()

2013-10-09 Thread Django

#21249: Typo in SQLCompiler.get_grouping()
-+-
 Reporter:  manfre   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by manfre):

 From IRC:
 {{{
  This seems incorrect.
 
https://github.com/django/django/blob/master/django/db/models/sql/compiler.py#L578
  Based upon the comment, shouldn't it check order_params instead
 of params?
  manfre: good catch. I have a strange feeling I know who is
 going to get git blame'd for that.
  and yes, it was me...

 ...

  manfre: the params -> order_params seems like an easy change,
 so that separately
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b0d53163f7c57ebfb9b0ea8cd4e2b66e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21234: DATABASES['other']['TEST_NAME'] is ignored is some situations.

2013-10-09 Thread Django

#21234: DATABASES['other']['TEST_NAME'] is ignored is some situations.
---+--
 Reporter:  vernondcole|Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timo):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 It seems likely you are running into #16969 which suggests to avoid
 selecting the production database prior to test database setup/teardown.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.07944baf8d1aff3f76c2654aa0e75dea%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19536: in ModelAdmin disabling has_add_permission results in not showing any object-tools

2013-10-09 Thread Django

#19536: in ModelAdmin disabling has_add_permission results in not showing any
object-tools
--+
 Reporter:  a.fazeli@…|Owner:  ikks
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.1e73235f21d4eed1238f9faebf77c97e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 970019: Fixed #21222 - Documented that 'default' and 'othe...

2013-10-09 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 9700194195735300f86803b0d023a37a89f4dff0
  
https://github.com/django/django/commit/9700194195735300f86803b0d023a37a89f4dff0
  Author: Tim Graham 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M docs/internals/contributing/writing-code/unit-tests.txt

  Log Message:
  ---
  Fixed #21222 - Documented that 'default' and 'other' must be different 
databases when running tests.

Thanks vernondcole for the suggestion.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/525579bdced61_7bbed5fd541285bc%40hookshot-fe4-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20885: Clarify who is in copy for the various mailboxes of the foundation.

2013-10-09 Thread Django

#20885: Clarify who is in copy for the various mailboxes of the foundation.
--+
 Reporter:  loic84|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  *.djangoproject.com   |  Version:
 Severity:  Normal|   Resolution:
 Keywords:  foundation| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Description changed by timo:

Old description:

> Example of such mailboxes:
>
> - https://www.djangoproject.com/contact/foundation/
>
> - c...@djangoproject.com

New description:

 Would be helpful to clarify:

 1. what audience receives mail from the "Contact the Django Software
 Foundation" contact form:
 https://www.djangoproject.com/contact/foundation/

 2. what the expected response to submitting a CLA to c...@djangoproject.com
 is. i.e. expect to receive a confirmation email with x days? I see that
 the profiles on djangoproject.com have a "CLA" attribute, e.g.
 https://www.djangoproject.com/~jacob/ but Loic and I don't have this badge
 and I know we've both submitted CLAs so I'm not sure it's maintained.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cc2a08e5143e2634290413165282177a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21251: Not all database backends support grouping by a column number

2013-10-09 Thread Django

#21251: Not all database backends support grouping by a column number
--+
 Reporter:  manfre|  Owner:  manfre
 Type:  New feature   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:  mssql
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 "SELECT ... GROUP BY 1" is not valid for all databases. This can happen in
 ORM generated queries when Django moves anything found in the ORDER BY
 over to the GROUP BY. E.g. "SELECT ... ORDER BY 1".

 There are two ways of proceeding:

 '''1. Don't promote the positional value from ORDER BY to GROUP BY, if the
 database doesn't support it.'''

 It's possible that not including the positional values from the GROUP BY
 will cause different backends (those that support positional columns and
 those that do not) to return different results for certain queries. I
 cannot think of any example queries and the only usage of positional
 columns that I've noticed in the test suite are due to "ORDER BY 1". This
 change allows django-mssql to pass many aggregation and aggregation_regres
 tests that it previously failed with an error.

 This change is trivial and contained to a few lines in
 SQLCompiler.get_grouping().

 '''2. Look up the appropriate entry from the select by its position
 (indexed from 1, not 0) and include the select + params in the GROUP BY,
 instead of the position number.'''

 This will not generate the correct query in all situations, but it should
 generate a valid query for the backend. Depending on the specifics of the
 query and how columns are front loaded to the select, it's quite possible
 that the intended ORDER BY position no longer lines up with the desired
 position when attempting to do the look up for GROUP BY.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.4956a71818211c74709837fb2a47e398%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21250: Make Remote User tests more flexible

2013-10-09 Thread Django

#21250: Make Remote User tests more flexible
--+
 Reporter:  elbarto   |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Testing framework |Version:  1.5
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 I recently had to implement my own middleware with a custom HTTP header,
 not REMOTE_USER, like:

 {{{
 from django.contrib.auth.middleware import RemoteUserMiddleware

 class MyRemoteUserMiddleware(RemoteUserMiddleware):
 header = 'MY_HTTP_AUTHUSER'
 }}}

 This is perfect, but then I needed to test my code, so my first idea was
 to inherit from Django tests overriding my middleware config (I don't know
 if it's a bad idea) like:

 {{{
 from django.contrib.auth.tests import RemoteUserTest

 class MyRemoteUserTest(RemoteUserTest):
 middleware = 'path.to.MyRemoteUserMiddleware'
 }}}

 since it would save me to write a lot of code.

 The problem is that all tests in such module (
 
https://github.com/django/django/blob/master/django/contrib/auth/tests/test_remote_user.py
 ) are dependent for REMOTE_USER, because of many REMOTE_USER keywords are
 passed to self.client.get() and I was forced to duplicate all the code
 simply changing REMOTE_USER keyword for my header.

 I think it would be great if it could be more flexible.

 I was thinking about something like:

 {{{
 from django.contrib.auth.tests import RemoteUserTest

 class MyRemoteUserTest(RemoteUserTest):
 middleware = 'path.to.MyRemoteUserMiddleware'
 header = 'MY_HTTP_AUTHUSER'
 }}}

 and then changing:

 {{{
 response = self.client.get('/remote_user/', REMOTE_USER=None)
 }}}

 for:
 {{{
 response = self.client.get('/remote_user/', **{self.header: None})
 }}}

 in all calls.

 Or maybe instantiate the middleware (I don't know if it's possible) and
 getting its self.header.

 It would make a lot of easier to implement tests (without duplicating
 code) when is needed to change the header for the Remote User middleware.

 If it were accepted I could code the patch myself.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.f16b5e700461915601f7942079834ac2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21249: Typo in SQLCompiler.get_grouping()

2013-10-09 Thread Django

#21249: Typo in SQLCompiler.get_grouping()
-+-
 Reporter:  manfre   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * easy:  1 => 0
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.db71673bd95c6d877df8061628aff183%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19224: Documentation version switcher obscures footer (was: The documentation version switcher)

2013-10-09 Thread Django

#19224: Documentation version switcher obscures footer
-+
 Reporter:  aruseni  |Owner:  graup
 Type:  Bug  |   Status:  assigned
Component:  *.djangoproject.com  |  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+
Changes (by timo):

 * easy:  1 => 0


Comment:

 The JSS/CSS fix here seems like overkill. How about if we just break the
 footer text into multiple lines so the switcher won't collide for most
 resolutions?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7f0c4da4cbc6a5102a43bbb61e50822e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20292: Django 1.5.1: ORA-01843: not a valid month

2013-10-09 Thread Django

#20292: Django 1.5.1: ORA-01843: not a valid month
-+-
 Reporter:  CarstenF |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.5
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  Oracle, cx_oracle,   |  Needs documentation:  0
  unicode|  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by anonymous):

 Thanks for posting the patch. I've tested it on several systems, but
 unfortunately, it doesn't seem to make a difference: also with the patch
 applied, we observe the same problem as originally reported.

 Best regards,
 Carsten

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.faa325406a389bad9e1dd3b8ac717402%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21249: Typo in SQLCompiler.get_grouping()

2013-10-09 Thread Django

#21249: Typo in SQLCompiler.get_grouping()
-+-
 Reporter:  manfre   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by manfre):

 * needs_better_patch:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * easy:  0 => 1
 * needs_docs:   => 0


Comment:

 https://github.com/django/django/pull/1721

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fdabb4437142d677e6ff3958c5cb628e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19924: Some jQuery selectors in actions.js use hardcoded values instead of pulling from options.

2013-10-09 Thread Django

#19924: Some jQuery selectors in actions.js use hardcoded values instead of 
pulling
from options.
---+
 Reporter:  anonymous  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  javascript | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4523fcd60101124a307bd4026296337087b66884"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4523fcd60101124a307bd4026296337087b66884"
 Fixed #19924 -- Fixed selectors in actions.js that did not use options.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.101bf44dac5db2fe5f981b71c3cb449d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21249: Typo in SQLCompiler.get_grouping()

2013-10-09 Thread Django

#21249: Typo in SQLCompiler.get_grouping()
--+
 Reporter:  manfre|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 From
 
https://github.com/django/django/blob/master/django/db/models/sql/compiler.py#L578

 {{{
 for order, order_params in ordering_group_by:
 # Even if we have seen the same SQL string, it might
 have
 # different params, so, we add same SQL in "has
 params" case.
 if order not in seen or params:
 result.append(order)
 params.extend(order_params)
 seen.add(order)
 }}}

 should be:

 {{{
 for order, order_params in ordering_group_by:
 # Even if we have seen the same SQL string, it might
 have
 # different params, so, we add same SQL in "has
 params" case.
 if order not in seen or order_params:
 result.append(order)
 params.extend(order_params)
 seen.add(order)

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.cde005585ca2a83f67582ce7af48532e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 4523fc: Fixed #19924 -- Fixed selectors in actions.js that...

2013-10-09 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 4523fcd60101124a307bd4026296337087b66884
  
https://github.com/django/django/commit/4523fcd60101124a307bd4026296337087b66884
  Author: crccheck 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M django/contrib/admin/static/admin/js/actions.js
M django/contrib/admin/static/admin/js/actions.min.js

  Log Message:
  ---
  Fixed #19924 -- Fixed selectors in actions.js that did not use options.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52556b395c405_1afec01d5489955%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21169: Deletion in custom reverse managers

2013-10-09 Thread Django

Comment (by akaariai):

I did some work to make sure queries used by m2m clear() and remove() are
as simple as possible. Now the clearing queries do not use subqueries when
the manager doesn't have filters. The subqueries in these cases didn't
actually filter anything out. In addition, when subqueries are used, the
subquery has one less join than before. End result is that the queries are
similar to current master when the base manager doesn't have filters, and
a bit more efficient that current HEAD of pull 1685 when there are
filters. The tradeoff is even more complexity in m2m manager
implementation.

To me it seems important that as simple as possible queries are used. This
ensures as little DB resources are used as possible. In addition I believe
old versions of MySQL will simply panic when they see a query with both a
subquery and joins...

Patch at

https://github.com/akaariai/django/commit/9dd75213050e6f85a0b93ddd59243f8d3809b06c
- this doesn't have any tests, and regressions in query efficiency seem
likely. I wonder if CaptureQueriesContext could be used to inspect the
used queries.

BTW I spotted one possible data-corruption issue in current clear() code
for symmetric m2m. Currently the clear is implemented as two separate
delete queries which delete all items from the relation, first in one
direction, then in another. But, if a concurrent add() commits in between
then the added relation is deleted in one direction, but not in anohter.
The sequence is like this for transactions T1 and T2:
{{{
T1: add relation for instances m1 <-> m2. Two rows are added so that the
relation is symmetrical (rows m1:m2 and m2:m1).
T2: m1.clear() starts. First, delete all rows where m1:*. m1:m2 isn't
deleted as that isn't yet visible.
T1: commits, m1:m2 and m2:m1 become visible to T2.
T2: Second part of clear is executed, that is *:m1 is deleted. Now m2:m1
is visible and it is deleted.
T2: commits. m1:m2 relation exists, but m2:m1 doesn't. The symmetry of
m1<->m2 is broken.
}}}
Luckily this seems rare in practice. pull 1685 does the delete in one go,
so this issue is fixed in PR1685. This seems to be impossible to test in a
way that the regression test actually picks up regressions. So, no tests
needed for this case.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.da8842d19cf151b3ed46c9e3e926a71c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 7a58fd: [1.6.x] Fixed grammar/typos in auth customization ...

2013-10-09 Thread GitHub

  Branch: refs/heads/stable/1.6.x
  Home:   https://github.com/django/django
  Commit: 7a58fde7a60d93b118bcaeb2d18c95e7ec512b8a
  
https://github.com/django/django/commit/7a58fde7a60d93b118bcaeb2d18c95e7ec512b8a
  Author: Claude Paroz 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M docs/topics/auth/customizing.txt

  Log Message:
  ---
  [1.6.x] Fixed grammar/typos in auth customization docs

Backport of 1b9c72fc4f from master.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/525566ccd3068_63d98ffd54408d3%40hookshot-fe6-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 1b9c72: Fixed grammar/typos in auth customization docs

2013-10-09 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 1b9c72fc4ff9970680252499c20d6f25b1456321
  
https://github.com/django/django/commit/1b9c72fc4ff9970680252499c20d6f25b1456321
  Author: Claude Paroz 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M docs/topics/auth/customizing.txt

  Log Message:
  ---
  Fixed grammar/typos in auth customization docs



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5255668256961_1ef052dd48574f%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

2013-10-09 Thread Django

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  pyriku
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_tests:  1 => 0
 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1f66c48bb07da7cf06daec645c979d14%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15582: Docs don't mention that TestCase.multi_db affects test fixtures

2013-10-09 Thread Django

#15582: Docs don't mention that TestCase.multi_db affects test fixtures
---+
 Reporter:  slinkp |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c862e59d2341d80eeaa69d059ac39303%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17212: django.contrib.gis.geos.error.GEOSException: Could not parse version info string "3.4.0dev-CAPI-1.8.0"

2013-10-09 Thread Django

#17212: django.contrib.gis.geos.error.GEOSException: Could not parse version 
info
string "3.4.0dev-CAPI-1.8.0"
+
 Reporter:  strk@…  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  GIS |  Version:  1.3
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+

Comment (by claudep):

 Here's a patch you should be able to manually apply to 1.4:
 {{{
 diff --git a/django/contrib/gis/geos/libgeos.py
 b/django/contrib/gis/geos/libgeos.py
 index f011208..05e5d12 100644
 --- a/django/contrib/gis/geos/libgeos.py
 +++ b/django/contrib/gis/geos/libgeos.py
 @@ -108,8 +108,11 @@ def get_pointer_arr(n):
  geos_version.restype = c_char_p

  # Regular expression should be able to parse version strings such as
 -# '3.0.0rc4-CAPI-1.3.3', '3.0.0-CAPI-1.4.1' or '3.4.0dev-CAPI-1.8.0'
 -version_regex =
 
re.compile(r'^(?P(?P\d+)\.(?P\d+)\.(?P\d+))((rc(?P\d+))|dev)?-CAPI-(?P\d+\.\d+\.\d+)$')
 +# '3.0.0rc4-CAPI-1.3.3', '3.0.0-CAPI-1.4.1', '3.4.0dev-CAPI-1.8.0' or
 '3.4.0dev-CAPI-1.8.0 r0'
 +version_regex = re.compile(
 +r'^(?P(?P\d+)\.(?P\d+)\.(?P\d+))'
 +
 r'((rc(?P\d+))|dev)?-CAPI-(?P\d+\.\d+\.\d+)(
 r\d+)?$'
 +)
  def geos_version_info():
  """
  Returns a dictionary containing the various version metadata parsed
 from
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.01672c02a72c6609d10f14fe06f3f598%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21248: Password tests failure on Django 1.5 (bcrypt related)

2013-10-09 Thread Django

#21248: Password tests failure on Django 1.5 (bcrypt related)
--+--
 Reporter:  akaariai  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Anssi Kääriäinen ):

 In [changeset:"037ec1054ca8c08e65307f53e5851fe50ac5e8bf"]:
 {{{
 #!CommitTicketReference repository=""
 revision="037ec1054ca8c08e65307f53e5851fe50ac5e8bf"
 [1.4.x] Fixed #21248 -- Skipped test_bcrypt if no py-bcrypt found

 Pre 1.6 Django worked only with py-bcrypt, not with bcrypt. Skipped
 test_bcrypt when using bcrypt to avoid false positives.

 Backpatch of 9f8a36eb20895d9e542820d5190bfa77ad1b85d9 from stable/1.5.x.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cf9379e66870ac496fcf8a609f7ec6fb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 037ec1: [1.4.x] Fixed #21248 -- Skipped test_bcrypt if no ...

2013-10-09 Thread GitHub

  Branch: refs/heads/stable/1.4.x
  Home:   https://github.com/django/django
  Commit: 037ec1054ca8c08e65307f53e5851fe50ac5e8bf
  
https://github.com/django/django/commit/037ec1054ca8c08e65307f53e5851fe50ac5e8bf
  Author: Anssi Kääriäinen 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M django/contrib/auth/tests/hashers.py

  Log Message:
  ---
  [1.4.x] Fixed #21248 -- Skipped test_bcrypt if no py-bcrypt found

Pre 1.6 Django worked only with py-bcrypt, not with bcrypt. Skipped
test_bcrypt when using bcrypt to avoid false positives.

Backpatch of 9f8a36eb20895d9e542820d5190bfa77ad1b85d9 from stable/1.5.x.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52554212f3f22_617678bd4c10329%40hookshot-fe3-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21248: Password tests failure on Django 1.5 (bcrypt related)

2013-10-09 Thread Django

#21248: Password tests failure on Django 1.5 (bcrypt related)
--+--
 Reporter:  akaariai  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Anssi Kääriäinen ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9f8a36eb20895d9e542820d5190bfa77ad1b85d9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9f8a36eb20895d9e542820d5190bfa77ad1b85d9"
 [1.5.x] Fixed #21248 -- Skipped test_bcrypt if no py-bcrypt found

 Pre 1.6 Django worked only with py-bcrypt, not with bcrypt. Skipped
 test_bcrypt when using bcrypt to avoid false positives.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7af310e88ab421be54ebd0e17d12dae0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 9f8a36: [1.5.x] Fixed #21248 -- Skipped test_bcrypt if no ...

2013-10-09 Thread GitHub

  Branch: refs/heads/stable/1.5.x
  Home:   https://github.com/django/django
  Commit: 9f8a36eb20895d9e542820d5190bfa77ad1b85d9
  
https://github.com/django/django/commit/9f8a36eb20895d9e542820d5190bfa77ad1b85d9
  Author: Anssi Kääriäinen 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M django/contrib/auth/tests/hashers.py

  Log Message:
  ---
  [1.5.x] Fixed #21248 -- Skipped test_bcrypt if no py-bcrypt found

Pre 1.6 Django worked only with py-bcrypt, not with bcrypt. Skipped
test_bcrypt when using bcrypt to avoid false positives.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52554135821f7_7b92d4bd54563c7%40hookshot-fe4-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21248: Password tests failure on Django 1.5 (bcrypt related)

2013-10-09 Thread Django

#21248: Password tests failure on Django 1.5 (bcrypt related)
--+--
 Reporter:  akaariai  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by akaariai):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Django 1.5.x doesn't work with bcrypt, only with py-bcrypt (confirmed by
 dstufft). Skipping the test_bcrypt test for bcrypt library (but not py-
 bcrypt) seems good enough for now.

 
[https://github.com/akaariai/django/commit/7c88676c0d551dd2632783b0c4f2e24e9c4fe425
 This commit] seems to skip the test for bcrypt, but not for py-bcrypt.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c57151bc8c58250ed5cee71c4b0932ae%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21126: Potential data corruption issue with Oracle and Mysql due to SQLCompiler.resolve_columns row, fields misalignment

2013-10-09 Thread Django

Comment (by akaariai):

I backpatched 69f7db153d8108dcef033207d49f4c80febf3d70 to 1.5.x. Now
results_iter() should have all relevant commits backpatched, not just
partial backpatch.

I think I made a mistake in the original backpatch of this ticket's patch
to 1.5.x. Classifying this as a data loss issue is a bit of a stretch...
But as said before, leaving 1.5.x's results_iter() in half-fixed state
seems to be the worst option here.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.b7a17b7ac4a3fdd12dc2027effecb8e7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16436: `annotate()` + `select_related()` + `only()` = `ValueError: invalid literal for int() with base 10`

2013-10-09 Thread Django

#16436: `annotate()` + `select_related()` + `only()` = `ValueError: invalid 
literal
for int() with base 10`
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:  annotate |  Needs documentation:  0
  select_related only defer  |  Patch needs improvement:  1
  ValueError empty list  |UI/UX:  0
Has patch:  1|
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Anssi Kääriäinen ):

 In [changeset:"b495c24375aa1fe0373727511cf81298337a1227"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b495c24375aa1fe0373727511cf81298337a1227"
 [1.5.x] Fixed #16436 -- defer + annotate + select_related crash

 Correctly calculate the ``aggregate_start`` offset from loaded fields,
 if any are deferred, instead of ``self.query.select`` which includes all
 fields on the model.

 Backpatch of 69f7db153d8108dcef033207d49f4c80febf3d70 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.db830cff85e9f8cb6a92dc321a646ecf%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] b495c2: [1.5.x] Fixed #16436 -- defer + annotate + select_...

2013-10-09 Thread GitHub

  Branch: refs/heads/stable/1.5.x
  Home:   https://github.com/django/django
  Commit: b495c24375aa1fe0373727511cf81298337a1227
  
https://github.com/django/django/commit/b495c24375aa1fe0373727511cf81298337a1227
  Author: Tai Lee 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M django/db/models/sql/compiler.py
M tests/modeltests/defer/models.py
M tests/modeltests/defer/tests.py

  Log Message:
  ---
  [1.5.x] Fixed #16436 -- defer + annotate + select_related crash

Correctly calculate the ``aggregate_start`` offset from loaded fields,
if any are deferred, instead of ``self.query.select`` which includes all
fields on the model.

Backpatch of 69f7db153d8108dcef033207d49f4c80febf3d70 from master.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52553673793be_1b72d87d5456721%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21248: Password tests failure on Django 1.5 (bcrypt related)

2013-10-09 Thread Django

#21248: Password tests failure on Django 1.5 (bcrypt related)
--+
 Reporter:  akaariai  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  contrib.auth  |Version:  1.5
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 I get this failure when running Django's test suite on stable/1.5.x (at
 commit f8393edb52e3dc73185f2496bfa08463fa4ffa09):
 {{{
 ==
 ERROR: test_bcrypt (django.contrib.auth.tests.hashers.TestUtilsHashPass)
 --
 Traceback (most recent call last):
   File "/home/akaariai/Programming/py27_venv/local/lib/python2.7/site-
 packages/django/contrib/auth/tests/hashers.py", line 100, in test_bcrypt
 self.assertTrue(check_password('lètmein', encoded))
   File "/home/akaariai/Programming/py27_venv/local/lib/python2.7/site-
 packages/django/contrib/auth/hashers.py", line 55, in check_password
 is_correct = hasher.verify(password, encoded)
   File "/home/akaariai/Programming/py27_venv/local/lib/python2.7/site-
 packages/django/contrib/auth/hashers.py", line 293, in verify
 return constant_time_compare(data,
 bcrypt.hashpw(force_bytes(password), data))
   File "/home/akaariai/Programming/py27_venv/local/lib/python2.7/site-
 packages/bcrypt/__init__.py", line 91, in hashpw
 raise TypeError("Unicode-objects must be encoded before hashing")
 TypeError: Unicode-objects must be encoded before hashing
 }}}

 The failure happens only when bcrypt is installed. Tested bcrypt
 1.0.0-1.0.2. The failure happens both on Python 2.7 and 3.2. It seems the
 error is there in first 1.5 release, too. The error isn't present in
 1.6.x.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.1b7e21793a04b1598c0a2f5d0fd33f5b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 24f996: Fixed regression introduced by 20472aa827669d2b83b...

2013-10-09 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 24f99676195333aa345fb955cdc8d2d0cd08efa3
  
https://github.com/django/django/commit/24f99676195333aa345fb955cdc8d2d0cd08efa3
  Author: Baptiste Mispelon 
  Date:   2013-10-09 (Wed, 09 Oct 2013)

  Changed paths:
M django/contrib/gis/geoip/__init__.py

  Log Message:
  ---
  Fixed regression introduced by 20472aa827669d2b83b74e521504e88e18d086a1.

The wrong exception was being caught when detecting the presence of GeoIP.
Thanks to ramiro for the report.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/525528b35e410_1b72d87d54519aa%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21205: related_objects() fails on SQLite when passing more than 999 objects

2013-10-09 Thread Django

#21205: related_objects() fails on SQLite when passing more than 999 objects
-+-
 Reporter:  NiGhTTraX|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  sqlite delete|  Unreviewed
  related 999|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by NiGhTTraX):

 Seems like it. But, looking at the proposed patch, I see that it doesn't
 use the max_batch_size database ops.

 Also, the splitting occurs at the collect() level, while I propose that it
 happens in related_objects(), as that's where the problem lies.

 Feel free to discuss both patches.

 I think this should be fixed as soon as possible since it could break a
 lot of people's code, especially when trying to truncate tables via
 objects.all().delete().

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ccd523ecd682e170a16cd3d96afcbad5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

50 matches

Mail list logo