Re: [Django] #29478: cached_property decorator doesn't work with mangled method names

2018-06-20 Thread Django
#29478: cached_property decorator doesn't work with mangled method names
-+
 Reporter:  Thomas Grainger  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Utilities|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Xin He):

 * status:  assigned => new
 * owner:  Xin He => (none)


Comment:

 It's seem another pull request to fix the ticket on Github. So I have to
 deassign it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3632a03c263a7d09b97d687b7970cb1a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29506: Misleading migrate "App 'apps.somethings' does not have migrations." error message with nested apps

2018-06-20 Thread Django
#29506: Misleading migrate "App 'apps.somethings' does not have migrations." 
error
message with nested apps
-+-
 Reporter:  oliver   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by oliver):

 Thank you too.
 I learned a lot from your code!

 Replying to [comment:5 Tim Graham ]:
 > In [changeset:"c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8" c723a1ff]:
 > {{{
 > #!CommitTicketReference repository=""
 revision="c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8"
 > Fixed #29506 -- Added validation for migrate's app_label option.
 >
 > Thanks MyungSeKyo for the report and the initial patch.
 > }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.53a28ee9fa9779e54fd85c9ac5b3bc1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29469: Misleading makemigrations "App count not be found" error message with nested apps

2018-06-20 Thread Django
#29469: Misleading makemigrations "App count not be found" error message with
nested apps
---+
 Reporter:  Matthew Schinckel  |Owner:  oliver
 Type:  Bug|   Status:  closed
Component:  Migrations |  Version:  2.0
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"c3c7d15c34d6174ff25a49d7c9a57da140769567" c3c7d15]:
 {{{
 #!CommitTicketReference repository=""
 revision="c3c7d15c34d6174ff25a49d7c9a57da140769567"
 Refs #29469 -- Reused get_app_config() error message in makemigrations
 error.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.521e19e9103b3103a482790275a6d7be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29506: Misleading migrate "App 'apps.somethings' does not have migrations." error message with nested apps

2018-06-20 Thread Django
#29506: Misleading migrate "App 'apps.somethings' does not have migrations." 
error
message with nested apps
-+-
 Reporter:  oliver   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8" c723a1ff]:
 {{{
 #!CommitTicketReference repository=""
 revision="c723a1ff8e76aaef227d5af7a57006cc9bfd2fc8"
 Fixed #29506 -- Added validation for migrate's app_label option.

 Thanks MyungSeKyo for the report and the initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.536608b13609794436f635fa9b2bb9fc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29506: Misleading migrate "App 'apps.somethings' does not have migrations." error message with nested apps

2018-06-20 Thread Django
#29506: Misleading migrate "App 'apps.somethings' does not have migrations." 
error
message with nested apps
-+-
 Reporter:  oliver   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"fc266151648da8856dc735058375ed6cc0e636b5" fc266151]:
 {{{
 #!CommitTicketReference repository=""
 revision="fc266151648da8856dc735058375ed6cc0e636b5"
 Refs #29506 -- Added validation for squashmigrations' app_label option.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b82f04868b671a5e17ca869885392190%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of query parameters

2018-06-20 Thread Django
#27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of
query parameters
-+-
 Reporter:  Cédric Codet |Owner:  Jan
 Type:   |  Pieter Waagmeester
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"5d98d53fab874ec21b313499a7e6aa05791bde85" 5d98d53]:
 {{{
 #!CommitTicketReference repository=""
 revision="5d98d53fab874ec21b313499a7e6aa05791bde85"
 Refs #27398 -- Simplified some tests with assertRedirects().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.363e8283dd5e9b36383751669d76cbb4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of query parameters

2018-06-20 Thread Django
#27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of
query parameters
-+-
 Reporter:  Cédric Codet |Owner:  Jan
 Type:   |  Pieter Waagmeester
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"24959e48d949a20be969f649ece3576dbc7ce422" 24959e48]:
 {{{
 #!CommitTicketReference repository=""
 revision="24959e48d949a20be969f649ece3576dbc7ce422"
 Fixed #27398 -- Added an assertion to compare URLs, ignoring the order of
 their query strings.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.bd0835d0bffde1eee2901fe9c47eb655%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28687: Add a 'Not Empty' option to admin's related filter

2018-06-20 Thread Django
#28687: Add a 'Not Empty' option to admin's related filter
-+-
 Reporter:  Brillgen Developers  |Owner:  Jake
 Type:   |  Barber
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 I agree -- `get_not_empty_value_display()` looks heavy handed for this use
 case. `get_empty_value_display()` is used elsewhere besides the
 `RelatedFieldListFilter` and it corresponds to the values displayed in the
 changelist -- that's not the case for the "not empty" case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c49e2035060af56795e02e1b2b12a4e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24159: compilemessages does not behave the same as makemessages

2018-06-20 Thread Django
#24159: compilemessages does not behave the same as makemessages
-+-
 Reporter:  Matthew Somerville   |Owner:  Matthew
 |  Somerville
 Type:  New feature  |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Please open appropriate tickets with your issues.

 > And any broken locale file in any package can break compilation process.

 This is fixed in master (through #24384).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.60bf31a5566cf34c7d0e74832fda74e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29499: Race condition in QuerySet.update_or_create()

2018-06-20 Thread Django
#29499: Race condition in QuerySet.update_or_create()
-+-
 Reporter:  Michael Sanders  |Owner:  Michael
 |  Sanders
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  race-condition   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Michael Sanders):

 * status:  new => assigned
 * owner:  nobody => Michael Sanders


Comment:

 I am obtaining permission from my employer and then will create a PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.3607e5797727f2cac6b2896b2a83429e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29451: Add compatibility with MySQL 8

2018-06-20 Thread Django
#29451: Add compatibility with MySQL 8
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"243f07bbb3e65c44500451a78251d062301fe25d" 243f07b]:
 {{{
 #!CommitTicketReference repository=""
 revision="243f07bbb3e65c44500451a78251d062301fe25d"
 [2.0.x] Refs #29451 -- Fixed invalid SQL on MySQL in queries tests.

 Backport of c4f099de1d0d82c5e1f88768300896eae69bddbd from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fb1d8a119e74863db3546a55a27c0c56%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29451: Add compatibility with MySQL 8

2018-06-20 Thread Django
#29451: Add compatibility with MySQL 8
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"f8a6488839ac3666412bd3b5573cf7eae78fbcca" f8a64888]:
 {{{
 #!CommitTicketReference repository=""
 revision="f8a6488839ac3666412bd3b5573cf7eae78fbcca"
 [2.0.x] Refs #29451 -- Fixed regex/iregex lookups on MySQL 8.

 Backport of 42490768441701bc02255b22df8e6894cbe487c7 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cf6a8ec64454481d0f3de79051ae1f1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29451: Add compatibility with MySQL 8

2018-06-20 Thread Django
#29451: Add compatibility with MySQL 8
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"17017ba12a183d491c983ca1ff9c3889619676fe" 17017ba1]:
 {{{
 #!CommitTicketReference repository=""
 revision="17017ba12a183d491c983ca1ff9c3889619676fe"
 [2.1.x] Refs #29451 -- Fixed regex/iregex lookups on MySQL 8.

 Backport of 42490768441701bc02255b22df8e6894cbe487c7 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.71b22552bce5a3e551be409ea4703853%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29451: Add compatibility with MySQL 8

2018-06-20 Thread Django
#29451: Add compatibility with MySQL 8
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"42490768441701bc02255b22df8e6894cbe487c7" 4249076]:
 {{{
 #!CommitTicketReference repository=""
 revision="42490768441701bc02255b22df8e6894cbe487c7"
 Refs #29451 -- Fixed regex/iregex lookups on MySQL 8.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c0030ed9cfdc70fcd9fb5b47b36873dd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29451: Add compatibility with MySQL 8

2018-06-20 Thread Django
#29451: Add compatibility with MySQL 8
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"dae75481fabbe775160893a2e7cb2b2d73705a8f" dae75481]:
 {{{
 #!CommitTicketReference repository=""
 revision="dae75481fabbe775160893a2e7cb2b2d73705a8f"
 [2.1.x] Refs #29451 -- Fixed invalid SQL on MySQL in queries tests.

 Backport of c4f099de1d0d82c5e1f88768300896eae69bddbd from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a74ad9ab5af34057987970ce6e82cbf0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29505: SchemaEditor prohibits setting a field's default value to a callable that'll be used as the default (was: Impossible to set a Field's default value to a callable that takes an arg

2018-06-20 Thread Django
#29505: SchemaEditor prohibits setting a field's default value to a callable
that'll be used as the default
-+
 Reporter:  Eugene Pakhomov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  default  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham):

 * status:  closed => new
 * type:  Uncategorized => Bug
 * needs_tests:  0 => 1
 * has_patch:  0 => 1
 * resolution:  wontfix =>
 * stage:  Unreviewed => Accepted


Comment:

 After a second look, I agree with your analysis. The patch looks okay, and
 the test will probably go in `tests/schema`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.556a55686cde95edf57b0f56ca648628%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29508: Simplify overriding `login_form` in AdminSite

2018-06-20 Thread Django
#29508: Simplify overriding `login_form` in AdminSite
+
   Reporter:  remilapeyre   |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  2.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 When setting `login_form` of `AdminSite` to a subclass of
 AdminAuthenticationForm an AppRegistryNotReady exception gets raised as
 documented in
 
https://github.com/django/django/blob/master/django/contrib/admin/sites.py#L377.

 This problem makes it harder to customize the administration site as it
 requires to override the whole `login` method of AdminSite to bypass it.

 The attached patch use `import_string` to let users specify the class to
 use as a string and import it at runtime.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.52882fe1dbb4e36118fdb66fa67aa039%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

2018-06-20 Thread Django
#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b0fbfae09334554124e1dccb7559d10f36e2f84c" b0fbfae0]:
 {{{
 #!CommitTicketReference repository=""
 revision="b0fbfae09334554124e1dccb7559d10f36e2f84c"
 Fixed #29503 -- Made __in lookup keep order of values in query.

 Regression in 86eccdc8b67728d84440a46e5bf62c78f2eddf6d.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3b44de15d3dc86c92034ca1190357c54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

2018-06-20 Thread Django
#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"16e691d568a06873445171025ba44b5f00920e7e" 16e691d]:
 {{{
 #!CommitTicketReference repository=""
 revision="16e691d568a06873445171025ba44b5f00920e7e"
 [2.1.x] Fixed #29503 -- Made __in lookup keep order of values in query.

 Regression in 86eccdc8b67728d84440a46e5bf62c78f2eddf6d.

 Backport of b0fbfae09334554124e1dccb7559d10f36e2f84c from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b88161b736e550945da9917621d9761a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29507: add Oracle support for Envelope function

2018-06-20 Thread Django
#29507: add Oracle support for Envelope function
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"fa453b03a6a20cc7339c766f6258434d028ed28c" fa453b0]:
 {{{
 #!CommitTicketReference repository=""
 revision="fa453b03a6a20cc7339c766f6258434d028ed28c"
 Fixed #29507 -- Added Oracle support for Envelope GIS function.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3936abb6dbed652cfd63153aa56c8573%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24159: compilemessages does not behave the same as makemessages

2018-06-20 Thread Django
#24159: compilemessages does not behave the same as makemessages
-+-
 Reporter:  Matthew Somerville   |Owner:  Matthew
 |  Somerville
 Type:  New feature  |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marcin Nowak):

 Hi.

 I'm using buildout. Both commands, compilemessages (after #24159 patch)
 and makemessages, introduced new issues. They scan all nested directories,
 they're reading (makemessages) and creating (compilemessages) files in
 external eggs and cloned repositories, even in django itself and unused
 but stored on disk packages. There is no possibility to exclude or include
 directories to search. And any broken locale file in any package can break
 compilation process.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ac13be0f07601f83c7d971da1360a8f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29507: add Oracle support for Envelope function

2018-06-20 Thread Django
#29507: add Oracle support for Envelope function
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9d1b3c902aceca6152a1021046e7d116%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #20935: ePub documentation not valid

2018-06-20 Thread Django
#20935: ePub documentation not valid
---+
 Reporter:  mabdullah  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Claude Paroz):

 https://github.com/sphinx-doc/sphinx/issues/5070 (issue with internal
 anchors) has just been fixed. After the 1.7.6 sphinx release is out and
 deployed on readthedocs, we may check the document validity again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.694137f6a04396bbe718d7e16f194823%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

2018-06-20 Thread Django
#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: felixxm (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.cc61371f79f8c916dc500565d3572cdd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29507: add Oracle support for Envelope function

2018-06-20 Thread Django
#29507: add Oracle support for Envelope function
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/10069 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.96edba551d53f7beb53ea05687a90c6b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29467: override_settings context manager can leave undesired settings state

2018-06-20 Thread Django
#29467: override_settings context manager can leave undesired settings state
-+-
 Reporter:  Sławek Ehlert|Owner:  Sławek
 |  Ehlert
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  settings | Triage Stage:  Accepted
  override_settings  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: felixxm (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.16192bca6364aa477e68fc9324dcc5aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29507: add Oracle support for Envelope function

2018-06-20 Thread Django
#29507: add Oracle support for Envelope function
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * status:  new => assigned
 * owner:  nobody => Sergey Fedoseev


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c01def52b0bdc9704a1125cf571af8cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29507: add Oracle support for Envelope function

2018-06-20 Thread Django
#29507: add Oracle support for Envelope function
---+
   Reporter:  Sergey Fedoseev  |  Owner:  nobody
   Type:  New feature  | Status:  new
  Component:  GIS  |Version:  master
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.0b2174c1d47be908af40d29caf4ad3cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

2018-06-20 Thread Django
#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sławek Ehlert):

 @Carlton I've opened https://github.com/django/django/pull/10068

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.dbd14ab58c078f58da56ad88e15674ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29467: override_settings context manager can leave undesired settings state

2018-06-20 Thread Django
#29467: override_settings context manager can leave undesired settings state
-+-
 Reporter:  Sławek Ehlert|Owner:  Sławek
 |  Ehlert
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  settings | Triage Stage:  Accepted
  override_settings  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sławek Ehlert):

 I've opened https://github.com/django/django/pull/10068 to address this
 issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ff467cd1f686679403fe2d5c06cbaff7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of query parameters

2018-06-20 Thread Django
#27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of
query parameters
-+-
 Reporter:  Cédric Codet |Owner:  Jan
 Type:   |  Pieter Waagmeester
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.41eac91120cd3f1da749132bc91cce07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

2018-06-20 Thread Django
#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * cc: Carlton Gibson (added)
 * stage:  Unreviewed => Ready for checkin


Comment:

 I'd be happy with the use of `OrderedSet` here. Semantically `in` uses a
 set but we (always/mostly?) pass it a list, which is ordered, and it's
 reasonable enough to maintain that. (Beyond Nick's usage, it could be
 handy somewhere.)

 Is this a regression? Was it always part of the contract? Not sure. Pass.
 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.19c62f224578a26ce1f5cae8120ee90e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

2018-06-20 Thread Django
#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * has_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d5d25323a23ba9d3096de8f01cd70b77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.