Re: [Django] #32813: Display development server address after server bind

2022-08-05 Thread Django 
#32813: Display development server address after server bind
-+-
 Reporter:  fmwviormv|Owner:  Abhijeet
 |  Pal
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  development server,  | Triage Stage:  Accepted
  automatic port |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Abhijeet Pal):

 Hi, was busy for a couple of weeks, I would try to make the asked changes
 over this weekend.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018270f173c0-347642dd-2cf6-4616-a831-35b3a38d6cde-00%40eu-central-1.amazonses.com.

Re: [Django] #32813: Display development server address after server bind

2022-08-05 Thread Django 
#32813: Display development server address after server bind
-+-
 Reporter:  fmwviormv|Owner:  Abhijeet
 |  Pal
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  development server,  | Triage Stage:  Accepted
  automatic port |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Gav O'Connor):

 Happy to pick up the PR updates if @TheAbhijeet isn't available?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018270469371-2dcc584b-bad7-4885-a316-135e6973c47c-00%40eu-central-1.amazonses.com.

Re: [Django] #33899: migrations.RemoveField causes OperationalError "no such column" upon migration

2022-08-05 Thread Django 
#33899: migrations.RemoveField causes OperationalError "no such column" upon
migration
-+-
 Reporter:  cessor   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  Migration Sqlite | Triage Stage:
  Docker |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 I'm really puzzled. I cannot reproduce this issue manually, but `make red`
 crashes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e9cfd25-0516b8d3-940b-4dcf-8d98-54d93e0365c5-00%40eu-central-1.amazonses.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

2022-08-05 Thread Django 
#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0
 * resolution:  fixed => wontfix
 * stage:  Ready for checkin => Unreviewed


Comment:

 Patch was reverted, it's probably not worth complexity.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e9b0c2f-916cd9ed-c4f0-4159-b038-263bd3a78ca6-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  admin| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"82e9e19ebe6bc920f1cfffc42d86648644fd4a78" 82e9e19]:
 {{{
 #!CommitTicketReference repository=""
 revision="82e9e19ebe6bc920f1cfffc42d86648644fd4a78"
 [4.1.x] Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double
 submission of admin forms."

 Regression in fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa.

 Backport of 0756c61f2ada56e4ae625589099c0141a77737eb from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e998c8c-021359a2-b9d0-407d-8cd9-63bfa3fa0ea5-00%40eu-central-1.amazonses.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

2022-08-05 Thread Django 
#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"82e9e19ebe6bc920f1cfffc42d86648644fd4a78" 82e9e19]:
 {{{
 #!CommitTicketReference repository=""
 revision="82e9e19ebe6bc920f1cfffc42d86648644fd4a78"
 [4.1.x] Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double
 submission of admin forms."

 Regression in fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa.

 Backport of 0756c61f2ada56e4ae625589099c0141a77737eb from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e998c69-c936acc7-fa63-470a-8421-0c65576f40d7-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  admin| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0756c61f2ada56e4ae625589099c0141a77737eb" 0756c61f]:
 {{{
 #!CommitTicketReference repository=""
 revision="0756c61f2ada56e4ae625589099c0141a77737eb"
 Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double submission of
 admin forms."

 Regression in fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e9921ba-269bb8ad-14cf-4662-94d8-0bdee87c5f82-00%40eu-central-1.amazonses.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

2022-08-05 Thread Django 
#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"0756c61f2ada56e4ae625589099c0141a77737eb" 0756c61f]:
 {{{
 #!CommitTicketReference repository=""
 revision="0756c61f2ada56e4ae625589099c0141a77737eb"
 Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double submission of
 admin forms."

 Regression in fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e992195-4f6b7421-9c17-4263-a5bf-4fa7c20088b7-00%40eu-central-1.amazonses.com.

Re: [Django] #33898: Window() expression with ArrayAgg() crashes.

2022-08-05 Thread Django 
#33898: Window() expression with ArrayAgg() crashes.
-+-
 Reporter:  Kia  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  ArrayAgg, Window | Triage Stage:  Accepted
  function, extend, tuple, params|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 > Should we keep this issue focused on the Window(ArrayAgg) case or
 perform a larger audit meant to be backported?

 Yes we should focus this on fixing ` Window(ArrayAgg)` and backport do
 4.1. Larger audit can be made on the `main` branch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e8dfdbd-c4945970-d6ee-4da8-925a-73c15ff7b4cd-00%40eu-central-1.amazonses.com.

Re: [Django] #33898: Window() expression with ArrayAgg() crashes.

2022-08-05 Thread Django 
#33898: Window() expression with ArrayAgg() crashes.
-+-
 Reporter:  Kia  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  ArrayAgg, Window | Triage Stage:  Accepted
  function, extend, tuple, params|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 This has become a true whack-a-mole game over the years.

 I think we should just bite the bullet and audit all of our `as_sql`
 functions to make sure they deal with params in `tuple` and not in `list`.
 Otherwise the only true way to cover all cases is to have a unit test for
 every combination of expression Django provides. Any thoughts on that
 Mariusz?

 Should we keep this issue focused on the `Window(ArrayAgg)` case or
 perform a larger audit meant to be backported? We could at least make sure
 all `as_sql` implementation are able to deal with `tuple | list` for now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e81770c-b3947672-c772-495d-b8b6-ff020d9dc1a0-00%40eu-central-1.amazonses.com.

Re: [Django] #33898: Window() expression with ArrayAgg() crashes. (was: Broken usage of ArrayAgg inside Window function)

2022-08-05 Thread Django 
#33898: Window() expression with ArrayAgg() crashes.
-+-
 Reporter:  Kia  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  ArrayAgg, Window | Triage Stage:  Accepted
  function, extend, tuple, params|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Simon Charette (added)
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report! Regression in
 e06dc4571ea9fd5723c8029959b95808be9f8812.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e7cb04d-b96501b7-5ee8-45c7-bef9-6e8c735dd154-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e72d690-00bf7fb9-925b-415d-a7a7-086d7f7eeb73-00%40eu-central-1.amazonses.com.

Re: [Django] #33899: migrations.RemoveField causes OperationalError "no such column" upon migration

2022-08-05 Thread Django 
#33899: migrations.RemoveField causes OperationalError "no such column" upon
migration
-+-
 Reporter:  cessor   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  Migration Sqlite | Triage Stage:
  Docker |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by cessor:

Old description:

> == Description
>
> I encountered the following error with django 4.1 in my Gitlab CI/CD
> Pipeline. When I bumped django versions from 4.0.7 to 4.1. my pipeline
> broke during the testing stage; specifically during db migrations. I have
> not changed the any other source code.
>
> == Steps to reproduce
>
> Minimal example attached. Run `make green` to see that it works with
> 4.0.7, run `make red` to see that it does not work with 4.1.
>
> Manual steps:
>
> 0. Install django 4.1
> 1. Create a new project
> 2. Create an app
> 3. Install app in project
> 4. Create a model
> 5. Add field on model
> 6. Make migrations
> 7. Remove field
> 8. Make migrations
>
> The migration should fail.

New description:

 == Description

 I encountered the following error with django 4.1 in my Gitlab CI/CD
 Pipeline. When I bumped django versions from 4.0.7 to 4.1. my pipeline
 broke during the testing stage; specifically during db migrations. I have
 not changed any other source code.

 == Steps to reproduce

 Minimal example attached. Run `make green` to see that it works with
 4.0.7, run `make red` to see that it does not work with 4.1. It will build
 and exercise a docker container which installs all dependencies in
 isolation and sets up an example django app and run migrations.

 Manual steps:

 0. Install django 4.1
 1. Create a new project
 2. Create an app
 3. Install app in project
 4. Create a model
 5. Add field on model
 6. Make migrations
 7. Remove field
 8. Make migrations

 The migration should fail.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e646c1b-ed4960ce-4a2f-426f-9126-9da72c965674-00%40eu-central-1.amazonses.com.

Re: [Django] #33899: migrations.RemoveField causes OperationalError "no such column" upon migration

2022-08-05 Thread Django 
#33899: migrations.RemoveField causes OperationalError "no such column" upon
migration
-+-
 Reporter:  cessor   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  Migration Sqlite | Triage Stage:
  Docker |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by cessor):

 * Attachment "django-bug-33899.tgz" added.

 Minimal Example

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e624209-f17d5a9d-a0be-4b94-b6e9-6fa617606739-00%40eu-central-1.amazonses.com.

[Django] #33899: migrations.RemoveField causes OperationalError "no such column" upon migration

2022-08-05 Thread Django 
#33899: migrations.RemoveField causes OperationalError "no such column" upon
migration
-+-
   Reporter:  cessor |  Owner:  nobody
   Type:  Bug| Status:  new
  Component: |Version:  4.1
  Migrations |   Keywords:  Migration Sqlite
   Severity:  Normal |  Docker
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 == Description

 I encountered the following error with django 4.1 in my Gitlab CI/CD
 Pipeline. When I bumped django versions from 4.0.7 to 4.1. my pipeline
 broke during the testing stage; specifically during db migrations. I have
 not changed the any other source code.

 == Steps to reproduce

 Minimal example attached. Run `make green` to see that it works with
 4.0.7, run `make red` to see that it does not work with 4.1.

 Manual steps:

 0. Install django 4.1
 1. Create a new project
 2. Create an app
 3. Install app in project
 4. Create a model
 5. Add field on model
 6. Make migrations
 7. Remove field
 8. Make migrations

 The migration should fail.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e5c59e9-e971d425-327d-4d90-935a-e51d5f148edf-00%40eu-central-1.amazonses.com.

[Django] #33898: Broken usage of ArrayAgg inside Window function

2022-08-05 Thread Django 
#33898: Broken usage of ArrayAgg inside Window function
-+-
   Reporter:  Kia|  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  4.1
  layer (models, ORM)|
   Severity:  Release|   Keywords:  ArrayAgg, Window
  blocker|  function, extend, tuple, params
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 The following query raises an AttributeError.

 {{{

 from django.contrib.postgres.aggregates import ArrayAgg
 from django.db.models.expressions import Window

 SampleModel.objects.all().annotate(
 sample_field=Window(
 expression=ArrayAgg("field_three"),
 partition_by=["field_one", "field_two"],
 )
 )
 }}}

 Traceback:

 {{{
 File "/usr/local/lib/python3.10/site-
 packages/django/db/models/expressions.py", line 1693, in as_sql
   params.extend(window_params)
 AttributeError: 'tuple' object has no attribute 'extend'
 }}}

 Works in Django 4.0.6 (maybe even in 4.0.7, didn't try) but broken in
 Django 4.1.

 Seems like in OrderableAggMixin
 
(https://github.com/django/django/blob/4.1/django/contrib/postgres/aggregates/mixins.py#L23)
 it used to return a `list` as second value, but now it's a `tuple` that
 breaks `params.extend()` in
 https://github.com/django/django/blob/4.1/django/db/models/expressions.py#L1693

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e301f74-c34ead1e-2354-494d-84ff-35f5cf4da89a-00%40eu-central-1.amazonses.com.

Re: [Django] #33897: django.request log for all requests

2022-08-05 Thread Django 
#33897: django.request log for all requests
---+--
 Reporter:  Tim Ioannidis  |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  HTTP handling  |  Version:  4.0
 Severity:  Normal |   Resolution:  wontfix
 Keywords:  logging| Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => wontfix
 * component:  Utilities => HTTP handling


Comment:

 > What's the rationale behind only logging responses with `django.request`
 if status code is >= 400?

 As far as I'm aware web server logs are appropriate place for logging all
 responses. It's not something that must be included in Django itself (see
 also #12012 and LoggingProposal).

 > Do you think we could make this a setting that a user can configure?

 Creating a new setting is always controversial because we already have
 plenty of them. Moreover, you can find many 3rd-party packages (e.g.
 `django-request-logging`, `django-request`)  that will help you to achieve
 this. You can also add a custom middleware that will log all responses in
 the `django.request` logger.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826d903256-2c59edbe-3d02-4660-a4ae-e1b1e27fe345-00%40eu-central-1.amazonses.com.

Re: [Django] #33897: django.request log for all requests

2022-08-05 Thread Django 
#33897: django.request log for all requests
-+--
 Reporter:  chemeng  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  logging  | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Description changed by chemeng:

Old description:

> What's the rationale behind only logging responses with `django.request`
> if status code is >= 400? Do you think we could make this a setting that
> a user can configure?
>
> For me it would be nice if I could use the same logger for all my
> requests coming from gunicorn but now I'm getting only 4XX, 5XX from
> django and all requests within gunicorn. I would ideally like to disable
> gunicorn logging and just capture all requests coming from django
> directly.

New description:

 What's the rationale behind only logging responses with `django.request`
 if status code is >= 400? Do you think we could make this a setting that a
 user can configure?

 For me it would be nice if I could use the same logger for all my requests
 coming from gunicorn but now I'm getting only 4XX, 5XX from django and all
 requests within gunicorn (ending up with duplicate logs for 4XX & 5XX). I
 would ideally like to disable gunicorn logging and just capture all
 requests coming from django directly.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826d6039ec-85a74670-407d-4c37-9ca1-ae67043f7d76-00%40eu-central-1.amazonses.com.

[Django] #33897: django.request log for all requests

2022-08-05 Thread Django 
#33897: django.request log for all requests
---+-
   Reporter:  chemeng  |  Owner:  nobody
   Type:  New feature  | Status:  new
  Component:  Utilities|Version:  4.0
   Severity:  Normal   |   Keywords:  logging
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+-
 What's the rationale behind only logging responses with `django.request`
 if status code is >= 400? Do you think we could make this a setting that a
 user can configure?

 For me it would be nice if I could use the same logger for all my requests
 coming from gunicorn but now I'm getting only 4XX, 5XX from django and all
 requests within gunicorn. I would ideally like to disable gunicorn logging
 and just capture all requests coming from django directly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826d5f8faa-5a006e04-c84e-4c0d-819c-5162ae1d8925-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826d021f7d-94fb0290-ed8a-4fd8-9910-56a7c5d2f7b9-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Fabian Jarrett):

 I messed up a few PRs. Hopefully this one is all good!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826ceef88c-0b152149-960a-4232-a441-8a4403facac5-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Fabian Jarrett):

 Fixed in this pull request: https://github.com/django/django/pull/15917

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826cdcd8cf-95110ef2-ca77-4de0-826b-e73dca159f9a-00%40eu-central-1.amazonses.com.

Re: [Django] #33896: TypeError: requires_system_checks must be a list or tuple.

2022-08-05 Thread Django 
#33896: TypeError: requires_system_checks must be a list or tuple.
-+-
 Reporter:  Eugene Lam   |Owner:  (none)
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  4.1
  commands)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Eugene Lam):

 Replying to [comment:1 Mariusz Felisiak]:
 > Support for boolean values was deprecated in Django 3.2 and removed in
 Django 4.1 (see #31546, c60524c658f197f645b638f9bcc553103bfe2630, and
 1cb495074f6d983096a015736fed16176588cd33).
 thank you

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826cce76e8-5ca0bc29-819c-4fdf-9b87-146a604547f6-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Fabian Jarrett):

 Replying to [comment:7 Mariusz Felisiak]:
 > Fabian, Would you like to prepare a patch? You can use `git revert
 fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa` and add release notes to the
 `4.1.1.txt`.

 Yea, I'll look into it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826cb77d6c-d2b70bb9-de76-4a18-9eeb-15ae0b1972d2-00%40eu-central-1.amazonses.com.

Re: [Django] #33893: Admin add model page incorrectly redirects

2022-08-05 Thread Django 
#33893: Admin add model page incorrectly redirects
-+-
 Reporter:  Fabian Jarrett   |Owner:  Fabian
 |  Jarrett
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Fabian, Would you like to prepare a patch? You can use `git revert
 fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa` and add release notes to the
 `4.1.1.txt`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826cb5719c-3917e3dc-7edf-4d07-a2b3-cd36d49f3f83-00%40eu-central-1.amazonses.com.