Re: [Django] #15111: manage.py test fails if sites app not installed

[Django]

#15111: manage.py test fails if sites app not installed
-+-
 Reporter:  wkornewald   |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Contrib apps |  Version:  SVN
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by wkornewald):

 * cc: wkornewald@… (removed)
 * ui_ux:   => 0
 * type:   => Uncategorized
 * severity:   => Normal
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15111: manage.py test fails if sites app not installed

[Django]

#15111: manage.py test fails if sites app not installed
-+--
   Reporter:  wkornewald | Owner:  nobody
 Status:  new| Milestone:  1.3   
  Component:  Contrib apps   |   Version:  SVN   
 Resolution: |  Keywords:
   Triage Stage:  Ready for checkin  | Has patch:  1 
Needs documentation:  0  |   Needs tests:  0 
Patch needs improvement:  0  |  
-+--
Changes (by wkornewald):

 * cc: wkornewald@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15111: manage.py test fails if sites app not installed

[Django]

#15111: manage.py test fails if sites app not installed
+---
  Reporter:  wkornewald | Owner:  nobody
Status:  new| Milestone:  1.3   
 Component:  Contrib apps   |   Version:  SVN   
Resolution: |  Keywords:
 Stage:  Ready for checkin  | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by wkornewald):

 Maybe if the purpose of the last line is to check if the exception is
 raised even with the Site cache filled we might need a small extra change.
 But then I'd rather extend get_current(), so it's guaranteed to raise
 Site.DoesNotExist if Site._meta.installed is False and have a unit test in
 the sites app for that.

 OTOH, I'd question the whole purpose of testing against a filled cache
 with Site._meta.installed set to False via a hack because then the unit
 test would verify if everything works correctly even if people use ugly
 hacks in their code (i.e., manipulating Site._meta.installed in production
 code).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15111: manage.py test fails if sites app not installed

[Django]

#15111: manage.py test fails if sites app not installed
+---
  Reporter:  wkornewald | Owner:  nobody
Status:  new| Milestone:  1.3   
 Component:  Contrib apps   |   Version:  SVN   
Resolution: |  Keywords:
 Stage:  Ready for checkin  | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Ready for checkin
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Marking RFC because the patch is pretty much ready to use.

 However, I have a suspicion that the very last delta is wrong (or at least
 requires additional thought). The call to get_current() is intended to
 populate a cache; it shouldn't be possible to remove that line without
 consequences.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15111: manage.py test fails if sites app not installed

[Django]

#15111: manage.py test fails if sites app not installed
--+-
 Reporter:  wkornewald|   Owner:  nobody
   Status:  new   |   Milestone:  1.3   
Component:  Contrib apps  | Version:  SVN   
 Keywords:|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 The unit tests of several contrib apps depend on the sites app even though
 the respective contrib app already falls back to RequestSite. The attached
 patch fixes the failing tests (at least the ones I've stumbled upon). Not
 sure how this patch relates to the proposed changes in #15089, though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.