Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+-
 Reporter:  twelveeighty  |Owner:  Sujay S Kumar
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+-

Comment (by Mariusz Felisiak ):

 In [changeset:"aff61790a326f214f5ea608bac8298c3a8716b1b" aff61790]:
 {{{
 #!CommitTicketReference repository=""
 revision="aff61790a326f214f5ea608bac8298c3a8716b1b"
 Refs #24944 -- Added test for overriding domain in email context in
 PasswordResetView.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.9b08533edfdb4e1b65fe7a64aa81e770%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d8d853378b3ff75c03d8bd91ea026d2b8c642b0f" d8d85337]:
 {{{
 #!CommitTicketReference repository=""
 revision="d8d853378b3ff75c03d8bd91ea026d2b8c642b0f"
 Fixed #24944 -- Added extra_email_context parameter to password_reset()
 view.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8cd8559cf5ae1b6c04572095c0625a6e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.98949d57f75ab0093f64f2c95e457465%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by berkerpeksag):

 * needs_better_patch:  0 => 1


Comment:

 Left some trivial review comments. Tim also reviewed the pull request
 yesterday.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.7a467598afb286c4744773950fd2f5b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.07662d74b0028eaf4f799227375040fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.4fc7dcf0d63ae48541f20ab215707794%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * needs_docs:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2d04ad1b27bc36e052d9713e76e51485%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b03b710e671beab8c17dc1e7105145c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---

Comment (by timgraham):

 The password reset function is documented in
 `docs/topics/auth/default.txt`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.9c71db82b9eb6d79abc87dbc1fcfd78c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---

Comment (by SujaySKumar):

 Replying to [comment:4 timgraham]:
 > A ticket isn't marked fixed until the patch is committed to Django. Also
 your patch is missing tests and documentation as outlined in our
 [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/#patch-review-checklist patch review checklist]. Also
 your patch has a problem if someone is using `extra_context` with a key
 that clashes with one in `opts` as I mentioned in comment 1.
 I am new to contributing to open source. I am not able to understand where
 to put the documentation for this new feature. I would be grateful if you
 could point to the file in which I should add the documentation.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.19b0dc255eefcb547ce62302af8c7913%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c0d76181935e6360a2d54ed185720292%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by timgraham):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 A ticket isn't marked fixed until the patch is committed to Django. Also
 your patch is missing tests and documentation as outlined in our
 [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/#patch-review-checklist patch review checklist]. Also
 your patch has a problem if someone is using `extra_context` with a key
 that clashes with one in `opts` as I mentioned in comment 1.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b3cfa7d7840e2b7cc55327723f7b3db2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * status:  assigned => closed
 * needs_docs:  0 => 1
 * has_patch:  0 => 1
 * resolution:   => fixed
 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.61524c39c1d9a0a555e173096ce85c1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+---
 Reporter:  twelveeighty  |Owner:  SujaySKumar
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+---
Changes (by SujaySKumar):

 * status:  new => assigned
 * cc: sujay.skumar141295@… (added)
 * owner:  nobody => SujaySKumar


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.0329583f095db9fbf664f17007e502c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
--+
 Reporter:  twelveeighty  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * component:  Uncategorized => contrib.auth
 * needs_tests:   => 0
 * needs_docs:   => 0
 * has_patch:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 I guess it's unlikely, but we'd have a small backwards compatibility issue
 if someone is using `extra_context` with a key that clashes with one in
 `opts`. For that reason, it might be better to use a separate parameter.

 There is also the idea of converting these views to class-based views in
 #17209 which might help here.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.578b64d5861982d6e04811937cff2339%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24944: Have password_reset pass extra_context to the email template rendering as well

[Django]

#24944: Have password_reset pass extra_context to the email template rendering 
as
well
---+
 Reporter:  twelveeighty   |  Owner:  nobody
 Type:  New feature| Status:  new
Component:  Uncategorized  |Version:  1.8
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  1  |  UI/UX:  0
---+
 The password_reset function in auth.views currently allows for extra
 context parameters to be passed to the rendered reset password form, but
 it does not pass through those extra context parameters to the 'opt'
 dictionary used for the email template. This should be an easy feature to
 add: just before the form.save(), add the extra_context to the opts
 dictionary:

 {{{
 # inside the request.method == 'POST' and form.isValid() block:
 opts = {  ...  }
 if extra_context is not None:
opts.update(extra_context)
 form.save(**opts)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.f61b6ede8ef3f1ddb8b4f99fc84e729f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.