Re: [dm-devel] [PATCH] multipath-tools: use internal drd.h file

2016-10-16 Thread Christophe Varoqui 
That's why we included a copy of the required valgrind header.
Does this solution eleviate your complain ?

On Sun, Oct 16, 2016 at 6:59 PM, Hannes Reinecke  wrote:

> On 10/16/2016 12:26 PM, Xose Vazquez Perez wrote:
>
>> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:
>>
>> Cc: Bart Van Assche 
>>> Cc: Christophe Varoqui 
>>> Cc: device-mapper development 
>>> Signed-off-by: Xose Vazquez Perez 
>>> ---
>>>  libmultipath/debug.c | 2 +-
>>>  multipathd/main.c| 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>> This patch is missing.
>> Thank you.
>>
>>
>> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
>>> index 295136c..fbe171a 100644
>>> --- a/libmultipath/debug.c
>>> +++ b/libmultipath/debug.c
>>> @@ -8,7 +8,7 @@
>>>  #include "log_pthread.h"
>>>  #include 
>>>  #include 
>>> -#include <../third-party/valgrind/drd.h>
>>> +#include "../third-party/valgrind/drd.h"
>>>  #include "vector.h"
>>>  #include "config.h"
>>>
>>> diff --git a/multipathd/main.c b/multipathd/main.c
>>> index cdfafe8..0998085 100644
>>> --- a/multipathd/main.c
>>> +++ b/multipathd/main.c
>>> @@ -23,7 +23,6 @@
>>>  #endif
>>>  #include 
>>>  #include 
>>> -#include 
>>>
>>>  /*
>>>   * libmultipath
>>> @@ -85,6 +84,7 @@ int uxsock_timeout;
>>>  #include "lock.h"
>>>  #include "waiter.h"
>>>  #include "wwids.h"
>>> +#include "../third-party/valgrind/drd.h"
>>>
>>>  #define FILE_NAME_SIZE 256
>>>  #define CMDSIZE 160
>>>
>>>
>> Please don't.
> We're trying to keep dependencies to each package as small as possible.
> And requiring valgrind by default is not going to help here.
> Please make this a compile-time option.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke   zSeries & Storage
> h...@suse.de  +49 911 74053 688
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
>
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: use internal drd.h file

2016-10-16 Thread Hannes Reinecke 

On 10/16/2016 12:26 PM, Xose Vazquez Perez wrote:

On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:


Cc: Bart Van Assche 
Cc: Christophe Varoqui 
Cc: device-mapper development 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/debug.c | 2 +-
 multipathd/main.c| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


This patch is missing.
Thank you.



diff --git a/libmultipath/debug.c b/libmultipath/debug.c
index 295136c..fbe171a 100644
--- a/libmultipath/debug.c
+++ b/libmultipath/debug.c
@@ -8,7 +8,7 @@
 #include "log_pthread.h"
 #include 
 #include 
-#include <../third-party/valgrind/drd.h>
+#include "../third-party/valgrind/drd.h"
 #include "vector.h"
 #include "config.h"

diff --git a/multipathd/main.c b/multipathd/main.c
index cdfafe8..0998085 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -23,7 +23,6 @@
 #endif
 #include 
 #include 
-#include 

 /*
  * libmultipath
@@ -85,6 +84,7 @@ int uxsock_timeout;
 #include "lock.h"
 #include "waiter.h"
 #include "wwids.h"
+#include "../third-party/valgrind/drd.h"

 #define FILE_NAME_SIZE 256
 #define CMDSIZE 160




Please don't.
We're trying to keep dependencies to each package as small as possible.
And requiring valgrind by default is not going to help here.
Please make this a compile-time option.

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: add VIOLIN arrays to hardware table

2016-10-16 Thread Hannes Reinecke 

On 10/15/2016 01:50 PM, Xose Vazquez Perez wrote:

Based on documentation provided by the manufacturer:
https://drive.google.com/open?id=0B_B6YmEmO7cDQlMzc1BsaUxZRVU

Cc: Christophe Varoqui 
Cc: device-mapper development 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index aca46ab..e34032d 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -944,6 +944,32 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
.no_path_retry = 12,
},
+   /*
+* Violin Memory
+*/
+   {
+   /* V3000 / V6000 Series */
+   .vendor= "VIOLIN",
+   .product   = "SAN ARRAY$",
+   .pgpolicy  = GROUP_BY_SERIAL,
+   .no_path_retry = 30,
+   },
+   {
+   .vendor= "VIOLIN",
+   .product   = "SAN ARRAY ALUA",
+   .hwhandler = "1 alua",
+   .pgpolicy  = GROUP_BY_PRIO,
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   .prio_name = PRIO_ALUA,
+   .no_path_retry = 30,
+   },
+   {
+   /* FSP 7000 family */
+   .vendor= "VIOLIN",
+   .product   = "CONCERTO ARRAY",
+   .pgpolicy  = MULTIBUS,
+   .no_path_retry = 30,
+   },
 #if 0
/*
 * Copy this TEMPLATE to add new hardware.


Where's the point of the first and the third entry?
They'll be identical to the default settings, no?

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: use internal drd.h file

2016-10-16 Thread Christophe Varoqui 
Merged.
Thanks.

On Sun, Oct 16, 2016 at 12:26 PM, Xose Vazquez Perez  wrote:

> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:
>
> > Cc: Bart Van Assche 
> > Cc: Christophe Varoqui 
> > Cc: device-mapper development 
> > Signed-off-by: Xose Vazquez Perez 
> > ---
> >  libmultipath/debug.c | 2 +-
> >  multipathd/main.c| 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
>
> This patch is missing.
> Thank you.
>
>
> > diff --git a/libmultipath/debug.c b/libmultipath/debug.c
> > index 295136c..fbe171a 100644
> > --- a/libmultipath/debug.c
> > +++ b/libmultipath/debug.c
> > @@ -8,7 +8,7 @@
> >  #include "log_pthread.h"
> >  #include 
> >  #include 
> > -#include <../third-party/valgrind/drd.h>
> > +#include "../third-party/valgrind/drd.h"
> >  #include "vector.h"
> >  #include "config.h"
> >
> > diff --git a/multipathd/main.c b/multipathd/main.c
> > index cdfafe8..0998085 100644
> > --- a/multipathd/main.c
> > +++ b/multipathd/main.c
> > @@ -23,7 +23,6 @@
> >  #endif
> >  #include 
> >  #include 
> > -#include 
> >
> >  /*
> >   * libmultipath
> > @@ -85,6 +84,7 @@ int uxsock_timeout;
> >  #include "lock.h"
> >  #include "waiter.h"
> >  #include "wwids.h"
> > +#include "../third-party/valgrind/drd.h"
> >
> >  #define FILE_NAME_SIZE 256
> >  #define CMDSIZE 160
> >
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: merge dcssblk in similar blacklist regex

2016-10-16 Thread Xose Vazquez Perez 
Similar patterns.

Cc: Christophe Varoqui 
Cc: device-mapper development 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/blacklist.c   | 8 +---
 multipath/multipath.conf.5 | 2 +-
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c
index aa8d975..f6c4506 100644
--- a/libmultipath/blacklist.c
+++ b/libmultipath/blacklist.c
@@ -172,7 +172,7 @@ setup_default_blist (struct config * conf)
char * str;
int i;
 
-   str = STRDUP("^(ram|raw|loop|fd|md|dm-|sr|scd|st)[0-9]");
+   str = STRDUP("^(ram|raw|loop|fd|md|dm-|sr|scd|st|dcssblk)[0-9]");
if (!str)
return 1;
if (store_ble(conf->blist_devnode, str, ORIGIN_DEFAULT))
@@ -184,12 +184,6 @@ setup_default_blist (struct config * conf)
if (store_ble(conf->blist_devnode, str, ORIGIN_DEFAULT))
return 1;
 
-   str = STRDUP("^dcssblk[0-9]");
-   if (!str)
-   return 1;
-   if (store_ble(conf->blist_devnode, str, ORIGIN_DEFAULT))
-   return 1;
-
str = STRDUP("^nvme");
if (!str)
return 1;
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 313e21b..367688e 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -851,7 +851,7 @@ The following keywords are recognized:
 Regular expression of the device nodes to be excluded.
 .RS
 .TP
-Default value is: \fB^(ram|raw|loop|fd|md|dm-|sr|scd|st)[0-9]\fR, 
\fB^(td|hd|vd)[a-z]\fR, \fB^dcssblk[0-9]\fR and \fB^nvme\fR
+Default value is: \fB^(ram|raw|loop|fd|md|dm-|sr|scd|st|dcssblk)[0-9]\fR, 
\fB^(td|hd|vd)[a-z]\fR and \fB^nvme\fR
 .RE
 .TP
 .B wwid
-- 
2.10.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: use internal drd.h file

2016-10-16 Thread Xose Vazquez Perez 
On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:

> Cc: Bart Van Assche 
> Cc: Christophe Varoqui 
> Cc: device-mapper development 
> Signed-off-by: Xose Vazquez Perez 
> ---
>  libmultipath/debug.c | 2 +-
>  multipathd/main.c| 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

This patch is missing.
Thank you.


> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
> index 295136c..fbe171a 100644
> --- a/libmultipath/debug.c
> +++ b/libmultipath/debug.c
> @@ -8,7 +8,7 @@
>  #include "log_pthread.h"
>  #include 
>  #include 
> -#include <../third-party/valgrind/drd.h>
> +#include "../third-party/valgrind/drd.h"
>  #include "vector.h"
>  #include "config.h"
>  
> diff --git a/multipathd/main.c b/multipathd/main.c
> index cdfafe8..0998085 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -23,7 +23,6 @@
>  #endif
>  #include 
>  #include 
> -#include 
>  
>  /*
>   * libmultipath
> @@ -85,6 +84,7 @@ int uxsock_timeout;
>  #include "lock.h"
>  #include "waiter.h"
>  #include "wwids.h"
> +#include "../third-party/valgrind/drd.h"
>  
>  #define FILE_NAME_SIZE 256
>  #define CMDSIZE 160
> 

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel