Re: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
Hi Dario,
kernel test robot noticed the following build warnings:
[auto build test WARNING on atorgue-stm32/stm32-next]
[also build test WARNING on drm-misc/drm-misc-next lee-mfd/for-mfd-next
robh/for-next linus/master v6.7-rc7 next-20231222]
[cannot apply to lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Dario-Binacchi/dt-bindings-mfd-stm32f7-Add-binding-definition-for-DSI/20231229-215601
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
patch link:
https://lore.kernel.org/r/20231229135154.675946-6-dario.binacchi%40amarulasolutions.com
patch subject: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA
FRD400B25025-A-CTK
:: branch date: 20 hours ago
:: commit date: 20 hours ago
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce:
(https://download.01.org/0day-ci/archive/20231230/202312301748.2brgs7xs-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes: https://lore.kernel.org/r/202312301748.2brgs7xs-...@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7:
>> [error] duplication of key "items" in mapping (key-duplicates)
--
>> Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7:
>> found duplicate key "items" with value "[]" (original value: "[]")
Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml:
properties:honeywell,pmin-pascal: '$ref' should not be valid under {'const':
'$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml:
properties:honeywell,pmax-pascal: '$ref' should not be valid under {'const':
'$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
--
>> Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:
>> ignoring, error parsing file
Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing
type definition
vim +/items +21
Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
5ce96fe032f43e Linus Walleij 2020-02-23 8
5ce96fe032f43e Linus Walleij 2020-02-23 9 maintainers:
5ce96fe032f43e Linus Walleij 2020-02-23 10- Linus Walleij
5ce96fe032f43e Linus Walleij 2020-02-23 11
5ce96fe032f43e Linus Walleij 2020-02-23 12 allOf:
5ce96fe032f43e Linus Walleij 2020-02-23 13- $ref: panel-common.yaml#
5ce96fe032f43e Linus Walleij 2020-02-23 14
5ce96fe032f43e Linus Walleij 2020-02-23 15 properties:
5ce96fe032f43e Linus Walleij 2020-02-23 16compatible:
859f1d9e26606c Dario Binacchi 2023-12-29 17 oneOf:
5ce96fe032f43e Linus Walleij 2020-02-23 18items:
5ce96fe032f43e Linus Walleij 2020-02-23 19 - const: hydis,hva40wv1
5ce96fe032f43e Linus Walleij 2020-02-23 20 - const: novatek,nt35510
859f1d9e26606c Dario Binacchi 2023-12-29 @21items:
859f1d9e26606c Dario Binacchi 2023-12-29 22 - const:
frida,frd400b25025
859f1d9e26606c Dario Binacchi 2023-12-29 23 - const: novatek,nt35510
5ce96fe032f43e Linus Walleij 2020-02-23 24description: This indicates
the panel manufacturer of the panel
5ce96fe032f43e Linus Walleij 2020-02-23 25 that is in turn using the
NT35510 panel driver. The compatible
5ce96fe032f43e Linus Walleij 2020-02-23 26 string determines how the
NT35510 panel driver shall be configured
5ce96fe032f43e Linus Walleij 2020-02-23 27 to work with the
indicated panel. The novatek,nt35510 compatible shall
5ce96fe032f43e Linus Walleij 2020-02-23 28 always be provided as a
fallback.
5ce96fe032f43e Linus Walleij 2020-02-23 29reg: true
5ce96fe032f43e Linus Walleij 2020-02-23 30reset-gpios: true
5ce96fe032f43e Linus Walleij 2020-02-23 31vdd-supply:
5ce96fe032f43e Linus Walleij 2020-02-23 32 description: regulator that
supplies the vdd voltage
5ce96fe032f43e Linus Walleij 2020-02-23 33vddi-supply:
5ce96fe032f43e Linus Walleij 2020-02-23 34 description: regulator that
supplies the vddi voltage
5ce96fe032f43e Linus Walleij 2020-02-23 35backlight: true
5ce96fe032f43e Linus Walleij 2020-02-23 36
5ce96fe032f43e Linus Walleij 2020-02-23 37 required:
5ce96fe032f43e Linus Walleij 2020-02-23 38- compatible
5ce96fe032f43e Linus Walleij 2020-02-23 39- reg
5ce96fe032f43e Linus Walleij 2020-02-23 40
--
0-DAY CI
[PATCH] drm/amd/display: dcn35_hwseq: use common comment to prevent kernel-doc warnings
Change non-kernel-doc comments to use "/*" to prevent warnings from scripts/kernel-doc. dcn35_hwseq.c:1124: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * power down sequence dcn35_hwseq.c:1124: warning: missing initial short description on line: * power down sequence dcn35_hwseq.c:1176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * power up sequence dcn35_hwseq.c:1176: warning: missing initial short description on line: * power up sequence Signed-off-by: Randy Dunlap Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- I thought that I sent this patch but it's not in the lore archive so I'm sending it again. Apologies if you get it twice. drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c @@ -1120,7 +1120,7 @@ void dcn35_calc_blocks_to_ungate(struct update_state->pg_res_update[PG_HPO] = true; } -/** +/* * power down sequence * ONO Region 3, DCPG 25: hpo - SKIPPED * ONO Region 4, DCPG 0: dchubp0, dpp0 @@ -1172,7 +1172,7 @@ void dcn35_hw_block_power_down(struct dc //domain22, 23, 25 currently always on. } -/** +/* * power up sequence * ONO Region 0, DCPG 22: dccg dio dcio - SKIPPED * ONO Region 2, DCPG 24: mpc opp optc dwb
[syzbot] [dri?] [media?] memory leak in get_sg_table
Hello, syzbot found the following issue on: HEAD commit:fbafc3e621c3 Merge tag 'for_linus' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10ae11cee8 kernel config: https://syzkaller.appspot.com/x/.config?x=e81921f96ae24ec0 dashboard link: https://syzkaller.appspot.com/bug?extid=9b4adfed366b14496e7e compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1635d436e8 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15e8171ae8 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/76e4a40f41aa/disk-fbafc3e6.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/a2f88511ce98/vmlinux-fbafc3e6.xz kernel image: https://storage.googleapis.com/syzbot-assets/2b21933ed8f1/bzImage-fbafc3e6.xz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+9b4adfed366b14496...@syzkaller.appspotmail.com Warning: Permanently added '10.128.0.162' (ED25519) to the list of known hosts. executing program executing program BUG: memory leak unreferenced object 0x88810af03840 (size 16): comm "syz-executor111", pid 5038, jiffies 4294942820 (age 13.250s) hex dump (first 16 bytes): 80 8b 89 0b 81 88 ff ff 04 00 00 00 04 00 00 00 backtrace: [] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline] [] slab_post_alloc_hook mm/slab.h:766 [inline] [] slab_alloc_node mm/slub.c:3478 [inline] [] __kmem_cache_alloc_node+0x2dd/0x3f0 mm/slub.c:3517 [] kmalloc_trace+0x25/0x90 mm/slab_common.c:1098 [] kmalloc include/linux/slab.h:600 [inline] [] kzalloc include/linux/slab.h:721 [inline] [] get_sg_table.isra.0+0x2a/0xe0 drivers/dma-buf/udmabuf.c:93 [] begin_cpu_udmabuf+0x63/0xa0 drivers/dma-buf/udmabuf.c:156 [] dma_buf_begin_cpu_access+0x3b/0xc0 drivers/dma-buf/dma-buf.c:1402 [] dma_buf_ioctl+0x550/0x660 drivers/dma-buf/dma-buf.c:475 [] vfs_ioctl fs/ioctl.c:51 [inline] [] __do_sys_ioctl fs/ioctl.c:871 [inline] [] __se_sys_ioctl fs/ioctl.c:857 [inline] [] __x64_sys_ioctl+0xf2/0x140 fs/ioctl.c:857 [] do_syscall_x64 arch/x86/entry/common.c:52 [inline] [] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:83 [] entry_SYSCALL_64_after_hwframe+0x63/0x6b BUG: memory leak unreferenced object 0x88810b898b80 (size 128): comm "syz-executor111", pid 5038, jiffies 4294942820 (age 13.250s) hex dump (first 32 bytes): c0 09 2a 04 00 ea ff ff 00 00 00 00 00 10 00 00 ..*. 00 70 82 0a 01 00 00 00 00 10 00 00 00 00 00 00 .p.. backtrace: [] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline] [] slab_post_alloc_hook mm/slab.h:766 [inline] [] slab_alloc_node mm/slub.c:3478 [inline] [] __kmem_cache_alloc_node+0x2dd/0x3f0 mm/slub.c:3517 [] __do_kmalloc_node mm/slab_common.c:1006 [inline] [] __kmalloc+0x4b/0x150 mm/slab_common.c:1020 [] kmalloc_array include/linux/slab.h:637 [inline] [] sg_kmalloc lib/scatterlist.c:167 [inline] [] get_next_sg lib/scatterlist.c:402 [inline] [] sg_alloc_append_table_from_pages+0x35f/0x770 lib/scatterlist.c:526 [] sg_alloc_table_from_pages_segment+0x8c/0x120 lib/scatterlist.c:586 [] sg_alloc_table_from_pages include/linux/scatterlist.h:477 [inline] [] get_sg_table.isra.0+0x5e/0xe0 drivers/dma-buf/udmabuf.c:96 [] begin_cpu_udmabuf+0x63/0xa0 drivers/dma-buf/udmabuf.c:156 [] dma_buf_begin_cpu_access+0x3b/0xc0 drivers/dma-buf/dma-buf.c:1402 [] dma_buf_ioctl+0x550/0x660 drivers/dma-buf/dma-buf.c:475 [] vfs_ioctl fs/ioctl.c:51 [inline] [] __do_sys_ioctl fs/ioctl.c:871 [inline] [] __se_sys_ioctl fs/ioctl.c:857 [inline] [] __x64_sys_ioctl+0xf2/0x140 fs/ioctl.c:857 [] do_syscall_x64 arch/x86/entry/common.c:52 [inline] [] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:83 [] entry_SYSCALL_64_after_hwframe+0x63/0x6b --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkal...@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. If the report is already addressed, let syzbot know by replying with: #syz fix: exact-commit-title If you want syzbot to run the reproducer, reply with: #syz test: git://repo/address.git branch-or-commit-hash If you attach or paste a git patch, syzbot will apply it before testing. If you want to overwrite report's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the report is a duplicate of another one, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup
[PATCH 4/4] drm/nouveau/volt/gk20a: don't misuse kernel-doc comments
Change kernel-doc "/**" comments to common "/*" comments to prevent
kernel-doc warnings:
gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc
comment. Refer Documentation/doc-guide/kernel-doc.rst
* cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
gk20a.c:49: warning: missing initial short description on line:
* cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc
comment. Refer Documentation/doc-guide/kernel-doc.rst
* cvb_t_mv =
gk20a.c:62: warning: missing initial short description on line:
* cvb_t_mv =
Signed-off-by: Randy Dunlap
Cc: Karol Herbst
Cc: Lyude Paul
Cc: Danilo Krummrich
Cc: nouv...@lists.freedesktop.org
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
@@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_c
/* 852 */ { 1608418, -21643, -269, 0,763, -48},
};
-/**
+/*
* cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
*/
static inline int
@@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, i
return mv;
}
-/**
+/*
* cvb_t_mv =
* ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
* ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
[PATCH 2/4] drm/nouveau: don't misuse kernel-doc comments
Change kernel-doc "/**" comments to common "/*" comments to prevent kernel-doc warnings: nouveau_ioc32.c:2: warning: Cannot understand * \file mga_ioc32.c on line 2 - I thought it was a doc line nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl' nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in 'nouveau_compat_ioctl' nouveau_ioc32.c:52: warning: Function parameter or member 'arg' not described in 'nouveau_compat_ioctl' nouveau_ioc32.c:52: warning: expecting prototype for Called whenever a 32-bit process running under a 64(). Prototype was for nouveau_compat_ioctl() instead Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_ioc32.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c --- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c +++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c @@ -1,4 +1,4 @@ -/** +/* * \file mga_ioc32.c * * 32-bit ioctl compatibility routines for the MGA DRM. @@ -38,7 +38,7 @@ #include "nouveau_ioctl.h" -/** +/* * Called whenever a 32-bit process running under a 64-bit kernel * performs an ioctl on /dev/dri/card. *
[PATCH 3/4] drm/nouveau/gr/gf100: don't misuse kernel-doc comments
Change kernel-doc "/**" comments to common "/*" comments to prevent kernel-doc warnings: gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Wait until GR goes idle. GR is considered idle if it is disabled by the gf100.c:1044: warning: missing initial short description on line: * Wait until GR goes idle. GR is considered idle if it is disabled by the Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c @@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr) } } -/** +/* * Wait until GR goes idle. GR is considered idle if it is disabled by the * MC (0x200) register, or GR is not busy and a context switch is not in * progress.
[PATCH 1/4] drm/nouveau/disp: don't misuse kernel-doc comments
Change kernel-doc "/**" comments to common "/*" comments to prevent kernel-doc warnings: crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Sets up registers for the given mode/adjusted_mode pair. crtc.c:453: warning: missing initial short description on line: * Sets up registers for the given mode/adjusted_mode pair. crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Sets up registers for the given mode/adjusted_mode pair. crtc.c:629: warning: missing initial short description on line: * Sets up registers for the given mode/adjusted_mode pair. Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c @@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *cr regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off. @@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, return ret; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off.
[PATCH] drm/amdkfd: fixes for HMM mem allocation
Few fixes to amdkfd and the doc of
devm_request_free_mem_region.
Signed-off-by: Dafna Hirschfeld
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 6 +++---
kernel/resource.c| 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
index 6c25dab051d5..b8680e0753ca 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
@@ -1021,7 +1021,7 @@ int kgd2kfd_init_zone_device(struct amdgpu_device *adev)
} else {
res = devm_request_free_mem_region(adev->dev, _resource,
size);
if (IS_ERR(res))
- return -ENOMEM;
+ return PTR_ERR(res);
pgmap->range.start = res->start;
pgmap->range.end = res->end;
pgmap->type = MEMORY_DEVICE_PRIVATE;
@@ -1037,10 +1037,10 @@ int kgd2kfd_init_zone_device(struct amdgpu_device *adev)
r = devm_memremap_pages(adev->dev, pgmap);
if (IS_ERR(r)) {
pr_err("failed to register HMM device memory\n");
- /* Disable SVM support capability */
- pgmap->type = 0;
if (pgmap->type == MEMORY_DEVICE_PRIVATE)
devm_release_mem_region(adev->dev, res->start,
resource_size(res));
+ /* Disable SVM support capability */
+ pgmap->type = 0;
return PTR_ERR(r);
}
diff --git a/kernel/resource.c b/kernel/resource.c
index 866ef3663a0b..fe890b874606 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1905,8 +1905,8 @@ get_free_mem_region(struct device *dev, struct resource
*base,
* devm_request_free_mem_region - find free region for device private memory
*
* @dev: device struct to bind the resource to
- * @size: size in bytes of the device memory to add
* @base: resource tree to look in
+ * @size: size in bytes of the device memory to add
*
* This function tries to find an empty range of physical address big enough to
* contain the new resource, so that it can later be hotplugged as ZONE_DEVICE
--
2.34.1
Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio
On 2023-12-19 at 17:54:19 +0100, Jernej Škrabec wrote: > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns > napisal(a): >> The Allwinner A64 manual lists the following constraint for the >> PLL-VIDEO0 clock: 8 <= N/M <= 25 >> >> Use this constraint. >> >> Signed-off-by: Frank Oltmanns >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> index c034ac027d1c..75d839da446c 100644 >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_base_clk, >> "pll-audio-base", >> BIT(28), /* lock */ >> CLK_SET_RATE_UNGATE); >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk, >> "pll-video0", >> +static >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_video0_clk, >> +"pll-video0", >> "osc24M", 0x010, >> 19200, /* Minimum rate >> */ >> 100800, /* Maximum rate >> */ I just realized that adding the whole ratio limits for ccu_nm is superfluous as you could just as well express them in for of a minimum and maximum range: Since 8 <= N/M <= 25 and parent_rate = 24 MHz, therefore 192 MHz <= rate <= 600 MHz. These absolute limits are also listed in Allwinner's A64 manual. BUT, here the upper limit was raised to 1008 MHz: 5de39acaf34604bd04834f092479cf4dcc946dd "clk: sunxi-ng: a64: Add max. rate constraint to video PLL" With this upper limit the ratio limitation is effectively: 8 <= N/M <= 42 Icenowy Zheng (added to CC) had the reasonable explanation that this was used in the BSP kernel, so we should probably stick to that and ditch the two PLL-VIDEO0 related patches. What are your thoughts on that? >> @@ -80,7 +81,10 @@ static >> SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk, "pll-vid >> 29700, /* frac rate 1 >> */ >> BIT(31),/* gate */ >> BIT(28),/* lock */ >> -CLK_SET_RATE_UNGATE); >> +CLK_SET_RATE_UNGATE, >> +CCU_FEATURE_FRACTIONAL | >> +CCU_FEATURE_CLOSEST_RATE, > > Above flags are unrelated change, put them in new patch if needed. > > Best regards, > Jernej > >> +8, 25); /* min/max nm >> ratio */ >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> "osc24M", 0x018, >> >>
