Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On Thu, May 25, 2023 at 08:37:07AM -0700, Kees Cook wrote:
> Hi!
>
> On Wed, May 24, 2023 at 04:27:31PM -0400, Hamza Mahfooz wrote:
> > + Kees
> >
> > On 5/24/23 15:50, Alex Deucher wrote:
> > > On Wed, May 24, 2023 at 3:46 PM Felix Kuehling
> > > wrote:
> > > >
> > > > Sure, I think we tried enabling warnings as errors before and had to
> > > > revert it because of weird compiler quirks or the variety of compiler
> > > > versions that need to be supported.
> > > >
> > > > Alex, are you planning to upstream this, or is this only to enforce more
> > > > internal discipline about not ignoring warnings?
> > >
> > > I'd like to upstream it. Upstream already has CONFIG_WERROR as a
> > > config option, but it's been problematic to enable in CI because of
> > > various breakages outside of the driver and in different compilers.
> > > That said, I don't know how much trouble enabling it will cause with
> > > various compilers in the wild.
>
> -Wmisleading-indentation is already part of -Wall, so this is globally
> enabled already.
>
> -Wunused is enabled under W=1, and it's pretty noisy still. If you can
> get builds clean in drm, that'll be a good step towards getting it
> enabled globally. (A middle ground with less to clean up might be
> -Wunused-but-set-variable)
>
> I agree about -Werror: just stick with CONFIG_WERROR instead.
There is also W=e, added by commit c77d06e70d59 ("kbuild: support W=e
to make build abort in case of warning") in 5.19, which works well for
building with configurations that do not have CONFIG_WERROR enabled and
avoiding dipping into menuconfig.
Unconditionally enabling -Werror with no way to turn it off is just
asking for problems over time with new compiler versions, either due to
new warnings in -Wall or warnings that have been improved or changed.
Should that still be desired, consider doing what i915 and PowerPC have
done and add a Kconfig option that can be disabled.
Cheers,
Nathan
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
Hi! On Wed, May 24, 2023 at 04:27:31PM -0400, Hamza Mahfooz wrote: > + Kees > > On 5/24/23 15:50, Alex Deucher wrote: > > On Wed, May 24, 2023 at 3:46 PM Felix Kuehling > > wrote: > > > > > > Sure, I think we tried enabling warnings as errors before and had to > > > revert it because of weird compiler quirks or the variety of compiler > > > versions that need to be supported. > > > > > > Alex, are you planning to upstream this, or is this only to enforce more > > > internal discipline about not ignoring warnings? > > > > I'd like to upstream it. Upstream already has CONFIG_WERROR as a > > config option, but it's been problematic to enable in CI because of > > various breakages outside of the driver and in different compilers. > > That said, I don't know how much trouble enabling it will cause with > > various compilers in the wild. -Wmisleading-indentation is already part of -Wall, so this is globally enabled already. -Wunused is enabled under W=1, and it's pretty noisy still. If you can get builds clean in drm, that'll be a good step towards getting it enabled globally. (A middle ground with less to clean up might be -Wunused-but-set-variable) I agree about -Werror: just stick with CONFIG_WERROR instead. -Kees > > > > Alex > > > > > > > > Regards, > > > Felix > > > > > > > > > On 2023-05-24 15:41, Russell, Kent wrote: > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > > > (Adding Felix in CC) > > > > > > > > I’m a fan of adding it to KFD as well. Felix, can you foresee any > > > > issues here? > > > > > > > > Kent > > > > > > > > *From:* amd-gfx *On Behalf Of > > > > *Ho, Kenny > > > > *Sent:* Wednesday, May 24, 2023 3:23 PM > > > > *To:* Alex Deucher ; Mahfooz, Hamza > > > > > > > > *Cc:* Li, Sun peng (Leo) ; Wentland, Harry > > > > ; Pan, Xinhui ; Siqueira, > > > > Rodrigo ; linux-ker...@vger.kernel.org; > > > > dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel > > > > Vetter ; Deucher, Alexander > > > > ; David Airlie ; Koenig, > > > > Christian > > > > *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile > > > > checks > > > > > > > > [AMD Official Use Only - General] > > > > > > > > [AMD Official Use Only - General] > > > > > > > > (+ Felix) > > > > > > > > Should we do the same for other modules under amd (amdkfd)? I was > > > > going to enable full kernel werror in the kconfig used by my CI but > > > > this is probably better. > > > > > > > > Kenny > > > > > > > > > > > > > > > > *From:*Alex Deucher > > > > *Sent:* Wednesday, May 24, 2023 3:22 PM > > > > *To:* Mahfooz, Hamza > > > > *Cc:* amd-...@lists.freedesktop.org ; > > > > Li, Sun peng (Leo) ; Ho, Kenny ; > > > > Pan, Xinhui ; Siqueira, Rodrigo > > > > ; linux-ker...@vger.kernel.org > > > > ; dri-devel@lists.freedesktop.org > > > > ; Daniel Vetter ; > > > > Deucher, Alexander ; David Airlie > > > > ; Wentland, Harry ; Koenig, > > > > Christian > > > > *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile > > > > checks > > > > > > > > On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz > > > > wrote: > > > > > > > > > > Currently, there are quite a number of issues that are quite easy for > > > > > the CI to catch, that slip through the cracks. Among them, there are > > > > > unused variable and indentation issues. Also, we should consider all > > > > > warnings to be compile errors, since the community will eventually end > > > > > up complaining about them. So, enable -Werror, -Wunused and > > > > > -Wmisleading-indentation for all kernel builds. > > > > > > > > > > Cc: Alex Deucher > > > > > Cc: Harry Wentland > > > > > Cc: Kenny Ho > > > > > Signed-off-by: Hamza Mahfooz > > > > > --- > > > > > v2: fix grammatical error > > > > > --- > > > > > drivers/gpu/drm/amd/display/Makefile | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/gpu/drm/amd/display/Makefile > > > > b/drivers/gpu/drm/amd/display/Makefile > > > > > index 0d610cb376bb..3c44162ebe21 100644 > > > > > --- a/drivers/gpu/drm/amd/display/Makefile > > > > > +++ b/drivers/gpu/drm/amd/display/Makefile > > > > > @@ -26,6 +26,8 @@ > > > > > > > > > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > > > > > > > > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > > > > > + > > > > > > > > Care to enable this for the rest of amdgpu as well? Or send out an > > > > additional patch to do that? Either way: > > > > Reviewed-by: Alex Deucher > > > > > > > > Alex > > > > > > > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > > > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > > > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > > > > > -- > > > > > 2.40.1 > > > > > > > > > > -- > Hamza > -- Kees Cook
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On Wed, 24 May 2023, Hamza Mahfooz wrote: > + Kees > > On 5/24/23 15:50, Alex Deucher wrote: >> On Wed, May 24, 2023 at 3:46 PM Felix Kuehling >> wrote: >>> >>> Sure, I think we tried enabling warnings as errors before and had to >>> revert it because of weird compiler quirks or the variety of compiler >>> versions that need to be supported. >>> >>> Alex, are you planning to upstream this, or is this only to enforce more >>> internal discipline about not ignoring warnings? >> >> I'd like to upstream it. Upstream already has CONFIG_WERROR as a >> config option, but it's been problematic to enable in CI because of >> various breakages outside of the driver and in different compilers. >> That said, I don't know how much trouble enabling it will cause with >> various compilers in the wild. FWIW, I think it's a bit scary to enable -Werror unconditionally. You'll then need to take into account *all* compilers the kernel build supports. I'd hate to fail the build for someone trying out a new compiler that has some new warnings. In i915, we've added our own kconfig for this that we tell our developers to use and have enabled in our CI. It also depends on !COMPILE_TEST to not get enabled by allmodconfig/allyesconfig configs. The Makefile then has: subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror On a somewhat related side note, it would be great to be able to enable the equivalent of W=1 on a subdir level. Now we need to add basically the same stuff one by one. Cc: Masahiro. BR, Jani. >> >> Alex >> >>> >>> Regards, >>> Felix >>> >>> >>> On 2023-05-24 15:41, Russell, Kent wrote: >>>> >>>> [AMD Official Use Only - General] >>>> >>>> >>>> (Adding Felix in CC) >>>> >>>> I’m a fan of adding it to KFD as well. Felix, can you foresee any >>>> issues here? >>>> >>>> Kent >>>> >>>> *From:* amd-gfx *On Behalf Of >>>> *Ho, Kenny >>>> *Sent:* Wednesday, May 24, 2023 3:23 PM >>>> *To:* Alex Deucher ; Mahfooz, Hamza >>>> >>>> *Cc:* Li, Sun peng (Leo) ; Wentland, Harry >>>> ; Pan, Xinhui ; Siqueira, >>>> Rodrigo ; linux-ker...@vger.kernel.org; >>>> dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel >>>> Vetter ; Deucher, Alexander >>>> ; David Airlie ; Koenig, >>>> Christian >>>> *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile >>>> checks >>>> >>>> [AMD Official Use Only - General] >>>> >>>> [AMD Official Use Only - General] >>>> >>>> (+ Felix) >>>> >>>> Should we do the same for other modules under amd (amdkfd)? I was >>>> going to enable full kernel werror in the kconfig used by my CI but >>>> this is probably better. >>>> >>>> Kenny >>>> >>>> >>>> >>>> *From:*Alex Deucher >>>> *Sent:* Wednesday, May 24, 2023 3:22 PM >>>> *To:* Mahfooz, Hamza >>>> *Cc:* amd-...@lists.freedesktop.org ; >>>> Li, Sun peng (Leo) ; Ho, Kenny ; >>>> Pan, Xinhui ; Siqueira, Rodrigo >>>> ; linux-ker...@vger.kernel.org >>>> ; dri-devel@lists.freedesktop.org >>>> ; Daniel Vetter ; >>>> Deucher, Alexander ; David Airlie >>>> ; Wentland, Harry ; Koenig, >>>> Christian >>>> *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile >>>> checks >>>> >>>> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz >>>> wrote: >>>>> >>>>> Currently, there are quite a number of issues that are quite easy for >>>>> the CI to catch, that slip through the cracks. Among them, there are >>>>> unused variable and indentation issues. Also, we should consider all >>>>> warnings to be compile errors, since the community will eventually end >>>>> up complaining about them. So, enable -Werror, -Wunused and >>>>> -Wmisleading-indentation for all kernel builds. >>>>> >>>>> Cc: Alex Deucher >>>>> Cc: Harry Wentland >>>>> Cc: Kenny Ho >>>>> Signed-off-by: Hamza Mahfooz >>>>> --- >>>>> v2: fix grammatical error >>>>> --- >>>>> drivers/gpu/drm/amd/display/Makefile | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/amd/display/Makefile >>>> b/drivers/gpu/drm/amd/display/Makefile >>>>> index 0d610cb376bb..3c44162ebe21 100644 >>>>> --- a/drivers/gpu/drm/amd/display/Makefile >>>>> +++ b/drivers/gpu/drm/amd/display/Makefile >>>>> @@ -26,6 +26,8 @@ >>>>> >>>>> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) >>>>> >>>>> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation >>>>> + >>>> >>>> Care to enable this for the rest of amdgpu as well? Or send out an >>>> additional patch to do that? Either way: >>>> Reviewed-by: Alex Deucher >>>> >>>> Alex >>>> >>>>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ >>>>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw >>>>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr >>>>> -- >>>>> 2.40.1 >>>>> >>>> -- Jani Nikula, Intel Open Source Graphics Center
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
+ Kees On 5/24/23 15:50, Alex Deucher wrote: On Wed, May 24, 2023 at 3:46 PM Felix Kuehling wrote: Sure, I think we tried enabling warnings as errors before and had to revert it because of weird compiler quirks or the variety of compiler versions that need to be supported. Alex, are you planning to upstream this, or is this only to enforce more internal discipline about not ignoring warnings? I'd like to upstream it. Upstream already has CONFIG_WERROR as a config option, but it's been problematic to enable in CI because of various breakages outside of the driver and in different compilers. That said, I don't know how much trouble enabling it will cause with various compilers in the wild. Alex Regards, Felix On 2023-05-24 15:41, Russell, Kent wrote: [AMD Official Use Only - General] (Adding Felix in CC) I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here? Kent *From:* amd-gfx *On Behalf Of *Ho, Kenny *Sent:* Wednesday, May 24, 2023 3:23 PM *To:* Alex Deucher ; Mahfooz, Hamza *Cc:* Li, Sun peng (Leo) ; Wentland, Harry ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Koenig, Christian *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better. Kenny *From:*Alex Deucher *Sent:* Wednesday, May 24, 2023 3:22 PM *To:* Mahfooz, Hamza *Cc:* amd-...@lists.freedesktop.org ; Li, Sun peng (Leo) ; Ho, Kenny ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org ; dri-devel@lists.freedesktop.org ; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Wentland, Harry ; Koenig, Christian *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: Currently, there are quite a number of issues that are quite easy for the CI to catch, that slip through the cracks. Among them, there are unused variable and indentation issues. Also, we should consider all warnings to be compile errors, since the community will eventually end up complaining about them. So, enable -Werror, -Wunused and -Wmisleading-indentation for all kernel builds. Cc: Alex Deucher Cc: Harry Wentland Cc: Kenny Ho Signed-off-by: Hamza Mahfooz --- v2: fix grammatical error --- drivers/gpu/drm/amd/display/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile index 0d610cb376bb..3c44162ebe21 100644 --- a/drivers/gpu/drm/amd/display/Makefile +++ b/drivers/gpu/drm/amd/display/Makefile @@ -26,6 +26,8 @@ AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher Alex subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr -- 2.40.1 -- Hamza
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On 5/24/23 15:54, Harry Wentland wrote: On 5/24/23 15:27, Hamza Mahfooz wrote: On 5/24/23 15:22, Alex Deucher wrote: On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: Currently, there are quite a number of issues that are quite easy for the CI to catch, that slip through the cracks. Among them, there are unused variable and indentation issues. Also, we should consider all warnings to be compile errors, since the community will eventually end up complaining about them. So, enable -Werror, -Wunused and -Wmisleading-indentation for all kernel builds. Cc: Alex Deucher Cc: Harry Wentland Cc: Kenny Ho Signed-off-by: Hamza Mahfooz --- v2: fix grammatical error --- drivers/gpu/drm/amd/display/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile index 0d610cb376bb..3c44162ebe21 100644 --- a/drivers/gpu/drm/amd/display/Makefile +++ b/drivers/gpu/drm/amd/display/Makefile @@ -26,6 +26,8 @@ AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher As far as I can tell, if `CONFIG_DRM_AMD_DC` is set it will run these checks on at least the base driver code. It's probable best to put that into amdgpu/Makefile in that case. I tried the following, but it doesn't seem to work: diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile index 74a9aa6fe18c..d97bde0796dc 100644 --- a/drivers/gpu/drm/amd/amdgpu/Makefile +++ b/drivers/gpu/drm/amd/amdgpu/Makefile @@ -39,6 +39,8 @@ ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \ -I$(FULL_AMD_DISPLAY_PATH)/amdgpu_dm \ -I$(FULL_AMD_PATH)/amdkfd +ccflags-y += -Werror -Wunused -Wmisleading-indentation + amdgpu-y := amdgpu_drv.o # add KMS driver Harry Alex subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr -- 2.40.1 -- Hamza
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
[AMD Official Use Only - General] I ran some experiment yesterday to turn on CONFIG_WERROR and here are some results (summary: gcc 12 seems ok but gcc 13 gives a lot more error, but not necessarily in our module.) Build with gcc13 using Fedora 38: http://zuul.linux.amd.com/t/osg/build/722ad77affed4f988d72051a84979e9f/log/job-output.txt#2924 Build with gcc12 using Fedora 37: http://zuul.linux.amd.com/t/osg/build/9e90f08bbeb044a2997a41b6cdc13f29/log/job-output.txt#7534 Kenny From: Alex Deucher Sent: Wednesday, May 24, 2023 3:50 PM To: Kuehling, Felix Cc: Russell, Kent ; Ho, Kenny ; Mahfooz, Hamza ; Li, Sun peng (Leo) ; Wentland, Harry ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org ; dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org ; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Koenig, Christian Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:46 PM Felix Kuehling wrote: > > Sure, I think we tried enabling warnings as errors before and had to > revert it because of weird compiler quirks or the variety of compiler > versions that need to be supported. > > Alex, are you planning to upstream this, or is this only to enforce more > internal discipline about not ignoring warnings? I'd like to upstream it. Upstream already has CONFIG_WERROR as a config option, but it's been problematic to enable in CI because of various breakages outside of the driver and in different compilers. That said, I don't know how much trouble enabling it will cause with various compilers in the wild. Alex > > Regards, >Felix > > > On 2023-05-24 15:41, Russell, Kent wrote: > > > > [AMD Official Use Only - General] > > > > > > (Adding Felix in CC) > > > > I’m a fan of adding it to KFD as well. Felix, can you foresee any > > issues here? > > > > Kent > > > > *From:* amd-gfx *On Behalf Of > > *Ho, Kenny > > *Sent:* Wednesday, May 24, 2023 3:23 PM > > *To:* Alex Deucher ; Mahfooz, Hamza > > > > *Cc:* Li, Sun peng (Leo) ; Wentland, Harry > > ; Pan, Xinhui ; Siqueira, > > Rodrigo ; linux-ker...@vger.kernel.org; > > dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel > > Vetter ; Deucher, Alexander > > ; David Airlie ; Koenig, > > Christian > > *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile > > checks > > > > [AMD Official Use Only - General] > > > > [AMD Official Use Only - General] > > > > (+ Felix) > > > > Should we do the same for other modules under amd (amdkfd)? I was > > going to enable full kernel werror in the kconfig used by my CI but > > this is probably better. > > > > Kenny > > > > > > > > *From:*Alex Deucher > > *Sent:* Wednesday, May 24, 2023 3:22 PM > > *To:* Mahfooz, Hamza > > *Cc:* amd-...@lists.freedesktop.org ; > > Li, Sun peng (Leo) ; Ho, Kenny ; > > Pan, Xinhui ; Siqueira, Rodrigo > > ; linux-ker...@vger.kernel.org > > ; dri-devel@lists.freedesktop.org > > ; Daniel Vetter ; > > Deucher, Alexander ; David Airlie > > ; Wentland, Harry ; Koenig, > > Christian > > *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile > > checks > > > > On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz > > wrote: > > > > > > Currently, there are quite a number of issues that are quite easy for > > > the CI to catch, that slip through the cracks. Among them, there are > > > unused variable and indentation issues. Also, we should consider all > > > warnings to be compile errors, since the community will eventually end > > > up complaining about them. So, enable -Werror, -Wunused and > > > -Wmisleading-indentation for all kernel builds. > > > > > > Cc: Alex Deucher > > > Cc: Harry Wentland > > > Cc: Kenny Ho > > > Signed-off-by: Hamza Mahfooz > > > --- > > > v2: fix grammatical error > > > --- > > > drivers/gpu/drm/amd/display/Makefile | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/amd/display/Makefile > > b/drivers/gpu/drm/amd/display/Makefile > > > index 0d610cb376bb..3c44162ebe21 100644 > > > --- a/drivers/gpu/drm/amd/display/Makefile > > > +++ b/drivers/gpu/drm/amd/display/Makefile > > > @@ -26,6 +26,8 @@ > > > > > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > > > > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > > > + > > > > Care to enable this for the rest of amdgpu as well? Or send out an > > additional patch to do that? Either way: > > Reviewed-by: Alex Deucher > > > > Alex > > > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > > > -- > > > 2.40.1 > > > > >
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On 5/24/23 15:27, Hamza Mahfooz wrote: > On 5/24/23 15:22, Alex Deucher wrote: >> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: >>> >>> Currently, there are quite a number of issues that are quite easy for >>> the CI to catch, that slip through the cracks. Among them, there are >>> unused variable and indentation issues. Also, we should consider all >>> warnings to be compile errors, since the community will eventually end >>> up complaining about them. So, enable -Werror, -Wunused and >>> -Wmisleading-indentation for all kernel builds. >>> >>> Cc: Alex Deucher >>> Cc: Harry Wentland >>> Cc: Kenny Ho >>> Signed-off-by: Hamza Mahfooz >>> --- >>> v2: fix grammatical error >>> --- >>> drivers/gpu/drm/amd/display/Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/amd/display/Makefile >>> b/drivers/gpu/drm/amd/display/Makefile >>> index 0d610cb376bb..3c44162ebe21 100644 >>> --- a/drivers/gpu/drm/amd/display/Makefile >>> +++ b/drivers/gpu/drm/amd/display/Makefile >>> @@ -26,6 +26,8 @@ >>> >>> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) >>> >>> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation >>> + >> >> Care to enable this for the rest of amdgpu as well? Or send out an >> additional patch to do that? Either way: >> Reviewed-by: Alex Deucher > > As far as I can tell, if `CONFIG_DRM_AMD_DC` is set it will run these > checks on at least the base driver code. > It's probable best to put that into amdgpu/Makefile in that case. Harry >> >> Alex >> >>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ >>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw >>> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr >>> -- >>> 2.40.1 >>>
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On Wed, May 24, 2023 at 3:46 PM Felix Kuehling wrote: > > Sure, I think we tried enabling warnings as errors before and had to > revert it because of weird compiler quirks or the variety of compiler > versions that need to be supported. > > Alex, are you planning to upstream this, or is this only to enforce more > internal discipline about not ignoring warnings? I'd like to upstream it. Upstream already has CONFIG_WERROR as a config option, but it's been problematic to enable in CI because of various breakages outside of the driver and in different compilers. That said, I don't know how much trouble enabling it will cause with various compilers in the wild. Alex > > Regards, >Felix > > > On 2023-05-24 15:41, Russell, Kent wrote: > > > > [AMD Official Use Only - General] > > > > > > (Adding Felix in CC) > > > > I’m a fan of adding it to KFD as well. Felix, can you foresee any > > issues here? > > > > Kent > > > > *From:* amd-gfx *On Behalf Of > > *Ho, Kenny > > *Sent:* Wednesday, May 24, 2023 3:23 PM > > *To:* Alex Deucher ; Mahfooz, Hamza > > > > *Cc:* Li, Sun peng (Leo) ; Wentland, Harry > > ; Pan, Xinhui ; Siqueira, > > Rodrigo ; linux-ker...@vger.kernel.org; > > dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel > > Vetter ; Deucher, Alexander > > ; David Airlie ; Koenig, > > Christian > > *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile > > checks > > > > [AMD Official Use Only - General] > > > > [AMD Official Use Only - General] > > > > (+ Felix) > > > > Should we do the same for other modules under amd (amdkfd)? I was > > going to enable full kernel werror in the kconfig used by my CI but > > this is probably better. > > > > Kenny > > > > > > > > *From:*Alex Deucher > > *Sent:* Wednesday, May 24, 2023 3:22 PM > > *To:* Mahfooz, Hamza > > *Cc:* amd-...@lists.freedesktop.org ; > > Li, Sun peng (Leo) ; Ho, Kenny ; > > Pan, Xinhui ; Siqueira, Rodrigo > > ; linux-ker...@vger.kernel.org > > ; dri-devel@lists.freedesktop.org > > ; Daniel Vetter ; > > Deucher, Alexander ; David Airlie > > ; Wentland, Harry ; Koenig, > > Christian > > *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile > > checks > > > > On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz > > wrote: > > > > > > Currently, there are quite a number of issues that are quite easy for > > > the CI to catch, that slip through the cracks. Among them, there are > > > unused variable and indentation issues. Also, we should consider all > > > warnings to be compile errors, since the community will eventually end > > > up complaining about them. So, enable -Werror, -Wunused and > > > -Wmisleading-indentation for all kernel builds. > > > > > > Cc: Alex Deucher > > > Cc: Harry Wentland > > > Cc: Kenny Ho > > > Signed-off-by: Hamza Mahfooz > > > --- > > > v2: fix grammatical error > > > --- > > > drivers/gpu/drm/amd/display/Makefile | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/amd/display/Makefile > > b/drivers/gpu/drm/amd/display/Makefile > > > index 0d610cb376bb..3c44162ebe21 100644 > > > --- a/drivers/gpu/drm/amd/display/Makefile > > > +++ b/drivers/gpu/drm/amd/display/Makefile > > > @@ -26,6 +26,8 @@ > > > > > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > > > > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > > > + > > > > Care to enable this for the rest of amdgpu as well? Or send out an > > additional patch to do that? Either way: > > Reviewed-by: Alex Deucher > > > > Alex > > > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > > > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > > > -- > > > 2.40.1 > > > > >
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
Sure, I think we tried enabling warnings as errors before and had to revert it because of weird compiler quirks or the variety of compiler versions that need to be supported. Alex, are you planning to upstream this, or is this only to enforce more internal discipline about not ignoring warnings? Regards, Felix On 2023-05-24 15:41, Russell, Kent wrote: [AMD Official Use Only - General] (Adding Felix in CC) I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here? Kent *From:* amd-gfx *On Behalf Of *Ho, Kenny *Sent:* Wednesday, May 24, 2023 3:23 PM *To:* Alex Deucher ; Mahfooz, Hamza *Cc:* Li, Sun peng (Leo) ; Wentland, Harry ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Koenig, Christian *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better. Kenny *From:*Alex Deucher *Sent:* Wednesday, May 24, 2023 3:22 PM *To:* Mahfooz, Hamza *Cc:* amd-...@lists.freedesktop.org ; Li, Sun peng (Leo) ; Ho, Kenny ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org ; dri-devel@lists.freedesktop.org ; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Wentland, Harry ; Koenig, Christian *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile errors, since the community will eventually end > up complaining about them. So, enable -Werror, -Wunused and > -Wmisleading-indentation for all kernel builds. > > Cc: Alex Deucher > Cc: Harry Wentland > Cc: Kenny Ho > Signed-off-by: Hamza Mahfooz > --- > v2: fix grammatical error > --- > drivers/gpu/drm/amd/display/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile > index 0d610cb376bb..3c44162ebe21 100644 > --- a/drivers/gpu/drm/amd/display/Makefile > +++ b/drivers/gpu/drm/amd/display/Makefile > @@ -26,6 +26,8 @@ > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher Alex > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > -- > 2.40.1 >
RE: [PATCH v2] drm/amd/display: enable more strict compile checks
[AMD Official Use Only - General] (Adding Felix in CC) I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here? Kent From: amd-gfx On Behalf Of Ho, Kenny Sent: Wednesday, May 24, 2023 3:23 PM To: Alex Deucher ; Mahfooz, Hamza Cc: Li, Sun peng (Leo) ; Wentland, Harry ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Koenig, Christian Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better. Kenny From: Alex Deucher mailto:alexdeuc...@gmail.com>> Sent: Wednesday, May 24, 2023 3:22 PM To: Mahfooz, Hamza mailto:hamza.mahf...@amd.com>> Cc: amd-...@lists.freedesktop.org<mailto:amd-...@lists.freedesktop.org> mailto:amd-...@lists.freedesktop.org>>; Li, Sun peng (Leo) mailto:sunpeng...@amd.com>>; Ho, Kenny mailto:kenny...@amd.com>>; Pan, Xinhui mailto:xinhui@amd.com>>; Siqueira, Rodrigo mailto:rodrigo.sique...@amd.com>>; linux-ker...@vger.kernel.org<mailto:linux-ker...@vger.kernel.org> mailto:linux-ker...@vger.kernel.org>>; dri-devel@lists.freedesktop.org<mailto:dri-devel@lists.freedesktop.org> mailto:dri-devel@lists.freedesktop.org>>; Daniel Vetter mailto:dan...@ffwll.ch>>; Deucher, Alexander mailto:alexander.deuc...@amd.com>>; David Airlie mailto:airl...@gmail.com>>; Wentland, Harry mailto:harry.wentl...@amd.com>>; Koenig, Christian mailto:christian.koe...@amd.com>> Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz mailto:hamza.mahf...@amd.com>> wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile errors, since the community will eventually end > up complaining about them. So, enable -Werror, -Wunused and > -Wmisleading-indentation for all kernel builds. > > Cc: Alex Deucher mailto:alexander.deuc...@amd.com>> > Cc: Harry Wentland mailto:harry.wentl...@amd.com>> > Cc: Kenny Ho mailto:kenny...@amd.com>> > Signed-off-by: Hamza Mahfooz > mailto:hamza.mahf...@amd.com>> > --- > v2: fix grammatical error > --- > drivers/gpu/drm/amd/display/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/Makefile > b/drivers/gpu/drm/amd/display/Makefile > index 0d610cb376bb..3c44162ebe21 100644 > --- a/drivers/gpu/drm/amd/display/Makefile > +++ b/drivers/gpu/drm/amd/display/Makefile > @@ -26,6 +26,8 @@ > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher mailto:alexander.deuc...@amd.com>> Alex > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > -- > 2.40.1 >
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On 5/24/23 15:22, Alex Deucher wrote: On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: Currently, there are quite a number of issues that are quite easy for the CI to catch, that slip through the cracks. Among them, there are unused variable and indentation issues. Also, we should consider all warnings to be compile errors, since the community will eventually end up complaining about them. So, enable -Werror, -Wunused and -Wmisleading-indentation for all kernel builds. Cc: Alex Deucher Cc: Harry Wentland Cc: Kenny Ho Signed-off-by: Hamza Mahfooz --- v2: fix grammatical error --- drivers/gpu/drm/amd/display/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile index 0d610cb376bb..3c44162ebe21 100644 --- a/drivers/gpu/drm/amd/display/Makefile +++ b/drivers/gpu/drm/amd/display/Makefile @@ -26,6 +26,8 @@ AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher As far as I can tell, if `CONFIG_DRM_AMD_DC` is set it will run these checks on at least the base driver code. Alex subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr -- 2.40.1 -- Hamza
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
[AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better. Kenny From: Alex Deucher Sent: Wednesday, May 24, 2023 3:22 PM To: Mahfooz, Hamza Cc: amd-...@lists.freedesktop.org ; Li, Sun peng (Leo) ; Ho, Kenny ; Pan, Xinhui ; Siqueira, Rodrigo ; linux-ker...@vger.kernel.org ; dri-devel@lists.freedesktop.org ; Daniel Vetter ; Deucher, Alexander ; David Airlie ; Wentland, Harry ; Koenig, Christian Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile errors, since the community will eventually end > up complaining about them. So, enable -Werror, -Wunused and > -Wmisleading-indentation for all kernel builds. > > Cc: Alex Deucher > Cc: Harry Wentland > Cc: Kenny Ho > Signed-off-by: Hamza Mahfooz > --- > v2: fix grammatical error > --- > drivers/gpu/drm/amd/display/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/Makefile > b/drivers/gpu/drm/amd/display/Makefile > index 0d610cb376bb..3c44162ebe21 100644 > --- a/drivers/gpu/drm/amd/display/Makefile > +++ b/drivers/gpu/drm/amd/display/Makefile > @@ -26,6 +26,8 @@ > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher Alex > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > -- > 2.40.1 >
Re: [PATCH v2] drm/amd/display: enable more strict compile checks
On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile errors, since the community will eventually end > up complaining about them. So, enable -Werror, -Wunused and > -Wmisleading-indentation for all kernel builds. > > Cc: Alex Deucher > Cc: Harry Wentland > Cc: Kenny Ho > Signed-off-by: Hamza Mahfooz > --- > v2: fix grammatical error > --- > drivers/gpu/drm/amd/display/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/Makefile > b/drivers/gpu/drm/amd/display/Makefile > index 0d610cb376bb..3c44162ebe21 100644 > --- a/drivers/gpu/drm/amd/display/Makefile > +++ b/drivers/gpu/drm/amd/display/Makefile > @@ -26,6 +26,8 @@ > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher Alex > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > -- > 2.40.1 >
