Re: [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Adham.Abozaeid
Hi Greg

On 8/1/19 9:41 AM, Greg KH wrote:
> External E-Mail
>
>
> On Wed, Jul 31, 2019 at 08:58:19PM +, adham.aboza...@microchip.com wrote:
> This patch causes the following build error:
> drivers/staging/wilc1000/wilc_hif.c: In function wilc_deinit:
> drivers/staging/wilc1000/wilc_hif.c:1610:2: error: implicit declaration of 
> function wilc_set_wfi_drv_handler [-Werror=implicit-function-declaration]
>  1610 |  wilc_set_wfi_drv_handler(vif, 0, 0, 0);
>   |  ^~~~
>
> Always test build your patches...
>
Apologies for that!
I'll fix the error and send a new version with both patches clubbed in a patch 
series.

Thanks,
Adham
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Greg KH
On Wed, Jul 31, 2019 at 08:58:19PM +, adham.aboza...@microchip.com wrote:
> From: Adham Abozaeid 
> 
> wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same
> parameters to the FW, so it's better to combine them together.
> 
> Kept wilc_set_wfi_drv_handler implementation since it sends all the
> required parameters, and renamed it to wilc_set_operation_mode to be
> more descriptive.
> 
> Signed-off-by: Adham Abozaeid 
> ---
>  drivers/staging/wilc1000/wilc_hif.c   | 29 ++-
>  drivers/staging/wilc1000/wilc_hif.h   |  5 ++--
>  drivers/staging/wilc1000/wilc_netdev.c|  6 ++--
>  .../staging/wilc1000/wilc_wfi_cfgoperations.c | 24 +++
>  drivers/staging/wilc1000/wilc_wlan_if.h   |  3 +-
>  5 files changed, 20 insertions(+), 47 deletions(-)

This patch causes the following build error:
drivers/staging/wilc1000/wilc_hif.c: In function wilc_deinit:
drivers/staging/wilc1000/wilc_hif.c:1610:2: error: implicit declaration of 
function wilc_set_wfi_drv_handler [-Werror=implicit-function-declaration]
 1610 |  wilc_set_wfi_drv_handler(vif, 0, 0, 0);
  |  ^~~~

Always test build your patches...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel