[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Disable XCODE unknown warning option
The option -Wno-error=unused-but-set-variable is added to disable variable 'fp' set but not used in GCC. But, XCODE doesn't know this option. To make XCODE pass build, -Wno-error=unknown-warning-option is added. The warning unused-but-set-variable reports the code issue. It will report to Oniguruma project. After it is fixed, next version code can remove those options. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf index 18e4d2f..b30d6cf 100644 --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf @@ -112,3 +112,6 @@ # Enable STDARG for variable arguments *_*_*_CC_FLAGS = -DHAVE_STDARG_H + + # Disable unknown warning option '-Werror=unused-but-set-variable' + XCODE:*_*_*_CC_FLAGS = -Wno-error=unknown-warning-option -- 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Enable STDARG for variable arguments
Set macro for variable arguments, and remove the hard code definition to avoid the potential duplicated definition. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c | 1 - MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c b/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c index 222e8e6..d92b61e 100644 --- a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c +++ b/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c @@ -28,7 +28,6 @@ */ #include "regint.h" -#define HAVE_STDARG_PROTOTYPES #if 0 #include /* for vsnprintf() */ diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf index 16e91bd..18e4d2f 100644 --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf @@ -109,3 +109,6 @@ # Oniguruma: error: variable 'fp' set but not used GCC:*_*_*_CC_FLAGS = -Wno-error=unused-but-set-variable + + # Enable STDARG for variable arguments + *_*_*_CC_FLAGS = -DHAVE_STDARG_H -- 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [patch 3/5] MdePkg: Correct condition check for AcpiExp text format
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1226
According to UEFI Spec, for ACPI Expanded Device Path,
when HIDSTR=empty, CIDSTR=empty, UID STR!=empty,
the ACPI Expanded Device Path node can be displayed as
AcpiExp(HID,CID,UIDSTR) format.
And if UID is 0 and UIDSTR is empty, then use AcpiEx format.
This patch is to correct the condition check to follow UEFI
Spec when convert the device path node to the AcpiExp text
format.
Cc: Ruiyu Ni
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
index 1c08a3ec2f..8e5efba1e8 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
@@ -453,11 +453,11 @@ DevPathToTextAcpiEx (
((AcpiEx->CID >> 5) & 0x1f) + 'A' - 1,
((AcpiEx->CID >> 0) & 0x1f) + 'A' - 1,
(AcpiEx->CID >> 16) & 0x
);
- if ((*HIDStr == '\0') && (*CIDStr == '\0') && (AcpiEx->UID == 0)) {
+ if ((*HIDStr == '\0') && (*CIDStr == '\0') && (*UIDStr != '\0')) {
//
// use AcpiExp()
//
UefiDevicePathLibCatPrint (
Str,
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [patch 4/5] MdePkg: Add PciRoot/PcieRoot text for ACPI Expanded Device Path
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1228
According to UEFI spec,for ACPI Expanded Device Path
when HID=PNP0A03 or CID=PNP0A03 and HID != PNP0A08,
the device path node can be displayed as: PciRoot(UID|UIDSTR)
When HID=PNP0A08 or CID=PNP0A08, the device path node can be
displayed as: PcieRoot(UID|UIDSTR). But current code miss the
code logic.
This commit is to do the enhancement.
Cc: Ruiyu Ni
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../UefiDevicePathLib/DevicePathToText.c | 21 +++
1 file changed, 21 insertions(+)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
index 8e5efba1e8..7ad9eadf6c 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
@@ -431,10 +431,31 @@ DevPathToTextAcpiEx (
AcpiEx = DevPath;
HIDStr = (CHAR8 *) (((UINT8 *) AcpiEx) + sizeof
(ACPI_EXTENDED_HID_DEVICE_PATH));
UIDStr = HIDStr + AsciiStrLen (HIDStr) + 1;
CIDStr = UIDStr + AsciiStrLen (UIDStr) + 1;
+ if (DisplayOnly) {
+if ((EISA_ID_TO_NUM (AcpiEx->HID) == 0x0A03) ||
+(EISA_ID_TO_NUM (AcpiEx->CID) == 0x0A03 && EISA_ID_TO_NUM
(AcpiEx->HID) != 0x0A08)) {
+ if (AcpiEx->UID == 0) {
+UefiDevicePathLibCatPrint (Str, L"PciRoot(%a)", UIDStr);
+ } else {
+UefiDevicePathLibCatPrint (Str, L"PciRoot(0x%x)", AcpiEx->UID);
+ }
+ return;
+}
+
+if (EISA_ID_TO_NUM (AcpiEx->HID) == 0x0A08 || EISA_ID_TO_NUM (AcpiEx->CID)
== 0x0A08) {
+ if (AcpiEx->UID == 0) {
+UefiDevicePathLibCatPrint (Str, L"PcieRoot(%a)", UIDStr);
+ } else {
+UefiDevicePathLibCatPrint (Str, L"PcieRoot(0x%x)", AcpiEx->UID);
+ }
+ return;
+}
+ }
+
//
// Converts EISA identification to string.
//
UnicodeSPrint (
HIDText,
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [patch 2/5] MdePkg: Correct the string order of ACPI Expanded Device Path
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1227
According to UEFI Spec, ACPI Expanded Device Path can be display
AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR)), but current code display
UID|UIDSTR before CID|CIDSTR.
This patch is to fix this issue.
Cc: Ruiyu Ni
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
index 85f5e97131..1c08a3ec2f 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
@@ -475,20 +475,20 @@ DevPathToTextAcpiEx (
UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr);
} else {
UefiDevicePathLibCatPrint (Str, L"AcpiEx(%s,", HIDText);
}
- if (AcpiEx->UID == 0) {
-UefiDevicePathLibCatPrint (Str, L"%a,", UIDStr);
+ if (AcpiEx->CID == 0) {
+UefiDevicePathLibCatPrint (Str, L"%a,", CIDStr);
} else {
-UefiDevicePathLibCatPrint (Str, L"0x%x,", AcpiEx->UID);
+UefiDevicePathLibCatPrint (Str, L"%s,", CIDText);
}
- if (AcpiEx->CID == 0) {
-UefiDevicePathLibCatPrint (Str, L"%a)", CIDStr);
+ if (AcpiEx->UID == 0) {
+UefiDevicePathLibCatPrint (Str, L"%a)", UIDStr);
} else {
-UefiDevicePathLibCatPrint (Str, L"%s)", CIDText);
+UefiDevicePathLibCatPrint (Str, L"0x%x)", AcpiEx->UID);
}
} else {
UefiDevicePathLibCatPrint (
Str,
L"AcpiEx(%s,%s,0x%x,%a,%a,%a)",
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [patch 5/5] MdePkg: Use VENDOR_DEVICE_PATH structure for Debug Port device path
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1229
When converting DebugPort device path from text,
current code use VENDOR_DEFINED_MESSAGING_DEVICE_PATH structure
for Debug port device node.
typedef struct {
EFI_DEVICE_PATH_PROTOCOL Header;
EFI_GUID Guid;
UINT8 VendorDefinedData[1];
} VENDOR_DEFINED_MESSAGING_DEVICE_PATH;
And Debugport Device Path is a vendor-defined messaging
device path with no data, only a GUID. So it's better to
use VENDOR_DEVICE_PATH to create the Debug port device node.
typedef struct {
EFI_DEVICE_PATH_PROTOCOLHeader;
EFI_GUIDGuid;
} VENDOR_DEVICE_PATH;
Cc: Ruiyu Ni
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
index c5f3764fc0..49da8268eb 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
@@ -1756,16 +1756,16 @@ DevPathFromTextEmmc (
EFI_DEVICE_PATH_PROTOCOL *
DevPathFromTextDebugPort (
IN CHAR16 *TextDeviceNode
)
{
- VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend;
+ VENDOR_DEVICE_PATH *Vend;
- Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode (
+ Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (
MESSAGING_DEVICE_PATH,
MSG_VENDOR_DP,
-(UINT16) sizeof
(VENDOR_DEFINED_MESSAGING_DEVICE_PATH)
+(UINT16) sizeof
(VENDOR_DEVICE_PATH)
);
CopyGuid (>Guid, );
return (EFI_DEVICE_PATH_PROTOCOL *) Vend;
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225
According to UEFI spec, the string expression of UTF8 vendor
device node should be displayed as: VenUtf8(). Current code
display it as: VenUft8() by mistake when convert device
path node to text.
This commit is to fix this bug.
Cc: Ruiyu Ni
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
index 7d8d304f6f..85f5e97131 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
@@ -193,11 +193,11 @@ DevPathToTextVendor (
return ;
} else if (CompareGuid (>Guid, )) {
UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()");
return ;
} else if (CompareGuid (>Guid, )) {
-UefiDevicePathLibCatPrint (Str, L"VenUft8()");
+UefiDevicePathLibCatPrint (Str, L"VenUtf8()");
return ;
} else if (CompareGuid (>Guid, )) {
FlowControlMap = (((UART_FLOW_CONTROL_DEVICE_PATH *)
Vendor)->FlowControlMap);
switch (FlowControlMap & 0x0003) {
case 0:
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg/Tcp4Dxe: Remove the trailing white space in one line.
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Monday, October 8, 2018 11:08 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Bi, Dandan ; Fu, > Siyuan ; Wu, Jiaxin > Subject: [edk2] [Patch] MdeModulePkg/Tcp4Dxe: Remove the trailing white > space in one line. > > Cc: Fu Siyuan > Cc: Ye Ting > Cc: Bi Dandan > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > index fb7f4f8502..7c0504770b 100644 > --- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > +++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > @@ -1,17 +1,17 @@ > ## @file > # This module produces EFI TCPv4 Protocol and EFI TCPv4 Service Binding > Protocol. > # > # This module produces EFI TCPv4(Transmission Control Protocol version 4) > Protocol > -# upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This > driver only > +# upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This > driver only > # supports IPv4 network stack. > # > # Notes: > # 1) This driver can't co-work with the TcpDxe driver in NetworkPkg. > -# 2) This driver might have some issues that have been fixed in the > TcpDxe driver > +# 2) This driver might have some issues that have been fixed in the > TcpDxe driver > # in NetworkPkg. > -# 3) This driver supports fewer features than the TcpDxe driver in > NetworkPkg (e.g. IPv6, > +# 3) This driver supports fewer features than the TcpDxe driver in > NetworkPkg (e.g. IPv6, > # TCP Cancel function). > # 4) TcpDxe driver in NetworkPkg is recommended for use instead of this > one even though > # both of them can be used. > # > # Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. > -- > 2.17.1.windows.2 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/2] Correct comments to align with the input parameter.
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Monday, October 8, 2018 11:03 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Fu, Siyuan > ; Ye, Ting ; Bi, Dandan > ; Wu, Jiaxin > Subject: [Patch 0/2] Correct comments to align with the input parameter. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230 > > Cc: Carsey Jaben > Cc: Fu Siyuan > Cc: Ye Ting > Cc: Bi Dandan > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > > Jiaxin Wu (2): > NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input > parameter. > ShellPkg/TftpDynamicCommand: Correct comments to align with the input > parameter. > > NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++- > NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 - > ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++ > 3 files changed, 16 insertions(+), 2 deletions(-) > > -- > 2.17.1.windows.2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] MdeModulePkg/HiiDB: Fix incorrect structure convention for checkbox
Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Monday, October 08, 2018 9:29 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Zeng, Star
>Subject: [patch] MdeModulePkg/HiiDB: Fix incorrect structure convention for
>checkbox
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1224
>
>When covert IFR binary to EFI_IFR_CHECKBOX structure,
>Current code has following incorrect code logic:
>IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);
>The correct one should be:
>IfrCheckBox = (EFI_IFR_CHECKBOX *) IfrOpHdr;
>
>This patch is to fix this bug.
>
>Cc: Liming Gao
>Cc: Star Zeng
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi
>---
> MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
>b/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
>index 45448c5198..664687796f 100644
>--- a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
>+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
>@@ -896,11 +896,11 @@ UpdateDefaultSettingInFormPackage (
> break;
> case EFI_IFR_CHECKBOX_OP:
> IfrScope = IfrOpHdr->Scope;
> IfrQuestionType = IfrOpHdr->OpCode;
> IfrQuestionHdr = (EFI_IFR_QUESTION_HEADER *) (IfrOpHdr + 1);
>- IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);
>+ IfrCheckBox = (EFI_IFR_CHECKBOX *) IfrOpHdr;
> EfiVarStoreIndex = IsEfiVarStoreQuestion (IfrQuestionHdr,
> EfiVarStoreList,
>EfiVarStoreNumber);
> Width= sizeof (BOOLEAN);
> if (EfiVarStoreIndex < EfiVarStoreNumber) {
> for (Index = 0; Index < DefaultIdNumber; Index ++) {
> if (DefaultIdList[Index] == EFI_HII_DEFAULT_CLASS_STANDARD) {
>--
>2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, October 2, 2018 6:14 PM > To: Ni, Ruiyu ; Zhang, Chao B > Cc: Zhang, Shenglei ; edk2-devel@lists.01.org; > Kinney, Michael D > Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs > > Ray, Chao, > > guys, you keep breaking the development process. Please fix your email > clients *now*. > > This is not the first time it has happened. If I remember correctly, Ray > blamed > his email client last time (not showing message threads correctly, or > something similar). > > I'm sorry, but this is unacceptable. This is on-going, systemic disregard for > the > project's other participants. > > Please fix your mail user agents *now*. > > Here's my promise. Next time, I'm going to revert such commits (assuming I > manage to catch them again). They do not represent the facts from the > mailing list. Sorry about that. I can understand it. So this is the first mail I choose to reply after a long holiday. I am now using Mozilla Thunderbird to only receive mails from this mailing list. This mail client can group the mails correctly so if I missed any R-b that's absolutely my faultī There is a difference between help-to-push for Intel developers and non-Intel developers. As the Intel developer, Shenglei is very kind to prepare the patch files with R-b and send to me internally as attachments. All I need to do is pushing the patches. Before the pushing, I will check whether there is R-b but won't check whether all R-bs are there. For non-Intel developers, I will edit the patch to list all R-bs before pushing. Again, thanks for enforcing the process. We will follow the process more strictly in future. > > Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 build
Laszlo: We meet with this failure in GCC4.8 and GCC4.9, but not in GCC5. We don't verify earlier version than GCC4.8. GCC48 is the specific tool chain for GCC4.8. But, GCC49 is the general tool chain that can be used with GCC4.9 or the above GCC version for LTO disable. So, even if we specify this warning for GCC48 and GCC49, it may be applied for GCC5 version. To be simplified, I suggest to disable this warning in the general style. I suggest to add more comments here to describe this warning for GCC4.8, GCC4.9 version. Not for GCC5. + # Oniguruma: tag_end in parse_callout_of_name + GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Tuesday, October 02, 2018 2:02 AM >To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org >Subject: Re: [edk2] [PATCH] MdeModulePkg:disable wraning to pass gcc4.8 >build > >Wait a sec: > >On 10/01/18 19:48, Laszlo Ersek wrote: > >> However, this (edk2) commit message seems to suggest that the warnings >> are only present with gcc-4.8 (and no later gcc releases). This in turn >> suggests that the warnings are spurious (presumably, later gcc releases >> recognize that none of the affected variables are actually read without >> a prior initialization or assignment.) >> >> Hence, upstream Oniguruma might argue that we should fix our compiler -- >> they might consider gcc-4.8 too old to care -- rather than litter their >> code with superfluous assignments, just to pacify gcc-4.8. > >[...] > >> So, I think I agree with this patch, but the commit message should be a >> *lot* more detailed. (Basically, include the analysis from above.) > >In fact, another improvement is possible: if the issue only affects >gcc-4.8, then: > >>> On 29/09/18 02:55, Dongao Guo wrote: Change-Id: I782962e4994a8edf14beb7ede8b1aabe233dc3a8 Contributed-under: TianoCore Contribution Agreement 1.1 --- >MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | >3 +++ 1 file changed, 3 insertions(+) diff --git >a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f index 16e91bd..07bc02e 100644 --- >a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f +++ >b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f @@ -109,3 +109,6 @@ # Oniguruma: error: variable 'fp' set but not used GCC:*_*_*_CC_FLAGS = -Wno-error=unused-but-set-variable + + # Oniguruma: tag_end in parse_callout_of_name + GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized > >this toolchain glob pattern is too general. It should be: > > GCC:*_GCC48_*_CC_FLAGS > >(or maybe spell it out for all GCC versions up to and including 4.8, >from the earliest we support, 4.4.) > >Thanks >Laszlo >___ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] MdeModulePkg/Tcp4Dxe: Remove the trailing white space in one line.
Cc: Fu Siyuan Cc: Ye Ting Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf index fb7f4f8502..7c0504770b 100644 --- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf +++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf @@ -1,17 +1,17 @@ ## @file # This module produces EFI TCPv4 Protocol and EFI TCPv4 Service Binding Protocol. # # This module produces EFI TCPv4(Transmission Control Protocol version 4) Protocol -# upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This driver only +# upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This driver only # supports IPv4 network stack. # # Notes: # 1) This driver can't co-work with the TcpDxe driver in NetworkPkg. -# 2) This driver might have some issues that have been fixed in the TcpDxe driver +# 2) This driver might have some issues that have been fixed in the TcpDxe driver # in NetworkPkg. -# 3) This driver supports fewer features than the TcpDxe driver in NetworkPkg (e.g. IPv6, +# 3) This driver supports fewer features than the TcpDxe driver in NetworkPkg (e.g. IPv6, # TCP Cancel function). # 4) TcpDxe driver in NetworkPkg is recommended for use instead of this one even though # both of them can be used. # # Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. -- 2.17.1.windows.2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch 1/2] NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input parameter.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230 Cc: Fu Siyuan Cc: Ye Ting Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++- NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 - 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c index 9725fb40dd..61d2d59675 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c @@ -1,9 +1,9 @@ /** @file Functions implementation related with Mtftp for UefiPxeBc Driver. - Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved. + Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at http://opensource.org/licenses/bsd-license.php. @@ -107,10 +107,11 @@ PxeBcMtftp6CheckPacket ( @param[in] PrivatePointer to PxeBc private data. @param[in] Config Pointer to EFI_MTFTP6_CONFIG_DATA. @param[in] Filename Pointer to boot file name. @param[in] BlockSize Pointer to required block size. + @param[in] WindowSize Pointer to required window size. @param[in, out] BufferSize Pointer to buffer size. @retval EFI_SUCCESSSucessfully obtained the size of file. @retval EFI_NOT_FOUND Parse the tftp ptions failed. @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. @@ -246,10 +247,11 @@ ON_ERROR: @param[in] PrivatePointer to PxeBc private data. @param[in] Config Pointer to EFI_MTFTP6_CONFIG_DATA. @param[in] Filename Pointer to boot file name. @param[in] BlockSize Pointer to required block size. + @param[in] WindowSize Pointer to required window size. @param[in] BufferPtr Pointer to buffer. @param[in, out] BufferSize Pointer to buffer size. @param[in] DontUseBuffer Indicates whether with a receive buffer. @retval EFI_SUCCESSSuccessfully read the data from the special file. @@ -414,10 +416,11 @@ PxeBcMtftp6WriteFile ( @param[in] PrivatePointer to PxeBc private data. @param[in] Config Pointer to EFI_MTFTP6_CONFIG_DATA. @param[in] Filename Pointer to boot file name. @param[in] BlockSize Pointer to required block size. + @param[in] WindowSize Pointer to required window size. @param[in] BufferPtr Pointer to buffer. @param[in, out] BufferSize Pointer to buffer size. @param[in] DontUseBuffer Indicates whether to use a receive buffer. @retval EFI_SUCCESSSuccessfully obtained the data from the file included in directory. @@ -584,10 +587,11 @@ PxeBcMtftp4CheckPacket ( @param[in] PrivatePointer to PxeBc private data. @param[in] Config Pointer to EFI_MTFTP4_CONFIG_DATA. @param[in] Filename Pointer to boot file name. @param[in] BlockSize Pointer to required block size. + @param[in] WindowSize Pointer to required window size. @param[in, out] BufferSize Pointer to buffer size. @retval EFI_SUCCESSSuccessfully obtained the size of file. @retval EFI_NOT_FOUND Parse the tftp options failed. @retval EFI_DEVICE_ERROR The network device encountered an error during this operation. @@ -723,10 +727,11 @@ ON_ERROR: @param[in] PrivatePointer to PxeBc private data. @param[in] Config Pointer to EFI_MTFTP4_CONFIG_DATA. @param[in] Filename Pointer to boot file name. @param[in] BlockSize Pointer to required block size. + @param[in] WindowSize Pointer to required window size. @param[in] BufferPtr Pointer to buffer. @param[in, out] BufferSize Pointer to buffer size. @param[in] DontUseBuffer Indicates whether to use a receive buffer. @retval EFI_SUCCESSSuccessfully read the data from the special file. @@ -890,10 +895,11 @@ PxeBcMtftp4WriteFile ( @param[in] PrivatePointer to PxeBc private data. @param[in] Config Pointer to EFI_MTFTP4_CONFIG_DATA. @param[in] Filename Pointer to boot file name. @param[in] BlockSize Pointer to required block size. + @param[in] WindowSize Pointer to required window size. @param[in] BufferPtr Pointer to buffer. @param[in, out] BufferSize Pointer to buffer size. @param[in] DontUseBuffer Indicates whether to use a receive buffer. @retval EFI_SUCCES Successfully obtained the data from the file included in the directory.
[edk2] [Patch 2/2] ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230 Cc: Carsey Jaben Cc: Fu Siyuan Cc: Ye Ting Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c index d4391b9f33..ccf7abde42 100644 --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c @@ -163,10 +163,11 @@ GetFileSize ( @param[in] Mtftp4 MTFTP4 protocol interface @param[in] FilePath Path of the file, Unicode encoded @param[in] AsciiFilePath Path of the file, ASCII encoded @param[in] FileSize Size of the file in number of bytes @param[in] BlockSize Value of the TFTP blksize option + @param[in] WindowSize Value of the TFTP window size option @param[out] Data Address where to store the address of the buffer where the data of the file were downloaded in case of success. @retval EFI_SUCCESS The file was downloaded. @@ -904,10 +905,11 @@ Error : @param[in] Mtftp4 MTFTP4 protocol interface @param[in] FilePath Path of the file, Unicode encoded @param[in] AsciiFilePath Path of the file, ASCII encoded @param[in] FileSize Size of the file in number of bytes @param[in] BlockSize Value of the TFTP blksize option + @param[in] WindowSize Value of the TFTP window size option @param[out] Data Address where to store the address of the buffer where the data of the file were downloaded in case of success. @retval EFI_SUCCESS The file was downloaded. -- 2.17.1.windows.2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch 0/2] Correct comments to align with the input parameter.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230 Cc: Carsey Jaben Cc: Fu Siyuan Cc: Ye Ting Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input parameter. ShellPkg/TftpDynamicCommand: Correct comments to align with the input parameter. NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++- NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 - ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++ 3 files changed, 16 insertions(+), 2 deletions(-) -- 2.17.1.windows.2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
Hi all, Sorry for that. Ray and Chao just helped me push the patches. It's my fault about the mistake. I'll prepare patches more carefully next time and make sure all things correct. Best Regards, Shenglei > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 2, 2018 6:14 PM > To: Ni, Ruiyu ; Zhang, Chao B > Cc: Zhang, Shenglei ; edk2-devel@lists.01.org; > Kinney, Michael D > Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs > > Ray, Chao, > > guys, you keep breaking the development process. Please fix your email > clients *now*. > > > On 08/28/18 05:42, shenglei wrote: > > shenglei (16): > > IntelFsp2Pkg FspSecCore: Remove unused PCDs > > IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs > > IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs > > IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs > > IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD > > IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs > > SecurityPkg/Tcg2ConfigPei: Remove an unused PCD > > This was patch #07 in this series. I had never reviewed it, yet Chao > pushed it with my R-b as commit > > https://github.com/tianocore/edk2/commit/3e11c27f67ea > > > > SecurityPkg/Tcg2Dxe: Remove unused PCDs > > UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD > > MdePkg/BaseLib: Remove an unused PCD > > MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs > > MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused > PCD > > ShellPkg/Shell: Remove unused PCDs > > This was patch #13 in this series. I reviewed it: > > http://mid.mail-archive.com/70dfa56d-6781-e8c0-f3f4- > aa1255867...@redhat.com > > but Ray pushed it as commit > > https://github.com/tianocore/edk2/commit/a9dfe53f56bb > > without my R-b tag. (Note: there was 1 month between my feedback and > the > push date.) > > The commit message now suggests that I ignored the patch (because I was > on CC, but seemingly didn't respond). It mis-represents my acts. > > > > ShellPkg/DpDynamicCommand: Remove unused PCDs > > ShellPkg/UefiHandleParsingLib: Remove an unused PCD > > Same here. Patch #15, pushed as commit > > https://github.com/tianocore/edk2/commit/42a7c2871a65 > > My review was at: > > http://mid.mail-archive.com/a70f17d9-b937-2835-4d71- > 5464bad82...@redhat.com > > but it was dropped from the commit. > > > > ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs > > Ditto. Patch #16. My review was at: > > http://mid.mail-archive.com/d23e7c95-96e9-4088-4e95- > 5dbc0a331...@redhat.com > > but the patch was pushed as commit > > https://github.com/tianocore/edk2/commit/aa9986651bfe > > with my review lost. > > > This is not the first time it has happened. If I remember correctly, Ray > blamed his email client last time (not showing message threads > correctly, or something similar). > > I'm sorry, but this is unacceptable. This is on-going, systemic > disregard for the project's other participants. > > Please fix your mail user agents *now*. > > Here's my promise. Next time, I'm going to revert such commits (assuming > I manage to catch them again). They do not represent the facts from the > mailing list. > > Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf OptionROM override
Pilar:
The change is good. Could you also update INF and FDF spec for this usage? If
you don't know how to update INF and FDF spec, please submit BZ. I will provide
the spec patch.
Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Tomas Pilar (tpilar)
>Sent: Tuesday, October 02, 2018 10:46 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf
>OptionROM override
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Tomas Pilar
>---
> BaseTools/Source/Python/GenFds/FdfParser.py | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
>b/BaseTools/Source/Python/GenFds/FdfParser.py
>index 63687e98bb..a65f2cfd2d 100644
>--- a/BaseTools/Source/Python/GenFds/FdfParser.py
>+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
>@@ -4469,10 +4469,15 @@ class FdfParser:
> if self.__IsKeyword( "PCI_DEVICE_ID"):
> if not self.__IsToken( "="):
> raise Warning("expected '='", self.FileName,
>self.CurrentLineNumber)
>-if not self.__GetNextHexNumber():
>-raise Warning("expected Hex device id", self.FileName,
>self.CurrentLineNumber)
>
>-Overrides.PciDeviceId = self.__Token
>+# Get a list of PCI IDs
>+Overrides.PciDeviceId = ""
>+
>+while self.__GetNextHexNumber():
>+Overrides.PciDeviceId += " " + self.__Token
>+
>+if not Overrides.PciDeviceId:
>+raise Warning("expected one or more Hex device ids",
>self.FileName, self.CurrentLineNumber)
> continue
>
> if self.__IsKeyword( "PCI_REVISION"):
>--
>2.17.1
>
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup build scripts
Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Steele, Kelly Sent: Thursday, October 4, 2018 12:43 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup build scripts >From f30cb7012687d09144ddeef1ad03a5571181757d Mon Sep 17 00:00:00 2001 From: Kelly Steele mailto:kelly.ste...@intel.com>> Date: Wed, 3 Oct 2018 09:35:00 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup build scripts Removed unused variables from exit routine. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Kelly Steele mailto:kelly.ste...@intel.com>> --- Platform/BroxtonPlatformPkg/BuildBxtBios.bat | 1 - Platform/BroxtonPlatformPkg/BuildIFWI.bat| 1 - 2 files changed, 2 deletions(-) diff --git a/Platform/BroxtonPlatformPkg/BuildBxtBios.bat b/Platform/BroxtonPlatformPkg/BuildBxtBios.bat index cdf666a7a4..3c0565e3ed 100644 --- a/Platform/BroxtonPlatformPkg/BuildBxtBios.bat +++ b/Platform/BroxtonPlatformPkg/BuildBxtBios.bat @@ -742,6 +742,5 @@ echo See EDK2.log for more details echo %date% %time% ( EndLocal - set BiosVersion=%BiosVersion% exit /b %ExitCode% ) diff --git a/Platform/BroxtonPlatformPkg/BuildIFWI.bat b/Platform/BroxtonPlatformPkg/BuildIFWI.bat index 78cdac5111..5566e211ee 100644 --- a/Platform/BroxtonPlatformPkg/BuildIFWI.bat +++ b/Platform/BroxtonPlatformPkg/BuildIFWI.bat @@ -244,6 +244,5 @@ set exitCode=1 :Exit ( EndLocal - set Arch=%Arch% exit /b %exitCode% ) -- 2.11.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/3] Update LZMA SDK version to the latest 18.05
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, August 29, 2018 8:51 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/3] Update LZMA SDK version to the latest 18.05 Liming Gao (3): IntelFrameworkModulePkg Lzma: Update LZMA SDK version to 18.05 MdeModulePkg Lzma: Update LZMA SDK version to 18.05 BaseTools Lzma: Update LZMA SDK version to 18.05 .../Source/C/LzmaCompress/LZMA-SDK-README.txt |4 +- BaseTools/Source/C/LzmaCompress/LzmaCompress.c |8 +- BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.c | 28 +- BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.h |8 +- BaseTools/Source/C/LzmaCompress/Sdk/C/7zStream.c | 111 +- BaseTools/Source/C/LzmaCompress/Sdk/C/7zTypes.h| 220 +- BaseTools/Source/C/LzmaCompress/Sdk/C/7zVersion.h | 22 +- BaseTools/Source/C/LzmaCompress/Sdk/C/Alloc.c | 399 +++- BaseTools/Source/C/LzmaCompress/Sdk/C/Alloc.h | 20 +- BaseTools/Source/C/LzmaCompress/Sdk/C/Bra86.c |4 +- BaseTools/Source/C/LzmaCompress/Sdk/C/Compiler.h |3 +- BaseTools/Source/C/LzmaCompress/Sdk/C/CpuArch.h| 166 +- BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.c | 163 +- BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.h | 12 +- BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.c | 67 +- BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.h |6 +- BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.c| 401 ++-- BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.h| 47 +- BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c| 2334 BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.h| 48 +- BaseTools/Source/C/LzmaCompress/Sdk/C/Threads.c| 14 +- BaseTools/Source/C/LzmaCompress/Sdk/C/Threads.h|5 +- .../Source/C/LzmaCompress/Sdk/DOC/lzma-history.txt | 63 +- .../Source/C/LzmaCompress/Sdk/DOC/lzma-sdk.txt |2 +- .../LzmaCustomDecompressLib/LZMA-SDK-README.txt|6 +- .../LzmaArchCustomDecompressLib.inf|6 +- .../LzmaCustomDecompressLib.inf|6 +- .../LzmaCustomDecompressLib/LzmaDecompress.c |4 +- .../LzmaCustomDecompressLib/Sdk/C/7zTypes.h| 220 +- .../LzmaCustomDecompressLib/Sdk/C/7zVersion.h | 22 +- .../Library/LzmaCustomDecompressLib/Sdk/C/Bra86.c |4 +- .../LzmaCustomDecompressLib/Sdk/C/Compiler.h |3 +- .../LzmaCustomDecompressLib/Sdk/C/CpuArch.h| 166 +- .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.c | 163 +- .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.h | 12 +- .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.c| 401 ++-- .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.h| 47 +- .../Sdk/DOC/lzma-history.txt | 63 +- .../LzmaCustomDecompressLib/Sdk/DOC/lzma-sdk.txt |2 +- .../LzmaCustomDecompressLib/LZMA-SDK-README.txt|6 +- .../LzmaArchCustomDecompressLib.inf|6 +- .../LzmaCustomDecompressLib.inf|6 +- .../LzmaCustomDecompressLib/LzmaDecompress.c |4 +- .../LzmaCustomDecompressLib/Sdk/C/7zTypes.h| 220 +- .../LzmaCustomDecompressLib/Sdk/C/7zVersion.h | 22 +- .../Library/LzmaCustomDecompressLib/Sdk/C/Bra86.c |4 +- .../LzmaCustomDecompressLib/Sdk/C/Compiler.h |3 +- .../LzmaCustomDecompressLib/Sdk/C/CpuArch.h| 166 +- .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.c | 163 +- .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.h | 12 +- .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.c| 401 ++-- .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.h| 47 +- .../Sdk/DOC/lzma-history.txt | 63 +- .../LzmaCustomDecompressLib/Sdk/DOC/lzma-sdk.txt |2 +- 54 files changed, 4230 insertions(+), 2175 deletions(-) -- 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/2] Update BrotliCompress to the latest version 1.0.5
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, September 10, 2018 8:37 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2] Update BrotliCompress to the latest version 1.0.5 Because the patch is too big, the change is placed in https://github.com/lgao4/edk2/tree/Brotli Update Brotli to the latest version 1.0.5 https://github.com/google/brotli Verify VS2017, GCC5 build. Verify Decompression boot functionality. Liming Gao (2): BaseTools: Update Brotli Compress to the latest one 1.0.5 MdeModulePkg: Update Brotli DecompressLib to the latest v1.0.5 BaseTools/BinWrappers/PosixLike/BrotliCompress |13 +- .../WindowsLike}/BrotliCompress.bat|12 +- BaseTools/Source/C/BrotliCompress/GNUmakefile | 8 +- BaseTools/Source/C/BrotliCompress/Makefile |20 +- BaseTools/Source/C/BrotliCompress/ReadMe.txt | 2 +- .../Source/C/BrotliCompress/common/constants.h |25 +- .../Source/C/BrotliCompress/common}/context.h | 356 +- .../Source/C/BrotliCompress/common/dictionary.c| 15341 +++-- .../Source/C/BrotliCompress/common/dictionary.h|47 +- .../Source/C/BrotliCompress/common/platform.h | 509 + BaseTools/Source/C/BrotliCompress/common/port.h| 107 - .../Source/C/BrotliCompress/common/transform.c | 235 + .../Source/C/BrotliCompress/common/transform.h |80 + BaseTools/Source/C/BrotliCompress/common/types.h |58 - BaseTools/Source/C/BrotliCompress/common/version.h |26 + BaseTools/Source/C/BrotliCompress/dec/bit_reader.c | 6 +- BaseTools/Source/C/BrotliCompress/dec/bit_reader.h | 162 +- BaseTools/Source/C/BrotliCompress/dec/decode.c | 1208 +- BaseTools/Source/C/BrotliCompress/dec/decode.h | 188 - BaseTools/Source/C/BrotliCompress/dec/huffman.c|59 +- BaseTools/Source/C/BrotliCompress/dec/huffman.h|24 +- BaseTools/Source/C/BrotliCompress/dec/port.h | 159 - BaseTools/Source/C/BrotliCompress/dec/prefix.h | 9 +- BaseTools/Source/C/BrotliCompress/dec/state.c |90 +- BaseTools/Source/C/BrotliCompress/dec/state.h |82 +- BaseTools/Source/C/BrotliCompress/dec/transform.h | 300 - .../C/BrotliCompress/enc/backward_references.c | 822 +- .../C/BrotliCompress/enc/backward_references.h |77 +- .../C/BrotliCompress/enc/backward_references_hq.c | 830 + .../C/BrotliCompress/enc/backward_references_hq.h |93 + .../C/BrotliCompress/enc/backward_references_inc.h |70 +- BaseTools/Source/C/BrotliCompress/enc/bit_cost.c | 4 +- BaseTools/Source/C/BrotliCompress/enc/bit_cost.h |12 +- .../C/BrotliCompress/enc/block_encoder_inc.h |13 +- .../Source/C/BrotliCompress/enc/block_splitter.c |11 +- .../Source/C/BrotliCompress/enc/block_splitter.h | 4 +- .../C/BrotliCompress/enc/block_splitter_inc.h |35 +- .../C/BrotliCompress/enc/brotli_bit_stream.c | 223 +- .../C/BrotliCompress/enc/brotli_bit_stream.h |63 +- BaseTools/Source/C/BrotliCompress/enc/cluster.c| 4 +- BaseTools/Source/C/BrotliCompress/enc/cluster.h| 4 +- .../Source/C/BrotliCompress/enc/cluster_inc.h | 2 + BaseTools/Source/C/BrotliCompress/enc/command.h|83 +- .../C/BrotliCompress/enc/compress_fragment.c | 189 +- .../C/BrotliCompress/enc/compress_fragment.h | 9 +- .../enc/compress_fragment_two_pass.c | 296 +- .../enc/compress_fragment_two_pass.h | 9 +- BaseTools/Source/C/BrotliCompress/enc/compressor.h | 161 - BaseTools/Source/C/BrotliCompress/enc/context.h| 184 - .../Source/C/BrotliCompress/enc/dictionary_hash.c | 1120 ++ .../Source/C/BrotliCompress/enc/dictionary_hash.h | 4101 + BaseTools/Source/C/BrotliCompress/enc/encode.c | 1050 +- BaseTools/Source/C/BrotliCompress/enc/encode.h | 221 - .../Source/C/BrotliCompress/enc/encode_parallel.h |27 - .../Source/C/BrotliCompress/enc/encoder_dict.c |32 + .../Source/C/BrotliCompress/enc/encoder_dict.h |41 + .../Source/C/BrotliCompress/enc/entropy_encode.c |46 +- .../Source/C/BrotliCompress/enc/entropy_encode.h |18 +- .../C/BrotliCompress/enc/entropy_encode_static.h |10 +- BaseTools/Source/C/BrotliCompress/enc/fast_log.h | 8 +- .../C/BrotliCompress/enc/find_match_length.h |22 +- BaseTools/Source/C/BrotliCompress/enc/hash.h | 732 +- .../C/BrotliCompress/enc/hash_composite_inc.h | 133 + .../BrotliCompress/enc/hash_forgetful_chain_inc.h | 145 +- .../BrotliCompress/enc/hash_longest_match64_inc.h | 266 + .../C/BrotliCompress/enc/hash_longest_match_inc.h | 229 +- .../enc/hash_longest_match_quickly_inc.h | 163 +- .../Source/C/BrotliCompress/enc/hash_rolling_inc.h | 215 +
[edk2] [patch] MdeModulePkg/HiiDB: Fix incorrect structure convention for checkbox
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1224
When covert IFR binary to EFI_IFR_CHECKBOX structure,
Current code has following incorrect code logic:
IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);
The correct one should be:
IfrCheckBox = (EFI_IFR_CHECKBOX *) IfrOpHdr;
This patch is to fix this bug.
Cc: Liming Gao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
b/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
index 45448c5198..664687796f 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c
@@ -896,11 +896,11 @@ UpdateDefaultSettingInFormPackage (
break;
case EFI_IFR_CHECKBOX_OP:
IfrScope = IfrOpHdr->Scope;
IfrQuestionType = IfrOpHdr->OpCode;
IfrQuestionHdr = (EFI_IFR_QUESTION_HEADER *) (IfrOpHdr + 1);
- IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);
+ IfrCheckBox = (EFI_IFR_CHECKBOX *) IfrOpHdr;
EfiVarStoreIndex = IsEfiVarStoreQuestion (IfrQuestionHdr,
EfiVarStoreList, EfiVarStoreNumber);
Width= sizeof (BOOLEAN);
if (EfiVarStoreIndex < EfiVarStoreNumber) {
for (Index = 0; Index < DefaultIdNumber; Index ++) {
if (DefaultIdList[Index] == EFI_HII_DEFAULT_CLASS_STANDARD) {
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Fix Type-C video
Hi Kelly,
Below comments should be removed. Other changes looks good to me.
Reviewed-by: David Wei
+
+//KES://
+//KES:// Dump MUX I2C registers
+//KES://
+//KES:MB3DumpMux ();
+
+ //
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
From: Steele, Kelly
Sent: Thursday, October 4, 2018 12:42 AM
To: edk2-devel@lists.01.org
Cc: Wei, David ; Guo, Mang
Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Fix Type-C video
>From a5d80c8322c30e09a92c0b88cdcec66ee612546f Mon Sep 17 00:00:00 2001
From: Kelly Steele mailto:kelly.ste...@intel.com>>
Date: Wed, 3 Oct 2018 09:38:36 -0700
Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Fix Type-C
video
Enabled Type-C video thru the VBT. Corrected the Type-C debug code
and removed the call to the Type-C debug code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Kelly Steele
mailto:kelly.ste...@intel.com>>
---
.../BoardInitPostMem/BoardInitMiscs.c | 5 -
.../MinnowBoard3Module/BoardInitPostMem/TypeC.c| 77 ++--
.../MinnowBoard3Module/BoardInitPostMem/TypeC.h| 133 ++---
.../Board/MinnowBoard3Module/Vbt/VbtBxtMipi.bin| Bin 5632 -> 5632 bytes
4 files changed, 130 insertions(+), 85 deletions(-)
diff --git
a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/BoardInitMiscs.c
b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/BoardInitMiscs.c
index 99e643f792..4e708e8793 100644
---
a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/BoardInitMiscs.c
+++
b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/BoardInitMiscs.c
@@ -128,11 +128,6 @@ Minnow3ModuleMultiPlatformInfoInit (
Status = Minnow3ModuleInitializeBoardOemId (PeiServices, PlatformInfoHob);
Status = Minnow3ModuleInitializeBoardSsidSvid (PeiServices, PlatformInfoHob);
- //
- // TypeC MUX AUX mode
- //
- MB3SetupTypecMuxAux ();
-
return EFI_SUCCESS;
}
diff --git
a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/TypeC.c
b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/TypeC.c
index 7b8d56ab48..12153ab6b0 100644
---
a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/TypeC.c
+++
b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3Module/BoardInitPostMem/TypeC.c
@@ -16,18 +16,20 @@
#include "TypeC.h"
static MUX_PROGRAMMING_TABLE mMB3MuxTable[] = {
- // Address RegisterData String
-
//
- {A_GENERAL, R_FIRMWARE_VERSION, MUX_TABLE_NULL, "Firmware Version
Number"},
- {A_STATUS, R_CC_STATUS_1, MUX_TABLE_NULL, "CC_Status_1"},
- {A_STATUS, R_CC_STATUS_2, MUX_TABLE_NULL, "CC_Status_2"},
- {A_STATUS, R_CC_STATUS_3, MUX_TABLE_NULL, "CC_Status_3"},
- {A_STATUS, R_MUX_HPD_ASSERT, MUX_TABLE_NULL, "MUX_In_HPD_Assertion"},
- {A_STATUS, R_MUX_STATUS, MUX_TABLE_NULL, "MUX Status"},
- {A_STATUS, R_MUX_DP_TRAINING, MUX_TABLE_NULL,
"MUX_DP_Training_Disable"},
- {A_STATUS, R_MUX_DP_AUX_INTERCEPT, MUX_TABLE_NULL,
"MUX_DP_AUX_Interception_Disable"},
- {A_STATUS, R_MUX_DP_EQ_CONFIG, MUX_TABLE_NULL,
"MUX_DP_EQ_Configuration"},
- {A_STATUS, R_MUX_DP_OUTPUT_CONFIG, MUX_TABLE_NULL,
"MUX_DP_Output_Configuration"}
+ // Address RegisterDataOrgData String
+
//==
+ {A_STATUS, R_FIRMWARE_VERSION, MUX_TABLE_NULL, 0x00,"Firmware
Version Number"}, // 0x00
+ {A_STATUS, R_CC_STATUS,MUX_TABLE_NULL, 0x00,"CC_Status"},
// 0x01
+ {A_MUX, R_CC_STATUS_1, MUX_TABLE_NULL, 0x00,"CC_Status
1"}, // 0x02
+ {A_MUX, R_CC_STATUS_2, MUX_TABLE_NULL, 0x00,"CC_Status
2"}, // 0x03
+ {A_MUX, R_CC_STATUS_3, MUX_TABLE_NULL, 0x00,"CC_Status
3"}, // 0x04
+ {A_MUX, R_MUX_STATUS, MUX_TABLE_NULL, 0x00,"MUX_Status"},
// 0x05
+ {A_MUX, R_MUX_USB_STATUS, MUX_TABLE_NULL, 0x00,"MUX USB
Status"}, // 0x06
+ {A_MUX, R_MUX_HPD_ASSERT, MUX_TABLE_NULL, 0x00,
"MUX_In_HPD_Assertion"},// 0x07
+ {A_MUX, R_MUX_DP_TRAINING, MUX_TABLE_NULL, 0x00,
"MUX_DP_Training_Disable"}, // 0x08
+ {A_MUX, R_MUX_DP_AUX_INTERCEPT, MUX_TABLE_NULL, 0x00,
"MUX_DP_AUX_Interception_Disable"}, // 0x09
+ {A_MUX, R_MUX_DP_EQ_CONFIG, MUX_TABLE_NULL, 0x00,
"MUX_DP_EQ_Configuration"}, // 0x0A
+ {A_MUX, R_MUX_DP_OUTPUT_CONFIG, MUX_TABLE_NULL, 0x00,
"MUX_DP_Output_Configuration"} // 0x0B
};
VOID
@@ -162,6 +164,7 @@ MB3ReadMux (
RetryCount = MUX_RETRY_COUNT;
do {
+
Re: [edk2] GenFds broken in latest basetools-win32
Hi, We planned to drop the support of BaseTools Python run from the freeze binary in Windows OS https://lists.01.org/pipermail/edk2-devel/2018-September/029436.html Please run BaseTools Python from source in Windows. Here is the step wiki https://github.com/tianocore/tianocore.github.io/wiki/Windows-systems Compile Tools section. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kurt Kennett Sent: Tuesday, October 2, 2018 4:55 AM To: edk2-devel@lists.01.org Subject: [edk2] GenFds broken in latest basetools-win32 "genfds" seems broken in latest tiano-win32 Can anybody else repo this: C:\repo\tiano-win32>genfds Traceback (most recent call last): File "C:\Python27\lib\site-packages\cx_Freeze\initscripts\Console.py", line 27, in File "GenFds\GenFds.py", line 24, in ValueError: Attempted relative import in non-package K2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [RFC] Create new edk2-test repo
Supreeth, I have created the edk2-test repository with the Readme.md, License.txt, and Contributions.txt files. I have also created the "EDK II Test Maintainers" team for developers that are maintainers of the test infrastructure and test cases in this repository. Best regards, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Supreeth Venkatesh > Sent: Friday, October 5, 2018 9:53 AM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Dong Wei ; Jin, Eric > > Subject: Re: [edk2] [RFC] Create new edk2-test repo > > Thanks Mike. I second that. > Also, UEFI-SCT needs to find a place within edk2-test. > Hope we can get this created before UEFI Taipei PlugFest > (Oct 16) and after everyone's comments/review and > approval. > > Thanks, > Supreeth > > -Original Message- > From: edk2-devel On > Behalf Of Kinney, Michael D > Sent: Tuesday, September 25, 2018 6:34 PM > To: edk2-devel@lists.01.org; Kinney, Michael D > > Subject: [edk2] [RFC] Create new edk2-test repo > > This is a proposal to create a new repository for tests > called edk2-test. > > The purpose of this repository is to provide test > harnesses and test cases to test EDK II based firmware. > > There is test related content in edk2-staging branches > and as that content is completed, a location for tests > is required. This will provide core and platform > developers the ability to test changes before commits > are made and also provide a place to add new test cases > for new features and functionality. > > Thanks, > > Mike > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any > attachments are confidential and may also be privileged. > If you are not the intended recipient, please notify the > sender immediately and do not disclose the contents to > any other person, use it for any purpose, or store or > copy the information in any medium. Thank you. > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
